Commit Graph

132 Commits

Author SHA1 Message Date
Rishabh Saxena
e944d005c1
fix: fixes related to switch branches (#8864) 2021-11-02 07:33:12 +00:00
balajisoundar
1b596be6f5
chore: Fix misc admin settings issues (#8838) 2021-10-28 10:17:02 +05:30
Rafael Baldasso Audibert
0e22f26621
fix: Change "Allow Horizontal Scroll" text to "Allow scroll" (#8085)
* chore: Change "Allow Horizontal Scroll" to "Allow Scroll"

* chore: Hide option to choose scroll for pie chart

* fix: Fix prettier errors

* feat: Add migration to allowScroll for `CHART_WIDGET`s

Closes #4227

* fix: Fix chart widget prop recursively

Per https://github.com/appsmithorg/appsmith/pull/8085#discussion_r733442011
Closes #4227
2021-10-25 17:09:39 +05:30
Hetu Nandu
2c3a0991f7
feat: setInterval and clearInterval support (#8158) 2021-10-11 12:55:03 +00:00
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
Apeksha Bhosale
7665ff3c4f
fix: small fixes js editor (#8022)
* remove space below response

* changes to name editor

* removing variable as dynamic binding path list

* error message change for js object
2021-10-04 16:38:02 +05:30
arunvjn
d67165f8bb
fix: for in null check sentry bug (#8150) 2021-10-04 15:11:25 +05:30
Vinod
d9b4685192
Introduce linting to all users (#7736)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-10-04 12:11:02 +05:30
Trisha Anand
c84844e905
Fix for generating action from datasource structure (#7778) 2021-09-24 12:17:36 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
Nidhi
688b75af22
Changes to introduce peader prefix in API key authentication type (#7742) 2021-09-23 13:20:44 +05:30
arunvjn
3cd93e11a7
feat: snippets discoverablity (#7689) 2021-09-22 16:59:47 +00:00
Nidhi
c3f4cdaa15
feat: Introducing SaaS integrations as a plugin (#7560)
* WIP client side changes

* Saas execution flow + scheduled import of remote plugins
2021-09-21 17:35:29 +05:30
Nayan
1296faef8e
feat: [Feature] Use photo asset id instead of email address for profile picture in comments (#7434)
* -set user photo id when adding a new comment thread

* -update user data when users remove their profile photo

* -updated photo id in comments when user changes or set a profile photo

* -remove photoid from thread, kept it in comment only

* -resized uploaded profile image

* -added test for delete profile photo

* -add test for the comment set user photo

* -check user change event handler is called in delete user photo

* -add test for checking user photo change event is triggered after upload photo

* -fixed tests due to changes

* -make profile pictures thumbnail only

* - used get photo by asset id API to show user photo in comment card
- set cache control header in get asset by id API

* - stop using email address to show user photo
2021-09-20 15:03:39 +06:00
Rishabh Saxena
819f0c2753
feat: add git config to user profile settings (#7538) 2021-09-17 16:18:38 +05:30
Rishabh Saxena
f277fe92e0
feat: minor bottom bar UI updates (#7456) 2021-09-15 19:31:32 +05:30
akash-codemonk
e9fe54fefe
fix: Show trigger errors in the debugger with widget and property name (#6970) 2021-09-15 10:41:13 +05:30
Abhinav Jha
b49f5097c6
refactor: Widget Development API (#6405) 2021-09-09 20:40:22 +05:30
Apeksha Bhosale
09eea59330
feat: JS Editor (#6003)
* Changes to add js plugin

* routes+reducer+create template

* added debugger to js editor page

* entity explorer changes

* create js function

* added copy, move and delete action

* added js plugin

* added existing js functions to data tree

* removed actionconfig for js collection

* new js function added to data tree and entity as well

* parsing flow added

* changes to data tree

* parse and update js functions

* small changes for def creator for js action

* create delete modified

* small changes for update

* update flow change

* entity properties added

* removed linting errors

* small changes in entity explorer

* changes for update

* move, copy implementation

* conflict resolved

* changes for dependecy map creation

* Only make the variables the binding paths

* Basic eval sync working

* Minor fixes

* removed unwanted code

* entity props and autocomplete

* saving in progress show

* redirection fix after delete js action

* removed unnecessary line

* Fixing merge conflict

* added sample body

* removed dummy data and added plugin Type

* few PR comments fixed

* automplete fix

* few more PR comments fix

* PR commnets fix

* move and copy api change

* js colleciton name refactor & 'move to page' changes & search

* view changes

* autocomplete added for js collections

* removing till async is implemented

* small changes

* separate js pane response view

* Executing functions

* js collection to js objects

* entity explorer issue and resolve action on page switch

* removed unused line

* small color fix

* js file icon added

* added js action to property pane

* Property pane changes for actions

* property pane changes for js functions

* showing syntax error for now

* actions sorted in response tab

* added js objects to slash and recent entitties

* enabling this to be used inside of function

* eval fix

* feature flag changes for entity explorer and property pane

* debugger changes

* copy bug fix

* small changes for eval

* debugger bug fix

* chnaged any to specific types

* error in console fix

* icons update

* fixed test case

* test case fix

* non empty check for functions

* evaluate test case fix

* added new icons

* text change

* updated time for debounce for trial

* after release mereg

* changed icon

* after merge

* PR comments simple

* fixed PR comments - redux form, settings remove

* js object interface changes

* name refactor

* export default change

* delete resolve actions chnage

* after merge

* adding execute fn as 3rd option and removed create new js function

* issue 7054 fixed - app crash

* execute function on response tab changes

* refactor function name part 1

* refactor of js function name

* try catch added refactor

* test fix

* not used line removed

* test cases locator fixed

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-09-08 23:02:22 +05:30
Nidhi
a7239cfa5b
feat: Changes to add js plugin (#4861)
Adds server side changes for supporting JS editor
2021-09-08 19:17:30 +05:30
Rishabh Saxena
685aa3b98c
feat: make comments publicly available (#7143) 2021-09-06 18:04:40 +05:30
Bhavin K
74cba639ae
feat: on chart widget set adaptive y-axis based on data (#6310)
* enhancement on chart props

* updates as required

* changed data for chart widget

* fixed build issue

* improve code

* update text

* Update propertyConfig.ts

* changed helpText

Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2021-09-06 17:45:58 +05:30
Rishabh Saxena
a2b38c86eb
feat: init bottom bar skeleton, add feature flag for git (#7105) 2021-09-06 14:59:35 +05:30
Tolulope Adetula
742f0cf1ec
feat: compact mode in property pane (#6637)
* fix: compact mode

* fix: test

* fix: remove row height visibility

* fix: options label for compactMode

* feat: Add test

* Fix: failing test

* fix: test

* fix: test case.

* fix failing test

* fix: move position of rowHeight prop in property pane
2021-09-06 00:05:51 -07:00
rashmi rai
c0748e5d5a
fixed missing toast (#7124)
Co-authored-by: rashmi rai <rashmirai@appsmith.com>
2021-09-06 11:23:21 +05:30
Tolulope Adetula
45fad5e094
Feat: Table Widget: icon button as a new column type (#6598)
* feat: add icon button properties to property pane
* feat: add icon button styles to property pane
2021-09-01 15:20:23 +05:30
Hetu Nandu
3380227cbb
feat: Enable Promises in Appsmith (#6253) 2021-08-27 14:55:28 +05:30
Pranav Kanade
a1ba69adfc
feat: draggable comment pins (#6742)
* made inline comment pins draggable and added wrapper around overlay comments wrapper

* moved drag hook to pin

* can drag on canvas

* Properly updating the thread to be able to properly move the pin

* always passing the ref to container

* updating BE to save the new pins position

* minor fix

* changed a file name

* minor improvement to fix unit test

* fix, updated dragging reducer function to not expect appId

* removing unrelated change

* added drag and drop for comment pins without react dnd

* updated unit tests

* minor fix

* added a grab pointer and minor offset when user moves the pin

* removed unnecessary store states

* moved drop from onDragEnd to onDrop to reset everything.

* using state selector and dispatch hook

* removed use of anchor widget

* removed pointer change from comments wrapper

* verifying if current pin is being dragged

* updated action creator name

* moved dragging in comments reducer.

* using dragging thread id from store itself

* using relative positioning of pointer to predict the location of pin

* unit test cases fixed

* minor fix

* removed the dependency of off set from callback
2021-08-27 14:27:18 +05:30
Pranav Kanade
f65ef8ddf3
feat: add multiplayer feature flag (#6888)
* updated feature flag to type

* added feature flag dependency for pointer sharing and editor listing features
2021-08-26 12:26:13 +05:30
Vinod
9f3a24fbb0
feat: show lint errors in code editor (#6265) 2021-08-26 10:15:17 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
Favour Ohanekwu
aca5bd78b1
fix: inclusion of authorization error for Google sheets (#6674)
* Added authorisation status to Google sheet datasource form
2021-08-25 11:36:55 +01:00
Pawan Kumar
960159eef3
Grouping widgets into container (#5704)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* add icon for grouping

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* add container on copy

* add analytics middleware

* refactor paste widget saga

* change flash element to accept array + revert refactor

* add logic to create containers from selected widgets

* update positions of grouped widgets

* fix comments + remove console

* update flashElementbyId to flashElementsById

* remove analytics middleware + remove unecessary imports

* add shorcut for grouping

* fix position issue when pasting

* allow grouping only when multi widgets are selected

* fix ux issues with widget grouping

* fix help text for grouping actions

* filter out the modal widget when calculting next row

* fix delete issue when grouping

* persist positin when grouping if there is no collision

* fix typo for new position

* changes for review comments

* changes for review comments

* fix position issue when pasting

* fix new container position issue

* move utils function to utils

* fix import issue

* fix the composite widget grouping issue

* fix table name bug

* remove repeated code

* move copied groups existence check;

* fix copied group check

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-25 10:30:31 +05:30
akash-codemonk
bb1c5ab9a3
Send errorType as part of analytics payload for action execution errors (#6754) 2021-08-23 19:17:17 +05:30
Ayush Pahwa
b1d003fdba
Added new type to the ActionConfig, fixed some typos (#6748) 2021-08-23 13:04:44 +05:30
Yash Vibhandik
158a71acab
FIX #3123 : added custom csvSeparator property in table widget for csv download (#6291) 2021-08-18 16:03:26 +05:30
Rishabh Saxena
a1daa7e3f8
Handle deletion for comments and threads in realtime (#6605) 2021-08-18 12:51:21 +05:30
Tolulope Adetula
b6f9aef70a
feat: Add isDisabled to Button column and isVisible to all Table widget Column settings (#4819) 2021-08-17 18:24:43 +05:30
ashit-rath
f904e4bffe
Fix: Widget: 'value' of null errors (#6535)
* validations: array - fixed default value, array object - fixed object index error message computation

* improved validation config

* minor test case additions
2021-08-17 11:35:51 +00:00
akash-codemonk
8e08e778d4
Update debugger error message CTA's (#6416) 2021-08-16 16:33:27 +05:30
Tolulope Adetula
38e1d660ef
fix: table column order and isVisible (#6521)
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh
2021-08-11 19:32:14 +05:30
Pranav Kanade
2ae0c8c836
Feature: Show a list of realtime app editors (#6286)
* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list
2021-08-09 14:34:24 +05:30
Rishabh Saxena
e4255f6773
Minor fixes for comments on the modal widget (#6368) 2021-08-06 14:47:56 +05:30
Rishabh Saxena
f0bf799b67
Use feature flag api to enable/disable comments (#6322) 2021-08-05 11:40:19 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
Abhinav Jha
cd8407152c
Missing validations (#6281)
* Fix validations for certain scenarios which were missed earlier
2021-08-02 12:53:46 +05:30
Rishabh Saxena
f4018f450e
Comments feature related fixes (#6156) 2021-07-28 12:32:11 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Rishabh Saxena
25a6fd2240
Fixes related to the comments feature (#5904) 2021-07-19 20:58:41 +05:30
Rishabh Saxena
8f7165b5fe
Update comments onboarding tour (#5903) 2021-07-16 14:01:26 +05:30