Commit Graph

11561 Commits

Author SHA1 Message Date
Shrikant Sharat Kandula
e7b2e2392b
Fix NPE on reset password, and message formats (#18108)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-06 08:37:41 +05:30
Appsmith Bot
ef5ee9c504 Update top contributors 2022-12-06 06:58:09 +05:30
Nidhi
166414b6d6
chore: Improved metadata on logs when reading DSL fails (#18692)
* chore: Improved metadata on logs when reading DSL fails

* Fixed test

* Test fix

* Review comment
2022-12-05 22:35:44 +03:00
sneha122
93fe30674f
fix: datasource autosave git issue fixed (#18690)
* datasource autosave git issue fixed

* Added appropriate comments

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-05 20:39:19 +05:30
Abhinav Jha
836af41be1
fix: Auto height breaks for fixed modal's children (#18691)
Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically
2022-12-05 20:24:45 +05:30
Goutham Pratapa
fee9b181fe
chore: fix ingress fieldname in appsmith (#18684) 2022-12-05 17:14:17 +05:30
Nilansh Bansal
ebadab572b
feat: Adding Embedding Apps Functionality in the API (#18566) 2022-12-05 15:49:37 +05:30
Shrikant Sharat Kandula
2198ed4c61
chore: Support using custom port(s) for listening in the start-https.sh script (#18451)
Added `--https-port` and `--http-port`, so you can set a custom port instead of the default 80 and 443. This is useful if you want to test Appsmith when using a non-standard port, fox example, how `appsmith.URL.host` behaves, or how OAuth redirects behave etc.

We also add a shortcut to start this with release endpoint. Just using `release` is now the same thing as using `https://release.app.appsmith.com`. This is useful to people like me who are _very_ good with typos.
2022-12-05 13:34:30 +05:30
Anagh Hegde
f70ad56fae
chore: Remove debugging logs for analytics (#18662) 2022-12-05 11:29:25 +05:30
akash-codemonk
3eab587368
feat: [Context Switching] Maintain datasource collapse state (#17616) 2022-12-05 11:28:17 +05:30
Ankita Kinger
f52a55632d
fix: Updating spec for member roles (#18657)
updated spec for member roles
2022-12-05 10:52:38 +05:30
Arsalan Yaldram
8b06621601
fix: Added support for country code flags on windows devices (#18203)
* fix: add pollyfill and use font family.

* fix: use latest version design system.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:43:21 +05:30
Arsalan Yaldram
3364bfd1a6
chore: dependentbot vulnerabilities. (#18528)
* fix: dependentbot vulnerabilities.

* chore: remove emoji-mart.

* chore: updated react-syntax-highlighter

* chore: update ts-loader add loader-utils resolution.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:37:51 +05:30
Appsmith Bot
ab62a1f225 Update top contributors 2022-12-05 06:58:28 +05:30
Sangeeth Sivan
6c498bcbf5
fix: datasource title not editable and ctas disabled on create (#18645)
fix: datasource title not editable on create flow, delete save ctas disabled on rest/graphql form
2022-12-04 20:49:01 +05:30
Ankita Kinger
b7d00d2498
feat: Adding an upgrade page for Access control (#18554)
* updated content for access control upgrade page

* added feature flag and moved content to message constants

* adding feature flag for RBAC

* updated some styles

* added a missing comma

* removed width on trigger details container

* updated some styles
2022-12-04 20:12:35 +05:30
NandanAnantharamu
8c6dccb6b4
Test : DH regression test automation (#18436)
* updated tab test

* updated tests

* Added some more scenarios

* updated valdations for presence of Height property under general

* Added tests for list

* Updated tests
2022-12-03 21:43:10 +05:30
Arsalan Yaldram
b41606e2b7
fix: center align select widgets and RTE widget labels. (#18378)
* fix: center align select and RTE labels.

* feat: added label tooltips to select widgets.

* fix: added center label alignment to datepicker.
2022-12-03 17:28:02 +05:30
Ayangade Adeoluwa
cb82b299b1
fix: datasource switching issue for Google sheets (#18397)
* Fix datasource switching issue for Goole sheets

* Fix failing vercel deployments
2022-12-03 15:25:42 +05:30
Appsmith Bot
f9dc5719fa Update top contributors 2022-12-03 06:58:07 +05:30
Rishabh Rathod
c440343586
chore: perf data tree shrink (#18361)
trimming dataTree object size by removing configs to make evaluation faster.
2022-12-02 18:15:11 +05:30
akash-codemonk
ced3b413c3
chore: comment out flaky assertion (#18640) 2022-12-02 18:14:43 +05:30
Sangeeth Sivan
85db5cc965
fix: update permission driven ctas to handle auto save update changes (#18609) 2022-12-02 18:05:18 +05:30
Trisha Anand
74dddd4701
fix: Add user permission in the response for update datasource api (#18629) 2022-12-02 13:40:57 +05:30
Trisha Anand
4345e29dc5
fix: If the user has delete permission on the workspace, allow the user to delete the workspace and also delete the default roles (without permission) (#18615) 2022-12-02 13:39:04 +05:30
Hetu Nandu
bf07e141f4
chore: Update NavigateTo tests to verify params (#18581) 2022-12-02 11:57:03 +05:30
Anand Srinivasan
c01ed28189
feat: New settings pane (#16361) 2022-12-02 11:19:51 +05:30
Apeksha Bhosale
42900c022f
fix: Reduces cloning by not adding platform functions (#18433)
reduces cloning
2022-12-02 11:13:39 +05:30
akash-codemonk
89bf555727
feat: [ Context Switching ] Maintain datasource edit mode (#17521) 2022-12-02 08:36:22 +05:30
Appsmith Bot
8c11af690f Update top contributors 2022-12-02 06:58:23 +05:30
Sangeeth Sivan
3e8414b4e0
fix: page list item icons aren't permission driven on first load (#18586)
* fix: page list ctas permission driven fix

* fix: page list and page context menu , datasource action pane create permission driven

* fix: check manage permission on page aswell for cloning

* fix: duplicate & fork app permission driven

* fix: onclick triggers on disabled icons
2022-12-02 02:56:21 +05:30
Tolulope Adetula
058500704e
fix: multiselect crashing (#18577) 2022-12-02 00:36:49 +05:30
Nilesh Sarupriya
68bb871fa8
chore: add events related to roles and groups (#18611) 2022-12-01 20:53:30 +05:30
Trisha Anand
a7f1f365af
Revert "ci:update env variable" (#18607)
Revert "ci:update env variable (#18557)"

This reverts commit e0fe306503.
2022-12-01 16:08:02 +05:30
Parthvi
e0fe306503
ci:update env variable (#18557)
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-01 13:47:11 +05:30
Ankita Kinger
6ea8e2549f
feat: Handle permission driven views for auto-saving pages and action… (#16950)
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 12:00:50 +05:30
balajisoundar
c0ce62f6b9
fix: miscellaneous issues in table widgets (#18127)
- Retain filter in table widget when table data changes but schema remain same
- Cursor jumps to start while editing a cell in Table Widget
- Save/Discard option should not be in the filter dropdown list.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 10:54:48 +05:30
Dhruvik Neharia
1a7b4c6725
feat: Dynamic Menu Items - Menu Button Widget (#17652)
* faet: Add menu items source for menu widget

* feat: Add configuration panel for dynamic menu items

* feat: Pass down items from sourceData to menu items widget

* feat: Take menu items config from property pane for dynamic menu items

* fix: Change all onMenuItemClick to onClick for dynamic menu items

* feat: Create MenuComputeValue property control to add support for {{currentItem}} binding in menu widget

* feat: Add JS toggles for style properties for menu widget

* feat: onClick now supports currentItem for menu button widget

* feat: Add currentItem autocomplete, move property pane config to separate files for menu button widget

* feat: WIP - Add Dynamic Menu Items for Table Widget

* Revert "feat: WIP - Add Dynamic Menu Items for Table Widget"

This reverts commit 271f96211c8612bc6f073a1aab7467993b9d7e36.

* fix: remove current item label by default for dynamic menu items in menu button

* feat: Add source data max length 10 validation for dynamic menu items in menu button

* feat: Add migrations for Dynamic Menu Items for Menu Button Widget

* feat: Add cypress test for dynamic menu items for menu button

* test: Update DSLMigration test with menu button widget tests

* fix: Update MenuButtonWidget migration

* fix: DSL migrations for menu button dynmaic items

* fix: Style validations for menu widget

* feat: Add more descriptive help text for configure menu items in menu button widget

* feat: Change menu items source property type from dropdown to icon tabs

* fix: Cy test for menu button widget to select menu items source from button tabs instead of dropdown

* feat: Make ConfigureMenuItemsControl a Generic/reusable OpenNextPanelWithButtonControl

* refactor: Change MenuComputeValue to MenuButtonDynamicItemsControl

* refactor: Merge TABLE_PROPERTY and MENU_PROPERTY into one ARRAY_AND_ANY_PROPERTY

* fix: Don't polute Menu Button DSL with properties for dynamic menu items until the source is static

* style: Change color of curly braces hint in currentItem autocomplete to make it more readable

* fix: remove unused import

* refactor: Move child config panels to a different file, style: Change help text and placeholder for a few properties for Dynamic menu items - menu button

* refactor: Change event autocomplete function name, use fast equal

* refactor: Change source data validation function name and use camelCase throughout

* refactor: Validation function for source data

* refactor: Create different type for menuItems and configureMenuItems and reuse them property config

* feat: refactor: move get items to widget instead of component

* pref: Visible items to be calculated when menu button is clicked

* refactor: replace !("menuItemsSource" in child) with in migration

* refactor: Change controlType name from OPEN_NEXT_PANEL_WITH_BUTTON to OPEN_CONFIG_PANEL, use generic names inside OpenNextPanelWithButtonControl.tsx

* refactor: Minor cleanup at MenuButtonDynamicItemsControl.tsx

* refactor: Minor cleanup at MenuButtonDynamicItemsControl.tsx

* fix: Change constant used in migration to a static value

* test: Add tests for validations and helper for menu button

* test: Add more Cypress tests for dynamic-menu-items

* fix: Minor refactor at onclick handler and MenuButtonDynamicItemsControl

* refactor: Rename ARRAY_AND_ANY_PROPERTY to ARRAY_TYPE_OR_TYPE

* feat: Move initial source data and keys generation inside an update hook

* refactor: Rename ARRAY_TYPE_OR_TYPE to ARRAY_OF_TYPE_OR_TYPE

* refactor: Minor code refactor in MenuButtonWidget/widget/index.tsx

* refactor: Change OpenNextPanelWithButtonControl with OpenConfigPanelControl

* feat: Use traverseDSLAndMigrate for dynamic menu items migration

* style: Minor code hygiene changes here and there for dynamic menu items

* style: Minor code hygiene changes here and there for dynamic menu items

* style: remove any type for visible items inside dynamic menu items

* refactor: Change type MenuItems to MenuItem

* feat: Add support for dynamic menu items (menu button) inside list widget

* fix: updateMenuItemsSource hook not working when changing from DYNAMIC to STATIC menu items source

* fix: Avoid empty icon name from rendering inside button and menu item

* style: Fix a couple of code callouts

* fix: Update import from TernServer to CodemirrorTernService

* style: fix minor code callouts here and there

* fix: Add check for configureMenuItems.config

* fix: Add wait time after addOption click for DynamicHeight_Auto_Height_spec.js

* fix: Increase the wait time for DynamicHeight_Auto_Height_spec.js to 200ms

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 10:25:57 +05:30
Appsmith Bot
3d5ff9e403 Update top contributors 2022-12-01 06:59:17 +05:30
arunvjn
1f1840aeff
feat: Enable fetch API (#17832) 2022-12-01 03:28:58 +05:30
Parthvi
a277568d33
test: fix merge_spec.js cypress test (#18587) 2022-11-30 22:21:24 +05:30
Ankita Kinger
3c546db6dd
chore: Adding additional optional props to editable text component (#18542)
adding additional optional props to editable text component
2022-11-30 18:11:34 +05:30
yatinappsmith
45009d0e63
ci: fix-fat-failedspec (#18571) 2022-11-30 16:10:24 +05:30
Ravi Kumar Prasad
ca2e8f8e23
fix: geolocation api callbacks are not called (#18235)
* fix: geolocation api callbacks are not called

The success and error callbacks are not being called. The code was absent.

fixes #11147

* Add comment

* Fix error callback not being called when location is turned off

* Fixes #9852 incorrect error handling on watchPosition

* Fix unit test

* fix unit tests
2022-11-30 16:08:15 +05:30
ankurrsinghal
0de6643922
fix: auto height limits container select (#18546)
* fixed the issue of parent container select while changing the auto height with limits by adding one more check in the clickToSelectWidget hook

* added a unit test to test shouldWidgetIgnoreClicksSelector based on whether we are changing the auto height with limits

* fixed the failing tests

Co-authored-by: Ankur Singhal <ankurrsinghal@gmail.com>
2022-11-30 13:02:36 +05:30
ankurrsinghal
11dfa2c8e1
fix: flicker issue when both the min max values collide (#18547) 2022-11-30 12:52:44 +05:30
Hetu Nandu
04ed5329a1
fix: Appsmith version update dialog showing up when no version is set (#18530)
Confirm an version number exists before checking for its match from server
2022-11-30 11:50:27 +05:30
sneha122
b5902bf035
feat: Datasource autosave improvements (#17649)
* Datasource autosave improvements WIP

* authenticated API and ds name updates

* popup updates, api to datasource updates

* issue fixes for new ds in new workspace

* formatter issue fixed

* console warning issue fixed

* refresh edge case handled for temp ds

* DS creation cypress update

* datasource improvements issue fixes

* CreateDS flow change cypress update

* reconnect issue fixed

* added space

* Create Ds related script updates

* SaveDs changes updated

* DatasourceForm_spec.js fix

* GoogleSheetsQuery_spec.js - still spec will fail

* GoogleSheetsStub_spec.ts fix

* MongoDatasource_spec.js fix

* ElasticSearchDatasource_spec.js fix

* AuthenticatedApiDatasource_spec.js

* RestApiDatasource_spec.js - will stil fail

* RedshiftDataSourceStub_spec.js fix

* issue fixes for datasource autosave

* save as datasource issue fixed

* SKipped - Bug 18035

* MySQL spec fix

* PostgresDatasource_spec.js fix

* MySQLDataSourceStub_spec.js fix

* MsSQLDataSourceStub_spec.js fix

* Bug16702_Spec.ts fix

* SwitchDatasource_spec.js fix

* ArangoDataSourceStub_spec.js fix

* code review changes, save and authorise issue fixed

* cypress test issue and cypress tests fixed

* client build failure issue fixed

* test failure fixes

* ReconnectDatasource_spec.js fix

* Entity_Explorer_CopyQuery_RenameDatasource_spec.js fix

* GitImport_spec.js fix

* Index add

* undo redo test issue fixed

* fixed cypress tests of rest api ds

* globalsearch_spec.js fixed

* code review changes

* code review comments addressed

* ds schema cypress issue fixed

* cypress test updates

* fix updateDatasource path

* rest api cypress test fixed

* cypress code review changes

* Removing few random .only's

* replay editor fix

* indexed

* adding .skip

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-11-30 11:29:45 +05:30
Nikhil Nandagopal
74fed1bcdc Updated Label Config 2022-11-30 11:24:33 +05:30
Arsalan Yaldram
92d0f4d14d
fix: text font size for text widget inside modal & statbox. (#18236)
fix: match font sizes for the text widgets inside modal, statbox to property pane values.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-11-30 11:09:58 +05:30