Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
4,852 Commits 1 Branch 0 Tags 507 MiB
e6a0b00a25
Commit Graph

3450 Commits

Author SHA1 Message Date
Trisha Anand
e5c44168f3
Configured pool size for hikariCP when new pool comes uo. (#2170) 2020-12-14 11:07:53 +05:30
dependabot[bot]
17e8725a84
Bump ini from 1.3.5 to 1.3.8 in /app/client (#2176) 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-13 11:10:46 +05:30
Arpit Mohan
7ae4959c29 Correcting the if clause for environment variable 2020-12-12 22:03:03 +05:30
Arpit Mohan
372774e728 Checking if the new run command works in Github Action 2020-12-12 20:48:21 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Piyush Mishra
2a05df86c7
Hotfix crash on navigate to API page after widget rename (#2134) 2020-12-11 18:04:06 +05:30
Arpit Mohan
75b3f18a92 Correcting github actions yaml. 
Really need a validator for this
 2020-12-11 17:41:39 +05:30
Arpit Mohan
7fbd14228d Correcting the node_modules cache for Cypress tests 2020-12-11 17:39:10 +05:30
prapullac
b27a32940e
Manual Test Ideas (#2129) 2020-12-11 17:25:54 +05:30
Arpit Mohan
51757072de Ignoring manual cypress tests during build 
Also correcting the node_modules cache during yarn install
 2020-12-11 17:10:05 +05:30
Nidhi
9a9feff678
Reset execute on page load for new actions (copied or otherwise) (#2162) 2020-12-11 14:33:07 +05:30
Arpit Mohan
b517639bd0 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-12-11 13:11:11 +05:30
Arpit Mohan
2951c609ec Correcting the APP_HOST in netlify for deploy previews 2020-12-11 13:10:55 +05:30
devrk96
7475aa643a
Fix: Org logo upload redux state (#2068) 2020-12-11 12:31:13 +05:30
Trisha Anand
74342f8598
Adding hikariCP for postgres (#2130) 2020-12-10 21:08:02 +05:30
Arpit Mohan
85d958c2c0
[CodeFactor] Apply automated fixes (#2131) 
Co-authored-by: codefactor-io <support@codefactor.io>
 2020-12-10 18:44:31 +05:30
Arpit Mohan
c1de6ce8f7 Fixing prettier errors in DynamicBindingUtils 2020-12-10 17:22:18 +05:30
Piyush Mishra
580c261e5d
copy tab data before mutating (#2084) 2020-12-10 14:21:54 +05:30
Hetu Nandu
f312320940
Remove unsafe functions from eval (#2076) 2020-12-10 14:00:49 +05:30
Pawan Kumar
5553da02e8
Fix: Page crashes on cloning the API (#2087) 
* fixed the page crashig on cloning the api

* adding test cases

* comment out the drag and drop test case in input spec

* update test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-10 13:52:40 +05:30
devrk96
8ef7405421
Fix: User icon numbers on home page (#2070) 2020-12-10 13:37:48 +05:30
devrk96
2995410d27
Fixing text overflow word-break property fixed. (#2116) 2020-12-10 13:36:13 +05:30
Rishabh Saxena
d7dea9aff4
fix toast message on widget cut (#2059) 
* fix toast message on widget cut

* show msg when widget not selected during cut/copy
 2020-12-10 13:03:43 +05:30
Piyush Mishra
0e47c0a4c0
Fix brackets mismatch (#2019) 2020-12-10 11:48:59 +05:30
Nikhil Nandagopal
9b51bf9af2
Merge pull request #2109 from appsmithorg/fix/boolean-validation 
Fix for false evaluated value showing as null
 2020-12-10 11:27:52 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
NandanAnantharamu
9fb99c1145
Added tests for Table binding with Input Widget (#1955) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-12-10 10:52:19 +05:30
Hetu Nandu
74f8b51db3 Fix for false evaluated value showing as null 2020-12-09 22:25:59 +05:30
Trisha Anand
e97915c0a1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-12-09 19:17:22 +05:30
Trisha Anand
746b0ab58e Changed log to sout in postgres plugin 2020-12-09 19:16:54 +05:30
Nikhil Nandagopal
8864a1eca2
Merge pull request #2101 from appsmithorg/fix/sentry-errors 
added code to prune payloads from sentry actions and reduce depth of …
 2020-12-09 19:11:34 +05:30
Trisha Anand
888d79b06d Removing printing of result objects from plugin execution. 2020-12-09 19:03:51 +05:30
Nikhil Nandagopal
d228f6d117 fix for undefined access to crash field 2020-12-09 18:22:36 +05:30
Nikhil Nandagopal
7d70a71d70 added code to prune payloads from sentry actions and reduce depth of actions reported 2020-12-09 14:42:12 +05:30
Nikhil Nandagopal
854d514359
Merge pull request #2094 from appsmithorg/fix/sentry-errors 
Prune expensive redux actions and console logs from sentry
 2020-12-09 13:06:54 +05:30
devrk96
fba79f960b
App icon and color name change issue resolved (#2089) 2020-12-09 12:36:02 +05:30
Nikhil Nandagopal
67fc762968 Merge branch 'release' into fix/sentry-errors 
# Conflicts:
#	app/client/src/sagas/ErrorSagas.tsx
 2020-12-09 12:34:08 +05:30
Nikhil Nandagopal
0fc5817caa added a check for errors without payloads 2020-12-09 12:32:27 +05:30
Nikhil Nandagopal
e0ac6e9850 Allowed console errors to still be logged 2020-12-09 11:59:40 +05:30
Nikhil Nandagopal
cfa020c063 pruned expensive redux actions and console logs from sentry 2020-12-09 11:50:39 +05:30
Rishabh Saxena
6a3b3c7cb8
treat false str as falsy for env vars (#2055) 
* check boolean env values against  string

* refactor parseConfig

* consistent bools

* return true/false for those strings
 2020-12-09 11:22:50 +05:30
Hetu Nandu
04e963c599
Fix for 502 errors from the server (#1949) 2020-12-09 00:43:48 +05:30
NandanAnantharamu
ec7149f9d8
Test case for creating multiple apps (#1871) 
* Added test for #1716

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-08 23:47:34 +05:30
Trisha Anand
8283396056
Moved from boundedElastic to elastic to ensure that the server services the plugin execution request as soon as the request arrives. (#2090) 2020-12-08 22:04:14 +05:30
Sumit Kumar
db3636f7b0
mysql plugin - check if connection is stale before running query (#2080) 
1. Check if mysql plugin connection is stale. If so, then return stale connection exception which triggers a retry after 
    establishing a new connection.
2. Refactor execute method code to remove code duplication.
3. Add a new test case to check if stale connection gets detected.
 2020-12-08 21:03:31 +05:30
Shrikant Sharat Kandula
4d24c8614f
Set random icons and colors for apps that are missing them (#2083) 2020-12-08 15:41:40 +05:30
Pawan Kumar
f8fd19d026
fix alignment of api editor response view (#2002) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-08 14:54:36 +05:30
Pawan Kumar
c67ada9a24
Fix/updating datasources does not update sidebar (#2018) 
* add check for datasources in memo equality check

* add test cases

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-08 14:54:02 +05:30
vicky-primathon
19d6ad695e
Table column max width limit removed (#2077) 2020-12-08 12:25:30 +05:30
Nikhil Nandagopal
0c1d914c38
Merge pull request #2064 from appsmithorg/fix/sentry-errors 
[Fix] reduced depth of information shared via sentry to prevent 413 errors
 2020-12-07 20:01:25 +05:30
Nikhil Nandagopal
03053d40c3 reduced depth of information shared to allow error sharing 2020-12-07 19:54:51 +05:30
Arpit Mohan
9d7a9d4aaf
Modifying the text for the roles in the share modal (#2045) 2020-12-07 16:16:43 +05:30
Pawan Kumar
e4b28172a7
add ellipsis in button (#2031) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-07 12:48:53 +05:30
devrk96
6cd44a5b84
Fix: Application name update checks (#1710) 2020-12-07 12:22:49 +05:30
devrk96
b7d77e15f1
Feature: New app icons and color palette (#2026) 2020-12-07 12:21:13 +05:30
Piyush Mishra
9ec030e101
null check for errors forEach(#2030) 2020-12-07 11:15:14 +05:30
Trisha Anand
b8b24604a6
[Bug] Update of an action leads to userSetOnLoad getting reset. (#2023) 
* Update of an action leads to userSetOnLoad getting reset.

* Added test case to assert the same.
 2020-12-04 13:07:34 +05:30
Sumit Kumar
b6abb8b067
Encode request body in Rest API plugin (#1988) 
1. Encode request body in REST API plugin when content header for URL encode is set.
2. Add a test case to test the encoding function.
3. Add a test case to check non-encoding (raw) function.
 2020-12-04 11:39:15 +05:30
Shrikant Sharat Kandula
4a57a739b6
Render templates directly without Mustache (#2010) 
* Render templates directly without Mustache

* Remove an unused variable
 2020-12-03 14:38:31 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985) 
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Shrikant Sharat Kandula
9bbbf37ae0
Fix #1597: Add a signed issuer token to proxied requests, if configured (#1953) 2020-12-02 18:20:57 +05:30
Sumit Kumar
d347448b24
Propagte mysql test datasource failure to UI. (#2001) 
1. Propagte mysql test datasource failure exception message to UI.
2. Change build TC to reflect the same.
 2020-12-02 17:53:38 +05:30
Arpit Mohan
a900b48712
Improving the text we see in the API and query settings pages (#1997) 2020-12-02 16:27:57 +05:30
vicky-primathon
6c19af7c24
Fix: Columns flicker when columns are resized or reordered (#1940) 
* Fixed flickering issue on column reorder and resize

* Disable sort when resizing column to stop flicker issue
 2020-12-02 16:14:56 +05:30
Pawan Kumar
066e20d0a2
Fix: Remove Fusioncharts Watermark (#1978) 
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-02 16:12:51 +05:30
akash-codemonk
afa81d9eaf
Datasource form bug fixes (#1986) 
* Datasource form fixes #1967 and fixes #1966
* Add tests for scenarios in #1967 and #1966
 2020-12-02 16:06:35 +05:30
Piyush Mishra
1eddc0c7d1
Faster recompile with cached eslint (#1987) 2020-12-02 11:57:56 +05:30
imgbot[bot]
4fa2fd4ba6
[ImgBot] Optimize images (#1993) 
*Total -- 307.73kb -> 177.70kb (42.25%)

/deploy/heroku/images/app-settings.png -- 215.56kb -> 118.43kb (45.06%)
/deploy/heroku/images/finish.png -- 33.21kb -> 19.53kb (41.19%)
/deploy/heroku/images/add-domain-form.png -- 29.12kb -> 18.04kb (38.06%)
/deploy/heroku/images/add-domain-button.png -- 29.37kb -> 21.23kb (27.71%)
/app/client/src/assets/icons/ads/upload.svg -- 0.47kb -> 0.47kb (0.62%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-12-02 11:50:10 +05:30
Sumit Kumar
b3c3102c72
Add tests for mysql plugin to test all regularly used data types in mysql. (#1994) 2020-12-02 11:49:41 +05:30
satbir121
8afa900044
Filepicker component and logo upload for org (#250) 2020-12-02 03:31:27 +05:30
devrk96
5d820c7203
Fix: Organization rename and toast issues (#1954) 
* Toast message removed when renaming an organization
 2020-12-02 03:30:29 +05:30
Hetu Nandu
29d0c49962
Wait for eval before executing the next evaluation (#1959) 2020-12-01 16:09:55 +05:30
Pawan Kumar
43f821fddc
Fix: test cases for datepicker (#1977) 
* clear cache values on delete

* added test cases

* add reload in test case

* fix test cases for datepicker spec

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-01 12:10:31 +05:30
Pawan Kumar
1aea90c404
Fix: Persist of default values even after delete of widget (#1929) 
* clear cache values on delete

* added test cases

* add reload in test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-01 10:56:35 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Sumit Kumar
883fa44896
Make sql plugin use R2DBC driver instead of JDBC driver (#1936) 
1. Add R2BC driver and remove JDBC driver usage in mysql plugin to make the plugin reactive.
2. Update dependencies in POM file.
3. Update mysql plugin to return result based on the type of sql query i.e select vs other queries. In case the queries are chained, then the last query is used for deciding the type.
4. Added a new TC for testing datasource and removed a non functional TC.
 2020-11-28 18:04:56 +05:30
Hetu Nandu
f248304720
Using --no-cache option for jest tests 2020-11-28 10:37:10 +05:30
Piyush Mishra
b199c539be
Fix setup for local linux server (#1948) 2020-11-27 14:49:09 +05:30
Nidhi
6c974408bd
Added IntelliJ run configuration for an easier getting started experience for contributors (#1944) 
* Added run configuration for IntelliJ

* Added instructions for run config
 2020-11-27 14:31:09 +05:30
Abhinav Jha
55ef8a0084
Loop sagas to respawn when they crash (#1880) 
* Added Sentry logging

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-11-27 14:21:08 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865) 
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-27 14:18:38 +05:30
akash-codemonk
49026d9b3c
Sava api with datasource without having to click on save datasource (#1930) 2020-11-27 11:06:16 +05:30
Nikhil Nandagopal
9c29b83d07
Fixed Action selector function arg splitting regex to include arrays and objects (#1893) 
- Also added navigateTo params field
 2020-11-27 10:30:53 +05:30
imgbot[bot]
f073698fcc
[ImgBot] Optimize images (#1928) 
*Total -- 316.18kb -> 175.10kb (44.62%)

/deploy/aws_ami/images/system-log.png -- 136.77kb -> 73.60kb (46.19%)
/deploy/aws_ami/images/select-system-log.png -- 178.91kb -> 101.01kb (43.54%)
/app/client/src/assets/icons/ads/warning.svg -- 0.49kb -> 0.49kb (0.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-26 18:43:05 +05:30
Trisha Anand
2062c60ca3
Moved all the scheduling of the plugin executions to bounded elastic instead of elastic. (#1931) 2020-11-26 17:50:43 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884) 
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-26 16:51:23 +05:30
NandanAnantharamu
a64069b9f2
Added test for Tab and input widget binding (#1912) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-26 15:15:03 +05:30
NandanAnantharamu
7a73763aea
Feature/pageload usecase (#1750) 
* Usecase for pageload Api and input widget

* Updated test name

* updated tests

* Updated assertion

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-25 21:40:31 +05:30
Piyush Mishra
d9e7baea45
Fix infinite loop crash on widget drag (#1916) 2020-11-25 21:32:54 +05:30
devrk96
461b662c7a
Feature: Rename organization in homepage (#1201) 2020-11-25 17:54:14 +05:30
Nikhil Nandagopal
8109b3b001
Merge pull request #1836 from vvkpd/show-number-of-records 
show number of the records
 2020-11-25 12:31:46 +05:30
Nikhil Nandagopal
25e9516315
Update TableHeader.tsx 2020-11-25 12:06:27 +05:30
Nikhil Nandagopal
610ea6c1f7 minor fix for user ids being sent 2020-11-24 21:10:50 +05:30
Vivek Pandey
1bdefc0094 removes show label from header 2020-11-24 20:05:34 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab 
Fix selectedTab binding issue
 2020-11-24 19:06:10 +05:30
Piyush Mishra
dbf947a1a6
Hotfix for mac start-https.sh script (#1891) 2020-11-24 18:58:05 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
e7c465eaae
Add support for WSL local dev (#1756) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2020-11-24 16:45:33 +05:30
Piyush Mishra
7376ada1b1
[Documentation] Use env variables in Cypress tests (#1887) 2020-11-24 16:44:38 +05:30
Piyush Mishra
03f97c0323
Fix: Maps widget crash on wrong initial location datatype (#1854) 2020-11-24 14:13:45 +05:30
devrk96
fee1a4518f
Feature: Toast component (#476) 2020-11-24 12:31:37 +05:30
Arpit Mohan
36af9d5c5e Correcting the placeholder in firestore form.json 2020-11-24 11:00:27 +05:30
Nikhil Nandagopal
6da629d441 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-23 18:48:00 +05:30
Nikhil Nandagopal
9cc5a20190 added source to user object 2020-11-23 18:47:12 +05:30
Shrikant Sharat Kandula
74cd362057
Firestore Integration (#1799) 
* Adding the skeleton for Firestore integration

* Adding the datasource & query editor forms

Also adding the database changelog for the firestore plugin

Commenting out the firestore.close() connection because that causes issues with multiple Firestore tenants running in the same JVM.

* Adding the code for fetching the structure of collections from Firestore

* Use single document path field for Firestore

* Fix potential NPE when datasource destroy timeouts

* Work in progress on collection level ops for Firestore

* Get documents in a collection now works

* Add collection level querying support

* Mild refactoring

* Fix NPE when some fields are missing

* Hide clientJSON as a password field for Firestore

* Make collection level querying reactive

* Make reactive

* Validate before connecting

* Add tests for all supported methods in Firestore

* Fix forms for Firestore with hidden fields

* Hide limit and order by fields when not needed

* Restore log entry deleted by mistake

* Use S3 URL for Firestore/Firebase logo

* Add comments detailing why some code is commented

* Make parsing JSON reactive and fix subscribe calls

* Fix reactive scheduler

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-23 18:42:33 +05:30
Trisha Anand
c07264f1c1
Making Redis plugin blocking statements run on elastic thread pool (#1850) 2020-11-23 17:03:04 +05:30
Trisha Anand
772884e1a3
Making dynamo db's blocking commands run on elastic thread pool. (#1853) 2020-11-23 17:02:41 +05:30
Trisha Anand
d8cba1bf8c
Making MySql blocking commands run on elastic thread pool (#1862) 2020-11-23 17:02:18 +05:30
Trisha Anand
0bb99dd087
Elastic search plugin's blocking calls moved to elastic scheduler thread (#1855) 2020-11-23 17:01:34 +05:30
Pawan Kumar
ad52842e1c
Fix/entity name coincide issue 1396 (#1781) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* add check if name is conflicting with internal fn

* use already existing selector

* add conflicting names checks on api/queries/widget names

* add test cases for invalid widget/api/query names

* refactor

* change array to map

* remove getDataTreeKeys selector

* refactor

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-23 14:57:00 +05:30
Piyush Mishra
5efcb47486
Improve test automation docs (#1838) 
* improve docs with link to client setup and change cypress.env.json instead of editing cypress.json file

* fix link to client setup

* improve ordering

* rearrange

* fix quotes

* remove unlinkable link

* fake push
 2020-11-23 13:58:26 +05:30
akash-codemonk
294348e1f9
Query pane plugin form should be initializable (#1802) 2020-11-23 11:58:15 +05:30
Trisha Anand
242afd5753
Making MS-SQL plugin blocking statements run on elastic thread pool (#1827) 
* MS-SQL Plugin now creates connection and executes statements over elastic thread pool.

* Added a test to ensure that throwables are clean.
 2020-11-23 11:28:01 +05:30
Trisha Anand
dc7a375543
Making postgres plugin blocking statements run on elastic threadpool. (#1821) 
* Making postgres plugin blocking statements run on elastic threadpool.

* Moved the blocking calls to check for the connection validity, etc. also inside the Mono.fromCallable
 2020-11-23 11:27:52 +05:30
Trisha Anand
c2d1ac973c
Adding thread name to the context of logs to allow for the thread names to be printed for each log. (#1824) 2020-11-23 10:45:15 +05:30
Vivek Pandey
0a35ecdcaf show number of the records 2020-11-22 20:16:27 +05:30
Nikhil Nandagopal
6487508e0c
Merge pull request #1823 from appsmithorg/fix/rte-linebreaks 
Fix RTE line break issue
 2020-11-20 17:27:51 +05:30
Abhinav Jha
3064a1865a Fix RTE line break issue 
Fix issue where empty defaultValue wasn't getting updated
 2020-11-20 17:08:51 +05:30
Hetu Nandu
ff541c3efa
Patch object order issue (#1819) 2020-11-20 15:00:50 +05:30
Hetu Nandu
9ef9d184ff
Pass execution params to action callback (#1814) 2020-11-20 13:57:46 +05:30
Trisha Anand
882df291d7
[Bug Fix] Indices not working for fetching actions during update layout (#1813) 
Instead of using compound index, using single indices to ensure that both fetch actions by app id (during load of actions in edit/view mode) and fetch actions by page id (during update layout) are indexed queries.
 2020-11-20 13:30:17 +05:30
vicky-primathon
3b85cc8222
Added defaultSelectedRow property in table widget so that users can configure default selected row(s) (#1684) 
* Added defaultSelectedRow property in table widget so that users can configure default selected rows

* Cypress test cases added to test default row selection in table widget

* Fix defualtSelectedRow property's evaluation type

* Fix default select row type

* Set default selected row when resetting user selected rows

* Use defaultSelectedRow when no user selected row in table
 2020-11-20 13:13:39 +05:30
devrk96
0da8c84ae1
Fix: App card boundaries UI (#1798) 
* Hover ui fixed on all sides of app card
 2020-11-20 12:45:48 +05:30
devrk96
879258b74f
Theme flag stored in localStorage cleared when logging out (#1796) 2020-11-20 12:45:04 +05:30
Trisha Anand
63fe27fae1
[Bug Fix] : Clone Application creates corrupted clone when interrupted. (#1800) 
* Doing a deep copy during clone application instead of updating the original application which may have been causing a concurrency bug.

* Ensuring that once the clone application flow is triggered, the flow completes eventually even if the client cancels the request before completion.

* Cloned application would not be public.

* Added parametrized Application constructor

* Removed lombok all args constructor

* Optimized import

* Incorporated review comments :
1. Updated the constructor for creating the application
2. Added a test case to assert that if during cloning of an application the flow gets cancelled, the cloning would still complete and ensure that the application created is sane.
 2020-11-20 10:55:59 +05:30
Sumit Kumar
b03e815952
Change Sentry log 'environment' tag value. (#1789) 
* Change Sentry log 'environment' tag value.

1. Change Sentry log 'environment' tag value to 'Properties' from 'properties'.
 2020-11-19 17:29:48 +05:30
akash-codemonk
26e793a86a
Show api datasource list on focus (#1668) 2020-11-19 17:11:06 +05:30
akash-codemonk
2ded99f9ac
Fix store as datasource (#1772) 2020-11-19 17:00:22 +05:30
Pawan Kumar
5f1b398d34
Fix/truncated page name in appviewer issue 1597 (#1770) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

* fix ref issue + test cases

* fix test case

* update test case

* fix test case

* fix merge conflict typo

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-19 16:08:09 +05:30
akash-codemonk
acb3c42d66
Highlight matching brackets in editor (#1613) 2020-11-19 13:24:21 +05:30
akash-codemonk
6dc7e42ce9
Remove api datasource from add datasource page (#1639) 
* Show only db datasources in the create datasource page

* Remove invalid test
 2020-11-19 13:22:44 +05:30
akash-codemonk
32482d4826
Fix datasource name getting focused after save while creating new datasource (#1793) 2020-11-19 13:04:19 +05:30
akash-codemonk
732dc632cd
Show callout only for db datasources (#1792) 2020-11-19 10:49:36 +05:30
akash-codemonk
c3c7b9b7d7
Add new property to conditionally hide form fields in datasource and editor (#1682) 
* Create a form control component which handles the hidden logic

* Add tests
 2020-11-19 09:02:58 +05:30
Arpit Mohan
9772d64c5b
Disable instance ping check when the disableTelemetry flag is set (#1776) 
Also adding the APPSMITH_SEGMENT_CE_KEY as a build arg to the server Dockerfile. This will be used to set the environment variable in the Docker image itself.
 2020-11-19 08:54:03 +05:30
Piyush Mishra
5b684b857e
Add placeholders on curl import and API create form (#1738) 
* adds placeholder on curl import form

* add placeholder to api creation form as well
 2020-11-19 05:48:54 +05:30
Abhinav Jha
93ac625135 Hide appviewer header if queryparams has embed 2020-11-18 18:55:25 +05:30
Vivek Pandey
de435ed009
Show number of records instead of pages in the table widget (#1734) 2020-11-18 18:20:04 +05:30
Hetu Nandu
2538444e20
Remove old derived value bindings from test DSLs (#1757) 2020-11-18 18:18:07 +05:30
Sumit Kumar
2c6d1bb361
Fix mongodb datasource test. (#1783) 
1. Fix mongodb datasource cypress test failure.
2. Against certain mongodb instances, we expect to receive an exception of type "unauthorized" when testing datasource. Earlier, this case was caught and whitelisted until the recent change to replace mongodb infra with reactive mongodb infra.
 2020-11-18 16:55:39 +05:30
Nidhi
941be8c58d
Fixed check for incorrect dynamic bindings (#1775) 
* Fixed check for incorrect dynamic bindings
 2020-11-18 14:25:55 +05:30
Shrikant Sharat Kandula
f36adeb6b5
Fix #1766: cURL parser eats backslashes in single-quotes (#1768) 2020-11-18 11:20:23 +05:30
Shrikant Sharat Kandula
2ca15ba57d
Fix #1758: columns duplicated in Postgres structure (#1767) 2020-11-18 11:19:55 +05:30
Sumit Kumar
2c2aa06e32
Add support for reactive streams with mongodb. (#1720) 
Add support for reactive streams with mongodb. (fixes 1480)

1. Replace mongodb driver with reactive mongodb driver. Change APIs accordingly.
2. Use webflux + reactor framework to execute mongodb queries in event loop model.
3. Add test to test MongoPluginExecutor class' method "testDatasource".
 2020-11-18 10:58:50 +05:30
Trisha Anand
fc3197b78f
Email sending is now non-blocking. The blocking code for email sending is triggered and then immediately returned. (#1762) 2020-11-18 00:31:39 +05:30
Arpit Mohan
c3a44651f2
Adding null check for dynamic binding path list (#1752) 
* Adding null check for dynamic binding path list.

* Increased timeout duration for failing test

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
 2020-11-17 15:38:48 +05:30
Trisha Anand
6ac04d8a9e
Added SLA bucket for metric evaluation for 1 second (#1740) 2020-11-17 12:47:49 +05:30
Pawan Kumar
6e4c6824ef
Fix/truncated page name in appviewer issue 1597 (#1742) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-17 12:03:10 +05:30
Nidhi
9de085f264
Switched to using dynamicBindingPathList for generic scan, supports DB queries and nested structures 
* Switched to using dynamicBindingPathList for generic scan
 2020-11-17 11:26:08 +05:30
Piyush Mishra
49c24c7654
Force redirect https on development nginx server (#1733) 2020-11-16 19:01:33 +05:30
Trisha Anand
a722b08002
Adding index for unpublishedAction.pageId to bring down the number of documents fetched in mongo db query during update layouts' fetching actions on page load. (#1739) 2020-11-16 18:59:04 +05:30
Arpit Mohan
955f80925f
Fixing the telemetry on self-hosted instances (#1714) 2020-11-12 19:01:40 +05:30
Abhinav Jha
0f4269891f
Fix issue where creating a new application twice does not work (#1713) 2020-11-12 18:58:12 +05:30
akash-codemonk
86a419d42a
Add the error style to bindings (#1711) 2020-11-12 18:53:49 +05:30
Pawan Kumar
fc29a31cd4
Fix/show two whitelist ips issue 1632 (#1705) 
* add second whitelist ip for create datasource page

* revert the cloudhosting check on help button

* update name of util function

* remove unused key

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-12 17:35:19 +05:30
NandanAnantharamu
da9ef2cb2d
Added a check for zoom feature test (#1703) 
* Added a check for zoom feature test

* Added another click for zoom-in check

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-12 17:34:44 +05:30
Pawan Kumar
7bc4697545
Fix/help modal fab button toggle issue 1681 (#1692) 
* change icon to close on opening help modal

* fix help modal icon bug

* add test cases for the fab buttont toggle issue

* fix padding + closing lag issue of help modal

* pass isOpen true all the time

* fix help modal button hover issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-12 16:56:54 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625) 
Implements #1575
 2020-11-12 16:53:32 +05:30
akash-codemonk
1510c21a7d
Add a back button to the datasources page (#1702) 2020-11-12 15:36:13 +05:30
Rohit Kumawat
175d43aad3 limit added for showing user icons in an organization 2020-11-12 15:01:51 +05:30
Arpit Mohan
073555ee8a
Moving all telemetry check to the configs class (#1700) 
Now we enable/disable all analytics in a central location in the configs class. This ensures that each analytics function can simply check it's own value and not worry about checking for the disableTelemetry flag
 2020-11-12 11:56:09 +05:30
Nikhil Nandagopal
e411df0a64
Added check so that existing installs don't get telemetry (#1698) 
* Adding the segment key to the tagged release
* Also opting out of telemetry data in CI builds

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-11 23:54:19 +05:30
Arpit Mohan
cb4b3b2753 Dummy commit to trigger CI build 2020-11-11 19:43:25 +05:30
Hetu Nandu
a51082fb54 Merge branch 'master' into release 2020-11-11 18:51:03 +05:30
devrk96
73869eee69
Feature: Show org user icons on homepage (#1685) 
* Displaying org user icons feature is implemented

* using username if name not found in user details

* Share user icon cypress test implemented
 2020-11-11 18:42:05 +05:30
Abhinav Jha
a4f652ce70
Add client-max-body-size directive to nginx https proxy (#1695) 2020-11-11 18:23:48 +05:30
Nikhil Nandagopal
5a903a6976 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-11 18:07:57 +05:30
Nikhil Nandagopal
a1d6b0232b enabled perf for sentry 2020-11-11 18:07:40 +05:30
akash-codemonk
aefafd33dc
Fix switching datasource in the query pane (#1636) 2020-11-11 17:59:26 +05:30
Hetu Nandu
b1c8008c3d Add null check for evaluated value in Chart Data Control (#1675) 
Fixes: #1672, #1666
 2020-11-11 17:28:26 +05:30
Hetu Nandu
3a84af82ed
Fix critical issues (#1686) 
Fixes #1683
Fix for dropdowns with option not being an object crashes dropdown and stops eval
Fixes #1656 #1657
Fix issue where updateWidgetProperty would get called without a widgetId
 2020-11-11 17:02:14 +05:30
Pawan Kumar
392de2b840
Fix/on date selected call issue 987 (#1691) 
* fix onSelectedDate call on deselection of date

* add test cases for deselecting the datepicker widget issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-11 16:59:45 +05:30
Arpit Mohan
166ee73c9f
Moving the intercom initialization to the body in index.html (#1690) 
This is to allow us to enable/disable Intercom chat based on the APPSMITH_INTERCOM_APP_ID and APPSMITH_CLOUD_HOSTED environment variables.
 2020-11-11 15:49:21 +05:30
NandanAnantharamu
d5ce1dfa52
Added tests for dependencies (#1679) 
* Added tests for dependencies

* updated review comments

* moved files to binding folder

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-11 15:44:01 +05:30
Nikhil Nandagopal
3c37645d12
Merge pull request #1674 from appsmithorg/fix/switch-content-type 
Fix incorrect bodyFormData values being sent
 2020-11-10 19:20:11 +05:30
Pawan Kumar
dace2a6a55
Merge pull request #1671 from appsmithorg/pawan/issue-720 
Fix long app names not visible issue
 2020-11-10 17:26:41 +05:30
Pawan Kumar
42fe5f4543 update test cases for the issue + typo fix 2020-11-10 16:59:34 +05:30
Akash N
06d330ef3a actionConfiguration.body shouldn't be reset 2020-11-10 16:42:31 +05:30
Pawan Kumar
8b7e7d2993 incorporate code reviews feedbacks 2020-11-10 15:58:21 +05:30
Akash N
6c0d0e228c Add test 2020-11-10 15:11:05 +05:30
Pawan Kumar
426bb0b8df clear search input in test cases 2020-11-10 15:08:47 +05:30
Akash N
3fbcf667b6 Do not reset the bodyFormData value 2020-11-10 14:58:14 +05:30
Nikhil Nandagopal
5e17450e2f
added check for no matches (#1673) 2020-11-10 14:52:35 +05:30
Pawan Kumar
3a708497dd add a max-width on tooltip component 2020-11-10 14:16:57 +05:30
Hetu Nandu
a52c5df987 Fix form widget eval loops for arrays 2020-11-10 13:23:18 +05:30
Sumit Kumar
2dc2615311
Replace Rollbar with Sentry (#1606) 
* Replace Rollbar with Sentry

1. Log exceptions using Sentry instead of Rollbar.
2. Remove all Rollbar infra.
 2020-11-10 09:59:10 +05:30
Pawan Kumar
ec49c358c4 Fix app name too long issue 2020-11-09 17:00:34 +05:30
Hetu Nandu
977405a720
Create app crash boundary (#1629) 2020-11-09 14:53:20 +05:30
Hetu Nandu
9f0363812e
Default page id fixes (#1628) 
* Fix App invite form not getting the correct page id

* localise confusing getDefaultPageId function

* Remove old fetch application workflow action
 2020-11-09 14:22:44 +05:30
Nidhi
1741e61ba0
Added user roles list to application fetcher (#1624) 
* Added user roles list to application fetcher

* Fixed blanket import
 2020-11-09 11:54:30 +05:30
Nidhi
62e4e28c8e
Fixed upload logo payload limit and added delete logo API (#1574) 
Also changed name of default organization to xyz's apps
 2020-11-09 07:52:08 +05:30
vicky-primathon
fd12e907af
Map not resetting to location selected fix. Location map to search location. (#1619) 2020-11-06 20:39:35 +05:30
Abhinav Jha
b549978fdf
Fix issue where clicking on widget add button redirects to the homepage (#1620) 2020-11-06 20:38:11 +05:30
vicky-primathon
e82b0c42e3
Fix distortion due to table scrollbar (#1608) 2020-11-06 16:48:04 +05:30
vicky-primathon
54a6ca0850
Fix/table widget pagination changes (#1298) 2020-11-06 16:45:47 +05:30
Nikhil Nandagopal
6121e6938e
Merge pull request #1576 from appsmithorg/fix/button-ui-invite-modal 
Fix: Invite modal cancel button UI
 2020-11-06 15:04:10 +05:30
Hetu Nandu
2820413b7d
Fix bad fix for show alert issue #1583 (#1614) 2020-11-06 14:57:10 +05:30
Hetu Nandu
f0862652c3 Fix for btoa / atob functions 2020-11-06 14:50:07 +05:30
Rohit Kumawat
f321b6e759 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/button-ui-invite-modal 2020-11-06 14:31:50 +05:30