Commit Graph

3450 Commits

Author SHA1 Message Date
Pawan Kumar
51076eaead
Fix: Show appropriate error message when an onPageLoad action fails (#2355)
* show action in toast error message on pageload error

* add test case

* add error body in toast

* fix test case

* fix test case

* update test case

* uncomment test case

* remove the console log

* remove unused console

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 10:55:47 +05:30
akash-codemonk
8d303d3d9f
Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-06 09:38:46 +05:30
akash-codemonk
f5e696a4f4
Hide other header elements while showing the deploy button 2021-01-06 09:38:18 +05:30
Nidhi
de5003a98e
Added type parameter for REST API plugin, and changes for no auth (#2438)
* Added type parameter for REST API plugin, and changes for no auth

* Removed logs

* Converted to reactive
2021-01-05 17:59:50 +05:30
Hetu Nandu
1598899dd6
Fix invalid toast message for evaluation error (#2443)
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
2021-01-05 17:15:37 +05:30
Trisha Anand
d5074ee7f7
Increased logs to debug future connection leaks. (#2437)
* Increased logs to debug future connection leaks.

* Fetch a connection from the pool only if a query exists.

* Minor comment added.

* Minor rewrite

* Code formatting.

* Update app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Added hikari cp pool stats to get database structure function as well.

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-01-05 15:34:55 +05:30
Rishabh Saxena
2629ead4b7
fix: check for undefined error action payload (#2428) 2021-01-05 12:12:04 +05:30
akash-codemonk
69cd988c01
Fix onboarding test failure causing other tests to fail (#2417) 2021-01-04 15:52:22 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
2021-01-04 15:46:08 +05:30
NandanAnantharamu
4c5387f707
updated assertion (#2419)
* updated assertion

* review comment incoirporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-04 12:59:21 +05:30
Trisha Anand
214f911060 Fixed merge conflict related build failure. 2021-01-04 11:24:00 +05:30
Trisha Anand
24ef325467
Merge branch 'master' into release 2021-01-04 11:18:13 +05:30
Trisha Anand
e17da5f913 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2021-01-01 01:24:55 +05:30
Trisha Anand
a3378397d7 Increasing pool size to 20 to reduce the number of times datasource becomes unusable. Symptomatic relief till I can solve for this at leisure over the next few days.
Note : Update/Insert are leading to connection leak
2021-01-01 01:24:26 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-31 17:54:50 +05:30
Piyush Mishra
3d7242d716
Cleanup cancelled requests (#2387) 2020-12-30 18:56:44 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Rishabh Saxena
c344377a9d
only autofocus widget search (#2400) 2020-12-30 18:32:11 +05:30
Hetu Nandu
31d8c8c4eb
[Worker] Fix critical issues (#2393) 2020-12-30 18:28:57 +05:30
Trisha Anand
d4640e01a2
Invite users once triggered should not be cancellable. (#2401)
* Invite users once triggered should not be cancellable.
2020-12-30 16:50:01 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30
Rishabh Saxena
f1f9441cc6
auto focus search input (#2360) 2020-12-30 14:33:24 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
5ae2da1578
Send clean validated tree back (#2376) 2020-12-29 23:57:07 +05:30
Rishabh Saxena
37d0314c2a
default error code (#2363) 2020-12-29 22:22:31 +05:30
Rishabh Saxena
14effe6db1
fix del hotkey (#2349) 2020-12-29 22:21:57 +05:30
Rishabh Saxena
ccd9371820
update tooltip test (#2392) 2020-12-29 19:50:14 +05:30
Trisha Anand
712f41db92
Reducing the probability of getting pages out of order (Expected order is the order in which the pages were created and added to the application). This should : (#2391)
1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team.
2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
2020-12-29 19:10:01 +05:30
Rishabh Saxena
13fae1a5c1
fix test (#2390) 2020-12-29 17:45:15 +05:30
Trisha Anand
ea366b1d29 Fixed NPE in database migration 2020-12-29 17:06:30 +05:30
Trisha Anand
735a4398b2
Added a migration to old rest api datasources which adds the new mandatory key isSendSessionEnabled with value N (#2388) 2020-12-29 16:29:28 +05:30
Rishabh Saxena
e526f5cca5
minox css fixes (#2375) 2020-12-29 16:17:32 +05:30
Hetu Nandu
b5e8673921
Properly log data tree instrumentation (#2228) 2020-12-29 14:55:56 +05:30
Trisha Anand
ea0f9c159c
[Bug] Multi page applications return only a single page when fetching pages per application (#2383)
* Zipping flux with mono leads to mono not getting repeated and only the first emitted value of flux is processed further. This is leading to only a single page getting emitted in a multi page application.

* Added a test case to assert this for a multi page application
2020-12-29 13:38:47 +05:30
Trisha Anand
a70b95be37 Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:29:50 +05:30
Trisha Anand
051d3c6c7f
Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:26:33 +05:30
Piyush Mishra
988ebe975b
RPC-like layer with graceful startup and shutdown around a webworker (#2252) 2020-12-28 14:12:43 +05:30
Sumit Kumar
6299c86f39
Add TC to test mongodb connection establishment (#2364)
1. Test that when a query is attempted to run on mongodb server but refused because of lack of authorization, then
also, it indicates a successful connection establishment.
2020-12-28 11:58:17 +05:30
dependabot[bot]
45497ba5ac
Bump node-notifier from 8.0.0 to 8.0.1 in /app/client (#2316)
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 10:55:39 +05:30
Trisha Anand
6210b9a0c0
All newly created applications now have a default published state. (#2309)
* All newly created applications now have a default published state.

* Added a test case to assert a new application comes up with default published states for both application and the default page.

* Function name changed.

* When trying to fetch a published version of a page when the page has not been published, throw a 404.

* WIP : Not working
2020-12-28 10:30:43 +05:30
Piyush Mishra
ebcffadca1
Prettier fixes (#2366) 2020-12-28 09:47:50 +05:30
Piyush Mishra
8ef8bfd2ac
Prettier fix. (#2353) 2020-12-24 19:01:09 +05:30
akash-codemonk
466d0cfde1
Fix explorer entity icon alignment (#1413) 2020-12-24 15:41:02 +05:30
Rishabh Saxena
83349e2996
fix modal entity not renamed through property pane when closed by clicking on the overlay (#2185) 2020-12-24 11:43:01 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
3930c4c63c
Hotfix circularJSON (#2214) 2020-12-23 19:48:46 +05:30
Shrikant Sharat Kandula
85350b2940 Add migration to set isEncrypted field where missing (#2332)
(cherry picked from commit d5e0fb18d8)
2020-12-23 18:07:35 +05:30
Shrikant Sharat Kandula
4ff2834559 Missing isEncrypted should mean a true value
(cherry picked from commit c7f330c4c7)
2020-12-23 18:07:35 +05:30
Rishabh Saxena
4e802d2c5a
reset query on select, don't jump to active item (#2237) 2020-12-23 17:45:14 +05:30
Rishabh Saxena
396b12b024
reorder widgets alphabetically, autofocus search input (#2325) 2020-12-23 17:02:30 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Rishabh Saxena
77801b10ff
fix undo delete tab, create copy of tabs array (#2315) 2020-12-23 16:55:52 +05:30
Rishabh Saxena
9417335176
render column submenu popover inline (#2329) 2020-12-23 16:55:25 +05:30
Shrikant Sharat Kandula
d5e0fb18d8
Add migration to set isEncrypted field where missing (#2332) 2020-12-23 15:35:45 +05:30
Shrikant Sharat Kandula
c7f330c4c7 Missing isEncrypted should mean a true value 2020-12-23 14:23:03 +05:30
a
61e12235b2 Revert "reorder widget locale wise, autofocus search input"
This reverts commit 0bcc8872eb.
2020-12-23 11:08:52 +05:30
a
0bcc8872eb reorder widget locale wise, autofocus search input 2020-12-23 11:01:00 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
Sumit Kumar
53a6160139
Revert "Redshift plugin (#2112)" (#2314)
This reverts commit 708ca7fedf.
2020-12-22 16:59:18 +05:30
Sumit Kumar
708ca7fedf
Redshift plugin (#2112)
1. Add new plugin to connect to AWS Redshift cluster and run query.
2. Add unit test cases.
2020-12-22 15:35:25 +05:30
prapullac
91125ebc26
Manual test Ideas for home page (#2208) 2020-12-22 14:06:52 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)"
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
2020-12-22 13:02:02 +05:30
Shrikant Sharat Kandula
ea6e897dde
Firestore ADD_TO_COLLECTION command support (#2305)
* Support ADD_TO_COLLECTION operation on Firestore

* Add test for Firestore add-to-collection command
2020-12-22 12:32:14 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293)
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
2020-12-22 08:27:57 +05:30
Shrikant Sharat Kandula
cfcd7aa0bb
Fix Firestore datasources not encrypting secret key JSON when editing (#2296)
* Fix encrypted field not being ignored in JSON

* Don't mask error in decrypting

* Revert masking of error in decrypting
2020-12-21 17:43:15 +05:30
Rishabh Saxena
42173e9249
fix tooltip boundary, don't show on target focus (#2250) 2020-12-21 15:22:58 +05:30
devrk96
851ae51c3a
Auto scroll to specific section on homepage when reloading with same url (#2115) 2020-12-21 14:35:58 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
Piyush Mishra
5408806bf1
Do not add objects to the DataTree (#2275)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-21 11:44:20 +05:30
Nidhi
e3cf285d1e
Fixed encryption related bugs for empty/new datasource (#2287) 2020-12-21 10:41:57 +05:30
Shrikant Sharat Kandula
fdc4f7b200
Fix invalid templates and API breaking on invalid templates (#2286) 2020-12-19 13:00:24 +05:30
Shrikant Sharat Kandula
5e04ca5c9d
Add ability to configure order of templates of plugins (#2279) 2020-12-18 20:45:08 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-18 18:48:47 +05:30
Nidhi
5a36d17f7a
Fixed encryption related bugs for empty/new datasource (#2272) 2020-12-18 16:13:01 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Nidhi
a00c144e85
Subclassing authentication (#2215)
* Sublcassing authentication

* Removed TODO

* Review changes
2020-12-17 21:38:52 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223)
* @hetunandu for president
2020-12-17 20:13:01 +05:30
Hetu Nandu
4b3a0ca9de
Fix table text pagination test (#2253) 2020-12-17 18:52:19 +05:30
Piyush Mishra
29de447411
Upgrade fusioncharts npm package (#2241) 2020-12-17 17:43:33 +05:30
NandanAnantharamu
db89dddbad
Organization test split into 2 parts (#2247)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 14:16:54 +05:30
Hetu Nandu
4f92ea99ed
Remove functions for action evals (#2242) 2020-12-17 13:36:16 +05:30
Pawan Kumar
e63f0a9d2a
Fix: 404 error page shows server unavailable (#2195)
* mount error wise route

* remove log

* add test case

* fix wrong error page

* fix typescript error + remove unused variable

* remove 404 + 500 routes

* remove unused imports

* fix typo in test case

* remove history replace in utils

* remove unused variable

* add error codes for safe crash

* remove unused variables

* add error codes in all api rejects + update error reducer code type

* update error codes in init saga

* add selectors for error safe crash + take error logic out of app router

* remove unused variables

* remove extra line

* add header in error pag

* refactor page header on error page

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-17 12:33:59 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 11:40:50 +05:30
Piyush Mishra
0ccc80127a
move null check out (#2221) 2020-12-16 14:52:34 +05:30
Rishabh Saxena
2f152bf5b1
fix prev widget hidden when dragging new (#2211) 2020-12-16 14:51:57 +05:30
Rishabh Saxena
17ded71de3
fix actions/queries not fetched after cloning a page (#2196)
* fix actions/queries not fetched after cloning a page

* cf fix

* update type

* update test to check if api is cloned

* trigger tests
2020-12-16 14:51:31 +05:30
Ashwani Sindhu
15a00f4982
Set document title as app name (#2203) 2020-12-15 16:54:44 +05:30
Rishabh Saxena
5c905ac0d8
Update styles for date time headers in a table (#2197) 2020-12-15 16:54:15 +05:30
Hetu Nandu
df902440f5
Add xml2json and json2xml functions (#2022) 2020-12-15 14:16:33 +05:30
Pawan Kumar
1cafbca767
Fix: The search in the multi select is not showing + Multi select dropdown stops functioning if default value is undefined (#2057)
* fix dropdown input ghost width

* add fix when default option is undefined

* update test cases for dropdown undefined default value

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:51 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165)
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:30 +05:30
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Rishabh Saxena
20d15188fd
br instead of p on enter within rte (#2188) 2020-12-14 14:50:45 +05:30
Trisha Anand
29706f7852
Removing printing the result for firestore plugin (#2191) 2020-12-14 14:48:50 +05:30
Rishabh Saxena
29d87a88f0
unmount during drag (#2168) 2020-12-14 12:38:00 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-14 11:50:44 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30