Commit Graph

4896 Commits

Author SHA1 Message Date
Pawan Kumar
a5733da363
fix: Cypress tests for admin settings's watermark setting (#15760) 2022-08-11 17:35:08 +02:00
Aswath K
ee32ffb76f
chore: Grouping & reorganisation for Input widgets (#15584) 2022-08-11 16:50:09 +05:30
Rishabh Rathod
e255593e28
fix: Improve Autocomplete for local vars, JSObject & ButtonGroup Widget
Add Autocomplete support for
- local variables 
- JSObjects
- ButtonGroupWidget
Remove Autocomplete suggestion for
- `eval`
-  undefined global values like `tabs`
2022-08-11 15:29:38 +05:30
Tolulope Adetula
c6ed1b7214
fix: select default value validation (#15846)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* fix: add jest test

* Empty Commit

* Fix: Empty commit to re-reun

* empty commit

* Empty Commit

* cy fix

* json field event fix

* TableFilter failure fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 10:02:55 +05:30
Dhruvik Neharia
ce2aafaee4
feat: Change default label position of RTE widget to top (#15769) 2022-08-10 14:00:24 +05:30
Rishabh Rathod
78379d4718
fix: update def on widget property name update (#15490) 2022-08-10 10:50:08 +05:30
rahulramesha
b4e9f648c3
fix: Multiple scrolls in view mode (#15679)
fix multiple scrollbars
2022-08-09 22:40:10 +05:30
Ayangade Adeoluwa
1ecffb8272
fix: Modify Form Control Inputs for various Datasource Actions (#15396)
* Modify control type for MongoDB Collection field

* Make more form control changes across datasources

* Fix cypress errors

* Fix typescript error

* Fix more cypress tests

* Fix failing MongoDBShoppingCart spec

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-09 13:05:59 +00:00
Aswath K
781620d57b
chore: Property Pane Grouping of Chart, Maps & Media widgets (#15557)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Adds FilePickerWidget

* Adds MapChartWidget

* Adds ContainerWidget

* Adds MapWidget

* Adds ImageWidget

* Adds AudioRecorderWidget

* Adds CameraWidget

* Adds ChartWidget

* fix: issues found in design review

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* Adds FormWidget

* fix: mapchart style section heading

* refactor: cleanup

* incoorporate latest change for Camera widget
2022-08-09 13:05:36 +00:00
Aswath K
6430adb413
chore: Grouping & reorganisation for multiple widgets (#15673)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties

* Adds TextWidget

* Adds RateWidget

* Adds DividerWidget

* Adds ProgressWidget

* Adds ListWidget

* adds TabWidget

* Adds IframeWidget

* Adds StatboxWidget

* Adds ModalWidget

* changes after design review
2022-08-09 13:05:15 +00:00
Aswath K
a3fe6a7826
fix: Remove unwanted logs which may confuse the users (#15815) 2022-08-08 19:24:37 +05:30
Shrikant Sharat Kandula
31481ddaae
fix: Disable polling transport for RTS (#15773)
Disable polling transport for RTS

This is required to support clustering of RTS, and with it, the Appsmith server.
2022-08-06 12:36:11 +05:30
Favour Ohanekwu
5c7f4009cb
fix: Correctly update trigger field dependency map (#15733) 2022-08-05 19:58:38 +02:00
Bhavin K
f85cbb9938
fix: reset the filepicker widget when the user goes to a different link (#15626)
* fix: reset the the fileficker widget

* test: add test-case for file-picker
2022-08-05 19:00:01 +05:30
Tanvi Bhakta
86f0da37db
feat: change imports for dropdown v2 and dependencies (#15081)
* Remove Dropdown, SearchComponent from this repository

* Change the imports so that SearchComponent and DropdownV2 come from the design system

* Add yalc

* default imports become named imports

* remove the yalc package, add the beta version

* Change import for SearchComponent in TableHeader

* Updated Label Config

* chore: Refactor dependency Map code (#14944)

* feat: Triggerpath dependency (#15015)

* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-05 10:05:28 +00:00
ashit-rath
ab5eb0e325
fix: JSONForm field event trigger binding get updated formData values (#15650)
fix: JSONForm field event trigger receive updated formData
2022-08-05 11:49:24 +05:30
Pawan Kumar
89b39e239b
fix: Reskinning Radio + Toggle + Checkbox (#15329)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* fix alignment issue

* fix cypress tests

* fix snapshot tests
2022-08-05 10:16:42 +05:30
Aswath K
56b247f421
Re-render of PropertyPaneConnections (#15552)
Prevents the re-rendering of PropertyPane connections when a property changes.
This improves the performance of the property pane a bit.
2022-08-04 18:21:54 +05:30
Bhavin K
66d3205f4f
fix: revert success flag from trigger response (#15641) 2022-08-04 17:30:53 +05:30
Tanvi Bhakta
819d43b5d0
feat: import changes for button tab component (#15507)
* Update ds package

* Remove ButtonTabComponent

* Remove exports

* Change imports

* bump ds package version
2022-08-04 10:30:36 +00:00
arunvjn
4e5b21600d
Optimise code editor renders (#15405) 2022-08-04 11:10:44 +05:30
Aswath K
7624b91026
chore: Grouping & Reorganisation for ButtonWidget, JSON Form widget and Audio Widget (#14379)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties
2022-08-04 11:01:05 +05:30
Anagh Hegde
82a9d720ae
feat: Added unconfigured datasources to the template API response (#15606)
Co-authored-by: Akash N <akash@codemonk.in>
2022-08-04 09:50:54 +05:30
Preet Sidhu
3cb57b531d
fix: tighten controls for fuzzy search in widget sidebar (#15032)
fix tighten controls for fuzzy search
2022-08-03 17:47:27 +00:00
Favour Ohanekwu
8ec31061e7
fix: Add support for crypto API in linting (#15607)
## Description

This PR adds [crypto web api](https://developer.mozilla.org/en-US/docs/Web/API/Crypto) support in linting

Fixes #15469 


## Type of change


- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- [x] https://github.com/appsmithorg/TestSmith/issues/1996

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented on my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-03 20:05:33 +05:30
Tolulope Adetula
9e66a774dd
feat: Multiselect defaultValue Validation Check for ServerSide Filtering(On/Off) (#15491)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests
2022-08-03 14:17:07 +01:00
arunvjn
7c37f7b35a
Add a new rule to show selectedRow in autocomplete's best match (#15406)
Refactored auto complete sorting logic.
2022-08-03 12:54:38 +05:30
Hetu Nandu
887832d29a
refactor: deprecate commenting and notifications (#15484) 2022-08-03 12:32:49 +05:30
Bhavin K
cf9b869b12
fix: improve camera widget (#14679)
* fix: issue points Android :2,3,6

* fix: improving the camera widget

* fix: show the device menu in fullscreen mode

* refactor: use getPlatformOS for check platform os

* refactor: add missing yarn file

* fix: camera switching issue when video mode

* fix: removed the audio/video mute button from ios devices

* fix: Disable the media button instead of hide in ios devices
2022-08-03 11:32:23 +05:30
Hetu Nandu
69490bbcbf
chore: Extend commenting deprecation deadline to 1.7.12 (#15616) 2022-08-02 10:02:34 +00:00
Anagh Hegde
1fb4cac6f5
chore: Update text message for git remote url placeholder (#15553)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-08-02 12:55:51 +05:30
Pawan Kumar
901749d442
fix: Delay in display of Intercom pop up when user tries to upgrade the Watermark property (#15576) 2022-08-01 21:20:37 +05:30
f0c1s
4ec0a1fe8c
fix: Improve ssh url checking for git import (#15494) 2022-08-01 10:50:38 +05:30
Tolulope Adetula
ef956ecad0
feat: Select defaultValue Validation Check for ServerSide Filtering(On/Off) (#15133)
* feat: defualt value check

* fix: Empty commit trigger deploy

* Fix: add more tests

* fix: improve validation

* Feat: improve jest test

* fix: more tests

* Fix: add github link

* Update app/client/src/widgets/SelectWidget/widget/index.tsx

Co-authored-by: ashit-rath <ashit@appsmith.com>

* fix: add more comment to issue

* fix: failing test

* fix: cypress config

* Fix: empty commit

* fix: select issue

* Fix: failing tests

* fix: failing Tests

Co-authored-by: ashit-rath <ashit@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2022-08-01 06:02:48 +01:00
balajisoundar
a6d37625a1
fix: provide access to currentRow in table widget menubutton items (#15457) 2022-08-01 10:31:34 +05:30
Keyur Paralkar
c396224fe8
fix: filePicker widget re-skinning (#15183)
* fix:
* added css variables for primary color
* added styles for dropHint custom icon

* feat:
* styled the remove uploaded file icon to match re-skinning
* added theme font-family to the contents inside the upload modal
* styled upload button to match re-skinning

* feat:
* set cancel button color to theme's primary color
* set the close button style according to theme
* set the border radius of the upload modal
* set the error message styles in accordance with re-skinning

* fix: cross mark position on the top right corner of upload modal

* fix: added hover background color on modal back and add more files button

* fix: added border radius fix for file remove button

* fix: modal close icon

* fix: addressed feedback from dilip

* fix: font-family issue inside the modal

* test: added cypress test to test styling logic
2022-07-29 10:29:02 +05:30
ashit-rath
b21c8cff31
fix: JSONForm input field REGEX validation (#15316)
* fix: JSONForm input field REGEX validation

* fix cypress test
2022-07-29 09:49:39 +05:30
Pawan Kumar
bae0b75583
feat: Code-split for admin setting for toggling appsmith watermark (#15036)
* create checkbox

* code split for hiding branding badge

* code split for hiding branding badge

* code review feedback fixes

* rename auth to upgrade button

* update mobile branding badge

* change label

* minor refactor

* minor updates

* add a cypress tests to check if watermark setting contains a upgrade button
2022-07-28 14:08:37 +05:30
Arsalan Yaldram
a02155fc88
fix: remove appsmith incoming entity from widget entity dropdown (#15324)
* fix: remove appsmith incoming entity from widget entity dropdown
2022-07-28 13:08:50 +05:30
Arsalan Yaldram
9dea163172
fix: show clear input icon on allow clear value (#15232)
* fix: show clear input on allow clear value

* fix: truncate select input on small size
2022-07-27 22:33:05 +05:30
akash-codemonk
3fdce8462c
fix: onboarding visual distraction from the entity explorer being hidden (#15446) 2022-07-27 19:29:43 +05:30
akash-codemonk
526f2a8be6
chore: fix cannot read properties of null (reading 'id') sentry error (#15323) 2022-07-27 16:25:41 +05:30
Favour Ohanekwu
e5d89e7099
chore: Upgrade astring version from v1.7.5 to v1.8.3 (#15245)
## Description
Previous version of the astring library doesn't preserve parenthesis when transforming AST to JS Code. This led to syntax error when null coalesce and logical expressions are used together.

The latest version of astring library fixes this.

<img width="1291" alt="screenshot_2022-07-16_at_04 29 52" src="https://user-images.githubusercontent.com/46670083/179581475-863d70f2-0886-403a-a667-a32ad93e76b7.png">


Fixes #15283 


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
Test plan

- [x] https://github.com/appsmithorg/TestSmith/issues/1970

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-27 14:48:39 +05:30
Bhavin K
47cc518dbe
fix: set default on reset of The Tab widget (#15202) 2022-07-27 14:26:16 +05:30
Arsalan Yaldram
22250b88a0
fix: updated marked to the latest version (#15309)
fix: updated marked added @babel/helper-create-regexp-features-plugin
2022-07-27 14:04:47 +05:30
Hetu Nandu
a1e5b511eb
chore: Deprecation warning for comments (#15363)
Adds deprecation warning for comments

Resolves #15364
2022-07-26 18:04:54 +05:30
Parthvi
58c7f3d805
test: Update documentation URLs used in tests (#15419)
## Description

With the new documentation structure, updating the URLs which are being used in tests.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-26 12:58:07 +05:30
Ankita Kinger
3b7ace67b5
feat: migrate texts and error messages from organization to workspace (#15410) 2022-07-25 17:52:09 +05:30
Favour Ohanekwu
0f92b97226
feat: Triggerpath dependency (#15015)
* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 21:31:08 +01:00
Bhavin K
f45a15545d
fix: depercate form button widget (#14510) 2022-07-22 08:27:37 +00:00
Rishabh Rathod
6ad308ec39
chore: Refactor dependency Map code (#14944) 2022-07-22 12:32:16 +05:30
Souma Ghosh
d45a6bfb97
fix: Compact property not functional for menu type in table widget v2 (#15302)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:45:48 +05:30
Souma Ghosh
27e91f8524
feat: Expose message event details for Iframe Widget (#14730)
* Expose message event details for Iframe Widget

* Change meta property name from messageEventProps to messageMetadata

* Cypress test for Iframe Message event details

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:42:57 +05:30
jaden
06e7d3cc63
CSS cant apply when constant WIDGET_PADDING=0 (#15227) 2022-07-21 18:34:10 +05:30
Favour Ohanekwu
243dc7f477
Improve lint error reporting (#15098)
Core changes in this PR

    Prevents logging of lint warnings (not errors) in the debugger
    Refined message for using 'await' in non-async functions
    Show lint error messages that include line numbers (previously weren't shown)

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-21 18:31:23 +05:30
Nidhi
50172ecd64
fix: Added support for self signed certificate during OAuth2 flows (#14719)
* Added support for self signed certificate during OAuth2 flows, server side changes

* fix: authentication.useSelfSignedCert key added

* Merging from release

* Fixed issue with dependencies, plus bug with using ssl

* Cypress test attempt 1

* Cypress test attempt 2

* Cypress test attempt 3

* Clean up

* Review comments

* Enabled compression again

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-07-21 16:10:36 +05:30
Hetu Nandu
48d2294f84
chore: typescript build error (#15262) 2022-07-21 09:30:02 +05:30
Bhavin K
7ecca954c7
fix: changed the marker(default) value string to number (#15217) 2022-07-20 18:46:06 +05:30
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 (#14158)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* refactor code to migrate from org to workspace

* migrated a few missed out org to workspace

* updated a few more

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* reverted code change

* few more changes

* fixed failing cypress test

* fixed failing cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
Preet Sidhu
c03fddf1c9
fix: Improve CodeMirror rendering performance using idleCallback (#13676)
* working editor wrapper

* updated other property controls

* fix tablefilter_spec unit test

* autofocus on editor

* update font styles

* show lint errors

* add syntax highlighting

* fix import issue

* fix input height

* use lazy and suspense

* wip

* update code clean up

* update input style

* fix select widget issue

* fix build issue

* fix import issue and linting css

* update lint error method

* add polyfill for idle callback

* fix undo aggregate helper changes

* rename CodeEditor component

* fix tests add delay before code mirror

* undo name change

* rename lazy editor

* add comments and update aggregate helper

* fix cypress helper

* fix testJsonText command

* update aggregate helper

* add wait to allow time to load

* fix filepicker issue

* fix currency input test

* fix unit tests

* update aggregate helper

* fix table property tests

* fix test

* fix command

* update json text command

* updated command ii

* update iii

* update iv

* add force click

* check for wrapper

* fix for objects

* fix test iv

* fix test v

* fix tests vi

* fix tests vi

* fix variable naming issue

* fix tests vii

* remove wait from wrapper click

* fix tests viii

* fix recheck wrapper availability

* fix updateCodeInput command

* fix undo while loop

* fix ix

* fix each loop

* removed EnableAllCodeEditors

* updated tests

* Upated wait

* updated some more tests

* updated wait time

* updated common method

* updated all related common methods

* update state name and add callback timeout

* updated test

* updated the test

* fix use while loop and update count

* update click func

* fix use get instead of find

* fix on click action command

* remove comments

* fix: update import statements

* add force click to widget command

* update wrapper ui

* fix auto load code editor

* update editor wrapper ui

* fix lineheight adjustment

* refactor editor wrapper

* update style import

* fix ascetic style import

* fix font style

* fix wrapper height

* update color for code block

* fix min height of content wrapper

* remove error linting and editor wrapper

* remove unused variable

* remove unused imports

* fix font color for objects

* update styles for placeholders

* remove console log

* remove react syntax highlighter

* cancel idlecallback on unmount

* Delay input foucs

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-20 14:56:12 +05:30
Souma Ghosh
eddd1e8344
fix: Multiselect widget height decreases on selecting more options (#15228)
Fixes issue where multiselect height decreases on selecting more options
2022-07-20 14:26:37 +05:30
Bhavin K
8848d89650
fix: Added the loader in the Button group widget (#15246) 2022-07-20 14:21:54 +05:30
ashit-rath
cb40e04aa0
fix: JSONForm default array item not deletable when default value initialized with undefined (#15205) 2022-07-20 14:07:52 +05:30
Aman Agarwal
4890742168
fix: api auth fails displays error on view mode now (#14767) 2022-07-20 13:09:11 +05:30
Rimil Dey
9284c5e240
Auto-indent JS code in the editor (#13222)
This pull request:

    introduces a new option to the menu in the JS editor which lets users prettify/auto-indent code.
    introduces a new keyboard shortcut that lets users prettify/auto-indent code
    Fixes bug where pressing CMD + <- in Mac (Home in windows) shifts the cursor to the first indented column. If the cursor is present on the first indented column, the cursor shifts to the 0th column in the editor

Fixes #9268
2022-07-20 12:43:23 +05:30
f0c1s
58dac0213c
Regenerate SSH key in connect and import flow (#14383)
As of today, we were supporting only ECDSA keys for GitHub, GitLab, and BitBucket. For Azure, RSA key generation was not available. This PR allows users to generate RSA or ECDSA keys.

As of now we support following key types and version control service providers:

    Github: ECDSA
    Gitlab: RSA, ECDSA
    Bitbucket: RSA, ECDSA
    Azure: RSA

Fixes #14382, #14715, #14570
2022-07-20 12:30:11 +05:30
Anagh Hegde
dbf0b94973
feat: Update the table widget to v2 in suggested widget list (#15277)
Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-20 12:28:50 +05:30
balajisoundar
71e581d69b
fix: cell background for edit actions column in Table v2 (#15233) 2022-07-20 11:42:59 +05:30
f0c1s
6eaabc3a7b
fix: reload default page on discard (#14964) 2022-07-20 11:40:06 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Hetu Nandu
5d568b7a6f
fix: Tooltip for long names in Entity Explorer (#15068) 2022-07-20 06:06:11 +00:00
Aswath K
8724f1c4fa
fix: Unwanted width calculation in Dropdown (#15239) 2022-07-20 06:05:44 +00:00
Aman Agarwal
10ca5b5033
fix: query creation via shortcut (#15281)
## Description

- Shortcut key-up and key-down were not working because the list of file operations on ui were filtered out of the `sectionTitle` but on key actions it was being referred to which was adding in the offset for the current active item.

Fixes #15264

## Type of change

- Bug fix (non-breaking change which fixes an issue)
2022-07-20 10:06:51 +05:30
akash-codemonk
086ac89565
fix: query forms which require evaluation shows loading (#15272) 2022-07-19 12:16:07 +05:30
f0c1s
df4fca9b8f
fix: show conflict info properly (#15240)
## Description

ConflictInfo was showing up along side discard button. Moved it to a row of its own.

Fixes #15113 

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:03:21 +05:30
f0c1s
654ae38e67
fix: break branch creation text, fix text casing (#15241)
## Description

During branch creation, a bit of text was clinging to each other. Put them as per the design.

Fixes #15014 

### Issue:

![image](https://user-images.githubusercontent.com/1573771/179294901-7820fe79-4f35-47fd-9f63-98a886f102b5.png)

### design:

![Screenshot 2022-07-16 at 12 40 39 AM](https://user-images.githubusercontent.com/1573771/179295031-bbb5ef67-8955-4901-997a-1f455bdf5bb0.png)

### fix:


https://user-images.githubusercontent.com/1573771/179295053-d5940ba7-2a9f-41a9-965d-596bff69ac71.mov

![Screenshot 2022-07-16 at 12 36 52 AM](https://user-images.githubusercontent.com/1573771/179295067-c82d3905-f325-47ed-9007-06b0c7104e86.png)


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:02:54 +05:30
Anand Srinivasan
53641d9c68
feat: filter error messages from hidden widgets (#14738)
* initial filter

* hide modal errors

* handle tabs and modal

* remove console logs

* clean up

* comment

* add comments

* handle nested tab

* unit tests

* update test

* uncomment

* show errors in isVisible bindings

* show all errors when widget has faulty binding for isVisible

* handle isVisible faults inside containers
2022-07-18 08:55:32 +05:30
Ayush Pahwa
886359b0a3
fix: UI alignment for key value arrays (#15235)
fix: added required padding for form label div
2022-07-16 17:20:58 +05:30
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
Rishabh Rathod
bd571ffeb8
fix: JSObject AST parsing logic (#14962)
fix AST logic
2022-07-16 16:06:53 +05:30
Arsalan Yaldram
56063ab23d
feat: update dependencies (bot-alerts) (#15124)
* chore(deps): bump async from 2.6.3 to 2.6.4 in /app/client

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: bump moment from 2.29.3 to 2.29.4 in /app/client

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* feat: updated rts folder packages

* feat: remove node-sass

* fix: use marked 3.0.8 instead of marked 4

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-15 17:07:56 +05:30
rahulramesha
b878d5bd01
fix: Update maincanvas height on widget resize, drag or delete operation (#14992)
* fix extra space on canvas

* reverting selector changes

* use updated main canvas minheight

* use default canvas minHeight
2022-07-15 15:57:13 +05:30
Ayush Pahwa
458715f0ac
fix: added default value for switch view type (#15215) 2022-07-15 09:15:08 +02:00
Souma Ghosh
d40a8fd9f2
fix: Compact property not functional for menu widget (#15090)
Fix compact property functionality for menu widget and menu type in table widget
2022-07-14 17:11:03 +05:30
akash-codemonk
c76c052d36
fix: remove the image binding step in guided tour (#15161) 2022-07-14 16:21:24 +05:30
arunvjn
c331f8c330
fix: change edit/launch buttons to anchor tags in applications dashboard (#15168) 2022-07-14 12:34:19 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
Aswath K
3824435f7d
chore: Adds analytics for Property Pane keyboard navigation (#13703)
* Adds analytics for DropdownControl

* Add isUpdatedViaKeyboard to WIDGET_PROPERTY_UPDATE

* fix: jest test for iconselectorcontrol

* refactor: Interaction analytics event dispatching moved to a hook

* refactor: event collection logic to HOC

* Analytics for SwitchControl

* Analytics for CodeEditor

* Analytics for InputTextControl

* Analytics for ColorPicker

* fix issue with ColorPicker

* refactor to re-use ref

* rename the hook to ts

* Analytics for StepControl

* Analytics for ButtonTabComponent

* Analytics for NumericInputControl

* Analytics for IconSelector

* fix: failed test

* Analytics for ActionSelector

* fix: failed jest test

* fix: jest test for StepControl

* Analytics for Option Control

* Analytics for LocationSearchControl

* Adds Analytics for Tab key

* analytics for Property pane connections

* Add analytics for widget name

* Adds analytics for copy & delete button

* fix issue with widget name analytics

* add useCallback for tab keydown handler for button

* Create separate Event handling for design system

* removes unused imports

* changes ADS_EVENT to DS_EVENT

* Changes AdsEventTypes to DSEventTypes

* Changes AdsEventDetail to DSEventDetail

* changes occurences of Ads to DS

* avoids creation of intermediate function

* removes trace of 'analytics' from DS components

* rename dispatchDSEvent to emitDSEvent

* fix: Cypress selector
2022-07-14 10:30:30 +05:30
Anand Srinivasan
59f91b618c
fix: curl import error (#15178)
* send only pageId on curl import creation

* remove variables

* fix data source redirect
2022-07-13 19:24:05 +05:30
Nidhi
02a5e1d490
fix: Added dropdown to select whether to send credentials in header or body in client credentials flow (#14545)
* Added dropdown to select isAuthorizationHeader in client credentials flow

* Added tests

* Added cypress test

* Oopsie
2022-07-13 14:33:19 +05:30
Arsalan Yaldram
8428ae506a
fix: using old versions of marked (#15151) 2022-07-13 13:04:23 +05:30
Pawan Kumar
0a78aa4aed
fix: Not able to right click on app home button in view mode (#15085)
replace button with link
2022-07-13 12:26:59 +05:30
rahulramesha
4dc3ed481c
fix: modal and App viewer header overlap (#15093)
* modal positions calculations on App View mode

* using css variables to compute modal offsets
2022-07-12 21:13:26 +05:30
Ayangade Adeoluwa
2bcc630435
fix: Fix wrong tooltip styling to form controls with no tooltips (#15055)
* Fix wrong tooltip styling to form controls with no tooltips

* Cypress tests for issue

* Resolve typescript error

* Empty-Commit
2022-07-12 14:55:16 +01:00
Ankita Kinger
3f1ae5b417
chore: add back button on individual authentication config pages (#15138)
added back button on authentication config pages
2022-07-12 19:01:11 +05:30
Aswath K
d61a91af8d
fix: initial selected value not getting displayed (#15000) 2022-07-12 12:46:15 +00:00
Tolulope Adetula
d9d1c0c676
fix: dropdown not closing is fixed (#15058)
* fix: Dropdown issues

* CR fix

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-12 17:20:09 +05:30
Hetu Nandu
71a82b4670
feat: Add the Zipy identify call (#15060) 2022-07-11 15:48:24 +05:30
f0c1s
18a8937c5d
fix: accept non-empty commit messages (#15053) 2022-07-11 15:41:33 +05:30
f0c1s
7c77d3fb7c
chore: update messaging for Deploy tab (#14911)
* chore: update messaging for the Deploy tab
2022-07-11 15:40:43 +05:30