Commit Graph

400 Commits

Author SHA1 Message Date
Tolulope Adetula
453974b18e
fix: Multiselection in table widget (#10838)
* fix: Multiselection in table widget

* fix: add test cases
2022-02-08 06:41:25 -08:00
NoxiousPenguin
abb3aebbba
chore: replaced == and != with === and !=== (#10733) 2022-02-05 11:11:15 +05:30
Tolulope Adetula
bb2f7da823
feat: Select and Multiselect V2 (#10359)
* fix: Select V2

* Fix: CI Fail

* fix: failing test

* fix: failing test

* Fix: MultiSelect

* Fix: loading issue

* Fix: loadin state

* Fix: loading

* fix: failing test

* fix: evaluation tests

* Fix: failing tests

* Fix: failing test

* fix: failing tests

* Fix: Failing tests

* fix: select All

* fix: filtering

* Fix: filtering

* fix: refactor Select widget

* fix: hide MultiSelect

* fix: select options

* Fix: failing tests

* fix: failing tests

* Fix: issues

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* fix: PR reviews

* Update EntityDefinitions.ts

* Fix: issues

* fix: console

* fix: QA issues

* fix: options issues

* fix: add widget icons

* fix: update Selectv2

* empty commit to fix CI

* fix: failing test
2022-02-02 06:15:07 -08:00
Vicky Bansal
b99a42acdf
fix: add pre-filled option on adding an option to a checkbox or radio button (#10544) 2022-02-02 17:40:40 +05:30
Tolulope Adetula
ea1ba54603
fix: test case (#10804)
* fix: test case

* fix: dsl

* fix: DSL

* fix: test
2022-02-01 23:52:05 -08:00
Parthvi12
283ef050d4
test: Fixed flaky tests Replay_editor and Table_navigateTo_validation_spec (#10772)
* Fixed flaky tests Replay_editor_spec and TableWidget_NaviagateTo_Validation_spec

* adding fix for ActiveDatasource.spec
2022-02-02 10:52:10 +05:30
Tolulope Adetula
8729c2b435
fix: select treeselect value validation (#10760)
* fix: Select adn treeSelect validation

* fix: remove cy.wait()
2022-02-01 10:54:16 +01:00
albinAppsmith
5cfe12bcea
feat: Entity explorer UI redesign (#9811)
Co-authored-by: arunvjn <arun@appsmith.com>
2022-01-29 12:56:19 +05:30
Rishabh Rathod
b61ceab94b
fix: Add meta to eval cycle and update it when default changes (#10401)
* Rearrange data tree widget factory

* Remove existing handling of default value override

* Altternate way of meta property override

* Fix tests

Co-authored-by: hetunandu <hetu@appsmith.com>
2022-01-28 16:40:05 +05:30
rashmi rai
10b3fe3800
feat: Validations for Action Forms (#10457) 2022-01-27 15:20:05 +05:30
Tolulope Adetula
b89c3100e4
fix: RTE required field (#10629) 2022-01-27 00:37:50 -08:00
Keyur Paralkar
5afff85e8d
fix: changed validation to FUNCTION for the default selected value RadioGroupWidget (#10020)
* fix: changed validation to FUNCTION for the default selected value RadioGroupWidget

* refactor: changed evalued struct msg for radio group default value

* test: added cypress test for checking radiogroup widget with integer value

* test: added jest test to validate the defaultValidation function for radio widget

* refactor: changed the test case title

* chore: updated yarn.lock file

* refactor: addressed the review comments

* refactor: added comment for defaultOptionValidation

* refactor: changed the expected example [QA comment]

* fix: added validationOperationType prop

* Revert "fix: added validationOperationType prop"

This reverts commit 896226fe940621c2c71aa8a9e87831039a9655de.

* fix: added custom validation for the options property

* fix: modififed the custom validation logic

* refactor: modified the cypress test

* refactor: addressed review comments

* refactor: addressed review comments

* refactor: addressed review comments; Updated custom validation for DSV; Update cypress

* refactor: added boolean check for the default selected value

* refactor: addressed review comments

* test: fixed jest test case
2022-01-26 12:48:13 +05:30
NandanAnantharamu
5245984ff8
test: Table Download test (#10571)
* Table Download test

* updated test
2022-01-25 19:37:51 +05:30
akash-codemonk
94d37f55dd
feat: improved guided tour (#9125) 2022-01-25 19:26:52 +05:30
Bhavin K
cd02572374
fix: table column name migration update (#10383)
* fix: table column name migration update

* test: added test case for migration

* fix: migration version update

* fix: update latest version logic

* fix: cypress updated

* fix: updated test case

* fix: delay added

* fix: test case update

* fix/ one more custom column added
2022-01-25 13:54:13 +00:00
Aishwarya-U-R
067d18a84e
test: Skipping JSObjectToListWidgetSpec.ts until open bug is fixed (#10477)
This PR skips tests from JSObject_To_ListWidgetSpec.ts until Bug #10284 is fixed
2022-01-19 17:37:30 +05:30
Tolulope Adetula
70cff3c373
fix: Copy and paste (#10422)
* fix: Copy and paste

* fix: test cases

* fix: onPaste action

* Update index.tsx
2022-01-18 19:54:34 +01:00
Parthvi12
a8eb1d838b
test: Adding fix for Chart_Widget_Loading_spec (#10462)
* Adding fix for Chart_Widget_Loading_spec

* adding wait after reloading

* commenting delete datasource part

* updating test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-01-18 21:07:29 +05:30
balajisoundar
02785b90b2
feat: Input, Phone no., Currency input widget (#10259)
* feat: Input, Phone no., Currency Widget

* cypress tests, jest test, QA and CR callouts

* fix tests

* Cypress and jest test fixes
2022-01-18 13:22:24 +05:30
Keyur Paralkar
d88022939e
fix: added loading state for chart widget (#10262)
* fix: added loading state for chart widget

* test: added cypress tests

* refactor: moved the loading logic from widget to component
2022-01-18 13:21:28 +05:30
Parthvi12
4871035742
test: Adding fix for Table_widget_add_button spec's test (#10423)
* Adding fix for Table_widget_add_button spec's test

* updating test

* commenting changing column type to button in second test
2022-01-17 15:00:58 +05:30
Sumit Kumar
18edb18b20
fix: implement getStructure method for S3 plugin (#8919)
* Add `getStructure` implementation for S3 to return a list of accessible buckets.
* Add command templates for S3.
  - List files
  - Read file
  - Create file
  - Delete file
* Remove getDatasourceMetadata implementation as getStructure method can be directly used now.
2022-01-13 11:33:50 +05:30
Aishwarya-U-R
cc426f1455
test: Automated tests for Promises in Typescript + failure fixes (#10288)
* JSObjects scripting

* storeValue Implemented

* Resolve, AsyncAwait script implementation

* Moved ts tests inside already existing folders

* Then & Catch test script implemented

* Promise.race test script implemented + S3 fix

* JSObject_To_ListWidgetSpec.ts failure fix

* S3 flaky test fix

* createOrg flaky fix

* FilePicker_with_fileTypes_spec.js filename fix

* createOrg flaky fix

* createOrg revert

* JSObject_To_ListWidgetSpec.ts added validations

* .then .catch promises script added

* Added script for Promises Maintaining context

* Added WaitUntilEleDisappear()

* JSObj run fix
2022-01-13 05:23:27 +00:00
Paul Li
6df4ebc1f0
feat: Tab widget should have navigation arrows when the tabs don't fit (#8630)
* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Add scroll navigation control

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Divide tabs navigator control into both sides of contents

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Implement navigation per slide

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Refactor on useEffect dependencies and some calculations
-- Introduce if-else statement for readability and consistency

* feat: Tab widget should have navigation arrows when the tabs don't fit

-- Add class names for scroll navigation controls
-- Narrow the width of Tab widget in dsl
-- Add a Cypress test case for checking the presence of scroll navigation controls

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-12 13:04:28 +08:00
Paul Li
f0fb061dbd
feat: Checkbox group should have a select all option (#8744)
* feat: Checkbox group should have a select all option

-- Add a new property, isSelectAll
-- Implement its functionality

* feat: Checkbox group should have a select all option

-- Set height to auto for select all control
-- Move isInline and isSelectAll properties below isDisabled
-- Set color for options to GREY_9 and GREY_10
-- Add Cypress test cases for handleSelectAllChange

* feat: Checkbox group should have a select all option

-- Fix on misalignment of select all control if isInline is true
-- Refactor the cypress test cases which is affected by adding select all control

* feat: Checkbox group should have a select all option

-- Set white-space to nowrap

* feat: Checkbox group widget should have a select all option

-- Change helpText for isSelectAll property

* feat: Checkbox group should have a select all option

-- Fix on broken test cases for the select all option

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-11 21:26:50 +08:00
Parthvi12
7d257c95fe
test: Autocomplete not working for Appsmith specific JS APIs (#10301) 2022-01-11 16:26:26 +05:30
Keyur Paralkar
843eeb1444
fix: Inconsistency propertypane (#10181)
* issue #8439

* Added color to cell background

* test: fixed existing tests

* test: fixed the backgroundcolor selector issue

Co-authored-by: AR10X <arehamanofficial@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-11 11:08:17 +05:30
akash-codemonk
c533d26a94
fix: filter menu not opening in snippet search (#10229) 2022-01-10 09:55:05 +05:30
Aishwarya-U-R
c711e39849
test: Automated tests for JSObjects in Typescript (#10223)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix

* Bugs # 8595 & 10049 - Implemented

* Updating AGHelper methods to explicit public

* Reverting tsconfig.json

* tsconfig.json reverted

* Adding local tsconfig.json for Cypress tests

* fixture read updating for ts tests

* Updating .yml files to pick up ts files execution

* Including ts files for cypress run

* Running only ts test files

* Inclusion of TS files for cypress run

* Revert cypress.json to run all tests

* Added validation for Bug #10055 & commented

* Flaky fix

* JSObject_To_ListWidgetSpec - Implemented in TS

* Entity_Explorer_JSEditor_spec implemented in TS

* Uncommenting script for Bug 10049, 10055
2022-01-10 09:51:43 +05:30
Paul Li
85d54a7b56
feat: Map Chart widget (#6929)
* FEATURE-6314 : Map Chart Widget

-- Scaffold the widget

* FEATURE-6314 : Map Chart Widget

-- Add a new widget icon
-- Proptotype the property pane for the first time

* FEATURE-6314 : Map Chart Widget

-- Install fusionmaps
-- Draw naive world map for the PoC

* FEATURE-6314 : Map Chart Widget

-- Integrate the limited number of FusionMaps into the widget
-- Bind basic properties and a action into the map

* FEATURE-6314 : Map Chart Widget

-- Comment out the console statements for linting error

* FEATURE-6314 : Map Chart Widget

-- Update dependency versioning

* feat: Map Chart Widget

-- Fix on linting errors, including unused variables, console statement

* Feat: Map Chart Widget

-- Install dependencies from scratch

* fix: increased max chink size allowed in the build config

* Feat: Map Chart Widget

-- Refactor code base according to the changed widget structure
-- Add cleanup for removing event listener
-- Eliminate the unnecessary codes, comments

* Feat: Map Chart Widget

-- Remove unnecessary icon
-- Refactor on constants

* Feat: Map Chart Widget

-- Add a cypress test case for map type changes
-- Add a cypress test case for title change
-- Add a cypress test case for toggling show labels
-- Add a cypress test case for onEntityClick event listener

* feat: Map Chart Widget

-- Scaffold the setup for custom map config

* feat: Map Chart Widget

-- Dynamically import map definition files

* feat: Map Chart Widget

-- Eliminate unnecessary comments

* feat: Fusion Maps Widget

-- Update base dependencies

* partial map chart changes.

* feat: Map Chart Widget

-- Refactor entire code base, removing custom configs
-- Disable prefetching on mapCharts chunk

* feat: Map Chart Widget

-- Comment onEntityClick test case out

* feat: Map Chart Widget

-- Fix on onEntityClick test case

* feat: Map Chart Widget

-- Change the widget icon
-- Rename onEnityClick to onDataPointClick
-- Expose selectedDataPoint
-- Add a new Cypress test case for the toast message on onDataPointClick

* feat: Map Chart Widget

-- Add a new property colorRange
-- Add default values for data and colorRange properties
-- Eliminate unnecessary constant colorRange

* feat: Map Chart Widget

-- update selectedDataPoint meta property unconditionally

* feat: Map Chart Widget

-- Update initial map type config to be consistent with the corresponding property

* feat: Map Chart Widget

-- Add widget icon for entity explorer

* feat: Map Chart Widget

-- Make array elements of data, colorRange properties unique

* feat: Map Chart Widget

-- Prevent re-render when disabling color codes and double-clicking on entities

* feat: Map Chart Widget

-- Declare defaultChartConfigs variable inside component class
-- Replace deprecated substr method with substring

* feat: Map Chart widget

-- Complement validation rules for data property

* feat: Map Chart widget

-- Define rows and cols without using GRID_DENSITY_MIGRATION_V1
-- Change updateDataSet hook by replacing switch statement with object mapping

* feat: Map Chart widget

-- Pull out dataSetMapping from the updateDataSet hook

* feat: Map Chart widget

-- Force click events with regard to onDataPointClick test cases

* feat: Map Chart widget

-- Update fusioncharts and fusionmaps npm packages to the latest version

* feat: Map Chart widget

-- Make contents responsive using CSS styles instead of directly changing width, height attributes of the chart

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-07 17:57:45 +08:00
Aishwarya-U-R
ac705a49f3
test: Automated tests for RestApi Bug in Typescript (#10137)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix

* Bugs # 8595 & 10049 - Implemented

* Updating AGHelper methods to explicit public

* Reverting tsconfig.json

* tsconfig.json reverted

* Adding local tsconfig.json for Cypress tests

* fixture read updating for ts tests

* Updating .yml files to pick up ts files execution

* Including ts files for cypress run

* Running only ts test files

* Inclusion of TS files for cypress run

* Revert cypress.json to run all tests

* Added validation for Bug #10055 & commented

* Flaky fix
2022-01-06 20:36:17 +05:30
NandanAnantharamu
ddd852c5dd
Added test for file types (#10156) 2022-01-06 11:31:53 +05:30
Pawan Kumar
028fe42dd2
fix: Select widget if set to required on initial state has red border (#9378)
* fix select widget error bug

* fix jest test

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-01-05 13:43:25 +00:00
Favour Ohanekwu
b703ceb69f
fix: remove duplicate query params in evaluated value (#10101)
Remove duplicate query parameters in evaluated value
2022-01-04 10:27:38 +01:00
Yash Vibhandik
a6a462cf68
feat: #4141 added truncate support into text widget (#9820)
* feat: #4141 added truncate support into text widget

* fix: updated truncate show logic, cypress added

* fix: updated ellipsis position

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-01-04 11:51:02 +05:30
Vicky Bansal
c9ec218b79
fix: change recaptcha key and type and add suggestion for recaptchaToken (#9464)
* Change recaptcha key and type and add suggestion for recaptchatoken

* Add recaptchaToken property as target for auto completion cypress tests

* Added cypress test to validate recaptcha v2 can be selected in button widget property pane

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-02 08:27:39 -08:00
Aishwarya-U-R
d71a873e16
test: Automated tests for Flakiness fixes (#10040)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix
2021-12-31 11:58:47 +05:30
Keyur Paralkar
40ba88ce57
fix: added selectedOptionValue for index change in changeSelectedOption func Dropdown widget (#10047)
* fix: added selectedOptionValue for index change in changeSelectedOption func Dropdown widget

* test: added cypress test for select reset issue
2021-12-31 11:00:17 +05:30
balajisoundar
467f9ee1c2
fix: Allow empty value in multiple widgets options property (#10012)
- Checkbox group widget
- MultiSelecttree widget
- Multiselect widget
- dropdown widget
- radio group widget
- single select tree
- switch group widget
2021-12-30 14:57:44 +05:30
Vicky Bansal
f05c92603e
fix: Improper formatting for Input Widget for DataType currency (#9050)
* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Add comments for utilities formatCurrencyNumber and limitDecimalValue

* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Fix Input currency type cypress test

* Add comments for utilities formatCurrencyNumber and limitDecimalValue

* Fix upstep and downstep button action for formated currency input

* remove crendentials from cypress.json

* Fix input currency test flakiness

* Fix cypress test for currency input type

Fix formatCurrencyNumber function and added more unit tests

* Fix cypress test for currency input

Handle group separator and decimal separator when formatting and deformatting input for currency type

* remove console.log

* Handle formatting changes for default text

* Format input widget value for currency to handle default text

* remove unused import

* Add unit tests for getGroupSeparator and getDecimalSeparator functions

* add function to get user locale

* use preventDefault in input increment/decrement button click

* Use getLocale function, use String function

* use Number function for type conversion

* fix number to string type

* Handle 0 value for numbers

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-30 00:40:01 -08:00
Vicky Bansal
2d645b7e8d
fix: disable submit button when date is out of bounds (#9552)
* disable submit button when date is out of bounds

* Remove comment from derived.js function as comments are not allowed for parsing

* Fix table client side search cypress test

* validate date again min/max irrespective of isRequired property
2021-12-30 00:38:40 -08:00
Tolulope Adetula
54bb8bffe0
fix: rich text editor cursor fix (#9889)
* fix: rich text editor cursur fix

* fix: failing tests

* fix: debounce callback

* fix: Throw away any pending invokation

* fix: use SetTimeout for deboucing

* fix: markdown issues

* fix: onTextChange on page load

* fix: failing test
2021-12-30 00:01:45 -08:00
Bhavin K
323fa52455
feat: add progressbar widget (#9574) 2021-12-29 17:31:19 +05:30
Bhavin K
e995865b28
fix: updated columns names (#9715) 2021-12-29 17:12:07 +05:30
Yash Vibhandik
29687f9f12
feat: 8761 added optionAlignment property (#9696) 2021-12-29 07:22:10 +00:00
Aishwarya-U-R
3a4db6bdfd
test: Automated tests for S3 uploads & Mongo Bugs + Flakiness fixes (#9931)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()
2021-12-29 11:11:30 +05:30
Favour Ohanekwu
c96c0d4f3b
feat: Show evaluated value in embeddedDatasource url (#9198)
Show evaluated value in embeddedDatasource url
2021-12-28 13:14:32 +01:00
balajisoundar
8c6bae6f71
fix: allow updating computed values of table widget in view mode (#9817)
* fix: allow updating computed values of table widget in view mode
* cypress tests
2021-12-28 12:45:28 +05:30
rashmi rai
f6b9abdacf
feat: adding ads component for UQI (#8777) 2021-12-27 17:34:45 +05:30
Parthvi12
b82ea06aa3
test: Adding visual tests for layout validation (#9857)
* Adding visual tests for layout validation

* updating screenshot to match CI's screenshot resolution

* updating screenshot as per CI

* setting failure threshold for the image comparision

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-24 17:47:22 +05:30