Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
6,919 Commits 1 Branch 0 Tags 507 MiB
e0273ecc03
Commit Graph

5203 Commits

Author SHA1 Message Date
vicky-primathon.in
3dc6e0884d Added cypress test case to test multi selected dropdown options are cleared in form reset 2021-04-12 13:07:05 +05:30
Vicky Bansal
d6399c2e48
Disable pagination controls when the table has a single page (#3895) 
* Disable input number field when there are no pages to navigate to

* Added cypress test to validate table pagination is disabled
 2021-04-09 16:06:50 +05:30
Vicky Bansal
791e8195b1
Align column headers when aligning columns (#3885) 
* Align table column header title with table columns

* Added cypress test to validate column header text alignment
 2021-04-09 16:04:01 +05:30
Vicky Bansal
43720123d8
Fix: Select Table Widget when a row is selected (#3871) 2021-04-09 16:03:22 +05:30
vicky-primathon.in
53d1333530 use derivedProperty selectedIndexArr instead of computing selectedIndexes 2021-04-09 15:50:48 +05:30
Nidhi
4bddfa0a4e
Fixed curl import without valid tokens (#3933) 2021-04-09 14:03:53 +05:30
vicky-primathon.in
1db50eb527 Custom scrollbar changes 2021-04-09 12:34:31 +05:30
Sumit Kumar
9c8bce0415
Feature: return data types of returned data on query execution for better data display (#3914) 
- Return data type list along with action execution result so that the data can be displayed in the correct format.
- Handles these three data types for now : table, json, raw.
  - If a plugin has already assigned the data type, then common handler is not used.
  - Mongo plugin assigns the data types in the plugin specific flow i.e. does not use the common data type parse / assign method.
- To address review comments:
  - added a new enum ActionResultDataType for data types. It is consumed by ParsedDataType. A list of ParsedDataType is returned by ActionExecutionResult
  - parsed data in parallel using streams.parallel().
 2021-04-09 10:58:37 +05:30
Nidhi
4f68d5f472 Logging test failure 2021-04-08 19:53:48 +05:30
Nidhi
13a3e8f240 Applying AOP encryption 2021-04-08 16:58:45 +05:30
Rishabh Saxena
d8f2211b70
Fix edit and fork buttons visible simultaneously on the viewer header (#3723) 2021-04-08 14:12:13 +05:30
Kaushik Varanasi
c37adc0a4d
Fix spacing of fields in org settings: fixes (#3612) (#3681) 
* add row colums styling to organisation settings fields

* add tests to make sure the grid layout is rendered

* added margin to make spacing look similar to before

* remove negative margin and reduce width

* added jest tests to make sure component mounts and that it has correct styles

* revert unnecessary changes related to cypress tests

* added strict checking for null to avoid ts errors

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* fixed typo

* added findbytext for sync call

* removed unused imports

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2021-04-08 11:20:26 +05:30
Sumit Kumar
41e44eed30
Feature: add title to action execution errors to improve user experience (#3872) 
- add title to action execution errors to improve user experience
    - all errors in AppsmithPluginErrors
    - action execution related errors in AppsmithError : NO_CONFIGURATION_FOUND_IN_DATASOURCE, INVALID_ACTION, INVALID_DATASOURCE, INVALID_DATASOURCE_CONFIGURATION - as these are the likely errors in an action execution flow (excluding plugin specific flow) that might result from faulty action / datasource configuration by a user.
    - title is returned as part of ActionExecutionResult.
    - title is set in ActionExecutionResult on failure during action execution.
    - In response to review comment - added a new BaseException class, so that both AppsmithException and AppsmithPluginException extend this base class. Also, refactored code to introduce setErrorInfo() function in ActionExecutionResult class to set its attributes.
- Some unrelated cleanup:
    - catch PoolInitializationException for Postgres plugin and return AppsmithPuginException
    - catch MongoTimeoutException and return AppsmithPluginException
 2021-04-08 09:49:05 +05:30
Trisha Anand
174ef284f0
[Bug Fix Improvement] : Table widget keys are unescaped after walking through the DSL (#3908) 
* WIP : untested

* Minor refactoring

* Added test case to assert escaping and unescaping of the table widget primary column keys
 2021-04-07 19:36:37 +05:30
Trisha Anand
df993efcde
Updated the DSL to change primary columns for an array to a map structure in the DSL (#3905) 2021-04-07 18:22:52 +05:30
Hetu Nandu
28995e5b53
Fix PS and smart substitute true false value (#3896) 2021-04-07 16:06:17 +05:30
Nidhi
927a6a3479
Annotation based encryption (#3610) 
* Annotation set up

* Removed annotation uses

* Redundant condition

* Commented out logging, retained for implementation

* Handling for Collection and Map parameterized types

* Removed comments
 2021-04-07 15:27:36 +05:30
Trisha Anand
4bf74f6434
Bug Fix : Escaping _id and _class from Table PrimaryColumn keys before storing the DSL (#3887) 
* Bug Fix : Escaping _id and _class from primary column keys before storing the DSL

* Fixed the test case failures.

* Updated the replacement strings for _id and _class to include appsmith keyword
 2021-04-07 13:21:18 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
NandanAnantharamu
547a9a7ee0
Added tests for Oauth and Stubbed tests (#3463) 
* Added tests for Oauth and Stubbed tests

* updated tests

* test updated

* updated DS tests

* review comments incorporated

* flag removed

* postinvite stubbed

* intercept req added and chromewebsecurity flag added

* Update app/client/cypress/support/commands.js

* updated header request

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2021-04-06 18:59:27 +05:30
Hetu Nandu
5a1584377b
Update editor.json for Postgres, Mongo, MySQL, MS-SQL adding evaluation type (#3884) 
Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-04-06 18:27:51 +05:30
vicky-primathon.in
b2ab89c2c5 add react custom scrollbar types 2021-04-06 17:01:52 +05:30
Hetu Nandu
8bdc491a81
Hot fix for plugin form not downloaded for onboarding (#3879) 2021-04-06 15:47:25 +05:30
Rishabh Saxena
d13f755ba8
Update GTM script (#3711) 2021-04-05 20:54:22 +05:30
NandanAnantharamu
8cd6c95e70
updated table property pane test (#3837) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2021-04-05 17:25:27 +05:30
Trisha Anand
4a087b172c
Feature : BSON Smart Substitution in Mongo Plugin (#3804) 
* Feature : JSON Smart Substitution in Mongo Plugin

* Added BSON data type for Mongo substitution. Added test case

* Minor comment added

* Minor variable re-naming and correcting failing test cases.

* REST API : Escaping special characters in string before smart substitution

* Incorporated review comment
 2021-04-05 17:12:29 +05:30
Sumit Kumar
00bcac7591
add support for 'prefer' ssl mode in postgresql. (#3848) 
- add support for 'Prefer' ssl option for postgres plugin.
 2021-04-05 15:51:17 +05:30
Apeksha Bhosale
48790ce6ca
Array support hidden field (#3809) 2021-04-05 15:41:04 +05:30
vicky-primathon.in
a24f8ae6ae Added react-custom-scrollbars 2021-04-05 14:52:55 +05:30
Kaushik Varanasi
8f8b7b281f
Fixes error on failed github docs fetch (#3665) 
fixes #3551
 2021-04-05 14:07:04 +05:30
Vicky Bansal
6b26e400a8
Bug fix for table crash #3645 (#3849) 2021-04-04 01:10:12 +05:30
Hetu Nandu
af5f6544ea
Always guarantee to fetch Api plugin forms (#3847) 2021-04-02 15:17:37 +05:30
Rishabh Saxena
244930dd69
Add support of component unit testing (#3828) 
Update jest config, add msw hooks
 2021-04-02 15:17:16 +05:30
Abhinav Jha
28921e0324
Fix table width on drag (#3839) 2021-04-02 13:48:30 +05:30
Trisha Anand
1e72cf279e
Bug Fix : If binding is present in commented part, ignore the exception (#3832) 2021-04-01 22:14:00 +05:30
Sumit Kumar
3140e98146
modify hint message to include fix (#3829) 
Modify hint message to include fix.
 2021-04-01 17:10:30 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Arpit Mohan
91a7acea49
Adding table plugin in the Rich text editor (#3799) 
* Add Table button in RTE Toolbar

Co-authored-by: Aswath K <aswath.sana@gmail.com>
 2021-04-01 13:54:42 +05:30
Shrikant Sharat Kandula
efec01344a
Clone explicitly set datasource for new users (#3793) 2021-04-01 12:44:44 +05:30
Nidhi
9f8cb59a04
Null handling for bad state in OAuth2 callback (#3810) 
* Null handling for bad state in OAuth2 callback

* Handling null

* Another case for when state is present but not as expected
 2021-04-01 10:41:11 +05:30
dependabot[bot]
68e405a746
Bump y18n from 4.0.0 to 4.0.1 in /app/client (#3817) 
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-04-01 10:39:29 +05:30
Apeksha Bhosale
1f216167c4
removing new lines while showing url path field (#3717) 
* added 2 states for path field

* added logic for compact only

* added small condition for no compact

* PR comments fixed

* removed redundant code

* added unit test for code editor functions

* Update app/client/src/components/editorComponents/CodeEditor/index.tsx

* setting cursor

setValue is resetting cursor position to the front.  so will update at the end

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2021-03-31 17:58:29 +05:30
Apeksha Bhosale
834fc3caf7
showing save datasource option all time (#3695) 
* showing datasource

Exposing 'save as datasource' with empty path but in disable state till value is entered

* sending flag instead of value

* removed classname

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-03-31 16:09:13 +05:30
Rishabh Saxena
7ffc0d3786
Ignore cypress/no-unnecessary-waiting (#3794) 2021-03-31 14:05:19 +05:30
Hetu Nandu
0c77051944
Improve performance monitoring (#3790) 2021-03-31 13:10:59 +05:30
Ashok Kumar M
3bce03173a
Fix: Property pane improvements and bug fixes (#3766) 
* Fix: Propane improvements bug fixes

* Adding plus indicator for New modal action.
 2021-03-31 11:21:24 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Aswath K
a6afa8ce4d Makes isFilterable true by default for DropdownWidget 2021-03-31 08:42:27 +05:30
Aswath K
b447aa8345 Allow removing filter on Dropdown Widget 2021-03-31 00:35:17 +05:30
Sumit Kumar
efa4ae072c
Firestore plugin support for FieldValue.delete() and FieldValue.serverTimestamp() values (#3693) 
- Allow users to define key path for FieldValue.delete() and FieldValue.serverTimestamp() values.
- delete() value is only valid for update operation, as Firestore does not seem to support it for any other ops.
- serverTimestamp() is valid for all operations excluding get and delete operations.
 2021-03-30 17:19:24 +05:30
Trisha Anand
aab75bf304
Bug fix : App viewer inviting another app viewer would assign correct permissions to applications 2021-03-30 17:05:44 +05:30
Sumit Kumar
7dbae1e481
fix regex for whitespace (#3761) 
- fix regex for whitespace
 2021-03-30 15:03:39 +05:30
Abhinav Jha
10159fc442
Fix #3752 DatePicker tries to auto parse the defaultDate (#3753) 2021-03-30 14:32:25 +05:30
Hetu Nandu
aec7e613ad
Update dropdown font size and shadow (#3680) 2021-03-30 14:18:14 +05:30
Ashok Kumar M
984fbecac5
Fix: Adding debounce for renaming tabs. (#3758) 2021-03-30 13:44:25 +05:30
Pawan Kumar
d8b9b8e918
Fix: TypeError: e.widgetName is undefined and TypeError: Cannot read property 'toUpperCase' of undefined (#3694) 
* call toUpperCase() only when widgetName exists

* use lodash instead of string class functions

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
 2021-03-30 11:20:00 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
dependabot[bot]
b4b903278c
Bump lodash-es from 4.17.11 to 4.17.14 in /app/client (#3738) 
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-03-30 10:38:34 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748) 
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
 2021-03-29 21:17:22 +05:30
Rishabh Saxena
3f55e16b35
Fix onboarding test spec: check res instead of req to verify if the datasource was created successfully (#3747) 2021-03-29 19:51:50 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)" 
This reverts commit 3437c16ef0.
 2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561) 
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
 2021-03-29 15:28:52 +05:30
Apeksha Bhosale
8983940a30
Merge pull request #3659 from appsmithorg/fix/new-field-POST-change 
Added index check to add content type in existing field
 2021-03-29 15:26:03 +05:30
Arpit Mohan
60400da94a
Fixing signed URL request for AWS S3 in Rest API plugin (#3734) 
* added empty byte array for request body to fix aws signed url signature match problem as detailed here - https://github.com/aws/aws-sdk-java/issues/2205

Co-authored-by: Bernard Worthy <>
 2021-03-29 12:58:57 +05:30
Hetu Nandu
55f65a9fe5
fix default override same value (#3691) 
Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-03-29 12:44:16 +05:30
Trisha Anand
554c45eef8
[Bug Fix] Prepared Statement -String starting with a number recognized as JSON object instead of String (#3710) 
* String starting with float like 2.1 recognized as JSON object instead of String.

* Incorporated review comments.
 2021-03-29 12:22:06 +05:30
dependabot[bot]
00477fe686
Bump guava from 28.1-jre to 29.0-jre in /app/server/appsmith-server (#3728) 
Bumps [guava](https://github.com/google/guava) from 28.1-jre to 29.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-03-29 00:20:04 +05:30
vicky-primathon.in
b153a0e78a Show header scrollbar always if needed 2021-03-27 11:36:42 +05:30
Trisha Anand
b9fd72e89d
Smart Substitution Debugging - Adding Appsmith data type to each parameter in response's request object for execute (#3716) 
* Smart Substitution Debugging - Adding appsmith data type to each parameter in response's request object for execute

* Incorporated review comments.

* Fixed failing test cases.

* Fixed MS-SQL test failures.
 2021-03-26 23:29:12 +05:30
Nidhi
683176fc48
Increased default limit for webclient payload (#3718) 
* Increased default limit for webclient payload
 2021-03-26 21:34:10 +05:30
Sumit Kumar
e347b61e53
Return hint on localhost url (#3611) 
- Return hint for localhost URL on the following events:
Test datasource
Save datasource
Update REST API Url
Create datasource from REST API
When page gets loaded for first time.
- Hint message returned: "You may not able to access your localhost if Appsmith is running inside a docker container or on the cloud. Please check out Appsmith's documentation to understand more."
- It has been decided as part of actions pod meeting that these messages will not be persisted.
 2021-03-26 15:42:34 +05:30
prapullac
d9417dc043
Adding test ideas for Switch widget (#3490) 
* adding test ideas for Switch widget

* reset  widget for date change
 2021-03-26 14:08:10 +05:30
Apeksha Bhosale
84ebd4324f
Updated link for datasource whitelist url (#3679) 2021-03-26 13:41:15 +05:30
Trisha Anand
c420d0207f
Supporting timestamp datatype in Prepared Statement (#3690) 
* WIP : Adding timestamp datatype in Prepared Statement

* Added simple tests for commonly used data types' identification

* Added plugin level test cases for timestamp with Prepared Statement to Postgres
 2021-03-26 13:19:22 +05:30
prapullac
cee1b86f32
Adding test ideas for Edit profile (#3700) 2021-03-26 12:51:46 +05:30
Rishabh Saxena
973a70a624
Fix editor help menu background color and icon size (#3686) 2021-03-26 12:18:15 +05:30
Apeksha Bhosale
eab1f8372a Merge branch 'release' into fix/new-field-POST-change 2021-03-26 09:33:52 +05:30
abhishek nayak
5114ca75c4
Merge pull request #3706 from appsmithorg/fix/filteredData-columnProperties 
Fix #3381: Table column properties now map correctly when filtering, sorting or searching
 2021-03-26 01:30:03 +05:30
Abhinav Jha
5b3547c104 Fix filter condition functions 
Fix issue where column properties don't update based on filters and sorting and search
 2021-03-26 01:18:40 +05:30
vicky-primathon.in
ea701de662 Added unit tests 2021-03-25 23:58:09 +05:30
vicky-primathon.in
45d7a5fe0b Added unit tests 2021-03-25 23:46:56 +05:30
vicky-primathon.in
b6f21b00e0 Added unit tests 2021-03-25 23:28:51 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
vicky-primathon.in
e79f6c8806 Fix horizontal and vertical table scrollbars 
Hide scrollbars during resize
 2021-03-25 21:46:22 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests (#3501) 
* added test with switch widget within farm widget

* Added another usecase with Switch

* added wait

* updated locators

* minor update

* add locators for switch widget spec

* removed waits and replaced with suitable assertions

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-25 21:38:16 +05:30
Trisha Anand
ed1a0b4045
Refactor the smart substitution code to extract common code at plugin interface level. (#3497) 2021-03-25 19:10:42 +05:30
NandanAnantharamu
378330815b
Added test for tableWidget bug (#3528) 
* Added test for tableWidget bug

* updated test

* review comment incorporated

* updated collapse pane test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-03-25 16:31:51 +05:30
Trisha Anand
c6e4f91ffb
[Bug fix] A lax search for presence of binding during save page to match client algorithm to reduce page save error (#3698) 
* Lax mustache binding check added to match the client side check when client recognizes a field to have a dynamic binding. This would reduce/remove bad bindings from throwing a 400 during save page.

* Added a test to assert that update layout does not fail in case the binding is technically incorrect because part of the mustache's lie inside quotes. Since client has a lax way of finding a dynamic path, server also follows suite.
 2021-03-25 16:00:45 +05:30
Rishabh Saxena
f2160d61e1
Fix onboarding Cypress test (#3678) 2021-03-25 13:23:56 +05:30
Trisha Anand
1a9a410c5e
Stringifying the binding name before setting in the error to ensure client can parse it correctly (#3689) 2021-03-25 12:36:56 +05:30
Apeksha Bhosale
4c464787a1
code folding in response and request (#3658) 2021-03-25 10:57:00 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670) 
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
 2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string (#3397) 2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Sumit Kumar
cb9df80694
change default value of s3 file data type on create file action (#3685) 
- modify default value for s3 on file create to Yes.
- change dropdown option names to base64, text from yes, no.
 2021-03-24 15:02:13 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-24 14:33:48 +05:30
Vicky Bansal
06231e0f5f
Fix crash on Tabs property bindings (#3640) 2021-03-24 14:28:00 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-03-24 14:23:39 +05:30
Hetu Nandu
9a4c317f20
Store value improvements (#3663) 2021-03-24 10:39:47 +05:30
Sumit Kumar
56f22edbe8
Return hint message on identical columns (#3656) 
- Return hint message if identical column names are found in SQL query for postgres, MySQL, mssql, redshift plugin.
- Add a PluginUtils class to hold general utility functions for plugins.
 2021-03-24 08:22:49 +05:30
Nidhi
992da806bf
Added dummy instances to UI matrix (#3683) 2021-03-24 08:18:19 +05:30
abhishek nayak
2e53c79464
Update ForkApplicationModal.tsx 2021-03-24 00:35:46 +05:30
vicky-primathon.in
f4d25f6b2e Renamed ScrollIndicator to VerticalScrollIndicator 
Common css moved to DefaultTheme
 2021-03-23 20:51:13 +05:30
prapullac
9da0d7abf6
Added test ideas for Table and Hide feature of the page (#3594) 2021-03-23 17:56:31 +05:30
Shri
a18e569f7d
Fix data serialization in analytics (#3677) 
* Serialize object fields before sending to analytics

* Push event when application is published
 2021-03-23 17:13:02 +05:30
Apeksha Bhosale
28a4b4a6d6 test case fixed 
it was checking 3rd key:value pair for content type but with changes it will added to first empty field (0th)
 2021-03-23 16:55:21 +05:30
Apeksha Bhosale
5d71e86f43 Test case and refactor code 2021-03-23 15:14:44 +05:30
Hetu Nandu
2dd1791810
Refactor and add unit tests to API interceptors (#3647) 2021-03-22 14:52:24 +05:30
Hetu Nandu
f345619f40
Fix code coverage generation file (#3655) 2021-03-21 12:02:47 +05:30
Hetu Nandu
f1cb2a35b7
Add jest coverage diff reporting action (#3651) 2021-03-20 19:28:10 +05:30
Sumit Kumar
38c5639542
Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins. (#3518) 
- Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins.
- Added a new option default, apart from the the SSL mode types supported by the driver. Default means that go with whatever default configuration driver provides.
 2021-03-19 15:03:56 +05:30
Hetu Nandu
52c7f5331a
Trigger client integration only on approved PRs (#3632) 
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
 2021-03-19 14:21:14 +05:30
Hetu Nandu
64116583e3
Fix container widget dynamicBindingPathList correction (#3619) 2021-03-19 11:39:35 +05:30
NandanAnantharamu
a82c789c1a
udpated tests (#3617) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-19 11:19:54 +05:30
Nikhil Nandagopal
6b7fcc4c5d
Merge pull request #3615 from appsmithorg/minor-globalsearch-fixes 
Minor globalsearch fixes
 2021-03-19 11:17:00 +05:30
vicky-primathon.in
5fa3f3abd9 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-19 00:39:24 +05:30
vicky-primathon.in
bb77794125 handle scrollbar changes 2021-03-19 00:39:13 +05:30
Nidhi
93d5a061e2
Added logs and analytics (#3622) 
* Added logs and analytics

* Fix in error string

Co-authored-by: Shri <shrikant@appsmith.com>

* Review fixes :)

Co-authored-by: Shri <shrikant@appsmith.com>

Co-authored-by: Shri <shrikant@appsmith.com>
 2021-03-18 21:48:13 +05:30
Shri
bb1d0059d3
Clear OAuth tokens for forked datasources (#3609) 
* Clear OAuth tokens for forked datasources

* Fix datasource duplicate finder in light of oAuth tokens

* Fix potential NPE
 2021-03-18 21:08:56 +05:30
Kaushik Varanasi
55c17a66aa
Fix success message for single user invite and multiple user invite (#3591) 
* Fixed error message for single user invite

* updated success message for single user invite and created tests

* use state to detect and update the number of users invited

* removing unnecessary lines

* typo
 2021-03-18 19:20:33 +05:30
hetunandu
12aba25a00 Remove page save event from frontend 2021-03-18 19:15:57 +05:30
Pawan Kumar
80895b876b
Enhancement: Virtualized Query Editor Table (#3496) 
* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

* fix height issue in virtualized table

* useBlockLayout in Table

* add border-right on table row

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-18 18:40:57 +05:30
Rishabh Saxena
8acb365201 Fix placeholder 2021-03-18 18:19:05 +05:30
Rishabh Saxena
660b00b4d5 update title 2021-03-18 18:17:09 +05:30
Rishabh Saxena
82cd1b33ba fix document icon styles 2021-03-18 18:14:37 +05:30
vicky-primathon.in
354405d975 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-18 13:01:36 +05:30
Kaushik Varanasi
5f80e2561e
Merge pull request #3572 from appsmithorg/bugfix/trunncate-org-name-settings 
add ellipsis to org name in settings
 2021-03-18 12:39:52 +05:30
vicky-primathon.in
fb7cea6ec6 Resolved conflicts 2021-03-18 11:07:16 +05:30
ram-primathon
8b21dd30fd
add icon and subText in ads dropdown (#3598) 2021-03-18 02:06:26 +05:30
Hetu Nandu
441bb368d2
Reduce flakiness by adding waits (#3605) 2021-03-18 02:02:16 +05:30
Hetu Nandu
0debe37637
Add arbitary wait on onboarding test (#3604) 
We recently changed the test to make sure we wait for the client to create an onboarding data source if it did not exist. This kind of check was also happening on the source code, and the complexity was not getting translated properly in the tests.

To improve the reliability of the test, I added an arbitrary wait time before we start the building
 2021-03-17 23:59:40 +05:30
vicky-primathon.in
5f2d994fda Fix double imports 2021-03-17 18:00:16 +05:30
Vicky Bansal
1195a0b694
Reset selected row(s) when table data is changed (#3576) 
* Fixed selected row resets when table data is changed

Added cypress test case to test selected row resets when table data changes

* Fixed cypress test case
 2021-03-17 17:27:38 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30
vicky-primathon.in
9e65136a75 Merge branch 'fix/table-scrollbar' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:21:37 +05:30
vicky-primathon.in
212cd423b5 Added horizontal scrollbar component 
Add horizontal and vertical scrollbars in table widget
 2021-03-17 17:15:49 +05:30
Nidhi
084faf8d54
Typo ¯\_(ツ)_/¯ (#3595) 2021-03-17 17:04:53 +05:30
Hetu Nandu
b32cdfc8cb
Remove property pane custom scrollbar for cypress (#3592) 2021-03-17 15:56:34 +05:30
Rishabh Saxena
0e3901953b
Fix specs (#3577) 2021-03-17 15:06:08 +05:30
Kaushik Varanasi
8fd0509bcb Merge branch 'release' into bugfix/trunncate-org-name-settings 2021-03-17 12:45:13 +05:30
NandanAnantharamu
8aca378028
updated flaky test (#3584) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-17 10:38:00 +05:30
Kaushik Varanasi
f9d2318e5a reconciling with current release 2021-03-17 00:22:01 +05:30
Kaushik Varanasi
dfa23a6944 added tests, documentation and better naming convention 2021-03-17 00:18:36 +05:30
Apeksha Bhosale
3dc04901c8 added index check to add content type in existing field 2021-03-16 19:57:21 +05:30
Shri
cbd7828503
Add migration to remove template organization config (#3568) 2021-03-16 15:29:06 +05:30
Kaushik Varanasi
2dcecfbf79 add ellipsis to org name in settings 2021-03-16 13:22:25 +05:30
hetunandu
eed140f945 stringify page save analytics 2021-03-16 11:01:48 +05:30
Ashok Kumar M
fc34901be8
Fix: Dynamic Canvas Height based on bottom most widget. (#3398) 
* Fix: Dynamic Canvas Height based on bottom most widget.

* Checking cytest failure reason.

* Revert "Checking cytest failure reason."

This reverts commit 2e3aaa882b282e10e1cf491633101293b72ffa89.

* Using UPDATE_CANVAS_LAYOUT to update the layout.

* Remove unwanted declarations.

* Adding comments.
 2021-03-16 10:31:37 +05:30
Shri
e1fb1203b5
Application forking fixes and improvements (#3519) 
* Clone only those datasources that are actually used

* Retry when cloning app causes a name class

* Search for an existing datasource before cloning

* Test deep matching of datasources

* Refactoring, since now the tests pass

* Allow forking of owning applications

* Don't limit datasource naming suffix number
 2021-03-15 22:19:40 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057) 
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-15 17:47:56 +05:30
Vicky Bansal
03be391fa3
Wrap evaluated data in computed value field (#3520) 2021-03-15 15:27:43 +05:30
Vicky Bansal
7c994da6e9
Allow null/empty values in Dropdown widget options (#3533) 2021-03-15 15:25:37 +05:30
Vicky Bansal
5acf2c3238
Fully display Table Widget filter conditionals (AND|OR) (#3521) 2021-03-15 14:39:10 +05:30
Vicky Bansal
812344c439
Persist Table Widget cell height to use as default in deployed app view (#3537) 2021-03-15 14:34:33 +05:30
Vicky Bansal
030269f684
Display the date column output correctly in table when using JS toggle for Display date format 2021-03-15 10:59:01 +05:30
Vicky Bansal
7f43705e7f
Fixed undefined poperty error when columnOrder is undefined (#3511) 2021-03-15 10:57:34 +05:30
Shrikant Sharat Kandula
3d6bd51556
Fix NPE in action execution analytics (#3541) 
The NPE noticed is with the return value of `.getStatusCode`.
But this PR adds NPE guards to a few other potential cases.
 2021-03-14 07:58:27 +05:30
Rishabh Saxena
3a47e085e3
Minor global search updates (#3502) 
* Update editor header help button styles

* Dont show the current entity in the recents, to keep the previous on top
 2021-03-13 23:31:47 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798) 
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-03-13 19:54:45 +05:30
Hetu Nandu
89effdd2fb
Refactor evaluate function and add tests (#3536) 2021-03-13 19:42:21 +05:30
Rishabh Saxena
7bd1e9587c
Use replace instead of replaceAll (#3538) 2021-03-13 16:15:51 +05:30
ram-primathon
191dde0b18
Fix API pane header and params count (#3494) 2021-03-13 13:53:46 +05:30
vicky-primathon.in
c952e9b10d Remove unnecessary scrollbar from inside table widget 2021-03-13 12:06:02 +05:30
Nikhil Nandagopal
3b2072eeb9
Merge pull request #3055 from appsmithorg/fix/rte-newline 
Added defaultText and defaultHTML properties in RTE
 2021-03-12 17:38:58 +05:30
Nikhil Nandagopal
261dfc308c
Merge pull request #3514 from appsmithorg/fix/file-picker 
[Fix] Made bade 64 encoding the default type for S3
 2021-03-12 16:29:05 +05:30
vicky-primathon.in
3da86b33fe Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-03-12 15:24:51 +05:30
Nikhil Nandagopal
6bdd39c4b8 minor fixes 2021-03-12 14:47:42 +05:30
Nikhil Nandagopal
dbb16775de updated type to enum 2021-03-12 14:43:47 +05:30
Nikhil Nandagopal
82b65e12d1 Removed the property pane 2021-03-12 14:37:24 +05:30
Nikhil Nandagopal
11c8d4f34b made files a derived prop to change based on the file data type 
added file type
 2021-03-12 14:34:05 +05:30
Nikhil Nandagopal
d7a5f36fea Made bade 64 encoding the default type for S3 
Added a data field for file pickers that is filled based on the property pane value
 2021-03-12 13:44:32 +05:30
akash-codemonk
4995288801
Show fork modal while returning back to forking after signing in (#3509) 
- Show loaders where required and other styling fixes
 2021-03-12 13:14:16 +05:30
Abhinav Jha
246f7de444
Preserve Table Column properties when evaluations fail (#3495) 
* When there is a cyclic depenency, the table data is processed as s string, leading to incorrect column computations and a render loop. Fixed this by bailing out when table data is a string, as further computations are moot
 2021-03-12 12:00:38 +05:30
Arpit Mohan
f11cd45886
Correcting the github condition to start the API server (#3506) 2021-03-12 11:06:54 +05:30
ram-primathon
5b2832f380
Fix api settings page not getting updated (#3489) 2021-03-11 17:33:23 +05:30
Trisha Anand
217e36aaa9
Enrichment of analytics event for execute. (#3492) 
* WIP : enrichment of analytics event for execute.

* Plugin level : Catch all exceptions and set request in the result
Server level : Adding new fields to analytics : `isSuccessfulExecution`, `statusCode`, `timeElapsed`

* Dont catch StaleConnectionException. Server handles the same.

* Removed class specification for onErrorResume in plugins since its supposed to catch all errors.
 2021-03-11 15:40:07 +05:30
Shrikant Sharat Kandula
b12057ef73
Allow client to set layouts without id when creating a page (#3477) 
* Allow client to set layouts without id when creating a page

* Mild refactoring

* Fix Layout action tests
 2021-03-11 15:13:24 +05:30
Nidhi
f017ef29d4
Modified maven dependencies to reduce build time and jar size of s3 (#3491) 2021-03-11 14:58:07 +05:30
Trisha Anand
9f63bfafd2
Adding JSON intelligent substitution for Rest Api plugin (#3474) 
* POC : null value getting handled correctly

* Refactor code. Tested with and without quotes. This is working! Woohoo!

* Added support for mustache binding to include json objects and arrays

* Added test for smart substitution.

* Added setting to turn on/off smart substitutions in Rest API plugin

* Handling turning on smart json substitution

* Added error handling

* Added config to turn on smart substitution in JSON to make the tests pass now

* Adding a beta tag to the API setting.

* Spelling error resolved.

* Incorporated review comments.

* Catching JSON Parse exception in http call.
 2021-03-11 14:10:00 +05:30
Shrikant Sharat Kandula
1d683ad458
Fix recaptcha failing on signup when not configured (#3488) 2021-03-11 11:05:48 +05:30
Pawan Kumar
385baaddcb
Enhancement: Virtualized Query Editor Table (#3460) 
* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-11 10:25:37 +05:30
Hetu Nandu
bc646ab9b2
Fix: Delete tabs from the entity explorer (#3405) 
Co-authored-by: Akash N <akash@codemonk.in>
 2021-03-11 09:48:46 +05:30
Abhinav Jha
0172430489
Fix unreachable code reported by deepsourcelabs (#3483) 2021-03-11 08:46:50 +05:30
Shrikant Sharat Kandula
65568a4e13
Add more devices in AppLayout options (#3451) 
* Remove width and introduce more AppLayout type enums

* Fix: Adding min width to layout options.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
 2021-03-11 07:51:48 +05:30
Abhishek
0b4adf198d
Add recaptcha verification for user signup on the server (#3383) 
Co-authored-by: Abhishek <abhishek.ak@bytedance.com>
 2021-03-11 07:25:01 +05:30
dependabot[bot]
27bc73482a
Bump elliptic from 6.5.3 to 6.5.4 in /app/client (#3480) 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-03-11 06:40:35 +05:30
akash-codemonk
1be56a8512
Applications marked as forkable can be forked (#3453) 2021-03-10 12:38:20 +05:30
Sumit Kumar
aaf4ce95f2
use dynamic input text in plugin editor forms (#3470) 
- Use dynamic input text for plugin editor forms so that the evaluated value of mustache expression is visible.
- Those fields which are meant to store Key only - i.e. they are not visible to the user and are only meant to provide key for key value pair in db have been skipped.
 2021-03-10 12:29:19 +05:30
Hetu Nandu
4e4c6b76a8
Improve cylical dependency error (#3471) 2021-03-10 12:28:52 +05:30
Rishabh Saxena
08ebbe410b
Fix chat with us button at the editor help menu (#3465) 2021-03-10 11:27:17 +05:30
Sumit Kumar
b6961ce7a4
Add timeout failure for mongo plugin test datasource (#3431) 
- Mongo plugin client driver does not return with exception upon first failure - instead it keeps retrying. Hence, adding timeout error to report failure before the client thread cancels due to delay in response.
- It seems that the mongdb connection string cannot be directly used for ping test, hence skipping it.
 2021-03-10 11:11:14 +05:30
Sumit Kumar
04e8acb763
Custom S3 service support (#3469) 
- Provide support for non Amazon S3 service providers like Upcloud, Digital Ocean, Wasabi, DreamObjects and any other S3 compliant storage service provider.
- Change plugin label from "Amazon S3" to "S3"
 2021-03-10 10:30:07 +05:30
akash-codemonk
4fb55b4fd0
Fix: Incorrect validation of gif source in onboarding (#3448) 2021-03-10 09:44:43 +05:30
Hetu Nandu
a885fc8d3b
Fix chart data migration issues (#3458) 2021-03-09 20:05:42 +05:30
Hetu Nandu
6f4f2bb26c
Render placeholder text in the Key Value form input (#3452) 2021-03-09 17:35:29 +05:30
Shrikant Sharat Kandula
bb9a9a307f
APIs for profile photos (#3260) 
* Add API for uploading profile photos for current user

* Add delete and get APIs for profile photos

* Add test for uploading and deleting profile photo

* Added negative tests for upload profile photo API
 2021-03-09 17:03:20 +05:30
Trisha Anand
092a942036
Added support for Prepared Statement in MS SQL plugin. (#3438) 
* Added support for Prepared Statement in MsSQL plugin.

* Minor code formatting

* Merged release and refactored code for compilation.
 2021-03-09 14:42:53 +05:30
Trisha Anand
cd45a1dd74
Added support for Arrays in Prepared Statement in Postgres (#3421) 
* Added support for Arrays in Prepared Statement

* Minor code cleanup

* Super minor code readability changes

* Incorporated review comment
 2021-03-09 13:17:42 +05:30
Ashok Kumar M
4781f1096c
Fix: Modal Size gets cut in smaller screens. (#3441) 2021-03-09 11:27:44 +05:30
Abhinav Jha
0a7bf6d0d3
Deprecate UPDATE_WIDGET_PROPERTY action (#3392) 
* Deprecate UPDATE_WIDGET_PROPERTY action

* Handle JS property toggle independently
 2021-03-09 11:00:57 +05:30
Trisha Anand
38c0151e94
Changed order of message for easy grep in case of invalid dynamic binding path (#3436) 2021-03-08 16:05:05 +05:30
Trisha Anand
79164fde44
Only return request object in action execute if the action was executed in EDIT mode. (#3426) 2021-03-08 16:04:17 +05:30
Hetu Nandu
9bf78a06c0
Add analytical events on page save (#3434) 2021-03-08 15:58:20 +05:30
Hetu Nandu
6898a0bbd5
Fix for Table onPageSizeChange trigger executing when not defined (#3422) 2021-03-08 14:34:00 +05:30
imgbot[bot]
243082e568
[ImgBot] Optimize images (#3435) 
*Total -- 1,191.78kb -> 1,073.90kb (9.89%)

/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/images/no_search_data.png -- 2.59kb -> 1.63kb (37%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/link.svg -- 0.32kb -> 0.31kb (2.45%)
/app/client/src/assets/icons/ads/fluid.svg -- 0.57kb -> 0.56kb (1.37%)
/app/client/src/assets/icons/ads/entities.svg -- 0.22kb -> 0.22kb (1.32%)
/app/client/src/assets/icons/ads/tablet.svg -- 0.58kb -> 0.57kb (1.01%)
/app/client/src/assets/icons/ads/recent.svg -- 0.59kb -> 0.59kb (0.66%)
/app/client/src/assets/icons/ads/docs.svg -- 2.24kb -> 2.22kb (0.57%)
/app/client/src/assets/icons/ads/desktop.svg -- 0.73kb -> 0.73kb (0.4%)
/app/client/src/assets/icons/ads/mobile.svg -- 0.79kb -> 0.79kb (0.37%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.17%)
/app/client/src/assets/icons/ads/shine.svg -- 0.71kb -> 0.71kb (0.14%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.12%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2021-03-08 14:32:48 +05:30
Rishabh Saxena
99b3fa6bb8
Omnibar global search (#2903) 2021-03-08 13:54:12 +05:30
Dwayne Forde
2dfc8ebf8a
Adds support for base64 image strings to image cells (#2769) 2021-03-06 01:07:49 +05:30
Sumit Kumar
800d305dab
Gracefully handle the timeout overflow / out of expected range errors (#3411) 
- Expect max value of timeout as 60000 ms.
- If value exceeds max value then add error message to the list of invalids. This list is returned to the client in response body.
- Detect integer overflow exception (Number format exception) and override the value to 60000 ms.
 2021-03-05 17:09:29 +05:30
Trisha Anand
10cd7f5f80
Adding support for Prepared Statements in MySQL plugin (#3327) 2021-03-05 16:22:46 +05:30
prapullac
d452c78453
Adding manual test cases for Table (#3325) 2021-03-05 14:02:54 +05:30
akash-codemonk
e012ea54aa
Fix: Action name being appended with a 1 when moved to another page even when there is no duplicate (#3352) 2021-03-05 13:05:15 +05:30
hetunandu
8574b86926 Merge branch 'master' into release 2021-03-05 12:06:14 +05:30
Pawan Kumar
220b28df3e
Fix: TypeError: e is undefined (#3337) 
* add conditional operator

* check for widget before calling the function

* check for widget exisitence

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-03-05 10:04:35 +05:30
NandanAnantharamu
71f4a4b0a9
grouping another set of tests (#3404) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-03-05 00:35:41 +05:30
Hetu Nandu
2b2cee6bd6
fix chart validation (#3400) 2021-03-05 00:28:43 +05:30
Hetu Nandu
dc154b94b0
Fix widget updates not working properly (#3403) 
* Fix widget updates not working properly

* Revert "Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218)"

This reverts commit 39e4990a7f.
 2021-03-05 00:05:41 +05:30
Vicky Bansal
c4d6405981
Fix: RTE Error (#3385) 
* Added defaultText property for text type validations to fix invalid data type beings passed to RichTextEditor component

* removed text and defaultValue properties from widget property validation map
 2021-03-04 16:21:58 +05:30
Trisha Anand
20ed017a58
In case of no mustache bindings are found in dynamic path list, throw invalid dynamic binding reference error. (#3394) 2021-03-04 15:35:46 +05:30
akash-codemonk
39e4990a7f
Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218) 2021-03-04 15:24:01 +05:30
akash-codemonk
1e4878f983
Support editing user's name field (#3306) 2021-03-04 15:07:02 +05:30
Hetu Nandu
c81495e2cb
Fix chart data validation (#3389) 2021-03-04 13:40:22 +05:30
Rishabh Saxena
013c4230e2
Wrap ads button text within span for resilience for DOM mutations (#3292) 2021-03-04 11:34:36 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-03-04 10:54:47 +05:30
Ashok Kumar M
af6b3dfdbb
Fix: Drop overlay widgets anywhere and add them as main container child (#3332) 
* Fix: Drop overlay widgets anywhere and add them as main container child

* Using detachFromLayout config.
 2021-03-04 10:26:00 +05:30
Trisha Anand
5e448b9331
DSL parsing : Catch index out of bound exception (#3364) 
* In case index being referred does not exist, throw appropriate error during DSL parsing

* Fixing bad commit.
 2021-03-03 18:51:35 +05:30
Sumit Kumar
639913703a
Fix/add mongo srv support (#3341) 
Provide helpful error msg when srv url is provided to mongo plugin

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2021-03-03 18:31:04 +05:30
Trisha Anand
75b0986b92 Fixed the incorrect JSON string in INVALID_DYNAMIC_BINDING_REFERENCE appsmith error. 2021-03-03 18:22:42 +05:30
Shrikant Sharat Kandula
bb49f04f06
Support descending ordering for Firestore documents (#3340) 2021-03-03 18:18:57 +05:30
Trisha Anand
f49cc7b455
Added throwing a properly formatted error for client to consume when dynamic binding path list contains an invalid entry (#3343) 2021-03-03 17:47:35 +05:30
Trisha Anand
ca8be4c7f5
Db Migration : Delete unreferenced dynamic binding paths in actions (#3310) 
* WIP compute if the dynamic binding path list is correct.

* Tested code for deleting the incorrect dynamic binding path list from actions.

* Added comments for code readability
 2021-03-03 17:11:03 +05:30
Shrikant Sharat Kandula
9c50182f0e
API for forking of public applications (#3221) 
* A barely working API for forking a public application

* Tests WIP

* Mild refactoring in tests

* Refactoring in test

* Not all applications are forkable
 2021-03-03 15:45:47 +05:30
Vicky Bansal
d3c2c02745
Fix: Tabs Widget crashes when data is invalid (#3235) 
* Fixed tabs data validation and added check to ensure tab property is accessible when tabs array is not empty

* added isVisible property in validations
 2021-03-03 11:29:02 +05:30
Ashok Kumar M
a7e0990cf8
Feature: Canvas Layout Options(max width config) (#3141) 
* Feature: Canvas Layout Options(max width config)

* Fixing css issues.

* Changing Default Device option to Desktop.

* Changed Implementation to maintain resize updates within the client.

* Addressing code review changes.

* Updating device resolutions.

* updating cytests

* Fixing resize bug.
 2021-03-03 10:56:47 +05:30
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
Sumit Kumar
e5586a590a
fix placeholderText label in form.json files (#3331) 
fix placeholderText label in form.json files
 2021-03-03 09:33:02 +05:30
Piyush
462379721d
Reset widget global function (#3181) 2021-03-02 18:19:36 +05:30
Sumit Kumar
5bab77a141
remove endpoint host and port fields from dynamodb datasource form (#3316) 
- A consensus has emerged that the utility of overriding endpoint is only for local development and testing. Hence, removing the fields from datasource form.
 2021-03-02 17:25:25 +05:30
Sumit Kumar
6c04e1467b
Provide option for only one endpoint and port in the dynamodb plugin datasource form (#3314) 
- provide a max length to keyvalue_array type. If the max length is set to 1, then the "+" button will not appear.
- front end changes are pending. A new github issue will be opened to track the same : #3315
 2021-03-02 15:42:38 +05:30
Arpit Mohan
bf16b45f2b
Merge pull request #3309 from appsmithorg/release 
Release v1.4.1
 2021-03-02 13:41:51 +05:30
Trisha Anand
bd18030c2d
Add request body in case http method is not GET (#3307) 
* Add request body in case http method is not GET

* Incorporated review comments.
 2021-03-02 12:46:20 +05:30
Rishabh Saxena
7204e87ea5
fix help modal overlapping with close button (#3289) 2021-03-02 11:26:02 +05:30
Rishabh Saxena
d48e00422e
Minor code cleanups (#3165) 2021-03-02 11:25:45 +05:30
Trisha Anand
91e308665b
Requests preparation by plugins instead of ActionService (#3159) 
* Added action request in S3 plugin.

* Added request data in Dynamo plugin

* Added request in Elastic Search.

* Request in Firestore.

* Request added in Mongo

* MsSQL request added.

* Added MySQL request.

* Added Postgres request.

* Added redis request.

* Redshift doen.

* Catching AppsmithPluginExceptions at the plugin level itself to ensure that the request gets passed on as part of the result.

* Fixed failing plugin test failures

* Fixed AmazonS3 test failures.

* WIP post analytics working

* WIP : Making the request data confirm to existing analytics request data format.

* Fixed the headers in the analytics body.

* Migrations S3, Postgres to the accepted format for request in analytics

* Updated S3 action to be the query

* Migration completed for all plugins for analytics.

* Removed the old analytics event. Now sending only the new one.

* Ensuring all data is captured in S3 plugin request in case of error.

* Minor editing of firestore to ensure that the errors get caught by the plugin itself.

* Fixed test cases in Amazon S3

* Incorporated review comments.
 2021-03-02 10:58:46 +05:30
Young Yoo
d61a900011
Fix #2712 - Duplicate Property For Map Widget (#3174) 
After a Map Widget created, the text field in the Text Widget can bind the map properties. Inside the map properties, "Map center" and "Center" are duplicate value. The "MapCenter" is deleted for the adjustment.

Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
 2021-03-02 10:45:39 +05:30
imgbot[bot]
13b4d61b8f
[ImgBot] Optimize images (#3303) 
*Total -- 114.50kb -> 96.16kb (16.02%)

/app/client/src/assets/images/no_data.png -- 103.98kb -> 85.71kb (17.58%)
/app/client/src/assets/icons/control/vertical_align_top.svg -- 0.17kb -> 0.17kb (2.3%)
/app/client/src/assets/icons/control/vertical_align_bottom.svg -- 0.18kb -> 0.17kb (1.67%)
/app/client/src/assets/icons/control/heading_1.svg -- 0.32kb -> 0.31kb (1.54%)
/app/client/src/assets/icons/control/vertical_align_center.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.12%)
/app/client/src/assets/images/secure.svg -- 1.08kb -> 1.07kb (0.91%)
/app/client/src/assets/icons/control/paragraph.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/control/delete-column.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/hide-column.svg -- 0.52kb -> 0.52kb (0.56%)
/app/client/src/assets/icons/control/heading_2.svg -- 1.08kb -> 1.08kb (0.45%)
/app/client/src/assets/icons/control/checkmark.svg -- 0.96kb -> 0.95kb (0.41%)
/app/client/src/assets/icons/control/paragraph_2.svg -- 1.49kb -> 1.49kb (0.33%)
/app/client/src/assets/icons/control/bullets.svg -- 1.52kb -> 1.52kb (0.32%)
/app/client/src/assets/icons/control/heading_3.svg -- 1.52kb -> 1.52kb (0.32%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2021-03-02 10:24:47 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222) 
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-03-02 08:43:43 +05:30
dependabot[bot]
d7b7cb26fa
Bump prismjs from 1.22.0 to 1.23.0 in /app/client (#3300) 
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.22.0...v1.23.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-03-02 08:20:31 +05:30
Sumit Kumar
7d2effae18
Modify hint statement for 'import from curl' form (#3285) 
- Move to hint statement out of query box and put if above it - between the label and the query box - so that user's don't confuse it as a typed in statement.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-03-01 23:28:07 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
akash-codemonk
beb6eb8241
Add validation to check if organization exists during onboarding (#3243) 2021-03-01 15:21:23 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function" 
This reverts commit 54f158694f.
 2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
RIshabh Saxena
2a868c89a6 Revert "Wrap text with span for resilience for DOM mutations by google translate" 
This reverts commit e87ef2452e.
 2021-03-01 13:25:05 +05:30
RIshabh Saxena
e87ef2452e Wrap text with span for resilience for DOM mutations by google translate 2021-03-01 13:24:36 +05:30
Sumit Kumar
68e6c7b1d8
stop logging datasource argument error externally. (#3262) 
- Stop logging datasource argument error externally. The error described in the linked GitHub issue arises due to bad service account credentials provided as arg.
- Update error msg to make it clear.
- Add TC.
 2021-03-01 12:13:32 +05:30
Trisha Anand
31b20da347
Adding support for NULL value parameters in Prepared Statement. (#3255) 2021-02-27 18:59:51 +05:30
Sumit Kumar
d2643a18c3
check dynamodb connection validity using listTables cmd. (#3241) 
* check dynamodb connection validity using listTables cmd.
* add TC
* add encrypted logo to password field
* rectify the default value of region dropdown
* remove unused imports
 2021-02-26 16:57:18 +05:30
vicky-primathon.in
950c7b93bb Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-26 16:35:12 +05:30
Shrikant Sharat Kandula
a1d027bb59
Save separate appLayout for edit/view and sync on publish (#3245) 2021-02-26 16:18:04 +05:30
Hetu Nandu
1f7fc9c0ed
Api form on submit (#3225) 2021-02-26 14:52:11 +05:30
Shrikant Sharat Kandula
5808620716
Add API for the signed in user to set their name (#3164) 
* Add API for the signed in user to set their name

* Use the correct error in session handling
 2021-02-26 14:48:20 +05:30
akash-codemonk
0682a92d87
Update useEffect dependency (#3239) 2021-02-26 14:13:24 +05:30
Shrikant Sharat Kandula
dc146a1a16
Fix MongoDB test operation errors not being caught (#3234) 2021-02-26 12:55:54 +05:30
Piyush
21a2a2bdf4
Redirect URL for oAuth Auth code flow (#3232) 2021-02-26 12:28:47 +05:30
Piyush
c38e58b3bc
Fix race between action reducer and handleQueryCreatedSaga (#3236) 2021-02-26 12:28:03 +05:30
Vicky Bansal
5e8805b40a
Feature: selectedOptionLabel and selectedOptionLabels in Dropdown widget (#3205) 2021-02-26 11:54:25 +05:30
Vicky Bansal
118467c5bb
Feature: Show/Hide Tabs in Tabs Widget (#3192) 
* Added functionality to show/hide a tab from tab property pane controls

* Added isVisible property in tabs widget default value

* Passing visible tabs to component from widget. Added missing widgetId
 2021-02-26 11:47:21 +05:30
akash-codemonk
05b2cd6d29
Fix renaming action goes to the action page (#3201) 2021-02-26 11:15:27 +05:30
Pawan Kumar
7185536c67
Fix: Cannot read property 'length' of undefined (#3207) 
* update

* fix chart component on empty dataset

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-26 10:58:31 +05:30
akash-codemonk
7daeadd447
Fix current page not changing while switching to an action of another page (#3214) 2021-02-26 10:34:14 +05:30
NandanAnantharamu
4bed88d7e1
Added test for table data sorting (#2257) 
* Added test for table data sorting

* commented tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-26 10:18:27 +05:30
hetunandu
3cc1fbfefd Merge branch 'release' 2021-02-25 22:36:20 +05:30
Hetu Nandu
a8889d6985
Capture cyclical dependency on sentry (#3226) 2021-02-25 22:29:00 +05:30
Abhinav Jha
3e7d2bb720 Merge branch 'release' of github.com:appsmithorg/appsmith 2021-02-25 21:39:02 +05:30
Abhinav Jha
a1bda002c0 Fix issue where renaming table data keys did not delete the previous key 2021-02-25 21:36:27 +05:30
Arpit Mohan
73d47413ff Merge branch 'release' 2021-02-25 20:43:04 +05:30
Hetu Nandu
ffeb297a1a
Fix dynamic path duplicate issue (#3223) 2021-02-25 20:42:29 +05:30
Arpit Mohan
4f16b23352 Merge branch 'release' 2021-02-25 19:34:22 +05:30
Hetu Nandu
c2646a8863
Use property config for trigger properties (#3217) 
* Use triggerPaths and remove isDynamicTrigger argument

* Remove triggerMaps from widgets

* Fix property updates
 2021-02-25 19:30:02 +05:30
Abhinav Jha
bdc2d46192
Add min max values to datepicker control (#3215) 2021-02-25 17:47:13 +05:30
Shrikant Sharat Kandula
9f18aa2e69
Fix NPE in analytics on action execution (#3216) 2021-02-25 17:46:24 +05:30
Arpit Mohan
d420518cad Fixing merge conflicts 2021-02-25 17:29:49 +05:30
Hetu Nandu
4a557309ca
Fix eval error logging (#3206) 
* Update app/client/src/utils/WidgetFactory.tsx
 2021-02-25 17:23:06 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212) 
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
 2021-02-25 17:21:54 +05:30
Sumit Kumar
1e59ed4928
Internal fix: Remove raw response from transformed DynamoDB response structure. (#3209) 
* remove raw response from transformed response structure.
* update TCs
 2021-02-25 16:34:07 +05:30
Trisha Anand
42af1fa771
Only extract dynamic bindings from leaf nodes on update layout (#3210) 
* Only extract dynamic bindings from leaf nodes.

* Minor code refactoring

* Moved to using generic Map type instead of LinkedHashMap
 2021-02-25 15:56:45 +05:30
NandanAnantharamu
21eecb1fe6
WIP : Added test for chart datapoint validation (#3176) 
* Added test for chart datapoint validation

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-25 12:49:23 +05:30
Rishabh Saxena
6b13347157
Fix navigation to modal widget's children from the entity explorer (#3067) 2021-02-25 12:39:33 +05:30
Piyush
8383d79c91
Remove client side validation on save for OAuth Datasource (#3131) 2021-02-25 12:01:21 +05:30
Hetu Nandu
3944d7e43e
Sort order fix if property path gets updated via multiple start nodes (#3194) 2021-02-24 21:56:00 +05:30
Abhinav Jha
e197d13399
Fix issue when searching for certain places does not return a valid list from a google maps control (#3197) 2021-02-24 20:59:12 +05:30
akash-codemonk
7fa5e3b1af
Hide pages in publish mode (#3106) 2021-02-24 19:17:37 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186) 
* Fix selected row issue in view mode

* Remove un-select feature
 2021-02-24 15:59:19 +05:30
akash-codemonk
791d92af94
Add validation to check if widget exists (#3140) 
* Check if widget is present incase it got deleted etc.

* Update test
 2021-02-24 11:30:22 +05:30
Rishabh Saxena
c0222db163
Fix editor header popovers (#3173) 2021-02-24 10:42:12 +05:30
Sumit Kumar
63ff3c73fa
Fix execute on page load for api on app copy (#3150) 
* first draft

* added fix without TC

* cleanup

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* - add TC
- minor code refactor

* fix condition

* update clone page test

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-02-24 10:21:03 +05:30
Shrikant Sharat Kandula
68bbc4fb28
Support server-side pagination for Firestore (#3128) 
* POC for Firestore server-side pagination

* Load pagination information values from action configuration

* Get execution information for Firestore plugin

* Working implementation of pagination for Firestore

* Add tests for next and previou page navigations

* Require ordering to be set when paginating

* Remove commented code

* Don't report error on bad configuration

* Error out on usupported operation

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Move constant indices to constant fields

* Use executeParameterized instead of execute

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-02-24 10:20:08 +05:30
vicky-primathon.in
b474442ec7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-23 18:11:14 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889) 
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-23 18:05:09 +05:30
Shrikant Sharat Kandula
72df6fb299
Allow MongoDB datasources without username/password (#3149) 2021-02-23 16:54:27 +05:30
Hetu Nandu
17dd5345a8
Fix code editor theme colours on the property pane (#3168) 2021-02-23 16:25:22 +05:30
Sumit Kumar
4b09b2c379
Transform Dynamodb response for easy consumption (#3050) 
- add support to handle dnyamoDb Binary type
- transform raw response to show extracted response and raw response for:
GetItem
BatchGetItem
DeleteItem
PutItem
Scan
TransactGetItems
UpdateItem
- modify TC.
 2021-02-23 16:24:06 +05:30
Trisha Anand
139d870c17
Marking Prepared Statement in Postgres plugin as a beta feature (#3161) 2021-02-23 15:39:53 +05:30
Hetu Nandu
3a5e0b30bb
Force light theme on the whole editor except the header (#3143) 2021-02-23 15:37:13 +05:30
NandanAnantharamu
d20d013d69
Cypress test for Tab rename from entity explorer (#2780) 
* Bug automation

* Test flow completed

* Another bug automation

* Updated tests

* uncommented delete tab test

* Uncommented a test

* updated tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-23 15:08:31 +05:30
Piyush
faea2f36ff
Add support for setting.json for pluginType DB (#3156) 2021-02-23 13:57:37 +05:30
Shrikant Sharat Kandula
9b58e683b5
Fix Spring deserialization routines failing at appLayout (#3155) 2021-02-23 12:32:55 +05:30
vicky-primathon.in
8b334c3064 Removed passing formatType to component as html is default output 2021-02-23 12:10:19 +05:30
Nidhi
61af306110
Added null check for OAuth2 scopes(#3153) 2021-02-23 11:10:47 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074) 
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
 2021-02-23 10:19:14 +05:30
NandanAnantharamu
725043fde3
Replace test api with mockApi in Cypress tests (#2975) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-23 09:56:02 +05:30
Shrikant Sharat Kandula
e2509ae325
Add placeholder for MongoDB datasource config's host inputs (#3145) 
* Remove example indicator
 2021-02-23 09:52:45 +05:30
Shrikant Sharat Kandula
4f6a48bf40
Fix BatchGetItem & TransactGetItems operations failing on the DynamoDB plugin (#3120) 
* Fix batch operations APIs failing with DynamoDB

* Fixed TransactGetItems operation on DynamoDB
 2021-02-23 09:51:23 +05:30
Ashok Kumar M
d1822a9dee
Feature: Modal Widget (#3092) 
* Feature: Modal Widget(DIP)

* Adding cypress tests.
 2021-02-23 09:48:23 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Shrikant Sharat Kandula
15b8e0f590
Add appLayout field to Applications (#3144) 
* Add `appLayout` field to Applications

* Fix NPE on clone
 2021-02-22 19:21:13 +05:30
Hetu Nandu
6f7ce24a2f
Fix action subtree evaluation (#3142) 2021-02-22 16:44:08 +05:30
Shrikant Sharat Kandula
276338af0a Rename the $ref field to _ref in Firestore plugin (#3135) 
(cherry picked from commit 198abbf37d)
 2021-02-22 14:40:02 +05:30
Shrikant Sharat Kandula
198abbf37d
Rename the $ref field to _ref in Firestore plugin (#3135) 2021-02-22 13:57:04 +05:30
Rishabh Saxena
1d76f391da
Fix styles for the primary logo within viewer for safari (#3133) 2021-02-22 13:32:38 +05:30
Piyush Mishra
90fba15630
Fix/datasource name conflict issue (#3134) 2021-02-22 12:57:05 +05:30
Hetu Nandu
447f458656
Minor Api pane design and logic fixes (#3091) 2021-02-22 11:45:02 +05:30
Rishabh Saxena
0dab943be2
Fix app title widths for both viewer and editor (#3094) 2021-02-22 11:02:19 +05:30
Hetu Nandu
88c86fa881
Add toast for trigger errors (#3100) 2021-02-22 10:30:16 +05:30
NandanAnantharamu
03eba7ed27
Categorise tests between client and server (#2856) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-02-22 10:18:30 +05:30
Trisha Anand
7ff80ea192
In case an action is created without plugin template being set, update doesn't set the property as well. (#3116) 2021-02-19 23:26:33 +05:30
vicky-primathon.in
c5a689b560 Added support for markdown type in RTE 2021-02-19 16:57:54 +05:30
Trisha Anand
5a2ad75d1b
Use a toggle instead of dropdown to configure Prepared Statements (#3105) 2021-02-19 16:31:18 +05:30
Rishabh Saxena
a8aa41b652
Handle false (type: string) as falsy for the switch control (internal forms) 2021-02-19 16:30:07 +05:30
Shrikant Sharat Kandula
ef732f1389 Add request body and some other details in action execution data point (#3096) 2021-02-19 15:20:20 +05:30
Shrikant Sharat Kandula
a6be22e028
Add request body and some other details in action execution data point (#3096) 
* Include request body in action execution data point

* Send analytics data point when analytics fails
 2021-02-19 14:39:40 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing. 
Fix default input type
 2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
akash-codemonk
f0be4341f3
Fix execute action error message (#3077) 2021-02-19 11:16:54 +05:30
Abhinav Jha
59f56c8052
Internal Fix: When tables are migrated, the computedValue for the columns do not have currenRow (#3066) 2021-02-19 10:21:52 +05:30
Abhinav Jha
419d724096
Internal Fix: Issue where the property panel isn't scrolled to top when opening it (#3065) 2021-02-19 10:21:01 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
dependabot[bot]
9579b91fae
Bump jackson-databind in /app/server/appsmith-plugins/restApiPlugin (#3098) 
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.4 to 2.10.5.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-19 08:24:07 +05:30
Shrikant Sharat Kandula
6eb9f399a3
Add a boolean isHidden field for pages (#3090) 
* Add a boolean `isHidden` field for pages

* Add `isHidden` when loading all pages of application
 2021-02-18 19:23:15 +05:30
Trisha Anand
e5574c1945
Support Prepared Statements in Postgres (#2967) 
* Pushing minor editor form changes to ensure that prepared statement could be turned off.

* Code refactor to do variable substitution in PluginExecutor instead of action service.

* WIP : Prepared Statement handling in psql plugin

* WIP Prepared Statements.

* Working version of prepared statements

* Quote trimming added for post preparing sql statements. Now the unprepared statements and prepared statements do not require edits.

* Fixed existing test cases failing.

* Code formatting.

* Super minor code cleanup.

* Added migration for the existing postgres actions.

* Fixed failing test cases in ActionServiceTest.

* Minor change in the text for turning on and off prepared statements in the postgres query pane.

* Added test cases for prepared statement.

* Some minor comments for code readability

* Moved Prepared Statement setting from Action Configuration to Plugin Specified Templates since this setting does not make sense for all the DB plugins.

* Added function level comments

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/SqlStringUtils.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/SqlStringUtils.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Incorporated review comments.

* Fixed compile time error.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-18 18:33:27 +05:30
imgbot[bot]
3ff938712c
[ImgBot] Optimize images (#2978) 
*Total -- 1,442.90kb -> 1,261.25kb (12.59%)

/app/client/src/assets/icons/gifs/lightmode_thumbnail.png -- 13.33kb -> 4.62kb (65.34%)
/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/images/invalid-page.png -- 3.20kb -> 2.22kb (30.49%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/images/appsmith_logo_square.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/icons/gifs/config_pagination_lightmode.gif -- 110.67kb -> 81.84kb (26.05%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/icons/gifs/config_pagination_darkmode.gif -- 101.19kb -> 80.38kb (20.57%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/icons/gifs/darkmode_thumbnail.png -- 4.87kb -> 4.34kb (10.88%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/view-less.svg -- 0.25kb -> 0.24kb (3.53%)
/app/client/src/assets/icons/ads/add-more.svg -- 0.50kb -> 0.49kb (2.53%)
/app/client/src/assets/icons/ads/play.svg -- 0.23kb -> 0.22kb (2.16%)
/app/client/src/assets/icons/ads/no-response.svg -- 3.84kb -> 3.76kb (1.88%)
/app/client/src/assets/icons/ads/close-modal.svg -- 0.28kb -> 0.27kb (1.75%)
/app/client/src/assets/icons/ads/chevron_left.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/chevron_right.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/right-arrow.svg -- 0.27kb -> 0.27kb (1.44%)
/app/client/src/assets/icons/ads/fork.svg -- 0.45kb -> 0.44kb (1.31%)
/app/client/src/assets/icons/ads/lightning.svg -- 0.22kb -> 0.22kb (1.3%)
/app/client/src/assets/icons/ads/arrow-left.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.67%)
/app/client/src/assets/icons/ads/shine.svg -- 0.72kb -> 0.71kb (0.41%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/ads/datasource.svg -- 0.87kb -> 0.87kb (0.34%)
/app/client/src/assets/icons/help/updates.svg -- 1.01kb -> 1.01kb (0.29%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-02-18 18:08:13 +05:30
Trisha Anand
b565301afe
Datasource is given permission for a public app during create/update of a public action (#3086) 
* Added test case to assert that new datasources and actions created post making an application public have the correct permissions for public execution.
 2021-02-18 18:05:07 +05:30
Sumit Kumar
2c395b8c82
Enchancements for AWS S3 plugin (#3079) 
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-02-18 17:55:01 +05:30
vicky-primathon.in
2636c70410 Handled commont property for default text input type 2021-02-18 15:56:40 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Shrikant Sharat Kandula
60a4ddb3c1 Fix NPE on plugin specified templates (#3084) 
(cherry picked from commit 2a2b55ceaf)
 2021-02-18 13:12:08 +05:30
Shrikant Sharat Kandula
128444f46c Add more information for action execution (#3060) 
* Add more information for action execution

* Add orgId and pageName to action execution data point

(cherry picked from commit 6936a40361)
 2021-02-18 13:12:08 +05:30
Shrikant Sharat Kandula
2a2b55ceaf
Fix NPE on plugin specified templates (#3084) 2021-02-18 09:10:15 +05:30
Shrikant Sharat Kandula
6936a40361
Add more information for action execution (#3060) 
* Add more information for action execution

* Add orgId and pageName to action execution data point
 2021-02-18 08:30:56 +05:30
Hetu Nandu
e1d43992b2
Fix default value reset issue (#2861) 2021-02-17 20:32:36 +05:30
prapullac
743791a95d
Manual negative test ideas for user invite flow (#2481) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-17 20:27:18 +05:30
prapullac
8cd3a981b9
Manual test ideas for datasource query (#2763) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-17 20:22:16 +05:30
akash-codemonk
5c80e2e3e2
Update the message on the widget sidebar (#3056) 2021-02-17 11:05:24 +05:30
Shrikant Sharat Kandula
c80b6b4761 Include Firestore document metadata in responses (#3063) 
(cherry picked from commit b9cb76e7e5)
 2021-02-17 10:59:36 +05:30
Pawan Kumar
503a8ae3fe
remove negative margin (#3037) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-17 10:54:56 +05:30
Shrikant Sharat Kandula
b9cb76e7e5
Include Firestore document metadata in responses (#3063) 2021-02-16 22:09:09 +05:30
Piyush Mishra
74b013d909
Encode params toggle (#3006) 
* Makes client side changes to support actionConfiguration.encodeParamsToggle setting.
* Add migration code.

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-16 20:31:35 +05:30
Nidhi
afc329fd7b
Added grant type Authorization code to OAuth2 (#2992) 
Co-authored-by: Piyush <piyush@codeitout.com>
 2021-02-16 17:58:03 +05:30
akash-codemonk
86725baf61 Update onboarding indicator animation for widget menu (#3018) 
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
 2021-02-16 17:52:15 +05:30
akash-codemonk
e604357643 Go back to application list instead of deleting app (#2981) 2021-02-16 17:52:04 +05:30
akash-codemonk
9c20ac5306 New onboarding flow (#2686) 
Co-authored-by: a <rishabh.robben@gmail.com>
 2021-02-16 17:51:46 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999) 
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816) 
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
 2021-02-16 15:59:08 +05:30
Ashok Kumar M
24c5357f9d
Fix: Shrink Entity explorer by 20% (#3005) 2021-02-16 15:56:09 +05:30
Piyush Mishra
7e84c93282
Add QUERY_DYNAMIC_INPUT_TEXT control (#2983) 2021-02-16 11:51:19 +05:30
Rishabh Saxena
2e72be0f8a
Handle quota exceeded and running low on disk space errors while saving a key in localStorage (#2947) 2021-02-16 11:47:23 +05:30
Arpit Mohan
a973d779fd
Correcting the display message for query actions based on isExecutionSuccess flag (#3045) 
Also improving the mongo error response string. Now we only send the error message instead of the entire stack trace back to the client
 2021-02-15 22:10:04 +05:30
Hetu Nandu
ebd61efcca
Show a toast when action executeOnLoad status updates (#3042) 2021-02-15 21:43:44 +05:30
Piyush Mishra
56170b0cdf
Null check in getConfigInitialValues (#3043) 2021-02-15 21:43:20 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value 
Added migrations to handle the same
 2021-02-15 17:19:33 +05:30
Abhinav Jha
342bad8909
Fix #2829 Crash when resetting form widget (#2942) 2021-02-15 11:03:30 +05:30
akash-codemonk
c7a5b8f6d5
Update onboarding indicator animation for widget menu (#3018) 
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
 2021-02-15 10:44:42 +05:30
Shrikant Sharat Kandula
3fd8db90bd
Consistent handling of signup configuration over FORM and OAUTH (#3013) 
* Fix OAuth flow throwing 500 when signup is disabled

* Check for error code to identify signup disabled error

* Add consistent handling of allowed-domains for signing up

* Check for existence of valid email before checking domain
 2021-02-12 19:48:07 +05:30
Sumit Kumar
5638997a36
change response data format for AmazonS3 Plugin (#3023) 
* change response data format.
* fix TCs
 2021-02-12 19:34:03 +05:30
Shrikant Sharat Kandula
48b8bb9de1
Fix order of roles in share modal (#3017) 2021-02-12 16:37:34 +05:30
Rishabh Saxena
051156da29
Follow the same sequence while displaying oauth options for Signup & Login (#3009) 2021-02-12 16:12:53 +05:30
Sumit Kumar
4df595417f
return url on file create and fix image/video file upload issues with amazons3 plugin (#3012) 
1. Return url on file create.
2. Fix image/video upload/download.
3. Change error msg format to directly print error msg without adding any prefix sentence.
 2021-02-12 16:01:26 +05:30
Pawan Kumar
5b23cbf6f1
fix margin/padding issue in container in publish view (#2446) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-12 10:37:03 +05:30
abhishek nayak
14d17dfad5
Update JSDependencies.tsx 
Updated 'Dependencies' to 'JS libraries you can use'
 2021-02-12 01:38:52 +05:30
Arpit Mohan
01ca53899e
Fixing the organization share Cypress test cases (#2993) 2021-02-11 23:50:49 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-11 18:24:00 +05:30
Nidhi
8823f9d407
Added client credentials grant type for OAuth2 (#2649) 
* Added client credentials grant type for OAuth2

Co-authored-by: Piyush <piyush@codeitout.com>
 2021-02-11 17:58:06 +05:30
Rishabh Saxena
1a593e1981
add default values to payload while creating a new action (#2976) 
Fix default values not sent as payload while creating a new action
 2021-02-11 17:17:21 +05:30
akash-codemonk
8aa39eae7b
Go back to application list instead of deleting app (#2981) 2021-02-11 16:55:47 +05:30
Shrikant Sharat Kandula
8440d4e4e3
Allow app-viewers to invite others as app-viewers (#2961) 
* Allow app-viewers to invite others as app-viewers

* Fix description for new permissions

* Migration for setting invite policy for app viewers
 2021-02-11 16:33:35 +05:30
Sumit Kumar
4870c0d743
enable save on missing username/password (#2979) 
1. Add encrypted logo to password.
2. Enable save on empty username / password.
 2021-02-11 14:35:10 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686) 
Co-authored-by: a <rishabh.robben@gmail.com>
 2021-02-11 12:06:07 +05:30
Pawan Kumar
234b6983e9
Fix: border-radius of modal and bug where children of modal were not resetting on close of modal. (#2963) 
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

* update border radius of modal

* reset modal children on close

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
 2021-02-11 11:55:11 +05:30
Pawan Kumar
3b28653395
update rich text editor version + add check for string in editor value (#2966) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-11 11:55:00 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Sumit Kumar
e9e30d1fa4
Enable toggle for params encoding (#2968) 
Enable toggle for params encoding
1. Add toggle param to ActionConfiguration class.
2. Add TCs to test toggle on/off/null.
 2021-02-11 11:02:29 +05:30
Ashok Kumar M
0da3421dc2
Fix Local setup changes to accommodate M1 chip Macbooks. (#2959) 
* Fix Local setup changes to accommodate M1 chip Macbooks.

* escaping quotes.

* formatting start-https.sh
 2021-02-10 16:12:01 +05:30
Sumit Kumar
2a7f7ba8c4
s3 plugin (#2735) 
1. Integrate S3 plugin.
 2021-02-10 15:26:01 +05:30
Shrikant Sharat Kandula
95d1717f57 Merge branch 'release' 2021-02-10 14:35:02 +05:30
Shrikant Sharat Kandula
ed1c926c8a
Add datasource structure support for DynamoDB (#2919) 2021-02-10 13:28:35 +05:30
Rishabh Saxena
8c72e901ee
Fix input's onSubmit action being triggered if its validation is failing (#2960) 2021-02-10 13:13:41 +05:30
Abhinav Jha
4becc50005
Fix issue where the parentRowSpace of the new widget generated from the query was incorrect. Resulting in incorrect pageSize calculations (#2944) 2021-02-10 12:34:11 +05:30
Shrikant Sharat Kandula
c5df149ba8
Add IN operator support for forms' hidden fields (#2939) 2021-02-10 11:27:21 +05:30
Pawan Kumar
c78a578247
Fix: Cannot read property 'closeModal' of null (#2911) 
* update filepicker uppy implementation

* update uppy implementation

* fix uppy implementation

* remove typo

* remove consoles

* remove unused variable

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-02-10 10:29:47 +05:30
Abhinav Jha
eafadb8988
Update nvmrc to match the node version in package.json (#2943) 2021-02-09 20:53:05 +05:30
Hetu Nandu
8439affd67
Update node to latest LTS version (#2931) 2021-02-09 19:14:50 +05:30
Shrikant Sharat Kandula
0861836db4
Fix bindings in Firestore plugin's where condition value (#2934) 2021-02-09 19:11:16 +05:30
abhishek nayak
785c81df23
Update messages.ts 2021-02-09 17:38:43 +05:30
Nidhi
c0e44d0cd9
Added null check for error messages (#2922) 
* Added null check for error messages

* Added a generic null check for future null pointers from other sources.
 2021-02-09 15:00:22 +05:30
Trisha Anand
af273c60d8
When fetching unpublished actions and unpublished pages, check if the undeployed version is not deleted before fetching. (#2792) 
* When fetching unpublished actions and unpublished pages, check if the undeployed version is not deleted before fetching.

* Only add unpublished page deleted at check if the view mode is false (aka edit mode)

* 1. Update action repository to fetch only non deleted actions if fetching actions in edit mode.
2. Added test cases to assert re-using of deleted page and action names.
 2021-02-09 12:57:10 +05:30
Shubhendra Singh Chauhan
ac49a5aa87
Remove true from boolean attribute (#2892) 
Added .deepsource.toml file
 2021-02-09 11:38:54 +05:30
Rishabh Saxena
36021f9aba
fix viewer tabs arrow btns on mobile (#2910) 2021-02-09 11:05:06 +05:30
Trisha Anand
078870f7c9
Communicate action execute on load changes in update layout (#2825) 
* 1. Update on load actions correctly
2. Send the changed actions with their changes as well as messages back to the client as part of the response.

* Added test case to assert that the action updates are correctly recorded in updateLayout.

* Code cleanup + added more comments for code readability

* Incorporated review comments.
 2021-02-09 10:39:08 +05:30
Shrikant Sharat Kandula
fbf6021080
Fix nested structure translation in DynamoDB (#2915) 2021-02-09 06:59:45 +05:30
Nidhi
973cd850e7
Modified documentation links for plugins (#2909) 
* Modified documentation links for plugins

* Modified documentation links for plugins
 2021-02-08 17:11:31 +05:30
Shrikant Sharat Kandula
ebcbfb0043 Merge branch 'release' 2021-02-08 16:39:47 +05:30
Piyush Mishra
0a6040c1cd
Hotfix redux-form getting destroyed (#2908) 2021-02-08 16:24:49 +05:30
NandanAnantharamu
3d43d04658
Remove unwanted step in Cypress Map widget test (#2902) 
* updated test

* removed the commented line

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-08 16:20:28 +05:30
NandanAnantharamu
1aa879d8c2
updated flaky test (#2899) 
* updated flaky test

* review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-08 15:50:03 +05:30
Shrikant Sharat Kandula
433ce89c76
Add support for handling array types in Postgres plugin (#2887) 2021-02-08 15:06:57 +05:30
Nidhi
35b3e7d84f
Switched test container ver (#2898) 2021-02-08 13:40:53 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823) 
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
 2021-02-08 13:00:01 +05:30
Rishabh Saxena
a473ed23b0
fix navbar bottom border when tabs arent rendered (#2883) 2021-02-08 10:50:52 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Piyush Mishra
a2d8061aa2
Prep for a separate RestAPIDatasource (#2874) 2021-02-04 17:50:24 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Sumit Kumar
e6b77a1299
Stop logging some AppsmithPluginException to Sentry (#2351) 
1. Move package  appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
 2021-02-04 15:24:30 +05:30
Hetu Nandu
0332c15d56
Better handling of action error response (#2839) 2021-02-04 15:08:25 +05:30
Shrikant Sharat Kandula
5c9f90fd59
Fix missing user name in first organization name (#2873) 2021-02-04 14:04:24 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link 
Fix/docs link
 2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Piyush Mishra
0ca5563b83
Chronological system events for developer user (#2530) 2021-02-03 18:46:48 +05:30
NandanAnantharamu
b3a75de6d3
split the test (#2799) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-03 18:08:27 +05:30
Shrikant Sharat Kandula
779c41e0d3 Merge branch 'release' 2021-02-03 17:44:23 +05:30
Nikhil Nandagopal
db9c2d6c27 Updated doc link 2021-02-03 17:28:05 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-03 17:00:19 +05:30
Shrikant Sharat Kandula
f950a9352b
Fix datasource hostnames being saved with spaces (#2844) 2021-02-03 16:46:09 +05:30
Nikhil Nandagopal
d27865e4c9
Merge pull request #2843 from appsmithorg/fix/filepicker-name 
added file name to file picker and fixed a crash
 2021-02-03 15:10:44 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
63c028159c
Fix manage users link not visible in the share modal when triggered from the editor or viewer (#2653) 2021-02-03 14:51:49 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777) 
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-03 11:56:46 +05:30
Piyush Mishra
311fb5ad47
Fail client build if anything fails (#2820) 2021-02-03 11:02:00 +05:30
Hetu Nandu
bda90b4bf3
Wrap words in a toast message (#2832) 2021-02-03 10:43:55 +05:30
Shrikant Sharat Kandula
e9ba40f1f4
Analytics data point on action execution (#2740) 
* Add analytics data point on action execution

* Include application details in action exec data point

* Only send action execution event on cloud

* Analytics is auto-disabled on self-hosted setups

* Move event name to AnalyticsEvents enum

* Move analytics Mono to separate method

* Use a common function to enqueue analytics message

* Provide analytics properties from caller method

* Use consistent casing in event names for analytics
 2021-02-02 20:24:27 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789) 
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
 2021-02-02 20:12:49 +05:30
Rishabh Saxena
9d97645b3c
minor style fixes: page context menu background color (#2479) 2021-02-02 17:47:18 +05:30
prapullac
66eb08413c
Test Ideas for "Copy to Clipboard" (#2585) 
* Test Ideas for copy to Clipboard

* Adding test ideas for App viewer and admin flow

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-02 14:11:34 +05:30
Nidhi
01bbc03857
Fixed handling of lists in dynamodb (#2818) 2021-02-02 13:35:58 +05:30
Nidhi
c83fb70b95
Fixed ExecuteOnLoad not getting set for onPageLoad actions (#2801) 
* Piped onpageload update function

* Added tests
 2021-02-02 10:48:51 +05:30
Shrikant Sharat Kandula
98a0cd59b1
Fix reference types in arrays in Firestore (#2811) 
* Fix reference types in arrays in Firestore

* Added a whole bunch of tests for various data types
 2021-02-02 10:18:06 +05:30
Hetu Nandu
4505e41369
Migrate renamed canvas widgets to the correct name (#2782) 2021-02-01 20:03:13 +05:30
Abhinav Jha
3a9b328dcc
Fix: New widget and action name conflicts (#2778) 2021-02-01 20:02:43 +05:30
Abhinav Jha
51696b7220
Tab names can now be updated from the entity explorer (#2779) 2021-02-01 18:47:55 +05:30
Tim Dillon
91d5eb5860
Fix user email duplicated as name (#2787) 2021-02-01 14:51:44 +05:30
Shrikant Sharat Kandula
8475d71600
Fix RestAPI plugin not starting up (#2757) 
* Remove unneeded dependency exclusions
 2021-02-01 14:38:06 +05:30
Shrikant Sharat Kandula
018e1a94d6
Fix Firestore single document method for ref types (#2790) 2021-02-01 14:23:48 +05:30
Hetu Nandu
86cb8cac67
Allow for navigateTo urls to be of mailto or tel url schemes t (#2781) 2021-02-01 13:47:31 +05:30
Hetu Nandu
22afbe8971
Fix Array paths (#2775) 2021-01-29 09:59:23 -08:00
Piyush Mishra
164de6fb7e
Avoid double validation (#2687) 2021-01-29 11:34:28 +05:30
Dwayne Forde
f8974f1911
Fixes a small syntax issue with ./start-https.sh (#2767) 2021-01-29 09:55:51 +05:30
Arpit Mohan
433461a347
Merge pull request #2759 from appsmithorg/release 
Release v1.3.2
 2021-01-28 18:02:48 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
prapullac
4ccdba9e85
Adding manual test ideas for Home page and Login scenarios (#2627) 
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-01-28 14:42:22 +05:30
Piyush Mishra
c3740709d0
Do not show sections that are supposed to be hidden (#2746) 2021-01-28 14:26:29 +05:30
Rishabh Saxena
ca052e7515
minor updates for auth pages: polish UI, hide empty email error message (#2743) 2021-01-28 12:50:09 +05:30
Nidhi
c17a2ea536
Modified error displayed to user on generic bad request (#2583) 
* Modified error displayed to user on generic bad request

* Separate null check for cURL import
 2021-01-28 12:14:34 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines (#2729) 
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
 2021-01-28 12:08:44 +05:30
Rishabh Saxena
4c393f0f1f
fix: action not a plain object for widget entity name action creater (#2638) 2021-01-27 23:38:08 +05:30
Rishabh Saxena
19c4559c95
fix: datasource bound value preview in the explorer showing entire response (#2480) 2021-01-27 23:35:32 +05:30
Shrikant Sharat Kandula
b731793a88
Fix reference type fields in Firestore throwing 500 (#2718) 2021-01-27 20:38:46 +05:30
NandanAnantharamu
8358709f56
Added usecase for orgNaming convention (#2521) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-27 18:44:44 +05:30
Shrikant Sharat Kandula
350aea90c4
Revert RestAPI plugin signature timeout fix (#2748) 2021-01-27 17:24:25 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478) 
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-27 17:08:21 +05:30
Shrikant Sharat Kandula
63b7eb6e95
Fix signature in RestAPI plugin throwing timeout error (#2745) 
* Fix restapi signature throwing timeout error

* Add missing dependencies for restapi
 2021-01-27 14:55:08 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691) 
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-27 14:37:33 +05:30
Shrikant Sharat Kandula
a6d76d1672
Fix organization slug computation clashes (#2725) 
* Fix organization slug computation clashes

* Handle case where number-less slug is available
 2021-01-27 14:35:43 +05:30
Abhinav Jha
0fa245a985
Fix issue where users could undo delete long after the timeout has expired (#2741) 2021-01-27 13:51:47 +05:30
Shrikant Sharat Kandula
6bf2be65c0
Don't attempt to get structure for invalid datasources (#2730) 2021-01-27 13:44:15 +05:30
Vicky Bansal
aa71f2ae7b
Handle invalid entity ids (#2547) 2021-01-27 12:26:19 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Hetu Nandu
43322413c6
Support for navigateTo function to open in new window (#2706) 
* Support target for navigate function

* Add docs and action creator field
 2021-01-27 11:58:23 +05:30
Rishabh Saxena
aea3b3d4db
Revamping UI on the Login/Signup page (#2696) 2021-01-27 11:42:32 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
Tim Dillon
c9b3059498
Disable sort by Delete column in Members page (#2722) 2021-01-27 00:24:50 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Shrikant Sharat Kandula
42efb20d14
Remove unused cert fields for Mongo and Postgres plugins (#2723) 2021-01-26 18:44:01 +05:30
Nidhi
6515b5c91c
Fixed null endpoint issue for MySQL plugin (#2719) 2021-01-26 17:16:31 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Trisha Anand
9e0f36a6f2
Improve Server thrown Error Messages' language (#2705) 
* Improve Error Messages

* Added naming convention expansion for action name in the error

* Fixed failing test case assertion.

* Minor formatting.
 2021-01-25 18:50:32 +05:30
Trisha Anand
3776e82fb8
Scheduling of parallel tasks implementation for on-page load actions (#2667) 
* Proof of concept code which calculates the on load page actions.

* Refactored the field names introduced in Layout. Added a new field to keep a track of direct action names used in dynamic bindings in the DSL.

* Untested compute on on page load actions completed.

* Working page load actions computation.
TODO : Update the tests for correctness.

* Added fix for BFS starting from root nodes instead of arbitrary nodes.
Fixed a test case to assert for correct page load actions.

* Fixed the bug where the ids of the actions were not getting set in the layout. Also asserting the same in the test case for catching the future breaks.

* Minor refactor of function name to clear its purpose without reading the code.

* Incorporated review comments.

* Added conditional checks for unpublished action deleted and circular dependency of actions depending on each other.
 2021-01-25 16:54:45 +05:30
Hetu Nandu
3f2e60dc0d
Sanitise any other possible place which could send functions (#2704) 2021-01-25 16:49:31 +05:30
Hetu Nandu
5dc01c677d
Batching widget property updates (#2685) 
- Changed the updateWidgetProperty redux action to use an object of updates instead of single update
- Added the new batchUpdateWidgetProperty action
> This action will calculate dynamicPath changes for all the updates and update them together
- Added the new deleteWidgetProperty action
>This action will delete a property and any dynamicPaths/child dynamicPaths that exist
 2021-01-25 14:27:26 +05:30
devrk96
3be4828d63
Fix: App name UI in edit and deploy mode (#2216) 2021-01-25 12:51:54 +05:30
Pawan Kumar
4f1fd68052
add check if widget is available in data tree (#2681) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-25 11:01:44 +05:30
NandanAnantharamu
536a222e1c
Uncommented few tests (#2695) 
* Uncommented few tests

* updated dsl

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-25 10:39:16 +05:30
Rishabh Saxena
e8a01c456d
product updates modal test (#2677) 2021-01-23 13:46:50 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a309107623
Fix - Remove delete icon when there are no filters in table widget (#2605) 2021-01-22 15:17:14 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
ae276a93f8
Fix - Boolean values comparison in Table widget filters(#2586) 
- Display filter label instead of value
 2021-01-22 15:14:03 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
vicky-primathon
64a0a44446
Remove table row alternating colors (#2552) 2021-01-22 15:07:43 +05:30
Shrikant Sharat Kandula
1e8aa62654 Merge branch 'release' 2021-01-22 14:34:58 +05:30
Shrikant Sharat Kandula
468e84aabb
Fix calls to release notes from cloud instances (#2680) 2021-01-22 14:25:24 +05:30
Hetu Nandu
d4be9b9404
Remove any functions from Eval Action bindings task before returning from the worker (#2679) 2021-01-22 13:40:00 +05:30
Trisha Anand
48cfa2cea0
In case an action has been deleted in unpublished state, dont return it to the user in edit mode. (#2678) 2021-01-22 13:19:42 +05:30
Rishabh Saxena
5ab2e194f7
update release modal styles (#2668) 2021-01-22 11:31:41 +05:30
Rishabh Saxena
57f6219d75
update styles for new updates count (#2646) 2021-01-22 11:04:37 +05:30
Rishabh Saxena
64a90a6767
enable immer autofreeze only in development (#2669) 2021-01-22 10:50:55 +05:30
dependabot[bot]
41690e2d61
Bump immer from 7.0.9 to 8.0.1 in /app/client (#2659) 
Bumps [immer](https://github.com/immerjs/immer) from 7.0.9 to 8.0.1.
- [Release notes](https://github.com/immerjs/immer/releases)
- [Commits](https://github.com/immerjs/immer/compare/v7.0.9...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-21 19:00:44 +05:30
Shrikant Sharat Kandula
317fa1e59c Remove duplicate function definition 2021-01-21 17:43:41 +05:30
Shrikant Sharat Kandula
95250cf955 Merge branch 'release' 
# Conflicts:
#	app/client/src/constants/messages.ts
#	app/client/src/sagas/ErrorSagas.tsx
 2021-01-21 17:16:33 +05:30
Pawan Kumar
f059e40484
Fix - RichTextEditor test by increasing wait time (#2666) 
* remove default action function in messages file

* revert getErrorMessageFromActionType comment

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-21 16:38:18 +05:30
Arpit Mohan
8ba4db6a96 Commenting out the test for RTE because it's failing even though the widget is operating properly 
The test needs to be fixed
 2021-01-21 14:58:00 +05:30
Hetu Nandu
4014e523db Never show the redux action type in toast errors (#2635) 2021-01-21 12:17:04 +05:30
Hetu Nandu
4021b210b1
Never show the redux action type in toast errors (#2635) 2021-01-21 12:12:53 +05:30
Shrikant Sharat Kandula
6b406be39e
Fetch release notes for caching every two hours (#2657) 
* Fetch release notes for caching every two hours

* Revert unrelated changes in Ping class
 2021-01-21 11:59:35 +05:30
Rishabh Saxena
628ac6953f
Scroll to created org (#2477) 2021-01-21 11:49:06 +05:30
dependabot[bot]
e781ceb30a
Bump jackson-databind in /app/server/appsmith-interfaces (#2652) 
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.10.5 to 2.9.10.7.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-21 10:48:01 +05:30
Shrikant Sharat Kandula
52c689efee
Add a migration to fix any remembered versions (#2651) 
* Add a migration to fix any remembered versions

* Drop the userData collection instead
 2021-01-21 07:39:41 +05:30
hetunandu
7f713b3def uncomment RTE tests 2021-01-20 16:53:58 +05:30
hetunandu
ee985af3d2 Merge branch 'release' 2021-01-20 16:48:30 +05:30
hetunandu
a478fcb149 Temporary comment RTE tests 2021-01-20 16:48:02 +05:30
Shrikant Sharat Kandula
63fb249e40 Merge branch 'release' 
# Conflicts:
#	app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js
#	app/client/src/components/editorComponents/Onboarding/Tooltip.tsx
#	app/client/src/constants/OnboardingConstants.tsx
#	app/client/src/pages/Editor/Welcome.tsx
#	app/client/src/sagas/ActionExecutionSagas.ts
#	app/client/src/sagas/OnboardingSagas.ts
 2021-01-20 15:49:56 +05:30
Rishabh Saxena
d2dfd75a0c
use editor init event intead of setup to check if initialised (#2622) 2021-01-20 11:00:53 +05:30
Shrikant Sharat Kandula
d4990683c6
Fix UI for documentation modal (#2631) 2021-01-19 22:01:35 +05:30
Rishabh Saxena
cf2e5ce9d1
fix: use popover for ads dropdown options (#2628) 2021-01-19 19:42:00 +05:30
Rishabh Saxena
20d315b527
check for empty releases (#2619) 2021-01-19 14:48:32 +05:30
Rishabh Saxena
3aa268174d
use script loader for tinymce (#2620) 2021-01-19 14:24:50 +05:30
NandanAnantharamu
4d556754e5
Fixes for Filepicker test flakiness (#2616) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-19 14:21:16 +05:30
Rishabh Saxena
8e459a0c6b
validate map center and markers (#2488) 2021-01-19 12:59:15 +05:30
Rishabh Saxena
969b6fd0d2
Product updates modal (#2453) 2021-01-19 11:47:15 +05:30
Shrikant Sharat Kandula
9ead9af5f6
Respond with empty string when no new versions (#2618) 2021-01-19 11:37:31 +05:30
Shrikant Sharat Kandula
f6845486d2
Handle snapshot versions as special (#2617) 
This is needed for remembering when a user has viewed
release notes. Snapshot versions aren't a tagged marker
on the version timeline so aren't useful for this purpose.
 2021-01-19 08:24:56 +05:30
abhishek nayak
c911bd183c
Merge pull request #2613 from appsmithorg/chart-widget-example 
Update ChartDataControl.tsx
 2021-01-19 01:19:26 +05:30
Shrikant Sharat Kandula
3dc6f1107b
Send repo information when fetching release notes (#2615) 2021-01-18 21:21:22 +05:30
abhishek nayak
4048b81b2e
Update ChartDataControl.tsx 2021-01-18 18:47:50 +05:30
Shrikant Sharat Kandula
04d4812fc9
Fix getting release notes always resulting empty (#2609) 2021-01-18 15:21:50 +05:30
Nidhi
e6a0b00a25
Added Oauth2 functionality for REST APIs (#2509) 
* Added Oauth2 functionality for REST APIs

* Encrypted response

* Missed file

* Review comments and tests

* Removed broken test
 2021-01-15 16:41:13 +05:30
akash-codemonk
6b8e3d7dd5
Onboarding changes (#2549) 
- Reduce the delay for the deploy modal to 1s.
- Separate ONBOARDING_ADD_WIDGET from ONBOARDING_ADD_WIDGET_CLICK event
- Add step metadata for skip onboarding event
- Improve the contrast for the add widget button
 2021-01-15 14:49:15 +05:30
Hetu Nandu
11766c0e4a
Action onPageLoad test fix (#2581) 2021-01-15 11:08:53 +05:30
Hetu Nandu
2b8bae158c
Batch action evaluation calls (#2561) 2021-01-14 20:07:21 +05:30
Hetu Nandu
8cff9bd9b9
Avoid evaluation for unnecesarry batch success calls (#2579) 2021-01-14 16:45:25 +05:30
NandanAnantharamu
9f2fbf13c8
Cypress upgrade to 6.2.1 (#2535) 
* Cypress upgrade to 6.2.1

* Replaced route and server and assertions

* Removed intercept as it involves changes with alias

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-14 11:14:07 +05:30
NandanAnantharamu
d1d70b8b5c
Updated mongodatasource tests (#2567) 
* Updated mongodatasource tests

* Commented assertion for test datasource and updated query test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-13 21:34:23 +05:30
Hetu Nandu
5310908cea
Handle action failure of on page load actions (#2554) 2021-01-13 17:17:41 +05:30
Hetu Nandu
42aa83a729
Selectively add paths to dependency map and evaluation order (#2537) 2021-01-13 16:22:03 +05:30
Hetu Nandu
c184fd3d3c
Remove deleted paths from evaluation order (#2517) 2021-01-13 16:21:46 +05:30
Arpit Mohan
36a47631ba Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-01-13 15:41:52 +05:30
Arpit Mohan
5860b1b2ab Adding the init dump SQL file for PostgreSQL database 
This is used when running the Cypress tests
 2021-01-13 15:41:39 +05:30
Hetu Nandu
d3e517ecb2
Fix for tabs widget getting the same name (#2538) 
Co-authored-by: Piyush <piyush@codeitout.com>
 2021-01-13 15:40:28 +05:30
akash-codemonk
09c4e4fc49 Onboarding deploy tooltip fix (#2490) 2021-01-13 15:27:53 +05:30
akash-codemonk
44e300ec45 Onboarding fixes (#2458) 2021-01-13 15:27:45 +05:30
akash-codemonk
b5a1c93f09 Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-13 15:27:37 +05:30
akash-codemonk
6e4cdb0f84 Hide other header elements while showing the deploy button 2021-01-13 15:27:29 +05:30
akash-codemonk
1e17c03478 Fix onboarding test failure causing other tests to fail (#2417) 2021-01-13 15:27:15 +05:30
Trisha Anand
91b8922f1c
In case cs service returns an error, stop processing release notes and resume with the caller flow. (#2550) 
* In case cs service returns an error, stop processing release notes and resume with the caller flow.

* In case the server was unable to exchange messages with the CS server, bail out of further processing gracefully since this is not a must have but rather a good to have feature.
 2021-01-13 14:30:23 +05:30
Arpit Mohan
2135a4a0e8 Dummy commit to trigger the build 2021-01-13 13:39:24 +05:30
Nidhi
9ea5c884e1
Null check for empty pagination next url (#2546) 2021-01-13 12:12:29 +05:30
Rishabh Saxena
a2528286a3
bump blueprint core to 3.36 for using async control prop (#2491) 2021-01-13 10:53:16 +05:30
Trisha Anand
c24bc826e0
When an application name is changed, the isPublic flag is reset to false. (#2539) 2021-01-12 20:06:33 +05:30
Shrikant Sharat Kandula
c6c128270c
Include version information when building Docker images for server and client (#2200) 
* Include version information in backend builds

* Enable manual trigger of server workflow

* Add a dummy input field for manual trigger

* Fix secret checking in github actions

* Disable cron scheduling of sync job

* Build docker image on pushing a version tag

* Fix duplicated id and invalid id in release workflow

* Don't try to login to Docker

* Avoid download progress outputs from Maven

* Add version information for building client

* Calculate version number only once

* Enable push to DockerHub after building images

* Use Docker username from GitHub secrets

* Fix Docker username in tags when building image

* Use different secret for org name

* Minor refactoring in server workflow

* Update client build workflow to use version

* Enable manual triggering of client workflow

* Set snapshot version for server builds

* Push to docker for all branches (temp)

* Undo temp change to push all branches to DockerHub

* Use Docker org from secrets in client.yml

* Fix missing version reference in client.yml

* Remove debug command in dockerfile

* Save release notes in a resource file in Docker image

* Fix query serialization to get release notes

* Get releases of current repo instead of hard-coded repo

* Fix variable quoting for repo variables

* Exclude draft and prerelease nodes from image

* Fix call to any in release notes processor

* Fix syntax error in release notes script

* Implement API to get new release count and info

* Add missing ReleaseNotes component

* Have the release workflow run after a release is created

* Build server after generating release notes

* Change release trigger to "released"

* Change release trigger to "published"

* Change release trigger to released, edited and deleted

* Use JS script to get release notes, take 1

* Filter drafts and prereleases in script

* Fix syntax error in ES6

* Write release notes to file

* Create parent directory before writing release notes

* Log cwd in release notes script

* Log pwd along with release-notes content

* Handle case where working directory is incorrect

* Remove shell based release notes generator

* Don't show error when Sentry config is missing

* Check for sentry auth token to enable Sentry

* Carry build's exit code over to CI

* Mark out build result and add a note about it

* Add a small test to verify new versions computation

* Remove incorrect test assertion

* Remove generation of release notes file

* Connect to cloud services to fetch release notes data

* Fix missing runner for test class

* Handle missing cloud_services base URL

* Fix test failures due to missing mocks

* Enable sync-ee cron job

* Revert build.sh as there's no real change

* Add API to update release notes viewed version for users

* Fix prettier line-length errors

* Create UserData model for info unrelated to auth

* Fix field name calls

* Ensure we have a userId before setting userData

* Add tests for setting version number in UserData

* Include instanceId when fetching release notes
 2021-01-12 18:15:15 +05:30
Shrikant Sharat Kandula
4fc6a7e763
Disable welcome email with an environment variable (#2527) 2021-01-12 16:50:26 +05:30
Shrikant Sharat Kandula
e4ba991114
Remove unused API endpoints for invite confirmation (#2532) 2021-01-12 16:20:48 +05:30
Trisha Anand
88e8723f37
Adding id and pluginType correctly for a user set on page load action (non referenced in the DSL) (#2523) 2021-01-12 14:39:53 +05:30
Hetu Nandu
f53af44316
Make first eval after page change happen with new layout first (#2516) 2021-01-12 14:34:34 +05:30
Shrikant Sharat Kandula
23cffc208f
Allow signup for admins, even if publicly disabled (#2520) 
* Allow signup for admins, even if publicly disabled

* Use Set for admin email addresses

* Set two admin emails in test
 2021-01-12 14:13:44 +05:30
Hetu Nandu
94cae231c1
Make sure Table selected row is not set to undefined on mount (#2518) 2021-01-12 11:45:08 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Shrikant Sharat Kandula
9cd9edd3fa
Disable uninvited signups via environment variable (#2512) 
* Disable signup API via environment variable

* Allow signup for invited users, even if disabled publicly

* Add test for signup when signup is disabled

* Run invite flow tests when signup is disabled

* Revert status annotation in signup API endpoint

* Remove unused tests on invite flow

* Change signup disabled error message
 2021-01-11 20:10:50 +05:30
Trisha Anand
6704e05ad0
Sub tree fixes for issues found on Jarvis (#2482) 2021-01-11 13:26:17 +05:30
Nidhi
1fa7d46845
Fixed unreferenced actions not being triggered for execute on load (#2434) 
* Fixed unreferenced actions not being triggered for execute on load

* WIP : Have to commit some minor cosmetic code formatting changes

* Comments and fix for action ordering

* modified test case

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-01-11 12:18:07 +05:30
Rishabh Saxena
c36b6b640f
auto focus create org input field (#2493) 2021-01-11 11:14:54 +05:30
Pawan Kumar
fcac402789
Fix - 502 in save layout is abruptly taking me to an error screen (#2475) 
* remove crash:true in api + add error icon on page save

* remove crash true in api

* add crash on user init request fail

* dispatch safe crash action on user init call error

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-11 10:58:10 +05:30
akash-codemonk
d82d8965e4
Onboarding deploy tooltip fix (#2490) 2021-01-11 09:46:59 +05:30
Nikhil Nandagopal
4666f40a21
Merge pull request #2489 from appsmithorg/fix/analytics 
added appmode analytics to the execute action
 2021-01-08 14:53:04 +05:30
NandanAnantharamu
06ecc106d6
Using Cypress wait instead of postExecute for Table binding test (#2249) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-08 14:11:23 +05:30
Nikhil Nandagopal
a435133bdf added appmode analytics to the execute action 2021-01-08 13:06:22 +05:30
akash-codemonk
bad63f9e68
Onboarding fixes (#2458) 2021-01-08 11:36:09 +05:30
dependabot[bot]
0ab61079e2
Bump axios from 0.19.2 to 0.21.1 in /app/server/scripts/node (#2462) 
Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-07 17:38:24 +05:30
Trisha Anand
d1d73070f4 Adding action execution time and logging the same (#2473) 2021-01-07 14:10:22 +05:30
Trisha Anand
527bac0827
Adding action execution time and logging the same (#2473) 2021-01-07 13:49:50 +05:30
imgbot[bot]
ec115967f5
[ImgBot] Optimize images (#2384) 
*Total -- 1,492.69kb -> 1,218.88kb (18.34%)

/static/form.png -- 651.09kb -> 517.01kb (20.59%)
/static/editor.png -- 694.01kb -> 555.61kb (19.94%)
/static/appsmith_logo_white.png -- 4.91kb -> 4.31kb (12.23%)
/app/client/src/assets/icons/ads/app-icons/bar-graph.svg -- 0.54kb -> 0.51kb (4.18%)
/app/client/src/assets/icons/ads/app-icons/team.svg -- 1.03kb -> 1.00kb (3.12%)
/app/client/src/assets/icons/ads/app-icons/line-chart.svg -- 0.88kb -> 0.86kb (2.77%)
/app/client/src/assets/icons/ads/app-icons/email.svg -- 0.25kb -> 0.24kb (2.73%)
/app/client/src/assets/icons/ads/app-icons/single-person.svg -- 0.69kb -> 0.68kb (1.97%)
/app/client/src/assets/icons/ads/app-icons/airplane.svg -- 1.18kb -> 1.16kb (1.82%)
/app/client/src/assets/icons/ads/app-icons/family.svg -- 1.52kb -> 1.49kb (1.8%)
/app/client/src/assets/icons/ads/app-icons/hospital.svg -- 0.41kb -> 0.41kb (1.65%)
/app/client/src/assets/icons/ads/app-icons/pants.svg -- 0.45kb -> 0.44kb (1.52%)
/app/client/src/assets/icons/ads/app-icons/call.svg -- 0.67kb -> 0.66kb (1.46%)
/app/client/src/assets/icons/ads/app-icons/lotus.svg -- 1.35kb -> 1.33kb (1.3%)
/app/client/src/assets/icons/ads/app-icons/lightning.svg -- 0.78kb -> 0.77kb (1.25%)
/app/client/src/assets/icons/ads/app-icons/hat.svg -- 0.55kb -> 0.54kb (1.24%)
/app/client/src/assets/icons/ads/app-icons/couples.svg -- 1.50kb -> 1.48kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/mug.svg -- 0.56kb -> 0.55kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/sunflower.svg -- 1.15kb -> 1.13kb (1.19%)
/app/client/src/assets/icons/ads/app-icons/website.svg -- 1.83kb -> 1.81kb (1.12%)
/app/client/src/assets/icons/ads/app-icons/diamond.svg -- 0.63kb -> 0.62kb (1.09%)
/app/client/src/assets/icons/ads/app-icons/money.svg -- 1.18kb -> 1.17kb (1.07%)
/app/client/src/assets/icons/ads/app-icons/headphones.svg -- 0.84kb -> 0.83kb (1.04%)
/app/client/src/assets/icons/ads/app-icons/bus.svg -- 2.09kb -> 2.07kb (1.03%)
/app/client/src/assets/icons/ads/app-icons/pie-chart.svg -- 0.96kb -> 0.95kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/shirt.svg -- 0.67kb -> 0.67kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/smartphone.svg -- 0.68kb -> 0.68kb (1%)
/app/client/cypress/fixtures/appsmithlogo.png -- 1.97kb -> 1.96kb (0.99%)
/app/client/src/assets/icons/ads/app-icons/music.svg -- 0.74kb -> 0.73kb (0.93%)
/app/client/src/assets/icons/ads/app-icons/rocket.svg -- 1.55kb -> 1.54kb (0.88%)
/app/client/src/assets/icons/ads/app-icons/medical.svg -- 0.57kb -> 0.56kb (0.86%)
/app/client/src/assets/icons/ads/app-icons/plant.svg -- 1.06kb -> 1.05kb (0.83%)
/app/client/src/assets/icons/ads/app-icons/love.svg -- 0.83kb -> 0.82kb (0.82%)
/app/client/src/assets/icons/ads/app-icons/repeat.svg -- 0.76kb -> 0.75kb (0.78%)
/app/client/src/assets/icons/ads/app-icons/bird.svg -- 1.15kb -> 1.14kb (0.77%)
/app/client/src/assets/icons/ads/app-icons/car.svg -- 1.79kb -> 1.78kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/coding.svg -- 0.51kb -> 0.51kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/rose.svg -- 1.29kb -> 1.28kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/system.svg -- 1.03kb -> 1.02kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/tree.svg -- 0.95kb -> 0.94kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/card.svg -- 1.22kb -> 1.21kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/cricket.svg -- 0.96kb -> 0.95kb (0.71%)
/app/client/src/assets/icons/ads/app-icons/yen.svg -- 0.99kb -> 0.99kb (0.69%)
/app/client/src/assets/icons/ads/app-icons/location.svg -- 1.00kb -> 1.00kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/laptop.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/rupee.svg -- 1.04kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/medal.svg -- 1.05kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/shop.svg -- 1.96kb -> 1.94kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/cat.svg -- 1.60kb -> 1.59kb (0.61%)
/app/client/src/assets/icons/ads/app-icons/dog.svg -- 2.11kb -> 2.09kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/bicycle.svg -- 1.46kb -> 1.46kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/basketball.svg -- 1.52kb -> 1.51kb (0.58%)
/app/client/src/assets/icons/ads/app-icons/flag.svg -- 1.22kb -> 1.22kb (0.56%)
/app/client/src/assets/icons/ads/app-icons/euros.svg -- 1.24kb -> 1.23kb (0.55%)
/app/client/src/assets/icons/ads/app-icons/stars.svg -- 1.20kb -> 1.19kb (0.49%)
/app/client/src/assets/icons/ads/app-icons/chat.svg -- 1.49kb -> 1.49kb (0.46%)
/app/client/src/assets/icons/ads/app-icons/restaurant.svg -- 1.52kb -> 1.52kb (0.45%)
/app/client/src/assets/icons/ads/app-icons/saturn.svg -- 1.59kb -> 1.58kb (0.43%)
/app/client/src/assets/icons/ads/app-icons/moon.svg -- 1.65kb -> 1.65kb (0.41%)
/app/client/src/assets/icons/ads/app-icons/chinese-remnibi.svg -- 1.69kb -> 1.68kb (0.4%)
/app/client/src/assets/icons/ads/app-icons/burger.svg -- 2.77kb -> 2.76kb (0.39%)
/app/client/src/assets/icons/ads/app-icons/earth.svg -- 1.87kb -> 1.86kb (0.37%)
/app/client/src/assets/icons/ads/app-icons/joystick.svg -- 1.98kb -> 1.97kb (0.35%)
/app/client/src/assets/icons/ads/app-icons/steam-bowl.svg -- 2.95kb -> 2.94kb (0.33%)
/app/client/src/assets/icons/ads/app-icons/alien.svg -- 1.27kb -> 1.27kb (0.31%)
/app/client/src/assets/icons/ads/app-icons/uk-pounds.svg -- 2.33kb -> 2.32kb (0.29%)
/app/client/src/assets/icons/ads/app-icons/dollar.svg -- 2.59kb -> 2.58kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/pizza.svg -- 1.86kb -> 1.86kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/bitcoin.svg -- 2.75kb -> 2.74kb (0.25%)
/app/client/src/assets/icons/ads/app-icons/rainy-weather.svg -- 8.28kb -> 8.27kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/shake-hands.svg -- 4.62kb -> 4.61kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/football.svg -- 4.93kb -> 4.92kb (0.14%)
/app/client/src/assets/icons/ads/app-icons/snowy-weather.svg -- 8.34kb -> 8.33kb (0.12%)
/app/client/src/assets/icons/ads/app-icons/server.svg -- 9.10kb -> 9.10kb (0.08%)
/app/client/src/assets/icons/ads/app-icons/cloud.svg -- 23.21kb -> 23.20kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2021-01-07 11:23:35 +05:30
NandanAnantharamu
523e3ec397
flaky test updated (#2468) 
* flaky test updated

* updated another flaky test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-07 10:37:17 +05:30
Hetu Nandu
cb2dd3c9da
Handle for scenarios scrollTo is not available in browser (#2456) 2021-01-07 10:36:25 +05:30
prapullac
7309e91153
Added test for Datasource associated with API (#2336) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2021-01-07 10:32:26 +05:30
Hetu Nandu
2943f7f782
Copy Text trigger function (#2394) 2021-01-07 10:14:30 +05:30
Sumit Kumar
4748014cee
Redshift plugin (#2440) 
* introduce redshift plugin
 2021-01-06 17:51:07 +05:30
Pawan Kumar
6fa31e6388
Fix - Lodash import typo (#2466) 
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

* fix improt typo

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-06 17:31:04 +05:30
Trisha Anand
bd011c45ab
Removed unused organization setting, setting class, and query class. (#2464) 2021-01-06 17:30:09 +05:30
Pawan Kumar
563c32d203
[Fix] - Authentication after 404 not redirecting back to the original page (#2423) 
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-06 16:54:16 +05:30
Rishabh Saxena
affb68ee52
Fix widths for pagination test and modal confirm btns (#2445) 2021-01-06 16:39:08 +05:30
Hetu Nandu
eb1f9e7ec8
Update axios package (#2454) 2021-01-06 13:58:49 +05:30
Pawan Kumar
51076eaead
Fix: Show appropriate error message when an onPageLoad action fails (#2355) 
* show action in toast error message on pageload error

* add test case

* add error body in toast

* fix test case

* fix test case

* update test case

* uncomment test case

* remove the console log

* remove unused console

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-06 10:55:47 +05:30
akash-codemonk
8d303d3d9f
Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-06 09:38:46 +05:30
akash-codemonk
f5e696a4f4
Hide other header elements while showing the deploy button 2021-01-06 09:38:18 +05:30
Trisha Anand
db2b002ac7 Increased logs to debug future connection leaks. (#2437) 
* Increased logs to debug future connection leaks.

* Fetch a connection from the pool only if a query exists.

* Minor comment added.

* Minor rewrite

* Code formatting.

* Update app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Added hikari cp pool stats to get database structure function as well.

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2021-01-05 18:39:36 +05:30
Nidhi
de5003a98e
Added type parameter for REST API plugin, and changes for no auth (#2438) 
* Added type parameter for REST API plugin, and changes for no auth

* Removed logs

* Converted to reactive
 2021-01-05 17:59:50 +05:30
Hetu Nandu
45918bfd33 Fix invalid toast message for evaluation error (#2443) 
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
 2021-01-05 17:16:51 +05:30
Hetu Nandu
1598899dd6
Fix invalid toast message for evaluation error (#2443) 
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
 2021-01-05 17:15:37 +05:30
Trisha Anand
d5074ee7f7
Increased logs to debug future connection leaks. (#2437) 
* Increased logs to debug future connection leaks.

* Fetch a connection from the pool only if a query exists.

* Minor comment added.

* Minor rewrite

* Code formatting.

* Update app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Added hikari cp pool stats to get database structure function as well.

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2021-01-05 15:34:55 +05:30
Rishabh Saxena
2629ead4b7
fix: check for undefined error action payload (#2428) 2021-01-05 12:12:04 +05:30
akash-codemonk
69cd988c01
Fix onboarding test failure causing other tests to fail (#2417) 2021-01-04 15:52:22 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841) 
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
 2021-01-04 15:46:08 +05:30
NandanAnantharamu
4c5387f707
updated assertion (#2419) 
* updated assertion

* review comment incoirporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-04 12:59:21 +05:30
Trisha Anand
214f911060 Fixed merge conflict related build failure. 2021-01-04 11:24:00 +05:30
Trisha Anand
24ef325467
Merge branch 'master' into release 2021-01-04 11:18:13 +05:30
Trisha Anand
e17da5f913 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2021-01-01 01:24:55 +05:30
Trisha Anand
a3378397d7 Increasing pool size to 20 to reduce the number of times datasource becomes unusable. Symptomatic relief till I can solve for this at leisure over the next few days. 
Note : Update/Insert are leading to connection leak
 2021-01-01 01:24:26 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-31 17:54:50 +05:30
Piyush Mishra
3d7242d716
Cleanup cancelled requests (#2387) 2020-12-30 18:56:44 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Rishabh Saxena
c344377a9d
only autofocus widget search (#2400) 2020-12-30 18:32:11 +05:30
Hetu Nandu
31d8c8c4eb
[Worker] Fix critical issues (#2393) 2020-12-30 18:28:57 +05:30
Trisha Anand
d4640e01a2
Invite users once triggered should not be cancellable. (#2401) 
* Invite users once triggered should not be cancellable.
 2020-12-30 16:50:01 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30
Rishabh Saxena
f1f9441cc6
auto focus search input (#2360) 2020-12-30 14:33:24 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
5ae2da1578
Send clean validated tree back (#2376) 2020-12-29 23:57:07 +05:30
Rishabh Saxena
37d0314c2a
default error code (#2363) 2020-12-29 22:22:31 +05:30
Rishabh Saxena
14effe6db1
fix del hotkey (#2349) 2020-12-29 22:21:57 +05:30
Rishabh Saxena
ccd9371820
update tooltip test (#2392) 2020-12-29 19:50:14 +05:30
Trisha Anand
712f41db92
Reducing the probability of getting pages out of order (Expected order is the order in which the pages were created and added to the application). This should : (#2391) 
1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team.
2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
 2020-12-29 19:10:01 +05:30
Rishabh Saxena
13fae1a5c1
fix test (#2390) 2020-12-29 17:45:15 +05:30
Trisha Anand
ea366b1d29 Fixed NPE in database migration 2020-12-29 17:06:30 +05:30
Trisha Anand
735a4398b2
Added a migration to old rest api datasources which adds the new mandatory key isSendSessionEnabled with value N (#2388) 2020-12-29 16:29:28 +05:30
Rishabh Saxena
e526f5cca5
minox css fixes (#2375) 2020-12-29 16:17:32 +05:30
Hetu Nandu
b5e8673921
Properly log data tree instrumentation (#2228) 2020-12-29 14:55:56 +05:30
Trisha Anand
ea0f9c159c
[Bug] Multi page applications return only a single page when fetching pages per application (#2383) 
* Zipping flux with mono leads to mono not getting repeated and only the first emitted value of flux is processed further. This is leading to only a single page getting emitted in a multi page application.

* Added a test case to assert this for a multi page application
 2020-12-29 13:38:47 +05:30
Trisha Anand
a70b95be37 Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:29:50 +05:30
Trisha Anand
051d3c6c7f
Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:26:33 +05:30
Piyush Mishra
988ebe975b
RPC-like layer with graceful startup and shutdown around a webworker (#2252) 2020-12-28 14:12:43 +05:30
Sumit Kumar
6299c86f39
Add TC to test mongodb connection establishment (#2364) 
1. Test that when a query is attempted to run on mongodb server but refused because of lack of authorization, then
also, it indicates a successful connection establishment.
 2020-12-28 11:58:17 +05:30
dependabot[bot]
45497ba5ac
Bump node-notifier from 8.0.0 to 8.0.1 in /app/client (#2316) 
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 10:55:39 +05:30
Trisha Anand
6210b9a0c0
All newly created applications now have a default published state. (#2309) 
* All newly created applications now have a default published state.

* Added a test case to assert a new application comes up with default published states for both application and the default page.

* Function name changed.

* When trying to fetch a published version of a page when the page has not been published, throw a 404.

* WIP : Not working
 2020-12-28 10:30:43 +05:30
Piyush Mishra
ebcffadca1
Prettier fixes (#2366) 2020-12-28 09:47:50 +05:30
Piyush Mishra
8ef8bfd2ac
Prettier fix. (#2353) 2020-12-24 19:01:09 +05:30
akash-codemonk
466d0cfde1
Fix explorer entity icon alignment (#1413) 2020-12-24 15:41:02 +05:30
Rishabh Saxena
83349e2996
fix modal entity not renamed through property pane when closed by clicking on the overlay (#2185) 2020-12-24 11:43:01 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
3930c4c63c
Hotfix circularJSON (#2214) 2020-12-23 19:48:46 +05:30
Shrikant Sharat Kandula
85350b2940 Add migration to set isEncrypted field where missing (#2332) 
(cherry picked from commit d5e0fb18d8)
 2020-12-23 18:07:35 +05:30
Shrikant Sharat Kandula
4ff2834559 Missing isEncrypted should mean a true value 
(cherry picked from commit c7f330c4c7)
 2020-12-23 18:07:35 +05:30
Rishabh Saxena
4e802d2c5a
reset query on select, don't jump to active item (#2237) 2020-12-23 17:45:14 +05:30
Rishabh Saxena
396b12b024
reorder widgets alphabetically, autofocus search input (#2325) 2020-12-23 17:02:30 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Rishabh Saxena
77801b10ff
fix undo delete tab, create copy of tabs array (#2315) 2020-12-23 16:55:52 +05:30
Rishabh Saxena
9417335176
render column submenu popover inline (#2329) 2020-12-23 16:55:25 +05:30
Shrikant Sharat Kandula
d5e0fb18d8
Add migration to set isEncrypted field where missing (#2332) 2020-12-23 15:35:45 +05:30
Shrikant Sharat Kandula
c7f330c4c7 Missing isEncrypted should mean a true value 2020-12-23 14:23:03 +05:30
a
61e12235b2 Revert "reorder widget locale wise, autofocus search input" 
This reverts commit 0bcc8872eb.
 2020-12-23 11:08:52 +05:30
a
0bcc8872eb reorder widget locale wise, autofocus search input 2020-12-23 11:01:00 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
Sumit Kumar
53a6160139
Revert "Redshift plugin (#2112)" (#2314) 
This reverts commit 708ca7fedf.
 2020-12-22 16:59:18 +05:30
Sumit Kumar
708ca7fedf
Redshift plugin (#2112) 
1. Add new plugin to connect to AWS Redshift cluster and run query.
2. Add unit test cases.
 2020-12-22 15:35:25 +05:30
prapullac
91125ebc26
Manual test Ideas for home page (#2208) 2020-12-22 14:06:52 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)" 
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
 2020-12-22 13:02:02 +05:30
Shrikant Sharat Kandula
ea6e897dde
Firestore ADD_TO_COLLECTION command support (#2305) 
* Support ADD_TO_COLLECTION operation on Firestore

* Add test for Firestore add-to-collection command
 2020-12-22 12:32:14 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293) 
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
 2020-12-22 08:27:57 +05:30
Shrikant Sharat Kandula
cfcd7aa0bb
Fix Firestore datasources not encrypting secret key JSON when editing (#2296) 
* Fix encrypted field not being ignored in JSON

* Don't mask error in decrypting

* Revert masking of error in decrypting
 2020-12-21 17:43:15 +05:30
Rishabh Saxena
42173e9249
fix tooltip boundary, don't show on target focus (#2250) 2020-12-21 15:22:58 +05:30
devrk96
851ae51c3a
Auto scroll to specific section on homepage when reloading with same url (#2115) 2020-12-21 14:35:58 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
Piyush Mishra
5408806bf1
Do not add objects to the DataTree (#2275) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-12-21 11:44:20 +05:30
Nidhi
e3cf285d1e
Fixed encryption related bugs for empty/new datasource (#2287) 2020-12-21 10:41:57 +05:30
Shrikant Sharat Kandula
fdc4f7b200
Fix invalid templates and API breaking on invalid templates (#2286) 2020-12-19 13:00:24 +05:30
Shrikant Sharat Kandula
5e04ca5c9d
Add ability to configure order of templates of plugins (#2279) 2020-12-18 20:45:08 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-12-18 18:48:47 +05:30
Nidhi
5a36d17f7a
Fixed encryption related bugs for empty/new datasource (#2272) 2020-12-18 16:13:01 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Nidhi
a00c144e85
Subclassing authentication (#2215) 
* Sublcassing authentication

* Removed TODO

* Review changes
 2020-12-17 21:38:52 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223) 
* @hetunandu for president
 2020-12-17 20:13:01 +05:30
Hetu Nandu
4b3a0ca9de
Fix table text pagination test (#2253) 2020-12-17 18:52:19 +05:30
Piyush Mishra
29de447411
Upgrade fusioncharts npm package (#2241) 2020-12-17 17:43:33 +05:30
NandanAnantharamu
db89dddbad
Organization test split into 2 parts (#2247) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-17 14:16:54 +05:30
Hetu Nandu
4f92ea99ed
Remove functions for action evals (#2242) 2020-12-17 13:36:16 +05:30
Pawan Kumar
e63f0a9d2a
Fix: 404 error page shows server unavailable (#2195) 
* mount error wise route

* remove log

* add test case

* fix wrong error page

* fix typescript error + remove unused variable

* remove 404 + 500 routes

* remove unused imports

* fix typo in test case

* remove history replace in utils

* remove unused variable

* add error codes for safe crash

* remove unused variables

* add error codes in all api rejects + update error reducer code type

* update error codes in init saga

* add selectors for error safe crash + take error logic out of app router

* remove unused variables

* remove extra line

* add header in error pag

* refactor page header on error page

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-17 12:33:59 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-17 11:40:50 +05:30
Piyush Mishra
0ccc80127a
move null check out (#2221) 2020-12-16 14:52:34 +05:30
Rishabh Saxena
2f152bf5b1
fix prev widget hidden when dragging new (#2211) 2020-12-16 14:51:57 +05:30
Rishabh Saxena
17ded71de3
fix actions/queries not fetched after cloning a page (#2196) 
* fix actions/queries not fetched after cloning a page

* cf fix

* update type

* update test to check if api is cloned

* trigger tests
 2020-12-16 14:51:31 +05:30
Ashwani Sindhu
15a00f4982
Set document title as app name (#2203) 2020-12-15 16:54:44 +05:30
Rishabh Saxena
5c905ac0d8
Update styles for date time headers in a table (#2197) 2020-12-15 16:54:15 +05:30
Hetu Nandu
df902440f5
Add xml2json and json2xml functions (#2022) 2020-12-15 14:16:33 +05:30
Pawan Kumar
1cafbca767
Fix: The search in the multi select is not showing + Multi select dropdown stops functioning if default value is undefined (#2057) 
* fix dropdown input ghost width

* add fix when default option is undefined

* update test cases for dropdown undefined default value

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-15 10:34:51 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165) 
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-15 10:34:30 +05:30
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Rishabh Saxena
20d15188fd
br instead of p on enter within rte (#2188) 2020-12-14 14:50:45 +05:30
Trisha Anand
29706f7852
Removing printing the result for firestore plugin (#2191) 2020-12-14 14:48:50 +05:30
Rishabh Saxena
29d87a88f0
unmount during drag (#2168) 2020-12-14 12:38:00 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-14 11:50:44 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
Trisha Anand
e5c44168f3
Configured pool size for hikariCP when new pool comes uo. (#2170) 2020-12-14 11:07:53 +05:30
dependabot[bot]
17e8725a84
Bump ini from 1.3.5 to 1.3.8 in /app/client (#2176) 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-13 11:10:46 +05:30
Arpit Mohan
7ae4959c29 Correcting the if clause for environment variable 2020-12-12 22:03:03 +05:30
Arpit Mohan
372774e728 Checking if the new run command works in Github Action 2020-12-12 20:48:21 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Piyush Mishra
2a05df86c7
Hotfix crash on navigate to API page after widget rename (#2134) 2020-12-11 18:04:06 +05:30
Arpit Mohan
75b3f18a92 Correcting github actions yaml. 
Really need a validator for this
 2020-12-11 17:41:39 +05:30
Arpit Mohan
7fbd14228d Correcting the node_modules cache for Cypress tests 2020-12-11 17:39:10 +05:30
prapullac
b27a32940e
Manual Test Ideas (#2129) 2020-12-11 17:25:54 +05:30
Arpit Mohan
51757072de Ignoring manual cypress tests during build 
Also correcting the node_modules cache during yarn install
 2020-12-11 17:10:05 +05:30
Nidhi
9a9feff678
Reset execute on page load for new actions (copied or otherwise) (#2162) 2020-12-11 14:33:07 +05:30
Arpit Mohan
b517639bd0 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-12-11 13:11:11 +05:30
Arpit Mohan
2951c609ec Correcting the APP_HOST in netlify for deploy previews 2020-12-11 13:10:55 +05:30
devrk96
7475aa643a
Fix: Org logo upload redux state (#2068) 2020-12-11 12:31:13 +05:30
Trisha Anand
74342f8598
Adding hikariCP for postgres (#2130) 2020-12-10 21:08:02 +05:30
Arpit Mohan
85d958c2c0
[CodeFactor] Apply automated fixes (#2131) 
Co-authored-by: codefactor-io <support@codefactor.io>
 2020-12-10 18:44:31 +05:30
Arpit Mohan
c1de6ce8f7 Fixing prettier errors in DynamicBindingUtils 2020-12-10 17:22:18 +05:30
Piyush Mishra
580c261e5d
copy tab data before mutating (#2084) 2020-12-10 14:21:54 +05:30
Hetu Nandu
f312320940
Remove unsafe functions from eval (#2076) 2020-12-10 14:00:49 +05:30
Pawan Kumar
5553da02e8
Fix: Page crashes on cloning the API (#2087) 
* fixed the page crashig on cloning the api

* adding test cases

* comment out the drag and drop test case in input spec

* update test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-10 13:52:40 +05:30
devrk96
8ef7405421
Fix: User icon numbers on home page (#2070) 2020-12-10 13:37:48 +05:30
devrk96
2995410d27
Fixing text overflow word-break property fixed. (#2116) 2020-12-10 13:36:13 +05:30
Rishabh Saxena
d7dea9aff4
fix toast message on widget cut (#2059) 
* fix toast message on widget cut

* show msg when widget not selected during cut/copy
 2020-12-10 13:03:43 +05:30
Piyush Mishra
0e47c0a4c0
Fix brackets mismatch (#2019) 2020-12-10 11:48:59 +05:30
Nikhil Nandagopal
9b51bf9af2
Merge pull request #2109 from appsmithorg/fix/boolean-validation 
Fix for false evaluated value showing as null
 2020-12-10 11:27:52 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
NandanAnantharamu
9fb99c1145
Added tests for Table binding with Input Widget (#1955) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-12-10 10:52:19 +05:30
Hetu Nandu
74f8b51db3 Fix for false evaluated value showing as null 2020-12-09 22:25:59 +05:30
Trisha Anand
e97915c0a1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-12-09 19:17:22 +05:30
Trisha Anand
746b0ab58e Changed log to sout in postgres plugin 2020-12-09 19:16:54 +05:30
Nikhil Nandagopal
8864a1eca2
Merge pull request #2101 from appsmithorg/fix/sentry-errors 
added code to prune payloads from sentry actions and reduce depth of …
 2020-12-09 19:11:34 +05:30
Trisha Anand
888d79b06d Removing printing of result objects from plugin execution. 2020-12-09 19:03:51 +05:30
Nikhil Nandagopal
d228f6d117 fix for undefined access to crash field 2020-12-09 18:22:36 +05:30
Nikhil Nandagopal
7d70a71d70 added code to prune payloads from sentry actions and reduce depth of actions reported 2020-12-09 14:42:12 +05:30
Nikhil Nandagopal
854d514359
Merge pull request #2094 from appsmithorg/fix/sentry-errors 
Prune expensive redux actions and console logs from sentry
 2020-12-09 13:06:54 +05:30
devrk96
fba79f960b
App icon and color name change issue resolved (#2089) 2020-12-09 12:36:02 +05:30
Nikhil Nandagopal
67fc762968 Merge branch 'release' into fix/sentry-errors 
# Conflicts:
#	app/client/src/sagas/ErrorSagas.tsx
 2020-12-09 12:34:08 +05:30
Nikhil Nandagopal
0fc5817caa added a check for errors without payloads 2020-12-09 12:32:27 +05:30
Nikhil Nandagopal
e0ac6e9850 Allowed console errors to still be logged 2020-12-09 11:59:40 +05:30
Nikhil Nandagopal
cfa020c063 pruned expensive redux actions and console logs from sentry 2020-12-09 11:50:39 +05:30
Rishabh Saxena
6a3b3c7cb8
treat false str as falsy for env vars (#2055) 
* check boolean env values against  string

* refactor parseConfig

* consistent bools

* return true/false for those strings
 2020-12-09 11:22:50 +05:30
Hetu Nandu
04e963c599
Fix for 502 errors from the server (#1949) 2020-12-09 00:43:48 +05:30
NandanAnantharamu
ec7149f9d8
Test case for creating multiple apps (#1871) 
* Added test for #1716

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-08 23:47:34 +05:30
Trisha Anand
8283396056
Moved from boundedElastic to elastic to ensure that the server services the plugin execution request as soon as the request arrives. (#2090) 2020-12-08 22:04:14 +05:30
Sumit Kumar
db3636f7b0
mysql plugin - check if connection is stale before running query (#2080) 
1. Check if mysql plugin connection is stale. If so, then return stale connection exception which triggers a retry after 
    establishing a new connection.
2. Refactor execute method code to remove code duplication.
3. Add a new test case to check if stale connection gets detected.
 2020-12-08 21:03:31 +05:30
Shrikant Sharat Kandula
4d24c8614f
Set random icons and colors for apps that are missing them (#2083) 2020-12-08 15:41:40 +05:30
Pawan Kumar
f8fd19d026
fix alignment of api editor response view (#2002) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-08 14:54:36 +05:30
Pawan Kumar
c67ada9a24
Fix/updating datasources does not update sidebar (#2018) 
* add check for datasources in memo equality check

* add test cases

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-08 14:54:02 +05:30
vicky-primathon
19d6ad695e
Table column max width limit removed (#2077) 2020-12-08 12:25:30 +05:30
Nikhil Nandagopal
0c1d914c38
Merge pull request #2064 from appsmithorg/fix/sentry-errors 
[Fix] reduced depth of information shared via sentry to prevent 413 errors
 2020-12-07 20:01:25 +05:30
Nikhil Nandagopal
03053d40c3 reduced depth of information shared to allow error sharing 2020-12-07 19:54:51 +05:30
Arpit Mohan
9d7a9d4aaf
Modifying the text for the roles in the share modal (#2045) 2020-12-07 16:16:43 +05:30
Pawan Kumar
e4b28172a7
add ellipsis in button (#2031) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-07 12:48:53 +05:30
devrk96
6cd44a5b84
Fix: Application name update checks (#1710) 2020-12-07 12:22:49 +05:30
devrk96
b7d77e15f1
Feature: New app icons and color palette (#2026) 2020-12-07 12:21:13 +05:30
Piyush Mishra
9ec030e101
null check for errors forEach(#2030) 2020-12-07 11:15:14 +05:30
Trisha Anand
b8b24604a6
[Bug] Update of an action leads to userSetOnLoad getting reset. (#2023) 
* Update of an action leads to userSetOnLoad getting reset.

* Added test case to assert the same.
 2020-12-04 13:07:34 +05:30
Sumit Kumar
b6abb8b067
Encode request body in Rest API plugin (#1988) 
1. Encode request body in REST API plugin when content header for URL encode is set.
2. Add a test case to test the encoding function.
3. Add a test case to check non-encoding (raw) function.
 2020-12-04 11:39:15 +05:30
Shrikant Sharat Kandula
4a57a739b6
Render templates directly without Mustache (#2010) 
* Render templates directly without Mustache

* Remove an unused variable
 2020-12-03 14:38:31 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985) 
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Shrikant Sharat Kandula
9bbbf37ae0
Fix #1597: Add a signed issuer token to proxied requests, if configured (#1953) 2020-12-02 18:20:57 +05:30
Sumit Kumar
d347448b24
Propagte mysql test datasource failure to UI. (#2001) 
1. Propagte mysql test datasource failure exception message to UI.
2. Change build TC to reflect the same.
 2020-12-02 17:53:38 +05:30
Arpit Mohan
a900b48712
Improving the text we see in the API and query settings pages (#1997) 2020-12-02 16:27:57 +05:30
vicky-primathon
6c19af7c24
Fix: Columns flicker when columns are resized or reordered (#1940) 
* Fixed flickering issue on column reorder and resize

* Disable sort when resizing column to stop flicker issue
 2020-12-02 16:14:56 +05:30
Pawan Kumar
066e20d0a2
Fix: Remove Fusioncharts Watermark (#1978) 
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-02 16:12:51 +05:30
akash-codemonk
afa81d9eaf
Datasource form bug fixes (#1986) 
* Datasource form fixes #1967 and fixes #1966
* Add tests for scenarios in #1967 and #1966
 2020-12-02 16:06:35 +05:30
Piyush Mishra
1eddc0c7d1
Faster recompile with cached eslint (#1987) 2020-12-02 11:57:56 +05:30
imgbot[bot]
4fa2fd4ba6
[ImgBot] Optimize images (#1993) 
*Total -- 307.73kb -> 177.70kb (42.25%)

/deploy/heroku/images/app-settings.png -- 215.56kb -> 118.43kb (45.06%)
/deploy/heroku/images/finish.png -- 33.21kb -> 19.53kb (41.19%)
/deploy/heroku/images/add-domain-form.png -- 29.12kb -> 18.04kb (38.06%)
/deploy/heroku/images/add-domain-button.png -- 29.37kb -> 21.23kb (27.71%)
/app/client/src/assets/icons/ads/upload.svg -- 0.47kb -> 0.47kb (0.62%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-12-02 11:50:10 +05:30
Sumit Kumar
b3c3102c72
Add tests for mysql plugin to test all regularly used data types in mysql. (#1994) 2020-12-02 11:49:41 +05:30
satbir121
8afa900044
Filepicker component and logo upload for org (#250) 2020-12-02 03:31:27 +05:30
devrk96
5d820c7203
Fix: Organization rename and toast issues (#1954) 
* Toast message removed when renaming an organization
 2020-12-02 03:30:29 +05:30
Hetu Nandu
29d0c49962
Wait for eval before executing the next evaluation (#1959) 2020-12-01 16:09:55 +05:30
Pawan Kumar
43f821fddc
Fix: test cases for datepicker (#1977) 
* clear cache values on delete

* added test cases

* add reload in test case

* fix test cases for datepicker spec

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-01 12:10:31 +05:30
Pawan Kumar
1aea90c404
Fix: Persist of default values even after delete of widget (#1929) 
* clear cache values on delete

* added test cases

* add reload in test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-01 10:56:35 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Sumit Kumar
883fa44896
Make sql plugin use R2DBC driver instead of JDBC driver (#1936) 
1. Add R2BC driver and remove JDBC driver usage in mysql plugin to make the plugin reactive.
2. Update dependencies in POM file.
3. Update mysql plugin to return result based on the type of sql query i.e select vs other queries. In case the queries are chained, then the last query is used for deciding the type.
4. Added a new TC for testing datasource and removed a non functional TC.
 2020-11-28 18:04:56 +05:30
Hetu Nandu
f248304720
Using --no-cache option for jest tests 2020-11-28 10:37:10 +05:30
Piyush Mishra
b199c539be
Fix setup for local linux server (#1948) 2020-11-27 14:49:09 +05:30
Nidhi
6c974408bd
Added IntelliJ run configuration for an easier getting started experience for contributors (#1944) 
* Added run configuration for IntelliJ

* Added instructions for run config
 2020-11-27 14:31:09 +05:30
Abhinav Jha
55ef8a0084
Loop sagas to respawn when they crash (#1880) 
* Added Sentry logging

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-11-27 14:21:08 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865) 
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-27 14:18:38 +05:30
akash-codemonk
49026d9b3c
Sava api with datasource without having to click on save datasource (#1930) 2020-11-27 11:06:16 +05:30
Nikhil Nandagopal
9c29b83d07
Fixed Action selector function arg splitting regex to include arrays and objects (#1893) 
- Also added navigateTo params field
 2020-11-27 10:30:53 +05:30
imgbot[bot]
f073698fcc
[ImgBot] Optimize images (#1928) 
*Total -- 316.18kb -> 175.10kb (44.62%)

/deploy/aws_ami/images/system-log.png -- 136.77kb -> 73.60kb (46.19%)
/deploy/aws_ami/images/select-system-log.png -- 178.91kb -> 101.01kb (43.54%)
/app/client/src/assets/icons/ads/warning.svg -- 0.49kb -> 0.49kb (0.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-26 18:43:05 +05:30
Trisha Anand
2062c60ca3
Moved all the scheduling of the plugin executions to bounded elastic instead of elastic. (#1931) 2020-11-26 17:50:43 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884) 
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-26 16:51:23 +05:30
NandanAnantharamu
a64069b9f2
Added test for Tab and input widget binding (#1912) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-26 15:15:03 +05:30
NandanAnantharamu
7a73763aea
Feature/pageload usecase (#1750) 
* Usecase for pageload Api and input widget

* Updated test name

* updated tests

* Updated assertion

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-25 21:40:31 +05:30
Piyush Mishra
d9e7baea45
Fix infinite loop crash on widget drag (#1916) 2020-11-25 21:32:54 +05:30
devrk96
461b662c7a
Feature: Rename organization in homepage (#1201) 2020-11-25 17:54:14 +05:30
Nikhil Nandagopal
8109b3b001
Merge pull request #1836 from vvkpd/show-number-of-records 
show number of the records
 2020-11-25 12:31:46 +05:30
Nikhil Nandagopal
25e9516315
Update TableHeader.tsx 2020-11-25 12:06:27 +05:30
Nikhil Nandagopal
610ea6c1f7 minor fix for user ids being sent 2020-11-24 21:10:50 +05:30
Vivek Pandey
1bdefc0094 removes show label from header 2020-11-24 20:05:34 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab 
Fix selectedTab binding issue
 2020-11-24 19:06:10 +05:30
Piyush Mishra
dbf947a1a6
Hotfix for mac start-https.sh script (#1891) 2020-11-24 18:58:05 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
e7c465eaae
Add support for WSL local dev (#1756) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2020-11-24 16:45:33 +05:30
Piyush Mishra
7376ada1b1
[Documentation] Use env variables in Cypress tests (#1887) 2020-11-24 16:44:38 +05:30
Piyush Mishra
03f97c0323
Fix: Maps widget crash on wrong initial location datatype (#1854) 2020-11-24 14:13:45 +05:30
devrk96
fee1a4518f
Feature: Toast component (#476) 2020-11-24 12:31:37 +05:30
Arpit Mohan
36af9d5c5e Correcting the placeholder in firestore form.json 2020-11-24 11:00:27 +05:30
Nikhil Nandagopal
6da629d441 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-23 18:48:00 +05:30
Nikhil Nandagopal
9cc5a20190 added source to user object 2020-11-23 18:47:12 +05:30
Shrikant Sharat Kandula
74cd362057
Firestore Integration (#1799) 
* Adding the skeleton for Firestore integration

* Adding the datasource & query editor forms

Also adding the database changelog for the firestore plugin

Commenting out the firestore.close() connection because that causes issues with multiple Firestore tenants running in the same JVM.

* Adding the code for fetching the structure of collections from Firestore

* Use single document path field for Firestore

* Fix potential NPE when datasource destroy timeouts

* Work in progress on collection level ops for Firestore

* Get documents in a collection now works

* Add collection level querying support

* Mild refactoring

* Fix NPE when some fields are missing

* Hide clientJSON as a password field for Firestore

* Make collection level querying reactive

* Make reactive

* Validate before connecting

* Add tests for all supported methods in Firestore

* Fix forms for Firestore with hidden fields

* Hide limit and order by fields when not needed

* Restore log entry deleted by mistake

* Use S3 URL for Firestore/Firebase logo

* Add comments detailing why some code is commented

* Make parsing JSON reactive and fix subscribe calls

* Fix reactive scheduler

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-23 18:42:33 +05:30
Trisha Anand
c07264f1c1
Making Redis plugin blocking statements run on elastic thread pool (#1850) 2020-11-23 17:03:04 +05:30
Trisha Anand
772884e1a3
Making dynamo db's blocking commands run on elastic thread pool. (#1853) 2020-11-23 17:02:41 +05:30
Trisha Anand
d8cba1bf8c
Making MySql blocking commands run on elastic thread pool (#1862) 2020-11-23 17:02:18 +05:30
Trisha Anand
0bb99dd087
Elastic search plugin's blocking calls moved to elastic scheduler thread (#1855) 2020-11-23 17:01:34 +05:30
Pawan Kumar
ad52842e1c
Fix/entity name coincide issue 1396 (#1781) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* add check if name is conflicting with internal fn

* use already existing selector

* add conflicting names checks on api/queries/widget names

* add test cases for invalid widget/api/query names

* refactor

* change array to map

* remove getDataTreeKeys selector

* refactor

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-23 14:57:00 +05:30
Piyush Mishra
5efcb47486
Improve test automation docs (#1838) 
* improve docs with link to client setup and change cypress.env.json instead of editing cypress.json file

* fix link to client setup

* improve ordering

* rearrange

* fix quotes

* remove unlinkable link

* fake push
 2020-11-23 13:58:26 +05:30
akash-codemonk
294348e1f9
Query pane plugin form should be initializable (#1802) 2020-11-23 11:58:15 +05:30
Trisha Anand
242afd5753
Making MS-SQL plugin blocking statements run on elastic thread pool (#1827) 
* MS-SQL Plugin now creates connection and executes statements over elastic thread pool.

* Added a test to ensure that throwables are clean.
 2020-11-23 11:28:01 +05:30
Trisha Anand
dc7a375543
Making postgres plugin blocking statements run on elastic threadpool. (#1821) 
* Making postgres plugin blocking statements run on elastic threadpool.

* Moved the blocking calls to check for the connection validity, etc. also inside the Mono.fromCallable
 2020-11-23 11:27:52 +05:30
Trisha Anand
c2d1ac973c
Adding thread name to the context of logs to allow for the thread names to be printed for each log. (#1824) 2020-11-23 10:45:15 +05:30
Vivek Pandey
0a35ecdcaf show number of the records 2020-11-22 20:16:27 +05:30
Nikhil Nandagopal
6487508e0c
Merge pull request #1823 from appsmithorg/fix/rte-linebreaks 
Fix RTE line break issue
 2020-11-20 17:27:51 +05:30
Abhinav Jha
3064a1865a Fix RTE line break issue 
Fix issue where empty defaultValue wasn't getting updated
 2020-11-20 17:08:51 +05:30
Hetu Nandu
ff541c3efa
Patch object order issue (#1819) 2020-11-20 15:00:50 +05:30
Hetu Nandu
9ef9d184ff
Pass execution params to action callback (#1814) 2020-11-20 13:57:46 +05:30
Trisha Anand
882df291d7
[Bug Fix] Indices not working for fetching actions during update layout (#1813) 
Instead of using compound index, using single indices to ensure that both fetch actions by app id (during load of actions in edit/view mode) and fetch actions by page id (during update layout) are indexed queries.
 2020-11-20 13:30:17 +05:30
vicky-primathon
3b85cc8222
Added defaultSelectedRow property in table widget so that users can configure default selected row(s) (#1684) 
* Added defaultSelectedRow property in table widget so that users can configure default selected rows

* Cypress test cases added to test default row selection in table widget

* Fix defualtSelectedRow property's evaluation type

* Fix default select row type

* Set default selected row when resetting user selected rows

* Use defaultSelectedRow when no user selected row in table
 2020-11-20 13:13:39 +05:30
devrk96
0da8c84ae1
Fix: App card boundaries UI (#1798) 
* Hover ui fixed on all sides of app card
 2020-11-20 12:45:48 +05:30
devrk96
879258b74f
Theme flag stored in localStorage cleared when logging out (#1796) 2020-11-20 12:45:04 +05:30
Trisha Anand
63fe27fae1
[Bug Fix] : Clone Application creates corrupted clone when interrupted. (#1800) 
* Doing a deep copy during clone application instead of updating the original application which may have been causing a concurrency bug.

* Ensuring that once the clone application flow is triggered, the flow completes eventually even if the client cancels the request before completion.

* Cloned application would not be public.

* Added parametrized Application constructor

* Removed lombok all args constructor

* Optimized import

* Incorporated review comments :
1. Updated the constructor for creating the application
2. Added a test case to assert that if during cloning of an application the flow gets cancelled, the cloning would still complete and ensure that the application created is sane.
 2020-11-20 10:55:59 +05:30
Sumit Kumar
b03e815952
Change Sentry log 'environment' tag value. (#1789) 
* Change Sentry log 'environment' tag value.

1. Change Sentry log 'environment' tag value to 'Properties' from 'properties'.
 2020-11-19 17:29:48 +05:30
akash-codemonk
26e793a86a
Show api datasource list on focus (#1668) 2020-11-19 17:11:06 +05:30
akash-codemonk
2ded99f9ac
Fix store as datasource (#1772) 2020-11-19 17:00:22 +05:30
Pawan Kumar
5f1b398d34
Fix/truncated page name in appviewer issue 1597 (#1770) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

* fix ref issue + test cases

* fix test case

* update test case

* fix test case

* fix merge conflict typo

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-19 16:08:09 +05:30
akash-codemonk
acb3c42d66
Highlight matching brackets in editor (#1613) 2020-11-19 13:24:21 +05:30
akash-codemonk
6dc7e42ce9
Remove api datasource from add datasource page (#1639) 
* Show only db datasources in the create datasource page

* Remove invalid test
 2020-11-19 13:22:44 +05:30
akash-codemonk
32482d4826
Fix datasource name getting focused after save while creating new datasource (#1793) 2020-11-19 13:04:19 +05:30
akash-codemonk
732dc632cd
Show callout only for db datasources (#1792) 2020-11-19 10:49:36 +05:30
akash-codemonk
c3c7b9b7d7
Add new property to conditionally hide form fields in datasource and editor (#1682) 
* Create a form control component which handles the hidden logic

* Add tests
 2020-11-19 09:02:58 +05:30
Arpit Mohan
9772d64c5b
Disable instance ping check when the disableTelemetry flag is set (#1776) 
Also adding the APPSMITH_SEGMENT_CE_KEY as a build arg to the server Dockerfile. This will be used to set the environment variable in the Docker image itself.
 2020-11-19 08:54:03 +05:30
Piyush Mishra
5b684b857e
Add placeholders on curl import and API create form (#1738) 
* adds placeholder on curl import form

* add placeholder to api creation form as well
 2020-11-19 05:48:54 +05:30
Abhinav Jha
93ac625135 Hide appviewer header if queryparams has embed 2020-11-18 18:55:25 +05:30
Vivek Pandey
de435ed009
Show number of records instead of pages in the table widget (#1734) 2020-11-18 18:20:04 +05:30
Hetu Nandu
2538444e20
Remove old derived value bindings from test DSLs (#1757) 2020-11-18 18:18:07 +05:30
Sumit Kumar
2c6d1bb361
Fix mongodb datasource test. (#1783) 
1. Fix mongodb datasource cypress test failure.
2. Against certain mongodb instances, we expect to receive an exception of type "unauthorized" when testing datasource. Earlier, this case was caught and whitelisted until the recent change to replace mongodb infra with reactive mongodb infra.
 2020-11-18 16:55:39 +05:30
Nidhi
941be8c58d
Fixed check for incorrect dynamic bindings (#1775) 
* Fixed check for incorrect dynamic bindings
 2020-11-18 14:25:55 +05:30
Shrikant Sharat Kandula
f36adeb6b5
Fix #1766: cURL parser eats backslashes in single-quotes (#1768) 2020-11-18 11:20:23 +05:30
Shrikant Sharat Kandula
2ca15ba57d
Fix #1758: columns duplicated in Postgres structure (#1767) 2020-11-18 11:19:55 +05:30
Sumit Kumar
2c2aa06e32
Add support for reactive streams with mongodb. (#1720) 
Add support for reactive streams with mongodb. (fixes 1480)

1. Replace mongodb driver with reactive mongodb driver. Change APIs accordingly.
2. Use webflux + reactor framework to execute mongodb queries in event loop model.
3. Add test to test MongoPluginExecutor class' method "testDatasource".
 2020-11-18 10:58:50 +05:30
Trisha Anand
fc3197b78f
Email sending is now non-blocking. The blocking code for email sending is triggered and then immediately returned. (#1762) 2020-11-18 00:31:39 +05:30
Arpit Mohan
c3a44651f2
Adding null check for dynamic binding path list (#1752) 
* Adding null check for dynamic binding path list.

* Increased timeout duration for failing test

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
 2020-11-17 15:38:48 +05:30
Trisha Anand
6ac04d8a9e
Added SLA bucket for metric evaluation for 1 second (#1740) 2020-11-17 12:47:49 +05:30
Pawan Kumar
6e4c6824ef
Fix/truncated page name in appviewer issue 1597 (#1742) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-17 12:03:10 +05:30
Nidhi
9de085f264
Switched to using dynamicBindingPathList for generic scan, supports DB queries and nested structures 
* Switched to using dynamicBindingPathList for generic scan
 2020-11-17 11:26:08 +05:30
Piyush Mishra
49c24c7654
Force redirect https on development nginx server (#1733) 2020-11-16 19:01:33 +05:30
Trisha Anand
a722b08002
Adding index for unpublishedAction.pageId to bring down the number of documents fetched in mongo db query during update layouts' fetching actions on page load. (#1739) 2020-11-16 18:59:04 +05:30
Arpit Mohan
955f80925f
Fixing the telemetry on self-hosted instances (#1714) 2020-11-12 19:01:40 +05:30
Abhinav Jha
0f4269891f
Fix issue where creating a new application twice does not work (#1713) 2020-11-12 18:58:12 +05:30
akash-codemonk
86a419d42a
Add the error style to bindings (#1711) 2020-11-12 18:53:49 +05:30
Pawan Kumar
fc29a31cd4
Fix/show two whitelist ips issue 1632 (#1705) 
* add second whitelist ip for create datasource page

* revert the cloudhosting check on help button

* update name of util function

* remove unused key

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-12 17:35:19 +05:30
NandanAnantharamu
da9ef2cb2d
Added a check for zoom feature test (#1703) 
* Added a check for zoom feature test

* Added another click for zoom-in check

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-12 17:34:44 +05:30
Pawan Kumar
7bc4697545
Fix/help modal fab button toggle issue 1681 (#1692) 
* change icon to close on opening help modal

* fix help modal icon bug

* add test cases for the fab buttont toggle issue

* fix padding + closing lag issue of help modal

* pass isOpen true all the time

* fix help modal button hover issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-12 16:56:54 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625) 
Implements #1575
 2020-11-12 16:53:32 +05:30
akash-codemonk
1510c21a7d
Add a back button to the datasources page (#1702) 2020-11-12 15:36:13 +05:30
Rohit Kumawat
175d43aad3 limit added for showing user icons in an organization 2020-11-12 15:01:51 +05:30
Arpit Mohan
073555ee8a
Moving all telemetry check to the configs class (#1700) 
Now we enable/disable all analytics in a central location in the configs class. This ensures that each analytics function can simply check it's own value and not worry about checking for the disableTelemetry flag
 2020-11-12 11:56:09 +05:30
Nikhil Nandagopal
e411df0a64
Added check so that existing installs don't get telemetry (#1698) 
* Adding the segment key to the tagged release
* Also opting out of telemetry data in CI builds

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-11 23:54:19 +05:30
Arpit Mohan
cb4b3b2753 Dummy commit to trigger CI build 2020-11-11 19:43:25 +05:30
Hetu Nandu
a51082fb54 Merge branch 'master' into release 2020-11-11 18:51:03 +05:30
devrk96
73869eee69
Feature: Show org user icons on homepage (#1685) 
* Displaying org user icons feature is implemented

* using username if name not found in user details

* Share user icon cypress test implemented
 2020-11-11 18:42:05 +05:30
Abhinav Jha
a4f652ce70
Add client-max-body-size directive to nginx https proxy (#1695) 2020-11-11 18:23:48 +05:30
Nikhil Nandagopal
5a903a6976 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-11 18:07:57 +05:30
Nikhil Nandagopal
a1d6b0232b enabled perf for sentry 2020-11-11 18:07:40 +05:30
akash-codemonk
aefafd33dc
Fix switching datasource in the query pane (#1636) 2020-11-11 17:59:26 +05:30
Hetu Nandu
b1c8008c3d Add null check for evaluated value in Chart Data Control (#1675) 
Fixes: #1672, #1666
 2020-11-11 17:28:26 +05:30
Hetu Nandu
3a84af82ed
Fix critical issues (#1686) 
Fixes #1683
Fix for dropdowns with option not being an object crashes dropdown and stops eval
Fixes #1656 #1657
Fix issue where updateWidgetProperty would get called without a widgetId
 2020-11-11 17:02:14 +05:30
Pawan Kumar
392de2b840
Fix/on date selected call issue 987 (#1691) 
* fix onSelectedDate call on deselection of date

* add test cases for deselecting the datepicker widget issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-11 16:59:45 +05:30
Arpit Mohan
166ee73c9f
Moving the intercom initialization to the body in index.html (#1690) 
This is to allow us to enable/disable Intercom chat based on the APPSMITH_INTERCOM_APP_ID and APPSMITH_CLOUD_HOSTED environment variables.
 2020-11-11 15:49:21 +05:30
NandanAnantharamu
d5ce1dfa52
Added tests for dependencies (#1679) 
* Added tests for dependencies

* updated review comments

* moved files to binding folder

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-11 15:44:01 +05:30
Nikhil Nandagopal
3c37645d12
Merge pull request #1674 from appsmithorg/fix/switch-content-type 
Fix incorrect bodyFormData values being sent
 2020-11-10 19:20:11 +05:30
Pawan Kumar
dace2a6a55
Merge pull request #1671 from appsmithorg/pawan/issue-720 
Fix long app names not visible issue
 2020-11-10 17:26:41 +05:30
Pawan Kumar
42fe5f4543 update test cases for the issue + typo fix 2020-11-10 16:59:34 +05:30
Akash N
06d330ef3a actionConfiguration.body shouldn't be reset 2020-11-10 16:42:31 +05:30
Pawan Kumar
8b7e7d2993 incorporate code reviews feedbacks 2020-11-10 15:58:21 +05:30
Akash N
6c0d0e228c Add test 2020-11-10 15:11:05 +05:30
Pawan Kumar
426bb0b8df clear search input in test cases 2020-11-10 15:08:47 +05:30
Akash N
3fbcf667b6 Do not reset the bodyFormData value 2020-11-10 14:58:14 +05:30
Nikhil Nandagopal
5e17450e2f
added check for no matches (#1673) 2020-11-10 14:52:35 +05:30
Pawan Kumar
3a708497dd add a max-width on tooltip component 2020-11-10 14:16:57 +05:30
Hetu Nandu
a52c5df987 Fix form widget eval loops for arrays 2020-11-10 13:23:18 +05:30
Sumit Kumar
2dc2615311
Replace Rollbar with Sentry (#1606) 
* Replace Rollbar with Sentry

1. Log exceptions using Sentry instead of Rollbar.
2. Remove all Rollbar infra.
 2020-11-10 09:59:10 +05:30
Pawan Kumar
ec49c358c4 Fix app name too long issue 2020-11-09 17:00:34 +05:30
Hetu Nandu
977405a720
Create app crash boundary (#1629) 2020-11-09 14:53:20 +05:30
Hetu Nandu
9f0363812e
Default page id fixes (#1628) 
* Fix App invite form not getting the correct page id

* localise confusing getDefaultPageId function

* Remove old fetch application workflow action
 2020-11-09 14:22:44 +05:30
Nidhi
1741e61ba0
Added user roles list to application fetcher (#1624) 
* Added user roles list to application fetcher

* Fixed blanket import
 2020-11-09 11:54:30 +05:30
Nidhi
62e4e28c8e
Fixed upload logo payload limit and added delete logo API (#1574) 
Also changed name of default organization to xyz's apps
 2020-11-09 07:52:08 +05:30
vicky-primathon
fd12e907af
Map not resetting to location selected fix. Location map to search location. (#1619) 2020-11-06 20:39:35 +05:30
Abhinav Jha
b549978fdf
Fix issue where clicking on widget add button redirects to the homepage (#1620) 2020-11-06 20:38:11 +05:30
vicky-primathon
e82b0c42e3
Fix distortion due to table scrollbar (#1608) 2020-11-06 16:48:04 +05:30
vicky-primathon
54a6ca0850
Fix/table widget pagination changes (#1298) 2020-11-06 16:45:47 +05:30
Nikhil Nandagopal
6121e6938e
Merge pull request #1576 from appsmithorg/fix/button-ui-invite-modal 
Fix: Invite modal cancel button UI
 2020-11-06 15:04:10 +05:30
Hetu Nandu
2820413b7d
Fix bad fix for show alert issue #1583 (#1614) 2020-11-06 14:57:10 +05:30
Hetu Nandu
f0862652c3 Fix for btoa / atob functions 2020-11-06 14:50:07 +05:30
Rohit Kumawat
f321b6e759 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/button-ui-invite-modal 2020-11-06 14:31:50 +05:30
Nikhil Nandagopal
72334ca8ad
Merge pull request #1612 from appsmithorg/fix/atob-btoa-not-working 
Remove extra dependency and use browser atob and btoa
 2020-11-06 14:28:21 +05:30
Hetu Nandu
f99291ea2d Revert "Fix still crashing for #1583" 
This reverts commit 2c88f11ed4.
 2020-11-06 14:17:26 +05:30
Nikhil Nandagopal
7816f2c1f7
Merge pull request #1592 from appsmithorg/feat/sticky-header 
Show query form headers while scrolling
 2020-11-06 14:09:53 +05:30
Hetu Nandu
2c88f11ed4 Fix still crashing for #1583 2020-11-06 14:08:22 +05:30
Hetu Nandu
9cc94777f2 Remove extra dependency and use browser atob and btoa 2020-11-06 14:04:10 +05:30
Nikhil Nandagopal
5e84dcaa95
Merge pull request #1557 from appsmithorg/feature/telemetry 
Adding telemetry for community edition
 2020-11-06 13:57:18 +05:30
Arpit Mohan
17ffcd946e Increase the timeout while waiting for containers to start 2020-11-06 13:33:35 +05:30
Rohit Kumawat
64d053de6e variable name corrected 2020-11-06 13:23:38 +05:30
Nikhil Nandagopal
2a8e756149 added caching for analytics hash 2020-11-06 11:57:36 +05:30
vicky-primathon.in
717082b8bc Fix distortion due to table scrollbar 2020-11-06 10:51:29 +05:30
Rohit Kumawat
d85351526d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/button-ui-invite-modal 2020-11-06 08:47:59 +05:30
Nikhil Nandagopal
daeb9ed4be Merge branch 'feature/telemetry' of github.com:appsmithorg/appsmith into feature/telemetry 2020-11-05 22:21:35 +05:30
Nikhil Nandagopal
430dfc00ea updated analytics checks 2020-11-05 22:21:22 +05:30
Arpit Mohan
a944680d50 Adding the disable telemetry config in the env example 2020-11-05 22:01:58 +05:30
Arpit Mohan
12f3a4182c Fixing the tests and adding the segment key in the yarn build 
This key will be burned into the Docker image itself.

Also adding the disable telemetry link to the nginx_app template during self-hosted deploys.
 2020-11-05 20:32:25 +05:30
akash-codemonk
86cac0fae3
Add test for showBindingPrompt function (#1566) 2020-11-05 19:15:40 +05:30
Nikhil Nandagopal
7ed8d3db9b fixed conf 2020-11-05 18:10:04 +05:30
Hetu Nandu
c1ff711a45 Fix build errors 2020-11-05 17:58:39 +05:30
Nikhil Nandagopal
08b755bdcb
Merge pull request #1591 from appsmithorg/fix/args 
Fix for args not splitting correctly with empty values
 2020-11-05 17:52:35 +05:30
Hetu Nandu
20f357ae35
Add checks for wrong alert types of Toast messages (#1588) 
Fixes #1583
 2020-11-05 17:19:37 +05:30
Nikhil Nandagopal
5e93815276 added segment CE and telemetry flags 2020-11-05 16:58:17 +05:30
Nikhil Nandagopal
2c111edbba fix for tests 2020-11-05 16:56:00 +05:30
imgbot[bot]
96fcf65f04
[ImgBot] Optimize images (#1558) 
/app/client/src/assets/images/timeout-image.png -- 109.72kb -> 86.13kb (21.51%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-05 16:46:54 +05:30
Akash N
01303e6716 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feat/sticky-header 2020-11-05 16:17:59 +05:30
Nikhil Nandagopal
6d6ef35b7c
Merge pull request #1518 from sumanthyedoti/fix/tabs-widget-corners 
fix/tabs widget corners
 2020-11-05 15:51:41 +05:30
Nikhil Nandagopal
a110a23574
Merge pull request #1169 from daniel-shuy/fix/download-file-type-dropdown-optional 
Allow Download File Type dropdown to be deselected
 2020-11-05 15:47:18 +05:30
Nikhil Nandagopal
39331d95b2 fix for args not splitting correctly with empty values 2020-11-05 15:46:38 +05:30
Akash N
abd3bf248a Add the output the query to the content of the query tab to have a sticky header like UI 2020-11-05 14:38:52 +05:30
Trisha Anand
24582a2e58
Adding server side performance tooling using spring metrics. (#1562) 
* Experimenting with spring metrics, prometheus

* Added prometheus config in application.properties.

* Added a few more configurations for spring metrics to improve performance tooling.

* Added basic authentication to allow prometheus to scrape our monitoring data in an authenticated fashion.

* Only exposing prometheus end point at this junction instead of other metric endpoints as well.

* Fixed test case which failed because of actuator instantiating bean.
 2020-11-05 14:33:40 +05:30
Rohit Kumawat
5eff7e7970 cancel button text color fixed 2020-11-05 12:34:44 +05:30
Nikhil Nandagopal
274e2bc5cd updated telemetry check 2020-11-05 11:41:29 +05:30
Nikhil Nandagopal
409c4ad9b7
Merge pull request #1571 from appsmithorg/fix/org-setting-field-validation 
Fix: Field Issues in Organization's General Tab
 2020-11-05 11:31:33 +05:30
Nikhil Nandagopal
6206da646a
max height is fixed for users list in invite modal (#1572) 2020-11-05 11:29:39 +05:30
devrk96
06f106090b
underline css fixed (#1570) 2020-11-05 11:27:27 +05:30
Arpit Mohan
b3eabf68ea Moving the segment CE key to a build time variable instead of hard coding it 2020-11-05 10:54:30 +05:30
Sumanth Yedoti
851f94842e fix: tabs height 2020-11-05 10:17:55 +05:30
Arpit Mohan
994d57422b Fixing the jest test in AnalyticsUtil 2020-11-05 08:01:01 +05:30
Sumanth Yedoti
db4e09bb1e resolve merge conflict 2020-11-04 23:09:05 +05:30
Sumanth Yedoti
6d55b37b0d fix: add shadow to TabsWidget 2020-11-04 23:03:32 +05:30
Sumanth Yedoti
cac499c9ad fix(Widgets): add rounded corners and improve overall style for TabsWidget 2020-11-04 22:53:08 +05:30
Yedoti Sumanth
f4bed59ba0 style: remove extra red border to Tabs Widget 2020-11-04 22:52:22 +05:30
Yedoti Sumanth
91eec61608 fix(EnitityExplorer): remove scrollbar when content does not overflow 2020-11-04 22:52:22 +05:30
Yedoti Sumanth
97e4168523 fix(Widget): add rounded corners to Tabs Widget 2020-11-04 22:52:21 +05:30
Sumanth Yedoti
60bbc963dc fix(Widgets): add shadow to TabsWidget 2020-11-04 22:51:59 +05:30
Sumanth Yedoti
41a2a53bf1 fix(Widgets): add rounded corners and improve overall style for TabsWidget 2020-11-04 22:51:58 +05:30
Sumanth Yedoti
a3d7cdb769 style: remove extra red border to Tabs Widget 2020-11-04 22:51:57 +05:30
Yedoti Sumanth
41411bddcb fix(Widget): add rounded corners to Tabs Widget 2020-11-04 22:51:57 +05:30
Rohit Kumawat
e40db8b92c max height is fixed for users list in invite modal 2020-11-04 22:36:29 +05:30
Rohit Kumawat
ea87b38077 organization label fixed 2020-11-04 21:36:44 +05:30
Rohit Kumawat
560fd9155b field validation fixed in email and white space removed 2020-11-04 21:36:06 +05:30
NandanAnantharamu
ec50857d15 commented AddWidget_spec (#1559) 2020-11-04 20:23:23 +05:30
NandanAnantharamu
37dc0ba4e4 Updated a binding and commented out failing test (#1546) 2020-11-04 20:23:13 +05:30
Arpit Mohan
0b5250529a Moving the getAppsmithConfig function to static function in index.ts 2020-11-04 20:03:17 +05:30
Abhinav Jha
dc7f055612 Handle null regex parts in input widget regex function (#1569) 2020-11-04 19:51:40 +05:30
Abhinav Jha
e14f23c31d
Handle null regex parts in input widget regex function (#1569) 2020-11-04 19:49:46 +05:30
Arpit Mohan
ce24f37d43 Merge branch 'release' into feature/telemetry 2020-11-04 19:08:05 +05:30
Abhinav Jha
1747390183
Fix: All canvas widgets should have no container styling applied (#1564) 2020-11-04 18:58:21 +05:30
Arpit Mohan
946b3ba25f Merge branch 'release' into feature/telemetry 2020-11-04 18:02:25 +05:30
Daniel Shuy
2c5e74313c Add default empty selection for FILE_TYPE_OPTIONS 2020-11-04 20:23:56 +08:00
Arpit Mohan
1413203251 Adding the check for disabling telemetry if the environment variable is set 2020-11-04 17:50:14 +05:30
NandanAnantharamu
af5ec1363e
commented AddWidget_spec (#1559) 2020-11-04 17:45:41 +05:30
Sumit Kumar
6db7101662
Report selective errors to rollbar. (#1516) 
* Report selective errors to rollbar.

1. Assign an action attribute to each AppsmithError enum item. Take action based on the action attribute.

* Fixing the condition for organization name being empty

* Report selective errors to rollbar.

1. Assign an action attribute to each AppsmithError enum item. Take action based on the action attribute.

Co-authored-by: Sumit Kumar <sumitsum@Sumits-MacBook-Pro.local>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-04 17:32:43 +05:30
Hetu Nandu
20ef86f118
Improve app initialisation for timeouts (#1412) 
Fixes: #1510 

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2020-11-04 17:10:59 +05:30
akash-codemonk
1eeb0af01e Fixed binding prompt crash 2020-11-04 17:08:18 +05:30
akash-codemonk
8ae77f7764
Fix prompt showing up always (#1556) 2020-11-04 16:37:10 +05:30
Nikhil Nandagopal
f05ac9a9c6 added sha256 hash to obfuscate analytics data 2020-11-04 16:23:15 +05:30
akash-codemonk
ba6aceb096
Fix includes is not a function error crash (#1555) 
* Make the value a string to avoid includes is not a function error

* If it is not a string show the prompt
 2020-11-04 15:27:11 +05:30
Nikhil Nandagopal
0f90b19dc0 added anonymization of user data for CE 2020-11-04 15:23:26 +05:30
NandanAnantharamu
ceb31edd76
Updated a binding and commented out failing test (#1546) 2020-11-04 13:06:32 +05:30
Nidhi
fc4fca8bf0
Added fallback email to new organization from user email (#1536) 2020-11-04 12:57:17 +05:30
Nidhi
c7efe55c9c
Fixed timeout error message, added new type of error for plugin timeout (#1519) 
* Fixed timeout error message, added new type of error for plugin timeouts

* Switched error code and added test for a secondary StaleConnectionException
 2020-11-04 12:56:52 +05:30
Arpit Mohan
dcc30b31d2 Correcting the assertion for table binding widget test 2020-11-04 10:26:08 +05:30
Arpit Mohan
ee5e1a81ff Reverting back the changes for local postgres 2020-11-04 08:40:35 +05:30
Arpit Mohan
e71412d3ab Moving postgres container to background 2020-11-04 00:45:02 +05:30
Arpit Mohan
4f094ea779 Moving the postgres container to Cypress test setup 2020-11-04 00:32:42 +05:30
Arpit Mohan
fba99c4728 Removing health check for postgres 2020-11-04 00:17:31 +05:30
Arpit Mohan
c93e72c3ec Adding postgres env variables 2020-11-04 00:05:30 +05:30
Arpit Mohan
8e839ab224 Correcting the mount volume in client.yml 2020-11-03 23:48:10 +05:30
Arpit Mohan
19131e14ab Using absolute path for volume mount in client.yml 2020-11-03 23:29:03 +05:30
Arpit Mohan
779801c763 Correcting the ports for postgres in client.yml 2020-11-03 23:18:45 +05:30
Arpit Mohan
0ea9c96a8f
Spinning up Postgresql container in client workflow CI (#1521) 2020-11-03 23:16:51 +05:30
Abhinav Jha
8b097775a3 Fix table crash issue when selectedRowIndices was reset (#1542) 2020-11-03 22:17:52 +05:30
Abhinav Jha
d5c7fcc1e4
Fix table crash issue when selectedRowIndices was reset (#1542) 2020-11-03 22:16:44 +05:30
Nikhil Nandagopal
8d2ccefab2 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-11-03 22:10:45 +05:30
Abhinav Jha
ada1e28f64 Fix styles to show table rows in query results (#1540) 2020-11-03 21:47:26 +05:30
Nikhil Nandagopal
a4443e0acb added a fix for null crashing a page in bindings 2020-11-03 21:47:18 +05:30
Nikhil Nandagopal
8a1be448e1 added a fix for null crashing a page in bindings 2020-11-03 21:17:16 +05:30
Abhinav Jha
0538c08bcd
Fix styles to show table rows in query results (#1540) 2020-11-03 21:05:55 +05:30
Abhinav Jha
543b7ec72d
Entity Explorer Render (#1354) 
* WIP: Performance improvements in entity explorer

* WIP: Achieve feature parity for entity explorer with release

* Update unit tests

* Add sentry profiling to current page entity properties component

* Fix page add/delete not showing up on entity explorer issue. Update memoization logic for pagegroup entity

* Deal with the ban-ts-ignore eslint issues

* Update unit tests

* Fix widget entity children visibility

* Fix tests and code

* Fix tests for scenarios where the collapsed entities are unmount, as this is a part of the performance optimization

* Filter undefined children when generating structureDSL

* Remove rule from eslintrc

Consolidate createPage test command

* Update CreatePage tests to remove redundant dsl updates

* Revert CreatePage test changes, as adding more checks within this command globally causes other tests to have issues.

* re-enable eslint rule, as without it CI tests fail

* Revert to ban-ts-comment

* Fix typescript ban-ts-ignore issue by upgrading react-scripts and fixing typescript issue across the application

* Typescript errors handled

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
 2020-11-03 18:35:40 +05:30
Nikhil Nandagopal
ef9a70b9e5 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-11-03 18:35:06 +05:30
Nikhil Nandagopal
25a6fe2e09
Fix: Tabs Widget (#1532) (#1535) 
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2020-11-03 18:33:26 +05:30
Abhinav Jha
120c2da507
Fix: Tabs Widget (#1532) 
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint
 2020-11-03 18:32:50 +05:30
Arpit Mohan
cce2c007fb Merge branch 'release' 2020-11-03 16:56:47 +05:30
Arpit Mohan
33b18a9336 Fixing merge conflicts 2020-11-03 16:50:23 +05:30
Hetu Nandu
4cba17ab82
Add post eval action support (#1529) 
Fixes #1504
 2020-11-03 15:46:11 +05:30
vicky-primathon
25e8d17108
Change to resolve conflicts with master branch (#1530) 2020-11-03 14:46:35 +05:30
Arpit Mohan
bd11fdef91 Merge branch 'release' 2020-11-03 14:28:18 +05:30
Trisha Anand
111922d49e Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 13:19:06 +05:30
Trisha Anand
936ddc4fa0
Added indexes on NewPage and NewAction. Also made changes to the sorting order of actions when read in view and edit mode. (#1527) 2020-11-03 13:15:51 +05:30
Automated Github Action
5df7127af6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 07:15:39 +00:00
Sumanth Yedoti
87a2effbc5
Fix/api URL field twitch (#1495) 
Fixes: #1248
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
 2020-11-03 12:21:02 +05:30
Automated Github Action
05c82e2498 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 06:10:23 +00:00
vicky-primathon
1c4adf84a1
Fix/multi select dropdown (#1295) 
* Cypress test locator fix

* Multi select dropdown values initialization fixed

* Reverted test case selector change

* Using lodash isEqual since values can be object
 2020-11-03 10:49:27 +05:30
Automated Github Action
c08fe7ece8 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 04:16:31 +00:00
akash-codemonk
9afcf87156
Show binding prompt when there is no binding in the editor (#1478) 2020-11-03 09:40:07 +05:30
Arpit Mohan
ac44da036c Dummy commit to trigger build 2020-11-03 08:32:08 +05:30
Arpit Mohan
71ede6622a Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-03 07:58:58 +05:30
Arpit Mohan
d087b8152d Fixing the condition for organization name being empty 2020-11-03 07:58:22 +05:30
Arpit Mohan
91fded3ddd Fixing merge conflicts 2020-11-03 07:40:53 +05:30
Dmitriy Danilov
26da9ce60b
fix(organization-service): add check that organization is not empty (#1120) 
Fixes ##774
 2020-11-02 20:35:12 +05:30
Sumanth Yedoti
a7ecfd0a6d
Fix(API): remove cursor in API HTTP methods field (#1512) 
Fixes: #1249 
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
 2020-11-02 20:33:46 +05:30
NandanAnantharamu
da8ab92803
Updated dsl file (#1496) 
* Updated dsl file

* fixed the shareApp tests
 2020-11-02 20:06:41 +05:30
NandanAnantharamu
eb6c8ee8f0
Added tests for button click navigation (#1467) 2020-11-02 20:06:16 +05:30
imgbot[bot]
f5924c6895
[ImgBot] Optimize images (#1513) 
*Total -- 1,942.96kb -> 1,638.83kb (15.65%)

/app/client/src/assets/icons/header/save-loading.gif -- 14.17kb -> 5.67kb (59.99%)
/app/client/src/assets/images/Postman.png -- 10.34kb -> 4.63kb (55.24%)
/app/client/src/assets/images/Google.png -- 11.18kb -> 5.62kb (49.76%)
/static/appsmith_logo_primary.png -- 8.02kb -> 4.06kb (49.34%)
/app/client/src/assets/images/appsmith_logo.png -- 8.02kb -> 4.06kb (49.34%)
/static/logo.png -- 13.20kb -> 7.77kb (41.11%)
/app/client/src/assets/images/no_image.png -- 4.94kb -> 2.97kb (39.97%)
/app/client/src/assets/images/query-image-outline.png -- 1.65kb -> 1.01kb (38.71%)
/app/client/src/assets/images/404-image.png -- 141.37kb -> 94.81kb (32.93%)
/app/server/appsmith-server/src/test/resources/test_assets/OrganizationServiceTest/my_organization_logo.png -- 1.77kb -> 1.20kb (32.41%)
/app/client/src/assets/images/appsmith_logo_white.png -- 1.88kb -> 1.29kb (31.17%)
/app/client/src/assets/icons/control/play-icon.png -- 2.00kb -> 1.39kb (30.15%)
/Query.png -- 219.82kb -> 155.18kb (29.41%)
/app/client/src/assets/images/Github.png -- 4.17kb -> 2.94kb (29.36%)
/API.png -- 332.87kb -> 239.07kb (28.18%)
/static/logo-no-padding.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/images/Curl.png -- 40.68kb -> 32.55kb (19.99%)
/app/client/src/assets/icons/ads/logout.svg -- 0.94kb -> 0.76kb (19.38%)
/app/client/src/assets/icons/menu/datasource-column.svg -- 0.64kb -> 0.52kb (19.15%)
/static/API2.png -- 167.58kb -> 140.36kb (16.24%)
/static/Query2.png -- 118.59kb -> 102.85kb (13.27%)
/app/client/src/assets/icons/ads/context-menu.svg -- 0.52kb -> 0.45kb (12.99%)
/app/client/src/assets/icons/help/github-icon.svg -- 2.63kb -> 2.34kb (10.85%)
/app/client/src/assets/icons/ads/search.svg -- 0.26kb -> 0.25kb (3.73%)
/app/client/src/assets/icons/widget/slash.svg -- 0.19kb -> 0.18kb (3.59%)
/app/client/src/assets/icons/widget/plus.svg -- 0.30kb -> 0.29kb (3.58%)
/app/client/src/assets/icons/widget/modal.svg -- 0.20kb -> 0.19kb (2.99%)
/app/client/src/assets/icons/ads/frame.svg -- 0.50kb -> 0.48kb (2.96%)
/app/client/src/assets/icons/menu/explorer.svg -- 0.19kb -> 0.18kb (2.11%)
/app/client/src/assets/icons/control/lightning.svg -- 0.23kb -> 0.23kb (2.1%)
/app/client/src/assets/icons/ads/product.svg -- 0.34kb -> 0.33kb (2.03%)
/app/client/src/assets/icons/widget/container.svg -- 0.20kb -> 0.19kb (1.99%)
/app/client/src/assets/images/placeholder-image.svg -- 0.15kb -> 0.14kb (1.99%)
/static/Share5.png -- 143.35kb -> 140.55kb (1.95%)
/app/client/src/assets/icons/form/info-outline.svg -- 1.77kb -> 1.73kb (1.93%)
/app/client/src/assets/icons/ads/file.svg -- 0.36kb -> 0.35kb (1.89%)
/app/client/src/assets/icons/ads/success.svg -- 0.26kb -> 0.25kb (1.88%)
/app/client/src/assets/icons/widget/input.svg -- 0.32kb -> 0.31kb (1.84%)
/app/client/src/assets/icons/ads/create-new.svg -- 0.23kb -> 0.22kb (1.73%)
/app/client/src/assets/icons/ads/book.svg -- 0.52kb -> 0.51kb (1.69%)
/app/client/src/assets/icons/control/email.svg -- 0.17kb -> 0.17kb (1.69%)
/app/client/src/assets/icons/ads/down_arrow.svg -- 0.18kb -> 0.18kb (1.63%)
/app/client/src/assets/icons/ads/upper_arrow.svg -- 0.18kb -> 0.18kb (1.63%)
/app/client/src/assets/icons/ads/bag.svg -- 0.42kb -> 0.42kb (1.61%)
/app/client/src/assets/icons/control/compact.svg -- 0.55kb -> 0.54kb (1.59%)
/app/client/src/assets/icons/help/openlink.svg -- 0.70kb -> 0.69kb (1.53%)
/app/client/src/assets/icons/help/document.svg -- 0.80kb -> 0.79kb (1.47%)
/app/client/src/assets/images/logo.svg -- 2.61kb -> 2.57kb (1.46%)
/app/client/src/assets/icons/ads/manage.svg -- 0.27kb -> 0.27kb (1.42%)
/app/client/src/assets/icons/ads/error.svg -- 0.35kb -> 0.34kb (1.4%)
/app/client/src/assets/icons/ads/view-all.svg -- 0.21kb -> 0.21kb (1.39%)
/app/client/src/assets/icons/control/pick-location-initial.svg -- 0.50kb -> 0.49kb (1.38%)
/app/client/src/assets/icons/menu/storage.svg -- 0.21kb -> 0.21kb (1.36%)
/app/client/src/assets/icons/ads/calender.svg -- 0.51kb -> 0.50kb (1.35%)
/app/client/src/assets/icons/menu/widgets-colored.svg -- 0.22kb -> 0.22kb (1.32%)
/app/client/src/assets/icons/control/input.svg -- 0.31kb -> 0.30kb (1.27%)
/app/client/src/assets/icons/header/share-white.svg -- 0.47kb -> 0.46kb (1.26%)
/app/client/src/assets/icons/control/pick-location-onclick.svg -- 0.48kb -> 0.48kb (1.21%)
/app/client/src/assets/icons/menu/datasource-table.svg -- 0.25kb -> 0.24kb (1.2%)
/app/client/src/assets/icons/form/add-new.svg -- 0.34kb -> 0.34kb (1.15%)
/app/client/src/assets/icons/ads/camera.svg -- 0.86kb -> 0.85kb (1.14%)
/app/client/src/assets/icons/widget/image.svg -- 0.35kb -> 0.35kb (1.11%)
/app/client/src/assets/icons/ads/shopper.svg -- 0.62kb -> 0.61kb (1.11%)
/app/client/src/assets/icons/control/sort-icon.svg -- 0.27kb -> 0.27kb (1.09%)
/app/client/src/assets/icons/menu/pages.svg -- 0.37kb -> 0.36kb (1.07%)
/app/client/src/assets/icons/ads/delete.svg -- 0.28kb -> 0.27kb (1.06%)
/app/client/src/assets/icons/menu/page.svg -- 0.37kb -> 0.37kb (1.06%)
/app/client/src/assets/icons/ads/workspace.svg -- 0.28kb -> 0.28kb (1.05%)
/app/client/src/assets/icons/control/download-table.svg -- 0.47kb -> 0.47kb (1.03%)
/app/client/src/assets/icons/control/help.svg -- 0.47kb -> 0.47kb (1.03%)
/app/client/src/assets/icons/control/close.svg -- 0.29kb -> 0.29kb (1.01%)
/app/client/src/assets/icons/control/move.svg -- 0.39kb -> 0.39kb (1%)
/app/client/src/assets/icons/ads/general.svg -- 0.29kb -> 0.29kb (1%)
/app/client/src/assets/icons/ads/duplicate.svg -- 0.30kb -> 0.30kb (0.96%)
/app/client/src/assets/icons/control/edit-white.svg -- 0.41kb -> 0.40kb (0.96%)
/app/client/src/assets/icons/control/view.svg -- 0.32kb -> 0.32kb (0.92%)
/app/client/src/assets/icons/header/feedback.svg -- 0.43kb -> 0.42kb (0.91%)
/app/client/src/assets/icons/control/remove.svg -- 0.33kb -> 0.33kb (0.89%)
/app/client/src/assets/icons/ads/heart.svg -- 0.79kb -> 0.79kb (0.86%)
/app/client/src/assets/icons/control/more-vertical.svg -- 1.02kb -> 1.01kb (0.86%)
/app/client/src/assets/icons/widget/rich-text.svg -- 1.60kb -> 1.58kb (0.86%)
/app/client/src/assets/icons/control/info.svg -- 0.34kb -> 0.34kb (0.85%)
/app/client/src/assets/icons/control/draggable.svg -- 0.47kb -> 0.47kb (0.83%)
/app/client/src/assets/images/API.svg -- 4.92kb -> 4.88kb (0.81%)
/app/client/src/assets/icons/widget/radio.svg -- 0.50kb -> 0.49kb (0.79%)
/app/client/src/assets/icons/ads/share.svg -- 0.37kb -> 0.37kb (0.79%)
/app/client/src/assets/images/EditPen.svg -- 0.38kb -> 0.37kb (0.78%)
/app/client/src/assets/icons/widget/collapse.svg -- 0.50kb -> 0.50kb (0.78%)
/app/client/src/assets/icons/control/edit.svg -- 0.65kb -> 0.65kb (0.75%)
/app/client/src/assets/icons/ads/user.svg -- 0.54kb -> 0.53kb (0.73%)
/app/client/src/assets/icons/widget/checkbox.svg -- 0.54kb -> 0.53kb (0.73%)
/app/client/src/assets/icons/ads/edit.svg -- 0.40kb -> 0.40kb (0.73%)
/app/client/src/assets/icons/control/collapse.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/icons/menu/queries.svg -- 0.41kb -> 0.41kb (0.71%)
/app/client/src/assets/icons/ads/close.svg -- 0.42kb -> 0.42kb (0.7%)
/app/client/src/assets/images/NoSearchResult.svg -- 8.61kb -> 8.55kb (0.69%)
/app/client/src/assets/icons/widget/chart.svg -- 0.43kb -> 0.43kb (0.68%)
/app/client/src/assets/icons/control/decrease.svg -- 0.45kb -> 0.45kb (0.65%)
/app/client/src/assets/icons/menu/api.svg -- 1.51kb -> 1.50kb (0.65%)
/app/client/src/assets/icons/widget/filepicker.svg -- 0.61kb -> 0.60kb (0.64%)
/app/client/src/assets/icons/ads/launch.svg -- 0.61kb -> 0.61kb (0.64%)
/app/client/src/assets/icons/menu/homepage.svg -- 0.92kb -> 0.92kb (0.64%)
/app/client/src/assets/icons/control/launch.svg -- 0.62kb -> 0.61kb (0.63%)
/app/client/src/assets/icons/control/pick-location-selected.svg -- 0.48kb -> 0.48kb (0.61%)
/app/client/src/assets/icons/widget/video.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/currency.svg -- 0.50kb -> 0.49kb (0.59%)
/app/client/src/assets/icons/control/filter-icon.svg -- 0.84kb -> 0.84kb (0.58%)
/app/client/src/assets/icons/control/search.svg -- 0.55kb -> 0.54kb (0.54%)
/app/client/src/assets/icons/control/zoomout.svg -- 0.55kb -> 0.55kb (0.53%)
/app/client/src/assets/icons/form/lock.svg -- 0.56kb -> 0.56kb (0.52%)
/app/client/src/assets/icons/control/multiline.svg -- 1.51kb -> 1.50kb (0.52%)
/app/client/src/assets/icons/ads/flight.svg -- 1.33kb -> 1.32kb (0.51%)
/app/client/src/assets/icons/control/pick-my-location.svg -- 1.16kb -> 1.16kb (0.5%)
/app/client/src/assets/icons/ads/chat.svg -- 1.36kb -> 1.35kb (0.5%)
/app/client/src/assets/icons/widget/table.svg -- 0.78kb -> 0.78kb (0.5%)
/app/client/src/assets/icons/control/delete.svg -- 0.59kb -> 0.59kb (0.5%)
/app/client/src/assets/icons/control/phone.svg -- 0.59kb -> 0.59kb (0.5%)
/app/client/src/assets/icons/control/password.svg -- 1.97kb -> 1.96kb (0.49%)
/app/client/src/assets/icons/widget/alert.svg -- 0.81kb -> 0.81kb (0.48%)
/app/client/src/assets/icons/control/right-align.svg -- 0.62kb -> 0.61kb (0.48%)
/app/client/src/assets/icons/ads/invite-users.svg -- 0.64kb -> 0.64kb (0.46%)
/app/client/src/assets/icons/widget/tabs.svg -- 0.86kb -> 0.85kb (0.46%)
/app/client/src/assets/icons/control/columns-visibility.svg -- 1.08kb -> 1.07kb (0.45%)
/app/client/src/assets/icons/control/zoomin.svg -- 0.65kb -> 0.65kb (0.45%)
/app/client/src/assets/icons/control/left-align.svg -- 0.67kb -> 0.67kb (0.44%)
/app/client/src/assets/icons/control/underline.svg -- 0.68kb -> 0.68kb (0.43%)
/app/client/src/assets/icons/ads/globe.svg -- 1.60kb -> 1.59kb (0.43%)
/app/client/src/assets/icons/menu/widgets.svg -- 0.97kb -> 0.97kb (0.4%)
/app/client/src/assets/icons/widget/text.svg -- 0.99kb -> 0.98kb (0.4%)
/app/client/src/assets/icons/control/center-align.svg -- 0.76kb -> 0.76kb (0.38%)
/app/client/src/assets/icons/widget/location-picker.svg -- 1.02kb -> 1.02kb (0.38%)
/app/client/src/assets/icons/menu/overflow-menu.svg -- 1.05kb -> 1.05kb (0.37%)
/app/client/src/assets/icons/header/deploy.svg -- 1.59kb -> 1.59kb (0.37%)
/app/client/src/assets/icons/control/italics.svg -- 0.80kb -> 0.80kb (0.36%)
/app/client/src/assets/icons/control/increase.svg -- 0.81kb -> 0.81kb (0.36%)
/app/client/src/assets/icons/help/discord.svg -- 1.08kb -> 1.08kb (0.36%)
/app/client/src/assets/icons/widget/map.svg -- 1.10kb -> 1.09kb (0.36%)
/app/client/src/assets/images/email-not-configured.svg -- 28.71kb -> 28.61kb (0.35%)
/app/client/src/assets/icons/help/help.svg -- 1.15kb -> 1.15kb (0.34%)
/app/client/src/assets/icons/control/copy.svg -- 0.87kb -> 0.86kb (0.34%)
/app/client/src/assets/icons/control/bold.svg -- 0.88kb -> 0.88kb (0.33%)
/app/client/src/assets/icons/widget/dropdown.svg -- 1.21kb -> 1.21kb (0.32%)
/app/client/src/assets/icons/ads/billing.svg -- 0.96kb -> 0.95kb (0.31%)
/app/client/src/assets/icons/control/decimal.svg -- 0.98kb -> 0.97kb (0.3%)
/app/client/src/assets/icons/control/settings.svg -- 1.33kb -> 1.32kb (0.29%)
/app/client/src/assets/icons/control/chevron-down.svg -- 1.02kb -> 1.02kb (0.29%)
/app/client/src/assets/icons/widget/switch.svg -- 1.38kb -> 1.37kb (0.28%)
/app/client/src/assets/images/secure.svg -- 1.07kb -> 1.07kb (0.27%)
/app/client/src/assets/icons/menu/datasource-colored.svg -- 1.12kb -> 1.12kb (0.26%)
/app/client/src/assets/icons/menu/api-colored.svg -- 1.13kb -> 1.12kb (0.26%)
/app/client/src/assets/icons/menu/foreign-key.svg -- 1.15kb -> 1.15kb (0.26%)
/app/client/src/assets/icons/menu/org.svg -- 1.15kb -> 1.15kb (0.25%)
/app/client/src/assets/icons/control/redo.svg -- 1.17kb -> 1.16kb (0.25%)
/app/client/src/assets/icons/menu/primary-key.svg -- 1.17kb -> 1.17kb (0.25%)
/app/client/src/assets/icons/control/undo.svg -- 1.17kb -> 1.17kb (0.25%)
/app/client/src/assets/icons/form/trash.svg -- 2.75kb -> 2.74kb (0.25%)
/app/client/src/assets/icons/control/integer.svg -- 1.25kb -> 1.25kb (0.23%)
/app/client/src/assets/icons/widget/form.svg -- 1.32kb -> 1.32kb (0.22%)
/app/client/src/assets/icons/control/drag.svg -- 1.33kb -> 1.33kb (0.22%)
/app/client/src/assets/icons/header/save-failure.svg -- 1.45kb -> 1.44kb (0.2%)
/app/client/src/assets/icons/control/js-toggle.svg -- 1.97kb -> 1.96kb (0.2%)
/app/client/src/assets/images/Curl-logo.svg -- 5.33kb -> 5.32kb (0.18%)
/app/client/src/assets/icons/alert/info.svg -- 1.60kb -> 1.60kb (0.18%)
/app/client/src/assets/icons/alert/warning.svg -- 1.63kb -> 1.63kb (0.18%)
/app/client/src/assets/icons/header/save-success.svg -- 1.67kb -> 1.66kb (0.18%)
/app/client/src/assets/icons/alert/success.svg -- 1.67kb -> 1.67kb (0.18%)
/app/client/src/assets/icons/menu/data-sources.svg -- 1.74kb -> 1.73kb (0.17%)
/app/client/src/assets/icons/alert/error.svg -- 1.95kb -> 1.95kb (0.15%)
/app/client/src/assets/icons/widget/datepicker.svg -- 3.23kb -> 3.22kb (0.12%)
/app/client/src/assets/icons/widget/button.svg -- 3.75kb -> 3.75kb (0.1%)
/app/client/src/assets/icons/control/address.svg -- 3.37kb -> 3.37kb (0.09%)
/app/client/src/assets/icons/control/datepicker.svg -- 3.75kb -> 3.75kb (0.08%)
/app/client/src/assets/images/appsmith-datasource.svg -- 505.60kb -> 505.43kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-02 19:44:01 +05:30
devrk96
09ce4329b0
underline css fixed (#1515) 2020-11-02 19:35:31 +05:30
Arpit Mohan
7d7ea490ec
Fixing the client release & master builds (#1501) 2020-11-02 16:27:30 +05:30
Automated Github Action
89edfa8c93 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-02 10:16:13 +00:00
satbir121
51cb0d82a2
Fixing zoom on pan issue. (#1474) 
* FIxing zoom on pan issue.

* Adding a disabled label to 1x zoom.

* Adding comments.

* Update PropertyPaneConfigResponse.tsx

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
 2020-11-02 15:21:14 +05:30
Arpit Mohan
773b069885 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-02 15:07:32 +05:30
akash-codemonk
ac70e5be4d
Update query form UI (#1500) 2020-11-02 15:01:00 +05:30
Abhinav Jha
4f569f4996
Fix issue where datasource was missing for an action (#1498) 2020-11-02 14:58:20 +05:30
Automated Github Action
4c48d61a50 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-02 09:08:12 +00:00
akash-codemonk
fbfcfeed2a
Show template menu on click of datasource table (#1410) 2020-11-02 14:24:54 +05:30
Trisha Anand
32301ae3b4
Printing the invalid messages of the action properly. (#1507) 2020-11-02 14:15:29 +05:30
Automated Github Action
4fe0fdc952 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-02 06:10:12 +00:00
Nikhil Nandagopal
2ec5b6297b
Fix/action splitting (#1497) 
* fixed argument splitting logic to rely onregex instead of simple string split

* abstracted splitting function
 2020-11-02 10:54:15 +05:30
Arpit Mohan
e3d5832a78 Merge branch 'master' into release 2020-10-31 17:43:06 +05:30
Arpit Mohan
90e9c131b1 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-31 17:26:29 +05:30
devrk96
7d6a70d3ce
Feature: New create app flow (#1375) 
* EditableTextWrapper component implemented

* create new app flow implemented

* test cases for new create new app flow fixed

* role update element fixed

* before-all hooks fixed

* createOrg test cases fixed

* loading state test added

* editableText input unique identifier added in test-cases

* updateApplication API alias name corrected

* removed the second className prop on same component

* PR feedback implemented
 2020-10-31 12:10:51 +05:30
Nikhil Nandagopal
3829ccbbd0 Merge branch 'master' of github.com:appsmithorg/appsmith 
# Conflicts:
#	.github/workflows/client.yml
 2020-10-30 20:13:49 +05:30
Automated Github Action
8d469ad24f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 13:04:52 +00:00
Nikhil Nandagopal
5c26ef5d07
Fixed Bindings Working inside action selectors (#1484) 
* added functions to convert string to JS and JS to string while manipulating property pane values
refactored getters and setters to reuse functions instead of creating multiple functions

* minor fixes

* optimized the js conversion function and fixed an edge case

* minor fix for type setters

* abstracted enum getter

* dummy commit
 2020-10-30 18:05:21 +05:30
vicky-primathon
6a0e573c50 Query table scroll issue fixed (#1464) 
* Query table scroll issue fixed

* Table widget horizontal scroll fix
 2020-10-30 16:47:19 +05:30
Automated Github Action
dbdd5a9742 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 11:08:58 +00:00
vicky-primathon
0508bbd115 Query table scroll issue fixed (#1464) 
* Query table scroll issue fixed

* Table widget horizontal scroll fix
 2020-10-30 16:20:35 +05:30
vicky-primathon
b74bec311e
Query table scroll issue fixed (#1464) 
* Query table scroll issue fixed

* Table widget horizontal scroll fix
 2020-10-30 16:18:57 +05:30
Arpit Mohan
a65b915fb3 Fixing merge conflicts when back merging master into release 2020-10-30 15:33:43 +05:30
Arpit Mohan
17ae082637 Moving to conditional if steps 2020-10-30 15:11:59 +05:30
Arpit Mohan
4df2801643 Splitting the if conditions 2020-10-30 15:04:01 +05:30
Arpit Mohan
ca72e1f382 Trying a different syntax 2020-10-30 14:57:38 +05:30
Arpit Mohan
0595b8d05a Adding more debug logging 2020-10-30 14:52:34 +05:30
Arpit Mohan
594bae4d17 Making the default shell bash 2020-10-30 14:49:37 +05:30
Arpit Mohan
aef74b8aaa Dummy commit to trigger build 2020-10-30 14:41:37 +05:30
Arpit Mohan
184cda75cf Minor changes in the client.ymp file 2020-10-30 14:17:31 +05:30
Arpit Mohan
7b76dfd293 Adding debug logs for the output variable 2020-10-30 14:10:14 +05:30
Arpit Mohan
71f5daac3a Debugging the github ref 2020-10-30 13:42:31 +05:30
Arpit Mohan
587a90af0f Adding a separate step for the server docker image 2020-10-30 13:24:08 +05:30
Arpit Mohan
97e4df6fc2 Adding dummy commit to trigger build 2020-10-30 13:08:30 +05:30
Arpit Mohan
b15c0a1f0b Fixing the docker image name for master builds 2020-10-30 12:56:48 +05:30
Arpit Mohan
12c874cca7 Fixing merge conflicts when cherry picking 2020-10-30 12:55:47 +05:30
Arpit Mohan
862a310050 Fixing merge conflicts during cherry picking 2020-10-30 12:54:52 +05:30
Arpit Mohan
ccea01cb21 Ensures that the master & release flows pick appropriate server Docker images (#1465) 2020-10-30 12:43:52 +05:30
Automated Github Action
d3ccf634f8 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 07:12:14 +00:00
akash-codemonk
d652c1485d
Update the action config with the datasource info (#1451) 2020-10-30 11:54:15 +05:30
Automated Github Action
9cdee5aee4 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 06:05:53 +00:00
Sumit Kumar
6cf4c10c4b Merge branch 'fix/setup_guide' of https://github.com/sumitsum/appsmith into fix/setup_guide 2020-10-30 01:17:50 +05:30
Sumit Kumar
d8e4b045b7 Update server and client setup guide. (#1437) 
1. Add Linux specific requirements.
2. Add debug info for common build errors.
3. Correct build step or any other statement wherever required.
4. For more info please see the attachment here: https://github.com/appsmithorg/appsmith/issues/1437
 2020-10-30 00:57:25 +05:30
Automated Github Action
2016c19b2f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 19:04:39 +00:00
vicky-primathon
75c84cbba7
Map resetting when clicking on a marker fix (#1299) 2020-10-29 23:46:27 +05:30
Automated Github Action
7eb11f0007 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 14:09:24 +00:00
akash-codemonk
9553fe9b19
Merge datasources and actions in explorer (#1285) 2020-10-29 19:23:10 +05:30
Nuwan Sameera Alawatta
e782ca17e8
fix lightning bolt menu onhover bug (#1454) 
* fix lightning bolt create new api onhover bug

* fix lightning bolt menu onhover bug
 2020-10-29 19:00:04 +05:30
Automated Github Action
7e58c95ece Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 12:11:37 +00:00
devrk96
f6bb16a4e6
Fix: Invalid email error in invite modal (#1368) 
* Invalid email error showing on entering incorrect email before submission

* error state name corrected

* colon removed from error message
 2020-10-29 16:47:52 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356) 
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
 2020-10-29 16:44:39 +05:30
Arpit Mohan
f38df9febc Correcting typo in env variable in client.yml 2020-10-29 16:19:14 +05:30
Arpit Mohan
63329b3762 Fixing bad merge 2020-10-29 16:05:37 +05:30
Arpit Mohan
7668560738 Fixing merge conflicts 2020-10-29 15:51:04 +05:30
Arpit Mohan
591b51b6a9
Ensures that the master & release flows pick appropriate server Docker images (#1465) 2020-10-29 15:44:58 +05:30
Trisha Anand
d6ff4dedd6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 15:04:00 +05:30
Trisha Anand
13e2cc2a63
[Do Not Merge]Brought down cloud migration time from 122 minutes to 9.5 minutes (#1441) 
* [Do Not Merge]Brought down cloud migration time from 122 minutes to 9.5 minutes

* Removed commented code.
TODO : Figure out if we want to change the migration order numbers once the release environment is reverted back to pre original migration data.

* Added plugin id for the migrated action.

* Renamed the createIndex functions for new action and new page and added a drop collection command before creating the index. This ensures that if any developer has pulled code in the last two days, this migration does not negatively impact them
 2020-10-29 15:03:41 +05:30
Automated Github Action
ccac36928f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 09:08:35 +00:00
Nikhil Nandagopal
2d7ccdc515
flipped user id and instance id so that the ping can be correlated with the email from the install script (#1461) 2020-10-29 14:17:45 +05:30
Sumit Kumar
da907f58f3 Merge branch 'fix/setup_guide' of https://github.com/sumitsum/appsmith into fix/setup_guide 2020-10-29 13:46:12 +05:30
Automated Github Action
676f26dcec Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 06:12:55 +00:00
NandanAnantharamu
a7b6a754f5
Added tests for add widget in query (#1353) 
* Added tests for add widget in query

* test updated

* updated test with wait

* Updated binding data

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-10-29 11:15:17 +05:30
NandanAnantharamu
ee0729e60c
Basic test for theme change (#1448) 2020-10-29 11:14:46 +05:30
Sumit Kumar
1437d4a9e8 Update server and client setup guide. (#1437) 
1. Add Linux specific requirements.
2. Add debug info for common build errors.
3. Correct build step or any other statement wherever required.
4. For more info please see the attachment here: https://github.com/appsmithorg/appsmith/issues/1437
 2020-10-28 23:02:33 +05:30
Automated Github Action
6e1e226a62 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 16:12:54 +00:00
vicky-primathon
dbf98fde5f
Fix/table widget filter conditions (#1297) 
* Table widget isEqualTo and notEqualTo conditions fixed
 2020-10-28 21:10:33 +05:30
Automated Github Action
4bb2d491ee Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 15:09:29 +00:00
vicky-primathon
4cd2579dfa
Added horizontal scrolling in table widget (#1436) 
* Added horizontal scrolling in table widget

* Handled table grow shrink with display table css property
 2020-10-28 19:49:15 +05:30
Arpit Mohan
f2e37b8759 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-28 19:06:37 +05:30
Arpit Mohan
470f2fafcd
Adding support for https endpoints for ES plugin (#1445) 
* Adding host:port validation checks to ES plugin & Redis plugin

Also correcting the assertions in the RedisPluginTest so that the error message on test failure is accurate.

* Removing the endpoint validation from datasourceServiceImpl

Moving the endpoint validation to the plugin implementation classes because there are databases that require complete HTTP URL in their configuration. Checking for http/https at the platform level affects the UX for the user & plugin developer when using a new integration. Hence, all plugins must implement their own client/server validations in their own implementations

* Adding tests to assert hostname validation in mysql & postgres plugins
 2020-10-28 19:06:10 +05:30
Automated Github Action
3bc4ca12b3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 12:11:09 +00:00
devrk96
5ebea89d98
Test cases: Application update (#1339) 
* application name and icon update test cases implemented

* application icon update test case implemented
 2020-10-28 17:36:30 +05:30
devrk96
bc70460093
role change update fixed (#1192) 2020-10-28 17:21:14 +05:30
Automated Github Action
4a754f526b Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 11:07:52 +00:00
Hetu Nandu
44725c983e
Use global history on 500 page (#1446) 2020-10-28 16:29:34 +05:30
Automated Github Action
ab0f016f03 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 08:11:24 +00:00
Jeff Rescignano
c967c03494
Add "back to home" CTA on 500 page (#1319) 
Fixes: #1303 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-10-28 13:38:52 +05:30
Arpit Mohan
ee683157a5 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-28 11:10:06 +05:30
devrk96
15ab7809f8
Org name, email and website update test cases implemented (#1433) 2020-10-28 11:09:28 +05:30
Arpit Mohan
d13de8709a Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-27 15:30:39 +05:30
Trisha Anand
5197b17d8c
Bug Fix : Reading the datasource configuration incorrectly from actionDTO instead of datasource object. (#1415) 
* Bug Fix : Reading the datasource configuration incorrectly from actionDTO instead of datasource object.

* Added test case to assert that datasource configuration and action configurations are not null when action execute is called.
 2020-10-27 15:23:25 +05:30
Arpit Mohan
d457614b4e Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-27 12:29:01 +05:30
akash-codemonk
a8b40dcd53
Do not show template view if there no templates. (#1330) 2020-10-27 12:03:45 +05:30
Nikhil Nandagopal
2557c1748c Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-27 11:39:36 +05:30
Automated Github Action
0ff5b3f471 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-27 06:09:15 +00:00
Nikhil Nandagopal
427aa7e74c disable sentry perf (#1399) 2020-10-27 11:39:05 +05:30
Nikhil Nandagopal
790d202662 Update netlify.toml 2020-10-27 11:33:49 +05:30
NandanAnantharamu
d03be01b28
Added assertion for basic AddWidget test (#1405) 2020-10-27 10:43:03 +05:30
Automated Github Action
07fdd867a6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-27 05:09:54 +00:00
akash-codemonk
0f34c7f38f
Secure connection UI (#1358) 2020-10-27 10:32:32 +05:30
Automated Github Action
e034f1062e Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 18:08:24 +00:00
Trisha Anand
230126ebcf
Remove unnecessary database migration (#1406) 2020-10-26 22:50:36 +05:30
Trisha Anand
d00ba212b3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 18:55:13 +05:30
Trisha Anand
5b625fed4a Dummy commit to run the client test suite again. 2020-10-26 18:53:23 +05:30
Trisha Anand
eda489fd7f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 18:07:37 +05:30
Trisha Anand
fc9ea45e3b
[API breaking change : Automated Tests Will Fail] Page And Action Refactor (#549) 
* Introduced new page which stores the published and unpublished pages as separate.

* Mid level commit to save the state.

* Parity of new page repository with old page repository (custom functions)

* WIP : Delete a page. This requires changes across application structure as well.

* Added publishedPages construct inside application to store the pages in the deployed view as well as isDefault so that the same changes (delete or isDefault) in unpublished view doesn't alter these fields for the published application

* Parity reached with PageService.

* Minor ActionService refactor to remove unnecessary code.
ApplicationPageService, LayoutActionService, LayoutService use the new page service to fetch the pages
Minor corrections in fetching the page from new page service in tests

* New save function which sets the PageDTO for unpublished page and then saves the new page into repository.

* Migration of page service functions to new page service functions across other services/tests/controller

* Finished migrating all the page service functions to the new page service functions

* Application Service Tests have been fixed.

* All the existing test cases are working now.

* Publish application implemented to store published pages as well. Added a basic test case to check that published pages is being set and that page's publishedPageDTO is being set accordingly.

* Minor TODOs added to add test cases for published application.

* A few tests to ascertain that published application page fields (deleted, isDefault) does not get changed when these statuses are changed for a page in edit mode.

* Added a new controller end point to fetch application in view mode.

* Added new endpoint for fetching an application in view mode on the client.

* Bug fix where get application in view mode API was not getting called.

* Fixed the get page names by application & archive pages which have been deleted in edit mode during publishing of application.

* During delete page, if a page was never published and it was deleted during edit, delete the entire page instead of just deleting the unpublished PageDTO

* Minor formatting.

* Non working client side code to fetch page list using view mode.

* revert unnecassary changes and streamlined view and edit actions

* Fix missed import

* Fixed a bug where if a page is not published, it should not be returned in view mode in list of page names api.

* Fixed update for a page which was not working in integration test.

* ActionDTO added.

* Solidified the new action structure.

* Migration added for NewAction index creation and NewAction per Action insertion in the database.

* Basic file structure added the new repository, custom repository, service, etc.

* Delete OldPage.java

* Repo functions added - TODO : Haven;t handled the published/edited views

* Helper functions added to convert Action to NewAction and vice-versa. Removed unused currentUserMono usage.

* Create & update action functionality added.

* Execute Action refactored. Removed dry run specific code.

* Repository migrated to handle new data structure. Execute action refactored to no longer support dry runs of actions.

* TODO added for special handling of change view of application to handle edge cases of pages/actions which either exist in published mode but don't exist in unpublished mode or vice versa.

* Migrated finding on load actions from spring repository to custom repository.

* In view mode, now actions are being fetched by application id directly instead of first fetching application and then using the page ids, fetching the actions. This reduces the db calls from 2 to 1 per fetch actions in view mode api call.

* Delete action and get all actions (used in edit mode on the client side) implemented.

* Updated CollectionService and ActionCollectionService to use the new action service instead of the old one.

* LayoutActionService refactored to now use the new service functions.

* ActionController now no longer used ActionService. The remaining service functions have been migrated to the new action service.

* Refactor across ACL code for addition/removal of policies during addition/removal of users to organization, making app public, refactor for services like policy utils, item service, etc.

* Removed the last of action repository and action service and replaced with new action repo and new action service.

* Compile and run time issues fixed. The server is coming up without any spring dependency errors.

* WIP in fixing fetching actions by page id.

* Finally!!! Fixed the fetch actions (both published and unpublished actions) by page id repository function.

* Fixed create action bug where null datasource in published actiondto (inside newly created action) leads to error.

* Fixed the execute action issues :
1. Removed the dry runs from the tests
2. Fixed the null pointer error in variable substituted action and datasource configurations.

* 1. Fixed the custom action repository field names.
2. Fixed the data structures used in ExamplesOrganizationClonerTests

* Fixed countByDatasourceId repository function which was querying the actions incorrectly.

* Fixed the clone example organization error where the id of the action was not getting updated in the page correctly. Yay!

* Fixed post merge compilation failure.

* Fixed more compilation time failures in ActionServiceTest

* Fixed failing test case for fetching actions in view mode.

* Minor changes to resolve merge changes and incorporate in the new refactored code.

* 1. Fixed compile time errors on Client code.
2. Fixed fetching of actions in view mode by application id. The repository function did not need name parameter. Removed the same.

* [Integration Testing Error Fix] : Added a new test case for refactor action name.

* Instead of fetching actions in the page, mistakenly used the base service which was fetching all the actions in the repository, barring none which led to the name refactor being blocked even though no action in the current page exists with the new proposed name,

* Added delete functionality to action service.

* Minor code cleanup

* Adding viewMode to action execution

* Replacing action with actionId.

* 1. Bug fix for deletion of unpublished action. In case of never published action, the entire action should be deleted. In case an action was published, only the unpublished action should be deleted.
2. In case of DB actions (external datasources), only the bare minimum fields should be stored inside the action (datasource id and datasource plugin id). The other fields should not be duplicated across code.

* Fixed yarn build compilation issues.

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ActionController.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Changed the API path for GET applications in view mode. Some minor code formatting.

* Incorporated review comments.

* Some more unnecessary code removed.

* Instead of returning Page, now the interface object between client and server for Pages is PageDTO

* Migrated Page and Action to PageDTO and ActionDTO
Fixed the compilation issues.
TODO : Fix the test compilation issues.

* Fixed compilation time issues with all the tests by migrating Page and Action to PageDTO and ActionDTO respectively

* Action Controller and Page Controller no longer extend Base Controller. All the required functions have now been implemented and no base line API end points are being re-used from the base.

* Test case fixes.

* Bug Fix : Updating an action was not updating execute on load. Fixed the data flow leading to the error.

* Deprecating Page and Action domain objects. This is to ensure no new code is written with these till we remove this old code.

* Cloned example applications are now published before returning. This is to ensure that the applications are in ready to view mode when the new user signs up.

* Added a function comment to expand on the usage of new param introduced.

* When cloning a page, new actions were not being stored. Added that. Also updated the clonePage test to assert that the actions are also cloned when the pages are cloned.

* Updated a Api call

* removed extra slash

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
 2020-10-26 18:04:23 +05:30
Automated Github Action
a2b08c34fc Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 12:10:37 +00:00
Nikhil Nandagopal
e963b3a2f5
disable sentry perf (#1399) 2020-10-26 16:46:24 +05:30
Automated Github Action
b574e62f69 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 10:09:13 +00:00
vicky-primathon
aa9bc58a90
Fix/map crash (#1301) 
* Adding default map center to fix map crash issue

* API key removed
 2020-10-26 15:31:01 +05:30
Nikhil Nandagopal
c41733700a
Update netlify.toml 2020-10-26 14:59:27 +05:30
Automated Github Action
8a7915f655 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 07:09:51 +00:00
Thakur Karthik
57031fed10
Fix theme breaking with a slash in url (#1391) 
Fixes #1386
 2020-10-26 12:30:01 +05:30
Arpit Mohan
7758f5d750 Merge branch 'release' 2020-10-25 21:02:08 +05:30
Arpit Mohan
13fc69a2bb Disabling Sentry to check app load performance 2020-10-25 20:39:05 +05:30
Arpit Mohan
3cbb79c8b9 Merge branch 'release' 2020-10-25 13:11:34 +05:30
Arpit Mohan
2382af48e1 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-25 12:37:47 +05:30
Nikhil Nandagopal
411c2c24c3
Added check for config crashing when entity properties are not present (#1394) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2020-10-25 12:37:17 +05:30
Arpit Mohan
d502e08040 Fixing merge conflicts 2020-10-24 21:30:21 +05:30
Automated Github Action
00b1249461 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-24 15:07:55 +00:00
Hetu Nandu
ea0d873ac8
Fix JS switch failing when going back to normal (#1388) 
Fixes: #1389
 2020-10-24 19:59:53 +05:30
Automated Github Action
5f89256041 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-24 12:10:17 +00:00
Hetu Nandu
32469f50b2
Fix for app view not opening correct page (#1387) 
Fixes: #1385
 2020-10-24 17:15:16 +05:30
Arpit Mohan
2be2d441c6 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-23 23:53:01 +05:30
Arpit Mohan
c092297dbc Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-23 23:37:43 +05:30
Hetu Nandu
f4d9277950
Fix this (#1379) 2020-10-23 23:32:59 +05:30
Arpit Mohan
d977befc54 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-23 20:58:58 +05:30
Automated Github Action
4eaa52f520 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-23 15:07:54 +00:00
Arpit Mohan
c6d4902e3d
Adding microsoft SQL server plugin integration (#1374) 2020-10-23 20:36:45 +05:30
akash-codemonk
e9c40da8fd
Fix widget not having query data (#1372) 
* Initialise the tableData and dynamic binding prop adding widget
 2020-10-23 20:05:07 +05:30
Arpit Mohan
4cd9964649 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-23 13:32:13 +05:30
akash-codemonk
9d27315213
Update datasource form config to include encrypted property (#1360) 2020-10-23 13:31:46 +05:30
Arpit Mohan
dd6cef5d82 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-22 18:46:08 +05:30
Hetu Nandu
6dc40970ef
Fix async evaluation issues (#1348) 
* Fix issue with deleted widgets still showing up in binding reference

* Fix for firefox not letting errors pass through
 2020-10-22 18:45:50 +05:30
Arpit Mohan
365e9b6bf6 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-22 17:56:35 +05:30
Shinn Lok
4768fd3848
Fix organization ordering by name on the homepage (#1177) 2020-10-22 17:53:51 +05:30
Automated Github Action
4470beeab1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-22 12:10:31 +00:00
Akshay Avinash
474d95b9b4
Updated check to see appsmith editor link based on permissions (#1247) 2020-10-22 17:38:51 +05:30
Arpit Mohan
fc9562fb85 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-22 16:42:00 +05:30
Arpit Mohan
74fe08f8bf
Adding the database changelog for Redis (#1346) 
1. Fixing the build by excluding the slf4j-api from redis-plugin pom.xml
2. Adding the editor.json and form.json for the query pane & datasource pane.
3. Adding array handling in the Redis response by feeding all the output into a "result" key
 2020-10-22 16:40:19 +05:30
Automated Github Action
e99e8d8673 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-22 08:09:01 +00:00
Prashant Chaubey
bf69c7d66b
Adding basic structure for plugin integrating with Redis (#1085) 
Co-authored-by: nitesh261193 <nitesh261193@gmail.com>
 2020-10-22 13:26:58 +05:30
Hetu Nandu
4ffbd16ea8 Fix Dropdown widget selection (#1340) 2020-10-22 01:43:25 +05:30
Hetu Nandu
63e5e24c2b Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-22 01:36:08 +05:30
Hetu Nandu
a16372fed1
Fix Dropdown widget selection (#1340) 2020-10-22 01:15:02 +05:30
Automated Github Action
1e9fd22f3e Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-21 17:07:26 +00:00
dependabot[bot]
bc14b6ce4b
Bump junit in /app/server/appsmith-plugins/elasticSearchPlugin (#1331) 
Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.11.md)
- [Commits](https://github.com/junit-team/junit4/compare/r4.11...r4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-10-21 22:20:49 +05:30
Automated Github Action
497dc46266 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-21 13:07:36 +00:00
dependabot[bot]
a4872f3cb6
Bump junit in /app/server/appsmith-plugins/dynamoPlugin (#1335) 
Bumps [junit](https://github.com/junit-team/junit4) from 4.11 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.11.md)
- [Commits](https://github.com/junit-team/junit4/compare/r4.11...r4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-10-21 17:57:44 +05:30
Shrikant Sharat Kandula
2a53abd8a6
Add DynamoDB Plugin (#1167) 
* Added DynamoPlugin to integrate with DynamoDB

* Connection management for DynamoPlugin

* Process action from a single JSON object as input

* Moved ListTables command to separate class

* Add missing UI definition files

* Use reflection to build request objects for AWS SDK

* All DynamoDB actions are now run purely by reflection

* Serialize responses to JSON

* Remove some unused/commented code and some refactorings

* Add non-working test with generic dynamodb container

* Added working test for ListTables action

* Added test for PutItem action

* Add tests for get and update actions

* Added comments and some refactoring

* Removed unused Command class.

* Added more tests for map to SDK object conversion

* Add templates

* Add option to set an endpoint override

* Fix Dynamo plugin tests when ~/.aws is missing

* Add documentation link for DynamoDB plugin

* Fix validation checks

* Remove debug log

* Added comments on expected query structure

* Fix incorrect error condition with incorrect request format

* Add comment for converting action to method name

* Error out if region is missing

* Remove unused throws declaration

* Use rich form for action configuration

* Removed templates

* Use PNG for logo images

* Use PNG logos for all plugins

* Avoid hard-coded field names

* Change logo to PNG only for ElasticSearch for now

* Wrap errors in AppsmithPluginException

* Typo

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Fix changeset order number

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Minor refactoring and fixed error messaging

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2020-10-21 17:45:54 +05:30
Automated Github Action
a039a0ad50 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-21 12:10:23 +00:00
NandanAnantharamu
48a772ab5c
Updated locator for test failure (#1334) 2020-10-21 17:13:47 +05:30
Arpit Mohan
951935ac30 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-21 15:35:32 +05:30
Shrikant Sharat Kandula
fa1a0549ff
Add ElasticSearch integration (#1181) 
* add elasticSearchPlugin

* Fix container startup in tests

* Add elasticsearch dependency

* Get plugin to a base working state

* Add templates and tests for all Document APIs

* Add support for bulk queries

* Add test and template for bulk operations

* Use rich form for action configuration

* Add test API for ElasticSearch

* Use rich form's values for plugin execution

* Add authorization header support

* Fix tests after config object use changes

* Add test for bulk requests with nd-json body

* Remove templates and minor refactoring

* Fix potential NPE with null body

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* Add datasource validation for endpoint

* Wrap errors in AppsmithPluginException

Co-authored-by: Suman Patra <spatra@akamai.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2020-10-21 15:34:29 +05:30
satbir121
81a92d40cb
Supporting 5 app cards till 1368px resolution (#1270) 
* Supporting 5 app cards till 1368px resolution

* Removed unused var.
 2020-10-21 14:53:40 +05:30
Automated Github Action
b1e55d4786 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-21 08:08:48 +00:00
akash-codemonk
f19810117b
Query editor styling fixes (#1318) 2020-10-21 13:24:10 +05:30
Automated Github Action
38b9dfaa86 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-21 07:08:25 +00:00
Shinn Lok
014ff80548
Parameter missing for email template replace (#1323) 
Co-authored-by: Trisha Anand <trisha1990@gmail.com>
 2020-10-21 11:40:32 +05:30
Hetu Nandu
3498f92f8d Dummy commit 2020-10-21 11:13:54 +05:30
Automated Github Action
9f1681a2b7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-21 05:07:38 +00:00
Hetu Nandu
655b160922
Web worker evaluation (#706) 
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
 2020-10-21 09:55:32 +05:30
Automated Github Action
8ba195416d Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-20 19:07:26 +00:00
Hetu Nandu
7763c9e904
Add retry to Cypress tests (#1322) 2020-10-20 23:51:37 +05:30
Arpit Mohan
06f8c1ab6b Fixing merge conflicts from community edition 2020-10-20 23:18:21 +05:30
Arpit Mohan
47b2ecec83 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-20 22:56:23 +05:30
Arpit Mohan
c89f5179b3 Removing db changelog for mssql 2020-10-20 22:46:59 +05:30
Automated Github Action
8f85e91f9a Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-20 17:07:39 +00:00
Arpit Mohan
a6a8406403 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-20 22:27:49 +05:30
Arpit Mohan
2bb093a5d7 Removing Mssql plugin 2020-10-20 22:27:29 +05:30
Automated Github Action
a61dd3f5f4 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-20 15:08:15 +00:00
Akshay Avinash
4cd2d94f74
Updated positioning of delete icon and eslint error fix (#1304) 2020-10-20 20:29:28 +05:30
Arpit Mohan
0f7f0df790 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-20 19:48:28 +05:30
Arpit Mohan
f507cc8a0e Changing version for commons-validator 2020-10-20 19:47:30 +05:30
Automated Github Action
aefd966aca Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-20 10:08:13 +00:00
Nikhil Nandagopal
5b35d93374 Merge branch 'master' into release 2020-10-20 15:34:01 +05:30
Nikhil Nandagopal
8a97f25b1d
Fix/example apps (#1315) 
* added signup for public apps that are not example apps

* minor fix
 2020-10-20 15:33:21 +05:30
Arpit Mohan
3b49e849e6 Fixing the build for server.yml 2020-10-20 15:06:18 +05:30
Arpit Mohan
eff803d1e7 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-20 14:53:25 +05:30
Arpit Mohan
3164c4a7d6
Fixing the build for mssql plugin (#1313) 2020-10-20 14:52:57 +05:30
Arpit Mohan
087078938c Fixing merge conflicts 2020-10-20 14:46:29 +05:30
akash-codemonk
6a2a36aadb
Update application card colors (#1288) 2020-10-20 14:31:54 +05:30
akash-codemonk
380da11ef0
Query home page with datasource information (#1237) 2020-10-20 14:30:02 +05:30
Hetu Nandu
39d51fdc4c
Fix input navigate test (#1310) 2020-10-20 14:18:38 +05:30
Arpit Mohan
d1713ca802 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-20 13:25:00 +05:30
vicky-primathon
56225d2fdd
Rich text editor content with newline is parsed for RTE (#1296) 2020-10-20 13:24:05 +05:30
Arpit Mohan
6ba5057b81 Adding a condition to only build Docker containers on push and not on pull_request_target 2020-10-20 13:21:22 +05:30
Nikhil Nandagopal
f5abf29cea hotfix for page load actions 2020-10-20 13:15:57 +05:30
Hetu Nandu
83d91b23e8
Fix chunk loading reload issue (#1305) 2020-10-20 12:51:33 +05:30
Arpit Mohan
f080f3e7a0 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-20 12:45:07 +05:30
satbir121
6c1e13a6e9
Revert create new app flow to use the old flow for now (#1265) 2020-10-20 12:44:39 +05:30
Arpit Mohan
783880c856 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-19 23:04:43 +05:30
Arpit Mohan
03f57be51f Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-19 23:04:02 +05:30
Arpit Mohan
31a199c5e5 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-19 23:02:36 +05:30
Arpit Mohan
45e436a7c6 Merging latest master into release 2020-10-19 23:02:24 +05:30
Trisha Anand
603f647e79 Fixing merge conflicts in AuthenticationSuccessHandler 2020-10-19 23:00:07 +05:30
Arpit Mohan
acb2e874dc Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-19 22:56:32 +05:30
Arpit Mohan
be405a4832 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-19 22:51:49 +05:30
Trisha Anand
870a38af1c
[Bug Fix] Removed create_USER event during userCreate because this breaks OAUTH first user login. (#1292) 2020-10-19 22:51:26 +05:30
Automated Github Action
a59aaa5409 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 17:07:35 +00:00
Adam
ff79074fc5
fix\Issues while performing actions on Home Page #749 (#1291) 
Fixes #749
 2020-10-19 21:46:27 +05:30
Arpit Mohan
df3b2f82ae Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-19 19:52:55 +05:30
Arpit Mohan
7cb9583034 Making the request to oauth2 endpoints publicly accessible 2020-10-19 19:52:27 +05:30
Automated Github Action
8fe172f5c2 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 14:08:14 +00:00
vicky-primathon
3ae032de38
Remove RTE intance from tinymce editor instances when component is unmounted (#1076) 
Fixes #785
 2020-10-19 19:10:00 +05:30
Lois Harris
2e6ba8d8fd
[#1136] Fix the Appsmith logo click href (#1255) 
Fixes: #1136
 2020-10-19 19:04:55 +05:30
Automated Github Action
6cbd4117b8 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 13:07:40 +00:00
Sufiyan Gani
f52a2500c1
Added sending email when the role of the member is (#1253) 
Added sending email when the role of a member is changed
 2020-10-19 17:53:12 +05:30
Akshay Avinash
d90d420035
Added no search result image and text on applicaitons (#1240) 2020-10-19 17:41:14 +05:30
Automated Github Action
48026a3e95 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 12:10:30 +00:00
Abhinav Jha
4d9a360f45
Fix keyboard shortcuts on windows and linux machines (#1274) 
* Fix keyboard shortcuts on windows and linux machines

* Update tests for keyboard shortcuts
 2020-10-19 16:56:39 +05:30
Arpit Mohan
8e58822e9a Fixing merge conflicts 2020-10-19 16:43:09 +05:30
Trisha Anand
37aedcba24
User emails should be changed to lower case before creating/inviting user. (#1281) 2020-10-19 16:39:04 +05:30
Shrikant Sharat Kandula
920b38da90
Resolve conflict with master (#1246) 
* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* added binary raw data to be set for files picked (#1211)

* added binary raw data to be set for files picked

* spread options before modifying to maintain immutability

* Add isFromInvite field to create_USER event (#1223)

* Adding dummy commit to trigger build

* added extra information to execute action call (#1244)

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-10-19 16:36:44 +05:30
Nikhil Nandagopal
77e1998e74
updated query template to have an explanatory comment (#1260) 2020-10-19 15:10:21 +05:30
Shrikant Sharat Kandula
a8d5138541
MS SQL Plugin implementation (#1272) 
* Working version of MsSQL plugin

* Add tests for mssql-plugin
 2020-10-19 15:06:08 +05:30
Arpit Mohan
dc698e7d59
Fixing warning message in Github Actions (#1261) 2020-10-19 14:42:25 +05:30
Automated Github Action
db0a23c540 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 09:07:55 +00:00
Abhinav Jha
5c43f5d18d
Update widgetId references to a copied tabs widget's tabs (#1273) 2020-10-19 14:26:04 +05:30
Automated Github Action
b920c159e6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 07:07:55 +00:00
João Rafael
85d5477039
BugFix (#944): Add HTTP prefix to URLs in RestApiPlugin and RapidApiPlugin (#1266) 
Also, add null check before adding HTTP prefix. This avoids null pointer exceptions and lets the UriBuilder deal with it
 2020-10-19 12:19:04 +05:30
Yash Joshi
c085fc778d
Fix evaluated pane scrollbar style (#1251) 
fixes: #1182
 2020-10-19 12:02:07 +05:30
Automated Github Action
9ad9a5d45b Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-19 06:08:56 +00:00
Nikhil Nandagopal
66d15d05c6 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-19 11:12:14 +05:30
Nuwan Sameera Alawatta
f5adc5732b
Fix page name special character bug (#1035) 
* Fix page name special character bug

* update fix page name special character bug

* fix page name ending space
 2020-10-19 10:48:27 +05:30
Automated Github Action
0069e50ad7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-16 15:07:58 +00:00
Akshay Avinash
4e99ab7ace
Fix 781 invalid message on password reset failure (#1234) 
* Updated to add button to redirect to forgot password page
 2020-10-16 19:48:03 +05:30
Nikhil Nandagopal
ec83d0c3fa
added extra information to execute action call (#1244) 2020-10-16 18:09:57 +05:30
Arpit Mohan
2c21246a13 Fixing merge conflicts 2020-10-16 15:02:38 +05:30
NandanAnantharamu
10fe3ba171
Feature/navigate totests (#1187) 
* Adding tests for Navigateto function

* Updated locators and renamed tests
 2020-10-16 14:17:54 +05:30
Arpit Mohan
277b97cf3f Adding dummy commit to trigger build 2020-10-16 13:58:42 +05:30
Arpit Mohan
337db97a18 Adding dummy commit to trigger build 2020-10-16 13:57:18 +05:30
Arpit Mohan
b52d4c3377 Adding dummy commit to trigger build 2020-10-16 13:55:49 +05:30
Arpit Mohan
f8c2fd312e Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-16 13:28:46 +05:30
akash-codemonk
0772bffe23
Create a new input field which outputs a key value pair (#1226) 2020-10-16 13:04:32 +05:30
Automated Github Action
7844e2ae05 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-16 07:07:46 +00:00
Shrikant Sharat Kandula
0055f01f2f
Remove extraneous scrollbars in API action pane (#1222) 2020-10-16 12:28:34 +05:30
Shrikant Sharat Kandula
273a120f1b Add isFromInvite field to create_USER event (#1223) 2020-10-16 12:02:25 +05:30
Shrikant Sharat Kandula
9c04f65901 Add isFromInvite field to create_USER event (#1223) 2020-10-16 12:01:23 +05:30
Pushkar Khedekar
2ac8ec589f
minor fix for column resizing onevent (#1235) 2020-10-16 11:59:50 +05:30
Thakur Karthik
fd9fa46bdd
Fix/fix input size (#1207) 
* fix(codemirror-autocomplete): show selection background on hover for options

This fix if merged shows the selection background by hovering on autocomplete
options.

Ref: #946

* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* fix for removing the extra padding in input field

* Revert "Merge branch 'master' of https://github.com/appsmithorg/appsmith into fix/fix-input-size"

This reverts commit 05a97588f8187c5a9f3146214ef523c30d1370d9, reversing
changes made to 4f70eb61e43c1a9270cb6bd05689820351a5b6e0.

* set scrollbarstyle to null in compact mode

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2020-10-16 11:56:03 +05:30
Automated Github Action
e19cbb6737 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-16 05:07:32 +00:00
Arpit Mohan
9d2b017bf3
Making the nginx root configuration also configurable. (#694) 
This is required for enabling custom logging. In future, we can leverage this for proxy caching as well.

Not adding this nginx-root.conf.template file to the installation script because there's nothing for the user to configure there during installation. This file will be baked into the Dockerfile and only the environment variables will be replaced during container start.
 2020-10-16 10:00:33 +05:30
Arpit Mohan
eddfa25543 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-15 23:36:45 +05:30