Commit Graph

3697 Commits

Author SHA1 Message Date
Pranav Kanade
a14730a453
Fix: intercom triggers are not working properly (#6512)
* initializing the intercom as soon as the help components are mounted.

* removed log
2021-08-11 11:03:11 +05:30
Pranav Kanade
700ed39d33
will widget pane if user moves away from canvas (#6516) 2021-08-10 20:26:56 +05:30
Yash Vibhandik
fddf2aece0
FIX #5254 : dropdown height fixed and made scrollable (#6170) 2021-08-10 18:10:21 +05:30
Hetu Nandu
eba88cdc85
Hotfix Table Widget crashes when there is a cyclical dependency (#6505) 2021-08-10 15:51:27 +05:30
Ashok Kumar M
1e05150ffd
Fix: Adding checks before we check for disallowCopy (#6214)
* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.
2021-08-10 15:42:47 +05:30
Rishabh Rathod
18272550c6
Add Analytics to Generate CRUD template feat (#6503)
* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics
2021-08-10 09:49:39 +00:00
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)
This reverts commit 3ae1bd6d95.
2021-08-10 13:27:29 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) 2021-08-10 12:21:46 +05:30
Rishabh Saxena
1f1e70f473
[Fix] Minor comments feature fixes (#6490)
* Fix skip btn

* update sorting for mentions list
2021-08-10 12:05:08 +06:00
haojin111
f4d4199183
fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380) 2021-08-09 18:21:13 +05:30
Bhavin K
ee33a556d3
changed default divider color to light grey (#6335) 2021-08-09 17:52:17 +05:30
Vicky Bansal
a8871770c1
Fix-Catch invalid google recaptcha v3 key error (#6034)
* Handle invalid google recaptcha v3 key
2021-08-09 17:48:58 +05:30
Nipun Agarwal
22f30d09b0
Added fix for cmd + enter not running google sheets actions (#6446) 2021-08-09 15:47:35 +05:30
Paul Li
a92b7595db
BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)
-- Add a overlaid div for iframe
2021-08-09 15:21:33 +05:30
Pranav Kanade
2ae0c8c836
Feature: Show a list of realtime app editors (#6286)
* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list
2021-08-09 14:34:24 +05:30
Bhavin K
805026176c
changed default image to old value loading from cloudinary (#6467) 2021-08-09 13:44:26 +05:30
Abhijeet
eb7dd49457
[skip_changelog] Form login disabled after user uses OAuth login method (#6425)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-08-09 12:50:06 +05:30
arunvjn
83249275a7
Omnibar redesign (#6288)
Omni bar would now have the categories navigation and documentation.
2021-08-09 11:52:37 +05:30
Pawan Kumar
8546b24839
Fix: List Widget issues (#6226)
* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-09 11:05:01 +05:30
akash-codemonk
48d389fe69
Fix: Parse api body to be shown as an object in debugger if possible (#6249) 2021-08-09 10:57:58 +05:30
Rishabh Saxena
cee509011b
Dont fetch feature flags if not logged in (#6444) 2021-08-07 09:40:06 +05:30
Rishabh Saxena
61820cc180
[Fix] Focus the comment thread when opened after dismissing (#6437) 2021-08-06 12:18:58 +00:00
rahulramesha
e3b141fbef
Prevent Entire Editor Header from re rendering (#6415)
* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-06 16:14:38 +05:30
Rishabh Saxena
d6c10b75f8
Update permission check for determining a user with dev access for comments intro (#6431) 2021-08-06 15:23:05 +05:30
Rishabh Saxena
e4255f6773
Minor fixes for comments on the modal widget (#6368) 2021-08-06 14:47:56 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
dependabot[bot]
e1550477b8
Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)
Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-06 12:46:47 +05:30
Favour Ohanekwu
dd0a413f1f
Fix download with URL issue (#6179) 2021-08-06 10:56:28 +05:30
Rishabh Saxena
eb55385bc6
Fix jest test for comments by overriding isCommentMode selector (#6027) 2021-08-05 22:16:38 +05:30
akash-codemonk
c0364d747b
Fix: Set a default option in select widget while adding from suggested widgets (#6236) 2021-08-05 20:27:08 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
Rishabh Saxena
4bd1ffb324
[Fix] Reset comment mode hotkey (#6401) 2021-08-05 18:57:48 +05:30
Rishabh Saxena
a21375e104
Skip btn comment onboarding (#6331) 2021-08-05 17:36:29 +05:30
Tolulope Adetula
4252af1b20
fix: Font size fixed for consistency between select and multi-select widget (#6400) 2021-08-05 17:29:54 +05:30
Rishabh Saxena
3d9bf77505
[Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407) 2021-08-05 17:23:03 +05:30
Paul Li
4f6a62fa53
Icon Button Widget (#5723)
Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.
2021-08-05 16:46:26 +05:30
Yash Vibhandik
418851fc2a
Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360) 2021-08-05 16:36:04 +05:30
Tolulope Adetula
330cd4a918
fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403) 2021-08-05 16:26:32 +05:30
Pranav Kanade
09c2dfaab1
Fix #5740 - Api actions are treated as queries (#6381)
* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages
2021-08-05 16:24:24 +05:30
NandanAnantharamu
9a4e1aed64
updated common method (#6397) 2021-08-05 15:40:52 +05:30
Rishabh Saxena
114140a64c
Fix ts error release (#6396) 2021-08-05 12:57:33 +05:30
Rishabh Saxena
333408f7b0
Check if comments are enabled for comment intro modal (#6395) 2021-08-05 06:26:27 +00:00
Rishabh Saxena
f0bf799b67
Use feature flag api to enable/disable comments (#6322) 2021-08-05 11:40:19 +05:30
Paul Li
7afb3034bf
BUG : Iframe widget: wrong placeholder Title (#6053)
Rectified the wrong placeholder in the iframe widget title property.
2021-08-05 10:52:27 +05:30
Paul Li
862e9f412e
iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)
* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component
2021-08-05 10:50:02 +05:30
haojin111
eda00479d5
open link inside text component in a new tab (#6205) 2021-08-04 19:04:44 +05:30
haojin111
96e494e38f
changed border radius of multiselect widget to 0px (#6349) 2021-08-04 19:03:32 +05:30
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
Bhavin K
9b6817e97d
close modal on cancel btn click (#6383)
The cancel button in the modal will now by default have the close action configured.
2021-08-04 18:07:46 +05:30
rahulramesha
60c4887432
Navigation Dropdown feedback Changes (#6119)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-04 16:23:04 +05:30
akash-codemonk
f413924fd4
Fix: Keep inspect entity in sync with the widget selection in the entity explorer 2021-08-04 15:36:13 +05:30
Nayan
0d106a5c9d
Improvement: Add limit on password length in user signup (#6312)
* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login
2021-08-04 15:33:33 +06:00
NandanAnantharamu
f5dd307357
updated spec with assertion values (#6323)
* updated spec with assert

* updated test

* updated test

* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action (#6208) 2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test (#6371) 2021-08-04 11:05:16 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
akash-codemonk
63dc8123bb
Fix: Update debugger placeholder text for non-mac (#6142) 2021-08-04 10:20:27 +05:30
Yash Vibhandik
31f8a708ae
FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)
reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished
2021-08-03 19:06:03 +05:30
NandanAnantharamu
cd72098b0d
Commenting test (#6354) 2021-08-03 16:19:45 +05:30
Rishabh Rathod
a9f16d75bd
Enable Autocomplete for Static Objects (#6302)
* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action
2021-08-03 13:36:48 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
Satish Gandham
88c92fd2f5
Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)
* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-02 21:36:33 +05:30
Rishabh Saxena
ce6f42683e
Fix comment card click at the view mode (#6332) 2021-08-02 21:15:19 +05:30
rahulramesha
7252975201
more conditions for run check (#6255)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 19:25:43 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering (#5941)
* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Pranav Kanade
2ca224d444
Updated labels Mock data to Sample data (#6330) 2021-08-02 18:14:56 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
2587d78404
Sentry typeError fix, with checks (#6256)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:46:50 +05:30
rahulramesha
a3152c450c
fix stop Rich text Editor from crashing on Modal (#6077)
* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:45:51 +05:30
Rishabh Saxena
5d6d9f75f4
[Fix] Refresh sidebar comments list when a thread is unresolved (#6326) 2021-08-02 16:05:58 +05:30
Rishabh Saxena
4b79291a7f
Fix comment card click: set visible thread (#6166) 2021-08-02 13:55:35 +05:30
Rishabh Saxena
6ee28950be
Minor comments feature fixes (#6245) 2021-08-02 12:57:20 +05:30
Abhinav Jha
cd8407152c
Missing validations (#6281)
* Fix validations for certain scenarios which were missed earlier
2021-08-02 12:53:46 +05:30
Anagh Hegde
9dbb16747e
Add analytics event for mock-data creation (#6136)
* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-02 08:30:56 +05:30
akash-codemonk
bafab2f254
Fix test by mocking the response (#6273) 2021-07-30 18:33:57 +05:30
yatinappsmith
de1088f84a
Fixed ExecutionParams (#6284) 2021-07-30 18:33:34 +05:30
Abhinav Jha
607012388e
Disable tern in view mode (#6203) 2021-07-30 15:54:22 +05:30
Paul Li
334c092fe4
FEATURE-5852 : make the iframe widget message property accessible (#5897)
-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.
2021-07-30 12:06:00 +05:30
yatinappsmith
a665b943c0
Using local Postgres database instead of remote (#6241)
* Using local Postgres database instead of remote

* Added createdb and usedb at the top
2021-07-30 11:41:14 +05:30
Pranav Kanade
44374f5641
[Fix] Small UI improvements to suggested widgets section (#6190)
* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment
2021-07-30 11:25:11 +05:30
akash-codemonk
7e0ebdd6b0
Add missed new nav analytics for connections (#6233)
* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks
2021-07-30 11:23:24 +05:30
Pranav Kanade
e08b748b02
Fix - #6221 new nav analytics improvements (#6223)
* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards
2021-07-30 11:17:38 +05:30
Rishabh Rathod
fbf6d9ad2d
Add Skip tour button in welcome onboarding (#6158)
This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.
2021-07-29 18:37:26 +05:30
Hetu Nandu
8789c4f897
Fix JS error message showing callstack in firefox (#6234) 2021-07-29 17:06:49 +05:30
Rishabh Saxena
7409982674 Revert "Update msg"
This reverts commit 0ac70ea7e9.
2021-07-29 16:28:47 +05:30
Rishabh Saxena
0ac70ea7e9 Update msg 2021-07-29 16:26:33 +05:30
Rishabh Saxena
96615e11b6
Fix xss redirectURL (#6229) 2021-07-29 08:49:46 +00:00
Rishabh Rathod
76dfcd0163
[Feature] Generate template page from datasource (#5513)
- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-29 13:43:10 +05:30
akash-codemonk
1fc6a21898
Fix overflowing text in toasts on safari (#6200) 2021-07-29 13:42:07 +05:30
Rishabh Saxena
2b60519b7c Merge branch 'release-frozen' into release 2021-07-28 13:11:43 +05:30
Rishabh Saxena
8b4e9af1f0
[hotfix][release-frozen] Fix xss iframe source url (#6212) 2021-07-28 13:03:10 +05:30
Arpit Mohan
4d5b366c43
Merge branch 'master' into release-frozen 2021-07-28 12:59:51 +05:30
Rishabh Saxena
f4018f450e
Comments feature related fixes (#6156) 2021-07-28 12:32:11 +05:30
Pranav Kanade
e84b28e825
added another regex to support short youtube video link format (#6192) 2021-07-28 12:06:46 +05:30
Rishabh Saxena
bec7acdcfc
Fix iframe url xss (#6209) 2021-07-28 11:31:09 +05:30
Rishabh Saxena
8f4db40b0f [Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:44:54 +05:30
Rishabh Saxena
7fa2f7e038 [Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:39:45 +05:30
Rishabh Saxena
8638b6951a
[Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:35:33 +05:30
Favour Ohanekwu
b3de24e3e1
changed texts on datasources page (#6130) 2021-07-27 07:15:49 +01:00
rahulramesha
10ff97b3dc
fix for tabelwidget filter bug (#6001)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-27 10:48:52 +05:30
Satish Gandham
ee3890b4b4
[Perf] Increase the code editor debounce time from 300 to 600ms (#5914)
* - Increase the code editor debounce time from 300 to 1000ms

* Decrease the debounce time from 1000 to 600ms

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-27 10:46:02 +05:30
balajisoundar
f6ae3b2d84
Fix #6084: Fix alignment issue with multiselection checkbox when there are (#6123)
no rows present in the table
2021-07-27 10:33:13 +05:30
Pranav Kanade
3547976dc7
[Feature] new nav sniping mode (#5746)
* added sniping mode toggle option to header

* added cover to components on hover in sniping mode

* fixed the transition time

* using filled icon

* Show dependencies in action pane

* Added a wrapper to make a widget snipeable

* removed older parts of sniping from Positioned Container

* removed onclick action from snipeable wrapper

* Showing widget name in different color

* Added a mechanism to send user to sniping mode from successful API screen

* created new property pane saga to bind the data

* Fix datasource list width issue

* Fix sidebar going out of view when the response is a table

* Minor refactor

* Show add widgets section on the sidebar

* Stop showing autocomplete option after adding a widget

* fetching pageId, appId from store

* Get suggested widget from response

* Fix table data not getting evaluated after adding binding

* Fix property pane going below the entity explorer while navigating from query/api pane

* Fix width of sidepane shifting for apis

* Fix vertical margins of connections

* Fix api pane suggested widget showing up for errors

* Fix margins

* can show select in canvas btn in sidebar

* can get the action object at the end to bind the data

* updated saga and action names

* can bind data to table

* Use themes

* Use new image url for Table widget

* Added conditional mapping for sniping mode binding.

* updated the widget name tags and seq of calls to open property pane

* pushed all sniping mode decoration to header

* moved setting sniping mode logic to editor reducer

* Added keyboard short cut to get out of sniping mode

* updated reset sniping mechanism

* removed a divider line

* if there are no relationships, will not show the complete section

* Connect Data will automatically show relevant tab in integrations

* Update list and dropdown image urls

* Remove create table button

* no wrapping bind to text

* minor review considerations

* showing the widget name to left in sniping mode

* can set data to datepicker

* will not show snipe btn if there are no widgets in canvas

* Changes for multiple suggested widgets

* removed dependency of sniping from suggested widgets

* Added analytics events for sniping mode

* logic for binding data to a widget, moved to snipeable component

* changed binding widget func from capture to onClick and took care of sniping from widget wrapper too.

* added tests to check sniping mode for table

* updated test spec

* minor fix

* Fix copy changes

* Update test to use table widget from suggested widget list

* if fails to bind will generate warning and keep user in sniping mode

* in sniping mode will only show name plate if it is under focus

* fixed the test case

* added a comment

* minor fix to capture on click event in sniping mode

* updated text

* Hide connections UI when there are no connections

* Increase width to 90%

* Show placeholder text and back button in sidepane

* Show tooltip on hover

* Add analyitcs events for suggested widgets and connections

* Update label based on whether widgets are there or not

* binding related changes

* renamed the saga file containing sinping mode sagas

* Changes for inspect entity

* Revert "binding related changes" temporarily

This reverts commit 54ae9667fecf24bc3cf9912a5356d06600b25c84.

* Update suggested widgets url

* Update table url

* Fix chart data field not getting evaluated

* a minor fix to show proper tool tip when user hovers on widget name

* Show sidepane when there is output

* Update locators

* Use constants for messages

* Update file name to ApiRightPane

* Remove delay

* Revert "Revert "binding related changes" temporarily"

This reverts commit ee7f75e83218137250b4b9a28fcf63080c185150.

* Fix width

* Fix overlap

Co-authored-by: Akash N <akash@codemonk.in>
2021-07-26 22:14:10 +05:30
NandanAnantharamu
10f37da2f0
Updated image spec (#6135) 2021-07-26 20:19:42 +05:30
yatinappsmith
54e81e4e33
Add tests for Propertypane drag and drop (#6131) 2021-07-26 19:20:17 +05:30
Pranav Kanade
109039c342
[Feature] Keep the scroll position into a widget when user switches to comment mode (#6132)
* updated the comment overlay to avoid widget re-rendering when user switches to comment mode

* removed duplicate code.
2021-07-26 18:43:20 +05:30
akash-codemonk
56e29d22f5
Add new nav related analytics (#6125)
Analytics events for the following have been added

- Create new datasource CTA on the property pane
- Run button at the response tab for actions
- Click on associated entity dropdown from the property pane
- Select an associated entity from the associated entity dropdown at the property pane
2021-07-26 16:29:15 +05:30
Vicky Bansal
0e6ff2bebe
Fix-Keep date picker open when selecting time, month, year in Table widget filters (#5991)
Keep date-picker open when selecting time or changing month, year in Table filters, The user before this could not select or change time. We have fixed this by closing the date-picker popover onClick of outside overlay/canvas.
2021-07-26 12:29:53 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Rishabh Saxena
5f342cf042
[Fix] Minor omnibar updates (#6097) 2021-07-23 16:53:36 +05:30
arunvjn
3618b85595
Fixed slash button positioning (#6085) 2021-07-23 16:12:48 +05:30
Tolulope Adetula
fa76a9a6e9
fix: File picker disabled state (#5972)
The filepicker in the disable sate was still able to upload the file. Fixed the issue here.
2021-07-23 14:42:51 +05:30
balajisoundar
0bd9753fef
Fix #5075 Retain search keyword and search results when user navigates (#6091)
away from homepage and comes back.
2021-07-23 13:01:16 +05:30
rahulramesha
f5e079f040
[Perf] prevent un-necessry re-renders of resizable Component on property control keyPress (#5885)
prevent un-necessry re-renders of resizable Component on property control keyPress
2021-07-23 12:10:39 +05:30
NandanAnantharamu
3d88ebf490 updated spec to wait for postexecute (#6042) 2021-07-22 20:14:01 +05:30
Yash Vibhandik
a0c9ecb2a5
FIX #3229 : added new props shortcuts and closeOnSelection for smooth interactions (#5276)
In the date picker widget we now have an option to let the date picker popup remain open until the a positive feedback is given by clicking outside the popup or another widget. In other words the date-picker popup will not close where a date is selected with `closeOnSelection` disabled. 

We have also added an option to show date-picker shortcuts to the end user.
2021-07-22 18:16:41 +05:30
Hetu Nandu
6ed618306b Fix action binary transformation (#6075) 2021-07-22 17:34:24 +05:30
Hetu Nandu
9f89b0d42c
Fix action binary transformation (#6075) 2021-07-22 17:33:04 +05:30
Arpit Mohan
d7b258f474 Fixing duplicate enum in ActionExecutionSaga which may have been caused due to a bad merge 2021-07-22 16:20:05 +05:30
Apeksha Bhosale
8d844e3961
changed the logic for tern server def creation (#6071) 2021-07-22 16:19:41 +05:30
Arpit Mohan
634092586b
Merge branch 'master' into release-frozen 2021-07-22 15:21:08 +05:30
Bhavin K
c23925c0c9
handle image download error (#5951)
Fixed an issue where because of the CORS issue the image was not able to download, To fix this we now open the image in a new tab where an error is received.
2021-07-22 14:15:45 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Bhavin K
bd05ab5dc7
fix when component update (#5931)
The custom chart onDataPointClick did not function well in the editor and view more, This is now fixed
2021-07-22 14:11:18 +05:30
Pranav Kanade
22bec1fce7
[Feature] Authenticated API datasource creation (#6017)
* added an oauth datasource tab

* added a comment

* removed warnings

* updated authenticated datasource name

* added a test case to verify new authenticated api card

* can create a simple rest api datasource

* enabled the use of view mode for rest api datasources

* minor fix for centered icons

* added analytics event
2021-07-22 13:25:13 +05:30
akash-codemonk
f1e829fe4a
Feature: Show error state in property pane connections if associated connection has errors (#5877) 2021-07-21 18:10:46 +05:30
NandanAnantharamu
2477c1f5ac
updated spec to wait for postexecute (#6042) 2021-07-21 16:02:40 +05:30
akash-codemonk
89000efffd
Fix: Fix horizontal scroll on overflow in property pane (#5909) 2021-07-21 13:23:14 +05:30
Rishabh Saxena
cf1e5dda19 Fixes related to the comments feature (#5904) 2021-07-21 11:34:57 +05:30
Hetu Nandu
7063ee9d2d
Improve information for cyclic dependency error (#5949) 2021-07-20 16:20:22 +05:30
Rishabh Saxena
745927ffef
Set focused comment based on url and visible thread id (#5992) 2021-07-20 15:44:35 +05:30
Hetu Nandu
ba06d797de
Improve autocomplete sorting (#5798) 2021-07-20 15:32:56 +05:30
Satish Gandham
93c675ba92
Provent property pane title from re-rendering on every state change #5867 (#5876)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-20 12:14:15 +05:30
Tolulope Adetula
32c746d6fe
fix: Menu button truncating (#5970)
The widget tag of menu button widget was broken and overflowing, We fixed that here
2021-07-20 12:09:17 +05:30
Arpit Mohan
9f29dd028d
Improving error message for invalid entities (#5977)
Also removing the toast message for successful action runs. With the debugger, this is no longer required.
2021-07-20 11:07:20 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30
Satish Gandham
fb78233973
[perf] Update redux store with only the values that changed (#5594)
* Pass evaluation order along with dataTree and update only evaluated values in the store.

* - Update the entire changed entitiy

* Make the updates in a way the top level tree reference is changed.

* Clean up.

* - Revert back to using evaluation order and removedPaths as JSON.stringify is expensive

* yarn.lock changes

* Only send eval updates across the worker thread

* - Update the tree with only the updates sent from the worker. (40% improvement)

* Fix evaluation tests

* Remove console.log

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-07-20 10:34:12 +05:30
akash-codemonk
8657a52f09
Fix: Fix create new query in onsubmit not creating a query for onboarding (#5918) 2021-07-20 09:44:32 +05:30
Nayan
6efe78479f
[Enhancement] Add link to unsubscribe from email notification for a comment thread (#5769)
* -added API to and template for unsubscribe  comment thread

* -changed public API url to make it sepratate from client public pages
-included the unsubscribe link to email body

* -made unsubscribe email notification API to private

* -added unsubscribe page

* -removed unused code

* Update app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Comments/UnsubscribeEmail_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/BaseAppsmithRepositoryImpl.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* -updated text as per lint error

* -updated text as per lint error

* -moved unsubscribe screen texts to messages.ts

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-07-20 00:14:38 +06:00
Ayush Pahwa
9560df8492 Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 21:07:44 +05:30
Ayush Pahwa
2cee1b5a7c Added axios call to the special use case of downloading zip files (#5927)
* Added axios call to the special use case of downloading zip files

* Removed console logs, added comments, fixed error handling

* Removed url check from getType, exported a fn to check tif string is a URL

* Changed filter from only zip to binary
2021-07-19 21:07:21 +05:30
Ayush Pahwa
5f950c4080 Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 21:03:49 +05:30
Rishabh Saxena
25a6fd2240
Fixes related to the comments feature (#5904) 2021-07-19 20:58:41 +05:30
Ayush Pahwa
cab6c12471
Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 20:13:37 +05:30
Rishabh Saxena
488e7e20df [Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 19:02:40 +05:30
Rishabh Saxena
7f95e4d268 Enable intercom for self hosted instances (#5871) 2021-07-19 19:02:06 +05:30
Rishabh Saxena
dff61da5ac [Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 18:56:08 +05:30
Rishabh Saxena
6947f4b7a0
[Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 17:36:04 +05:30
Rishabh Saxena
dc012be1de
Enable intercom for self hosted instances (#5871) 2021-07-19 15:34:15 +05:30