Commit Graph

210 Commits

Author SHA1 Message Date
NandanAnantharamu
530735e13f
test: CypressNewVersion (#6116)
* Upgrade Cypress Version

* Upgrade to 7.6

* update moment library with Dayjs

* updated a test

* Added tests for copy to clipboard

* Added a missing dsl
2021-08-25 19:31:04 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
arslanhaiderbuttar
8380299958
fix: chart widget fix (#6867)
Custom fusion chart was loading with some delay and cypress test cases were getting previous element to verify the x axis data. Added one more check to wait till the chart data is loaded before verifying.
2021-08-25 15:42:41 +05:00
akash-codemonk
95c60bafeb
fix: Hide debugger errors until onPageLoadActions are run (#6786) 2021-08-25 10:04:42 +05:30
Paul Li
cb4242e7e5
Feat: Style customisation in the button widget (#6052)
Added multiple style props to the button widget:
- Button styles
- The background colour can change with a hex code
- elevation (box-shadow & colour)
- There are button variant contained (solid button), outlined (only borders), text (text buttons)
- Button can have an end icon or start icon
2021-08-24 19:23:15 +05:30
Ashok Kumar M
971cc35e7f
[Feature] Click on widget will no longer open property pane (#6219)
* [Feature] Click on widget will no longer open property pane

* fixing test cases

* coverage fixes

* fixing imports.

* fixing build failure.

* fixing new specs

* clear property pane state for any new selection.
2021-08-23 19:42:17 +05:30
Pranav Kanade
6782bf6b85
fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) 2021-08-23 14:46:25 +05:30
NandanAnantharamu
0e5816d413
Fix/chart spec (#6774)
* updated Chart spec with a wait for route

* updated Chart spec with a wait for route
2021-08-23 14:02:53 +05:30
akash-codemonk
a42938c139
Expand all debugger errors by default (#6676) 2021-08-23 11:57:23 +05:30
arslanhaiderbuttar
01e5d8d839
Table UI test cases (#5910)
* TableUITestCases

Commit

* Table-widget-testcases

On Search Text Change Action
Default array data
On Row Selected Action
Explore Widget related documents Verification
On Page Change Action
Default search text
Default selected row
Delete Table Widget
Changing Column data type to "Image"
Changing Column data type to "URL"
Table Widget Functionality To Verify Row Height Functionality
Drage and Drop Table widget and verify default data
Table Widget Functionality To Filter The Data using 'Empty
Table Widget Functionality To Filter The Data using 'Not Empty'

* Discarded changes in cypress.json

Discarded changes in cypress.json

* Updated the test cases

* Undo changes to Cypress.json

Undo changes to Cypress.json

* Added new dsl json file

* Merge branch 'release' into SelectUITestCases

* table test cases fix

Co-authored-by: arslan <>
2021-08-21 12:34:23 +05:00
Rishabh Rathod
12e7ee0c94
Add s3 support for generate CRUD (#6264)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Add useS3BucketList hook WIP

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Add Query to get all S3 buckets

* Fix dropdown open issue

* Remove defaultIsOpen prop from dropdown

* Resolve comments
- Remove debugger
- mockSheetUrl -> getSheetUrl

* Add S3 cypress test

* Fix cypress test yml config

* Fix generate page cypress test
2021-08-20 12:27:01 +05:30
Bhavin K
3741bc160e
Added series title (internal property) to the chart widget selectedDataPoint (#6104) 2021-08-18 12:41:07 +05:30
Bhavin K
3270d6c7ba
Input widget enhancements (#5670)
Many new input widget enhancement added. The widget now has the capability to have its own label and tooltip as helper. The user can now add Icons inside the input widget and align them as well, The user can allow choose the max allowed length of the input. We have also added the isValid property in tandem to the regex property for additional validations using JS expressions
2021-08-17 16:38:04 +05:30
Paul Li
532e8f2a74
Feature : Checkbox Group widget (#6199)
Introducing a new widget: `Checkbox Group`, Users can now create a group of checkboxes and have an action trigger and also be able to refer the selected values from the internal API.
2021-08-17 14:41:38 +05:30
Favour Ohanekwu
f0c7ce0e89
Feature/option to upload file or text in multipart form (#6534)
* added option to multipart form data for file or text upload

* updated styles for the dynamic-text-field-with-dropdown styled component

* added cypress tests for multipart body type

* code refactor: moved constants to ApiEditorConstants.ts

* updated multipart dropdown styles

* minor bug fix
2021-08-16 13:00:11 +01:00
arslanhaiderbuttar
273b2d902f
Update Button_spec.js (#6474)
* Update Button_spec.js

Button widget issue has been fixed.

* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. (#5389)
* dip

* dip

* scroll

* fixes

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* solve for canvas glitches

* dip

* dip

* dip

* adjust scroll speed

* dip

* dip(code clean up)

* dip

* dip

* ---dip

* dip

* dip

* dip

* middle ware for dropping multiple widgets.

* adding scroll to drag for canvas selection.

* fixing drag disabled and modal widget(detach from layout) drops

* firefox and safari fixes

* rebase conflicts.

* fixing broken specs.

* fixing specs and adding jest tests.

* show border and disable resize when multiple widgets are selected.

* selection box grab cursor

* merge conflicts.

* code clean up

* fixing specs.

* fixed a bug and failed specs.

* fixing rerenders.

* code clean up

* code review comments

* always have the drag point inside the widget.

* fetching snap spaces instead of calculating.

* remove widget_move action

* fixing bugs with add widget parent height updation.

* fixing specs.

* List widget conflict fixes.

* fixing canvas drop persistence.

* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
3a41ab1f17
Added test for Navigate To feature (#6531)
* Added test for Navigate To feature

* updated test title
2021-08-12 11:01:20 +05:30
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) 2021-08-10 12:21:46 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
NandanAnantharamu
f5dd307357
updated spec with assertion values (#6323)
* updated spec with assert

* updated test

* updated test

* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action (#6208) 2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test (#6371) 2021-08-04 11:05:16 +05:30
NandanAnantharamu
cd72098b0d
Commenting test (#6354) 2021-08-03 16:19:45 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
yatinappsmith
de1088f84a
Fixed ExecutionParams (#6284) 2021-07-30 18:33:34 +05:30
Rishabh Rathod
76dfcd0163
[Feature] Generate template page from datasource (#5513)
- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-29 13:43:10 +05:30
Rishabh Saxena
bec7acdcfc
Fix iframe url xss (#6209) 2021-07-28 11:31:09 +05:30
Pranav Kanade
3547976dc7
[Feature] new nav sniping mode (#5746)
* added sniping mode toggle option to header

* added cover to components on hover in sniping mode

* fixed the transition time

* using filled icon

* Show dependencies in action pane

* Added a wrapper to make a widget snipeable

* removed older parts of sniping from Positioned Container

* removed onclick action from snipeable wrapper

* Showing widget name in different color

* Added a mechanism to send user to sniping mode from successful API screen

* created new property pane saga to bind the data

* Fix datasource list width issue

* Fix sidebar going out of view when the response is a table

* Minor refactor

* Show add widgets section on the sidebar

* Stop showing autocomplete option after adding a widget

* fetching pageId, appId from store

* Get suggested widget from response

* Fix table data not getting evaluated after adding binding

* Fix property pane going below the entity explorer while navigating from query/api pane

* Fix width of sidepane shifting for apis

* Fix vertical margins of connections

* Fix api pane suggested widget showing up for errors

* Fix margins

* can show select in canvas btn in sidebar

* can get the action object at the end to bind the data

* updated saga and action names

* can bind data to table

* Use themes

* Use new image url for Table widget

* Added conditional mapping for sniping mode binding.

* updated the widget name tags and seq of calls to open property pane

* pushed all sniping mode decoration to header

* moved setting sniping mode logic to editor reducer

* Added keyboard short cut to get out of sniping mode

* updated reset sniping mechanism

* removed a divider line

* if there are no relationships, will not show the complete section

* Connect Data will automatically show relevant tab in integrations

* Update list and dropdown image urls

* Remove create table button

* no wrapping bind to text

* minor review considerations

* showing the widget name to left in sniping mode

* can set data to datepicker

* will not show snipe btn if there are no widgets in canvas

* Changes for multiple suggested widgets

* removed dependency of sniping from suggested widgets

* Added analytics events for sniping mode

* logic for binding data to a widget, moved to snipeable component

* changed binding widget func from capture to onClick and took care of sniping from widget wrapper too.

* added tests to check sniping mode for table

* updated test spec

* minor fix

* Fix copy changes

* Update test to use table widget from suggested widget list

* if fails to bind will generate warning and keep user in sniping mode

* in sniping mode will only show name plate if it is under focus

* fixed the test case

* added a comment

* minor fix to capture on click event in sniping mode

* updated text

* Hide connections UI when there are no connections

* Increase width to 90%

* Show placeholder text and back button in sidepane

* Show tooltip on hover

* Add analyitcs events for suggested widgets and connections

* Update label based on whether widgets are there or not

* binding related changes

* renamed the saga file containing sinping mode sagas

* Changes for inspect entity

* Revert "binding related changes" temporarily

This reverts commit 54ae9667fecf24bc3cf9912a5356d06600b25c84.

* Update suggested widgets url

* Update table url

* Fix chart data field not getting evaluated

* a minor fix to show proper tool tip when user hovers on widget name

* Show sidepane when there is output

* Update locators

* Use constants for messages

* Update file name to ApiRightPane

* Remove delay

* Revert "Revert "binding related changes" temporarily"

This reverts commit ee7f75e83218137250b4b9a28fcf63080c185150.

* Fix width

* Fix overlap

Co-authored-by: Akash N <akash@codemonk.in>
2021-07-26 22:14:10 +05:30
NandanAnantharamu
10f37da2f0
Updated image spec (#6135) 2021-07-26 20:19:42 +05:30
yatinappsmith
54e81e4e33
Add tests for Propertypane drag and drop (#6131) 2021-07-26 19:20:17 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
akash-codemonk
f1e829fe4a
Feature: Show error state in property pane connections if associated connection has errors (#5877) 2021-07-21 18:10:46 +05:30
NandanAnantharamu
2477c1f5ac
updated spec to wait for postexecute (#6042) 2021-07-21 16:02:40 +05:30
Hetu Nandu
ba06d797de
Improve autocomplete sorting (#5798) 2021-07-20 15:32:56 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30
akash-codemonk
8657a52f09
Fix: Fix create new query in onsubmit not creating a query for onboarding (#5918) 2021-07-20 09:44:32 +05:30
Nayan
6efe78479f
[Enhancement] Add link to unsubscribe from email notification for a comment thread (#5769)
* -added API to and template for unsubscribe  comment thread

* -changed public API url to make it sepratate from client public pages
-included the unsubscribe link to email body

* -made unsubscribe email notification API to private

* -added unsubscribe page

* -removed unused code

* Update app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Comments/UnsubscribeEmail_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/BaseAppsmithRepositoryImpl.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* -updated text as per lint error

* -updated text as per lint error

* -moved unsubscribe screen texts to messages.ts

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-07-20 00:14:38 +06:00
NandanAnantharamu
d80bb7a31b
Fix checkbox spec Cypress test (#5952) 2021-07-19 15:28:34 +05:30
Vicky Bansal
fad7874613
Currency datatype in Input Widget (#5049)
Added currency type input to input widget
2021-07-15 18:20:01 +05:30
Rishabh Saxena
cb91221276
Fix globalsearch test: wait for page load (#5883) 2021-07-15 17:10:54 +05:30
rahulramesha
3042adbdea
Task/5463 Navigation Bar menu Dropdown (#5575)
* Feature/ Navigation Bar menu

* Cypress test fixes and minor style changes

* Changed some more integration test files and fixed some styling post feedback

* Updated failing tests

* Minor Cypress test change

* requested design changes and Analytics

* resolving conflicts

* minor style fix

* current deploy verbage change

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

* addressing review comments

* Updating discord link with permanent invite

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-15 16:26:18 +05:30
Yash Vibhandik
c7577a23f0
FIX #4676 : added onclick handler and update property pane config to table widget for column type image
added onclick handler and update property pane config to table widget for column type image

* added default value for onclick and remove extra check

* updated TableUtilities test case

* updated cypress test Table_spec
2021-07-09 17:51:51 +05:30
NandanAnantharamu
763f9ac77c
Fixing Flaky tests (#5578)
* Fix flaky Org tests

* updated log spec

* Removed unwanted calls
2021-07-09 12:41:07 +05:30
NandanAnantharamu
eea53bc1e0
Fix image widget spec for property pane click changes (#5707) 2021-07-09 10:22:57 +05:30
Hetu Nandu
0c0e165ee0
Improve Codemirror mount performance (#5497) 2021-07-08 12:34:47 +05:30