Commit Graph

637 Commits

Author SHA1 Message Date
NandanAnantharamu
530735e13f
test: CypressNewVersion (#6116)
* Upgrade Cypress Version

* Upgrade to 7.6

* update moment library with Dayjs

* updated a test

* Added tests for copy to clipboard

* Added a missing dsl
2021-08-25 19:31:04 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
arslanhaiderbuttar
8380299958
fix: chart widget fix (#6867)
Custom fusion chart was loading with some delay and cypress test cases were getting previous element to verify the x axis data. Added one more check to wait till the chart data is loaded before verifying.
2021-08-25 15:42:41 +05:00
Favour Ohanekwu
aca5bd78b1
fix: inclusion of authorization error for Google sheets (#6674)
* Added authorisation status to Google sheet datasource form
2021-08-25 11:36:55 +01:00
akash-codemonk
95c60bafeb
fix: Hide debugger errors until onPageLoadActions are run (#6786) 2021-08-25 10:04:42 +05:30
Paul Li
cb4242e7e5
Feat: Style customisation in the button widget (#6052)
Added multiple style props to the button widget:
- Button styles
- The background colour can change with a hex code
- elevation (box-shadow & colour)
- There are button variant contained (solid button), outlined (only borders), text (text buttons)
- Button can have an end icon or start icon
2021-08-24 19:23:15 +05:30
yatinappsmith
aa869f21ab
test: Added Support for MySQL (#6795)
* Added Support for MySQL

* Update setup-test.sh

fixed sql file

* Update setup-test.sh

Fixed path
2021-08-24 14:16:52 +05:30
Ashok Kumar M
971cc35e7f
[Feature] Click on widget will no longer open property pane (#6219)
* [Feature] Click on widget will no longer open property pane

* fixing test cases

* coverage fixes

* fixing imports.

* fixing build failure.

* fixing new specs

* clear property pane state for any new selection.
2021-08-23 19:42:17 +05:30
Pranav Kanade
6782bf6b85
fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) 2021-08-23 14:46:25 +05:30
NandanAnantharamu
0e5816d413
Fix/chart spec (#6774)
* updated Chart spec with a wait for route

* updated Chart spec with a wait for route
2021-08-23 14:02:53 +05:30
akash-codemonk
a42938c139
Expand all debugger errors by default (#6676) 2021-08-23 11:57:23 +05:30
arslanhaiderbuttar
01e5d8d839
Table UI test cases (#5910)
* TableUITestCases

Commit

* Table-widget-testcases

On Search Text Change Action
Default array data
On Row Selected Action
Explore Widget related documents Verification
On Page Change Action
Default search text
Default selected row
Delete Table Widget
Changing Column data type to "Image"
Changing Column data type to "URL"
Table Widget Functionality To Verify Row Height Functionality
Drage and Drop Table widget and verify default data
Table Widget Functionality To Filter The Data using 'Empty
Table Widget Functionality To Filter The Data using 'Not Empty'

* Discarded changes in cypress.json

Discarded changes in cypress.json

* Updated the test cases

* Undo changes to Cypress.json

Undo changes to Cypress.json

* Added new dsl json file

* Merge branch 'release' into SelectUITestCases

* table test cases fix

Co-authored-by: arslan <>
2021-08-21 12:34:23 +05:00
Rishabh Rathod
652950d239
Add Gsheets support for generate CRUD page (#6301)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Fix issues related to dropdown

* Add hooks to fetch sheets and spreadsheets

* Resolve warnings

* complete gheets basic support

* Add UI changes for Gsheet column names
- Fix Page Scroll issue

* Add debounce to avoid to many API calls

* Add request object formation via plugin config

* Resolve comments & remove executingDatasourceQuery

* Send sheetName in the tableName key.

* Add loader and Column name UI Fix

* Add Column Headers Label

* Fix logic to show comma separator btn column names
- Make "Column Header Fetched" text Bold

* Add tooltip info for searchable column

* Add value prop to TextInput
- Fix Table header Index Invalid Input issue

* Hotfix validator logic
2021-08-20 15:25:59 +05:30
Abhijeet
163c7cde71
Update template application file to fix failing cypruss TC (#6758) 2021-08-20 14:51:17 +05:30
Rishabh Rathod
12e7ee0c94
Add s3 support for generate CRUD (#6264)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Add useS3BucketList hook WIP

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Add Query to get all S3 buckets

* Fix dropdown open issue

* Remove defaultIsOpen prop from dropdown

* Resolve comments
- Remove debugger
- mockSheetUrl -> getSheetUrl

* Add S3 cypress test

* Fix cypress test yml config

* Fix generate page cypress test
2021-08-20 12:27:01 +05:30
Anagh Hegde
e76d8c2c15
Change the name of the mock datasource (#6498)
* Change the name of the mock datasource

* Remove the hardcoded value for Cloud services

* Handle index out of exception

* Add check if the response contains necessary credentials for mockdb

* Change as per review comments

* Fix cypress test failures

* minor changes to fix cypress test for mock data according to new changes

* updated mock data locator

* Update the mockdata source name

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-19 17:53:30 +05:30
Abhijeet
9677a4fb8f
[Skip_changelog] Enable S3 and GSheet from backend for generate CRUD page (#6706)
* Update appsmithVersion for static json file used in import application cypruss test
2021-08-19 12:04:14 +05:30
Bhavin K
3741bc160e
Added series title (internal property) to the chart widget selectedDataPoint (#6104) 2021-08-18 12:41:07 +05:30
Bhavin K
3270d6c7ba
Input widget enhancements (#5670)
Many new input widget enhancement added. The widget now has the capability to have its own label and tooltip as helper. The user can now add Icons inside the input widget and align them as well, The user can allow choose the max allowed length of the input. We have also added the isValid property in tandem to the regex property for additional validations using JS expressions
2021-08-17 16:38:04 +05:30
Paul Li
532e8f2a74
Feature : Checkbox Group widget (#6199)
Introducing a new widget: `Checkbox Group`, Users can now create a group of checkboxes and have an action trigger and also be able to refer the selected values from the internal API.
2021-08-17 14:41:38 +05:30
Abhijeet
c3f7bea904
Add version check for import-export flow (#6552)
* Added version check

* Added error message for version check while importing the file

* Added TC to check version in exported file

* Added version in FE assets for cypruss test
2021-08-16 21:32:51 +05:30
Favour Ohanekwu
f0c7ce0e89
Feature/option to upload file or text in multipart form (#6534)
* added option to multipart form data for file or text upload

* updated styles for the dynamic-text-field-with-dropdown styled component

* added cypress tests for multipart body type

* code refactor: moved constants to ApiEditorConstants.ts

* updated multipart dropdown styles

* minor bug fix
2021-08-16 13:00:11 +01:00
Favour Ohanekwu
30c11e4a74
fix cypress mockdatasource flaky test (#6624) 2021-08-16 12:24:17 +01:00
Favour Ohanekwu
11385092ca
Hotfix/trailing white spaces in mysql datasource configuration (#6227)
* trimmed white spaces in datasource configuration

* Added cypress tests for MySQLdatasource

* fixed trailing whitespaces bug in mysql datasource configuration

* Fix overflowing text in toasts on safari (#6200)

* [Feature] Generate template page from datasource  (#5513)

- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Fix xss redirectURL (#6229)

* Update msg

* Revert "Update msg"

This reverts commit 0ac70ea7e9.

* Fix JS error message showing callstack in firefox (#6234)

* Adding expiry of 30 days to session cookies (#6224)

Fixes #5872

Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed.

* Removing release-drafter github action (#6248)

* Add Skip tour button in welcome onboarding (#6158)

This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.

* Fix - #6221 new nav analytics improvements (#6223)

* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards

* Add missed new nav analytics for connections (#6233)

* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks

* [Fix] Small UI improvements to suggested widgets section (#6190)

* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment

* Fix NPE when Segment key not available correctly (#6244)

* Using local Postgres database instead of remote (#6241)

* Using local Postgres database instead of remote

* Added createdb and usedb at the top

* FEATURE-5852 : make the iframe widget message property accessible (#5897)

-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.

* Disable tern in view mode (#6203)

* Fixed ExecutionParams (#6284)

* Fix test by mocking the response (#6273)

* added cypress tests for users mock datasource

* Fix: Mark comment threads as viewed when they are resolved (#6251)

* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type

* Add analytics event for mock-data creation (#6136)

* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Missing validations (#6281)

* Fix validations for certain scenarios which were missed earlier

* Minor comments feature fixes (#6245)

* Fix comment card click: set visible thread (#6166)

* Fixing bug where the comment feature flag was disabled for all users

* [Fix] Refresh sidebar comments list when a thread is unresolved (#6326)

* fix stop Rich text Editor from crashing on Modal (#6077)

* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Sentry typeError fix, with checks (#6256)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Supporting all ASCII characters in table widget (#6041)

* Updated labels Mock data to Sample data (#6330)

* [perf] propertyControl re-rendering (#5941)

* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Snowflake get structure error resolved for columns query (#6316)

* Table name reference copied from templates body to avoid misconfiguration in action body

* more conditions for run check (#6255)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Fix comment card click at the view mode (#6332)

* Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)

* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>

* Multiselect Widget (#5228)

We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.

* Added instance Id in analytics datapoint (#6252)

* Enable Autocomplete for Static Objects (#6302)

* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action

* updated cypress tests to account for testing trailing spaces in db name and host address

* removed unparsed token

* Commenting test (#6354)

* Add list buckets API to S3 (#6334)

* Add list buckets action method to S3

* Added TC for list bucket method

* FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)

 reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished

* Added null check to verify empty layout in generate CRUD page flow (#6359)

* Fix authentication issue while creating mockdata (#6294)

* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password

* updated cypress tests for mock datasource

* fixed cypress failing datasources tests

* Fix: Update debugger placeholder text for non-mac (#6142)

* Added logic to show form data requests in debugger (#6350)

* Added logic to show form data requests in debugger

* Tests and comments

* Tests

* Tern server performance fix and Best match fix (#6338)

* Uncomment Gen CRUD page Test (#6371)

* Reorganised test steps to utilise retry action (#6208)

* updated spec with assertion values (#6323)

* updated spec with assert

* updated test

* updated test

* updated dsl

* Improvement: Add limit on password length in user signup (#6312)

* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login

* Fix binding query for the nested data responses (#6372)

* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications

* Fix: Keep inspect entity in sync with the widget selection in the entity explorer

* docs: Updates event archive

* Navigation Dropdown feedback Changes (#6119)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Feature: Add API to set and get concurrent app editors (#6292)

* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts

* close modal on cancel btn click (#6383)

The cancel button in the modal will now by default have the close action configured.

* Button and chart fixes (#6373)

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* changed border radius of multiselect widget to 0px (#6349)

* open link inside text component in a new tab (#6205)

* Fix loading test data for Cypress tests in CodeBuild

* Change dropdown widget to select widget in Github labels for automation to work properly (#6386)

* Updating k8s README to point to docs.appsmith.com

* iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)

* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component

* BUG : Iframe widget: wrong placeholder `Title` (#6053)

Rectified the wrong placeholder in the iframe widget title property.

* Use feature flag api to enable/disable comments (#6322)

* Check if comments are enabled for comment intro modal (#6395)

* Fix ts error release (#6396)

* updated common method (#6397)

* Fix #5740 - Api actions are treated as queries (#6381)

* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages

* fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403)

* Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360)

* Icon Button Widget (#5723)

Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.

* [Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407)

* fix: Font size fixed for consistency between select and multi-select widget (#6400)

* Skip btn comment onboarding (#6331)

* [Fix] Reset comment mode hotkey (#6401)

* Welcome tour GIF and Close button fixes (#6309)

* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants

* Fix: Set a default option in select widget while adding from suggested widgets (#6236)

* Fix jest test for comments by overriding isCommentMode selector (#6027)

* Fix download with URL issue  (#6179)

* Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)

Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update CRUD template For S3 page (#6426)

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>

* Cypress tests for commenting feature (#5505)

* Minor fixes for comments on the modal widget (#6368)

* Update permission check for determining a user with dev access for comments intro (#6431)

* Prevent Entire Editor Header from re rendering (#6415)

* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* [Fix] Focus the comment thread when opened after dismissing (#6437)

* Dont fetch feature flags if not logged in (#6444)

* Update README.md

Fixed a spelling mistake

* Fix: Parse api body to be shown as an object in debugger if possible (#6249)

* Fix: List Widget issues (#6226)

* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>

* [Bugfix] Empty object creation in published pages for application object fixed

* Omnibar redesign (#6288)

Omni bar would now have the categories navigation and documentation.

* [skip_changelog] Form login disabled after user uses OAuth login method (#6425)

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* changed default image to old value loading from cloudinary (#6467)

* Feature: Show a list of realtime app editors (#6286)

* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list

* Enable auto-start after VM restart (#6428)

* BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)

-- Add a overlaid div for iframe

* Added fix for cmd + enter not running google sheets actions (#6446)

* Fix-Catch invalid google recaptcha v3 key error (#6034)

* Handle invalid google recaptcha v3 key

* changed default divider color to light grey (#6335)

* fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380)

* Add null check for the nested data structure (#6479)

* Add null check for the nested data structure

* Add unit test for the null nested data

* Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)

* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup

* [Fix] Minor comments feature fixes (#6490)

* Fix skip btn

* update sorting for mentions list

* Show server logs when create cypress user fails

* [Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477)

* Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)

This reverts commit 3ae1bd6d95.

* Updated flaky test (#6486)

* Updated flaky test

* updated another test

* Store MongoDB creds in separate file from install.sh (#6499)

* Store MongoDB creds in separate file from install.sh

* Move MongoDB credentials to docker.env

* Add Analytics to Generate CRUD template feat (#6503)

* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics

* Fix: Adding checks before we check for disallowCopy (#6214)

* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.

* Hotfix Table Widget crashes when there is a cyclical dependency (#6505)

* FIX #5254 : dropdown height fixed and made scrollable (#6170)

* will widget pane if user moves away from canvas (#6516)

* Fix: intercom triggers are not working properly (#6512)

* initializing the intercom as soon as the help components are mounted.

* removed log

* Fix: Undo-Delete of Containers fix (#6510)

* Encrypt attributes (#6508)

* encrypt attributes

* updated references to DOM targets for accessing the Mock User datasource

* Fix/omnibar landing bug (#6513)

* hide certificate string using dots on UI (#6533)

* replace actual certificate string with '*' like it is done for hiding password on the UI.

* Updated Template

* fixed failing cypress tests

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Confidence Okoghenun <cokoghenun@gmail.com>
Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com>
Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: abhishek nayak <nayak.abhishek@gmail.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Nipun Agarwal <31271538+nipun1999@users.noreply.github.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2021-08-13 09:42:29 +01:00
arslanhaiderbuttar
273b2d902f
Update Button_spec.js (#6474)
* Update Button_spec.js

Button widget issue has been fixed.

* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. (#5389)
* dip

* dip

* scroll

* fixes

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* solve for canvas glitches

* dip

* dip

* dip

* adjust scroll speed

* dip

* dip(code clean up)

* dip

* dip

* ---dip

* dip

* dip

* dip

* middle ware for dropping multiple widgets.

* adding scroll to drag for canvas selection.

* fixing drag disabled and modal widget(detach from layout) drops

* firefox and safari fixes

* rebase conflicts.

* fixing broken specs.

* fixing specs and adding jest tests.

* show border and disable resize when multiple widgets are selected.

* selection box grab cursor

* merge conflicts.

* code clean up

* fixing specs.

* fixed a bug and failed specs.

* fixing rerenders.

* code clean up

* code review comments

* always have the drag point inside the widget.

* fetching snap spaces instead of calculating.

* remove widget_move action

* fixing bugs with add widget parent height updation.

* fixing specs.

* List widget conflict fixes.

* fixing canvas drop persistence.

* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
3a41ab1f17
Added test for Navigate To feature (#6531)
* Added test for Navigate To feature

* updated test title
2021-08-12 11:01:20 +05:30
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) 2021-08-10 12:21:46 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
NandanAnantharamu
9a4e1aed64
updated common method (#6397) 2021-08-05 15:40:52 +05:30
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
NandanAnantharamu
f5dd307357
updated spec with assertion values (#6323)
* updated spec with assert

* updated test

* updated test

* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action (#6208) 2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test (#6371) 2021-08-04 11:05:16 +05:30
NandanAnantharamu
cd72098b0d
Commenting test (#6354) 2021-08-03 16:19:45 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
akash-codemonk
bafab2f254
Fix test by mocking the response (#6273) 2021-07-30 18:33:57 +05:30
yatinappsmith
de1088f84a
Fixed ExecutionParams (#6284) 2021-07-30 18:33:34 +05:30
yatinappsmith
a665b943c0
Using local Postgres database instead of remote (#6241)
* Using local Postgres database instead of remote

* Added createdb and usedb at the top
2021-07-30 11:41:14 +05:30
Rishabh Rathod
76dfcd0163
[Feature] Generate template page from datasource (#5513)
- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-29 13:43:10 +05:30
Rishabh Saxena
bec7acdcfc
Fix iframe url xss (#6209) 2021-07-28 11:31:09 +05:30
Pranav Kanade
3547976dc7
[Feature] new nav sniping mode (#5746)
* added sniping mode toggle option to header

* added cover to components on hover in sniping mode

* fixed the transition time

* using filled icon

* Show dependencies in action pane

* Added a wrapper to make a widget snipeable

* removed older parts of sniping from Positioned Container

* removed onclick action from snipeable wrapper

* Showing widget name in different color

* Added a mechanism to send user to sniping mode from successful API screen

* created new property pane saga to bind the data

* Fix datasource list width issue

* Fix sidebar going out of view when the response is a table

* Minor refactor

* Show add widgets section on the sidebar

* Stop showing autocomplete option after adding a widget

* fetching pageId, appId from store

* Get suggested widget from response

* Fix table data not getting evaluated after adding binding

* Fix property pane going below the entity explorer while navigating from query/api pane

* Fix width of sidepane shifting for apis

* Fix vertical margins of connections

* Fix api pane suggested widget showing up for errors

* Fix margins

* can show select in canvas btn in sidebar

* can get the action object at the end to bind the data

* updated saga and action names

* can bind data to table

* Use themes

* Use new image url for Table widget

* Added conditional mapping for sniping mode binding.

* updated the widget name tags and seq of calls to open property pane

* pushed all sniping mode decoration to header

* moved setting sniping mode logic to editor reducer

* Added keyboard short cut to get out of sniping mode

* updated reset sniping mechanism

* removed a divider line

* if there are no relationships, will not show the complete section

* Connect Data will automatically show relevant tab in integrations

* Update list and dropdown image urls

* Remove create table button

* no wrapping bind to text

* minor review considerations

* showing the widget name to left in sniping mode

* can set data to datepicker

* will not show snipe btn if there are no widgets in canvas

* Changes for multiple suggested widgets

* removed dependency of sniping from suggested widgets

* Added analytics events for sniping mode

* logic for binding data to a widget, moved to snipeable component

* changed binding widget func from capture to onClick and took care of sniping from widget wrapper too.

* added tests to check sniping mode for table

* updated test spec

* minor fix

* Fix copy changes

* Update test to use table widget from suggested widget list

* if fails to bind will generate warning and keep user in sniping mode

* in sniping mode will only show name plate if it is under focus

* fixed the test case

* added a comment

* minor fix to capture on click event in sniping mode

* updated text

* Hide connections UI when there are no connections

* Increase width to 90%

* Show placeholder text and back button in sidepane

* Show tooltip on hover

* Add analyitcs events for suggested widgets and connections

* Update label based on whether widgets are there or not

* binding related changes

* renamed the saga file containing sinping mode sagas

* Changes for inspect entity

* Revert "binding related changes" temporarily

This reverts commit 54ae9667fecf24bc3cf9912a5356d06600b25c84.

* Update suggested widgets url

* Update table url

* Fix chart data field not getting evaluated

* a minor fix to show proper tool tip when user hovers on widget name

* Show sidepane when there is output

* Update locators

* Use constants for messages

* Update file name to ApiRightPane

* Remove delay

* Revert "Revert "binding related changes" temporarily"

This reverts commit ee7f75e83218137250b4b9a28fcf63080c185150.

* Fix width

* Fix overlap

Co-authored-by: Akash N <akash@codemonk.in>
2021-07-26 22:14:10 +05:30
NandanAnantharamu
10f37da2f0
Updated image spec (#6135) 2021-07-26 20:19:42 +05:30
yatinappsmith
54e81e4e33
Add tests for Propertypane drag and drop (#6131) 2021-07-26 19:20:17 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Yash Vibhandik
a0c9ecb2a5
FIX #3229 : added new props shortcuts and closeOnSelection for smooth interactions (#5276)
In the date picker widget we now have an option to let the date picker popup remain open until the a positive feedback is given by clicking outside the popup or another widget. In other words the date-picker popup will not close where a date is selected with `closeOnSelection` disabled. 

We have also added an option to show date-picker shortcuts to the end user.
2021-07-22 18:16:41 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Pranav Kanade
22bec1fce7
[Feature] Authenticated API datasource creation (#6017)
* added an oauth datasource tab

* added a comment

* removed warnings

* updated authenticated datasource name

* added a test case to verify new authenticated api card

* can create a simple rest api datasource

* enabled the use of view mode for rest api datasources

* minor fix for centered icons

* added analytics event
2021-07-22 13:25:13 +05:30