Commit Graph

1004 Commits

Author SHA1 Message Date
ankurrsinghal
6a503b4d57
Merge pull request #12007 from appsmithorg/fix/datepicker-resets-today-11837-2
fix: added bugfix for date parsing in datepicker widget 2
2022-03-24 12:31:03 +05:30
Arsalan
86125dee5e fix: Merge conflicts resolved. 2022-03-23 20:28:12 +05:30
Tolulope Adetula
aa806de7ba fix: parsing unnecessary value 2022-03-23 13:08:32 +01:00
Tolulope Adetula
90dfa002fa fix: build issue 2022-03-23 07:25:20 +01:00
Tolulope Adetula
15c827bf87 FIX: BUILD ISSUE 2022-03-22 13:55:06 +01:00
Arsalan
e8566e10f8 fix: added missing semi-colon 2022-03-22 17:06:49 +05:30
Arsalan
035583e92d fix: ButtonGroup vertical orientation styles. 2022-03-22 16:47:06 +05:30
Tolulope Adetula
7d6bc6e2e5 fix: default value with number 2022-03-22 12:03:27 +01:00
Paul Li
2b278ee7a1 feat: Internal property to detect changes in a form
-- Merge componentDidUpdate methods
2022-03-22 18:09:52 +08:00
Tolulope Adetula
eec6b0e227 Fix: multiselect default label issue 2022-03-22 09:51:27 +01:00
Arsalan
b643ea7bb9 fix: Menu Button Table componenet Menu button order fixed. 2022-03-22 13:15:33 +05:30
Arsalan
bef9d2d81b fix: resolved disabled captcha click. 2022-03-22 12:22:39 +05:30
Preet
29fca665ef Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-22 11:39:44 +05:30
Paul Li
0e6ade690c Merge branch 'release' into feat/4182-form-detect-changes 2022-03-22 05:13:38 +08:00
Arsalan
f2ea8b1838 fix: Merge conflicts resolved. 2022-03-21 20:49:24 +05:30
Preet
7016f3d439 fix cypress tests 2022-03-21 20:15:17 +05:30
Ankur Singhal
d5afbd4629 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/datepicker-resets-today-11837-2 2022-03-21 15:45:20 +05:30
Preet
1595a7a61d move isNilOrEmpty to helpers.ts 2022-03-21 13:27:25 +05:30
Preet
84a2e96b6d Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-21 13:18:57 +05:30
Preet
4b27fdf643 fix select widget width 2022-03-21 13:18:51 +05:30
Ankur Singhal
3f0450ea96 added bugfix for date parsing in datepicker widget 2 2022-03-21 13:05:47 +05:30
balajisoundar
f1d1ee9ac0
fix: numeric type input widget should accept zero after decimal point (#11923)
- Derived properties of List widget children won't work. so having the text
  property of the Input widget as a derived property causes issues. hence
  having it as a meta property.
2022-03-18 22:18:16 +05:30
Arsalan
ec62586a44 fix: Replace GREY_4 with GREY_8 2022-03-18 16:23:02 +05:30
Arsalan
0bbe9fedbb fix: Fixed Icon Button onClick in disabled state. 2022-03-18 14:59:34 +05:30
Arsalan
83d166d42b fix: ButtonGroup, MenuItems update indexes. 2022-03-17 18:58:56 +05:30
Arsalan
37d9fd22bb Merge branch 'release' into fix/button-group-undo 2022-03-17 17:45:25 +05:30
Paul Li
3e37914b01 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-17 19:27:50 +08:00
Paul Li
dd49573d15 feat: 4182: Internal property to detect changes in a form
-- Eliminate unnecessary props
2022-03-17 19:26:24 +08:00
Arsalan
87c4645a87 fix: Button Group, MenuButton, Tabs undo Redo fixed. 2022-03-17 15:49:17 +05:30
Preet
53c8b18c79 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-17 11:56:44 +05:30
Preet
9003e6ddfb add unit test for Select Button 2022-03-17 11:49:35 +05:30
Arsalan Yaldram
9f51619b2c
Merge pull request #11865 from appsmithorg/fix/button-icon-alignment
fix: Button Icon Alignment on Icon Change
2022-03-17 11:12:15 +05:30
Preet
cd694540fd fix scroll behaviour on filtering 2022-03-17 11:10:22 +05:30
Preet
bceae2fb4e refactor select button 2022-03-17 10:57:39 +05:30
Bhavin K
ab9310bda8
fix: remove margin when no label (#11789) 2022-03-17 10:42:35 +05:30
Preet
1e5d7153ea add virtual list for select menu 2022-03-17 10:30:24 +05:30
Paul Li
7403449197 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-16 22:51:09 +08:00
Paul Li
f9e30a1e15
fix: Input widget onSubmit gets triggered before evaluation (#11590)
* fix: onSubmit gets triggered before evaluation

-- Enforce to update text meta property before trigger the submit action

* fix: onSubmit gets triggered before evaluation

-- Add a comment and a Cypress test on the fix

* fix: onSubmit gets triggered before evaluation

-- Fix on the failed test case

* fix: onSubmit gets triggered before evaluation

-- Rewrite comments
-- Rewrite the test case to fail if we revert changes

* fix: Iput widget onSubmit gets triggered before evaluation

-- Update a common property, isDirty
2022-03-16 22:45:12 +08:00
Paul Li
097ab33b4c feat: Internal property to detect changes in a form
-- Complement Cypress test case by adding reset cases
-- Update isDirty reset logic for MultiSelectWidgetV2
2022-03-16 22:44:44 +08:00
balajisoundar
ab963d473c
Revert "fix: numeric type input widget should accept zero after decimal point (#11579)" (#11888)
This reverts commit 342fec4462.
2022-03-16 17:34:44 +05:30
Bhavin K
3486e7c0c8
fix: Reset image error flag when imageUrl or defaultImageUrl is changed in Image widget (#11790)
* fix: handle image error flag

* doc: comment update

* test: added cypress testcase

* test: updated cypress test case

* test: test case updated

* test: cypress updated

* test: fix cypress
2022-03-16 06:10:20 +00:00
Paul Li
c4ee93edef Merge branch 'release' into feat/4182-form-detect-changes 2022-03-16 07:55:07 +08:00
Arsalan
1f45c67edf fix: added iconAlign dependency to iconName prop 2022-03-15 12:19:30 +05:30
Arsalan Yaldram
6496f84374
fix: Added Button Container for the firefox drag issue (#11627)
* fix: Added Button Container for the firefox drag issue

* fix: Removed un-necessary styles, added Container in Canvas mode.

* fix: Removed renderMode check from styled function.

* fix: Code refactor and handled Icon Button Component.

* fix: Added extensive comments.

* fix: handled menu button drag issues.

* fix: Fixed some failing tests.

* New Button locator (with drag-container) fix

* NewBtn container locator fix

* btn locator fix

* MongoShopping spec fix

* Mongo, Postgress fixes

* Stat box fix

* Testcase title update

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-13 22:51:04 +05:30
Preet
d5a59d48be Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-12 11:13:36 +05:30
Preet
d389270423 add config param for limiting line breaks 2022-03-12 11:12:56 +05:30
Bhavin K
92267b3627
feat: changed icon widget to icon btn for modal widget (#11508) 2022-03-11 23:58:17 +05:30
Yash Vibhandik
ccf12c76a0
fix: #11315 Added trimming in button variant name (#11390)
* fix: #11315 trim buttonVariant

* test: cypress added
2022-03-10 21:39:17 -08:00
Yash Vibhandik
2a203b428b
fix: #11112 updated list widget property config (#11388) 2022-03-10 21:38:37 -08:00
Tolulope Adetula
beed6df8b3
fix: inconsistency in select and treeselect widgets behaviours (#11462)
* fix: Select dropdown width overflow

* fix: dropdown overflow in MultiTreeSelect widget

* fix: Multi tree select and Add filter input

* fix: tree select dropdown

* Fix: Select icons on explorer and Fix invlaid state of widgets

* fix: remove redundant style

* fix: build failure

* fix: build failure

* fix: yarn issues

* fix: build issue

* fix: remove labels from select widgets

* fix: dropdown width issue in compact mode

* fix: remove the close icon in the filter bar when there's no text

* fix: Filter bar should also follow the same min width as the widget.

* fix: add tooltip to show hover when text is truncated

* fix: Add audio widget to entity explorer

* Fix: failing tests and searching on Select widget

* fix: PR reviews

* fix: isDirty only when value changes

* fix: focus state of treeselect

* fix: remove default focus state and make filter get focus on open

* fix: focused Item when opened

* fix: No ellipsis found in Select widget when URL is an option
2022-03-10 21:35:05 -08:00
balajisoundar
342fec4462
fix: numeric type input widget should accept zero after decimal point (#11579) 2022-03-10 13:27:58 +05:30
Bhavin K
71d6da19bc
feat: added isJSConvertible property in IconButton Widget (#11625)
* feat: updated  isJSConvertible property

* fix: default icon value added, validation updated
2022-03-10 09:41:02 +05:30
Preet
8041c58254 fix stringify text if it exceeds line breaks limit 2022-03-09 20:04:26 +05:30
Paul Li
b4c33fe050
fix: Icon alignment changes automatically every time the icon is changed in Menu button widget (#11570)
* fix: Icon Alignment changes automatically every time when icon is changed in Menu Widget

-- Add iconAlign property as a dependency for iconName property

* fix: Icon Alignment changes automatically every time when icon is changed in Menu Widget

-- Add a Cypress test case to ensure the fix

* fix: Icon alignment changes automatically every time the icon is changed in Menu button widget

-- Fix on a broken Cypress test, setting force to true
2022-03-09 02:29:50 -08:00
Arsalan Yaldram
e411f093cc
Merge pull request #11623 from appsmithorg/fix/table-filter-pane-overflow
fix: Added root element as the ParentBoundary for TableFilterPane.
2022-03-09 11:22:19 +05:30
Bhavin K
c9760edb87
Revert "fix: handle main container height (#11461)" (#11674)
This reverts commit c6f5dcb673.
2022-03-08 12:54:40 +05:30
Tolulope Adetula
b17cd2e3bd
fix: table widget value displacement (#11650) 2022-03-07 22:06:32 -08:00
Paul Li
8b79f6c77d Merge branch 'release' into feat/4182-form-detect-changes 2022-03-07 23:27:57 +08:00
Paul Li
70706c7f8e feat: Internal property to detect changes in a form
-- Add Cypress tests FormWidget's hasChanges and all assoicated widgets' isDirty
-- Add missing isDirty meta property for SwitchGroupWidget
-- Rewrite isDirty check logic for RichTextEditorWidget
2022-03-07 23:23:57 +08:00
Preet
51c3d37620 Custom menu item 2022-03-07 20:06:35 +05:30
Preet
f4e6341add Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-07 13:13:22 +05:30
Preet
21a5727353 update popover visibility through state 2022-03-07 13:12:49 +05:30
Arsalan
93e2f5eb62 fix: Added root element as the ParentBoundary for TableFilterPane. 2022-03-04 14:53:29 +05:30
Vicky Bansal
43441bfce2
feat: add tooltip to column header text which overflows (#10666)
* feature: add tooltip to column header text which overflows (#10495)

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix: test issues

Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-03-04 00:56:16 -08:00
Preet
65940048e8 remove unnecessary re-renders 2022-03-04 13:36:38 +05:30
Paul Li
26d06c45a4
fix: Aspect ratio of video changes when Camera widget is longer in width than the aspect ratio (#11453) 2022-03-04 12:21:10 +05:30
Paul Li
5254f8e7f3 feat: Internal property to detect changes in a form
-- Eliminate the redundant code from RichTextEditorWidget
-- Change the way to detect default values changes with SelectWidget and MultiSelectWidgetV2
2022-03-03 21:57:22 +08:00
Yash Vibhandik
2f7d862ea0
fix: #11301 filter pane text css updated (#11410) 2022-03-03 17:33:26 +05:30
balajisoundar
fe72182064
fix: Number type input should honour required property when value is empty string (#11442) 2022-03-03 00:38:22 +05:30
Bhavin K
12954d4e3d
fix: changed download flow for image control (#11391)
* fix: changed download flow for image control

* test: cypress test added

* fix cypress test case
2022-03-02 13:43:24 +00:00
Bhavin K
c6f5dcb673
fix: handle main container height (#11461) 2022-03-02 13:41:44 +00:00
Hetu Nandu
ac7a73f667
fix: table button multi-line execution (#11525) 2022-03-02 12:07:20 +05:30
Paul Li
e7355bdeba Merge branch 'release' into feat/4182-form-detect-changes 2022-03-02 03:15:54 +08:00
Paul Li
dbb09dd4e0 feat: Internal property to detect changes in a form
-- Make isDirty to a meta property, followed by code refactoring
-- Reset isDirty only if default value changes
-- Recursively check if the form has changes, even considering nested case
2022-03-02 03:02:10 +08:00
Hetu Nandu
06bf4696b4
fix: Promises in Table buttons (#11239) 2022-02-28 15:05:43 +05:30
Bharat Patodi
59c0d94ade
chore: Replace require with import statements (#8121) 2022-02-28 14:53:19 +05:30
Rishabh Rathod
7a484fc027
fix: meta changes (non-default) also update metaHOC state (#10734)
* Reset metaHOC state on widget reset

* Pass all meta values for metaHOC reset logic

* pass only metaReducer values in meta

* fix unit test

* Add test
2022-02-26 02:16:04 +05:30
Tolulope Adetula
588e1356e3 fix: scrolling issue in container and modals for app view 2022-02-24 13:54:37 +01:00
Bhavin K
73a3a2452e
fix: added width cap, updated props to handle size (#11357) 2022-02-24 13:51:45 +05:30
Paul Li
bd9636f514
fix: left border of Input widget is cut off when icon is set and left aligned (#11257)
-- Remove the CSS rule for border-left to be transparent
2022-02-24 11:30:55 +05:30
Paul Li
4b80ea27e9
fix: Some .jpg images don't load in the Image Widget (#11247) 2022-02-24 09:07:54 +05:30
Tolulope Adetula
facf6a3d96
fix: date picker uniformity when only Month or year is changed (#11077)
* fix: date picker uniformity

* cypress tests

* fix: Failing date picker test

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-23 15:54:24 -08:00
Bhavin K
89bc82b4f5
fix: radio widget example string (#11352) 2022-02-23 17:23:15 +00:00
Tolulope Adetula
06eac9387e
fix: make table button transparent when no color is selected (#11348)
* fix: make table button transparent when no color is selected

* fix:  failing tests in Table_widget_add _button_spec
2022-02-23 07:54:46 -08:00
Paul Li
c30f072c84
fix: Input widget onSubmit ends up triggering onTextChange (#11304)
-- Make onSubmitSuccess callback not to trigger additional onTextChange
2022-02-23 20:44:55 +08:00
Paul Li
ff2bcc228a Merge branch 'release' into feat/4182-form-detect-changes 2022-02-23 16:21:48 +08:00
Paul Li
c0f93052de feat: Internal property to detect changes in a form
-- Implement dirty check logic for a form
-- Expose an form property, hasChanges for checking if the user has changed any values in the form
-- Add isDirty derived property for the following widgets: AudioRecorderWidget, CameraWidget, CheckboxGroupWidget, CheckboxWidget, CurrencyInputWidget, DatePickerWidget2, FilePickerWidgetV2, InputWidgetV2, MultiSelectTreeWidget, MultiSelectWidgetV2, PhoneInputWidget, RadioGroupWidget, RichTextEditorWidget, SelectWidget, SingleSelectTreeWidget, SwitchGroupWidget, SwitchWidget
2022-02-23 16:03:51 +08:00
Bhavin K
03dc8da930
fix: updated max character validation (#11333) 2022-02-23 11:53:58 +05:30
Bhavin K
e944f1b17c
fix: handled to hide widget in preview mode (#11138)
* fix: handled to hide widget in preview mode

* docs : comment update

* fix: condition updated as required, cypress test added

* fix: simpler condition, types updated
2022-02-23 10:22:04 +05:30
Tolulope Adetula
24293ced76
fix: select widget accept string and object in the defaultOption property (#11082)
* fix: Select widget accept string and object

* fix: JSON object case

* Fix: make Multiselect Defaukt option Array of strings

* fix: Select and Multiselect

* fixes and test cases

* comments

* fix: Select option value

* fix: mutiselect and test case

* fix: failing test

* fix: reset select widget

* fix: PR issues

* fix: Select widget Reset

* fix: failing Test

* fix: test

* fix: tests

* FIX: EVALUATION TESTS

* fix: getting Select Value in form

* fix: Test cases

* fix: add more test cases

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-22 00:43:35 -08:00
Bhavin K
707dd9bb8a
fix: updated css for ISDCode Dropdown in the phone widget so that placeholder does not collapses to the left when disabled (#11196) 2022-02-21 11:12:39 +05:30
Bhavin K
9eeb120c77
fix: updated height for page view (#10796) 2022-02-18 19:34:14 +05:30
Arsalan Yaldram
d12ae7a800
fix: Table Filter pane overflows when Table is at the top of the canvas (#10618)
* Added boundaryParent prop to Propperto prevent table filter pane overflow.

* Review Changes, done.

* Resolved overflow issue with multiple pages.

* Removed hardcoded Top value while dragging.

* Added parentElement as a function parameter.
2022-02-18 12:26:09 +00:00
Arsalan Yaldram
45da98f1dd
Merge pull request #10935 from appsmithorg/fix/10766-rating-inactive-color
fix: Rating Widget inactive-color.
2022-02-18 17:54:44 +05:30
Paul Li
12dad5737d
fix: Issues and Enhancements in the camera widget (#10943)
* fix: Issues and Enhancements in the camera widget

-- Fix on an image stretching issue when taking a picture
-- Set background to black
-- Add onImageSave, onVideoSave Actions
-- Rename Camera to Image

* fix: Issues and Enhancements in the camera widget

-- List all device info only when one or more MediaStreams are active

* fix: Issues and Enhancements in the camera widget

-- Always keep camera aspect ratio when resizing

* fix: Issues and Enhancements in the camera widget

-- Add a Cypress test case for onSaveImage property

* Increased wait!

* Camera case failure locator fix

* Camera case locator fix

* Promises restWidget moved to last!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-17 20:10:32 +08:00
Paul Li
f3360d814e
fix: Text widget shows a horizontal scroll on center and right alignment (#11189)
-- Set overflow-x to hidden on StyledText
2022-02-17 20:01:15 +08:00
Arsalan Yaldram
81e79af04f
Merge pull request #10954 from appsmithorg/fix/10697-rating-widget-flickering
fix: rating widgets flickering when value is reduced.
2022-02-16 13:27:21 +05:30
Tolulope Adetula
7837b568af
fix: select Widget resize (#11048) 2022-02-14 23:34:53 -08:00
Pranav Kanade
b778b83ac4
refactor: admin settings (#9906)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-02-11 23:38:46 +05:30
balajisoundar
85cc3f3497
feat: Provide option in phone input widget to turn off auto formatting (#10832) 2022-02-11 15:39:38 +05:30