Commit Graph

3744 Commits

Author SHA1 Message Date
Hetu Nandu
dc154b94b0
Fix widget updates not working properly (#3403)
* Fix widget updates not working properly

* Revert "Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218)"

This reverts commit 39e4990a7f.
2021-03-05 00:05:41 +05:30
Vicky Bansal
c4d6405981
Fix: RTE Error (#3385)
* Added defaultText property for text type validations to fix invalid data type beings passed to RichTextEditor component

* removed text and defaultValue properties from widget property validation map
2021-03-04 16:21:58 +05:30
Trisha Anand
20ed017a58
In case of no mustache bindings are found in dynamic path list, throw invalid dynamic binding reference error. (#3394) 2021-03-04 15:35:46 +05:30
akash-codemonk
39e4990a7f
Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218) 2021-03-04 15:24:01 +05:30
akash-codemonk
1e4878f983
Support editing user's name field (#3306) 2021-03-04 15:07:02 +05:30
Hetu Nandu
c81495e2cb
Fix chart data validation (#3389) 2021-03-04 13:40:22 +05:30
Rishabh Saxena
013c4230e2
Wrap ads button text within span for resilience for DOM mutations (#3292) 2021-03-04 11:34:36 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-04 10:54:47 +05:30
Ashok Kumar M
af6b3dfdbb
Fix: Drop overlay widgets anywhere and add them as main container child (#3332)
* Fix: Drop overlay widgets anywhere and add them as main container child

* Using detachFromLayout config.
2021-03-04 10:26:00 +05:30
Trisha Anand
5e448b9331
DSL parsing : Catch index out of bound exception (#3364)
* In case index being referred does not exist, throw appropriate error during DSL parsing

* Fixing bad commit.
2021-03-03 18:51:35 +05:30
Sumit Kumar
639913703a
Fix/add mongo srv support (#3341)
Provide helpful error msg when srv url is provided to mongo plugin

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-03-03 18:31:04 +05:30
Trisha Anand
75b0986b92 Fixed the incorrect JSON string in INVALID_DYNAMIC_BINDING_REFERENCE appsmith error. 2021-03-03 18:22:42 +05:30
Shrikant Sharat Kandula
bb49f04f06
Support descending ordering for Firestore documents (#3340) 2021-03-03 18:18:57 +05:30
Trisha Anand
f49cc7b455
Added throwing a properly formatted error for client to consume when dynamic binding path list contains an invalid entry (#3343) 2021-03-03 17:47:35 +05:30
Trisha Anand
ca8be4c7f5
Db Migration : Delete unreferenced dynamic binding paths in actions (#3310)
* WIP compute if the dynamic binding path list is correct.

* Tested code for deleting the incorrect dynamic binding path list from actions.

* Added comments for code readability
2021-03-03 17:11:03 +05:30
Shrikant Sharat Kandula
9c50182f0e
API for forking of public applications (#3221)
* A barely working API for forking a public application

* Tests WIP

* Mild refactoring in tests

* Refactoring in test

* Not all applications are forkable
2021-03-03 15:45:47 +05:30
Vicky Bansal
d3c2c02745
Fix: Tabs Widget crashes when data is invalid (#3235)
* Fixed tabs data validation and added check to ensure tab property is accessible when tabs array is not empty

* added isVisible property in validations
2021-03-03 11:29:02 +05:30
Ashok Kumar M
a7e0990cf8
Feature: Canvas Layout Options(max width config) (#3141)
* Feature: Canvas Layout Options(max width config)

* Fixing css issues.

* Changing Default Device option to Desktop.

* Changed Implementation to maintain resize updates within the client.

* Addressing code review changes.

* Updating device resolutions.

* updating cytests

* Fixing resize bug.
2021-03-03 10:56:47 +05:30
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
Sumit Kumar
e5586a590a
fix placeholderText label in form.json files (#3331)
fix placeholderText label in form.json files
2021-03-03 09:33:02 +05:30
Piyush
462379721d
Reset widget global function (#3181) 2021-03-02 18:19:36 +05:30
Sumit Kumar
5bab77a141
remove endpoint host and port fields from dynamodb datasource form (#3316)
- A consensus has emerged that the utility of overriding endpoint is only for local development and testing. Hence, removing the fields from datasource form.
2021-03-02 17:25:25 +05:30
Sumit Kumar
6c04e1467b
Provide option for only one endpoint and port in the dynamodb plugin datasource form (#3314)
- provide a max length to keyvalue_array type. If the max length is set to 1, then the "+" button will not appear.
- front end changes are pending. A new github issue will be opened to track the same : #3315
2021-03-02 15:42:38 +05:30
Trisha Anand
bd18030c2d
Add request body in case http method is not GET (#3307)
* Add request body in case http method is not GET

* Incorporated review comments.
2021-03-02 12:46:20 +05:30
Rishabh Saxena
7204e87ea5
fix help modal overlapping with close button (#3289) 2021-03-02 11:26:02 +05:30
Rishabh Saxena
d48e00422e
Minor code cleanups (#3165) 2021-03-02 11:25:45 +05:30
Trisha Anand
91e308665b
Requests preparation by plugins instead of ActionService (#3159)
* Added action request in S3 plugin.

* Added request data in Dynamo plugin

* Added request in Elastic Search.

* Request in Firestore.

* Request added in Mongo

* MsSQL request added.

* Added MySQL request.

* Added Postgres request.

* Added redis request.

* Redshift doen.

* Catching AppsmithPluginExceptions at the plugin level itself to ensure that the request gets passed on as part of the result.

* Fixed failing plugin test failures

* Fixed AmazonS3 test failures.

* WIP post analytics working

* WIP : Making the request data confirm to existing analytics request data format.

* Fixed the headers in the analytics body.

* Migrations S3, Postgres to the accepted format for request in analytics

* Updated S3 action to be the query

* Migration completed for all plugins for analytics.

* Removed the old analytics event. Now sending only the new one.

* Ensuring all data is captured in S3 plugin request in case of error.

* Minor editing of firestore to ensure that the errors get caught by the plugin itself.

* Fixed test cases in Amazon S3

* Incorporated review comments.
2021-03-02 10:58:46 +05:30
Young Yoo
d61a900011
Fix #2712 - Duplicate Property For Map Widget (#3174)
After a Map Widget created, the text field in the Text Widget can bind the map properties. Inside the map properties, "Map center" and "Center" are duplicate value. The "MapCenter" is deleted for the adjustment.

Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-03-02 10:45:39 +05:30
imgbot[bot]
13b4d61b8f
[ImgBot] Optimize images (#3303)
*Total -- 114.50kb -> 96.16kb (16.02%)

/app/client/src/assets/images/no_data.png -- 103.98kb -> 85.71kb (17.58%)
/app/client/src/assets/icons/control/vertical_align_top.svg -- 0.17kb -> 0.17kb (2.3%)
/app/client/src/assets/icons/control/vertical_align_bottom.svg -- 0.18kb -> 0.17kb (1.67%)
/app/client/src/assets/icons/control/heading_1.svg -- 0.32kb -> 0.31kb (1.54%)
/app/client/src/assets/icons/control/vertical_align_center.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.12%)
/app/client/src/assets/images/secure.svg -- 1.08kb -> 1.07kb (0.91%)
/app/client/src/assets/icons/control/paragraph.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/control/delete-column.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/hide-column.svg -- 0.52kb -> 0.52kb (0.56%)
/app/client/src/assets/icons/control/heading_2.svg -- 1.08kb -> 1.08kb (0.45%)
/app/client/src/assets/icons/control/checkmark.svg -- 0.96kb -> 0.95kb (0.41%)
/app/client/src/assets/icons/control/paragraph_2.svg -- 1.49kb -> 1.49kb (0.33%)
/app/client/src/assets/icons/control/bullets.svg -- 1.52kb -> 1.52kb (0.32%)
/app/client/src/assets/icons/control/heading_3.svg -- 1.52kb -> 1.52kb (0.32%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-03-02 10:24:47 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
dependabot[bot]
d7b7cb26fa
Bump prismjs from 1.22.0 to 1.23.0 in /app/client (#3300)
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.22.0...v1.23.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-02 08:20:31 +05:30
Sumit Kumar
7d2effae18
Modify hint statement for 'import from curl' form (#3285)
- Move to hint statement out of query box and put if above it - between the label and the query box - so that user's don't confuse it as a typed in statement.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-03-01 23:28:07 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
akash-codemonk
beb6eb8241
Add validation to check if organization exists during onboarding (#3243) 2021-03-01 15:21:23 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function"
This reverts commit 54f158694f.
2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
RIshabh Saxena
2a868c89a6 Revert "Wrap text with span for resilience for DOM mutations by google translate"
This reverts commit e87ef2452e.
2021-03-01 13:25:05 +05:30
RIshabh Saxena
e87ef2452e Wrap text with span for resilience for DOM mutations by google translate 2021-03-01 13:24:36 +05:30
Sumit Kumar
68e6c7b1d8
stop logging datasource argument error externally. (#3262)
- Stop logging datasource argument error externally. The error described in the linked GitHub issue arises due to bad service account credentials provided as arg.
- Update error msg to make it clear.
- Add TC.
2021-03-01 12:13:32 +05:30
Trisha Anand
31b20da347
Adding support for NULL value parameters in Prepared Statement. (#3255) 2021-02-27 18:59:51 +05:30
Sumit Kumar
d2643a18c3
check dynamodb connection validity using listTables cmd. (#3241)
* check dynamodb connection validity using listTables cmd.
* add TC
* add encrypted logo to password field
* rectify the default value of region dropdown
* remove unused imports
2021-02-26 16:57:18 +05:30
Shrikant Sharat Kandula
a1d027bb59
Save separate appLayout for edit/view and sync on publish (#3245) 2021-02-26 16:18:04 +05:30
Hetu Nandu
1f7fc9c0ed
Api form on submit (#3225) 2021-02-26 14:52:11 +05:30
Shrikant Sharat Kandula
5808620716
Add API for the signed in user to set their name (#3164)
* Add API for the signed in user to set their name

* Use the correct error in session handling
2021-02-26 14:48:20 +05:30
akash-codemonk
0682a92d87
Update useEffect dependency (#3239) 2021-02-26 14:13:24 +05:30
Shrikant Sharat Kandula
dc146a1a16
Fix MongoDB test operation errors not being caught (#3234) 2021-02-26 12:55:54 +05:30
Piyush
21a2a2bdf4
Redirect URL for oAuth Auth code flow (#3232) 2021-02-26 12:28:47 +05:30
Piyush
c38e58b3bc
Fix race between action reducer and handleQueryCreatedSaga (#3236) 2021-02-26 12:28:03 +05:30