Commit Graph

11713 Commits

Author SHA1 Message Date
Anand Srinivasan
db38a64e71
chore: update imports for code split (#19085)
* move actionTriggers.ts

* update imports Explorer/helpers.tsx

* update imports EntityDefinitions.ts

* update imports Evaluation/Actions.ts

* update imports for ActionExecutionSagas

* missed worker types

* missed imports

* update imports for dataTreeUtils

* missed imports

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-22 12:04:28 +05:30
Appsmith Bot
c2a7face0c Update top contributors 2022-12-22 06:58:19 +05:30
sidhantgoel
dbb72c4778
feat: Support for Import/Export without ACL (#18997)
For EE RBAC compatibility, import/export for git sync does not use ACL
2022-12-21 23:35:11 +05:30
arunvjn
2dc7dc90e3
feat: Import javascript libraries (#17895) 2022-12-21 22:44:47 +05:30
GitStart-Appsmith
585a19401b
feat: [APPSMTH-29] make step up/down arrows in input Number and Currency widgets optional (#18764)
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-21 22:37:15 +05:30
Vaibhav Tanwar
f934b632f9
fix: Improved error message for google sheet insert/update empty body (#18558)
Google Sheet empty insert/update body error messages improved.
2022-12-21 19:00:02 +05:30
yatinappsmith
bff3f326cd
ci: Fix run result due to deprecated command (#19084)
## Description

Ci fix run result due to deprecated 

Fixes # (issue)



Media



## Type of change



- Bug fix (non-breaking change which fixes an issue)



## How Has This Been Tested?
code reivew

### Test Plan


### Issues raised during DP testing



## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-21 15:31:55 +05:30
NandanAnantharamu
751a95f866
test: Updated test for list widget (#18824)
* updaed test for list widget

* Added tests for List widget with DH

* updated the test with bug automation

* review comments incorporated

* updated dsl filename

* updated spec file comment

* updated tests
2022-12-21 14:49:27 +05:30
Nilesh Sarupriya
33077063ab
ci: flaky test validCloneApplicationWhenCancelledMidWay (#19091) 2022-12-21 14:13:54 +05:30
Rimil Dey
d0ceef7593
revert: Parse js actions for view mode changes (#19033)
Revert "fix: Parse js actions for view mode changes (#18357)"

This reverts commit efa8b68a47.
2022-12-21 10:27:55 +05:30
Nikhil Nandagopal
b6a0745c1f Updated Label Config 2022-12-21 10:15:09 +05:30
Appsmith Bot
9ab39e3cfe Update top contributors 2022-12-21 06:57:58 +05:30
Aman Agarwal
4a381607eb
fix: google sheet ui issues, removed redundant code (#18785)
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-20 20:40:18 +05:30
Goutham Pratapa
d452b2452c
ci: Migrate runners from buildjet to github (#19066)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-12-20 16:32:22 +05:30
f0c1s
ff9db224f8
Revert "chore: remove telemetry option" (#19067)
Revert "chore: remove telemetry option (#19052)"

This reverts commit 059fcd5c58.
2022-12-20 15:19:09 +05:30
yatinappsmith
e50d309161
ci: fix PR number in adding failed tests (#19065) 2022-12-20 15:15:09 +05:30
Ankita Kinger
980f6f5827
chore: Addressing changes requested by the design team during design QA (#19041)
* addressing design QA change requested

* updating the props
2022-12-20 12:19:57 +05:30
f0c1s
059fcd5c58
chore: remove telemetry option (#19052) 2022-12-20 11:52:36 +05:30
NandanAnantharamu
99ba866761
test: added test for modal widget (#18729) 2022-12-20 11:44:33 +05:30
Ayush Pahwa
8d09ab297b
chore: CE EE split of routes for manage env pages (#18449)
update: routes for CE EE split env editing
2022-12-19 19:10:49 +07:00
yatinappsmith
876cd428f9
ci: Comment failing tests to PR (#18450)
## Description

Comment failing tests to PR

Fixes # 



## Type of change

- New feature (non-breaking change which adds functionality)


## How Has This Been Tested?
Code review. Tested in local fork

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-19 16:23:39 +05:30
Aswath K
f9e17f670f
fix: All property control renders when JS toggle button is clicked (#18905)
Fix the performance issue that happens when we click the JS toggle button in property pane.
2022-12-19 15:45:50 +05:30
Shrikant Sharat Kandula
467a1f65eb
chore: Fix inconsistency in behaviour when re-marking public (#19031)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-19 15:29:58 +05:30
Sumesh Pradhan
60806f7761
Dockerfile mongodb 4.4 to 5.0.14 upgrade (#18773) 2022-12-19 15:00:24 +05:30
f0c1s
0f56f054e0
chore: restrict when /usage-pulse can be fired (#19029) 2022-12-19 14:39:27 +05:30
Hetu Nandu
c5c8734dc1
chore: Update github actions to remove deprecation warnings (#18619) 2022-12-19 13:04:43 +05:30
rahulramesha
6636e8ae82
fix: Remove auto-height from list widget's children (#18755)
* remove auto height from list widget's children

* avoid large diffs

* disable auto height in list widget, review commit

* fix children object for list widget during migration

* reposition comment

* fix blueprint message when multiple widgets are added

* remove comment

* List widget test for Dynamic height updated

* fix propertyPane config

* fix property pane search for hidden dynamic height values

Co-authored-by: Apple <nandan@thinkify.io>
2022-12-18 01:33:35 +05:30
Trisha Anand
760738a430
chore: [GAC] Using correct permissions to fetch the application object using view mode (#19007) 2022-12-17 16:48:31 +05:30
Appsmith Bot
fe3bfaa516 Update top contributors 2022-12-17 06:57:51 +05:30
akash-codemonk
bedcd7cade
fix: set soft focus for property pane inputs (#19009) 2022-12-16 22:52:47 +05:30
Sumit Kumar
803043c12e
feat: add endpoints for custom JS library add / remove / get (#18904) 2022-12-16 18:00:50 +05:30
Ankita Kinger
424e3b24e4
fix: updating the redirection of admin settings to fix failing tests (#18971) 2022-12-16 17:14:44 +05:30
Rishabh Rathod
c4c873953b
chore: Remove evalError & values from dataTree (#18649)
## Description

Appsmith internally maintains the data of all the entities as a collection called dataTree. This data tree stores evaluated values and errors ( evaluated props ) in entity object with key `__evaluation__`. 

In this PR, we move the evaluated props out of the dataTree for worker code to make `deepCloning` and dataTree sanitization i.e., `JSON.parse(JSON.stringify(dataTree))` faster. 

TL;DR

Trimming dataTree object size by evaluatedProps to make evaluation faster.

Fixes #14710 

## Type of change

Performance change


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- [ ] https://github.com/appsmithorg/TestSmith/issues/2124

- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [x] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-16 14:17:54 +05:30
Anagh Hegde
82489a3ecd
fix: Add error message for protected branch (#18737)
* Add error message for protected branch

* Added Junit Test cases

* Add error message for protected branch

* Added Junit Test cases

* chore: push failed warning

* Add reset command

* Fix test failures

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-16 12:07:40 +05:30
Dhruvik Neharia
f2709d6de7
fix: Button Group Menu Item Label Misaligned (#18951)
## Description

This PR fixes a minor bug that caused the label of new menu items inside the button group widget to be misaligned.

Fixes #18867

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-16 12:06:55 +05:30
Parthvi
a30fbf2c77
test: add common test methods for RBAC (#18968) 2022-12-16 10:45:25 +05:30
balajisoundar
f49db2a90e
feat: Provide currentRow access in the table widget select column typ… (#18180) 2022-12-16 10:05:51 +05:30
Appsmith Bot
0fae15b01c Update top contributors 2022-12-16 06:58:17 +05:30
Trisha Anand
27b579fa68
chore: Refactor sign up flow to support create workspace to be permission driven (#18981) 2022-12-15 23:47:36 +05:30
Trisha Anand
69bc3c06dc
fix: [GAC] editing js objects should use read permission for creating actions (#18977)
* chore: For Js action, only using read permission while creation. For non Js actions, using create page permission to fetch the page

* fixing ci test case failure
2022-12-15 23:45:02 +05:30
Arpit Mohan
970deb92c7 ci: Reverting change for Github large runners 2022-12-15 21:03:18 +05:30
Arpit Mohan
4ed4de8d9c
ci: Moving the runners to use Github large runners instead of Buildjet (#18984) 2022-12-15 20:29:21 +05:30
akash-codemonk
17dbe63ed3
feat: [Context Switching] maintain focus of code editor fields (#18240) 2022-12-15 19:45:46 +05:30
Aswath K
c72f865962
chore: Property pane search input focus (#18858) 2022-12-15 16:25:52 +05:30
Ankita Kinger
a83bfc8acd
chore: Updating the version of the design system dependency (#18965)
updating the version of design system dependency
2022-12-15 15:34:21 +05:30
Tejas Ahluwalia
2b5b27ae6f
docs: added "How Appsmith Works" image to README (#18967)
* Add "How Appsmith Works" image

* Add "How it works" image to README.md

* docs: make "How Appsmith Works" image full width
2022-12-15 15:04:33 +05:30
Pawan Kumar
86f86f0298
chore: Update Logo/Favicon url + remove EE cypress code for Branding + Update screenshots tests (#18872)
* add new screenshot of apppagelayout + update logo url + remove ee code in spec

* fix error message for logo

* revert profile snap

* remove brand colors in ce

* fix auth page layout issue

* revert some snap images

* fix visual tests

* fix cypress tests

* fix cypress tests
2022-12-15 14:59:26 +05:30
Manish Kumar
2445a3c625
chore: method signature changed for getCachedDatasourceForActtionExecution (#18950)
## Description

> To accommodate for datasource context adaption for environments, Some datasourceService methods needs to be aware of `environment name` in order to evaluate the `datasource configuration` for the given environment
> TL; DR : This Pr changes method signature for fetching  datasource by actionId

Fixes #18760  
Ref #18762 

## Type of change
 > Chore

## How Has This Been Tested?
- Manual
- Jest



## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
2022-12-15 14:47:03 +05:30
Anagh Hegde
051444f221
fix: App deleted when the user creates branch in few scenarios (#18964)
## Description

> Continuing from the PR - https://github.com/appsmithorg/appsmith/pull/18034. The app getting deleted bug was introduced when creating branch was introduced in the linked PR. 
Current PR adds a check to ensure that none of the git flow is affected. 

Fixes - https://app.frontapp.com/inboxes/teams/folders/15585868/unassigned/66043703436

## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-15 14:44:16 +05:30
Favour Ohanekwu
8ed9d20547
feat: reset meta widgets (#18809)
* Initial commit

* reset meta widgets

* Annotate code

* Rehydrate meta values for meta widgets when dirty

* Undo rehydration logic
2022-12-15 09:23:09 +01:00