Commit Graph

1983 Commits

Author SHA1 Message Date
f0c1s
421dfb9b64
chore: Fixing broken client build (#17634)
## Description

EE client build is broken due to not following proper code splitting strategy; one file in particularly didn't get split earlier and changes to that file broke the client build on EE.

This PR fixes the issues.
2022-10-18 10:53:18 +05:30
Hetu Nandu
3aff53187c
feat: Maintain Focus and Context Phase 1 (#16317) 2022-10-17 20:46:38 +05:30
albinAppsmith
dab6fe95d2
feat: Migrated color picker v2 to property controls (#17362)
* feat: Migrated color picker v2 to property controls

* Design system package version updated
2022-10-16 23:53:05 +05:30
Dhruvik Neharia
c0318b6451
feat: Change Modern/Default Theme Background to #F8FAFC (#17345)
* feat: Change Modern/Default Theme Background to #F8FAFC

* feat: Update modern/default theme bg in system themes

* fix: Update basic spec theming test with new modern theme background color

* fix visual tests

* fix: Update WidgetsLayout_spec.js snapshots

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2022-10-14 11:10:50 +05:30
Ayangade Adeoluwa
282f1ff5a6
feat: Adds one way switching to Form Controls (#17194)
* Adds one way switching to Form Controls

* Fix failing jest test

* Retrigger oktotest

* JSOnload1 spec 6th case fix

* Jsonloadspec 1 fix

Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-13 21:28:46 +01:00
Tanvi Bhakta
ac0c872843
chore: migrate toast (#17208)
* Refactor toast to be passed the dispatch hook externally

* Add comments explaining dilemma

* use store.dispatch instead of a hook

* use alpha version

* Change imports

* Refactor DebugButton out

* update release

* fix issue with incorrectly merged package.lock

* fix syntax of alpha version

* bump ds vesion

* copy lock from release

* update lock to have alpha

* make changes

* delete Toast

* DS package version updated

* import change from release

* use new alpha version

* update ds version

* update ds version

* chore: migrate editable text and friends (#17285)

* Delete empty components

* use alpha for ds

* Deleted EditableTextSubComponent, import changes

* Delete EditableText, import changes

* use ds alpha 10

* Delete EditableTextWrapper.tsx

* update ds to use next minor version

* use new alpha

* fix issue with merge

Co-authored-by: Albin <albin@appsmith.com>

* chore: migrate file picker v2 (#17308)

* use alpha ds

* Delete FilePickerV2, import changes

* Delete FilePicker, change imports

* update alpha version

* chore: move copy url form into setting components (#17322)

* move CopyUrlForm to src/pages/settings/formgroup

* update ds version to use next minor release

* feat: Migrate table component to design system (#17329)

* feat: Migrate table component to design system

* removed commented code in ads index file

* fix: table no data hover effect removed

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>

* feat: Banner message component migrated to design system (#17327)

* feat: Banner image component migrated to design system

* Version update for design system package

* design system version updated

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>

* feat: Tabs component migrated to design system (#17321)

* feat: Tabs component migrated to design system

* design system package version updated

* Update app/client/src/components/editorComponents/form/FormDialogComponent.tsx

* Update app/client/src/pages/Editor/PropertyPane/PropertyPaneTab.tsx

* Tab component expand issue fix

Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>

Co-authored-by: Albin <albin@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
2022-10-14 01:43:44 +05:30
sneha122
4ebdc73e4f
fix: Added frontend validation checks for access token url and url in authenticated API datasource configuration (#17340)
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-10-13 18:59:20 +05:30
albinAppsmith
cbf415544f
feat: Migrated callout component to design system (#17289) 2022-10-13 18:08:32 +05:30
Tanvi Bhakta
08e6256fc6
chore: migrate form message (#17369)
* use ds alpha

* Remove FormMessage, change imports

* use updated ds alpha version
2022-10-13 12:14:16 +00:00
ankurrsinghal
f0f4427288
feat: InputTextControl enhanement (#17449)
enhanced the InputTextControl to accept two more event handlers for focus and blur from the property pane config

Co-authored-by: Ankur Singhal <ankurrsinghal@gmail.com>
2022-10-13 12:13:49 +00:00
Tanvi Bhakta
221c28ccb4
chore: move TextAreaField (#17419) 2022-10-11 09:06:55 +05:30
akash-codemonk
56ee520d8c
chore: hide templates v2 behind feature flag (#17034) 2022-10-10 13:14:37 +05:30
albinAppsmith
7301c8538f
feat: Change dialogue component import to design system repository (#17302)
* feat: Change dialogue component import to design system repository

* design system version changed
2022-10-10 09:24:41 +05:30
Tanvi Bhakta
5d4de1878c
feat: import changes for step component (#17252)
* import changes for step component

* delete step component

* Update index.ts

* use alpha package

* use named import

* update ds to use next minor version
2022-10-10 01:19:09 +00:00
Aman Agarwal
ab106455f2
fix: adding mode for graphql syntax with dynamic bindings (#17229)
fix: added mode for dynamic binding with quote for graphql
2022-10-08 03:17:07 +01:00
Aswath K
da23cba1e3
fix: Evaluated popup & binding prompt being trimmed (#17081) 2022-10-06 21:24:49 +05:30
Aman Agarwal
78c89894f8
fix: updated settings page design (#16990)
fix: updated settings page design
2022-10-06 16:36:29 +05:30
albinAppsmith
2741d37a4c
feat: Moved UserProfileImagePicker from ads folder (#17111)
* fix: Moved UserProfileImagePicker from ads folder

* design system package version update
2022-10-06 11:37:52 +05:30
albinAppsmith
794a422a82
feat: migration of ads/formFields/TextField to utils as part ads migration (#17281)
* feat: migration of ads/formFields/TextField to utils as part ads migration

* fixed checkbox and toggle issue

* dummy commit to fix dp issue
2022-10-05 16:36:49 +05:30
albinAppsmith
651fb9fd28
feat: Migrate DraggableListCard and DraggableListComponent from ads (#17202) 2022-10-05 16:33:42 +05:30
albinAppsmith
ba6936e26b
feat: JS Toggle migration from ads folder to design system (#17248) 2022-10-05 06:58:42 +05:30
f0c1s
32ed0da447
fix: Rest of the audit logs potential auto-merge errors. (#17192)
* fix: EE-CE parity due to audit-logs

* fix: rest of the audit-logs potential failures

* fix: future conflict with RBAC
2022-10-04 16:48:35 +05:30
Rimil Dey
a92b680462
chore: Extract views into their own components (#17014) 2022-10-04 16:25:26 +05:30
ChandanBalajiBP
02c8f6c2dd
fix: Slow rendering of JSON and RAW response (#16971)
* fix:Slow rendering of JSON and RAW response

* added debouncing for editor refresh
2022-09-30 20:51:04 +05:30
Ayush Pahwa
38d93e23a5
fix: console log dx issue fixes (#17137)
* chore: moved all helpers and types to diff files

* fix: cloning the incoming object to avoid mutation
2022-09-30 18:29:02 +05:30
rahulramesha
db6ebe3324
fix: Extra Space at the end of the Canvas in Viewmode (#16747)
We had logic to fix MainCanvas height when a Widget is dragged, resized or deleted. Extending that logic to When a widget is added to mainCanvas as well.

Also added logic to trim mainCanvas width in View Mode.
2022-09-30 13:49:52 +05:30
sneha122
9670fa26af
fix: Fix/additional rows api header section (#17052)
* fixed additional rows in header section

* additional rows issue resolved for empty pairs

* removed unnecessary imports

* refactored additional rows issue code

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-30 12:01:36 +05:30
Souma Ghosh
54e00b9c5d
fix: JS toggle default value is wrong for vertical alignment table widget (#16733)
* fix: JS toggle default value is wrong for vertical alignment table widget
- Fixes wrong default value for Vertical Alignment in column settings
- Fixes issue where JS toggle cannot be turned off after turning it on once

* Fix failing cypress test

* Change horizontalAlignment default value to LEFT
2022-09-30 11:39:26 +05:30
Tanvi Bhakta
cafb0d37b0
feat: import changes for uneditable field (#16556)
* Bump design system package version

* Update CopyUrlForm.tsx to use the new API for UneditableField

* Remove UneditableField

* Pass prop as string because that's what the type expects

* use beta version for ds

* update yarn.lock

* Update yarn.lock

* remove yarn.lock from root

Co-authored-by: Albin <albin@appsmith.com>
2022-09-29 17:36:02 +00:00
Ankita Kinger
a1b24ab7dc
refactor: Invite modal component to support single & multi-select dropdown options (#17073)
* refactored code for invite modal

* updated invite users modal component

* minor change

* optimized addition of links in invite modal dropdown

* fixed a cypress test

* removed msw

* fixed a cypress test

* fixed a cypress test

* fixed a cypress test

* fixed a test
2022-09-29 09:53:25 +00:00
Aswath K
ce1f42f786
fix: Placeholder being shown when value is zero (#17082) 2022-09-29 11:31:45 +05:30
Aswath K
1a71a14319
fix: Re-selecting dropdown value triggers evaluation cycle (#16201) 2022-09-29 11:25:56 +05:30
Tanvi Bhakta
0f1df77e61
feat: decouple redux and the view layer in CalloutV2 (#16625)
* refactor group so the appropriate prop can be passed to CalloutV2

* Remove local calloutV2, move to the design system one

* use updated Callout

* bump ds version
2022-09-29 10:50:41 +05:30
Pawan Kumar
f59f33c1f8
fix: RTE + Form + JSONForm reskinning (#16956)
* update rich text editor styles

* fix disalbed text  color

* add border

* fix gaps and borders in json form

* fix disabled state

* fix checkbox disabled state color on checkbox + font size of title in json

* fix disabled state of rte not re-rendering

* remove unused import

* fix cypress test
2022-09-28 17:28:40 +00:00
Rimil Dey
83432a1640
fix: navigate to throws error when changing from same to new window and vice versa (#17067)
* Add quotes for navigate to value options

* Update tests
2022-09-27 15:10:32 +05:30
Rimil Dey
4e9068ddba
chore: Move constants, types and utils to their own files in Action Creator (#16947)
* Move constants and regex to their own files from index and fields file

* Move types to to its own file

* Move utils to its file

* Add proper types for functions in fields file

* Rename Switch -> Switchtype

* Fix imports

* Fix NAVIGATION_TARGET_FIELD_OPTIONS constant so that the build works

* Jest tests to cover the utils

* Add jest test cases

* Update cases

* Code review changes
2022-09-26 10:05:04 +05:30
Tanvi Bhakta
a64f27ce27
feat: migrate SearchSnippet (#16886)
* Remove SearchSnippet, refactor parents to pass an onClick function

* Use SearchSnippet from DS

* [chore] bump design system version
2022-09-26 09:49:37 +05:30
Aswath K
995847cdef
fix: Action Selector menu goes out of viewport (#16878) 2022-09-23 10:46:26 +05:30
Aswath K
d62acb209a
fix: Issues with JS toggle (#16204)
* fix: unwanted JS toggle on Datepicker's firstDayOfWeek
* Remove JS toggle for properties that already accepts JS
* Enables the JS toggle button if the value is same that of defaultValue
2022-09-23 00:30:55 +05:30
Aman Agarwal
6d5fc58d71
fix: updated message changes for auth tab, capital texts (#16832)
* fix: updated message changes for auth tab, capital texts

* fix: updated icon color to text color
2022-09-21 15:48:43 +05:30
Ayush Pahwa
e3f90db341
feat: grouping in console logs (#16698)
* fix: updated skip functionality

* update: type of logs to add occurence count

* update: reducer function to merge the new logs

* update: added dependance on last log's occurence count

* add: UI to show the occurence badge

* fix: added null check for dependency array

* update: omit occurence from compare fn

* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array

* fix: replaced forEach with reduce

* test: added functions for console log grouping

* feat: updated warning grouping color

* update: moved function to reducer file for jest tests
2022-09-19 06:29:04 +00:00
Favour Ohanekwu
d6fbdb15b9
feat: Linting in entity properties and methods (#16171)
* Initial commit

* Remove arrow function params from identifiers

* Remove invalid identifiers from extracted identifiers

* Remove invalid identifiers which are derived from function params and variable declarations

* Fix typo error

* Correctly remove invalid identifiers

* Remove invalid names from identifier list

* fix build failure

* Add Promise to list of unacceptable entity name

* Keep track of unreferenced identifiers in bindings

* Add Global scope object names as unusable entity names

* Keep track of unreferenced identifiers

* Prevent traversal of data tree for addition of new paths and entities

* Sync linting in trigger fields

* Support linting of invalid properties

* Fix linting reactivity bug in trigger field

* Remove unused objects

* Fix conflict in merging

* Lint jsobject body for function change

* Remove unused map from tests

* Code cleanup

* Modify jest tests

* Update jest tests

* Fix cypress tests

* Code cleanup

* Support  linting of multiple bindings

* Set squiggle line as long as invalid property length

* Add jest tests

* Minor code refactor

* Move ast to shared repo

* Rename confusing identifiers

* Improve naming of functions and their return values

* move shared widget validation utils and constants to shared folder

* Add jest test for invalid entity names

* Add cypress tests

* Modify test comment

* Extend list of dedicated worker scope identifiers

* Resolve code review comments

* Resolve review comments

* Annonate code where necessary

* Code refactor

* Improve worker global scope object

* Code refactor

* Fix merge conflict

* Code refactor

* Minor bug fix

* Redundant commit to retrigger vercel build

* Add null checks to dependecy chain
2022-09-17 18:40:28 +01:00
Aman Agarwal
9dda476efa
fix: updated design for save as datasource button (#16700)
* fix: updated design for save as ds btn

* fix: updated the name for save/edit function
2022-09-16 15:57:35 +05:30
Favour Ohanekwu
b28d7df7c6
fix: prevent duplicated fields in debugger logs (#16761)
* Improve dependency chain generation

* Update jest test
2022-09-16 05:42:20 +01:00
Rimil Dey
903aaa7a14
feat: Change navigate to UI (#14856)
* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Fix types and imports

* Update the tests

* Add ref back to the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:00:16 +05:30
Satish Gandham
12f9a005ae
chore: Refactor getSelectedWidget selector (#16647)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Rename getSelectedWidget to getLastSelectedWidget in selectors/ui

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-15 05:44:11 +00:00
Satbir Singh
193dacfeca
chore: Adding JS Object Events (#16472)
* Event for creating new JS Object

* Adding tracking event for function execution

* Removing unwanted comment

* Events for adding new functions added

* Handling optional properties

* Changing event names

* Renaming Event Sources to JS_OBJECT
2022-09-14 21:04:10 +05:30
Favour Ohanekwu
16b04f33a6
fix: incorrect lint error position (#16526)
* perform string search using original binding

* Add jest test

* Improve code for better readability
2022-09-14 09:35:29 +01:00
Satish Gandham
a706ad3160
perf: Widget layer optimization (#16502)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Remove stray imports

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-14 12:25:08 +05:30
balajisoundar
afb9aa93c1
feat: Table widget V2 Inline editing validation for plain text & number column (#15954) 2022-09-13 11:11:59 +05:30