Commit Graph

784 Commits

Author SHA1 Message Date
Ayangade Adeoluwa
0e49c6efa9
fix: replace action execution cancellation toast errors with a better one (#16277)
* Remove error messages when user cancel action executions

* Add toast message after user cancels action execution

* Change error message

* Cypress validation for Bug #1609 added

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-31 18:08:42 +00:00
Rishabh Rathod
55082812b2
revert: "fix: dataTree mutation (#15952)" (#16406)
## Description

This reverts commit dbcc643ccf.

Fixes #16378

## Type of change

- Revert changes which impacted performance

## How Has This Been Tested?

Manual performance verification 

@ramsaptami 

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
2022-08-31 13:38:17 +00:00
Arsalan Yaldram
4c9484935b
fix: Property pane dropdown for currency and phone input widgets. (#16379)
* fix: Property pane dropdown for currency and phone input widgets.

* fix: added focus on open, added test cases
2022-08-30 11:33:31 +05:30
Aishwarya-U-R
f627b1ea8b
test: Script updates for flaky fixes (#16350)
* Table adding more wait time

* theme multiselect trial fix

* Ds form spec flaky fix

* TableV2 filter spec - app crash fix

* theme multiselect flaky fix

* ds form spec + community issues flaky fix

* spinner validatio added

* Theme_multiselect fix

* Json query run flaky fix

* DS add click flaky fix

* ds + locator update

* Skipping upgrade tests until fix

* Arango flaky fix

* Mongo.js flaky fix

* MySql CRud spec time increase

* ReadTableRowColumnData timeout increase
2022-08-29 04:36:17 +05:30
Aishwarya-U-R
3b90baf1d8
test: Script updates for flaky fixes (#16289)
* Auto completre fix

* Toast fixes

* Autocomplete js fix

* datatree mutation spec update

* Datatree -added  running api

* rmeoved unused ref

* Deletion time added

* Community issues spec fix

* AssertImportToast() update

* QueryAbort case fix

* Signature fix

* update

* UUID flaky fix

* Pomises spec + toasts updates

* Toasts updates

* ErrorReporting spec fix

* Scrolling mockdb fix

* Bug tests name change for easy identification

* bug spec file name update

* JSfunc fix

* Community issues table load time increase

* AssertContains() reduced wiat time

* AssertContains() update

* timeout added to mysql crud

* AssertContains revert

* AllInputWidget trial fix

* wait until table load ReadTableRowColumnData()

* fix

* testTimeout added

* ReadTableRowColumnData() revert

* path fix

* WaitUntilTableLoad() revert

* COmmunity issues row select fix

* Faker added

* wait time add for multiselect

* Mulipart fix

* Community issues spec fix

* AllInput spec update

* timeout 1 to 3

* update

* update

* EnterJSContext from JSEditor to PropPane ts

* update

* Removed unwanted comments

* fix

* UUID fix
2022-08-27 18:10:11 +05:30
Rishabh Rathod
dbcc643ccf
fix: dataTree mutation (#15952) 2022-08-24 22:06:54 +05:30
Aishwarya-U-R
f2c6e1ed61
test: Script updates for flaky fixes (#16143)
* Remove mongo coll dataset

* JSEXe spec flaky trial fix

* AbortActions to ts

* js func exe fix

* Abort spec fix

* Appsmith down flaky fix

* SelectWidget bug 12531 comment

* JSfun exec spec flaky fix

* Scrolling spec fix

* mysql crud fix

* mySql crud fix

* CRUD generate page fix

* jsonload flaky fix

* Automcomplete spec update

* jsOnload-1 spec flaky fix

* http patch

* patch install

* patch path correction

* cypress instal force

* removed

* yarn

* adding dev

* applypatch path corrected

* patch fix

* patch update

* patches

* patch file name update

* Adding blureprint patch back

* Cypress install removed

* Removed .only

* Autocomplete + Abort spec fix

* CI run key press fix

* https proxy update path fix

* JS editor parsing delay handle

* Autocmplete js fix

* Abort Query added

* Removed  "dev": "cypress open"

* js func exec spec fix

* js editor type flaky fix

* GetNClick revert

* Saving JS editor aft removal

* JS specs flaky fixes

* JSfun flaky fix

* Auto complete spec fi

* jSonkoad1 spec fix

* JSOnload spec

* Auto complete JS spec fix

* Removing waiting for toasts

* jsfun fix

* EditJSObj Preetify update

* contains index or colection

* SetQueryTimeout update

* DS toasts handle

* POstgresCRUD toast change

* POstgres CRUD toasts fix

* Bug 15372 spec toast fix + Api timeout update

* Added DeleteDSDirectly()

* Arango spec fix

* JSEditor indent spec - 6 fix

* JSeditor indent spec update 7, 1,2

* removed only

* JSEDitor Indent spec fixes

* removed only

* MySQK CRUD fixes

* BUg 14006 spec fix

* Mongo spec toast fix

* Mongo update

* text wrapping spec flaky fix
2022-08-24 19:53:41 +05:30
Dhruvik Neharia
11d33b79cd
feat: Add USA to the Map Chart Widget (#16130)
* feat: Add USA to the Map Chart Widget

* test: Add USA test to Map Chart Cy Spec
2022-08-24 13:49:24 +05:30
balajisoundar
38f9661e45
fix: Table widget pagesize in short row height mode (#16045) 2022-08-23 17:19:59 +05:30
Rimil Dey
b502332076
fix: catch block not working in firefox and safari for async functions (#15376)
* Add error.message only to data.reason, since the call stack being sent to responsePayload is different for different browsers. This fix ensures a consistent behaviour across all browsers

* Add integration tests

* Update test to typescript

* Fix error message

* Use new error instead of message object

* Code review fix

* Add else block to catch unknown errors

* Update tests

* Get back to original solution - error solution not working in safari
2022-08-23 11:32:31 +05:30
Trisha Anand
8f3591615a
feat: RBAC framework (#14823)
Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
2022-08-22 23:27:07 +05:30
Rishabh Rathod
83d30b8d05
fix: autocomplete fixes & enhancement (#15857) 2022-08-22 11:17:24 +05:30
ashit-rath
893fd34cdd
perf: Widget re-rendering refactor (#14485)
* initial commit

* props hoc

* changes

* removed ignores and withWidgetProps

* added extra props to canvasStructure

* widget props changes

* list widget changes

* reintroduced widget props hook and other refactors

* remove warnings

* added deepequal for childWidgets selector

* fix global hotkeys and tabs widget jest test

* fix main container test fix

* fixed view mode width

* fix form widget values

* minor fix

* fix skeleton

* form widget validity fix

* jest test fix

* fixed tests: GlobalHotkeys, Tabs, CanvasSelectectionArena and fixed main container rendering

* minor fix

* minor comments

* reverted commented code

* simplified structure, selective redux state updates and other inconsistencies

* fix junit test cases

* stop form widget from force rendering children

* fix test case

* random commit to re run tests

* update isFormValid prop only if it exists

* detangling circular dependency

* fixing cypress tests

* cleaned up code

* clean up man cnavas props and fix jest cases

* fix rendering order of child widgets for canvas

* fix dropdown reset spec

* adding comments

* cleaning up unwanted code

* fix multiselect widget on deploy

* adressing review comments

* addressing minor review comment changes

* destructuring modal widget child and fix test case

* fix communityIssues cypress spec

* rewrite isVisible logic to match previous behaviour

* merging widget props with component props before checking isVisible

* adressing review comments for modal widget's isVisible

Co-authored-by: rahulramesha <rahul@appsmith.com>
2022-08-19 15:40:36 +05:30
Bhavin K
d48976105d
fix: search functionality in tree select (#16073) 2022-08-18 16:00:37 +05:30
Tolulope Adetula
e36a28d7da
feat: Select default value control (#15856)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* Fix: Default Value Control

* fix: updated Multiselect

* Fix: issues with curly braces

* fix: Serverside filtering issue

* fix: revert commit

* Fix: empty commit

* fix: copy-paste widgets

* fix: use WidgetOperationSaga to fix copy-paste

* fix: update comment

* feat: add test for copy-past Select and MultiSelect
2022-08-18 08:10:58 +01:00
Aishwarya-U-R
ba9e4458a2
Automated test for JSObj OnPageLoad + flaky fixes + fix for timeout runs (#16028) 2022-08-18 12:00:28 +05:30
Favour Ohanekwu
7c5f6c4bd4
Fix Show invalid page UI for invalid jsobject page (#16056) 2022-08-17 17:27:54 +05:30
Satish Gandham
3990162ca6
ci: Update the access token in ci script. (#16032)
* Clean up the perf folder and update integration commnds to use the new repo

* Use a different token for github auth

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-08-16 14:33:55 +05:30
akash-codemonk
583320bea6
fix: hide explorer menu on scroll (#15537) 2022-08-16 14:18:47 +05:30
NandanAnantharamu
b6b762f623
Updated default-meta fix (#16003) 2022-08-16 10:31:12 +05:30
Aishwarya-U-R
820846ce8b
Cypress version upgrade for timeout issue resolution (#15917) 2022-08-16 09:31:16 +05:30
Bhavin K
0aafa388ec
fix: navigation issue in the Iframe widget due to src change (#15656)
* fix: navigation issue in the Iframe widget due to src change

* test: added test case for the iframe widget
2022-08-16 09:12:38 +05:30
Keyur Paralkar
d39cecbbb4
feat: chartwidget reskin feedback (#15621)
* style: added styles to chart configs

* style: adjusted axis names and legend position

* style:
* adjusting legend position
* removed background property at the widget level
* exposed current theme data at widget level

* fix: addressed feedback on chart widget reskin

* fix:
* style according to feedback
* styled custom charts

* fix:
* added migration for accentColor and fontFamily
* implemented reskinning feedback

* fix: changed the position of properties in custom chart config

* fix:
* added unit test for migration
* changed the caption color

* fix: spacing fix

* fix: added accentColor and fontFamily defaults

* test: added cypress test for chart reskinning

* test: fixed cypress test failure
2022-08-12 17:40:17 +05:30
Ayangade Adeoluwa
0e36569b06
feat: Abort Query Execution (#15775)
* Snaps response view to certain height and adds abort query execution feature

* make raw string a constant

* Add cypress tests

* Remove theme variable

* move raw strings to constants in messages.ts file

* Fix test case description

* Comment out query abort action execution

* cy fix

* Fix abortion of parallel action execution like onPageLoad

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-12 12:49:17 +05:30
Rishabh Rathod
e255593e28
fix: Improve Autocomplete for local vars, JSObject & ButtonGroup Widget
Add Autocomplete support for
- local variables 
- JSObjects
- ButtonGroupWidget
Remove Autocomplete suggestion for
- `eval`
-  undefined global values like `tabs`
2022-08-11 15:29:38 +05:30
albinAppsmith
1a6936435d
fix: design system package conflict with styled-component (#15914) 2022-08-11 15:13:15 +05:30
Tolulope Adetula
c6ed1b7214
fix: select default value validation (#15846)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* fix: add jest test

* Empty Commit

* Fix: Empty commit to re-reun

* empty commit

* Empty Commit

* cy fix

* json field event fix

* TableFilter failure fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 10:02:55 +05:30
Rishabh Rathod
78379d4718
fix: update def on widget property name update (#15490) 2022-08-10 10:50:08 +05:30
Bhavin K
f85cbb9938
fix: reset the filepicker widget when the user goes to a different link (#15626)
* fix: reset the the fileficker widget

* test: add test-case for file-picker
2022-08-05 19:00:01 +05:30
ashit-rath
ab5eb0e325
fix: JSONForm field event trigger binding get updated formData values (#15650)
fix: JSONForm field event trigger receive updated formData
2022-08-05 11:49:24 +05:30
NandanAnantharamu
9fe6d0a591
test: updated flaky test under default meta (#15707)
* updated flaky test

* Updated tests

* updated tests

* updated the tests

* updated tests
2022-08-05 11:38:46 +05:30
Pawan Kumar
89b39e239b
fix: Reskinning Radio + Toggle + Checkbox (#15329)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* fix alignment issue

* fix cypress tests

* fix snapshot tests
2022-08-05 10:16:42 +05:30
arunvjn
4e5b21600d
Optimise code editor renders (#15405) 2022-08-04 11:10:44 +05:30
Aishwarya-U-R
8fd3b94f8c
test: Automated tests for Postgres Datatype - UUID Cont., + Flaky fixes (#15582)
* UUID continued

* Edit Obj save

* Added TypeTextIntoField()

* Added paste back to JSEDitor context

* ExecuteActions spec ts

* ApiOnPage load spec ts

* propPane.UpdatePropertyFieldValue update

* fix

* AddDsl method update

* UUID flake fix

* DS docs spec

* GS & Firestore stub specs ts

* faliure fixes

* title fix

* Promises flake fix

* UUID update

* Autocomplete bug file name update

* Restapi flaky fix

* Flaky fix

* UUID fix

* UUID done

* UUID fix

* UUID fix

* Promy fix
2022-08-04 10:18:15 +05:30
NandanAnantharamu
e528286b9d
test: test for default meta feature (#14872) 2022-08-03 17:48:41 +02:00
Favour Ohanekwu
8ec31061e7
fix: Add support for crypto API in linting (#15607)
## Description

This PR adds [crypto web api](https://developer.mozilla.org/en-US/docs/Web/API/Crypto) support in linting

Fixes #15469 


## Type of change


- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- [x] https://github.com/appsmithorg/TestSmith/issues/1996

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented on my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-03 20:05:33 +05:30
Tolulope Adetula
9e66a774dd
feat: Multiselect defaultValue Validation Check for ServerSide Filtering(On/Off) (#15491)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests
2022-08-03 14:17:07 +01:00
arunvjn
7c37f7b35a
Add a new rule to show selectedRow in autocomplete's best match (#15406)
Refactored auto complete sorting logic.
2022-08-03 12:54:38 +05:30
Hetu Nandu
887832d29a
refactor: deprecate commenting and notifications (#15484) 2022-08-03 12:32:49 +05:30
Anagh Hegde
1fb4cac6f5
chore: Update text message for git remote url placeholder (#15553)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-08-02 12:55:51 +05:30
Aishwarya-U-R
5369edc245
test: Automated tests for Postgres Datatype - UUID + Flaky fixes (#15535)
* Binary spec updated

* flaky fix

* Removed skip, added only - recaptcha spec

* fix

* Reduced defaultCommandTimeout

* Adding global timeout

* failure fixes

* toForceClick to btn clicks js

* Elastic search flaky fix

* Passing Params - moved to CreateDs()

* Combining similar cases

* Removing unsed variables

* JSON Form widget specs moved

* flaky fix

* Mock db duplicate handling

* UUID added

* UUID spec update

* S3 fix
2022-08-01 17:16:00 +05:30
Tolulope Adetula
ef956ecad0
feat: Select defaultValue Validation Check for ServerSide Filtering(On/Off) (#15133)
* feat: defualt value check

* fix: Empty commit trigger deploy

* Fix: add more tests

* fix: improve validation

* Feat: improve jest test

* fix: more tests

* Fix: add github link

* Update app/client/src/widgets/SelectWidget/widget/index.tsx

Co-authored-by: ashit-rath <ashit@appsmith.com>

* fix: add more comment to issue

* fix: failing test

* fix: cypress config

* Fix: empty commit

* fix: select issue

* Fix: failing tests

* fix: failing Tests

Co-authored-by: ashit-rath <ashit@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2022-08-01 06:02:48 +01:00
balajisoundar
a6d37625a1
fix: provide access to currentRow in table widget menubutton items (#15457) 2022-08-01 10:31:34 +05:30
Aishwarya-U-R
73c0c9eecd
test: Automated tests for JSObjects + Flaky fixes (#15269)
* FOcusElement

* Specs into folders

* Bug14987_spec.js flaky fix

* S3 flaky trial fix

* CreateQuery() added

* Spec rearranged

* Sepcs rearranged

* MySql table load fix

* Added bug id JSOPageLoad

* Postgress idle connections spec fixed

* fixes

* fix

* fix

* Import fix

* Mock DB spec added

* flake fix

* Flake fix

* fix custom_chart_spec and gitSyncedApp_spec tests

* JSOnLoad after Import app scripted

* fix

* mock db name fix

* fix

* tc #58 scripted

* fix

* fixes

* moved spec

* increased wait time

* table filter fix

* Import time fix

* jsONload spec fix

* jsonload spec fix

* failure fixes

* "videoCompression": false

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 14:18:25 +05:30
Keyur Paralkar
c396224fe8
fix: filePicker widget re-skinning (#15183)
* fix:
* added css variables for primary color
* added styles for dropHint custom icon

* feat:
* styled the remove uploaded file icon to match re-skinning
* added theme font-family to the contents inside the upload modal
* styled upload button to match re-skinning

* feat:
* set cancel button color to theme's primary color
* set the close button style according to theme
* set the border radius of the upload modal
* set the error message styles in accordance with re-skinning

* fix: cross mark position on the top right corner of upload modal

* fix: added hover background color on modal back and add more files button

* fix: added border radius fix for file remove button

* fix: modal close icon

* fix: addressed feedback from dilip

* fix: font-family issue inside the modal

* test: added cypress test to test styling logic
2022-07-29 10:29:02 +05:30
ashit-rath
b21c8cff31
fix: JSONForm input field REGEX validation (#15316)
* fix: JSONForm input field REGEX validation

* fix cypress test
2022-07-29 09:49:39 +05:30
Parthvi
ed90490005
test: fix git cypress tests (#15508)
* fix git tests

* add wait for git status call to complete

* fix git tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 08:33:32 +05:30
Arsalan Yaldram
9dea163172
fix: show clear input icon on allow clear value (#15232)
* fix: show clear input on allow clear value

* fix: truncate select input on small size
2022-07-27 22:33:05 +05:30
akash-codemonk
3fdce8462c
fix: onboarding visual distraction from the entity explorer being hidden (#15446) 2022-07-27 19:29:43 +05:30
Favour Ohanekwu
e5d89e7099
chore: Upgrade astring version from v1.7.5 to v1.8.3 (#15245)
## Description
Previous version of the astring library doesn't preserve parenthesis when transforming AST to JS Code. This led to syntax error when null coalesce and logical expressions are used together.

The latest version of astring library fixes this.

<img width="1291" alt="screenshot_2022-07-16_at_04 29 52" src="https://user-images.githubusercontent.com/46670083/179581475-863d70f2-0886-403a-a667-a32ad93e76b7.png">


Fixes #15283 


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
Test plan

- [x] https://github.com/appsmithorg/TestSmith/issues/1970

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-27 14:48:39 +05:30