Commit Graph

743 Commits

Author SHA1 Message Date
Rishabh Rathod
d7cdf6f84b
fix: Add escaping special characters before JSON.parse (#9293)
* Add escaping special characters before JSON.parse
2021-11-25 16:22:40 +05:30
Aswath K
41c7c344b4
fix: radio group widget crash when one of options becomes null (#9303) 2021-11-25 14:59:16 +05:30
Pawan Kumar
d96c4981ca
fix: Button size inside the Table widget has increased + Property pane's panel not scrollable + Alignment issues (#9318) 2021-11-24 17:55:07 +05:30
Vicky Bansal
bf513f5c60
fix: Hide scrollbar in header and show when user hovers over header in Table Widget (#9323)
Co-authored-by: root <pawan@appsmith.com>
2021-11-24 15:27:26 +05:30
Paul Li
3f87f4959e
fix: Table Widget Icon Button should be having a default variant (#8664)
* fix: Table Widget Icon Button should be having a default variant

-- Add update logic for button variant property

* fix: Table Widget Icon Button should have default variant

-- Revert old solution
-- Set default button variant to PRIMARY both in getTableColumns and in propertyConfig

* fix: Table Widget Icon Button should have default variant

-- Change comments for updateIconAlignment utility function
-- Create a migration for button variant

* fix: Table Widget Icon Button should have default variant

-- Remove unused index parameter from forEach statement

* fix: Table Widget Icon Button should have default button variant

-- Fix on misuse of forEach on primaryColumns object

* fix: Table Widget Icon Button should have default variant

-- Change buttonVariant to TERTIARY instead of PRIMARY
2021-11-23 22:10:13 +08:00
Bhavin K
ffefdcccd8
fix: added muted flag and updated helper text (#9259) 2021-11-23 15:10:43 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking (#7361)
* add tailwindcss

* docked property pane

* uncomment a line

* make entity explorer as drawer on unpin

* remove unused imports

* add pin state in  reducer

* add menu icon in header

* fix widget sidebar

* fix widgets sidebar

* style property pane

* update property pane css

* update icons in property pane

* update property pane header styles

* update spacing

* fix few ui issues

* wip: preview mode

* wip:preview mode

* remove unused import

* comments sidebar in app and edit mode

* fix order of import

* use selected state for property pane

* update scrollbar style

* add classes to sidebar and property pane

* make widgets editor fluid

* make widgets editor fluid and refactor logic

* resize the widgets editor if explorer is pinned

* add shortcut for preview mode

* fix link for tabs in edit mode

* zoom in/zoom out for 0.75

* fix chart widget + table widget crashing

* allow zooming of canvas

* fix weird canvas draw issue + update container for handling zoom

* add actions for is panning

* allow panning with grab cursor

* reset panning + zooming when entering preview mode

* add grabbing cursor when grabbing

* only prevent default when space key is pressed

* dont allow zoom in preview mode

* remove unused imports

* fix dont allow zoom in preview mode

* fix ux of panning on space hit

* make fluid as the default app layout

* chart spec

* fix dropdown_on change spec

* fix add widget table and bind spec

* remove draggable property pane spec

* fix container spec

* fix form widget spec

* fix jest test

* fix the function typo

* remove clicking of close button for property pane in cypress tests

* remove property pane actions test

* fix drag and drop test failing

* add cypress selector id to back button in property pane

* fix toggle js spec

* fix merge conflicts from new design system

* editor header

* fix product updates styles + widget card

* remove all unused imports

* fix dynamic layout spec

* fix entity explorer tab rename test failing

* fix table spec

* fix bind tabletextpagination spec

* fix js object spec

* fix entity explorer rename issue

* fix cypress test

* fix cypress command wrong commit

* fix tab spec

* fix property pane copy tests

* add zoom header

* zoom levels

* make property pane sidebar resizable

* add multi select property pane

* fix widget search bug

* update property pane width in state on drag end

* fix viewer header

* fix editor header

* update editor header + remove zooming

* update small style

* dont allow closing of explorer when resizing

* fix jest test

* fix dropdown widget jest test

* preview test case wip

* add entity explorer pinning tests + preview mode tests

* add tooltip in layout control + add padding bottom in property pane view

* incorporate aakash feedbacks

* fix preview mode margin issue

* remove panning code

* fix cypress failing test

* uncomment jest test

* remove redundant code

* fix maincontainer test

* incorporate review feedbacks

* incorporate aakash feedbacks

* review feedbacks

* incorporate review feedbacks

* incorporate qa feedbacks

* fix dynamic layout spec

* updated test based on latest change

* dsl updated

* Updated dsl

* Updated dsl

* resize deselects widget issue.

* fix canvas height issue

* fix typo

* incorporate qa feedbacks

* incorporate qa feedbacks

* incorporate qa feedbacks

* update color for setting control for widget name

* fix onboarding styles conflicts

* Updated tests

* fix application overflow issue

* updated test method

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
Yash Vibhandik
75a25925b8
fix: #5980 added clear all filters button and close filter pane button (#8734)
* fix: #5980 added clear all filters button and close filter pane button

* height updated

* updated class names for test case
2021-11-23 11:53:26 +05:30
Yash Vibhandik
399eabd987
fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name (#8770)
* fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name

* highlighted duplicate column labels, show error message only when duplicate column label focused

* updated test case

* updated duplicate label indicator logic for test case
2021-11-23 11:35:01 +05:30
onifade boluwatife
e466495b5b
fix: Date picker must exit on pressing esc key when 'close on selecting' is turned off (#8425)
* refactored date picker a little
* minor refactor of date picker
* update
2021-11-22 07:08:36 +00:00
Bhavin K
e9bee3e511
fix: handled component update value logic (#9232)
* handled component update value logic

* Update index.tsx
2021-11-19 17:35:40 +05:30
imgbot[bot]
3eec0594f7
chore: [ImgBot] Optimize images (#9208)
*Total -- 929.35kb -> 640.18kb (31.11%)

/deploy/helm/images/helm-ssl-config.png -- 194.07kb -> 104.73kb (46.03%)
/static/images/client-wsl-yt-video-thumbnail.png -- 690.06kb -> 490.46kb (28.93%)
/app/client/src/assets/icons/widget/table/checkbox-line.svg -- 0.20kb -> 0.19kb (7.77%)
/app/client/src/assets/icons/widget/table/checkbox-check.svg -- 0.21kb -> 0.20kb (7.41%)
/app/client/src/assets/icons/comments/commentCursor.svg -- 1.10kb -> 1.07kb (3.1%)
/app/client/src/assets/icons/widget/recorder/recorder_recording.svg -- 0.14kb -> 0.14kb (2.74%)
/app/client/src/assets/icons/widget/recorder/recorder_pause.svg -- 0.23kb -> 0.23kb (2.53%)
/app/client/src/widgets/AudioWidget/icon.svg -- 0.39kb -> 0.39kb (1.98%)
/app/client/src/assets/icons/widget/recorder/recorder_complete.svg -- 0.23kb -> 0.23kb (1.67%)
/app/client/src/assets/icons/comments/unpinIcon.svg -- 0.28kb -> 0.27kb (1.41%)
/app/client/src/assets/icons/control/underline1.svg -- 0.77kb -> 0.76kb (1.27%)
/app/client/src/assets/icons/ads/plus.svg -- 0.24kb -> 0.24kb (1.22%)
/app/client/src/widgets/TextWidget/icon.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/assets/icons/ads/arrow-right-line.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/assets/icons/ads/up-arrow.svg -- 0.26kb -> 0.26kb (1.11%)
/app/client/src/assets/icons/ads/down-arrow.svg -- 0.29kb -> 0.28kb (1.02%)
/app/client/src/assets/icons/ads/dropdown.svg -- 0.23kb -> 0.23kb (0.83%)
/app/client/src/assets/icons/menu/run.svg -- 0.41kb -> 0.41kb (0.71%)
/app/client/src/assets/svg/no_entities_found.svg -- 0.98kb -> 0.98kb (0.7%)
/app/client/src/assets/icons/ads/snippet.svg -- 0.57kb -> 0.56kb (0.69%)
/app/client/src/assets/icons/ads/share-2.svg -- 0.46kb -> 0.46kb (0.63%)
/app/client/src/assets/icons/widget/recorder/recorder_default.svg -- 0.94kb -> 0.93kb (0.63%)
/app/client/src/assets/icons/widget/button-group.svg -- 1.29kb -> 1.28kb (0.53%)
/app/client/src/widgets/ButtonGroupWidget/icon.svg -- 1.29kb -> 1.28kb (0.53%)
/app/client/src/assets/icons/menu/beta.svg -- 1.00kb -> 1.00kb (0.49%)
/app/client/src/assets/svg/checkmark.svg -- 0.23kb -> 0.23kb (0.43%)
/app/client/src/assets/icons/menu/js-function.svg -- 0.91kb -> 0.91kb (0.43%)
/app/client/src/assets/icons/menu/js-group.svg -- 1.81kb -> 1.80kb (0.38%)
/app/client/src/assets/icons/ads/file-copy-line.svg -- 0.86kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/control/color-picker.svg -- 1.46kb -> 1.45kb (0.34%)
/app/client/src/assets/icons/ads/git-commit-line.svg -- 0.88kb -> 0.88kb (0.33%)
/app/client/src/assets/icons/ads/key-2-line.svg -- 1.28kb -> 1.28kb (0.31%)
/app/client/src/assets/icons/menu/js-file.svg -- 2.33kb -> 2.32kb (0.29%)
/app/client/src/assets/icons/widget/recorder/recorder_no_permission.svg -- 1.63kb -> 1.63kb (0.24%)
/app/client/src/assets/icons/ads/support.svg -- 1.23kb -> 1.22kb (0.24%)
/app/client/src/assets/icons/ads/cloudy-line.svg -- 1.38kb -> 1.38kb (0.21%)
/app/client/src/assets/icons/ads/user-v2.svg -- 1.55kb -> 1.54kb (0.19%)
/app/client/src/assets/icons/ads/upload-v2.svg -- 1.76kb -> 1.75kb (0.17%)
/app/client/src/assets/icons/ads/shield-success.svg -- 3.03kb -> 3.03kb (0.13%)
/app/client/src/assets/icons/ads/shield-error.svg -- 3.03kb -> 3.03kb (0.13%)
/app/client/src/assets/icons/ads/git-branch.svg -- 2.80kb -> 2.80kb (0.1%)
/app/client/src/assets/svg/loader-2-fill.svg -- 3.78kb -> 3.78kb (0.1%)
/app/client/src/assets/icons/ads/gear.svg -- 3.23kb -> 3.23kb (0.09%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-11-19 09:43:30 +05:30
balajisoundar
6e277d333e
fix: Table column sorting with null values (#8982)
Now cells with empty values (null &  ""), will get pushed to the bottom of the table while sorting.
2021-11-18 18:27:25 +05:30
Aswath K
701207718b
fix: Unable to drag disabled button (#8206) 2021-11-18 15:52:04 +05:30
Pawan Kumar
83ecb8cc8a
fix: second time file upload is failing in S3 crud page (#9213) 2021-11-17 19:03:47 +05:30
Yash Vibhandik
9c751ae58e
fix: #8528 Added default Icon column (#8733)
* fix: #8528 added defaultIconName for controlType ICON_SELECT and updated default value for column type icon button

* test case update
2021-11-16 16:12:20 +05:30
Yash Vibhandik
27d12754c6
fix: 8537 submenu color when disabled (#8948)
* fix: 8537 submenu color when disabled

* updated test case
2021-11-16 16:00:46 +05:30
haojin111
616a1fac16
feat: progress, loading and error states for git flows, pull button and minor misc changes (#9052)
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Rishabh Saxena <rishabh@appsmith.com>
2021-11-16 15:54:38 +05:30
Bhavin K
7032ee6b89
fix: Update designs for select widgets according to Figma (#8594)
* updated design as per figma

* updated design, fix cypress test

* item width fix as required

* label functionality in select, tree-select wids

* changes as required

* label, placeholder and default focused item logic changes for select

* updated border color for invalid selected value

* fix for colors file
2021-11-16 09:27:38 +00:00
Anand Srinivasan
8c60a8b870
feat: unified style for disabled widgets (#8731)
* basic input fields - unified disabled style

* select widgets - unified disabled style

* icon button - change disabled color

* radio group and switch - unified disabled style

* checkbox, radio, switch - disabled label color

* change disabled text color for all input fields

* chnage lable color on disabled state

* RTE header - not allowed cursor on disabled mode

* currency label - disabled color change

* switch and radio group css clean up

* replace text colors with GREY shades

* change label color for disabled switch and radio group

* restructure numeric input css

* numeric input buttons updated

* css fixes for mozilla

* table button disabled color

* change label color - numeric input dropdown

* hover only when enabled - numeric input

* all button colors updated

* remove unwanted wrapper

* update label color

* name color in constants

* use grey palette for switch component color
2021-11-15 11:59:06 +05:30
Paul Li
d700b62ac5
feat: Spellcheck property for the input widget (#8496)
* feat: Spellcheck property for the input widget

-- Add a new widget boolean property, isSpellCheck
-- Add the corresponding Cypress test cases

* feat: Spellcheck property for the input widget

-- Place isSpellCheck property just after autoFocus property
2021-11-12 15:34:10 +08:00
Bhavin K
2f25dba34b
feat: design updates as per figma (#8504) 2021-11-11 17:41:43 +00:00
Paul Li
069f0645d3
fix: The value is always empty object in AudioRecorder Widget (#8868)
* fix: The value is always empty object in AudioRecorder Widget

-- Export blob contents in raw binary, data url, and text

* fix: The value is always empty object in AudioRecorder Widget

-- Create new meta properties dataAsDataURL, dataAsRawBinary

* fix: The value is always empty object in AudioRecorder Widget

-- Rename meta properties

* fix: The value is always empty object in AudioRecorder Widget

-- Remove unnecessary constants.ts
2021-11-11 20:16:08 +05:30
Yash Vibhandik
4b2c1fc316
fix: 8543 added disabled flag support in icon button table widget (#8950)
* fix: 8543 added disabled flag support in icon button table widget

* updated test case
2021-11-11 16:09:21 +05:30
Bhavin K
0a8561a007
feat: create button group widget (#7337)
* Widget with new file structure

* merged utils file to solve onClick err

* updates as required

* design update: buttonStyle - buttonColor

* updated widget config response

* updated buttonVariant changes

* solved btn list delete issue

* updates as required

* design fix for menu item

* fixed theme color updates
2021-11-11 06:41:05 +00:00
Nidhi
51246a0869 fix: Reverted AST 2021-11-10 20:13:21 +05:30
balajisoundar
e76e515426
fix: Table widget column with 0 as value should render 0 (#8998) 2021-11-09 18:39:09 +05:30
Tolulope Adetula
dbbb7b84b2
fix: disable sorting in view mode (#7387)
* fix: disable sorting in view mode

* fix: add sortable to property pane

* fix: fix failing tests

* fix: Add cypress test

* fix: remove unneccesary useMemo

* fix: sortable columns

* fix: default switch value

* fix: revert switch control and add migrations

* fix: migration
2021-11-08 21:08:39 -08:00
Bhavin K
568d859af1
fix: theme updated with new variant keys (#8680)
* theme updated with new variant keys

* updated Menubtn styles for default

* theme update as required

* added jest test for WidgetUtils
2021-11-06 08:00:57 +00:00
Rishabh Rathod
bef48e8a79
chore: Config changes (#8564)
Change eslint config for console logging from error to warn
Add babel auto-import resolver to avoid using relative paths
2021-11-05 11:19:19 +05:30
Tolulope Adetula
92fe8e8d33
fix: selectedRows issues (#8837)
* fix: selectedRows issues

* fix: sanitized selectedRowIndices
2021-11-03 03:56:49 -07:00
Alyssa Holland
fe73e97206
fix: Enhance sort icon (layout) in Table widget (#8140) 2021-11-03 16:15:02 +05:30
Hetu Nandu
c0d0037ce2
feat: Extract references in code with AST (#8617)
Co-authored-by: Nidhi <nidhi@appsmith.com>
2021-11-03 13:12:31 +05:30
Bhavin K
2956162d7f
feat: new tooltip, updated cypress tests (#8759) 2021-11-03 09:24:19 +05:30
Confidence Okoghenun
04bae5477b
feat: Updates widget default state (#8562) 2021-11-02 09:47:49 +05:30
Yash Vibhandik
7229ef5b37
fix: design audit input widget (#8498)
* fix: 8041 Added design changes

* updated password input design and error border design

* updated green color names
2021-11-01 20:14:08 +05:30
Arpit Mohan
8c397b81a9
chore: Fixing typo in tooltip for Map widget property (#8914)
Fixes #8912
2021-11-01 20:01:49 +05:30
Abdul Rehaman
64696de8ed
fix: [Bug]Audio option hidden on edit mode (#8450)
* fix: [Bug]Audio option hidden on edit mode
2021-11-01 15:54:50 +05:30
Abdul Rehaman
2e2e0d1d51
fixed treeselect bug (#8474) 2021-10-30 23:31:55 -07:00
Bhavin Ag
da5baba982
fix: rename no item to no results in select components (#8666)
* style: update no results found style for multi select

* style: update empty data text for multi select widget

* style(SingleSelectTree): update style for no items found

* style: remove minimum width from empty containers

* test: add integration test for tree select

* test: add integration test for empty data for multi select

* test: add integration test for empty states
2021-10-30 23:25:23 -07:00
rahulramesha
ce453fd259
fix: Copied modal close and mobile modal bug fix (#8497)
* fix for copied widget

* copied modal paste on maincontainer fix

* mobile modal fix

* added logic to paste modal widget on the main container only

* added check only for modal Widget close since the saga seems to be shared for other scenarios
2021-10-28 07:41:19 +05:30
Abdul Rehaman
eae04e29a8
fix: [Bug] The name of the Widget is 'MultiTreeSelect' in Widget Pane… (#8371)
* fix: [Bug] The name of the Widget is 'MultiTreeSelect' in Widget Pane and 'MultiSelectTree' in the canvas #8306

* Resolves #8306 and #8436

* Updated commit

* Update, removed treeselect commit

* Removed space
2021-10-27 14:26:50 +01:00
balajisoundar
661fb88171
fix: Don't trigger onpause on onend in audio widget (#8843) 2021-10-27 17:55:19 +05:30
Vicky Bansal
8c4e7d331e
feat: Set selectedRow for multiple row selection in table widget (#7935) 2021-10-27 11:43:48 +05:30
Paul Li
b3aac80146
feat: Table widget, column settings - add helper to Computed value (#8634)
-- Add helpText for computedValue property of column settings

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-10-26 17:42:56 +05:30
Yash Vibhandik
a461c2dd7a
fix: #8042 updated dropped height width and default color (#8304) 2021-10-26 15:28:54 +05:30
Anand Srinivasan
9e55ca9ff0
fix: table widget design (#8426)
* Table - multi-select checkbox and selected row color update

* table: change hoverstyle on multi-select checkbox

* re-order conditions

* table widget: use px for positioning checkbox

* change hover style for unselected row

* check box remains white on hover

* fix cypress test

* table search box - highlight on active

* search cancel icon updated

* move svg to assets folder
2021-10-26 14:01:27 +05:30
Tolulope Adetula
3a40b76790
fix: page number reset (#8681)
* fix: page number reset

* fix: add cypress test
2021-10-26 01:12:03 -07:00
Tolulope Adetula
e4caaacbfd
fix: fixing table widget updatehook (#7992)
* fix: use column keys to update derived column

* fix: resolve conflicts

* fix: onclick trigger fro derived columns
2021-10-25 23:52:45 -07:00
Rafael Baldasso Audibert
0e22f26621
fix: Change "Allow Horizontal Scroll" text to "Allow scroll" (#8085)
* chore: Change "Allow Horizontal Scroll" to "Allow Scroll"

* chore: Hide option to choose scroll for pie chart

* fix: Fix prettier errors

* feat: Add migration to allowScroll for `CHART_WIDGET`s

Closes #4227

* fix: Fix chart widget prop recursively

Per https://github.com/appsmithorg/appsmith/pull/8085#discussion_r733442011
Closes #4227
2021-10-25 17:09:39 +05:30