d70977abeb
9479 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Diljit
|
d3f1788dfb
|
chore: filter smartlook urls from tracing assets in page load instrumentation (#35738)
## Description Filter smartlook urls from page load instrumentation. These api calls need not be tracked to measure page load performance. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10446808927> > Commit: c81e741f9dcb071f0961903e806e60260a744677 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10446808927&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 19 Aug 2024 04:16:17 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No |
||
|
Ashit Rath
|
31760057ce
|
perf: JSONForm widget optimise calling of clear errors (#35717)
## Description During on page load for a jsonForm widget, the `clearErrors` method was getting called even if there wasn't any error to clear. This led to significant number of this function execution for a large scale application For more info - https://theappsmith.slack.com/archives/C024GUDM0LT/p1723206363693759 Fixes https://github.com/appsmithorg/appsmith/issues/35739 ## Automation /ok-to-test tags="@tag.JSONForm" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10440802784> > Commit: 8f449b75c15bd57a65ca75c5b7cffc7417f645c5 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10440802784&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.JSONForm` > Spec: > <hr>Sun, 18 Aug 2024 13:21:29 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved error handling in form validation to ensure errors are cleared only when necessary. - **Bug Fixes** - Enhanced logic for retrieving current error states to provide a more robust user experience when filling out forms. - **Tests** - Expanded test coverage for form validation logic, including various scenarios to ensure correct behavior under different conditions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
32f2986662
|
chore: fix flaky datepicker spec. (#35726)
## Description In the past we attempted to remove the `DatePickerV2_spec` from flaky list after successful `/ci-limit-test` runs ([EE PR with runs](https://github.com/appsmithorg/appsmith-ee/pull/4736)). But the very next day it had to be added back to the flaky list. There was certainly a problem which was not getting caught on local and `ci-limit-test` runs. Upon observing the [last known failure run of this spec](https://internal.appsmith.com/app/cypress-dashboard/run-details-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10096251875&attempt=5&selectiontype=test&testsstatus=failed&specsstatus=fail), this error got highlighted: > CypressError: Timed out retrying after 100000ms: `cy.wait()` timed out waiting `100000ms` for the 5th response to the route: `updateLayout`. No response ever occurred. Upon further debugging and a loooot of local runs I noticed that even though we were changing the `Max date` at the end of this spec does not do anything(on the product UI) and more importantly had no impact on the test run. So we removed it. The good thing is that in current [EE PR](https://github.com/appsmithorg/appsmith-ee/pull/4907) as well there are no failures. > PS: I would still be on alert after merging to notice any more failures and add it back to flaky, if it troubles other team members. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datepicker, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10446454718> > Commit: b0348f4f13c6b36cb35b0a5fd596513d42ab7837 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10446454718&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datepicker, @tag.Sanity` > Spec: > <hr>Mon, 19 Aug 2024 03:36:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the DatePicker component's test to remove the maximum date constraint, allowing for a broader range of valid dates during testing. - Revised conditions for tooltip assertions related to date range validation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Diljit
|
e79e0ffa43
|
chore: Remove some logs and errors from console - 1/n (#35674)
## Description This PR removes some of the errors and logs from the console. The following fixes were added to this PR - Remove the error => Refused to set unsafe header "Expect" - Remove the aria label warnings - Remove the logs from service worker in dev mode Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10438062046> > Commit: 63fbfb22f40508ab298c765c4edbba7c42a125e1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10438062046&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Sun, 18 Aug 2024 06:12:03 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Accessibility Improvements** - Added `aria-label` attributes to the `StyledSearchInput` and `Label` components for enhanced screen reader support. - Improved the semantic structure of the `Label` component by providing additional context for assistive technologies. - **Performance Enhancements** - Removed the `Expect` header from API requests to streamline the request process. - **Logging Adjustments** - Disabled development logs in the service worker to enhance performance in production environments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Pawan Kumar
|
ace7c517f3
|
chore: restructure stories (#35725)
 Summary: 1. Renamed Design system to WDS 2. Moved Testing to WDS URL to test: https://64c89da059b7d62ad3a60544-aohsgyzraz.chromatic.com/?path=/docs/ads-components-avatar--docs /ok-to-test tags="@tag.Widget" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10422337445> > Commit: bbeb8f384f7d99fddd949755a6ddaf4cbd40c42c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10422337445&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget` > Spec: > <hr>Fri, 16 Aug 2024 16:29:43 UTC <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Pawan Kumar
|
e6d8523fe2
|
chore: Fix table columns when hidden are not greyed out in preview mode (#35729)
Fixes #34852 Grey out the header cells and row cells when the column is set invisible. Before:  After:  /ok-to-test tags="@tag.Widget" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10422331593> > Commit: 045a3e723cc3783c40b191613eb253a4e4ab1366 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10422331593&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget` > Spec: > <hr>Fri, 16 Aug 2024 16:28:06 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the visual feedback for users interacting with the `WDSTableWidget` by improving opacity styles for disabled table headers and cells. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Valera Melnikov
|
db9d572424
|
chore: use ads icons (#35633)
## Description Why did this PR appear? I wanted to replace the icons from `ads-old` with the icons from `ads`. After that, I had to fix some affected components in `ads-old` and in the main app. In the process, I discovered that a large amount of code is simply not being used. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10419944222> > Commit: 86491f43aff37e34468fb7dc32722b9ef2ec60c9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10419944222&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 16 Aug 2024 13:28:03 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved precision in UI element targeting for enhanced test reliability. - Broadened icon options within the FilePickerComponent for greater flexibility. - **Improvements** - Shifted component imports to a centralized design system for better consistency. - Simplified prop structures for the Button component to enhance clarity. - Enhanced validation utilities available for form handling and input validation. - **Bug Fixes** - Enhanced robustness of element locators, reducing potential UI interaction issues. - **Refactor** - Adjusted component properties to align with updated design guidelines, promoting semantic usage. - Consolidated exports to emphasize type definitions and utility functions for better maintainability. - **Chores** - Cleaned up imports and updated code structure for improved maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
NandanAnantharamu
|
1b61679184
|
test: removed retries from config file (#35284)
removed retries from config file /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10158592302> > Commit: 851bf5a08893cfede46033e3d516506e14aed19f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10158592302&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 30 Jul 2024 08:37:16 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the Cypress testing configuration to disable retries during test execution in run mode, streamlining the testing process by providing immediate feedback on test failures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
dependabot[bot]
|
36b2a17c38
|
chore(deps): bump elliptic from 6.5.4 to 6.5.7 in /app/client (#35721)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7. <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Pawan Kumar
|
66e535df65
|
chore: Rename wds packages (#35686)
/ok-to-test tags="@tag.Widget" ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10414775054> > Commit: 445dec9a23df945a5b2a965ce39b8369641bd2b8 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10414775054&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget` > Spec: > <hr>Fri, 16 Aug 2024 05:45:49 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Diljit
|
ed17ee0376
|
chore: ce - remove sentry performance tracker (#35710)
## Description Fix the following errors ### POST https://o296332.ingest.sentry.io/api/1546547/envelope/... 429 (Too Many Requests) We have an integration with Sentry to instrument page loads and other transactions. This is no longer used. All page load metrics are collected using a new relic integration. The sentry transactions api was throwing a 429 error when we exceed our trial quota. Removing the integration should curb this error. <img width="1181" alt="Screenshot 2024-08-15 at 1 22 28 PM" src="https://github.com/user-attachments/assets/543c0ec1-e87f-4439-b715-e75b3a6fd3ed"> [Slack thread ](https://theappsmith.slack.com/archives/CGBPVEJ5C/p1723699775838509)for more context on our sentry sub exceeding its quota. ### TypeError: e.className.split is not a function at t.value (PageLoadInstrumentation.ts:112:33) Add a type check for string. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10400625143> > Commit: fc83198b613a973c9a02644fc742947a92bfbd3c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10400625143&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 15 Aug 2024 08:45:49 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Removed performance tracking functionality across various components and sagas, simplifying the codebase and reducing overhead. - **Bug Fixes** - No specific bug fixes were made; improvements focus on performance tracking removal. - **Chores** - Eliminated unnecessary dependencies related to performance metrics, streamlining the application's dependency management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Alex
|
b4a3f0cad1
|
feat: add AnimatedGridLayout component (#34825)
## Description Added AnimatableGridLayout component, which is designed to be used for application layout. However, the component is generic and can be used for any purpose where layout needs smooth transitions. Fixes #34537 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10377477258> > Commit: 120433561c026726d29a1f993aa3de533ead6b51 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10377477258&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Tue, 13 Aug 2024 21:54:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a dynamic grid layout with animated transitions for child components using React Spring. - Added functionality to manage grid layout dimensions and child components with new types and interfaces. - **Enhancements** - Improved the `AnimatedGridLayout` component to support responsive grid layouts with adjustable rows and columns. - Added visibility resolution based on grid areas, rows, and columns for better layout management. - Introduced a custom React hook to access the previous render value for enhanced state management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Hetu Nandu <hetunandu@gmail.com> |
||
|
sneha122
|
37b5225117
|
test: fixed skipped graphQL test (#35571)
## Description **Context:** This cypress test is asserting the fixes made for [bug](https://github.com/appsmithorg/appsmith/issues/16702) Bug recording: https://www.loom.com/share/ccf9fccc89064ee7b4230aaf5bf3cc52 Basically bug was that when using bindings inside query of graphQL API, autocomplete menu shows up for first binding, but not for second binding. This test case asserts that autocomplete menu shows up every time inside binding for query EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4856 This PR fixes the skipped test of spec file: cypress/e2e/Regression/ClientSide/BugTests/GraphQL_Binding_Bug16702_Spec.ts Fixes #35147 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10383572807> > Commit: 0a655d760eeb23ac2aaf3251bb26d5cb848ec58f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10383572807&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Wed, 14 Aug 2024 09:15:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Updated the test for a GraphQL binding issue, now actively validating the resolution of a formatting bug that affected autocomplete functionality. - Enhanced test clarity by removing redundant code and optimizing the test flow for improved execution efficiency. - **Chores** - Changed the focus of the limited test scenario to prioritize addressing the GraphQL binding bug over template-related functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
dependabot[bot]
|
049216787c
|
chore(deps): bump axios from 1.7.2 to 1.7.4 in /app/client (#35681)
Bumps [axios](https://github.com/axios/axios) from 1.7.2 to 1.7.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.7.4</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>sec:</strong> CVE-2024-39338 (<a href="https://redirect.github.com/axios/axios/issues/6539">#6539</a>) (<a href="https://redirect.github.com/axios/axios/issues/6543">#6543</a>) (<a href=" |
||
|
Pawan Kumar
|
b6a785b0a4
|
chore: use translate to center the resize handle (#35665)
Fixes #35232 Because of how sub-pixels are handled in browsers, the resize handle was previously looking more inclined towards right. By using translate instead adjusting the width in left property, the issue seems to be resolved. Before: <img width="65" alt="CleanShot 2024-08-13 at 17 08 47@2x" src="https://github.com/user-attachments/assets/04f65b6a-6ef6-435f-91ea-3ebf1c12e7ab"> After: <img width="71" alt="CleanShot 2024-08-13 at 17 08 00@2x" src="https://github.com/user-attachments/assets/bc29017c-c12c-49ee-a14e-270f33b3a6a6"> </details> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced positioning logic for the space distribution handle, simplifying the alignment process and potentially improving rendering behavior. - **Documentation** - Added comments to clarify the rationale behind adjustments in the positioning logic and highlight the benefits of using `translateX` for centering. - **Bug Fixes** - Resolved potential pixel snapping issues related to the handle's positioning. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD 801900efe8c65439e1b82db3fb309dcd59e461a3 yet > <hr>Tue, 13 Aug 2024 12:05:21 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Rudraprasad Das
|
3bdd871a9a
|
chore: removing unused migration funcs and files (#35643)
## Description Removes old DSL migration files and functions Fixes #26786 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10364165262> > Commit: c718feaa1c7b35bbe4478c84fb6b554aeb5c3c3a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10364165262&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 13 Aug 2024 06:28:59 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Removed the `renameKeyInObject` function to streamline object manipulation processes, improving overall code efficiency. - **Refactor** - Cleaned up the codebase by eliminating unnecessary functions, enhancing maintainability and reducing complexity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Pawan Kumar
|
6f6c2784a3
|
chore: add isVisible in default values in wds widgets (#35624)
Fixes #35317 Fixes #35319 Fixes #35272 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `autocompleteConfig` to manage visibility of autocomplete features consistently across the application. - Added `isVisible` property to `defaultConfig` for better control over widget visibility. - **Improvements** - Simplified logic in the `shouldUpdateProperty` method for enhanced clarity and efficiency. - Updated `getAutocompleteDefinitions` methods to utilize the new `autocompleteConfig`, streamlining autocomplete handling. - **Modifications** - Expanded export capabilities of configuration modules, including the new `autocompleteConfig` across multiple widgets. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10368473517> > Commit: 362f2af4cd0370aefe57c0004102d25c9b10ad33 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10368473517&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.Anvil > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Tue, 13 Aug 2024 11:27:23 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Hetu Nandu
|
7c1be7580f
|
fix: Widget Overflow and Show Binding issue (#35651) | ||
|
Abhinav Jha
|
31be835726
|
chore: Anvil on canvas UI tests (#35342)
## Description ### Unit `index.test.tsx` - (Main connected component that uses floating ui) - [x] Test rendering of widget name component (floating-ui) based on "select", "focus" and "none" states from redux selector - [x] Test rendering of widget name component (floating-ui) based on error count from redux selector `AnvilWidgetNameComponent.test.tsx` (Standalone component that renders content for floating ui to use) - [x] Test rendering of standalone widget name component based on props. - [x] Test calling of `onDragStart` callback from the standalone widget name component. `SplitButton.test.tsx` (Low level UI component - child of `AnvilWidgetNameComponent`) - [x] Test left and right toggle click triggers - [x] Test if component handles props correctly ### E2E - [x] Test Dragging via widget name component - [x] Test widget name component when multiple widgets are selected - [x] Test Hover and Selection to show widget name component Fixes #33979 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10349986042> > Commit: 8c9e6b933fc63306ca4b9322d2cc109909df879d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10349986042&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 12 Aug 2024 11:13:52 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced a comprehensive suite of end-to-end tests for the Anvil editor's UI in canvas layout mode. - Enhanced flexibility in widget manipulation on the canvas with an updated method. - Expanded selectors for more precise targeting of UI components. - Added unit tests for the `AnvilWidgetNameComponent` and `SplitButton` components to ensure expected functionality. - **Bug Fixes** - Improved responsiveness of the `AnvilWidgetName` component to state changes. - **Documentation** - Updated comments and structure for clarity in test scenarios and component functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
35839c6bb3
|
test: fix flaky inline editing 2 spec (#35426)
## Description Fix flaky test - `Inline_editing_2_spec.js` Related EE PR for fix - https://github.com/appsmithorg/appsmith-ee/pull/4819 **Problems** Previous change made to remove the editable checkbox from the columns list on the table property pane made the `table.EnableEditableOfColumn` obsolete as a method for enabling edit mode on specific columns. There is a newly introduced method `toggleColumnEditableViaColSettingsPane` was swapped only in some cases, not implemented correctly, and in some other cases, the `table.EnableEditableOfColumn` still existed, causing the test to fail. **Solution** 1. Fix the implementation of the `table.toggleColumnEditableViaColSettingsPane` in all instances in the test suit 2. Replace `table.EnableEditableOfColumn` with `table.toggleColumnEditableViaColSettingsPane` in tests 3. Move standalone values into consts for readability 4. Remove unused const Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10352974239> > Commit: 83116d9c64f95946ab0ba7399c7e1c491f2d2851 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10352974239&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 12 Aug 2024 14:08:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Improved reliability of inline editing tests for the table widget, ensuring consistent behavior when editing columns. - **Improvements** - Enhanced clarity of test case descriptions regarding cell column height behavior with text wrapping. - Updated height assertions to use constants for better readability and maintainability. - **Chores** - Changed focus of limited tests from template-related tests to inline editing functionality tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
NandanAnantharamu
|
de053b62fa
|
test: updated helper for airgap view permission (#35627)
AirGap test for CE /ok-to-test tags="@tag.All" EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4726 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Improvements** - Streamlined logic for handling air-gapped scenarios, enhancing clarity and performance. - Removed unnecessary checks related to workspace validation for a more efficient process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10352641842> > Commit: c09ed041420b1a64bb67f120116043e6d555e75a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10352641842&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 12 Aug 2024 14:28:39 UTC <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: NandanAnantharamu <=> |
||
|
Hetu Nandu
|
211dc11ffb
|
fix: View mode canvas margin (#35619)
## Description Removes the extra margin added in the View Mode when Navigation is as Sidebar. It was noticed that the width of the sidebar was already accounted for and was reduced from the available width unnecessarily Fixes #35618 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10349675002> > Commit: 9778e836c9c8b13e4f6f0971ff36407f452b5d08 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10349675002&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Mon, 12 Aug 2024 10:18:59 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Improvements** - Enhanced the auto-resizing behavior of the app's canvas by streamlining the parameters used in the resizing hook, potentially improving performance and user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
b64d5c8338
|
fix: drag and drop issue in list widget (#35622)
## Description This pull request fixes an issue where the error count was not being properly checked when a list widget was dropped. * Reverts a previous commit(#35221). * Include changes to the test file and the widget creation functions to ensure that the error count is correctly checked when a list widget is dragged and dropped. Fixes #35578 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10350318730> > Commit: 07f3abcff845eb4d350fc9af235d6ed076257264 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10350318730&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 12 Aug 2024 11:35:20 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved drag-and-drop functionality for list widgets. - **Bug Fixes** - Enhanced clarity and organization of test cases for better logical flow. - **Chores** - Simplified widget ID generation across several components, improving consistency in the application. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
d03278a044
|
fix: overflow hidden was restricting the visibility of show bindings menu (#35609)
## Description There was an IDE PR : https://github.com/appsmithorg/appsmith/pull/35114 , that got merged which added the `overflow: hidden` property to the entity explorer which made the show bindings menu disappear from the view port. Hence, that change is fixed with this PR. Fixes #35584 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10347893824> > Commit: 05dd349a6f417e92f412eb6c29201296502c1d9f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10347893824&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Mon, 12 Aug 2024 08:12:07 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **User Interface Changes** - Adjusted the rendering behavior of the editor pane, allowing overflow content to be visible, which may enhance the user experience within the IDE. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vemparala Surya Vamsi
|
b8df54cbeb
|
chore: batching updates for a few widgets to reduce rerenders (#35594)
## Description Each meta update would cause rerender for the the widget, by batching meta updates we reduce the number of rerenders thereby improving the overall performance of the widget. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10346452761> > Commit: c1abc97a5d485f1c38885d8e3d1b0e99810027e4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10346452761&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 12 Aug 2024 06:26:33 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced batch processing for widget metadata updates across various widgets, improving state management efficiency. - Introduced new methods for committing batch updates, streamlining interaction handling. - **Bug Fixes** - Improved performance and consistency in widget state updates, reducing unnecessary re-renders. - **Refactor** - Modified existing update methods to utilize batching for more organized state management. - **Tests** - Adjustments made to ensure tests align with the new batch update functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
42debc6d11
|
chore: rename ADS package (#35583)
## Description Rename `design-system` package to `@appsmith/ads` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10319507327> > Commit: 65d9664dd75b750496458a6e1652e0da858e1fc6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10319507327&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 09 Aug 2024 13:47:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
vadim
|
7c0173af58
|
chore: WDS text inputs visual refinements (#35581)
## Description Fixes #34844 Fixes several issues that were spotted related to that: - We were not applying `--fg-neutral-subtle` to our placeholder because ADS has `!important` for their placeholder styling, so I added it to ours for now - After applying it, it became obvious that `--fg-neutral-subtle` and the “parent” `--fg-neutral` needed adjustments too - Disabled opacity needed an increase (became obvious) after making our `--bg-neutral-subtle` lighter to deal with the primary issue of the ticket) - `--bg-neutral-subtle` were derived from the seed, despite the intent to be derived from `--bg-accent-subtle`, fixed that too | Before | After | |--------|--------| | <img width="1114" alt="before-light" src="https://github.com/user-attachments/assets/a2c8b8ca-db5c-443d-84bf-8b7f7dd2333d"> | <img width="1102" alt="after-light" src="https://github.com/user-attachments/assets/dd924865-ea19-4d74-b4ed-3037e0b418ef"> | Additional preview of how dark mode looks after these changes: <img width="1119" alt="after-dark" src="https://github.com/user-attachments/assets/2d06df1e-211d-4b1d-a293-99710b34f7bd"> ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10319662006> > Commit: e1f99f2ea8956ff988c891470fc7fa4285ab32b0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10319662006&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.Anvil > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Fri, 09 Aug 2024 13:25:27 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced color themes for both dark and light modes, improving aesthetic coherence and visual accessibility. - **Bug Fixes** - Adjusted opacity of disabled components to improve clarity and user experience. - **Style** - Updated placeholder text styling in input fields to ensure consistent visibility across different contexts. - **Tests** - Modified expected output values in color theme tests for improved accuracy and alignment with new color definitions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
8514cf13e4
|
fix: js object editor overflowing fixed (#35553) | ||
|
Aman Agarwal
|
2ca40ecd39
|
fix: hidden page was not being checked for route change (#35558) | ||
|
Hetu Nandu
|
4bbbaecf20
|
chore: Upgrade TinyMCE (#35399) | ||
|
Aman Agarwal
|
f0059fe894
|
fix: table save row button onclick function (#35412) | ||
|
Valera Melnikov
|
b7ec5dacd8
|
chore: rename old ADS package (#35517)
## Description Rename package `design-system-old` to `@appsmith/ads-old`. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10286195096> > Commit: c0d478694b12f35b88687b6dae6f252967fba540 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10286195096&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 07 Aug 2024 15:26:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
Abhijeet
|
061e376a33
|
chore: Update env variable used for update persistent DB URL (#35526)
## Description PR to fix the issue with DB url update from admin settings page. When we migrated the env variable to `APPSMITH_DB_URL` instead of `APPSMITH_MONGODB_URI` this functionality broke. We had a discussion to remove this update functionality as this does not work in all the setups. But as QA has already started pointing this as an issue raising this PR. ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10297374384> > Commit: dbef20ca923a1cba0d7687766481060eab5057fa > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10297374384&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Thu, 08 Aug 2024 07:13:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the database connection string naming from "MongoDB URI" to "Appsmith DB URL" in the Admin Settings, enhancing clarity in configuration. - Revised subtext in Admin Settings for improved user understanding of the database URL's purpose. - **Bug Fixes** - Adjusted test cases to reflect the new naming convention, ensuring consistent references to "APPSMITH_DB_URL" across various tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ashit Rath
|
aaadbc675f
|
chore: add isError to return value of extractIdentifierInfoFromCode in AST (#35525)
## Description Adds an isError flag to know if there is a syntax error while parsing PR for https://github.com/appsmithorg/appsmith-ee/pull/4547 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10295486363> > Commit: d69958d73ceb625ce82101ee98e5c81fe3d46697 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10295486363&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 08 Aug 2024 06:45:00 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `isError` property in the identifier information interface, enhancing error reporting during code extraction. - **Bug Fixes** - Updated extraction function to properly set the `isError` property based on success or `SyntaxError`, improving clarity on extraction outcomes. - **Tests** - Enhanced test cases by incorporating the `isError` property, improving clarity on expected outcomes and robustness of the testing framework. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Sagar Khalasi
|
6d1b9bdc2c
|
test: fix flaky case for forkapp (#35376)
## Description Fix case with adding one more assertion with wait. RCA: The issue was not with the function itself but rather with the flaky behavior of the Cypress code. The modal was opening, and our code was attempting to click the “Skip to Application” button too quickly. The actual validation was only for SkipToAppBtn, but in the application, the modal was still loading, causing Cypress to perform the action prematurely, which led to failures. To address this, I added an additional wait for another element, and this resolved the issue. Fixes #`35375` ## Automation /ok-to-test tags="@tag.Fork" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10279433214> > Commit: 748f4f7cf960355a957e59f3956a47880494da93 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10279433214&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Fork` > Spec: > <hr>Wed, 07 Aug 2024 07:08:45 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced test robustness for the ForkApplication component by implementing a prerequisite check for the presence of a critical UI element linked to data sources. - **Bug Fixes** - Improved control flow in tests to ensure that necessary elements are available before proceeding with actions, reducing the likelihood of test failures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rudraprasad Das
|
9b59d4da17
|
fix: issue with opening custom widget source editor (#35463) | ||
|
Diljit
|
43518e6d58
|
chore: Remove google fonts imported from googleapis (#35392)
## Description Google fonts are served by the appsmith instance and change that was introduced in t[his PR](https://github.com/appsmithorg/appsmith/pull/22129). This PR removes redundant the import of google fonts from googleapis. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10270353461> > Commit: 142bcc8507af247ced35a92473cc6fdab9868025 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10270353461&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 06 Aug 2024 17:21:17 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Transitioned to a fully local/custom font strategy, enhancing branding consistency and potentially improving load times. - **Usability Improvements** - Enhanced output readability in the GitHub Actions workflow, making it easier for users to identify changed files. - Updated the file change detection mechanism in the GitHub Actions workflow for better performance and clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
c42e0317de
|
fix: change appsmith alias (#35349)
In order to unify package names, we decided to use `@appsmith` prefix as a marker to indicate that packages belong to our codebase and that these packages are developed internally. So that we can use this prefix, we need to rename the alias of the same name. But since `@appsmith` is currently being used as an alias for `ee` folder, we have to rename the alias as the first step. Related discussion https://theappsmith.slack.com/archives/CPG2ZTXEY/p1722516279126329 EE PR — https://github.com/appsmithorg/appsmith-ee/pull/4801 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10267368821> > Commit: 2b00af2d257e4d4304db0a80072afef7513de6be > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10267368821&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 06 Aug 2024 14:24:22 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
VigneswarV
|
380022c0de
|
fix: commit icon of github on airgapped, the app crashes. #33812 (#34673) | ||
|
Vemparala Surya Vamsi
|
95e32687af
|
chore: Memoising some computations within WDS_TOOLBAR_BUTTONS_WIDGET (#35436)
## Description Memoising some computations related to WDS_TOOLBAR_BUTTONS_WIDGET Fixes #`Issue Number` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10264040446> > Commit: c15e274b718fc36f17b8f7edda4f23790b72f16d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10264040446&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 06 Aug 2024 10:43:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Performance Enhancements** - Optimized the `ToolbarButtons` component for improved efficiency by utilizing the `useMemo` hook, reducing unnecessary calculations and re-renders. - Consolidated the computation of `sortedButtons` and `disabledKeys` in `ToolbarButtonsComponent` for better performance and clarity. - **Telemetry Integration** - Added performance tracking capabilities to the `withWidgetProps` higher-order component, enhancing observability of widget performance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Sagar Khalasi
|
828c6aeefe
|
chore: Adding new command for running test case (#35419)
## Description It is for running a spec file with given run_count with PR comment. Fixes #`34956` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10250647978> > Commit: 69556d529719ff00d6d0b6961edb83a2a6112541 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10250647978&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 05 Aug 2024 14:49:54 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a CI/CD workflow to manage client and server builds with Cypress testing. - Added a job to enforce TypeScript file checks, providing feedback for corrections on pull requests. - Expanded testing capabilities with a new job for managing testing limits. - **Improvements** - Enhanced logging for better visibility into test execution attempts. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
vadim
|
6d47068db7
|
chore: WDS adjust bgNeutral (#35382)
## Description Fixes #34856 | Before | After | |--------|--------| | <img width="945" alt="Screenshot 2024-08-02 at 14 21 12" src="https://github.com/user-attachments/assets/f157d616-6b42-4d56-be20-da778e5a9ba3"> | <img width="950" alt="Screenshot 2024-08-02 at 14 38 02" src="https://github.com/user-attachments/assets/2e565b64-2379-4499-8e95-f1e58a5b7e55"> | | <img width="934" alt="Screenshot 2024-08-02 at 14 21 21" src="https://github.com/user-attachments/assets/760d1264-25ab-4c0f-9ae3-85c17dea0602"> | <img width="939" alt="Screenshot 2024-08-02 at 14 49 57" src="https://github.com/user-attachments/assets/7c2c1671-75a2-4d46-9c23-96c46e4c1013"> | ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10216260757> > Commit: e865f449f68767e53d0a0e4b19ae3294bea3987c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10216260757&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.Anvil > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilRadioGroupWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Fri, 02 Aug 2024 13:46:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced color adjustment logic for both Dark and Light Mode themes to improve visual harmony and accessibility. - **Bug Fixes** - Updated expected RGB values for neutral background colors in both Dark and Light Mode in tests. - **Refactor** - Reworked lightness thresholds and adjustments for color properties for a more refined user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
74f9da357e
|
chore: update storybook and related packages (#35384)
## Description
Update storybook and related packages
## Automation
/ok-to-test tags=""
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!CAUTION]
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Updated Storybook and Vite dependencies to their latest versions,
enhancing performance and compatibility.
- **Bug Fixes**
- Minor bug fixes included with the update of Storybook dependencies
that improve stability and functionality.
These changes ensure a smoother development experience and leverage
improvements in the libraries used.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Abhinav Jha
|
c0664e2c52
|
fix: Anvil zone widget default configurations (#35299)
## Description - Zone widget needs the `flexVerticalAlignment` configurations to make the layout stretch to occupy all vertical space in a section - Zone widget's layout configuration needs a `height:100%` to enable highlights in an empty zone. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10221060293> > Commit: 76b97f97b1ff6b487db00684584a97957094bcba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10221060293&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 02 Aug 2024 20:25:54 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `layoutStyle` property for enhanced border and height control in layout components. - Added `flexVerticalAlignment` property to improve vertical alignment flexibility in widgets, allowing for responsive design enhancements. These changes aim to provide users with greater customization options for layout and widget presentation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Diljit
|
7adb33d015
|
chore: Add hostname as common attr on all spans (#35388)
## Description Some of the self hosted instances are sending data with the entitiy.name as Appsmith Production OTLP. Therefore we need another attribute to slice all the cloud data and hostname will be unique to each instance. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/10234910845> > Commit: b616a08165d404f8d4fc4a5cc8d467ce4a7476a6 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Sun, 04 Aug 2024 08:47:52 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced telemetry data by adding a new `hostname` property, improving tracking and analysis of telemetry events based on the specific web page host. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vemparala Surya Vamsi
|
964fb0e1aa
|
chore: allKeys computation is constrained by diff (#35303)
## Description allKeys is previously computed from the complete unevalTree, we used to recursively traverse through the entire unevalTree during each evaluation update cycle. We are optimising this by leveraging the diff which we have previously computed and using the diff to directly update the allKeys result. When delete based diffs detected are detected we are directly deleting the nodes in the previous allKeys result, for only new nodes we are recursively computing the allKeys for those nodes and merging it back to the previous allKeys result. The time complexity of the solution has improved by limiting iterations to the diff alone instead of computing the entire unevalTree. Fixes #35386 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10220298181> > Commit: 12b94c33ecfd3fb069b003df16a0f3192f769d62 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10220298181&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 02 Aug 2024 19:22:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced a new function for dynamic path management based on differential updates. - Enhanced data processing in the DataTreeEvaluator class to improve dependency tracking and efficiency. - **Bug Fixes** - Improved handling of data tree updates to ensure accurate addition and deletion of paths. - **Tests** - Added a comprehensive test suite for the new path management function, verifying accurate response to various data tree changes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
a0f2ee10ce
|
fix: collapse params & query params in action selector if value is not changed (#35323) | ||
|
Hetu Nandu
|
5458466a11
|
chore: Upgrade fast-xml-parser to 4.4.1 (#35353)
## Description Update `@aws-sdk` dependencies to update the `fast-xml-parser` version in our yarn.lock ## Automation /ok-to-test tags="@tag.Datasource, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10211483091> > Commit: 82e737a66fb4886f904c3b564c7f79c7a5b29d35 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10211483091&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource, @tag.Sanity` > Spec: > <hr>Fri, 02 Aug 2024 07:45:57 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated AWS SDK dependencies, potentially introducing new features and improvements for S3 operations and storage management. - **Bug Fixes** - Enhanced stability and performance through the updated versions of AWS SDK components. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Jacques Ikot
|
3b1c14a9f0
|
feat: add sortBy property to table select cell type (#35187)
## Description **Problem** The table widget now supports the Select column type, which allows the column to contain both a label and a value. This could be useful for currency fields, foreign keys, or any other case where you want to display a different version of the column value. However, there is a problem with sorting. The table always sorts using the value, and does not give the user an option to sort using the label, where it makes sense in specific cases. **Solution** This PR adds a Sort By property to the table select cell, allowing the users to choose which value is used for sorting without affecting any functionality of the label or value of the select cell. [Additional Technical Documentation](https://www.notion.so/appsmith/Adding-sortBy-Property-to-Select-Columns-in-Table-Widget-V2-a5a41e6319a047378eb50a42be8c32ef?pvs=4) **Tested Cases** 1. Sort select column by default value Objective: Ensure that a newly added table with select column default sorts by the value **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., role) to select type. - Add selectOptions property - Verify that when sorted in ascending or descending order, the sorting is correct 2. Sort select column by label Objective: Ensure that a newly added table with select column and sortBy property set to label sorts correctly **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., role) to select type - Add selectOptions property - Set sortBy property to label - Verify that when sorted in ascending or descending order, the sorting is correct and based on the label value only 3. Verify that sorting of other table cells that are not select works as expected Objective: Ensure that every other cell type in the table sorts correctly **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., role) to select type - Add selectOptions property - Set sortBy property to label - Verify that when columns other that role are sorted, they are sorted correctly 4. Verify that sorting works as expected when table data is a binding Objective: Ensure that the sorting works for all columns while using data binding in table data **Steps:** - Drop a new table widget - Link a query binding to the table data property - Verify that all columns sort correctly 5. Verify that sorting works as expected when table data is a binding and select column sorting is set to label Objective: Ensure that the sorting works for all columns while using data binding in table data with a select column set to sort by the label **Steps:** - Drop a new table widget - Link a query binding to the table data property - Set a column (e.g., role) to select type - Add selectOptions property - Set sortBy property to label - Verify that all columns sort correctly 6. Verify that sortBy logic does not take effect or break user experience until the user adds selectOptions in select cell **Steps:** - Drop a new table widget - Link a query binding to the table data property or add raw data - Set a column (e.g., role) to select type - Do not add selectOptions - Set sortBy property to label - Verify that all other columns display and sort correctly 7. Verify that sorting by label and value works correctly in deployed mode **Steps:** - Drop a new table widget - Link a query binding to the table data property or add raw data - Set a column (e.g., role) to select type - Add selectOptions - Set sortBy property to label - Deploy application - Confirm that sorting works correctly for all columns Fixes #21993 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10165119164> > Commit: 8a4e8b238adc0d78726a811b54a209caa4990606 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10165119164&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Tue, 30 Jul 2024 16:02:35 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [x] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a feature flag for dynamic table cell labeling. - Added a sorting option for select cells, allowing sort by value or label. - Enhanced user interface with new configuration options for select components. - Improved sorting functionality for select columns to sort by labels. - **Bug Fixes** - Improved sorting functionality in the table widget to ensure accurate data representation. - **Tests** - Expanded and clarified test cases for sorting functionality in the Table Widget V2. - Updated testing structure for better reliability and isolation of test scenarios. - Integrated dynamic testing capabilities based on feature flags. - **Documentation** - Added new locators for sorting controls to enhance UI interaction capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
albinAppsmith
|
ed1e4745f6
|
feat: Added zone component to UQI (#35316)
## Description Added zone component to the UQI. This component will maintain the single and double column layout. Fixes #35214 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10193706753> > Commit: e4bc652b691a5bfb5be60c393e7822f418c1e458 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10193706753&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 01 Aug 2024 07:35:05 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `Section` component for modular UI design, facilitating easy integration of standalone and non-standalone sections. - Added a `Zone` component to manage layout options with single-column and double-column formats, enhancing layout flexibility. - New CSS modules for `Section` and `Zone` components improve styling and responsiveness across different screen sizes. - Created a centralized entry point for streamlined access to `Section` and `Zone` functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |