Commit Graph

738 Commits

Author SHA1 Message Date
Trisha Anand
d6670c70cc Bug Root Cause : New users have no applications inside the organizations(s). In this case, get all applications does not return back organizationApplications object.
Fix : In getAllApplications, instead of iterating over collections of applications which could be empty, we iterate over organizations where we are guaranteed to have atleast one organization.
2020-05-28 13:31:24 +05:30
Arpit Mohan
a24633e391 Merge branch 'feaure/acl-cascade-org-permissions' into 'feature/acl-spring-object'
Acl : Cascade org permissions to applications, pages and eventually actions.

See merge request theappsmith/internal-tools-server!355
2020-05-27 14:36:58 +00:00
Trisha Anand
6475be63d1 Baseline code added for cascading the org level permissions to applications, pages and eventually actions. 2020-05-27 14:36:57 +00:00
Trisha Anand
59a83d414b Added description to roles for organization appsmith roles. 2020-05-26 10:49:42 +05:30
Arpit Mohan
c8cd7ad934 Merge branch 'bug/acl-getAllActions' into 'feature/acl-spring-object'
BaseRepository : findAll function fixed.

See merge request theappsmith/internal-tools-server!353
2020-05-22 10:31:35 +00:00
Trisha Anand
0c9c95bc9a Fixed the findAll repository function which was leading to get all actions via application id to throw an internal server error. 2020-05-22 15:56:09 +05:30
Trisha Anand
10b07d5912 Merge branch 'feature/acl-org-user-role' into 'feature/acl-spring-object'
GET Organization Users & part base code to update permissions given an org level role.

See merge request theappsmith/internal-tools-server!339
2020-05-21 15:05:43 +00:00
Trisha Anand
d98fce3d09 WIP: adding helper functions for adding/removing roles from an organization. Adding role updates the organization right now. Removing role -> added a helper.
TODO : finish the above code flows + cascade these to the children objects of the organization -> Applications/Pages/Actions.
2020-05-21 15:05:43 +00:00
Trisha Anand
8caf66d68a Merge branch 'feature/acl-new-create-application' into 'feature/acl-spring-object'
create application now expects organization id.

See merge request theappsmith/internal-tools-server!347
2020-05-19 17:09:51 +00:00
Trisha Anand
e95b680169 create application now expects organization id. Fixed the test cases which broke because of this basic change in the way applications are created. 2020-05-19 17:09:51 +00:00
Trisha Anand
5829a92998 Merge branch 'release' into feature/acl-spring-object
# Conflicts:
#	appsmith-server/src/main/java/com/appsmith/server/services/ActionServiceImpl.java
2020-05-13 23:37:31 +05:30
Trisha Anand
7b851fce7a Merge branch 'feature/acl-403' into 'feature/acl-spring-object'
In case of anonymous user, return 401 instead of 403 when fetching user profile.

See merge request theappsmith/internal-tools-server!335
2020-05-13 18:00:03 +00:00
Trisha Anand
9a8bf9dc89 In case the user is not signed in, return a 401 so that the user can be redirected to login by the frontend. 2020-05-13 18:00:03 +00:00
Shrikant Kandula
1c33380820 Merge branch 'chore/rename-should-cache-field' into 'release'
Rename ActionExecutionResult.shouldCacheResponse -> isExecutionSuccess.

See merge request theappsmith/internal-tools-server!334
2020-05-12 13:50:56 +00:00
Shrikant Kandula
9c48f42990 Rename ActionExecutionResult.shouldCacheResponse -> isExecutionSuccess. 2020-05-12 18:25:49 +05:30
Arpit Mohan
d2d0805146 Merge branch 'feat/use-unique-name-on-post-datasource' into 'release'
Automatically use a unique name for creating datasources without name.

In the request from frontend for datasource creation, if the data
doesn't have a `name` value, we now set it to an automatically numbered
value and save with that.

See merge request theappsmith/internal-tools-server!333
2020-05-12 12:23:23 +00:00
Shrikant Kandula
b65690ec74 Automatically use a unique name for creating datasources without name.
In the request from frontend for datasource creation, if the data
doesn't have a `name` value, we now set it to an automatically numbered
value and save with that.
2020-05-12 16:05:29 +05:30
Nikhil Nandagopal
5dad85ff3e Update form.json 2020-05-12 09:48:56 +00:00
Arpit Mohan
f4d79ae25b Merge branch 'bug/curl-error-reporting' into 'release'
Report error when cURL command is invalid.

See merge request theappsmith/internal-tools-server!327
2020-05-12 04:12:55 +00:00
Shrikant Kandula
7f4d32e7d4 Report error when cURL command is invalid. 2020-05-12 04:12:55 +00:00
Arpit Mohan
4207de2c53 Merge branch 'bug/add-mongo-auth-type-to-uri' into 'release'
Auth mechanism is not added to URI in the MongoPlugin. Fixed now.

See merge request theappsmith/internal-tools-server!330
2020-05-12 04:11:47 +00:00
Trisha Anand
963a3388c3 In CI, buidling and packaging ACL branch with a new tag for the deployment. 2020-05-11 21:15:19 +05:30
Shrikant Kandula
f3e448019d Auth mechanism is not added to URI in the MongoPlugin. Fixed now. 2020-05-11 12:16:09 +05:30
Trisha Anand
6cdab92bbe Merge branch 'feature/acl-action-inheritance' into 'feature/acl-spring-object'
Action Permission Inheritance during create.

See merge request theappsmith/internal-tools-server!329
2020-05-08 15:39:36 +00:00
Trisha Anand
b7435e546f Added action inheritance for permissions during create. No update permissions for action added. Fixed the existing test cases to run with the new code.
TODO : Add test cases for action permissions.
2020-05-08 15:39:36 +00:00
Trisha Anand
02de2ea1f6 Removing Arn because its not being used anymore. 2020-05-08 21:08:16 +05:30
Trisha Anand
f7bb87824c Merge branch 'release' into feature/acl-spring-object
# Conflicts:
#	appsmith-server/src/main/java/com/appsmith/server/domains/User.java
2020-05-08 20:57:51 +05:30
Trisha Anand
c12d83caa5 Merge branch 'feature/acl-page-inheritance' into 'feature/acl-spring-object'
Completed the loop on page inheritance from application

See merge request theappsmith/internal-tools-server!328
2020-05-08 11:07:52 +00:00
Trisha Anand
d7637355fe Create Page always sets the inherited policies from the application. Update Application policy remains to be done. Leaving it as a TODO for now. 2020-05-08 16:32:46 +05:30
Shrikant Kandula
0e2320895c Merge branch 'bug/install-default-plugins-to-existing-orgs' into 'release'
Migration to install existing default plugins to existing organizations.

See merge request theappsmith/internal-tools-server!326
2020-05-08 07:12:50 +00:00
Shrikant Kandula
ffc4379a4d Migration to install existing default plugins to existing organizations. 2020-05-08 11:46:13 +05:30
Shrikant Kandula
7673ee49eb Merge branch 'chore/remove-index-annotations' into 'release'
Remove index annotations as they don't accurately reflect actual indexes

See merge request theappsmith/internal-tools-server!322
2020-05-08 01:58:43 +00:00
Shrikant Kandula
b8de4ef659 Remove index annotations as they don't accurately reflect actual indexes 2020-05-08 01:58:43 +00:00
Shrikant Kandula
b1a9c40397 Merge branch 'bug/npe-when-curl-command-is-invalid' into 'release'
Guard against NPE when action is null due to cURL command being invalid.

See merge request theappsmith/internal-tools-server!323
2020-05-08 01:22:02 +00:00
Shrikant Kandula
2e9a94341b Guard against NPE when action is null due to cURL command being invalid. 2020-05-08 01:22:02 +00:00
Trisha Anand
5fa667aecc Merge branch 'feature/add-delete-perm-obj' into 'feature/acl-spring-object'
Add and Remove Policies to an Object

See merge request theappsmith/internal-tools-server!325
2020-05-07 14:14:51 +00:00
Trisha Anand
44ce0bbf01 Added baseservice function add and remove policies to an object. This would be used for updating permissions for an object. 2020-05-07 19:39:36 +05:30
Trisha Anand
47e7f6a8c5 Merge branch 'feature/acl-getAllApplications' into 'feature/acl-spring-object'
Feature/acl get all applications

See merge request theappsmith/internal-tools-server!317
2020-05-07 10:49:48 +00:00
Trisha Anand
957116409d Resolved the review comments. Changed the structure of the DTO returned. Added the userPermissions as part of the base domain leading to this field always computed before returning any object to the user. 2020-05-07 10:49:48 +00:00
Trisha Anand
10f3395d3b Merge branch 'bug/add-timeout-page-actions' into 'release'
Added timeout in page load actions

See merge request theappsmith/internal-tools-server!324
2020-05-07 09:57:35 +00:00
Trisha Anand
485eb29e03 Added timeout in DslActionDTO which is used to represent actions inside a layout and in turn is used for page load action execution. 2020-05-07 15:06:16 +05:30
Shrikant Kandula
3e2dea8f84 Merge branch 'bug/hide-exception-class-in-plugin-error-message' into 'release'
Hide Exception class details in the Plugin error message.

See merge request theappsmith/internal-tools-server!321
2020-05-05 11:08:38 +00:00
Shrikant Kandula
e99c104fe7 Hide Exception class details in the Plugin error message. 2020-05-05 16:34:09 +05:30
Nikhil Nandagopal
8f95fe22a9 Update form.json 2020-05-05 10:46:58 +00:00
Nikhil Nandagopal
c4f3ccfd8b Update form.json 2020-05-05 10:34:02 +00:00
Shrikant Kandula
bc55baeb1f Merge branch 'feat/add-delete-datasource-perm-existing-groups' into 'release'
Add `delete:datasources` permission to all existing groups.

See merge request theappsmith/internal-tools-server!320
2020-05-05 09:19:40 +00:00
Shrikant Kandula
172be7e7e5 Merge branch 'bug/missing-default-database-name-in-mongo-form' into 'release'
Add missing default database field in Mongo plugin form.

See merge request theappsmith/internal-tools-server!319
2020-05-05 09:06:32 +00:00
Shrikant Kandula
f7f03c5ad7 Add delete:datasources permission to all existing groups. 2020-05-05 13:52:03 +05:30
Shrikant Kandula
57dc2205e2 Add missing default database field in Mongo plugin form. 2020-05-05 13:39:03 +05:30
Arpit Mohan
77b4ef9a00 Adding a docker image tag for the master commit. This will allow us to revert to previous versions of the image (if required) 2020-05-05 12:54:46 +05:30