Commit Graph

3 Commits

Author SHA1 Message Date
Rahul Barwal
35cec53538
chore: Adds fix for flaky tests of reconnect datasources list. (#22545)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.

## Description
Fixes tests by adding looking for required element from the root

This is done by passing `{ withinSubject: null, }` as config to
`cy.get()`

Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers
about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)



## How Has This Been Tested?

- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 23:46:31 +05:30
Rahul Barwal
9e3f70f894
feat: Adds tooltip to reconnect datasources list. (#22083)
## Description
Adds tooltip to the icon next to data source name

This is helpful when data source name is long and truncated.

Fixes # (issue)
[16067](https://github.com/appsmithorg/appsmith/issues/16067)


Media
![Screenshot 2023-04-04 at 3 50 11
PM](https://user-images.githubusercontent.com/6761673/229762544-9a82f80e-f493-4fda-9b5b-6ab486fa699d.png)

## Type of change

- New feature (non-breaking change which adds functionality)


## How Has This Been Tested?
Added cypress test and confirmed locally.
Steps to reproduce are in the issue link above

- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 19:06:38 +05:30
Aishwarya-U-R
ceefaa00bc
Test: Adding Smoke & Sanity suites into the CI pipeline (#22029)
## Description

- This PR introduces smoke & sanity tests into the CI pipeline, to
capture the failures early.

## Type of change

- CI Improvements


## How Has This Been Tested?

- Cypress runs on local PR workflows

## Checklist:

### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes

---------

Co-authored-by: Saroj <saroj@appsmith.com>
2023-04-04 10:39:40 +05:30