## Description
- This PR includes basic tests for connecting to a MsSQL ds & running
simple queries on it
## Type of change
- New script (non-breaking change which functional tests the MsSql ds)
## How Has This Been Tested?
- Cypress local & CI run
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all Cypress test
## Description
- Deleting duplicate specs while commenting failed specs in the pr
## Type of change
- integration-tests-command.yml
## How Has This Been Tested?
- Manual
## Checklist
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
- This PR removes the restarting of the MsSQL container which is
throwing error sometimes in CI runs - WARNING: Failed to load
/var/opt/mssql/mssql.conf ini file with error open
/var/opt/mssql/mssql.conf: no such file or directory
## Type of change
- yml file update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
- This PR reverts the loading of data into MsSQL container with docker
exec - login timeout issue fixed.
## Type of change
- Yml file update (commenting two lines of code)
## Checklist:
### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
## Description
- This PR init loads the data into MsSQL container after starting it
## Type of change
- Yml file update
## Checklist:
### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
## Description
- This PR reverts the loading of data into MsSQL container with docker
exec, until JDBC driver issue fixed.
## Type of change
- Yml file update (commenting)
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
- This PR includes MsSQL as separate docker container inside CI that can
be used for running mssql ds test cases in CI
## Type of change
- Yml file update
## How Has This Been Tested?
- CI-Debugging tmate session
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
---------
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
## Description
- Picking up the unique records from the specs from the failed specs in
ci-test.yml
## Type of change
- ci-test.yml
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR includes MsSQL as separate docker container inside CI that can
be used for running mssql ds test cases in CI
## Type of change
- Yml file update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
---------
Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
## Description
- Modified the logic to get the failed tests in ci-test.yml
## Type of change
- CI
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Added step to delete the failed-spec-ci after combining all results to
address the issue
## Type of change
- ci
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Fixing the working directory in perf-test.yml
## Type of change
- perf-test.yml
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Updated the path to download the artifact in perf-test.yml
## Type of change
- perf-test.yml
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Added steps to use the pre built docker image instead of building a
new one in perf-test.yml
## Type of change
- perf-test.yml
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Modularised the docker image building
- Optimised the `install dependancies` step to reduce the time from 8
mins to 30-40 secs now
- Removed unnecessary steps from the ci-dubugging.yml
- Added ci-debug.sh file to ease the steps to run ngrok while running
ci-debugging
- Changes made to below files
1. integration-tests-command.yml
2. test-build-docker-image.yml
3. ci-test.yml
4. build-docker-image.yml
## Type of change
- integration-tests-command.yml
- test-build-docker-image.yml
- ci-test.yml
- build-docker-image.yml
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR adds mapping for 6001 port from TED to run the OAuth cases in
CI
## Type of change
- Yml file update
## How Has This Been Tested?
- Local run with TED
## Checklist:
### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
## Description
- Added ci-debugging.yml to enable local debugging
- Modularised docker image building with build-docker-image.yml
## Type of change
- ci-debugging.yml
- build-docker-image.yml
## How Has This Been Tested?
- Manual
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR updates the ci-test.yml file to empty the failed_spec_ci
folder which still holds the previoulsy (or attempt-1) failures & hence
prints the attempt-1 failures also in the attempt-2 git comment in PRs.
## Type of change
- ci-test.yml file update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
- This PR changes the mapping port of GITEA TED form 3000 to 3001
because while building client/server locally Appsmith uses
localhost:3000
## Type of change
- Script yml update (non-breaking change which fixes an issue)
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing the changes
## Description
Add ci test check command
Fixes # (issue)
Media
## Type of change
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
- Manual
### Test Plan
### Issues raised during DP testing
## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [X] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
## Description
- This PR includes yml file update to remove the duplicate entry of
failing specs in github comments during PR oktotest runs
## Type of change
- Script fix
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
- Updated the pat to access appsmithorg/ci-oldstack
## How Has This Been Tested?
- Cypress
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Specifying the branch name to pull from ci-oldstack in ci-test.yml
## Type of change
- ci-test.yml
## How Has This Been Tested?
- Cypress
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Updated ci-test.yml to pull the old stack from a private repo instead
of S3
## Type of change
- ci-test.yml
## How Has This Been Tested?
- Cypress
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR Stops SSH which is run on port 22 for enabling it for Local
Gitea support from TED
## Type of change
- Ci-test yml file update:
## Checklist
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
- This PR reverts https://github.com/appsmithorg/appsmith/pull/20471
## Type of change
- ci-test yml file update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
## Description
This PR reverts https://github.com/appsmithorg/appsmith/pull/20471
## Type of change
- ci-test yml file update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes test
## Description
- This PR reverts #20471
## Type of change
- ci-test yml file update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reveiwing all changes
## Description
- This PR Stops SSH which is run on port 22 for enabling it for Local
Gitea support from TED
## Type of change
- Script update
## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing the changes
## Description
- This PR adds the 3000 port mapping for the TED GITEA support for the
cypress tests
## Type of change
- Script update
## Checklist:
### QA activity:
- [X] Test plan has been peer reviewed by QA
- [X] Cypress test cases have been added and approved by either SDET or
manual QA
## Description
- Updated the if condition to run the ci-test
## Type of change
- ci-test.yml
## How Has This Been Tested?
- Cypress
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- Modularising the ci-test
## Type of change
- Workflow files
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
> Add back setup of ui nginx environment using docker while setting up
tests
Fixes # [(issue)](https://github.com/appsmithorg/appsmith/issues/20124)
> if no issue exists, please create an issue and ask the maintainers
about this first
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
- Manual
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR includes the script updates for connecting to TED Git instead
of actual Github for running tests
## Type of change
- New script changes to connect to TED Git
## How Has This Been Tested?
- Cypress CI runs
## Checklist:
### QA activity:
- [X] Test plan has been approved by relevant developers
- [X] Test plan has been peer reviewed by QA
- [X] Cypress test cases have been added and approved by either SDET or
manual QA
- [X] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [X] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR skips the upgrade spec until its fully functional
## Type of change
- Script fix
## Checklist:
### QA activity:
- [X] Cypress test cases have been added and approved by either SDET or
manual QA
Set the pr number as 0 for push event.
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
## Description
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
> Links to Notion, Figma or any other documents that might be relevant
to the PR
> Add a TL;DR when description is extra long (helps content team)
Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers
about this first
Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
## Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important
- Manual
- Jest
- Cypress
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
- This PR moves all specs from slim to fat container to run tests underneath it
- Fat has the actual libraries that are being shipping to customers, hence this PR
- Also includes moving Git tests from using GitHub to Gitea
## Type of change
- New run (non-breaking change which adds functionality)
## How Has This Been Tested?
- Cypress CI Fat runs
## Checklist:
### QA activity:
- [X] Test plan has been approved by relevant developers
- [X] Test plan has been peer reviewed by QA
- [X] Cypress test cases have been added and approved by either SDET or manual QA
- [X] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [X] Added Test Plan Approved label after reveiwing all Cypress test
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
## Description
- This PR removes the Upgrade workflow from being triggered in oktotest
## Type of change
- Yml Script fix (non-breaking change which fixes an issue)
## Description
- Appsmith Upgrade Test
## Type of change
- Cypress
## How Has This Been Tested?
- Cypress
## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Add JAVA setup step to perf tests in test build workflow.
This is a possible fix for perf tests on running because backend server
was not up.
Co-authored-by: Satish Gandham <hello@satishgandham.com>
## Description
Hides the list of failed tests behind a spoiler to avoid making PR pages
very long
Fixes # N/A
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## Description
Reverts the changes made to perf job in ui-build-workflow as the perf tests are getting skipped.
Co-authored-by: Satish Gandham <hello@satishgandham.com>
This upgrade takes care of our move to JDK 17, Spring Boot 3.0.1 and a
few other security upgrades along the way.
Fixes#18993
TODO:
- [x] Check CI changes for Java 17
- [x] Check vulnerability report
- [x] Mongock needs an upgrade
- [x] Add JVM args at all possible places for exposing java.time module
- [x] Add type adapters everywhere / use the same config for type
adapters everywhere
Remove perf-tests from /ok-to-test temporarily.
**Why**
Switch to github runners is causing an issue with perf tests, disabling until that is resolved.
Co-authored-by: Satish Gandham <hello@satishgandham.com>
## Description
Ci fix run result due to deprecated
Fixes # (issue)
Media
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
code reivew
### Test Plan
### Issues raised during DP testing
## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
## Description
Comment failing tests to PR
Fixes #
## Type of change
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
Code review. Tested in local fork
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
* Fix perf test failure due to a wrong step added earlier
* Remove all the steps added to make perf tests work on EE
Co-authored-by: Satish Gandham <hello@satishgandham.com>
## Description
- This PR adds a new fat-migration.yml file which will run all cases in fat container instead of dev.app.appsmith
- This PR will not affect any existing Push/Workflow dispatches as its a separate action file
- Moving to fat container will not be put into action until RBAC is live - so as to not trigger any new challenge at last minute
## Type of change
- New .yml file
## How Has This Been Tested?
- Cypress CI runs
## Checklist:
### QA activity:
- [X] Test plan has been approved by relevant developers
- [X] Test plan has been peer reviewed by QA
- [X] Cypress test cases have been added and approved by either SDET or manual QA
- [X] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [X] Added Test Plan Approved label after reveiwing all Cypress test
* - Add missing env variables to fix perf tests failures in EE
* - Delete source maps on CI only for EE
* - Add the additional steps that might be required for running perf tests on EE
* Update if condition
* Update if condition
* Switch to bash from using sh in build.sh
* Check if the server started later
* Update the check to see if the server has started
Co-authored-by: Satish Gandham <hello@satishgandham.com>
* Rearrange client build steps
* Remove PR from the run meta insert query
* Add repo to the query
Co-authored-by: Satish Gandham <hello@satishgandham.com>
* - Add S3 credentials to environment
- Change the workflow name
- Create performance run meta data record at the begining.
* Fix a typo
* Fix a typo
* Store DB credentials as plain values instead of JSON
* Fix SQL insert query
* Add missing secrets
* Continue even if the meta creation fails
* Fix SQL insert command
* Rename workflow
Co-authored-by: Satish Gandham <hello@satishgandham.com>
* Add option to run only perf tests on github
* Add new line at the end of the file
* - Run the artifacts step even on failure
- Add link to the perf run details
- Remove the perf comment on the PR
Co-authored-by: Satish Gandham <hello@satishgandham.com>
## Description
- This PR includes changes for starting rts server for AST changes to take effect
## Type of change
- yml file updates
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
## Description
- This PR includes changes for starting rts server for AST changes to take effect
## Type of change
- yml file updates
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
* update rts logic to use updated shared AST logic
* Make changes to naming conventions
* Add test cases for RTS and rename ast functions
* Add running jest test to RTS workflow
* Install dependencies and then trigger jest tests in workflow
* Close server connection after test ends
* Remove logs
* Improve jest test descriptions
Fix ci cache & rts build for push workflow
## Description
Fix ci cache & rts build for push workflow
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
code review
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
## Description
Fix ui-test cache
Fixes # (issue)
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
Code review
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
## Description
Fix ui-test cache
Fixes # (issue)
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
Code review
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
## Description
The problem with the RTS workflow after the induction of AST parsing was that while copying the `node_modules`, Ubuntu doesn't follow the symlink and copy the content. It simply copies the symlink as is. This causes issues for RTS service to start.
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
- Personal repository
## Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
## Description
The depot docker step wasn't initialized. This was causing Docker builds to fail.
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
- Relying on CI
## Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
Refer to #16020 for details. This PR has been opened since we could not modify the previous PR since it's a contribution by an external contributor.
Co-authored-by: kylegalbraith <kyle.galbraith459@gmail.com>
## Description
- This PR makes changes to run CI on latest stable Chrome always
## Type of change
- Browser update
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
## Description
- This PR makes changes for moving from Chrome to Electron browser for CI runs & fixes the git hub runners failure issue incases of Chrome version updates
## Type of change
- Browser name update
## Checklist:
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
Moving server builds to Buildjet to confirm if it's faster and more reliable
Also, cleaning up some CI workflows to remove references to release-frozen branch.
## Description
This PR adds the string `Community` along with the Appsmith version. This will help users identify the type of instance that they are running.
## Type of change
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
Manually
## Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
* Clean up the perf folder and update integration commnds to use the new repo
* Use a different token for github auth
* Update the token
* - Remove directory listing command
* Move perf checkout command to the back
* resolve conflicts
* Add directory listing code
* Fix an issue with directory listing
* - Remove directory listing code
Co-authored-by: Satish Gandham <satish@appsmith.com>
* Clean up the perf folder and update integration commnds to use the new repo
* Use a different token for github auth
* Update the token
* - Remove directory listing command
* Move perf checkout command to the back
* resolve conflicts
* Add directory listing code
* Fix an issue with directory listing
Co-authored-by: Satish Gandham <satish@appsmith.com>
* Clean up the perf folder and update integration commnds to use the new repo
* Use a different token for github auth
* Update the token
* - Remove directory listing command
* Move perf checkout command to the back
* resolve conflicts
* Add directory listing code
Co-authored-by: Satish Gandham <satish@appsmith.com>
* Clean up the perf folder and update integration commnds to use the new repo
* Use a different token for github auth
* Update the token
* - Remove directory listing command
Co-authored-by: Satish Gandham <satish@appsmith.com>
* Clean up the perf folder and update integration commnds to use the new repo
* Use a different token for github auth
* Update the token
Co-authored-by: Satish Gandham <satish@appsmith.com>
* Clean up the perf folder and update integration commnds to use the new repo
* Use a different token for github auth
Co-authored-by: Satish Gandham <satish@appsmith.com>
* Run perf tests only on buildjet machine
* - Set chrome process priority to maximum to stabilise the run data
* Update index.js
* Update perf.js
* Update index.js
* - Move around args
* - Add --no-sandbox option to initial setup
* -We don't need sudo on the main script, we can use sudo in node scripts to set process priority
* - Some tweaks to the perf scripts.
* - Remove no-sandbox option in puppeteer launch
* - Remove sudo at unnecessary places
* - Add code to force grabage collection in chrome
* Update logins and some cleanup
* Remove unsed import
Co-authored-by: Satish Gandham <satish@appsmith.com>
Reverts #14636
Reverting this change for now because there is an issue when re-running the failed specs. The action is unable to find the correct directory.
We use github actions cache to store jobstate for the previous runs. The default cache is invalidated incase the job fails. To support rerunning only failed tests, we use custom cache martijnhols/actions-cache@v3. Recently new changes into custome cache broke our workflow https://github.com/MartijnHols/actions-cache.
Co-authored-by: Yatin <yatin.chaubal@gmail.com>
* Adding visual tests for layout validation
* updating screenshot to match CI's screenshot resolution
* updating screenshot as per CI
* setting failure threshold for the image comparision
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Currently, all three services' artifact names are set to build. This leads to a single artifact with files from all three services as siblings. This has two problems:
1. If there's an overlap in a filename among the files in build folder of two services, one of them will be overwritten with the other.
2. The same large artifact is downloaded every time we do a download-artifact, once for server, once for client, and once for RTS, the same large artifact is downloaded thrice before building the Docker images.
Now we can add multiple title regexes for a PR and the labeler will automatically tag the PR with the appropriate labels. This will be useful when generated the release notes in a categorized fashion.
* Call cloud services to fetch mock datasets
* Call cloud services to fetch mock datasets
* Change the MockData Config,
* Remove unused import statements and fix small indentation issues
* 1. Moved the mock data creation and fetching to a separate class
2. Added plugin type to mockdata class
3. Used pluginName to identify the db type
4. Removed the block call mock data creating method
5. Added unit tests for the mockdata
* 1. Removed unused field from contract and
2. Updated the url to cloud service
* 1. renamed the field of mockdata contract
2. Updated the test cases
* using new mock datasources apis
* 1. Added the Cloud Service release end point to env variable
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
* Release frozen related changes
* Switched image used to PR head instead of target
* Update .github/workflows/client-test.yml
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* PRs into release should use release server code
* added empty byte array for request body to fix aws signed url signature match problem as detailed here - https://github.com/aws/aws-sdk-java/issues/2205
Co-authored-by: Bernard Worthy <>
* Include version information in backend builds
* Enable manual trigger of server workflow
* Add a dummy input field for manual trigger
* Fix secret checking in github actions
* Disable cron scheduling of sync job
* Build docker image on pushing a version tag
* Fix duplicated id and invalid id in release workflow
* Don't try to login to Docker
* Avoid download progress outputs from Maven
* Add version information for building client
* Calculate version number only once
* Enable push to DockerHub after building images
* Use Docker username from GitHub secrets
* Fix Docker username in tags when building image
* Use different secret for org name
* Minor refactoring in server workflow
* Update client build workflow to use version
* Enable manual triggering of client workflow
* Set snapshot version for server builds
* Push to docker for all branches (temp)
* Undo temp change to push all branches to DockerHub
* Use Docker org from secrets in client.yml
* Fix missing version reference in client.yml
* Remove debug command in dockerfile
* Save release notes in a resource file in Docker image
* Fix query serialization to get release notes
* Get releases of current repo instead of hard-coded repo
* Fix variable quoting for repo variables
* Exclude draft and prerelease nodes from image
* Fix call to any in release notes processor
* Fix syntax error in release notes script
* Implement API to get new release count and info
* Add missing ReleaseNotes component
* Have the release workflow run after a release is created
* Build server after generating release notes
* Change release trigger to "released"
* Change release trigger to "published"
* Change release trigger to released, edited and deleted
* Use JS script to get release notes, take 1
* Filter drafts and prereleases in script
* Fix syntax error in ES6
* Write release notes to file
* Create parent directory before writing release notes
* Log cwd in release notes script
* Log pwd along with release-notes content
* Handle case where working directory is incorrect
* Remove shell based release notes generator
* Don't show error when Sentry config is missing
* Check for sentry auth token to enable Sentry
* Carry build's exit code over to CI
* Mark out build result and add a note about it
* Add a small test to verify new versions computation
* Remove incorrect test assertion
* Remove generation of release notes file
* Connect to cloud services to fetch release notes data
* Fix missing runner for test class
* Handle missing cloud_services base URL
* Fix test failures due to missing mocks
* Enable sync-ee cron job
* Revert build.sh as there's no real change
* Add API to update release notes viewed version for users
* Fix prettier line-length errors
* Create UserData model for info unrelated to auth
* Fix field name calls
* Ensure we have a userId before setting userData
* Add tests for setting version number in UserData
* Include instanceId when fetching release notes
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Also adding the APPSMITH_SEGMENT_CE_KEY as a build arg to the server Dockerfile. This will be used to set the environment variable in the Docker image itself.
Also adding pull_request_target event for release and master branch. This will run the GH Actions in the context of the base repository instead of the forked one. Hence, the secrets for Cypress, Docker etc can be passed down to the action for PRs being raised via a fork
This is a hack to get around the fact that Github Actions doesn't support conditional status checks for monorepo PRs. Hence, we create similar jobs in the both server & client builds. In the server build, those jobs are dummy jobs that do nothing but satisfy the all-encompassing green tick so that PRs can be merged without using Admin privileges.
* Correcting the Docker image for Appsmith server for Github actions test
* Also fixing the bug where the datasource config is not returned properly for restapi-plugin
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* Adding a github action to push to Docker Hub and create Github release when a tag is created on master branch.
* Extracting the tag from the github ref and only tagging the Docker image with the relevant tag.
This PR adds the build, test & package workflow to the client code base as well.
In order for us to run the Cypress tests, we also spin up a local server in a Docker container and run all our tests against that server. This ensures that our tests are faster to run as well.
We also introduce the concept of stubbing network requests by stubbing the API that fetches the property pane configuration from the server.
Results for the Cypress tests can be viewed at: https://dashboard.cypress.io/projects/eyxvp8/runs/
