Commit Graph

9 Commits

Author SHA1 Message Date
Sagar Khalasi
ba6fd9bdef
chore: Running on failure only (reverting to original) (#36315)
## Description
Reverting to previous version as this steps specifically run for
failure.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10848068018>
> Commit: d646576aa20499b099adbf6f0479ff3b8363e41c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10848068018&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.ImportExport`
> Spec:
> <hr>Fri, 13 Sep 2024 11:26:38 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated workflow conditions to trim Cypress log files only on job
failures, improving log management for successful runs.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-13 17:00:23 +05:30
Sagar Khalasi
71b44a1736
chore: Updated error handling (#36288)
## Description
Added extra checks for better reporting


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10831607193>
> Commit: 2a5049d9cb17fc099c10e863b90a0694287c38fe
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10831607193&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.ImportExport`
> Spec:
> <hr>Thu, 12 Sep 2024 13:31:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced CI workflow to provide clearer test results through improved
commenting on pull requests based on test outcomes.
- Introduced a failure flag mechanism to explicitly record test
execution status.

- **Bug Fixes**
- Improved reliability of CI process by ensuring important logs and
results are preserved and uploaded even on test failures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-12 20:59:52 +05:30
Sagar Khalasi
a182e7409d
chore: Return failure results (#36233)
## Description

**Problem:** When running Cypress tests multiple times with the
cypress-repeat-pro --force option, we only see success messages. This is
because the `--force` option may override or mask failures, leading to
misleading results.

**Solution:** To address this, we have added a step to check for
specific failure indicators in the test summary file. If the summary
indicates that there were any failed tests (i.e., `Total Failed: 0` is
not present), the GitHub Action step will fail. This ensures that
failures are properly highlighted and reported in the PR comments.


Fixes #`36232`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10806403675>
> Commit: 3a04b01650a4f92967d6b489eead5d61e48cb89a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10806403675&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 11 Sep 2024 07:01:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced CI workflow to ensure GitHub Action fails if Cypress tests do
not pass, improving reliability.
  
- **Bug Fixes**
- Implemented a conditional check for test failures, providing clearer
feedback on test outcomes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-11 15:08:12 +05:30
Sagar Khalasi
4885337fd9
ci: Only command name update (#35926)
## Description
Only command name update


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10592127455>
> Commit: 1e1fb070a89908cd6bf78d0ba966d04305632f51
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10592127455&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 28 Aug 2024 07:44:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Improvements**
- Updated the CI workflow to utilize an enhanced version of Cypress for
running tests, potentially offering improved functionality and
performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-28 13:14:58 +05:30
Sagar Khalasi
d0e5085e2d
ci: Added code for PR comment results with repeat command (#35921)
## Description
**Challenge**: In our existing process, when users performed a limited
run with a specified count, the results were recorded solely in the
logs. This approach introduced an additional step, requiring users to
manually navigate through each workflow to check the results, which was
both time-consuming and prone to oversight.

**Solution**: To address this inefficiency, I took the initiative to
develop a custom npm library specifically designed to enhance the user
experience. This library automates the generation of a summary file that
consolidates the run data into a single, easily accessible document.
Furthermore, I integrated this solution into our existing workflow by
updating the process to automatically post the contents of this summary
file as a comment on the relevant PR upon completion of the run.

This improvement not only streamlines the workflow by eliminating the
need for users to manually sift through logs, but it also ensures that
critical information is immediately available at a glance. By
centralizing the results in the PR comments, we’ve enhanced transparency
and efficiency, allowing for quicker decision-making and more effective
collaboration. This solution is a step forward in optimizing our
processes and reducing the manual effort required to track and assess
test outcomes.

**Looks like this:**

<img width="993" alt="Screenshot 2024-08-28 at 11 06 37 AM"
src="https://github.com/user-attachments/assets/91a5966e-fef6-47b8-9fd8-9186012f2ab3">


Fixes #`35920`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10590991034>
> Commit: ef6ef69fb812ba43abba5d9d273623a914569c81
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10590991034&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 28 Aug 2024 06:19:47 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a summary of Cypress test results in pull request comments
for improved visibility.
- Added functionality to upload Cypress summary logs, ensuring
availability regardless of previous test outcomes.

- **Dependency Updates**
- Updated the testing package from `cypress-repeat-updated` to
`cypress-repeat-pro`, potentially enhancing testing capabilities.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-28 11:52:37 +05:30
Sagar Khalasi
ec4a376600
chore: Un commented yarn cache (#35668)
## Description
Having seen memory failure in EE repo for the yarn install. This same
steps works fine in CE.


Fixes #`35667`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10369580919>
> Commit: 29e0b8dbbd06ba6068af3484d466a57206e81c3d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10369580919&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 13 Aug 2024 12:37:35 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Restored the Yarn cache during workflow execution in case of failure,
improving build efficiency.

- **Chores**
- Updated GitHub Actions workflow to enhance caching mechanism for
better performance in CI processes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-13 18:09:01 +05:30
Sagar Khalasi
6238b3ed2c
chore: Fix parameter call from build file (#35620)
## Description
We’ve made significant progress and successfully ran a limited set of
test files by fixing parameters in the forked repository. I can able to
atleast trigger the workflow with slash command and passed right
parameter.

The ci-test-limited-with-count.yml workflow now supports running
specific test files. However, an issue was identified with one of the
parameters. To proceed with testing, the identified issue can be
resolved by merging this PR.


Fixes #`34956`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10351114050>
> Commit: fd17177d71110bf714b5ec4eaf7d2ae683cbdc68
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10351114050&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 12 Aug 2024 11:57:49 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit



- **Chores**
- Simplified access to the `run_count` variable in the GitHub Actions
workflow, improving readability and potentially enhancing performance.
- Updated syntax for referencing inputs in Cypress test workflows for
better clarity and consistency.
- Clarified default value handling for `run_count`, ensuring predictable
workflow behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-12 17:50:19 +05:30
Sagar Khalasi
92b8f81235
test: Testing pipeline with build yaml and run_count (#35524)
## Description
Testing the yaml with slash command.

Fixes #`34956`  


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10316110580>
> Commit: 41a74c726e332c4d9adeef876d60766f0c09c33a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10316110580&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 09 Aug 2024 08:43:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **Chores**
- Updated the GitHub Actions workflow to disable Yarn cache restoration,
which may affect build times.
- Modified Cypress test specifications to focus on the Fork application
instead of templates, refining test execution priorities.
- Enhanced the GitHub Actions workflow with a new input parameter,
`run_count`, improving configurability and responsiveness to events.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-09 14:25:24 +05:30
Sagar Khalasi
a30adfa5b3
test: Adding feature to run a spec file with count (#35282)
## Description
It is for running a spec file with given run_count

Fixes #`34956`  

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new GitHub Actions CI workflow for running limited tests,
enhancing the flexibility and management of the testing process.
- Added a new dependency for improved Cypress testing capabilities,
allowing for more efficient test execution.

- **Improvements**
- Enhanced artifact management for test runs and results within the CI
workflow for a more robust development lifecycle.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-30 13:44:10 +05:30