Commit Graph

5673 Commits

Author SHA1 Message Date
yatinappsmith
f900cf9765
test: JSEditor Tests (#8068)
* Added basic support for JSEditor

* Added copy and delete test cases

* Basic changes for js editor

* Basic tests

* JSEditor Binding tests
2021-10-07 07:59:16 +05:30
Favour Ohanekwu
803e5e7cc6
fix: improve dropdown component (#8183)
Improved multipart form's dropdown component
2021-10-06 20:20:35 +01:00
Nidhi
82dc82633f
fix: Make JS objects visible to anon users (#8260)
* Make JS objects visible to anon users

* Dummy commit
2021-10-07 00:30:16 +05:30
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
Apeksha Bhosale
b34102f685
fix: added errors to debugger (#8195)
* added errors to debugger

* comment added
2021-10-06 12:42:22 +05:30
balajisoundar
9fc8c92b02
chore: show canvas when user selects widgets tab during signposting flow (#8205) 2021-10-06 12:17:59 +05:30
balajisoundar
5db77f9b3f
chore: change welcome page usage data preferences label (#8166) 2021-10-06 11:41:25 +05:30
Nidhi
4498810cef
fix: Added graceful check for failure in mock data endpoint (#8211)
* fix: Added graceful check for failure in mock data endpoint

* Modified error type
2021-10-06 09:18:21 +05:30
Samyak Jain
e772fd4ff9
fix: using let instead of var and all var declarations at top (#8026)
* using let instead of var and all var declarations at top

* fix: used let instead of var
2021-10-05 22:55:16 +05:30
Hetu Nandu
038c62aea3
fix: Bug in evaluated value for falsy value checks (#8194) 2021-10-05 20:17:30 +05:30
Hetu Nandu
94e3ffef67
feat: Linting in trigger fields (#7638) 2021-10-05 13:52:27 +00:00
NandanAnantharamu
77d1c7ccfc
test: Updated flaky test (#8198)
* Updated flaky test

* updated test

* updated test

* commenting test
2021-10-05 18:39:07 +05:30
Trisha Anand
915484b7e5
Removing where clause from postgres template (#8202) 2021-10-05 16:47:42 +05:30
Abhijeet
24c1fbee7d
test: Update TC to include Smart Substitution and prepared statement check for generate page (#7922)
* Added prepared statement and smart substitution checks, in TC for generate page

* Updated Template

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-10-05 14:10:56 +05:30
arunvjn
f8ef495e4c
chore: Correct Appsmith spelling in messages (#8186) 2021-10-05 12:29:32 +05:30
albinAppsmith
7e4a5a0810
fix: Appsmith design system style fixes (#8182) 2021-10-05 12:03:58 +05:30
Nayan
c43854677f
fix: send list of users to others when someone leaves the page edit (#8162) 2021-10-05 01:27:53 +05:30
albinAppsmith
13b7c0431d
fix: Hardcoded version name removed (#8178) 2021-10-05 01:26:54 +05:30
Shrikant Sharat Kandula
08a775d63d
chore: Fix role and goal in event data (#8180)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-10-05 01:24:54 +05:30
Shrikant Sharat Kandula
89cc2555ab
Fix role and goal saving before using (#8177) 2021-10-04 23:09:56 +05:30
Nikhil Nandagopal
98c395cec7
chore: anonymised user id for ce (#8176) 2021-10-04 23:06:31 +05:30
Shrikant Sharat Kandula
edeec80d00
Fix role and goal usage and docker.env location (#8174) 2021-10-04 21:23:11 +05:30
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30
Favour Ohanekwu
30d0fb7a6d
fix: Add window object methods and properties as invalid entity name (#7928)
Added window object property and method names to list of invalid entity names
2021-10-04 13:49:58 +01:00
Apeksha Bhosale
7665ff3c4f
fix: small fixes js editor (#8022)
* remove space below response

* changes to name editor

* removing variable as dynamic binding path list

* error message change for js object
2021-10-04 16:38:02 +05:30
Ayush Pahwa
5c3cdea47b
Preventing evaluations to be reset on page change unless it is the first load (#8153) 2021-10-04 15:32:41 +05:30
arunvjn
d67165f8bb
fix: for in null check sentry bug (#8150) 2021-10-04 15:11:25 +05:30
Ayush Pahwa
b90a00ba0f
fix: Added checks to ensure that the configs are valid before starting eval (#8019) 2021-10-04 13:39:14 +05:30
Rishabh Saxena
a69c8b7484
feat: callouts for wip features (#8080) 2021-10-04 13:31:46 +05:30
Abhijeet
bacf29848b
test: Update testcases to check forking app is possible for user even with VIEW permission (#8079) 2021-10-04 13:24:17 +05:30
Pranav Kanade
ca4541a415
updated existing test cases to validate the import export flow with different user permissions (#8099) 2021-10-04 13:04:48 +05:30
Pranav Kanade
7298937e36
revert: back button navigation fixes (#8044)
* Revert "fixes to add proper routing around navigation between query pane, api pane and integration screen (#7782)"

This reverts commit b3d7f08d4e.

* Revert "fix: back btn navigation problems (#7692)"

This reverts commit c0f5ab3f30.
2021-10-04 12:27:26 +05:30
rashmi rai
4e7dec2738
added max width to the switch control (#7790) 2021-10-04 06:57:17 +00:00
Vinod
d9b4685192
Introduce linting to all users (#7736)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-10-04 12:11:02 +05:30
akash-codemonk
3d95598c18
fix: Fixes scenario where onboarding was trying to create an app in an organisation with view access (#8072) 2021-10-04 09:57:57 +05:30
akash-codemonk
a7fd0e16ac
fix: Fixes scenario where renaming actions was clearing debugger errors (#7993) 2021-10-04 09:57:23 +05:30
akash-codemonk
3209ad8cdf
chore: Do not show initialLocation of map widget in an error state when field is blank (#7931) 2021-10-04 09:56:52 +05:30
Nayan
dbb0cdef85
feat: added event for online page editors (#8130) 2021-10-03 20:36:17 +06:00
Abhijeet
82fac6405e
fix: Exclude the deleted page in applicationPages for export application flow (#7967)
* Added check for applicationPages to include only if not deleted
2021-10-03 10:51:33 +00:00
Shrikant Sharat Kandula
cb4d059e5f
Effect the telemetry choice in welcome page (#7902)
Solves for two things:

1. From the welcome page signup, depending on telemetry being enabled or disabled, we report.
2. When telemetry is changed from welcome page (which, it obviously will), we make the change persistent by writing to the env file.
2021-10-02 11:45:17 +05:30
Nayan
a8ab1e4cb6
fix: update user names in notifications when users update their name (#8043)
Fix: update user names in notifications when users update their name
2021-10-02 00:42:50 +06:00
Nayan
12acbf4a55
feat: added API to get unread comment thread count in an application (#7975) 2021-10-02 00:42:11 +06:00
Hetu Nandu
79aefc4d74
hotfix: js action parsing error resolution (#8086) 2021-10-01 22:40:49 +05:30
Pranav Kanade
a1488a73f6
refactor: client side rts (#7837)
* moved constants to a proper files

* added new action constants

* updated websocket reducers and actions

* updated websocket saga to handle proper socket events

* updated initialization

* updated multi pointer arena + realtime app editors components

* minor feedback update

* updated events list by socket level

* removed e.persist

* passing socket obj rather than just id
2021-10-01 16:44:19 +00:00
Pranav Kanade
b261efc511
fix: skip bot comment when user skips comments tour (#7693)
* setup for skipping the bot comments if user skips the comments tour

* Using the onboarding status api

* removed comments

* fixed typos

* added test cases

* small fixes

* updated the tests

* minor update to a test case
2021-10-01 21:55:55 +05:30
Hetu Nandu
633db3068e
fix: Single binding sql query causing prepared statement issue (#7792) 2021-10-01 21:05:05 +05:30
Bhavin K
1e6b916ff9
added auto focus for number input (#7961) 2021-10-01 15:09:59 +00:00
Abhijeet
49182e7060
chore: Update success asset urls for generate page (#7579)
* Update asset urls

* fix: use successImageUrl for CRUD success popup

* Increase delay to switch between GIF and image

* Use ASSETS_CDN_URL instead of S3_BUCKET_URL

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2021-10-01 15:09:41 +00:00
Nidhi
60f53546d2
Refactor now uses FQN when available (#7964) 2021-10-01 15:09:27 +00:00
Hetu Nandu
72f6ad8d99
fix: Cyclic dependency not resolving in JS Editor (#8003) 2021-10-01 15:09:09 +00:00
Nidhi
70c282da5a
fix: Refactor collection API (#7962)
* Refactor collection API

* Refactor collaction API
2021-10-01 15:08:56 +00:00
arunvjn
7acce6e802
fix: slash command auto open (#7977)
* Remove onFocus trigger for slash commands.
2021-10-01 15:08:42 +00:00
arunvjn
223bf0174f
fix: snippets ranking (#8020) 2021-10-01 15:08:26 +00:00
rashmi rai
0619e3798f
fix: missing where key in plugin specified templates (#8040) 2021-10-01 14:02:52 +00:00
Nidhi
e4c1c2a9ca
Converting headers safely into jsonnode (#8021) 2021-09-30 16:08:40 +00:00
Trisha Anand
9dafd3207f
fix: [Filter Library]Prepared Statements doesn't set value if the data type is not supported in H2. Defaulting to String for unsupported types. (#8015)
* Prepared Statements doesn't set value if the data type is not supported in H2. Defaulting to String for unsupported types.

* Incorporated review comment
2021-09-30 15:48:52 +00:00
Trisha Anand
d8dec82565
Handling the empty object set for where clause in new actions (#8017) 2021-09-30 14:58:32 +00:00
Nidhi
713ed76676
Fixed check for missing action collections (#8006) 2021-09-30 19:04:33 +05:30
Abhijeet
35442e2d42
fix: Update application permission for forking functionality, to enable templates forking (#8007) 2021-09-30 12:47:16 +00:00
Shrikant Sharat Kandula
4c1ed4a67e
Fix migration to not load full actions into memory (#8005) 2021-09-30 17:42:36 +05:30
Rishabh Rathod
70e6e54815
fix: Avoid sending param with no initialValue (#7647)
- Add initialValue for spreadSheetURL
- Pass only params having initialValue defined in generate CRUD
2021-09-30 11:29:09 +00:00
Tolulope Adetula
8b30fdd758
fix: wrong doc link (#7983) 2021-09-30 03:39:21 -07:00
Ayush Pahwa
6023bb10e4
fix: 7630 fixing where clause add delete row (#7968)
* Added new row addition action for form value changes

* Added comments

* Added special handling for where clause rows
2021-09-30 09:40:40 +00:00
Pranav Kanade
cf3cdced07
fix: small utility fixes for redirection to datasource and export app permissions (#7970)
* send user to auto tab in integration from property pane when they create new query

* only app admins will be able to export from inside app
2021-09-30 13:29:14 +05:30
Nidhi
a6a6c7e702
fix: Delete action collections on deleting page (#7957) 2021-09-30 05:59:40 +00:00
arunvjn
964d58747a
fix: snippet usage analytics (#7946) 2021-09-30 03:31:50 +00:00
Apeksha Bhosale
1aac46a66d
don't send errors to sentry (#7906) 2021-09-29 20:11:55 +05:30
Apeksha Bhosale
222f0e04c3
sending collectionName instead id in refactor (#7930) 2021-09-29 20:10:49 +05:30
Nayan
81d78ca9e8
fix: Signposting when user signs up with oauth is not working (#7918)
Creates a default application when users signs up from oauth
2021-09-29 20:07:28 +06:00
akash-codemonk
48f2c584ab
fix: Fix mismatch between errors in debugger and evaluated value popup (#7752) 2021-09-29 17:33:11 +05:30
Nayan
c3724d5df2
feat: Skip bot-comment when onboarding is skipped (#7816)
Backend changes to skip the bot comment and onboarding
2021-09-29 15:50:57 +06:00
Rishabh Rathod
570731507b
fix: Remove unneccessary scrolling (#7896) 2021-09-29 11:23:24 +05:30
Satish Gandham
c3d5b1010b
fix: Change multiselect back to supporting numbers and boolean. (#7895)
* Revert "fix: multiselect validation (#7698)"

This reverts commit 728a2559c5.

* - Convert the multiselect options value and labels to string before filtering as the values can be numbers.

* - Discourage users from using string in multiselect default value

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-28 19:38:24 +05:30
Nidhi
883b0215a6
Changes for JS actions in the import/export feature (#7892) 2021-09-28 18:13:26 +05:30
Ayush Pahwa
f8442622b3
fix: Added new row addition action for form value changes (#7682) 2021-09-28 11:36:03 +00:00
Aswath K
b4bab33d1e
fix: make the row click event trigger when table button is clicked (#7878) 2021-09-28 16:27:44 +05:30
Abhijeet
0729ab3211
fix: Display result in tabular format for action response in imported app for SQL datasource (#7889)
* Added pluginId to nested datasource object within actionDTO

* Added check in TC for plugin id
2021-09-28 16:03:56 +05:30
Nikhil Nandagopal
5c3e4ba715
fix: Update crud template (#7891)
* Delete CRUD-DB-Table-Template-Application.json

* Updated Template

* Update TC to replace selectedRow with triggeredRow as per the updated template

Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM>
2021-09-28 15:28:33 +05:30
Pranav Kanade
25035cbf88
hiding comments mode toggle for anonymous users (#7885) 2021-09-28 14:37:12 +05:30
Shrikant Sharat Kandula
f6d2e89ae3
fix: Actions not being deleted when app is deleted (#7880) 2021-09-28 13:28:50 +05:30
Apeksha Bhosale
a1e5b39b49
fix: Debugger logs and errors related to js editor (#7749)
* added errors

* small change url

* messages created

* few logs for debugger

* after merge
2021-09-28 13:01:46 +05:30
balajisoundar
287f7e2de2
chore: Signposting progress should be hidden when user generates a page (#7883)
Fixes: #7660
2021-09-28 11:58:18 +05:30
Apeksha Bhosale
1b8a77044e
scroll for response tab list of functions (#7864) 2021-09-28 11:29:09 +05:30
Vinod
d1730a92f9
fix: autocomplete suggestions should be restricted in bindings (#7732)
* Remove bracket highlight on error

* hide data tree functions in non actions

* filter by entity type

* fix the autocomplete issue

* temp

* Fix case where entity type is undefined

* remove unused code

* fix failing test
2021-09-28 11:09:43 +05:30
Paul Li
31424e77b1
fix: The recorder widget does not reset when onClick actions on submit button is set to reset recorder widget (#7729)
-- Add the logic for resetting the widget
2021-09-27 23:55:53 +05:30
Sumit Kumar
611ff3b776
feat: make Mongodb plugin error messages more readable. (#7857)
* Make MongoDB plugin's error messages more readable. A Client side change is required before this change becomes visible to the end user.
2021-09-27 15:10:14 +00:00
Bhavin K
59edccf294
fix: Image widget - file format change on download file (#7335) 2021-09-27 19:42:21 +05:30
Pranav Kanade
db02756173
fix: upgraded socket.io client package to latest stable version (#7845)
* upgraded socket io client to latest stable version

* auto update enabled

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
2021-09-27 16:59:47 +05:30
arunvjn
cb2ad8990a
Removed snippets feature flag (#7839) 2021-09-27 08:19:07 +00:00
Aswath K
d9fa049578
fix: Button variant validation (#7699)
* fix: Button variant validation

* fix: MenuVariant validation

* Add default value to buttonVariant

* Adds default value to MenuVariant
2021-09-27 12:00:04 +05:30
Tolulope Adetula
60131403b2
feat: disable parsing link (#7075)
* feat: add disableLink for text widget

* feat: add test for disable link

* fix: email parsing

* fix: test issues

* fix: failing test

* fix: failing test
2021-09-26 23:00:40 -07:00
Aswath K
20c1b56932
fix: table button migration issues (#7825) 2021-09-27 10:45:51 +05:30
arunvjn
90fda1ccae
fix: Remove snippet and doc icon from property pane (#7806) 2021-09-27 04:56:39 +00:00
Sumit Kumar
a7dcfae491
- remove feature flag for snippet. (#7824) 2021-09-27 08:12:04 +05:30
rahulramesha
46f525d365
fix: modal widget issues (#7821)
* fixing modal issues

* adding cypress tests

* patch for modal Issues
2021-09-25 16:45:39 +05:30
Aswath K
8a45e1507e
feat: Add AudioWidget (#7179)
* Create initial version of AudioWidget by copying VideoWidget

* Add EventType for AUDIO

* Change default Audio URL to a podcast related to Appsmith

* Add AudioWidget icon

* Change Entity definition for AudioWidget

* Add cypress test

* Add jest test

* fix: typo
2021-09-24 21:35:53 +05:30
arunvjn
f3afa81afe
fix: copy snippet (#7769)
Fixes copy snippets and snippets execution toast messages
2021-09-24 19:19:59 +05:30
Trisha Anand
eb0f88244a
Adding where key in generate CRUD application with google sheets for SelectQuery (#7812) 2021-09-24 12:37:42 +00:00
Pranav Kanade
79f613cf71
handle socket exception and log to sentry for time being. Need to test its impact on import/export (#7818) 2021-09-24 17:44:26 +05:30
Satish Gandham
941db9e99c
fix: Tweak how we show errors for required and not required inputs (#7783)
* - If a field is not required and empty, don't show error.
- If a field is required and empty, bail early and show error.

* - Remove default label from input
- Fix a issue with required validation

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-24 11:52:46 +00:00