Commit Graph

1220 Commits

Author SHA1 Message Date
Keyur Paralkar
d39cecbbb4
feat: chartwidget reskin feedback (#15621)
* style: added styles to chart configs

* style: adjusted axis names and legend position

* style:
* adjusting legend position
* removed background property at the widget level
* exposed current theme data at widget level

* fix: addressed feedback on chart widget reskin

* fix:
* style according to feedback
* styled custom charts

* fix:
* added migration for accentColor and fontFamily
* implemented reskinning feedback

* fix: changed the position of properties in custom chart config

* fix:
* added unit test for migration
* changed the caption color

* fix: spacing fix

* fix: added accentColor and fontFamily defaults

* test: added cypress test for chart reskinning

* test: fixed cypress test failure
2022-08-12 17:40:17 +05:30
Aswath K
b77a8cae81
feat: JS toggle for icon property of Inputs (#15947) 2022-08-12 14:35:37 +05:30
Aswath K
ee32ffb76f
chore: Grouping & reorganisation for Input widgets (#15584) 2022-08-11 16:50:09 +05:30
Tolulope Adetula
c6ed1b7214
fix: select default value validation (#15846)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* fix: add jest test

* Empty Commit

* Fix: Empty commit to re-reun

* empty commit

* Empty Commit

* cy fix

* json field event fix

* TableFilter failure fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 10:02:55 +05:30
Dhruvik Neharia
ce2aafaee4
feat: Change default label position of RTE widget to top (#15769) 2022-08-10 14:00:24 +05:30
Aswath K
781620d57b
chore: Property Pane Grouping of Chart, Maps & Media widgets (#15557)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Adds FilePickerWidget

* Adds MapChartWidget

* Adds ContainerWidget

* Adds MapWidget

* Adds ImageWidget

* Adds AudioRecorderWidget

* Adds CameraWidget

* Adds ChartWidget

* fix: issues found in design review

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* Adds FormWidget

* fix: mapchart style section heading

* refactor: cleanup

* incoorporate latest change for Camera widget
2022-08-09 13:05:36 +00:00
Aswath K
6430adb413
chore: Grouping & reorganisation for multiple widgets (#15673)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties

* Adds TextWidget

* Adds RateWidget

* Adds DividerWidget

* Adds ProgressWidget

* Adds ListWidget

* adds TabWidget

* Adds IframeWidget

* Adds StatboxWidget

* Adds ModalWidget

* changes after design review
2022-08-09 13:05:15 +00:00
Bhavin K
f85cbb9938
fix: reset the filepicker widget when the user goes to a different link (#15626)
* fix: reset the the fileficker widget

* test: add test-case for file-picker
2022-08-05 19:00:01 +05:30
Tanvi Bhakta
86f0da37db
feat: change imports for dropdown v2 and dependencies (#15081)
* Remove Dropdown, SearchComponent from this repository

* Change the imports so that SearchComponent and DropdownV2 come from the design system

* Add yalc

* default imports become named imports

* remove the yalc package, add the beta version

* Change import for SearchComponent in TableHeader

* Updated Label Config

* chore: Refactor dependency Map code (#14944)

* feat: Triggerpath dependency (#15015)

* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-05 10:05:28 +00:00
ashit-rath
ab5eb0e325
fix: JSONForm field event trigger binding get updated formData values (#15650)
fix: JSONForm field event trigger receive updated formData
2022-08-05 11:49:24 +05:30
Pawan Kumar
89b39e239b
fix: Reskinning Radio + Toggle + Checkbox (#15329)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* fix alignment issue

* fix cypress tests

* fix snapshot tests
2022-08-05 10:16:42 +05:30
Aswath K
7624b91026
chore: Grouping & Reorganisation for ButtonWidget, JSON Form widget and Audio Widget (#14379)
* POC: Grouping for ButtonWidget

* Adds featureflag

* improve feature flag experience for unfinished widgets

* Styling of tabs

* Adds activation group for ButtonWidget

* Makes contentConfig & styleCOnfig optional to avoid typescript errors from tests

* Adds UI for search

* Fixes title, search & tabs UI to the top

* fix: style issue

* fix styles

* refactor ProeprtyPaneTab

* updates Button based on Figma design changes

* POC for AudioWidget

* chore: JSON Form Grouping & Reorganisation (#15033)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* reorder JSON form's array data section

* Adds Button Form settings

* Address QA comments

* update JSON form with new design changes

* Open array & object style by default

* trigger ci

* chore: Grouping & reorganisation of Video widget (#15297)

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* Content & Style Config for Video Widget

* refactor and better naming of function

* address review comments for JSON form configs

* fix UI issues

* ??

* chore: Grouping & reorganisation of Document Viewer widget (#15514)

* Grouping & re-org for Document Viewer

* fix: scroll issue

* feat: Search properties in property pane (#14876)

* Upgrades fuse.js package

* Property pane search POC

* POC: JSON Form grouping

* fix: Empty sections

* Moves icon into a separate sub section

* fix some sections based on updated Designs

* fix styling issues

* fix: double border

* udpdates based on Figma updates

* Updates order as per Figma

* fix unused variable after merge

* Adds empty search UI

* Makes the order of search result proper

* Refactor PropertyControlGenerator

* refactor and support for panel

* Revert "Upgrades fuse.js package"

This reverts commit 76d8038139ff4b8add79019a75eaaf40fd620e8e.

* extract out search functionality to helper

* cleanup

* fix: panel issue

* Focus on Search bar on opening the property pane

* better naming

* fix: fuzzy search params

* refactor: As suggested in the code review

* fix: section is not hidden when there's no children

* fix: issue panel properties
2022-08-04 11:01:05 +05:30
Tolulope Adetula
9e66a774dd
feat: Multiselect defaultValue Validation Check for ServerSide Filtering(On/Off) (#15491)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests
2022-08-03 14:17:07 +01:00
Hetu Nandu
887832d29a
refactor: deprecate commenting and notifications (#15484) 2022-08-03 12:32:49 +05:30
Bhavin K
cf9b869b12
fix: improve camera widget (#14679)
* fix: issue points Android :2,3,6

* fix: improving the camera widget

* fix: show the device menu in fullscreen mode

* refactor: use getPlatformOS for check platform os

* refactor: add missing yarn file

* fix: camera switching issue when video mode

* fix: removed the audio/video mute button from ios devices

* fix: Disable the media button instead of hide in ios devices
2022-08-03 11:32:23 +05:30
Tolulope Adetula
ef956ecad0
feat: Select defaultValue Validation Check for ServerSide Filtering(On/Off) (#15133)
* feat: defualt value check

* fix: Empty commit trigger deploy

* Fix: add more tests

* fix: improve validation

* Feat: improve jest test

* fix: more tests

* Fix: add github link

* Update app/client/src/widgets/SelectWidget/widget/index.tsx

Co-authored-by: ashit-rath <ashit@appsmith.com>

* fix: add more comment to issue

* fix: failing test

* fix: cypress config

* Fix: empty commit

* fix: select issue

* Fix: failing tests

* fix: failing Tests

Co-authored-by: ashit-rath <ashit@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2022-08-01 06:02:48 +01:00
balajisoundar
a6d37625a1
fix: provide access to currentRow in table widget menubutton items (#15457) 2022-08-01 10:31:34 +05:30
Keyur Paralkar
c396224fe8
fix: filePicker widget re-skinning (#15183)
* fix:
* added css variables for primary color
* added styles for dropHint custom icon

* feat:
* styled the remove uploaded file icon to match re-skinning
* added theme font-family to the contents inside the upload modal
* styled upload button to match re-skinning

* feat:
* set cancel button color to theme's primary color
* set the close button style according to theme
* set the border radius of the upload modal
* set the error message styles in accordance with re-skinning

* fix: cross mark position on the top right corner of upload modal

* fix: added hover background color on modal back and add more files button

* fix: added border radius fix for file remove button

* fix: modal close icon

* fix: addressed feedback from dilip

* fix: font-family issue inside the modal

* test: added cypress test to test styling logic
2022-07-29 10:29:02 +05:30
Arsalan Yaldram
9dea163172
fix: show clear input icon on allow clear value (#15232)
* fix: show clear input on allow clear value

* fix: truncate select input on small size
2022-07-27 22:33:05 +05:30
Bhavin K
47cc518dbe
fix: set default on reset of The Tab widget (#15202) 2022-07-27 14:26:16 +05:30
Bhavin K
f45a15545d
fix: depercate form button widget (#14510) 2022-07-22 08:27:37 +00:00
Souma Ghosh
d45a6bfb97
fix: Compact property not functional for menu type in table widget v2 (#15302)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:45:48 +05:30
Souma Ghosh
27e91f8524
feat: Expose message event details for Iframe Widget (#14730)
* Expose message event details for Iframe Widget

* Change meta property name from messageEventProps to messageMetadata

* Cypress test for Iframe Message event details

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:42:57 +05:30
Bhavin K
7ecca954c7
fix: changed the marker(default) value string to number (#15217) 2022-07-20 18:46:06 +05:30
Souma Ghosh
eddd1e8344
fix: Multiselect widget height decreases on selecting more options (#15228)
Fixes issue where multiselect height decreases on selecting more options
2022-07-20 14:26:37 +05:30
Bhavin K
8848d89650
fix: Added the loader in the Button group widget (#15246) 2022-07-20 14:21:54 +05:30
ashit-rath
cb40e04aa0
fix: JSONForm default array item not deletable when default value initialized with undefined (#15205) 2022-07-20 14:07:52 +05:30
Anagh Hegde
dbf0b94973
feat: Update the table widget to v2 in suggested widget list (#15277)
Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-20 12:28:50 +05:30
balajisoundar
71e581d69b
fix: cell background for edit actions column in Table v2 (#15233) 2022-07-20 11:42:59 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
rahulramesha
b878d5bd01
fix: Update maincanvas height on widget resize, drag or delete operation (#14992)
* fix extra space on canvas

* reverting selector changes

* use updated main canvas minheight

* use default canvas minHeight
2022-07-15 15:57:13 +05:30
Souma Ghosh
d40a8fd9f2
fix: Compact property not functional for menu widget (#15090)
Fix compact property functionality for menu widget and menu type in table widget
2022-07-14 17:11:03 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
rahulramesha
4dc3ed481c
fix: modal and App viewer header overlap (#15093)
* modal positions calculations on App View mode

* using css variables to compute modal offsets
2022-07-12 21:13:26 +05:30
Tolulope Adetula
d9d1c0c676
fix: dropdown not closing is fixed (#15058)
* fix: Dropdown issues

* CR fix

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-12 17:20:09 +05:30
Arsalan Yaldram
7c220affd5
fix: selectwidgets clear search input on selection (#14609)
* fix: clear search input on selection

* fix: added comments in single select test case.

* fix: single select tree widget clear search on close

* fix: test cases for mult-select-spec

* fix: clear the filterText on select widget close

* fix: added resetOnClose to select component

* fix: resetOnClose only when serverSideFiltering is off
2022-07-08 18:57:13 +05:30
Keyur Paralkar
170dc193ad
fix: reset selectedFiles meta prop only on specific reason event (#15023)
* fix:
* removed the componentWillUnmount to avoid uppy reset
* added cypress test case

* fix:
* added componentWillUnmount again
* added reason argument to the file-remove handler
2022-07-08 13:32:54 +05:30
Arsalan Yaldram
4a9a05e88c
fix: currencyInput , phoneInput show empty pop when no search result is found. (#14764) 2022-07-07 11:28:19 +05:30
Preet Sidhu
8600201694
fix: App crash on binding large base64 data to text widget (#14782)
* add validation for excessive text length

* add max length as a param

* update max length to 20k
2022-07-07 05:38:24 +00:00
Bhavin K
1ca40f9eeb
fix: show the error message for text input widget (#14934)
* fix: show the error message for text input widget

* Update the error message & added releated new test case
2022-07-07 05:37:54 +00:00
Bhavin K
cc36ae70bb
fix: revert checkbox-group widget breaking UI issue (#14933)
Revert "fix: checkbox-group widget breaking UI issue (#14820)"

This reverts commit 6686b94280.
2022-07-04 14:33:31 +05:30
f0c1s
06ed917f8e
chore: code cleanup - remove extra break (#14672)
## Description

There are some instances of unreachable code, this PR fixes them. And some typos.
## Type of change

- Code Quality Improvement and code cleanup

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-04 09:25:40 +05:30
Rishabh Rathod
8e47219d05
fix: remove debounce from RTE component (#14126)
* fix: remove debounce from RTE component

* fix value change on prop

* Add comment for useEffect order understanding

* fix:
* default text update
* Text re-appearing once deleted

* fix: cursor jump issue

* test: added cypress tests for RTE widget

* fix: isDirty value not updating properly

* chore: added comment for the new useEffect

* fix:
* Changed the logic to include a state inside RTE component
* Added cypress tests

* fix: updating ref on on keystroke events

* fix: suppressed props.onValueChange call on change of default text

* refactor: addressed review comments

* test: fixed failing cypress test

* fix: renamed styles related to label
* added a test case for checking cursor position when in markdown

* test: refacotored test case

Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-04 08:31:16 +05:30
Pawan Kumar
d60ea07e65
The reset button on properties behaves incorrect for JSONForm fields and Table primary columns (#14768)
Reset value in primary columns in table widget and fields in JSONFOrm was not working as expected. This commit fixes that.
2022-06-30 15:52:20 +05:30
Bhavin K
6686b94280
fix: checkbox-group widget breaking UI issue (#14820)
- Hides Style alignment when Inline option is false which fixes UI overlapping issues
- Resizing the widget other options which are outside don't come within the widget boundaries - Fixed
- Behaviour of widget when placed at top of the canvas - Fixed
2022-06-30 11:12:45 +05:30
Aswath K
f895f7bf14
CENTER as default value for vertical alignment (#14888)
Set "CENTER" as default value for Vertical Alignment property instead of invalid value "LEFT"
2022-06-30 09:49:52 +05:30
rahulramesha
f90ce07143
fix: Multi widget selection fixes (#14388)
* rewrite logic for widget multiselect box position and dimension

* logic to select only the widgets on the same canvas while dragging to select them

* fix jest test case
2022-06-29 11:55:26 +00:00
Bhavin K
a2dd01806c
fix: remove the duplicate and rename the actions to events in property panel (#14714)
* Fix: Remove the duplicate & rename the "Actions" To "Events"

* rename the "Actions" to "Events" in select & multiselct widget

* Trigger Build

* fix: failed testcase are resolved
2022-06-29 11:54:50 +00:00
Rishabh Rathod
5625784829
fix: reset meta to default value (#14468)
* fix: [WIP] reset meta to default value

* refactor

* fix reset child widget and type in metaReducer

* Fix type and refactor test

* fix multiselect click

* Add jest test for reset widget action

* Add cypress test

* Add comments

* Add more cases as per comment

* remove `only` from test case

* Add default value case of array with values

* MultiSelect spec fix

* fix currencyInput reset

* refactor test code suggested in comments

* fix type

* fix more type

* fix cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-25 11:00:54 +05:30