d34edec1f4
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
srix
|
d34edec1f4
|
feat: assistive binding (#27070)
> Pull Request Template ## Description An assistive Binding feature is added. A new code editor hinter menu will pop up once three characters is pressed, and they match with any entities. This assistance is expected to help many new app builders discover binding features. PRD: [Widget binding & success](https://www.notion.so/appsmith/Widget-binding-success-bc2f559b67194891992c6163eb8ac457) UI Design : [Zeplin](https://app.zeplin.io/project/64df0f50e3f9570e8dcfc803/screen/64df0fa0e771af22508f2267) POC: [POC for Binding Success - Engineering](https://www.notion.so/appsmith/POC-for-Binding-Success-Engineering-07157e8e90c7451a850d6d054d975f36) ERD : [Engineering Requirement - Assistive Binding](https://www.notion.so/appsmith/Engineering-Requirement-Assistive-Binding-b04e41f07e3b4c998be7b8b49f8324ba) #### PR fixes following issue(s) Fixes # (issue number) When a users input within a property of a widget matches any query/api/jsobject of their application, a dropdown menu will appear with possible binding options for users to select from. #26682 When the user adds a new binding from the menu the cursor should be present in between the moustache bindings #26683 When a user toggles JS mode for the input, bindings with the cursor in between them should be present by default (incase input has no value) #26685 #### Media #### Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [x] Cypress > > #### Test Plan https://github.com/appsmithorg/TestSmith/issues/2507 #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1710094372 - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711189712 - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711209028 - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711214677 - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711311082 - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711321208 - [x] https://github.com/appsmithorg/appsmith/pull/27070#issuecomment-1711336112 ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [x] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [x] Test plan has been peer reviewed by project stakeholders and other QA members - [x] Manually tested functionality on DP - [x] We had an implementation alignment call with stakeholders post QA Round 2 - [x] Cypress test cases have been added and approved by SDET/manual QA - [x] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: arunvjn <arun@appsmith.com> Co-authored-by: Favour Ohans <fohanekwu@gmail.com> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|
balajisoundar
|
64cec91a0f
|
feat: select and multiselect label value (#24964)
## Description - Select and multi-select widgets now have two new properties under the data section label and value. - The existing options have been renamed to Source data. - Users can set the label and value of the options through these new properties. - We have written migrations to make this work for existing select widgets. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/24022 > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [x] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> |