Commit Graph

869 Commits

Author SHA1 Message Date
Tolulope Adetula
06eac9387e
fix: make table button transparent when no color is selected (#11348)
* fix: make table button transparent when no color is selected

* fix:  failing tests in Table_widget_add _button_spec
2022-02-23 07:54:46 -08:00
Paul Li
c30f072c84
fix: Input widget onSubmit ends up triggering onTextChange (#11304)
-- Make onSubmitSuccess callback not to trigger additional onTextChange
2022-02-23 20:44:55 +08:00
Bhavin K
03dc8da930
fix: updated max character validation (#11333) 2022-02-23 11:53:58 +05:30
Bhavin K
e944f1b17c
fix: handled to hide widget in preview mode (#11138)
* fix: handled to hide widget in preview mode

* docs : comment update

* fix: condition updated as required, cypress test added

* fix: simpler condition, types updated
2022-02-23 10:22:04 +05:30
Tolulope Adetula
24293ced76
fix: select widget accept string and object in the defaultOption property (#11082)
* fix: Select widget accept string and object

* fix: JSON object case

* Fix: make Multiselect Defaukt option Array of strings

* fix: Select and Multiselect

* fixes and test cases

* comments

* fix: Select option value

* fix: mutiselect and test case

* fix: failing test

* fix: reset select widget

* fix: PR issues

* fix: Select widget Reset

* fix: failing Test

* fix: test

* fix: tests

* FIX: EVALUATION TESTS

* fix: getting Select Value in form

* fix: Test cases

* fix: add more test cases

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-22 00:43:35 -08:00
Bhavin K
707dd9bb8a
fix: updated css for ISDCode Dropdown in the phone widget so that placeholder does not collapses to the left when disabled (#11196) 2022-02-21 11:12:39 +05:30
Bhavin K
9eeb120c77
fix: updated height for page view (#10796) 2022-02-18 19:34:14 +05:30
Arsalan Yaldram
d12ae7a800
fix: Table Filter pane overflows when Table is at the top of the canvas (#10618)
* Added boundaryParent prop to Propperto prevent table filter pane overflow.

* Review Changes, done.

* Resolved overflow issue with multiple pages.

* Removed hardcoded Top value while dragging.

* Added parentElement as a function parameter.
2022-02-18 12:26:09 +00:00
Arsalan Yaldram
45da98f1dd
Merge pull request #10935 from appsmithorg/fix/10766-rating-inactive-color
fix: Rating Widget inactive-color.
2022-02-18 17:54:44 +05:30
Paul Li
12dad5737d
fix: Issues and Enhancements in the camera widget (#10943)
* fix: Issues and Enhancements in the camera widget

-- Fix on an image stretching issue when taking a picture
-- Set background to black
-- Add onImageSave, onVideoSave Actions
-- Rename Camera to Image

* fix: Issues and Enhancements in the camera widget

-- List all device info only when one or more MediaStreams are active

* fix: Issues and Enhancements in the camera widget

-- Always keep camera aspect ratio when resizing

* fix: Issues and Enhancements in the camera widget

-- Add a Cypress test case for onSaveImage property

* Increased wait!

* Camera case failure locator fix

* Camera case locator fix

* Promises restWidget moved to last!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-17 20:10:32 +08:00
Paul Li
f3360d814e
fix: Text widget shows a horizontal scroll on center and right alignment (#11189)
-- Set overflow-x to hidden on StyledText
2022-02-17 20:01:15 +08:00
Arsalan Yaldram
81e79af04f
Merge pull request #10954 from appsmithorg/fix/10697-rating-widget-flickering
fix: rating widgets flickering when value is reduced.
2022-02-16 13:27:21 +05:30
Tolulope Adetula
7837b568af
fix: select Widget resize (#11048) 2022-02-14 23:34:53 -08:00
Pranav Kanade
b778b83ac4
refactor: admin settings (#9906)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-02-11 23:38:46 +05:30
balajisoundar
85cc3f3497
feat: Provide option in phone input widget to turn off auto formatting (#10832) 2022-02-11 15:39:38 +05:30
Tolulope Adetula
c992bd5285
feat: add more plugins to rich text editor (#11052) 2022-02-11 13:52:35 +05:30
Aswath K
fb83b0fbc6
feat: Make Button Tab keyboard accessible (#10873) 2022-02-11 00:30:20 +05:30
balajisoundar
e67474a4f3
fix: Input, Phone and Currency input widgets valid property validations (#10966)
- When the user removes an expression from the validation property of
  input widget, its value becomes `""`. And in boolean validation
  function we treat this empty string as false. so Input widget
  ends up with isValid false and we show an error border around the
  Input. so we are setting a default value true, so when there is
  no expression it evaluates to true.
2022-02-10 17:06:18 +05:30
Pawan Kumar
d4eeff8fcc
fix: Header tags are not styled correctly in the Text widget (#10949)
* fix text widget styles

* add font weight in headings

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-02-10 12:25:33 +05:30
balajisoundar
8f383ca8ea
fix: Phone Input and Input widget not getting reset on submit (#10860) 2022-02-09 17:33:10 +05:30
Paul Li
ce42dcb00b
fix: Map pin does not center when location is changed and centering option is turned on (#10296)
* fix: Map pin does not center when location is changed and centering option is turned on

-- Update center meta property when defaultMarkers or mapCenter properties were changed

* fix: Map pin does not center when location is changed and centering option is turned on

-- Force the last marker to be centered
2022-02-09 18:39:07 +08:00
balajisoundar
fab552cafa
chore: Extend the list of widgets that cannot be used inside the List… (#10928) 2022-02-09 12:45:10 +05:30
Vicky Bansal
e4e7c59bc2
fix: disable closing dropdown on space (#10945) 2022-02-09 12:32:57 +05:30
Tolulope Adetula
453974b18e
fix: Multiselection in table widget (#10838)
* fix: Multiselection in table widget

* fix: add test cases
2022-02-08 06:41:25 -08:00
Arsalan
048d8ac349 fix: Rating widget flicker, when value is changed. 2022-02-08 12:52:43 +05:30
Arsalan
903b2cec4d Added grey as the default inactive color. 2022-02-07 17:28:11 +05:30
Tolulope Adetula
94dbd612c3
fix: onOptionChange on TreeSelects and fix Switch Toggle (#10632)
* fix: treeSelect onoptionChange

* fix: revert cypress

* fix:switch widget toggle

* fix: remove Important from styling
2022-02-02 23:57:49 -08:00
Tolulope Adetula
bb2f7da823
feat: Select and Multiselect V2 (#10359)
* fix: Select V2

* Fix: CI Fail

* fix: failing test

* fix: failing test

* Fix: MultiSelect

* Fix: loading issue

* Fix: loadin state

* Fix: loading

* fix: failing test

* fix: evaluation tests

* Fix: failing tests

* Fix: failing test

* fix: failing tests

* Fix: Failing tests

* fix: select All

* fix: filtering

* Fix: filtering

* fix: refactor Select widget

* fix: hide MultiSelect

* fix: select options

* Fix: failing tests

* fix: failing tests

* Fix: issues

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* fix: PR reviews

* Update EntityDefinitions.ts

* Fix: issues

* fix: console

* fix: QA issues

* fix: options issues

* fix: add widget icons

* fix: update Selectv2

* empty commit to fix CI

* fix: failing test
2022-02-02 06:15:07 -08:00
Bhavin K
4e28b4887c
Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770)" (#10786)
This reverts commit df1ee35992.
2022-02-01 15:43:20 +05:30
Tolulope Adetula
8729c2b435
fix: select treeselect value validation (#10760)
* fix: Select adn treeSelect validation

* fix: remove cy.wait()
2022-02-01 10:54:16 +01:00
Bhavin K
df1ee35992
fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770) 2022-02-01 13:37:52 +05:30
Vicky Bansal
8e174f7316
chore: Fix recaptcha script not loading issue (#10764) 2022-01-31 21:25:58 +05:30
Rishabh Rathod
b61ceab94b
fix: Add meta to eval cycle and update it when default changes (#10401)
* Rearrange data tree widget factory

* Remove existing handling of default value override

* Altternate way of meta property override

* Fix tests

Co-authored-by: hetunandu <hetu@appsmith.com>
2022-01-28 16:40:05 +05:30
Bhavin K
45d3704dda
fix: icon button remove default green (#10573) 2022-01-27 19:07:13 +05:30
Yash Vibhandik
35d46b42d4
fix: #10428 styling support in popup (#10487) 2022-01-27 15:37:05 +05:30
Favour Ohanekwu
db3e29e15d
fix: Fix crash on broken list widget (#10670) 2022-01-27 15:31:24 +05:30
Rishabh Rathod
d3c2833c8c
chore: remove defaultSelectedFiles (#10586)
- It is not being used anywhere
2022-01-27 09:40:51 +00:00
Tolulope Adetula
b89c3100e4
fix: RTE required field (#10629) 2022-01-27 00:37:50 -08:00
Bhavin K
dfaddfbce4
fix: Datepicker closeOnSelection will now remain true by default for new widget drops(#10479) 2022-01-27 11:42:39 +05:30
Keyur Paralkar
5afff85e8d
fix: changed validation to FUNCTION for the default selected value RadioGroupWidget (#10020)
* fix: changed validation to FUNCTION for the default selected value RadioGroupWidget

* refactor: changed evalued struct msg for radio group default value

* test: added cypress test for checking radiogroup widget with integer value

* test: added jest test to validate the defaultValidation function for radio widget

* refactor: changed the test case title

* chore: updated yarn.lock file

* refactor: addressed the review comments

* refactor: added comment for defaultOptionValidation

* refactor: changed the expected example [QA comment]

* fix: added validationOperationType prop

* Revert "fix: added validationOperationType prop"

This reverts commit 896226fe940621c2c71aa8a9e87831039a9655de.

* fix: added custom validation for the options property

* fix: modififed the custom validation logic

* refactor: modified the cypress test

* refactor: addressed review comments

* refactor: addressed review comments

* refactor: addressed review comments; Updated custom validation for DSV; Update cypress

* refactor: added boolean check for the default selected value

* refactor: addressed review comments

* test: fixed jest test case
2022-01-26 12:48:13 +05:30
Ashok Kumar M
2a8e37bf3b
feat: Sliding Canvas for Dragging and Selection (#9983)
* Move existing canvas's to CanvasArenas folder

* moving hooks to canvas arenas folder.

* Sticky canvas implementation.

* fixing specs(WIP)

* dip

* fixing test cases.

* removing comments.

* fixing build

* renaming for readability.

* adding folder for canvas based sagas.

* Resolve conflicts.

* fixing failed cases.

* fixing cypress cases.

* fixing bugs introduced coz of drag and drop.

* fixing bugs.

* few more bug fixes in draw to select.

* mouse pointer default when drag to select.

* bug fix.

* dip

* integrating intersection api.

* dip need to adjust offset

* fixing offset issues.

* readability fix

* rebase bug fixes.

* bug fix.

* adjust canvas slider on mouse over.

* unwanted changes.

* left offset fix + removing dead code.

* fixing bugs.

* fixing broken test cases.

* addressing code review comments.
2022-01-25 20:58:31 +05:30
Bhavin K
b52ec44966
fix: changed cap default to fix ux issue on js toggle (#10424)
* fix: changed cap default to fix ux issue on js toggle

* fix: hard check on capSide hide

* fix: always show capSide if dynamic capType

* docs: label, help text update

* fix: remove hidden condition
2022-01-25 13:54:36 +00:00
Ashok Kumar M
6bc1bdd5e1
fix: Fixing GRID_DENSITY_MIGRATION_V1 based configs and adding test cases. (#10488) 2022-01-21 15:49:10 +05:30
Bhavin K
9976cb5018
fix: handle no color as transperant (#10498) 2022-01-21 15:31:30 +05:30
Favour Ohanekwu
f7ce277e4c
fix: currentItem showing error in debugger for list widgets (#10338) 2022-01-20 11:59:03 +01:00
Bhavin K
832622a221
fix/datepicker derived property condition updates (#10353)
- fixed mix / max date validation error on datepicker
2022-01-19 16:29:08 +05:30
Tolulope Adetula
70cff3c373
fix: Copy and paste (#10422)
* fix: Copy and paste

* fix: test cases

* fix: onPaste action

* Update index.tsx
2022-01-18 19:54:34 +01:00
Arsalan Yaldram
de3298ae9c
feat: Added Circular progress Widget (#10244)
* Added Circular Porgress Widget

* Updated the svg icon for the widget.

* Added strokeLineCap prop to the widget.

* Added Rounding for percent values.

* Review Changes completed. Removed un-necessary props, added Default Values.

* App crashes when a modal has a filepicker? (#10376)

(cherry picked from commit f646eeafc1)

* Revert "chore: Don't take client subscription into account for fork application (#10220)" (#10375)

This reverts commit 814a7d57f9.

* Added widget entries in TernServer files.

* Added Radial Separators.

* Removed Steps Functionality.

* Added isJSConvertible to progress property.

* Resovled eslint error under EntityDefinition.ts

Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
2022-01-18 14:36:14 +00:00
balajisoundar
02785b90b2
feat: Input, Phone no., Currency input widget (#10259)
* feat: Input, Phone no., Currency Widget

* cypress tests, jest test, QA and CR callouts

* fix tests

* Cypress and jest test fixes
2022-01-18 13:22:24 +05:30
Keyur Paralkar
d88022939e
fix: added loading state for chart widget (#10262)
* fix: added loading state for chart widget

* test: added cypress tests

* refactor: moved the loading logic from widget to component
2022-01-18 13:21:28 +05:30