Commit Graph

16958 Commits

Author SHA1 Message Date
Nidhi
658ea94ae6
chore: Split changes for overridden package import (#31712) 2024-03-13 10:34:44 +05:30
Manish Kumar
f65d9d0ead
fix: added error handling for updateLayout failure while importing (#31694) 2024-03-12 20:41:38 +00:00
Nirmal Sarswat
2dd730bcc3
fix: Handle error in trigger requests Appsmith AI (#31549)
## Description
Handling unexpected errors in trigger requests in Appsmith AI plugin

#### PR fixes following issue(s)
Fixes #

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

#### How Has This Been Tested?
- [x] Manual

## Automation

/ok-to-test tags="@tag.Datasource"


## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Bug Fixes**
- Improved error handling for file uploading and listing to enhance
stability and user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai
--><!-- This is an auto-generated comment: Cypress test results -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8245477758>
> Commit: `8a36d1b0216f86c18ebee541fbad2fec9e66dfb9`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8245477758&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->
2024-03-13 00:53:53 +05:30
Nidhi
2670128bce
chore: Split changes for mi dr values (#31677)
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2024-03-12 23:21:44 +05:30
Gurudatt S A
efce75ceb6
fix: Added index.d.ts file to enable auto code completion for custom commands in Cypress tests (#31696)
Co-authored-by: Gurudatt SA <>
2024-03-12 19:18:36 +05:30
Shrikant Sharat Kandula
1eb7f0e171
chore: Remove "Save theme" functionality (#31481)
This is deleting a defunct feature.

[Slack
thread](https://theappsmith.slack.com/archives/CGBPVEJ5C/p1709621165627549).
2024-03-12 18:54:39 +05:30
Hetu Nandu
de834b7142
chore: Side by Side analytics (#31690)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tags.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced analytics with the introduction of the "EDITOR_MODE_CHANGE"
event to track changes in the editor's view mode.
- Improved user experience in the IDE with the ability to track
full-screen and split-screen mode changes through analytics.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-12 13:13:00 +00:00
Ankita Kinger
99639d446e
fix: Homepage error message with no workspaces & Github changes message (#31691)
## Description

- Fixing error message on homepage when there are no workspaces
- Fixing leave workspace leading to no workspaces message
- Fixing github changes list message on the git modal with modules &
module instances
- Adding doc link for packages

Fixes [#30748](https://github.com/appsmithorg/appsmith/issues/30748)
[#31472](https://github.com/appsmithorg/appsmith/issues/31472)
[#30214](https://github.com/appsmithorg/appsmith/issues/30214)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8247923955>
> Commit: `6cd2ef6f4cfb2f12f251d6a4ad26e48fe88e78f8`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8247923955&attempt=2"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added new categories (`PACKAGES`, `MODULES`, `MODULE_INSTANCES`) to
track changes in Git Sync more effectively.
- Introduced a new constant for accessing the packages overview
documentation.

- **Enhancements**
- Improved icon determination logic for queries based on their
configuration.
- Enhanced user experience by redirecting to "/applications" after
leaving a workspace.

- **Refactor**
	- Optimized the `leaveWS` function for better performance.
- Updated selectors and reducers to handle new Git Sync tracking
categories.

- **Tests**
- Expanded test coverage to include tracking of modified packages,
modules, and module instances.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-12 18:14:05 +05:30
ashit-rath
3a8064ad5f
chore: reconnect modal refactor for package import (#31674) 2024-03-12 17:24:19 +05:30
Shrikant Sharat Kandula
0af7c7ecbb
chore: Remove non-static or API in Bridge (#31678)
Removing the `BridgeQuery.or` API since

1. it reads confusing. Are the passed-in items applied with an `or`, or
the current queries applied with the parameters with an `or`. Unlike
`and` method, this difference with `or` can change the meaning of the
query drastically.
2. it doesn't translate very well into Postgres world. Multiple hoops to
manage the same API, just not worth it.

The static `Bridge.or` looks, reads, and works much better. That's the
suggested alternative for this.
2024-03-12 15:53:49 +05:30
sneha122
c5ed198383
chore: execute action event updated with source (#31662) 2024-03-12 15:36:33 +05:30
Nilesh Sarupriya
127e96c3f1
chore: code split refactor of generateActionCollectionViewDTO and setAutoGeneratedHeaders (#31620)
## Description
> code split methods to support native triggering of workflows.

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the action collection view with additional parameters for
better access control and view mode handling.
- Improved action execution process by enabling the setting of
auto-generated headers dynamically, enhancing the flexibility and
customization of action executions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2024-03-12 15:35:28 +05:30
albinAppsmith
29cc9d39d5
feat: Added split pane beta announcement modal (#31676)
## Description

This PR adds the beta announcement modal for the new split pane.

Fixes #31657  

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8244295273>
> Commit: `8f20379a3f045328c0c7fa0ddce9b28d34a86348`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8244295273&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a beta version feature allowing users to work with code and
UI side-by-side, enhancing productivity and user experience.
- Added an announcement modal to inform users about the new split-screen
functionality, with options to try it immediately or learn more.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-12 15:13:52 +05:30
Hetu Nandu
90760da7ca
feat: New IDE Top Navbar (#31594)
## Description
Replaces the current App IDE Navbar with the new one.

Fixes #31603

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8244382997>
> Commit: `5dba98f326ce504de0bf32b56c195d615279bf69`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8244382997&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->

















<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Refactor**
- Centralized page management actions in Cypress tests using the new
`PageList` module.
- **Tests**
- Enhanced Cypress test reliability and readability by consistently
using `PageList` methods for page management.
- **Chores**
- Optimized test support infrastructure by removing outdated commands
and imports in Cypress support files.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-12 14:02:58 +05:30
Ayush Pahwa
d2c64344f9
chore: workflow ds icon update and beta card updates (#31681)
## Description
- Bumped version for for ds packages
- Added `isBeta` flag to action operations to add BetaCard for EE repo

Fixes #31357 

## Automation

/ok-to-test tags="@tag.Sanity @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8245228575>
> Commit: `8cdee76bccace3a148077e983793475b75751592`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8245228575&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the query list to include descriptions for beta features,
improving user guidance and understanding of new functionalities.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-12 14:00:42 +05:30
Nikhil Nandagopal
fd79d76618 Updated Label Config 2024-03-12 13:48:52 +05:30
Shrikant Sharat Kandula
350d89b98e
chore: Migrate NewAction repo to Bridge APIs (#31632) 2024-03-12 11:24:15 +05:30
Nidhi
c5c3dc4caf
ci: Modified older ok-to-test job to redirect to the new one (#31673) 2024-03-12 10:01:44 +05:30
Shrikant Sharat Kandula
86f0ebe9fe
chore: Remove unnecessary call to get default tenant ID (#31521) 2024-03-12 06:36:16 +05:30
Nikhil Nandagopal
c77e26967a Updated Label Config 2024-03-11 22:11:42 +05:30
Abhinav Jha
55487f5865
fix: Deselect all widgets on canvas click (#31653)
## Description
Clicking on the canvas in Anvil layouts did not deselect all widgets.
This PR fixes it. Now all widgets

## Approach
In the `AnvilMainCanvas` we check if the origin of the click event is
the Main Canvas. If it is, we allow the function to deselect all widgets
to run.

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Refactor**
- Improved the logic for clearing widget selections to enhance user
experience when interacting with the main canvas.
- **Tests**
- Added a test case to ensure clicking on the canvas deselects all
widgets and verifies the border color of widgets within the main canvas.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-11 20:45:47 +05:30
srix
eba9cad9f6
Revert "chore: code split to support other contexts" (#31666)
Reverts appsmithorg/appsmith#31623

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated method signatures and parameters related to OAuth2
authentication to simplify and enhance the redirect URL population
process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-11 19:33:20 +05:30
Nikhil Nandagopal
54696c0ae8 Updated Label Config 2024-03-11 19:31:54 +05:30
Nikhil Nandagopal
855d9c8377 Updated Label Config 2024-03-11 19:31:35 +05:30
Nikhil Nandagopal
aa53262dee Updated Label Config 2024-03-11 19:30:31 +05:30
Nilesh Sarupriya
b08d100185
chore: code split to support other contexts (#31623)
## Description
> Datasource Controller's getTokenRequestUrl() is currently bounded to
Pages.
> This is a code split to support generation of token request url for
other contexts like modules and workflows.

#### PR fixes following issue(s)
Fixes [[Bug]: Authenticated API & Authenticated graphQL API with OAuth2
throws 404 error in
workflows](https://github.com/appsmithorg/appsmith/issues/31554)

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [x] JUnit
Existing test cases should pass.
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated OAuth2 authorization process to use context-specific
parameters for enhanced flexibility and security.
- **Refactor**
- Modified `getTokenRequestUrl` and
`getAuthorizationCodeURLForGenericOAuth2` methods to accept
`contextType` and `contextId`, improving the OAuth2 flow.
- Adjusted logging and method parameters across various classes for
consistency with new OAuth2 process.
- **Tests**
- Updated test cases to reflect changes in method parameter orders and
OAuth2 authorization enhancements.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2024-03-11 19:29:04 +05:30
Abhinav Jha
d0acbe72b4
fix: Zones and Sections elevation token update (#31655)
## Description
This PR makes the following changes:
- Adds elevation token for `border-color` zones and sections, based on
their elevations
- Updates the `Background` property pane description for zones and
sections to make them relevant to what they mean semantically for the
user
- Adds a padding to the containers within zones and sections, when they
have their backgrounds visible.
- The above padding is not applied when backgrounds are not visible, as
described in the hypothesis for asymmetric padding.

### Before:
![Screenshot 2024-03-11 at 2 55
47 PM](https://github.com/appsmithorg/appsmith/assets/103687/b656914f-39d7-4486-b63f-4f58e9de199d)

### After:
![Screenshot 2024-03-11 at 2 54
02 PM](https://github.com/appsmithorg/appsmith/assets/103687/dcc7bc45-68b8-44e3-9e51-caa1c49da63d)

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Updated `ContainerComponent` to support conditional styling for
enhanced visual separation based on `elevatedBackground` property.
- **Refactor**
- Renamed configuration sections from "Background" to "General" and
updated labels and help texts to better describe the purpose of the
`elevatedBackground` property in both Section and Zone widgets.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-11 19:05:52 +05:30
Anagh Hegde
c4e73c475a
chore: Add compound index to user class (#31649) 2024-03-11 18:47:05 +05:30
gzlinzihong
85269c432c
fix: file picker widgets removing files causing abnormal content (#31646)
## Description
> fix filepicker widgets selects multiple files and then removes one of
them, causing the final content of all file.data to be abnormal
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> [31411](https://github.com/appsmithorg/appsmith/issues/31411)
#### Type of change
- Bug fix 
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
- Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- My code follows the style guidelines of this project
- I have performed a self-review of my own code
- I have commented my code, particularly in hard-to-understand areas
- My changes generate no new warnings
- New and existing unit tests pass locally with my changes


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the File Picker widget to support more interactive
functionalities like setting maximum file limits and custom data
formats.
- **Tests**
- Added tests for new functionalities in the File Picker widget,
including file uploading, setting restrictions, and file removal
verification.
- **Bug Fixes**
- Fixed an issue with file data retrieval in the File Picker widget to
ensure accurate data is presented after files are removed.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: linzihong <linzihong@corp.netease.com>
2024-03-11 18:13:12 +05:30
balajisoundar
2c7b3684d6
chore: [map chart widget] update the label counts and snapshot in spec (#31648)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Maps"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8231075012>
> Commit: `07f432e3206c6b370265078607b285e94eb0aacd`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8231075012&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->












<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated MapChart widget test cases, including selector changes and
modified assertions.
- **New Features**
- Enhanced the MapChart Widget to render charts using SVG for improved
performance and quality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-11 16:34:34 +05:30
sneha122
394093f6d5
fix: removed unnecessary checks for create action api in spec file (#31656)
## Description
Fixed `GlobalSeach_spec.ts` test case, it had unnecessary check for
create action API, removed that.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Tests**
- Updated the `navigatesToApi` test case in the Global Search feature to
refine validation criteria.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-03-11 16:32:34 +05:30
Nikhil Nandagopal
ab06d40e92 Updated Label Config 2024-03-11 15:24:53 +05:30
Vinay Chilukuri
f376eb0d45
fix: Removed box-shadow for the active tab that is causing a visual artefact. (#31608)
Removed box-shadow for the active tab that is causing a visual artefact.
<img width="328" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/101088862/6e7ed92a-fb74-4994-969d-d92188f0ffc6">
2024-03-11 12:40:43 +05:30
Vinay Chilukuri
a8e1a8f6a6
fix: Background color change for the tab bar (#31607)
Changed the background color of the tab bar to #FFF to minimise
background colors in the tab bar area.
2024-03-11 12:40:04 +05:30
Shrikant Sharat Kandula
9afcf84d0d
chore: Fix double-brace-initialization (#31643)
This PR fixes all uses of double brace initialization, with ordinary
normal code.

It is usually advised to avoid Double brace initialization, especially
for building collections as it can cause very hard-to-troubleshoot bugs
with systems that use reflection a lot, like Spring, Hibernate, Jackson,
etc.

Almost every Java linter out there recommends to avoid this.

This can be configured in IntelliJ to show up as an error with the
following configuration. Please **please** do this.

![shot-2024-03-11-04-14-16](https://github.com/appsmithorg/appsmith/assets/120119/cc3d8c67-5dfc-4884-a36a-8f9e1aeea19f)
2024-03-11 11:54:25 +05:30
Nikhil Nandagopal
5801b21030 Updated Label Config 2024-03-11 11:37:10 +05:30
sneha122
1da73775b8
chore: create action source instrumentation added (#31585)
## Description

Added server side create action instrumentation for following cases:
Action | Source | Frontend/Backend | Tests Added?
-- | -- | -- | --
Create Action / query from any other place in app (entity explorer /
datasource preview / ombinar) | self | source sent from frontend |
Cypress
Drag a table widget → Click connect data → Select datasource → select
table → click on connect data | one-click-binding | source sent from
frontend | Cypress
Generate CRUD triggered from new page menu or datasource preview |
generate-crud-page | source set in backend | No
When page is cloned | clone-page | source set in backend | No
When application is forked | fork-application | source set in backend |
No

#### PR fixes following issue(s)
Fixes #31173 
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced event tracking capabilities by introducing an enumeration to
track the source of action creation for analytics.

- **Enhancements**
- Improved action creation flow by specifying the source in various
components, aiding in precise analytics and debugging.
- Streamlined analytics properties method across services for
consistency and simplicity.

- **Bug Fixes**
- Adjusted assertion logic in Cypress tests to validate the source of
action creation accurately, ensuring reliability in automated testing.

- **Refactor**
- Simplified method signatures and logic in server-side analytics
handling for better maintainability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-03-11 10:22:24 +05:30
Hetu Nandu
98edccb970
chore: Add back Preview Mode shortcut (#31602)
Adds back the preview mode shortcut now with a modifier key to be `⌥ +
P` on mac or `Alt + P` on windows

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the Preview Mode with additional hotkeys (`alt + p`) for
toggling, improving user experience in navigating the editor.
- Improved tooltip messages for better clarity on shortcuts available to
the user.

- **Tests**
- Updated regression tests to cover new Preview Mode functionality and
ensure its reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-11 10:02:19 +05:30
Abhijeet
0c2f1a27e0
feat: Add functionality to enforce strong password for form signups (#31605)
**PR to selectively enable strong password requirements.**

Fixes: https://github.com/appsmithorg/appsmith/issues/31525
2024-03-11 09:39:01 +05:30
Shrikant Sharat Kandula
20bc0844ac
chore: Don't print hashed password in logs (#31624) 2024-03-11 09:38:00 +05:30
Nidhi
3756e94d91
ci: Prettify and remove redundancies (#31638) 2024-03-09 17:48:13 +05:30
Nidhi
86f5e8617e
ci: Prettify and remove redundancies (#31637) 2024-03-09 13:46:56 +05:30
Nidhi
01954c15d6
ci: Prettify and remove redundancies (#31635) 2024-03-09 13:24:38 +05:30
Nidhi
96655ec988
ci: Prettify and remove redundancies (#31634) 2024-03-09 12:56:02 +05:30
Nidhi
fee21b5fd5
ci: Simplified PR template to align with ok-to-test (#31633) 2024-03-09 11:14:56 +05:30
Nidhi
3b10f233cd
ci: Make Cypress results show up in body as well (#31631) 2024-03-09 09:55:50 +05:30
Nidhi
cd8cefd965
ci: Inherit secrets in workflow call to integrations tests (#31630) 2024-03-09 09:08:47 +05:30
Nidhi
73a7e3e8e7
ci: Make sure target is release branch for new flow (#31628) 2024-03-09 02:37:45 +05:30
Nidhi
d948bb6e1f
ci: Added an alternate ok-to-test path (#31626) 2024-03-09 02:30:19 +05:30
Jacques Ikot
78f269bcc8
feat: drag and drop building block on canvas with skeleton loader (#31406)
## Description
**Goal**
To allow users drag and drop building blocks on the canvas just like
widgets today. We are also implementing a loading state with the
platform skeleton component immediately the user drops the block on the
canvas.

**Why**
The dropping of building blocks needs to make an API call to the backend
to process adding the building block functionality to the users app.
This loading skeleton acts as a placeholder for the block while the API
call is processing.

**How**
1. We had listed the building blocks in a previous
[PR](https://github.com/appsmithorg/appsmith/pull/31199)
2. Created a new saga to handle widget and building block addition
called `addUIEntitySaga`
3. The saga handles widget addition like it did previously, but also
handles building block addition to canvas.

#### PR fixes following issue(s)
Fixes #31314 

#### Media

#### Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced drag-and-drop functionality for building blocks within the
canvas editor.
- Added a new feature flag to enable/disable drag-and-drop building
blocks.
- Implemented new UI components such as `SeeMoreButton`, `UIEntityList`,
and `UIEntitySidebar` for enhanced widget management and exploration.
- Enhanced widget sidebar with improved search and filter capabilities.

- **Enhancements**
- Updated various components and sagas to support the new drag-and-drop
functionality and building blocks management.
- Improved loading and organization of UI explorer items, including
widgets and building blocks.

- **Refactor**
- Adjusted import paths and reorganized imports across multiple files
for better code maintenance.
- Consolidated widget addition logic under a unified saga for handling
different UI entity types.

- **Bug Fixes**
- Fixed the directory structure for the `useIsEditorPaneSegmentsEnabled`
hook to reflect recent changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-08 19:59:29 +05:30