Commit Graph

16958 Commits

Author SHA1 Message Date
Nidhi
ef9390a573
Merge pull request #25680 from appsmithorg/release_v1.9.30 2023-07-31 22:53:08 +05:30
Valera Melnikov
e5209aa7cd
fix: bump storybook version and move stories to storybook package (#25821)
## Description
- bump storybook version
- move stories to storybook package
- add dimensions for testing viewports
- improve some stories and types for argTable

#### PR fixes following issue(s)
Fixes #25534

#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-31 19:15:50 +03:00
Goutham Pratapa
3f8db42522
fix: failing-vercel-dps (#25851)
Fixes:
https://github.com/appsmithorg/appsmith/actions/runs/5713787930/job/15479827656#step:9:30

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-31 20:51:35 +05:30
Aishwarya-U-R
4146a2a193
test: Cypress | Unskip Airtable spec (#25860)
## Description
- This PR unskips the Airtable spec (after hook)
2023-07-31 20:07:55 +05:30
Manish Kumar
8a36b95402 fix: fixed typo analytics constant (#25858) 2023-07-31 19:58:50 +05:30
Aishwarya-U-R
19cb14a968
test: Cypress | Unskip Airtable spec (#25859)
## Description
- This PR unskips Airtable spec - which is flaky in CI
- 
#### Type of change
- Script fix (non-breaking change which fixes an issue)
- ## Testing
>
#### How Has This Been Tested?
- [X] Cypress local runs
2023-07-31 19:57:13 +05:30
tkAppsmith
84affb0433 test: Cypress - Flaky Fix (#25795)
**Fixed below flaky tests**
- Button_onClickAction_spec.js
- TemplatesPage_filtering_spec.ts

- Flaky test fix

- Cypress test runs

- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-31 19:56:53 +05:30
Manish Kumar
63c1dc0ff8
fix: fixed typo analytics constant (#25858) 2023-07-31 19:51:40 +05:30
NandanAnantharamu
4a1b1d0c99 test: cypress -udpated common method to handle CE/EE scenario (#25693)
updated common method to handle CE/ EE scenario for ShareApp
2023-07-31 19:43:51 +05:30
Vijetha-Kaja
615bd5f349
test: Cypress - Flaky Fix (#25795)
## Description

**Fixed below flaky tests**
- Button_onClickAction_spec.js
- TemplatesPage_filtering_spec.ts
 
## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-31 19:42:42 +05:30
Aishwarya-U-R
eb1fb72c31 test: Cypress | Fix Datasources/MockDBs_Spec.ts (#25816)
## Description
- This PR fixes - Datasources/MockDBs_Spec.ts
- It improves the CheckResponseRecordsCount() to validate if record
count matches the min value sent for validation

#### Type of change
- Script fix (non-breaking change which fixes an issue)

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-31 19:40:27 +05:30
Aishwarya-U-R
49e0bbfc85 test: Cypress | Fix Datasources/MockDBs_Spec.ts (#25796)
## Description
- Movies is now returning 2 records for default query as opposed to 1,
hence this PR to fix it in CI runs

#### Type of change
- Script fix (non-breaking change which fixes an issue)
- 
## Testing
>
#### How Has This Been Tested?

- [X] Cypress locally
2023-07-31 19:40:14 +05:30
Saroj
e88eb26bdd
ci: Fix for comments in case ci-test failure due to other steps (#25850)
## Description
- Fix for comments in case ci-test failure due to other steps
- Fixed the ci-test-result issue in ci-test-limited
#### Type of change
- Workflow file
## Testing
- Workflow run
2023-07-31 17:56:55 +05:30
Aishwarya-U-R
e6ee5e7348
test: Cypress | Automated cases for MongoURI CRUD (#25837)
## Description
- This PR is adding new scripts for Mongo URI CRUD validations
- Add/Update/Delete from CRud page
- Search table
- FIlter table
- Download results
- Suggested widget from a mongo uri query
- Apps/CommunityIssues_Spec.ts - 5th fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress
- 
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-31 16:57:07 +05:30
Shrikant Sharat Kandula
fa36098f5e
chore: Graceful handling for empty CS URL (#25843)
This will allow us to

1. Bake different CS URLs for release and master builds.
2. Be resilient to the CS URL being set to empty string, as opposed to
not being set at all.
2023-07-31 16:55:46 +05:30
Favour Ohanekwu
53f5e276b0
chore: Add console statements log to JS_RUN event (#25801)
## Description
This PR adds `consoleStatements` field to JS_OBJECT_FUNCTION_RUN
analytics event


Fixes #25532 

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
Nil
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-31 15:22:23 +05:30
Vishnu Gp
2b4d7a7af4
chore: Integrated features API to Appsmith and added tenant features to user feature flags API response (#25761)
## Description
Added features API to the instance for enabling and disabling features.
Also added tenant features to user feature flags API response


#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith-ee/issues/1887
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-31 15:04:01 +05:30
Goutham Pratapa
6faaf791d2
fix: redis-url when deploying appsmith via helm (#25689)
Fixes: [25688](https://github.com/appsmithorg/appsmith/issues/25688)
2023-07-31 14:55:57 +05:30
Shrikant Sharat Kandula
b3b9b57d4a
chore: Revert Dockerfile arg change that's breaking release 2023-07-31 14:44:03 +05:30
Druthi Polisetty
f4da1abe9d
fix: UI fixes for the Signposting component (#25659)
## Description
fix: UI fixes for the Signposting component

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-31 13:40:37 +05:30
Sumesh Pradhan
18b26a4ec5
ci: Ad-hoc DP | Build Push Deploy from branch (#25357)
Workflow and script to build from branch and deploy to uat-cluster.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-31 13:27:47 +05:30
Shrikant Sharat Kandula
af37843df3
fix: Fix missing cloud services URL when env variable is empty (#25838)
When `APPSMITH_CLOUD_SERVICES_BASE_URL` is an empty string, Spring's
interpolation in `application.properties` doesn't take the default
value. This PR sets up the `entrypoint.sh` script so that it'll `unset`
this env variable, when it's empty.
2023-07-31 13:21:57 +05:30
tkAppsmith
d93dc83515 chore: Corrected maintenance alert message for cloud users (#25833) 2023-07-31 12:22:39 +05:30
tkAppsmith
c07e974bd9 feat: Make MongoDB alert dependent on running version (#25611) 2023-07-31 12:22:25 +05:30
tkAppsmith
f190c0421c
chore: Corrected maintenance alert message for cloud users (#25833) 2023-07-31 11:42:27 +05:30
Rishabh Rathod
d6acecb3ab fix: Remove validation error on revalidation (#25734)
## Description

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/25706

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?

- [x] Manual
- [ ] Jest
- [ ] Cypress

#### Test Plan

#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-31 11:05:41 +05:30
Shrikant Sharat Kandula
0d69fb5472
ci: Use cache from release image to build faster (#25829)
This should enable using unchanged layers from the `release` image, as a
cache, and build PR images faster. We only do this for images built for
PRs and not for direct `release` or `master` branches.
2023-07-31 10:30:46 +05:30
Shrikant Sharat Kandula
a347b0801a
fix: Fix Redis connections that require authentication (#25828)
This fixes a problem with connecting to Redis that require
authentication.
This is a regression introduced in #24924.

Fixes #25259
2023-07-31 10:26:27 +05:30
Shrikant Sharat Kandula
5a9abe0075
ci: Add a note about Vercel DPs with env=release (#25211)
Non-impacting change, only adds some more content to the DP URL comment.

More context around this at
https://notion.so/031b87bce3404e3a95240d4c14c82e46.
2023-07-31 10:19:20 +05:30
Shrikant Sharat Kandula
50a18c325f
fix: Extend Forwarded header, if present (#25827)
This is to fix OAuth redirect URI not being computed correctly, when
deployed to CloudRun.

More details at
http://sharats.me/drafts/story-of-a-forwarded-header.html.
2023-07-31 10:18:32 +05:30
Shrikant Sharat Kandula
71268ca31b
chore: Prevent null tenantConfiguration, needed for EE (#25678)
This change is [already made in
EE](9b9a39e488/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/TenantServiceCEImpl.java (L123)).
This PR is about paying the back-sync debt.
2023-07-31 10:18:04 +05:30
Shrikant Sharat Kandula
9986dbd235
chore: Add APPSMITH_CLOUD_SERVICES_BASE_URL as build arg (#25721)
This will allow us to set a separate cloud-services URL during build
time.
2023-07-31 10:17:46 +05:30
Nidhi
3e6b6810cc
chore: Renamed migrations to allow consistency and interleaving (#25826) 2023-07-30 07:25:49 +05:30
Appsmith Bot
ea97e01cc1 Update top contributors 2023-07-29 06:57:19 +05:30
Parthvi
cef487583d
test: add common methods for ME (#25763) 2023-07-29 06:12:08 +05:30
Ankita Kinger
00ef2b9e09
chore: Adding integration tests for provisioning upgrade page (#25818)
## Description

Adding integration tests for provisioning upgrade page

#### PR fixes following issue(s)
Fixes [#25269](https://github.com/appsmithorg/appsmith/issues/25269)

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-28 21:20:43 +05:30
Rajat Agrawal
8525fb0da5
feat/Replace fusion charts with Echarts (#24249)
Fixes #24423
Fixes #24426
Fixes #25129
Fixes #25710
2023-07-28 18:59:16 +05:30
Nilesh Sarupriya
2a817a1998
refactor: move createNewUser to a helper class (#25790)
## Description
> This is a refactoring change. this change will be used in the
appsmith-ee code repo to add custom permissions to the user policies.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/25728
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2023-07-28 16:46:41 +05:30
tkAppsmith
8ed502bf1a
feat: Make MongoDB alert dependent on running version (#25611) 2023-07-28 16:02:42 +05:30
Rishabh Rathod
9513dd172f
fix: Remove validation error on revalidation (#25734)
## Description

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/25706

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?

- [x] Manual
- [ ] Jest
- [ ] Cypress

#### Test Plan

#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-28 16:01:56 +05:30
Aishwarya-U-R
06c2bc3eb4
test: Cypress | Fix Datasources/MockDBs_Spec.ts (#25816)
## Description
- This PR fixes - Datasources/MockDBs_Spec.ts
- It improves the CheckResponseRecordsCount() to validate if record
count matches the min value sent for validation

#### Type of change
- Script fix (non-breaking change which fixes an issue)

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-28 14:48:40 +05:30
Ankita Kinger
8bfc95c75d
chore: Removing feature flag for SCIM (#25742)
## Description

Removing the feature flag for SCIM

#### PR fixes following issue(s)
Fixes [#25809](https://github.com/appsmithorg/appsmith/issues/25809)

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [x] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-28 13:35:55 +05:30
Nayan
06f9724e71
chore: Export app and fetch remote in parallel when git status (#25272)
## Description
This PR changes the code flow in get status API by running export app
and fetch remote operations in parallel. Goal of this change is to
improve the time taken in get status API.

#### PR fixes following issue(s)
Fixes #24649
2023-07-28 13:33:13 +06:00
Ayush Pahwa
af7b479e51 fix: config checks for generate page CRUD (#25785)
## Description
Generate page crud was checking for the config from DS storage even for
non env enabled datasources. This PR fixes that.

#### PR fixes following issue(s)
Fixes #25640
2023-07-28 10:58:23 +05:30
balajisoundar
5f2e1f06bc chore: remove stale property from select and multi select widget dyna… (#25799)
…micBindingPathList

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/25800


#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-28 10:24:12 +05:30
NandanAnantharamu
91a65d5eeb
test: cypress - updated click actions in tests (#25748)
Updated steps related to click action in **Listv2_onItemClick_spec.js**
2023-07-28 10:16:32 +05:30
balajisoundar
45ca308238
chore: remove stale property from select and multi select widget dyna… (#25799)
…micBindingPathList

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/25800


#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-28 09:46:26 +05:30
Rishabh Rathod
65d6a99fa9
chore: Add widget params to analytics (#25597) 2023-07-28 09:32:00 +05:30
Appsmith Bot
e888a892d0 Update top contributors 2023-07-28 06:57:27 +05:30
balajisoundar
606f2bd3e9
fix: [List widget] cannot read property of undefined while updating m… (#25682)
#### PR fixes following issue(s)
Fixes #25275

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [x] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-27 23:51:34 +05:30