Tolulope Adetula
60b1805d64
Merge branch 'master' into release--22nov
2022-11-22 11:10:40 +00:00
akash-codemonk
f669954873
chore: update omnibar to work with docusaurus site ( #18146 )
...
Fixes #17501
New index will be used once the algolia keys are updated https://github.com/appsmithorg/keys/pull/10
## Description
- Update algolia index name and keys.
- Removed [app/client/gitbook-algolia-lambda.js](https://github.com/appsmithorg/appsmith/pull/18146/files#diff-cd4ea8ae515ff25aaad99dc86059b65cc9b67edcde4eb261e1e456497b6957d3 ). It is being replaced by [website/omnibar-algolia-index.js](https://github.com/appsmithorg/appsmith-docs/pull/564/files#diff-a3f32686fd88fe5556e1dec268d0fa72ddd30a7ca05af48e2d55f1a811acd2c0 ).
- Fixes video and list styles of content shown in the omnibar.
- Videos on docs.appsmith.com are wrapped in a `videoembed` tag so have updated the regex for the same.
- Image urls also sometimes include algolia highlight tags which makes the url invalid have removed the same
https://github.com/appsmithorg/appsmith/pull/18146/files#diff-0e7cdbf77157af62f50ece962a8d4e381b2c070c2453123e8a713298f9640e25R126 .
- Docusaurus https://docusaurus.io/docs/markdown-features/admonitions have a different syntax have updated the regex to parse the same. https://github.com/appsmithorg/appsmith/pull/18146/files#diff-0e7cdbf77157af62f50ece962a8d4e381b2c070c2453123e8a713298f9640e25R154
TLDR
Make omnibar work with the new docs site.
## How Has This Been Tested?
- Manual
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
https://github.com/appsmithorg/appsmith/issues/17501#issuecomment-1307043824
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-11-21 08:25:33 +00:00
Ayangade Adeoluwa
300950b147
fix: Fix response header issues ( #17717 )
...
Fix response header issues
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-11-19 19:29:15 +05:30
balajisoundar
9079d36600
fix: Cyclic deps in Table widget shouldn't crash the app ( #18217 )
2022-11-18 16:24:35 +05:30
Arsalan
dbc580a37f
fix: merge conflicts resolved.
2022-11-17 20:17:22 +05:30
Aswath K
2cb7474e1c
fix: Allow country code change text gets wrapped and makes the UI looks ugly ( #18218 )
...
* fix: Change country code text gets wrapped and makes the UI looks ugly
* fix: Cypress failures
2022-11-17 17:45:06 +05:30
Hetu Nandu
b4adfcf8e2
feat: [Context Switching]: Change focus target and fix cursor position ( #17794 )
...
Co-authored-by:
rahulramesha <rahul@appsmith.com>
2022-11-15 11:50:18 +05:30
Rishabh Kashyap
1e7c97c1f7
feat: show number of tabs on the header ( #18071 )
...
* number of tabs displayed alongside label
* styling for span removed
* feature added and cypress test cases written
* code refactoring after review
2022-11-08 20:50:58 +05:30
balajisoundar
2df27a6fb2
feat: Option to add new row in Table widget ( #17515 )
2022-11-05 15:24:20 +05:30
Dhruvik Neharia
2ec1ccc6a5
feat: Code Scanner Enhancements ( #17929 )
...
* feat: Add Scanner Variant - Click to scan and always on to code scanenr
* feat: Enhancements for code scanner's property pane - update help text, hide properties on always on
* feat: Add Image Mirror button to code scanner
* feat: Update code scanner video fit to contain
* feat: Add DSL migrations for Code Scanner
* feat: Make always on the default scanner layout, rename scannerVarient to scannerLayout
* feat: Stop scanning and detecting codes in background for code scanner widget
* test: Add Cypress tests for different scanner layouts for code scanner
* refactor: fix minor code callouts here and there
* refactor: Restructure cypress test suite
* feat: Increase code scanner delay to avoid unintended detections
* refactor: combine two different conditions into one ternary
* feat: Remove one cy test case
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-11-04 11:45:45 +05:30
Favour Ohanekwu
1379180ecd
feat: Split evaluation and linting ( #17287 )
...
* Evaluations and Linting now runs on separate web-workers for a much faster and responsive coding experience on Appsmith.
* Removed worker-loader webpack plugin.
2022-11-03 14:53:15 +05:30
Anand Srinivasan
1ecfecabc6
Merge branch 'master' into promotion/release-1-8-7
2022-11-03 08:35:02 +05:30
akash-codemonk
01805a27f4
fix: show empty canvas CTA's only on the first page while creating an app ( #17869 )
2022-11-02 14:39:59 +05:30
f0c1s
e4f8e8a755
chore: update upgrade page ( #17988 )
...
* chore: upgrade page for usage
* fix: upgrade page scroll
* chore: scrollable and design upgrade for upgradePage
* fix: module imports
2022-11-01 22:23:27 +05:30
Aishwarya-U-R
d5d2bf92bb
test: Script updates for flaky tests ( #17980 )
...
* JSOnload fix
* mysql fix
2022-11-01 15:31:42 +05:30
GitStart
5c558e1792
feat: Adding the function to clear stored values ( #17568 )
2022-11-01 14:56:13 +05:30
akash-codemonk
958a38bd63
fix: video widget not visible in widget pane when explorer is pinned ( #17318 )
2022-10-29 11:31:25 +05:30
Tolulope Adetula
e5ea3e6324
fix: label position test failure ( #17931 )
...
* fix: label position test failure
* update visual tests for switchgroup
* skipping postgres test
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-28 15:36:15 +05:30
arunvjn
368cafdf78
fix: clone logged object to prevent mutation to it ( #17756 )
2022-10-26 10:07:53 +05:30
Arsalan Yaldram
944ad01686
feat: slider widgets cypress test cases ( #17467 )
...
* feat: cypress test cases for the slider widget.
* fix: review changes completed.
* fix: cypress use data-cy selector.
* fix: remove range calculation from range slider stpSize validation.
* fix: added range validation back for stepSize.
2022-10-21 15:55:41 +05:30
Souma Ghosh
408d116c44
fix: Incorrect page count when number of records in page is different from page size ( #17535 )
2022-10-21 13:14:46 +05:30
f0c1s
daa9886a69
fix: upgrade page for audit logs with correct data ( #17697 )
...
## Description
This PR fixes:
- content that was repeated
- has new images
- removes comments
- brings text to messages file
## Compare
| OLD | NEW |
| - | - |
|  |  |
|  |  |
|  |  |
2022-10-21 10:48:30 +05:30
f0c1s
9db612cf92
fix: upgrade page for audit logs with correct data ( #17697 )
...
## Description
This PR fixes:
- content that was repeated
- has new images
- removes comments
- brings text to messages file
## Compare
| OLD | NEW |
| - | - |
|  |  |
|  |  |
|  |  |
2022-10-21 10:42:59 +05:30
Arsalan Yaldram
3182dd4116
fix: checkbox & switch widget label alignment. ( #17516 )
...
* fix: checkbox label right alignment issue.
* fix: label position and alignment for switch and checkbox widgets.
* fix: test cases for switch and checkbox label alignment.
2022-10-21 09:51:00 +05:30
Aswath K
436205f6e9
fix: Converted Dropdowns to Button group & added missing tooltips ( #17454 )
...
* Makes the IconTabControl to have fullWidth property
* Changes dropdown to Button Group & adds missing tooltips
2022-10-20 19:36:32 +05:30
arunvjn
ddff993722
chore: List widget security fix ( #17666 )
...
* fix: ListWidget triggerPaths
* Replace single quote with JSON.stringify to parse trigger fields to avoid code execution via user input.
Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2022-10-20 17:50:56 +05:30
Anand Srinivasan
d62e1961d8
fix: Add collapse icon for bottom bar ( #16939 )
...
* add containerRef and explandedHeight to enable collapse icon
* change icon
* sizing
* alignment fixes
* consistent height
* remove unwanted padding
* debugger panel height
* remove extra divider line
* open panel on header click
* rename method
* cypress tests init
* jsobject navigate instead of create
* clean up
* remove variable
* undo changes
* final clean up
* logs spec clean up
* debugger locators clean up
* rename locator
* mock db spec fix
* logs spec fix
* clean up records count locator
* Rename dubugger locators and methods
* spec file change
* move methods
* rename debugger helper class
* build fix
* handle selectors
* merge clean up
* fix failing tests
* use single variable to set height
* undo cypress env changes
2022-10-20 17:38:48 +05:30
Aishwarya-U-R
694a7d342e
test: Script updates for flaky tests ( #17603 )
...
* Skipping Bug16702 spec
* Bug 16702 fix
* timeout spec index update
* Bug 16702 spec fix
* Bug16702 fix
* BUg16702 spec fix
* Bug 16702 revert
* fix template spec
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-20 14:35:27 +05:30
Parthvi
1b9373e3b0
test: Add cypress tests for template phase 2 ( #17036 )
...
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-20 14:29:47 +05:30
Rimil Dey
42b913cef8
feat: Add postMessage as a global function ( #14925 )
...
## Description
**Revert Context -**
Reverts appsmithorg/appsmith#14890 (We had to revert the PR as we got some suggestions on improving the feature - now reverting the revert so we can have this feature out with improvements)
**PR Context -**
This pull request exposes window.postMessage() as a global function in the Appsmith platform.
Post message safely enables cross-origin communication between window objects.
Example use-case - Appsmith page embedded within an iframe which communicates with the container website
Diagram for all the different levels of communication -
**More on post message here** - https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage
**References used for this PR:**
1. Geolocation APIs - https://github.com/appsmithorg/appsmith/pull/9295
2. setInterval and clearInterval support - https://github.com/appsmithorg/appsmith/pull/8158
**Fixes** https://github.com/appsmithorg/appsmith/issues/7241
## Type of change
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
Test plan
- **Manual**: Created an app with different buttons holding different types of data and embedded it in a code sandbox within an iframe. Also removed the target origin which throws an error (App link - https://dev.appsmith.com/app/post-msg-app/page1-624c1af4d8e632741017682e , Codesandbox link - https://codesandbox.io/s/compassionate-tdd-6dnzzd?file=/src/index.js )
- Added Jest tests
- https://github.com/appsmithorg/TestSmith/issues/1892
- https://github.com/appsmithorg/TestSmith/issues/2068
- https://github.com/appsmithorg/TestSmith/issues/2069
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-20 12:39:42 +05:30
Aishwarya-U-R
03fbcdd21c
test: Script updates for flaky tests ( #17603 )
...
* Skipping Bug16702 spec
* Bug 16702 fix
* timeout spec index update
* Bug 16702 spec fix
* Bug16702 fix
* BUg16702 spec fix
* Bug 16702 revert
* fix template spec
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-20 11:56:52 +05:30
Parthvi
0ae012a90e
test: Add cypress tests for template phase 2 ( #17036 )
...
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-19 19:43:51 +05:30
Anagh Hegde
f2012b6804
Merge branch 'release-frozen' of https://github.com/appsmithorg/appsmith into release-frozen
2022-10-19 12:11:53 +05:30
Keyur Paralkar
0e73906a19
fix: remove file references on click of cancel button ( #17664 )
2022-10-19 12:11:29 +05:30
sneha122
2139382928
fix: table does not show data issue fixed ( #17459 )
2022-10-19 11:30:04 +05:30
Keyur Paralkar
3a96547815
fix: remove file references on click of cancel button ( #17664 )
2022-10-19 11:09:01 +05:30
f0c1s
cb26edbb66
Merge branch 'master' into release-frozen
2022-10-18 19:08:12 +05:30
arunvjn
28138c18c8
feat: enabled setTimeout/clearTimeout APIs ( #17445 )
2022-10-17 22:40:17 +05:30
Hetu Nandu
3aff53187c
feat: Maintain Focus and Context Phase 1 ( #16317 )
2022-10-17 20:46:38 +05:30
f0c1s
d2ba72306f
feat: upgrade hooks | audit logs ( #17525 )
2022-10-17 18:39:09 +05:30
Keyur Paralkar
fefeb9b0ac
fix: updated logic to retain the files on page change ( #17389 )
...
* fix: updated logic to retain the files on page change
* fix: update test case title
* fix: addressed review comments
* fix: cypress failure related to filepicker spec
Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-10-14 18:19:58 +05:30
Souma Ghosh
99dc583514
feat: Resize Image option in Table Widget v2 ( #17482 )
...
* feat: Resize image option in Table Widget
* Change default image size from 64px to 32px
* Add cypress tests
* Move Image Size property control under Style tab
* Review changes
* Fix failing cypress tests
* fix prettier issue
2022-10-14 17:51:54 +05:30
f0c1s
1b29ff7167
fix: update implementation as per design | git ( #17406 )
...
* fix: update UI as per design
* fix: rename disconnect to revoke
* fix: update DISCONNECT to REVOKE
* breaking word with CSS when text is longer than width
Co-authored-by: Ankit Srivastava <ankit@appsmith.com>
2022-10-14 12:13:17 +05:30
Dhruvik Neharia
c0318b6451
feat: Change Modern/Default Theme Background to #F8FAFC ( #17345 )
...
* feat: Change Modern/Default Theme Background to #F8FAFC
* feat: Update modern/default theme bg in system themes
* fix: Update basic spec theming test with new modern theme background color
* fix visual tests
* fix: Update WidgetsLayout_spec.js snapshots
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2022-10-14 11:10:50 +05:30
Souma Ghosh
8f5668e23f
fix: Ends with operator not working as expected ( #17519 )
...
* fix: Ends with operator not working as expected
- fix issue
- uncomment cypress tests
* Review changes
2022-10-14 11:09:52 +05:30
Pawan Kumar
5ab8e57e0d
fix: Table reskinning ( #17228 )
...
* update rich text editor styles
* fix disalbed text color
* add border
* fix gaps and borders in json form
* fix disabled state
* fix checkbox disabled state color on checkbox + font size of title in json
* fix pagination arrows
* update list + modal
* update tabs widget
* fix border color
* fix pagination styles
* fix font weight
* update colors
* update colors
* fix table hidden header
* add config for variant
* add check header border
* fix hover colors
* fix hover colors
* add fixes for feedbacks from dilip
* move cell borders
* move cell borders
* update label
* add dilip feedback fixes
* remove unused import
* fix font in filter popup
* fix margin and datepicker getting cut off
* table disabled state for header input
* fix icon color
* fix cypress tests
2022-10-14 10:23:31 +05:30
Dhruvik Neharia
7b7ca712fd
feat: Add Text Truncate Button Color to System Themes ( #17299 )
...
* feat: Add text truncate button color to system themes
* updated colour used
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Nandan <nandan@thinkify.io>
2022-10-14 10:07:34 +05:30
Ayangade Adeoluwa
282f1ff5a6
feat: Adds one way switching to Form Controls ( #17194 )
...
* Adds one way switching to Form Controls
* Fix failing jest test
* Retrigger oktotest
* JSOnload1 spec 6th case fix
* Jsonloadspec 1 fix
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-13 21:28:46 +01:00
Parthvi
c4d6845bd5
test: Add cypress tests for leave workspace flow ( #17354 )
...
* Add leave workspace tests
* removing .pause()
* refactor test
2022-10-13 12:14:39 +00:00
Aishwarya-U-R
47a0a48943
test: Script updates for flaky tests to unblock CI ( #17469 )
2022-10-13 16:12:36 +05:30
