Commit Graph

101 Commits

Author SHA1 Message Date
Preet Sidhu
792b46f2da
feat: create interfaces for individual flex properties (#27331)
## Description

Created and exported interfaces for the following flex properties:
1. AlignContent
2. AlignItems
3. AlignSelf
4. JustifyContent
5. JustifySelf
6. FlexDirection
7. FlexWrap

These interfaces will enable better type casting for Flex component
usage in client.


#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-18 15:44:34 +03:00
Valera Melnikov
62bca098f7
fix: provider font family (#27361)
## Description
Fix wds provider font family

#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-15 20:00:10 +03:00
Pawan Kumar
eab29f5cdb
chore: add fg + bd tokens tests for color algo (#27291)
Related #26018

---------

Co-authored-by: System Administrator <root@Pawans-MacBook-Pro.local>
2023-09-15 17:51:17 +03:00
Valera Melnikov
469a78fb1a
fix: multiple fixes for storybook (#27318)
## Description
- remove redundant dependency
- fix tokenTables
- add system default font
- change color for code
2023-09-15 10:51:19 +03:00
Pawan Kumar
3711ad90e6
feat: enable CSS Modules fro WDS (#26162)
Fixes: #26019

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
Co-authored-by: Valera Melnikov <valera@appsmith.com>
2023-09-15 10:17:06 +03:00
Pawan Kumar
978f48af8a
chore: add tests for bgNeutralSubtle + bgNeutralActive + bgPositives + bgNegatives (#27239)
Related #26018 

Added tests for 
- bgNeutralActive color
- bgNeutralSubtle color
- bgNeutralSubtleHover color
- bgNeutralSubtleActive color
- bgPositive color
- bgPositiveHover color
- bgPositiveActive color
- bgPositiveSubtle color
- bgPositiveSubtleHover color
- bgPositiveSubtleActive color
- bgNegative color
- bgNegativeHover color
- bgNegativeActive color
- bgNegativeSubtle color
- bgNegativeSubtleHover color
- bgNegativeSubtleActive color
- bgWarning color
- bgWarningHover color
- bgWarningActive color
- bgWarningSubtle color
- bgWarningSubtleHover color
- bgWarningSubtleActive color
2023-09-13 10:49:50 +03:00
Pawan Kumar
c1b49739e2
chore: add unit tests for bgNeutral and bgNeutralHover (#27208)
Related #26018
2023-09-12 17:59:08 +03:00
Pawan Kumar
59d6316e98
chore: add unit test for bgAssitive + bgAccentSubtleActive + bgAccentSubtleHover (#27021)
Related #26018
2023-09-08 14:47:11 +03:00
Pawan Kumar
4d13f024ab
chore: unit test for bgAccentActive (#26916)
Related #26018
2023-09-04 17:58:25 +03:00
vadim
f484eec2dd
chore: WDS color docs (#26754)
Closes #26085

---------

Co-authored-by: Valera Melnikov <valera@appsmith.com>
2023-09-01 11:31:17 +03:00
vadim
5b34de09e3
chore: WDS fluid tokens config fine-tuning (#26533)
Closes #25686
2023-08-23 12:35:11 +03:00
vadim
081bf03a1c
chore: add favicon to WDS Storybook (#26567)
tl;dr there was no favicon, added one. Slightly different fills for
light and dark mode.

---------

Co-authored-by: Valera Melnikov <valera@appsmith.com>
2023-08-23 12:35:01 +03:00
Pawan Kumar
99e1b44526
chore: Move stories to component level (#26489)
Fixes #26503
2023-08-23 09:13:26 +03:00
Pawan Kumar
1116d1e8cc
chore: add unit tests for color algo - bgAccent and bgAccentHover (#26402)
This PR adds unit tests for bgAccent and bgAccentHover of both DarkMode
and LIghtMode themes.
Related issue - #26018
2023-08-18 11:37:53 +03:00
Valera Melnikov
947a8ce22d
chore: migrate storybook from webpack to vite (#26396)
## Description
1. Migrate storybook from webpack to vite
2. Add a11y storybook plugin

Before 
<img width="900" alt="Снимок экрана 2023-08-16 в 21 33 02"
src="https://github.com/appsmithorg/appsmith/assets/11555074/eed4c242-9c30-4b53-a770-8f4e10d8796b">
![Снимок экрана 2023-08-16 в 20 49
09](https://github.com/appsmithorg/appsmith/assets/11555074/6a836515-8c81-489d-a4f8-f9baff2de2f7)

After
<img width="895" alt="Снимок экрана 2023-08-16 в 21 32 35"
src="https://github.com/appsmithorg/appsmith/assets/11555074/01a9ef14-0aa0-4dcd-9dd2-20d0a4542a0f">
![Снимок экрана 2023-08-16 в 20 38
12](https://github.com/appsmithorg/appsmith/assets/11555074/e55fea08-4505-499e-a056-857f5beb0223)

A11y plugin
<img width="506" alt="Снимок экрана 2023-08-16 в 21 34 11"
src="https://github.com/appsmithorg/appsmith/assets/11555074/b29abe16-5bbe-4787-9dbf-334c29abd172">
2023-08-17 10:32:15 +03:00
Aswath K
d917b42126
chore: Add id & ref to Flex component (#26190)
## Description
Added `id` and `ref` properties to Flex component

---------

Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: Valera Melnikov <valera@appsmith.com>
2023-08-16 16:09:32 +03:00
Pawan Kumar
21ee27462d
chore: unit tests for color algo - bg (#26289)
Fixes #26018
2023-08-16 15:19:23 +03:00
Pawan Kumar
f2636358af
fix: Chromatic build issue (#26368)
Fixes build issue that happened on the promotional PR: release v1.9.33
It happened due to our recent change in the node version. npm started
behaving differently.

~This PR removes post install script in ast and dsl so that there is no
conflict between package names between ast and ast/build.~
2023-08-16 12:49:21 +03:00
vadim
68ae2d546f
fix: WDS colors checks for non-achromatic seeds (dark mode) (#26317)
See also #26168
2023-08-14 11:41:23 +03:00
Valera Melnikov
54e666be16
fix: fix button font weight (#26258)
## Description
Fix button font weight

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-10 17:29:42 +03:00
vadim
4c594c6332
fix: WDS fgAccent for achromatic seeds (dark mode) (#26168)
Fixes #26145
2023-08-08 17:06:12 +03:00
Valera Melnikov
58ff27fd84
chore: add components to complex form (#26095)
## Description
Add components to complex form

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-08 10:42:38 +03:00
Valera Melnikov
abff60b6a2
chore: improve eslint rules (#26056)
## Description
Make eslint rules stricter for packages

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-07 15:38:48 +03:00
Valera Melnikov
65a662ee48
chore: clean up switch stories (#26057)
## Description
Clean up switch stories

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-04 21:56:45 +03:00
Pawan Kumar
57cf92e68d
chore: Split Chromatic and Storybook stories (#25877)
Fixes #25427
2023-08-03 21:00:17 +03:00
Pawan Kumar
56c795206e
fix: Loading state changes button width (#25926)
Fixes #25890
2023-08-03 20:34:17 +03:00
vadim
306b1c44ac
chore: WDS color cleanup (#25848)
Closes #25035
2023-08-02 16:03:42 +03:00
Valera Melnikov
e5209aa7cd
fix: bump storybook version and move stories to storybook package (#25821)
## Description
- bump storybook version
- move stories to storybook package
- add dimensions for testing viewports
- improve some stories and types for argTable

#### PR fixes following issue(s)
Fixes #25534

#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-31 19:15:50 +03:00
Pawan Kumar
898ecf6d04
chore: add switch and switch group (#25526)
Fixes #25509 
Fixes #25510
2023-07-27 11:16:26 +03:00
vadim
07c8f06ef9
feat: WDS colors bdOn* (#25743)
Closes #25440
2023-07-26 18:35:17 +03:00
Valera Melnikov
2cb1432e9d
fix: add font-family to theme provider and fix update props in SB theming (#25749)
## Description
Fix the use of theme props in Storybrook.

#### PR fixes following issue(s)
Fixes #25684

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-26 17:51:43 +03:00
Pawan Kumar
2fd0f6f3c2
chore: Add button v2 under feature flag (#25106) 2023-07-26 18:10:44 +05:30
Valera Melnikov
dd9dd5c9a2
fix: add *bdOn* tokens and add borders for buttonGroup (#25727)
## Description
The first part of ButtonGroup component fixes. #25500 

- Add stubs for *bdOn* tokens
- Add borders for ButtonGroup component
- Add stories fixes

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-26 13:03:56 +03:00
vadim
469c31413e
feat: WDS programmatic focus color (#25642)
Fixes #24748
2023-07-25 12:35:46 +03:00
Valera Melnikov
013adf782c
feat: add fluid tokens and flex component (#25448)
## Description
- Add fluid root unit
- Add fluid tokens for typography, spacing and sizing
- Add docs about Theme
- Typography now works by creating a class at the provider level
- Update styled component version. Add PickRename interface to work with
[transient
props](https://styled-components.com/docs/api#transient-props)
- Remove the direct use of rootUnit and replace it with sizing tokens
- Get rid of some unit test because new version of styled components
doesn't work with Jest. Fortunately, we have visual tests.

#### PR fixes following issue(s)
#24295

#### Type of change
- New feature (non-breaking change which adds functionality)

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-24 11:59:05 +03:00
Rishabh Rathod
b863b39d69
feat: Add linting error for assignment expression (#25140)
## Description


This change adds a linting error for direct mutation of widget property
like `Widget.property = "dsf"` and instead suggests to use setter
methods.


#### PR fixes following issue(s)
Fixes #5822


#### Type of change

- New feature (non-breaking change which adds functionality)

## Testing

- [x] Add jest tests as mentioned in the
[comments](https://www.notion.so/appsmith/Widget-Property-Setters-Tech-Spec-2a34730e2e6d4df8ae7637c363b1096c?pvs=4#276554d9875b42d68868aa969e9d7d03)
of the tech spec document for this project.
- [x] Add test to verify linting error for widget assignment
- [x] Add cypress test for autocomplete of more setter methods 
- [x] Add cypress test for currencyInput setValue 

#### How Has This Been Tested?

- [ ] Manual
- [ ] Jest
- [x] Cypress

#### Test Plan

#### Issues raised during DP testing

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [x] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Druthi Polisetty <druthi@appsmith.com>
2023-07-24 12:23:45 +05:30
vadim
0257dd553d
chore: WDS simpler semantic hovers (#25598)
Fixes #25196
2023-07-21 17:56:20 +03:00
arunvjn
6f59c1cde5
fix: PostMessage's message field in Action selector doesn't support Objects (#25467)
## Description
> Message field of PostMessage in Action selector was configured to only
accept string as arguments. Message field should ideally be able to
support any JS Literals and enums. This PR adds a generic argument
setter method, that can handle this specification.
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes #23167
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-21 17:15:48 +05:30
vadim
715342cf56
feat: WDS algorithmic colors fgOn* (#25539)
## Description

tl;dr Accessible readable foregrounds on semantic backgrounds

Fixes #25018 

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-21 12:02:05 +03:00
vadim
5945aaa81b
feat: WDS color bgAssistive (#25406)
## Description

tl;dr Generative backgrounds for tooltips etc.

Fixes #23986

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-18 19:34:40 +03:00
vadim
636d89b37b
feat: WDS colors *Subtle refinement (#25455)
## Description

tl;dr Nicer looking subtles

Fixes #24747

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-18 19:34:23 +03:00
vadim
0bc1213795
feat: WDS color bgNeutral, states and Subtle variant (#25332)
## Description

tl;dr States and other derivatives of `bgNeutral`, some fixes for
`bgNeutral` logic itself.

Fixes #24512  

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-13 11:39:42 +03:00
vadim
eeb2d40a10
feat: WDS bgNeutral, fgNeutral (#25302)
## Description

tl;dr Automatic neutrals for arbitrary seed.

Fixes #25060 

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-11 18:58:33 +03:00
vadim
8d1ff39947
fix: WDS color bdWarningHover return (#25306)
## Description

tl;dr Wrong color was exported (`bdWarning` instead of `bdWarningHover`)

## Type of change
- Bug fix

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-11 18:58:22 +03:00
vadim
89d40ec658
feat: WDS color Negative, states and Subtle variant (#25125)
## Description

tl;dr States and other derivatives of `bgNegative`. Also minor
adjustment for `bgPositiveSubtle` in dark mode.

Fixes #24511 

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-06 16:28:23 +03:00
vadim
8cc76f6287
feat: WDS color Warning, states and Subtle variant (#25158)
## Description

tl;dr States and other derivatives of `bgWarming`.

Fixes #24513 

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-06 16:28:09 +03:00
Favour Ohanekwu
e6f2dcacde
feat: Improve Linting performance (#23865)
## Description
This PR introduces a new architecture, making evaluation and linting
independent.

<img width="500" alt="Screenshot 2023-07-04 at 17 24 40"
src="https://github.com/appsmithorg/appsmith/assets/46670083/00b1eab9-cd79-4442-b51a-5345c2d6c4da">


In the previous architecture, one dependency graph was used to hold the
relationship between entities in the application and subsequently, the
"evaluation order" and "paths to lint" were generated.

Although similar, the dependency graph required for evaluation and
linting differ. For example, trigger fields should not depend on any
other entity/entity path in the eval's dependency graph since they are
not reactive. This is not the case for the linting dependency graph.

## Performance

- This PR introduces "lint only" actions. These actions trigger linting,
but not evaluation. For example, UPDATE_JS_ACTION_BODY_INIT (which is
fired immediately after a user edits the body of a JS Object). Since
linting fires without waiting for a successful update on the server,
**response time decreases by 40%** (from 2s to 1.2s).


- Reduction in time taken to generate paths requiring linting.

<img width="715" alt="Screenshot 2023-07-04 at 18 10 52"
src="https://github.com/appsmithorg/appsmith/assets/46670083/d73a4bfc-de73-4fa7-bdca-af1e5d8ce8a1">



#### PR fixes following issue(s)
Fixes #23447 
Fixes #23166
Fixes #24194 
Fixes #23720 
Fixes #23868 
Fixes #21895 

Latest DP: https://appsmith-r3f9e325p-get-appsmith.vercel.app/



#### Type of change

- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan

https://github.com/appsmithorg/appsmith/pull/23865#issuecomment-1606738633
>
>
#### Issues raised during DP testing

https://github.com/appsmithorg/appsmith/pull/23865#issuecomment-1608779227
response:
https://github.com/appsmithorg/appsmith/pull/23865#issuecomment-1619677033
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [x] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: Ivan Akulov <mail@iamakulov.com>
2023-07-05 14:34:03 +01:00
vadim
84eea29572
feat: WDS bgPositive states and Subtle variant (#25062)
## Description

tl;dr States and other derivatives of `bgPositive`.

Fixes #24510 

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-05 11:58:16 +03:00
vadim
b1649f87d0
feat: WDS algorithmic warning (yellow) colors (#25036)
## Description

tl;dr Automatic adjustment for `*Warning` colors if seed is yellow.
Fixes for found errors in prior algo.

Fixes #23802   

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-04 12:16:02 +03:00
Pawan Kumar
0666b07e30
chore: Add RadioGroup component (#24909)
Fixes #24906

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-06-29 18:07:09 +03:00