Commit Graph

18791 Commits

Author SHA1 Message Date
Nilesh Sarupriya
3d799ad1f9
chore: add information about event tag generation for analytics (#31931)
## Description
> [!TIP]  
> Add code comment block about how event tags are generated for
Analytics service.

Fixes [[Task]: Add clarification on Analytics Events, when is resource
type added as a suffix to the analytics
events.](https://github.com/appsmithorg/appsmith/issues/31582)

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Enhanced clarity on event tag generation in analytics with detailed
comments, including examples and references.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2024-03-21 15:22:54 +05:30
balajisoundar
b498c7e9c4
chore: Add config to widgets to ask for evaluations error and table widget optimisation (#31956)
## Description
- Add `needsErrorInfo` to widget configuration
- Replace usage of `fast-deep-equal` with referential check for
tableData

## Automation

/ok-to-test tags="@tag.Widget"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8370220547>
> Commit: `ded6b16333e1df5d5d55f22df0559ba378f33d9c`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8370220547&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a mechanism to display evaluation errors directly on
widgets when necessary.
- **Enhancements**
- Simplified data comparison logic in `TableWidgetV2` to improve
performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-21 15:16:00 +05:30
Nikhil Nandagopal
0e50c57d6b Updated Label Config 2024-03-21 13:34:20 +05:30
Nikhil Nandagopal
60bb22c782 Updated Label Config 2024-03-21 13:33:43 +05:30
Nikhil Nandagopal
ad6ba1b2b0 Updated Label Config 2024-03-21 13:33:07 +05:30
Nikhil Nandagopal
e2ebf482b8 Updated Label Config 2024-03-21 13:31:54 +05:30
Nikhil Nandagopal
3313fcd91d Updated Label Config 2024-03-21 13:28:02 +05:30
Nikhil Nandagopal
8fcb82207e Updated Label Config 2024-03-21 13:22:13 +05:30
Nikhil Nandagopal
f4eb599e1a Updated Label Config 2024-03-21 13:20:59 +05:30
Arpit Mohan
79726f2483
21st March, 2024 - Daily Promotion 2024-03-21 12:51:39 +05:30
Goutham Pratapa
d3acb4ba8f
feat: add ability to change application logs location (#31926)
Fixes [31877](https://github.com/appsmithorg/appsmith/issues/31877) 

```
sudo docker run -it -d --name ap -e APPSMITH_LOG_DIR=/logs --pull always appsmith/appsmith-dp:ce-31926


(base) ➜  appsmith-ee git:(release) ✗ docker exec -it -u root ap bash
root@3d17510be0d7:/opt/appsmith# ls /logs/*
/logs/backend:
backend-3d17510be0d7.log

/logs/editor:
access-3d17510be0d7.log  error-3d17510be0d7.log

/logs/rts:
rts-3d17510be0d7.log
root@3d17510be0d7:/opt/appsmith#

```
2024-03-20 19:45:48 +05:30
Nikhil Nandagopal
0b3a2d298b Updated Label Config 2024-03-20 19:31:34 +05:30
Nikhil Nandagopal
a5852199dc Updated Label Config 2024-03-20 19:30:48 +05:30
Nikhil Nandagopal
3cf6965653 Updated Label Config 2024-03-20 19:30:29 +05:30
Nikhil Nandagopal
9821057ed4 Updated Label Config 2024-03-20 19:30:12 +05:30
Nikhil Nandagopal
1ecf0e2cc2 Updated Label Config 2024-03-20 19:27:32 +05:30
Nikhil Nandagopal
6a3e3cd824 Updated Label Config 2024-03-20 19:27:09 +05:30
Nikhil Nandagopal
76ce272952 Updated Label Config 2024-03-20 19:26:57 +05:30
Apeksha Bhosale
54a9d06fb9
chore: making body and variables as optional props- 31568 (#31665)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

Fixes #`Issue Number`  
_or_  
Fixes https://github.com/appsmithorg/appsmith/issues/31568
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8325305172>
> Commit: `ce37f05a17f494b1a5409cf79895248cc32f453f`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8325305172&attempt=2"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->
2024-03-20 19:03:52 +05:30
Ankita Kinger
0f28934491
chore: Adding a beta check for adding description on options for creating JS objects (#31950)
## Description

Adding a beta check for adding description on options for creating JS
objects

Fixes [#31949](https://github.com/appsmithorg/appsmith/issues/31949)  

## Automation

/ok-to-test tags="@tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8356416960>
> Commit: `8117683b5b63fcb9f00612fd4083e2bd7f7a2b5a`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8356416960&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the `AddJS` component to display "Beta" in the description for
beta features.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-20 15:43:27 +05:30
Trisha Anand
6d27b2d1b9
Merge pull request #31954 from appsmithorg/release
20/03 Daily Promotion
2024-03-20 15:37:21 +05:30
balajisoundar
55191cb372
fix: [custom widget] remove stale keys from dynamicTriggerPathList (#31586)
## Description
1. Improve string pattern used to determine whether to show onReady
function missing warning
2. Remove stale keys from dynamicTriggerPathList when user changes the
event names
3. Clean up events when a custom widget unselected in editor

Fixes https://github.com/appsmithorg/appsmith/issues/31682
Fixes https://github.com/appsmithorg/appsmith/issues/30276
Fixes https://github.com/appsmithorg/appsmith/issues/30204

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8337490694>
> Commit: `4fcb4cab6960c9a4a459a2b97261a112363901e2`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8337490694&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->







<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a new route for `CustomWidgetBuilderLoader` component,
enhancing navigation and accessibility.
- Enhanced the Custom Widget Builder with improved event handling and
dynamic trigger path support.
- Added a new styled `Container` for the Custom Widget component for
better layout management.
- **Refactor**
- Improved configuration settings readability and consistency for New
Relic integration.
- Refactored `CustomWidgetBuilderService` for clearer modularity and
enhanced message handling.
- Optimized property editing and update logic within the Property Pane
of the Editor.
- **Bug Fixes**
- Adjusted connection timeout in the Custom Widget Builder for a more
responsive user experience.
	- Updated button sizes in the ConfirmationModal for consistency.
- **Tests**
- Added comprehensive test cases for `CustomWidgetBuilderService` and
`Builder` classes.
- **Chores**
- Removed deprecated `UPDATE_SRCDOC_ACK` event, streamlining Custom
Widget Builder events.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-20 14:31:03 +05:30
Nilansh Bansal
6763fa5abc
fix: Table and JSON Widgets columns max height adjusted (#31882)
## Description
> This PR adjusts the maximum number of columns to be shown in Table and
JSON Widgets to 4.

<img width="842" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/25542733/55f85f98-2fc9-4fa1-960b-fc685d74b0d8">


Fixes #31833  

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8355362590>
> Commit: `576e01175a9427bbe8e2a463ad31881fc2875123`
> Cypress dashboard: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8355362590&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank"> Click here!</a>
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js
>
<li>cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts
> <li>cypress/e2e/Regression/ClientSide/Widgets/Select/RTL_support.ts
</ol>
> To know the list of identified flaky tests - <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">Refer here</a>

<!-- end of auto-generated comment: Cypress test results  -->








<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new property to enhance the layout consistency of
draggable list controls.
- **Refactor**
- Updated the layout configuration for improved user interface
consistency in list controls.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-20 08:50:46 +00:00
Nikhil Nandagopal
13a2cf4a3f Updated Label Config 2024-03-20 11:31:58 +05:30
Nikhil Nandagopal
ff5e91b0c8 Updated Label Config 2024-03-20 11:31:47 +05:30
Nikhil Nandagopal
3d67c82f9f Updated Label Config 2024-03-20 11:31:32 +05:30
Nikhil Nandagopal
c0a51a357a Updated Label Config 2024-03-20 11:30:45 +05:30
Nikhil Nandagopal
9729389310 Updated Label Config 2024-03-20 11:30:27 +05:30
Nikhil Nandagopal
dd8c3f10ea Updated Label Config 2024-03-20 11:30:14 +05:30
Nikhil Nandagopal
b4362afddd Updated Label Config 2024-03-20 11:29:54 +05:30
Nikhil Nandagopal
725398a779 Updated Label Config 2024-03-20 11:29:42 +05:30
Nikhil Nandagopal
303c601542 Updated Label Config 2024-03-20 11:27:08 +05:30
Nikhil Nandagopal
0b27776d22 Updated Label Config 2024-03-20 11:23:58 +05:30
Nikhil Nandagopal
4893716fad Updated Label Config 2024-03-19 23:06:58 +05:30
Nikhil Nandagopal
758fc4a4e0 Updated Label Config 2024-03-19 23:06:39 +05:30
Nikhil Nandagopal
ed8bf629de Updated Label Config 2024-03-19 23:06:21 +05:30
Nikhil Nandagopal
e52f5904a4 Updated Label Config 2024-03-19 23:05:43 +05:30
Nikhil Nandagopal
4c0a8d1a09 Updated Label Config 2024-03-19 23:05:30 +05:30
Nikhil Nandagopal
83972f1167 Updated Label Config 2024-03-19 23:05:18 +05:30
Nikhil Nandagopal
dfbb3c864a Updated Label Config 2024-03-19 23:05:01 +05:30
Nikhil Nandagopal
6f615df81d Updated Label Config 2024-03-19 23:04:42 +05:30
Nikhil Nandagopal
69ec4fcc87 Updated Label Config 2024-03-19 23:04:24 +05:30
Nikhil Nandagopal
4b3c437069 Updated Label Config 2024-03-19 23:03:58 +05:30
Nikhil Nandagopal
fb78be2b4f Updated Label Config 2024-03-19 23:03:43 +05:30
Shrikant Sharat Kandula
34c59c8f4d
chore: Reduce RTS error log spam (#31917)
We're logging the entire request/response, Axios config etc. in the
logs, which isn't adding any value in troubleshooting, but is making
reading logs _much_ harder.

This PR will print only the essential information to logs, concisely.
2024-03-19 20:08:09 +05:30
albinAppsmith
8f70909382
feat: Added unit test for query/js delete - next item selection (#31915)
## Description

This PR added unit test to validate getNextEntityAfterDelete

Fixes #31864

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8340217451>
> Commit: `81950b382c97f2634a44d9f64eef904104df8390`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8340217451&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved internal handling of redirection after deleting an entity to
ensure a smoother user experience.
- **Tests**
- Added tests for better reliability in navigating between entities
after deletions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-19 15:17:49 +05:30
Trisha Anand
2270303a52
Merge pull request #31916 from appsmithorg/release
19/03 Daily Promotion(attempt 2)
2024-03-19 14:44:48 +05:30
Abhijeet
3cdd2a97e6
fix: Filter Appsmith exceptions from feature flagged aspect to provide context based exception (#31913)
## Description
PR to provide more contextual exception when Appsmith exception is
thrown within method marked with `@FeatureFlagged`.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8339550893>
> Commit: `e5a0be3166e7ede54240c8981683f61e09f506f8`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8339550893&attempt=2"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Refactor**
- Improved handling of specific exceptions during method invocations to
directly rethrow known exceptions for clearer error reporting.
- **Bug Fixes**
- Enhanced an error message in the system to provide more detailed
information about encountered issues.
- **Tests**
- Added new tests to verify the correct handling and messaging of
exceptions under different conditions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-19 14:33:55 +05:30
Hetu Nandu
65821394b7
chore: Add ability to enable feature flags in unit tests (#31914)
## Description

Allows you to pass feature flags when using the `render` function of
testing utils

```
const container = render(
  <Component />,
  { featureFlags: { release_my_feature_enabled: true } }
)

```

This will update the redux store with the flags values passed
2024-03-19 14:31:08 +05:30
Shrikant Sharat Kandula
54832b6ac3
ci: Fix TED tag 2024-03-19 14:29:27 +05:30