Commit Graph

7854 Commits

Author SHA1 Message Date
Abhijeet
ad4772f5ea
fix: Improve git error logging (#13580)
* Add appropriate error type

* Fix warnings

* Update repo not found exception
2022-05-06 10:57:35 +05:30
Satish Gandham
1146465a3c
chore: Fix the typo in login credentials (#13536)
* Fix the typo in login credentials

* update multiSelect selector

Co-authored-by: Preet <preetsidhu.bits@gmail.com>
2022-05-06 10:46:48 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component (#13105)
* fix: set max-height for Dropdown component

* changes style for date format dropdown

* Combines MultiSelectControl into DropdonwControl

* fix: max height set via props

* fix: popover double scrollbar issue

* fix: styles for chips

* Delete MultiSelectControl

* fix: error when pressing Enter twice

* add tests for multi select & fix some warnings

* removes unwanted test file

* fix: country filtering issue

* address review comments

* fix dropdown for primary columns dropdown

* fix: issue with position

* Adds scrollIntoView when using arrow key for navigation

* fixes issue with scrollbar

* fix: jest tests

* fix: jest test

* fix: flaky cypress test

* fix: height & align issue in Date format selection

* smoothens the scroll
2022-05-06 10:34:17 +05:30
f0c1s
7a3985f962
feat: git discard changes (#11835)
* feat: git discard changes
* fixed cypress test in git connection
* feat: add discardDocUrl and update casing
* chore: update tests
* chore: fix review comment

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-06 10:14:24 +05:30
Ayangade Adeoluwa
ec3a1acc4b
Fix text/plain not showing up when api is run in api response viewer (#13575) 2022-05-05 19:54:24 +00:00
Aswath K
9916315128
Merge pull request #13560 from appsmithorg/fix/colorpicker-tests
fix: package issue with focus-trap causing jest test failure
2022-05-05 23:36:09 +05:30
Abhijeet
ecb3904680
chore: Add analytics event for SSH key generation (#13505) 2022-05-05 15:52:30 +00:00
Vishnu Gp
f23077285b
Merge pull request #13570 from appsmithorg/feat/analytics-events-for-authentication-methods
Chore: Functional breakdown for authentication analytics feature
2022-05-05 20:14:48 +05:30
Aswath K
f3eb7f6ed9 Merge branch 'release' into fix/colorpicker-tests 2022-05-05 19:51:34 +05:30
Aman Agarwal
ff510cba0e
fix: undefined check added for plugin (#13595) 2022-05-05 18:48:56 +05:30
rashmi rai
0b6ea8dc7e
fix: moving refreshTokenClientCredentialsLocation from oAuth2Common to AuthoCode (#13551) 2022-05-05 17:24:14 +05:30
arunvjn
d7d4386e1e
feat: entity explorer submenu (#13425) 2022-05-05 15:44:10 +05:30
Arsalan
69fb17eae0 fix: moved test to WidgetOperationSaga.test.tsx 2022-05-05 14:03:18 +05:30
Arsalan
a02aee83f4 fix: propertyUtils return propertiesToUpdate. 2022-05-05 12:46:57 +05:30
Favour Ohanekwu
c554dcd955 fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)
* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections

(cherry picked from commit 7261834fe5)
2022-05-05 07:57:32 +01:00
Arsalan
d340242ef8 fix: table derived bindingList error. 2022-05-05 12:08:27 +05:30
ashit-rath
f0952b8082
fix: JSONForm RadioGroupField - support numeric values in the options (#13365)
* fix: JSONForm RadioGroupField accept numeric values in the options

* cypress test - clear options before adding

* update code editor clear
2022-05-05 11:10:52 +05:30
Nidhi
dc70220a2f
fix: Throw error when trying to import a cURL command that has a subshell in it (#13558) 2022-05-05 11:08:17 +05:30
Ankita Kinger
8522692bac
Code split for RBAC features (#13557) 2022-05-05 11:07:50 +05:30
arunvjn
7f243c505a
Fixes missing applicationId in fetch comments API by delaying the component mount. (#13519) 2022-05-05 10:52:32 +05:30
Parthvi12
b84f827ef2
test: fix Tab widget related cypress tests (#13571)
* fix Bind_TabWidget_Input_spec and Tab_new_scenario_spec
2022-05-05 09:05:36 +05:30
Vishnu Gp
21f5447e40 Functional breakdown for authentication analytics feature 2022-05-04 20:39:03 +05:30
Paul Li
58dfb48023 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-04 21:46:14 +08:00
arunvjn
3c57ac1764
fix: update JS libs version numbers in entity explorer (#13526) 2022-05-04 19:06:10 +05:30
ankurrsinghal
ef79f6450d
Merge pull request #12190 from appsmithorg/feature/pp-datepicker
feat: added keyboard interaction for datepicker
2022-05-04 18:10:27 +05:30
f0c1s
9cc0cdd404
fix: remove horizontal scrollbar in git sync modal (#13514) 2022-05-04 17:10:32 +05:30
Aswath K
c03cc6e1d3 fix: package issue with focus-trap causing jest test failure 2022-05-04 16:32:04 +05:30
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects (#13212) 2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Favour Ohanekwu
7261834fe5
fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)
* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections
2022-05-04 09:43:26 +01:00
akash-codemonk
05fdfd540b
fix: welcome form shown for a while after signup (#13304) 2022-05-04 14:13:02 +05:30
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience (#12906)
* copy paste commit

* class name generator changes

* modal widget fixes change

* addressing review comments

* bug fix for after deleting a widget by undoing action

* additional fix for modal widget

* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data (#13453) 2022-05-04 12:53:48 +05:30
Abhijeet
9fc9f7a774
chore: Commit application files during the connect flow (#12288)
* Commit application files during the connect flow

* Refactor detach remote method name

* updating connectToGitRepo method

* fix git tests

* Update default dsl to remove uncommitted changes for bottomRow and pathlist

* updating git cypress tests

* fixed git bug spec cypress test

* enabled other test case

* with store test

* fixed comment

* closing git sync modal

* updated test logic

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Parthvi12 <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-04 12:27:07 +05:30
dependabot[bot]
356a3d646d
chore(deps): bump cross-fetch from 3.1.4 to 3.1.5 in /app/client (#13427)
Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/lquixada/cross-fetch/releases)
- [Commits](https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: cross-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 10:57:01 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load (#13415)
* fix: submit button not disabled in invalid json form on first load

* reset fixes
2022-05-04 10:45:27 +05:30
Favour Ohanekwu
3efb3588d2
chore: Add JS editor test cases 2022-05-03 15:22:45 +01:00
Vishnu Gp
acca123872
Merge pull request #13462 from appsmithorg/feat/analytics-events-for-authentication-methods
Feat: Added analytics events for GitHub and Google Auth
2022-05-03 19:51:39 +05:30
Arpit Mohan
80516658b4
Release v1.6.24 2022-05-03 16:14:15 +02:00
haojin111
0414c8823d
fix: 12456 - oauth redirection issue (#13511)
* fixed issue of gsheet authorization
* hidden cloudhost ip info on reconnect modal
2022-05-03 14:22:48 +05:30
Anagh Hegde
75a326470c
fix: Add null check for createdAt field in analytics event (#13491)
* Add null check for createdAt field

* send empty value
2022-05-03 11:42:34 +05:30
Anagh Hegde
d274fa3974
fix: Optimize flow to maintain page order during export-import (#13401)
* Use map isntead of sorting list

* Refactor

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2022-05-03 11:42:22 +05:30
Rimil Dey
c55718f9f1
fix: don't run onClick event handler when button is disabled (#12333) 2022-05-03 07:25:31 +02:00
Favour Ohanekwu
395fd30335
add overflow to js editor settings (#13488) 2022-05-02 20:34:55 +02:00
Ankur Singhal
3b63f59a16 added the force true to single-select action selector 2022-05-02 15:47:25 +05:30
Ankur Singhal
0d0f5d4c2c Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-05-02 13:23:59 +05:30
haojin111
c300bc9eeb
Merge pull request #13472 from appsmithorg/fix/12603-git-import-modal-message
fix: 12603 - git import modal message of remote url inputbox
2022-05-02 14:23:48 +08:00
haojin111
ca33d68532 fixed uppercase of url 2022-05-02 12:50:49 +08:00
Parthvi12
2f4ca6aa98
test: Add tests for git sync app and git bugs (#13394)
* Add tests for gitSync

* add test for git import bug#12749

* modified importAppfromGit method

* add test for bug #13385

* updated tests

* fixed test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-02 09:59:03 +05:30
haojin111
ecffa88684 updated label text of remote url 2022-04-30 21:18:53 +08:00
rashmi rai
4596a12bfd
added fixActionPayloadForMongoQuery (#13465) 2022-04-30 08:27:15 +05:30
Nayan
e9b1108e47
fix: Set default theme when application is exported (#13321)
When application is exported and it does not have a theme set, a NullPointerException was raised in that case. This PR fixes that by returning the default theme when theme is missing.
2022-04-30 01:41:08 +06:00
Preet Sidhu
c6f3f356e6
Merge pull request #12964 from appsmithorg/fix-10379
fix: 10379 disable html parsing for long texts
2022-04-29 12:29:36 -04:00
Rishabh Rathod
3b1fbfa989
fix: replace klon/full with klona default (#13457)
- when manipulating props, react state (immutable values)
2022-04-29 15:14:17 +00:00
Vishnu Gp
a8fa0b7465 Added analytics events for GitHub and Google Auth 2022-04-29 19:18:24 +05:30
Anagh Hegde
3e3a32604a
fix: Git connected Application forking should use default branch application (#13255)
* Application forking use default branch application

* refactor changes

* Update the permission
2022-04-29 19:05:23 +05:30
Ankita Kinger
63479dbb3e
chore: update subtext copies for Google & Github (#13451)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-04-29 17:52:27 +05:30
Preet
2ee727bd84 Merge branch 'release' into fix-10379 2022-04-29 06:34:47 -04:00
akash-codemonk
9b9048fdc4
chore: add analytics event for similar templates click (#13177) 2022-04-29 15:39:16 +05:30
Anagh Hegde
0653f657cf
Merge pull request #13262 from appsmithorg/bug/duplicate-app-git-connected
fix: For git connected apps duplicate should use default branch resources
2022-04-29 15:01:50 +05:30
Paul Li
297b6141c0
fix: feedbacks on label feature (#13123)
* fix: Fix on feedbacks on Label feature

-- Eliminate CSS restriction for horizontal scrolling

* fix: feedbacks on label feature

-- Eliminates CSS rules for overflow-x: hidden
2022-04-29 17:21:08 +08:00
Ankur Singhal
e29a879ff7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-29 14:14:37 +05:30
Preet Sidhu
5726ed0919
chore: add perf test for select widget (#12409)
* wip

* add select widget perf test

* fudge cred

* Revert "fudge cred"

This reverts commit e2e78ed4c126c385b31ca03d9ea5834114849637.

* pr updates

* pr updates

* remove single test script

* remove coverage summary changes
2022-04-29 14:12:03 +05:30
Nayan
501fb1c1ed
feat: Delete theme when application is deleted (#13252)
This PR archives the related themes when an application is deleted aka archived.
2022-04-29 12:38:09 +06:00
Maulik
59e8ad12e1
fix: allow camera & mic access for page in iframe widget 2022-04-29 11:49:44 +05:30
Anagh Hegde
4a19f83a42 Merge branch 'release' into bug/duplicate-app-git-connected 2022-04-29 11:43:45 +05:30
Tolulope Adetula
fa48a026ad Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-04-29 06:12:19 +01:00
Tolulope Adetula
16724bdc04
Merge pull request #13074 from appsmithorg/fix/table-mutiselect-checkbox-alignment
fix: table Widget Multiselect Row checkbox alignment
2022-04-28 21:51:38 -07:00
akash-codemonk
cc3de11bfa
fix: dropdown showing an empty row when the options list is empty (#13364) 2022-04-29 10:09:44 +05:30
Tolulope Adetula
14e1b20464
Merge pull request #12626 from appsmithorg/feat/show-page-count-when-total-records-exist
feat: show total records and pageCount in table header
2022-04-28 19:30:51 -07:00
Tolulope Adetula
5749a4461b Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-29 02:37:59 +01:00
Tolulope Adetula
302644473c
Merge pull request #13164 from appsmithorg/fix/Primary-column-control-visibility-icon-out-of-sync
fix: Primary column control visibility icon out of sync
2022-04-28 18:35:11 -07:00
Tolulope Adetula
76b2e219f6 fix: build issue 2022-04-29 02:22:28 +01:00
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
Tolulope Adetula
70c475f049
Update Icon.tsx 2022-04-28 04:59:14 -07:00
Anagh Hegde
aa4c3fe953 fix: Unable to see apps in home page after git connect fails (#13387) 2022-04-28 17:17:50 +05:30
Tolulope Adetula
359d3706fe Merge branch 'release' into fix/Primary-column-control-visibility-icon-out-of-sync 2022-04-28 12:42:04 +01:00
Tolulope Adetula
47398e20d9 fix: PR reviews 2022-04-28 12:25:14 +01:00
Ankur Singhal
f2cabb8eec Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-28 16:51:19 +05:30
Anagh Hegde
2c484d5538
fix: Unable to see apps in home page after git connect fails (#13387) 2022-04-28 16:43:53 +05:30
Ankur Singhal
47d219cc90 removed day click and clear click which was crfeating the ambiguity 2022-04-28 16:36:18 +05:30
Pawan Kumar
0aec29d837 update theming config 2022-04-28 16:00:03 +05:30
Pawan Kumar
6052600d0b update theming config 2022-04-28 15:58:51 +05:30
Ankita Kinger
3835e81105
chore: Add analytic event for the Reset button click on the Admin settings page. (#13408) 2022-04-28 14:46:38 +05:30
Favour Ohanekwu
02d4af3ed7
prevent multiple execution of pageload actions when generating a template (#13361) 2022-04-27 19:28:52 +01:00
Ankita Kinger
251ad6097b
chore: Add analytic events on Authentication page (#13384)
* added analytic events for Authentication page on Admin settings

* updated event names
2022-04-27 23:16:24 +05:30
rahulramesha
727889434c
fix: calculating the canvas container height to be exact to not scroll on scrollIntoView() call (#13096)
* canvas container Fix

* add comments
2022-04-27 15:43:29 +00:00
Ayangade Adeoluwa
5a126bfda2
Add space to both sides of response run button (#13368) 2022-04-27 12:42:29 +01:00
Tolulope Adetula
2d57840938 fix: add new line 2022-04-27 12:30:43 +01:00
Tolulope Adetula
7f8bf5c4fe fix: PR reviews 2022-04-27 12:29:31 +01:00
ashit-rath
fc36a3af94
feat: Analytics to log source data limit exceed (#13339)
* feat: Analytics to log source data limit exceed

* minor change
2022-04-27 14:04:15 +05:30
Maulik
0eef3b0bfd
fix: code hidden issue for JS Enabled fields (#13241)
* fix code hidden issue for JS Enabled fields

* test for code hidden fix
2022-04-27 12:37:33 +05:30
Anagh Hegde
a768bb5eb7 Merge branch 'release' into bug/duplicate-app-git-connected 2022-04-27 12:31:23 +05:30
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Anagh Hegde
456b5b94ef
fix: Page order sequence for git import (#13126)
* Added page sequence to metadata

* Update test resources

* Add null check for the pageOrder List

* FIx NPE

* Add logic to handle page order for deployed version

* Add tests for the page order

* Add null check for published pages

* Fix unpublished page names getting added in the order list for published

* update the variable name

* Use published page order in tests for published view

* Fix NPE
2022-04-27 11:45:40 +05:30
Nidhi
e73fd0a269
fix: Parse nested structures as tables for action execution results (#13328)
* fix: Parse nested structures as tables

* Updated comments
2022-04-27 08:45:15 +05:30
Ayangade Adeoluwa
c264e1cd89
Add fallback for responseType, in case it does not exist (#13324) 2022-04-26 20:40:59 +05:30
Nidhi
10f83ef698
fix: Throw error on trying to access non-existent unpublished action (#13210)
* fix: Throw error on trying to access non-existent unpublished action

* Fixed NPE at copy policies from page to action
2022-04-26 20:04:14 +05:30
Nidhi
ea6debab20
fix: Added contains and not equals options to where clause in Google Sheets (#13208) 2022-04-26 20:03:17 +05:30
Arsalan Yaldram
4dabbd8f13
fix: onSucess & onError action selector () => {} (#12753) 2022-04-26 20:01:23 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once (#13272) 2022-04-26 19:51:06 +05:30
albinAppsmith
1d019d1376
fix: Modal padding and color fixes (#12189)
* * share modal fixes

* * modal ui fixes
2022-04-26 19:26:07 +05:30
Rimil Dey
0da092baa7
Merge branch 'master' into promotion-release-1-6-22 2022-04-26 17:55:31 +05:30
Sumit Kumar
7e9eb58f03
fix: fix action objects missing plugin id and plugin type info in database (#13263)
* add plugin id and type info to action object if found missing
* this fix is currently added to the read and update action flows
2022-04-26 16:51:30 +05:30
Abhijeet
b88cdacc7d
Fix npe and duplication for JSObject during clone application (#13297) 2022-04-26 13:13:58 +05:30
Tolulope Adetula
faea2712fe fix: disable cancel button on a disabled select widget 2022-04-25 13:36:36 +01:00
Nidhi
21b6936f86 fix: Fixed compile time errors 2022-04-25 14:44:58 +05:30
Anagh Hegde
838b45a8f5 Add branchName check for the clone 2022-04-25 14:24:04 +05:30
Anagh Hegde
94ba542606 use default branch app for clone operation 2022-04-25 14:18:17 +05:30
Bhavin K
20aa7196d2
fix: handle editor value update (#12726) 2022-04-25 12:32:55 +05:30
f0c1s
d428262bf9
fix: Azure SSH url was not accepted for git connection (#12896) 2022-04-23 18:01:43 +05:30
haojin111
08bbd55020
Merge pull request #13207 from appsmithorg/fix/13184-master-branch-issue
fix: 13183, 13184 - fixed issue of correct branch name on edit mode
2022-04-23 05:03:44 +08:00
Aishwarya-U-R
8c8a3b0695
Adding wait to fix flake failures (#13226) 2022-04-22 19:46:03 +05:30
Abhijeet
56998d77d5 Add index for git (#13133) 2022-04-22 18:31:52 +05:30
Aman Agarwal
2d238a6506 fix: updated the condition to show expiry key (#13092) 2022-04-22 18:22:22 +05:30
Preet Sidhu
f89d722479 fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)
* add debounce to search and remove state var

* increase debounce time
2022-04-22 18:22:09 +05:30
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity (#13083) 2022-04-22 17:20:51 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name (#12930)
* Change response tab name

* Fix response tab name
2022-04-22 12:10:00 +01:00
Aman Agarwal
9a022a668f
fix: datasource ui style issues resolved (#13175) 2022-04-22 16:23:00 +05:30
Bhavin K
78600bd2ed
fix: handle dropdown flickers (#12979) 2022-04-22 15:56:48 +05:30
Abhinav Jha
60503bb9a6
feat: Dynamic Height widget config (#13143)
* Add platform feature which adds dynamic height property controls and default properties based on widget config

* Move features to the top, so that defaults can override them if necessary

* - Add unit tests to verify that the property controls show up for dynamic height
- Add unit test to verify that the hidden hook in the dynamic height controls work
- Fix console warning for react key unavailable in Generator.tsx
- Move constants and types to their respective files

* Remove dynamic height config from Container Widget

* Add comments in hard to understand areas

* Add function which converts fn validation params to fnString
2022-04-22 15:14:22 +05:30
ashit-rath
07757c7e7b
fix: Replace "klona/full" -> "klona" in JSONForm to avoid cloning of non-enumerable properties (#13193)
- non-enumerable like `writable`, `configurable`, `enumerable` were getting cloned with `klona/full` and it wasn't needed.
2022-04-22 14:15:45 +05:30
Nayan
0a038e714f
feat: added page names to the templates meta data (#12786)
Adds page names to templates meta data
2022-04-22 12:58:35 +06:00
haojin111
498b9a6f7e fixed issue of correct branch name on edit mode 2022-04-22 14:36:49 +08:00
Bhavin K
7e3d873d20
feat: added searched address into map center data (#12962) 2022-04-22 11:44:42 +05:30
Nayan
c4ee44de15
feat: log template app name to analytics service when template is forked (#12972)
Logs application template name to analytics service when template is forked.
2022-04-22 11:40:32 +06:00
Vishnu Gp
534bdd93b2
fix: Add validation for Git URLs on server (#13182)
This PR adds a backend validation for git URLs on the backend side. Plus added some more test cases for URLs
2022-04-22 07:23:13 +05:30
Nayan
6889882088
feat: updated download template App API to download from cloud services (#12311)
Update download json file API so that it downloads via cloud services
2022-04-22 00:19:46 +06:00
akash-codemonk
7d646bf11c
chore: redirect to home page at the end of onboarding (#12961) 2022-04-21 19:28:26 +05:30
Ankita Kinger
6f311944be
fix: add edition check on cypress to avoid merge conflicts on EE (#13188)
* added edition check on cypress to avoid merge conflicts on EE

* minor change
2022-04-21 19:04:03 +05:30
arunvjn
bdcc99b53b
chore: Hides update button when there are no pending updates. (#13152) 2022-04-21 18:44:10 +05:30
Bhavin K
958233f4f5
fix: added dataFormat into file data (#12807) 2022-04-21 16:09:24 +05:30
Satish Gandham
f6b29d3b71
Fix perf infra data collection (#13158)
Only last run data was being saved to supabase since we were changing the value in the same object.
2022-04-21 15:30:07 +05:30
Nayan
15394207a5
feat: Add API to get template filters (#12969)
Adds a new API to get available filters for application templates from Appsmith cloud services. It acts as a proxy to the API.
2022-04-21 15:52:27 +06:00
Nidhi
d14d8d356e
chore: Added jcmd to Appsmith server image (#13155) 2022-04-21 13:56:49 +05:30
albinAppsmith
978f1d3cd1
chore: Added margin bottom for sign posting checklist footer (#12884) 2022-04-21 11:44:34 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
Abhijeet
3a22cda148
Add index for git (#13133) 2022-04-21 11:10:41 +05:30
Preet
19172bf2b6 reduce line break limits to 1000 2022-04-20 13:22:45 -04:00
Preet
eb4eaf849a Merge remote-tracking branch 'origin/release' into fix-10379 2022-04-20 13:20:22 -04:00
Aishwarya-U-R
ade7b05adb
test: Automation script update to fix PromisesSpec failure (#13148)
* Promises spec fix for validating EitherOr

* Sipping LayoutValidationForLoginPage failure case
2022-04-20 22:00:22 +05:30
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change (#13085)
* Scroll to active entity in explorer on route change

* Removes scroll animation

* Open modal via entity explorer

* Try tonavigate to canvas only in edit mode

* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
Tolulope Adetula
04ac78ba15 fix: Primary column control visibility icon out of sync 2022-04-20 14:56:01 +01:00
rahulramesha
98f6a3fede
move reflow out of beta (#12746) 2022-04-20 18:33:30 +05:30
Paul Li
0771f23294 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Rename getDropdownPosition to getCloesetCanvas
2022-04-20 20:40:53 +08:00
Paul Li
ef56d732a8 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 20:36:53 +08:00
Paul Li
b2c1ebf736 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Makes getDropdownPosition as a widget utility function
2022-04-20 20:35:35 +08:00
Aman Agarwal
356cdfffab
fix: changed prop drilled fn to class fn, avoided array prop (#12788) 2022-04-20 15:56:27 +05:30
Leo Thomas
c8f88ed977
fix: 11141-JDBC override parameter for resolving TZ Cast Errors (#12821) 2022-04-20 14:50:49 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
Vishnu Gp
cfb7fc4b94
fix: git remote SSH url for Azure | BE (#12933)
Users were not able to add Git SSH URLs from some providers. This fixes the BE aspects of this issue.
2022-04-20 14:47:02 +05:30
Paul Li
43ca423b48 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 17:04:24 +08:00
Paul Li
9301bf9637 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Sets popover container to the closest canvas
2022-04-20 17:02:57 +08:00
rahulramesha
27b54f22e8
Reflow overlapping fix on canvas edges (#12745) 2022-04-20 12:56:35 +05:30
Pawan Kumar
a5e32c8083
chore: Update theming default themes configs (#13117)
* theming config update

* add progress bar

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-04-20 12:08:35 +05:30
Aman Agarwal
4f4d1400c5
fix: updated the condition to show expiry key (#13092) 2022-04-20 11:32:01 +05:30
haojin111
923efa9696
fixed issue of deleting original default branch (#13062) 2022-04-20 05:50:54 +05:30
Anagh Hegde
ecb08a4918
Add logic to change default branch for git connected application (#11549)
We are opening the appsmith default application when the user clicks on edit. But when the app is connected to git we should always bring up the default application of the default branch.
2022-04-19 19:43:23 +05:30
Abhijeet
cebccc5401
Fix issues in git flows when pages don't have reference in application object (#13040)
As a part of git-directory update we have introduced a bug where if the entity names includes the - we were not able to filter the entities in the individual page directory. This commit introduces a new name-seperator to avoid such issues.
2022-04-19 17:25:11 +05:30
Tolulope Adetula
a892aa678d fix: Table Multiselect checkbox alignment 2022-04-19 09:40:42 +01:00
rashmi rai
bb5d7159c6
Always show advanced settings in rest api editor (#12927) 2022-04-19 12:03:27 +05:30
Ankita Kinger
5b4628a9d4
Add common code for SAML (#12976)
Added new form field component in ads. Also, updated copy URL form component.
2022-04-18 17:47:29 +05:30
Anagh Hegde
f9fee48c14
Remove feature flag for git import (#12909) 2022-04-18 16:36:59 +05:30
Anagh Hegde
4b8646dd05
Handle logic to delete the application during git delete branch flow (#12986) 2022-04-18 15:24:40 +05:30
Rishabh Rathod
8df17fd56c
chore: remove minifying in dev to ease debugging (#12940) 2022-04-18 13:51:36 +05:30
Bhavin K
3575a03005
fix: updated cursor style in actionWrapper (#12850) 2022-04-18 11:39:11 +05:30
Preet Sidhu
820a99e5d1 disable html parsing for long texts 2022-04-15 10:03:38 -04:00
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
akash-codemonk
71591ff75f
chore: remove frontend template feature flag (#12937) 2022-04-15 14:58:27 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Abhijeet
a12750b536
feat: Update directory structure for git-sync to mimic UI (#11705)
* File migration for git

* Testcases added

* Comments added

* Update the action file names to keep unique constraints

* Separate out the theme from metadata

* Update server version to convey the file migration
2022-04-14 23:35:08 +05:30
Aswath K
25afe65cb7
Merge pull request #12923 from appsmithorg/fix/delete-button-kdb
feat: makes option control delete button keyboard accessible
2022-04-14 19:57:06 +05:30
Rishabh Rathod
846ba223ea
fix: replace rfdc with klona (#12568)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-14 14:19:13 +00:00
akash-codemonk
90fa2d7912
fix: onboarding deploy step getting redirected to edit view (#12830) 2022-04-14 16:58:51 +05:30
Aswath K
6a4b632338 Merge branch 'release' into fix/delete-button-kdb 2022-04-14 16:24:52 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Aswath K
1bf959d177 feat: makes option control delete button keyboard accessible 2022-04-14 13:23:41 +05:30
Ayangade Adeoluwa
a4d22b3d13
Handle stringified json response and fix alignment issue (#12886) 2022-04-14 12:53:07 +05:30
Rishabh Rathod
ee76cabb96
chore: fix Key missing error in Boxed component (#12912) 2022-04-14 06:31:50 +00:00
arunvjn
b7aff3c38b
chore: Parallellise fetch page call with actions, jsObject and plugins (#12537) 2022-04-14 10:16:17 +05:30
rahulramesha
cfba555fe8
chore: Should not persist DSL for mainContainer layout changes (#12351)
* Moving out non persistent state out of DSL

* replacing canvas width seector

* converting to immerReducer

* adding TODO and more immer reducer changes
2022-04-14 10:06:20 +05:30
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
rahulramesha
faaf977728
feat: Container Jump Improvements and Code for tracking Container Jumps (#12686)
* conatiner Jump Optimization and tracking

* Round of mouse positions ans add negative jest test cases

* addressing review comments
2022-04-13 20:27:44 +05:30
Vishnu Gp
c7a4ac7353
fix: Organization name can be empty
fix: Organization name can be empty
2022-04-13 17:36:32 +05:30
Anagh Hegde
5c17422956
fix: Connection timeout for git connect when the git repo is behind a firewall (#12819)
* Use non blocking IO for checking the repo status

* Cache the results

* Update tests for the util class method
2022-04-13 10:33:28 +00:00
akash-codemonk
2abb7bb822
fix: welcome form getting submitted on pressing enter key (#12613) 2022-04-13 15:37:11 +05:30
f0c1s
736c2e024e
feat: git delete branch (#12681) 2022-04-13 15:33:23 +05:30
akash-codemonk
73482000a6
chore: search for templates with a given datasource or widgets (#12434) 2022-04-13 14:18:40 +05:30
f0c1s
f5796bfa30
fix: git merge tab issues (#12576) 2022-04-13 08:47:33 +00:00
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30
Favour Ohanekwu
b102d32761
fix: show loading state in JS Editor (#12820) 2022-04-13 11:47:56 +05:30
Vishnu Gp
ccc25f35f5 code refactoring for empty organization name fix 2022-04-13 11:17:35 +05:30
Anand Srinivasan
8420f6c5fa
fix: Js object - set async tag after all objects are parsed (#12684)
* set isAsync after all parsing is done

* clean up
2022-04-13 11:07:46 +05:30
Preet Sidhu
19d0db30b0
fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)
* add debounce to search and remove state var

* increase debounce time
2022-04-12 16:31:51 +00:00
Nayan
4819907a34
feat: Add analytics events to track user activation (#12611)
Adds some attributes to existing analytics events to track user activation.
2022-04-12 20:09:03 +06:00
akash-codemonk
d292075243
fix: template fork button style on safari (#12202) 2022-04-12 19:23:57 +05:30
Rishabh Rathod
136308fd7c
fix: table search text dependency deletion (#11608)
* Replace BindingPaths with ReactivePaths and remove non-bindable property path from bindingPaths to reduce confusion.
2022-04-12 13:09:26 +00:00
arunvjn
68bca33a55
fix: broken checklist onboarding flow (#12822) 2022-04-12 17:03:35 +05:30
Aman Agarwal
21eb88f847
fix: updated default content-type and default body format type (#11878)
* fix: updated default content-type and default body format type

* fix: updated the cypress test because the default content-type is changed

* fix: update content type on change of http method and update body format type too

* fix: changed cypress test back to previous
2022-04-12 16:43:11 +05:30
Nidhi
b2d356bcce
fix: Fixes connection pool minimum size to 0, also refactored uri related operations (#12837) 2022-04-12 16:33:07 +05:30
Ankita Kinger
c1e48f7486
feat: Refactor code for SAML integration (#12700)
* Implemented code splitting of some files for SAML integration

* Implemented code splitting of some more files for SAML integration

* updated redirect url component

* fixed an import statement

* fixed a unit test

* updated restart banner tooltip logic

* updated an import statement
2022-04-12 16:20:01 +05:30
Rishabh Rathod
7626d75ccf
fix: remove "Error when determining async func" (#12683)
- Add logs for debugging
2022-04-12 10:02:02 +00:00
Satish Gandham
76d9f2b9fc
chore: use postgres as datasource for performance tests (#12689)
* Use postgres as datasource for the golden app

* - Update DB name

* Remove fake API data source from DSL

* Change the app base url

* Update postgress DB details in DSL

* User dev.appsmith.com for testing instead of localhost

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-04-12 10:01:41 +00:00
Aishwarya-U-R
8f4756c1d1
test: Automated tests for AForce Migration scenarios + Improved TableFilter spec script coverage (#12534)
* Aforce spec- DefaultSearchText added

* Bug 12228 scripted

* Remove text added

* Aforce - Client Side Search added

* Aforce - adding new issue from modal

* Aforce spec - add new issue fixed

* Aforce spec - update/Delete issue added

* Aforce - multi widget selection fix

* aforce spec - multi select fix

* Aforce - multi select fix

* Aforce - multi select fix

* Removing Table_Filter_spec from ignore files

* MemberRoles locator fix

* member roles locator update

* Tablefilter spec fix

* Aforce spec type fix

* Aforce - search spec

* TableFilter spec fix

* Chartdatapoint fixed

* desc update

* Aforce - skipping table search again

* Removed duplicate spec

* GetNClick improved

* BindTable_api spec fix

* AForce spec fix

* CHartdatapoint spec fixed

* JSObjToListwidget spec fix

* OnPageLoad spec fix

* updates

* TableFilter.ts added

* TableFilter added more scenarios

* TableFilter added more scenarios

* Table_spec failure fix

* TableFilter spec - scenarios added

* AForce Filter case added

* AForce fix

* Aforce filter fix

* Aforce fix

* SelectFromMultiSelect added fix

* Picking msg from message.ts file

* Aforce spec - Added wait

* Aforce - filter spec fix

* JSONload messages update
2022-04-12 15:31:22 +05:30
Tolulope Adetula
89fcc414e3
fix: remove internalKeys from Selected row and Triggered row (#12655) 2022-04-12 10:01:03 +00:00
Trisha Anand
85ebed6d5e
Merge branch 'master' into release 2022-04-12 14:06:53 +05:30
haojin111
c32ca69a91
fix: 12456, 12420, 12422 on reconnect modal issues (#12569)
* fixed-12456 gsheet auth issue

* fixed - 12420 save button functionality failed

* fixed - 12422 datasource selection issue

* fixed issue of gsheet authentication

* fixed comments point

* fixed 12511: typo issue

* fixed cypress test import and export
2022-04-11 23:00:29 +05:30
Ayangade Adeoluwa
5bc414082a
fix: Fix app crash on arrow down in where clause (#12801)
* Fix app crash on arrow down in where clause

* Makes sure first index is not omitted
2022-04-11 17:02:56 +00:00
Ayangade Adeoluwa
8bdcbec9f1
fix: Fix google sheets datasource options (#12773) 2022-04-11 20:29:13 +05:30
Tolulope Adetula
52a51b882c
fix: select widget virtualization not rendering first top items (#12768)
* fix: select widget virtualization

* fix: use max height of renderMenuItem

* fix: make height a constant

* fix: variable name

* fixed spec

Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-04-11 18:20:01 +05:30
Nidhi
e36b352a42
fix: Conversion logic for expires in field (#12781) 2022-04-11 11:27:24 +00:00
haojin111
6e63290477
fix: 12338 - postgres datasource default configure on reconnect modal (#12503)
* updated logic of form initialization on reconnect datasource modal

* fixed cypress test

* fixed cypress test
2022-04-11 16:53:52 +05:30
Vishnu Gp
2c24050bf9 Added comments and test case for empty organization name fix 2022-04-11 16:27:31 +05:30
Ankita Kinger
65ffb56f34
chore: Improve the UI for restart banner on admin settings page (#12580)
* improved the UI for restart banner on admin settings page

* implemented suggestions from PR

* retrying to restart server on button click

* updated colors getting used

* implemented PR suggestions

* fixed cypress test failure
2022-04-11 14:12:06 +05:30
Anagh Hegde
f9df59f02b
Handle empty repo during git import with proper error message (#12752) 2022-04-11 12:29:18 +05:30
Abhijeet
8dd6bc8d4c
fix: After cloning the page with JSObject creating a new branch copies all the JSObject in a single page (#12743) 2022-04-11 07:42:09 +02:00
Vishnu Gp
1826f3dfef Fix empty organization name 2022-04-11 10:53:38 +05:30
akash-codemonk
d100cac0ec
fix: fork app button not opening the fork modal for non-signed in users (#12479) 2022-04-11 10:44:50 +05:30
Leo Thomas
f8cc2f5e54
fix: add support for reading DBRef type in Mongo plugin (#12670)
* DBRef fix with codec

* Added code comments regarding custom codec implemented

* Added Unit Test for Mongo DBRef

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-04-11 09:38:17 +05:30
NandanAnantharamu
db2310bef7
test: Commands file organised (#12533)
* Commands file seggregated

* updated support file

* updated common method

* updated the support files

* Updated imports
2022-04-11 09:00:37 +05:30
Rishabh Rathod
5c7a0105de
fix: react overlay issue (#12742) 2022-04-10 18:02:57 +05:30
Aswath K
7aba7772e2
fix: invisible icon in panel (#12610) 2022-04-10 00:01:37 +05:30
Favour Ohanekwu
b3e30725dc
properly handle translated diffs when change is between undefined and an Array (#12577) 2022-04-09 14:55:41 +01:00
Abhijeet
75cfe8df5b
fix: Fix clone page issue where JSObjects are not showing up in destination page when application is connected to git (#12723) 2022-04-09 13:53:28 +00:00
Anagh Hegde
e386c594fe
fix: Maintain page order during file import (#12698)
* Add logic to order page after creating

* Add test to check if the page order is same as the json file during the import
2022-04-09 11:15:45 +05:30
balajisoundar
a58416585f
chore: Fix failing test case in phone input onSubmit spec (#12735) 2022-04-09 07:19:51 +02:00
Anagh Hegde
f9f689af69
fix: Current branch delete exception in delete branch API (#12699)
* Handle current branch delete exception

* Updated error message

* Update error message
2022-04-08 18:28:43 +00:00
balajisoundar
a11ae569e1 Fixing merge conflicts 2022-04-08 19:48:47 +02:00
albinAppsmith
2ffeb192cc chore: Edit app icon color changes to white (#12693) 2022-04-08 19:43:22 +02:00
Sumit Kumar
ed35225df7 fix: update check for GSheet where condition (#12729) 2022-04-08 19:43:22 +02:00
balajisoundar
6cdef28afa
fix: Phone and currency widget's dialCode and currencyCode should … (#12720) 2022-04-08 19:39:05 +02:00
ashit-rath
6a33b4da5a
fix: JSONForm select not working in nested fields - Array/Object (#12635)
* fix: JSONForm select not working in nested fields - Array/Object

* fixed merge-conflict missing import
2022-04-08 22:54:08 +05:30
imgbot[bot]
bc0325617c
chore: [ImgBot] Optimize images (#12266)
*Total -- 563.13kb -> 460.13kb (18.29%)

/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/EmptyApp.snap.png -- 17.86kb -> 11.54kb (35.43%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/quickPageWizard.snap.png -- 57.24kb -> 39.42kb (31.12%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/emptyAppBuilder.snap.png -- 74.00kb -> 51.48kb (30.43%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/apppage.snap.png -- 46.22kb -> 32.18kb (30.38%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/loginpage.snap.png -- 33.64kb -> 24.07kb (28.44%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout_spec.js/Profile.snap.png -- 29.72kb -> 21.58kb (27.4%)
/app/client/src/assets/gifs/table_data.gif -- 60.23kb -> 50.42kb (16.29%)
/app/client/src/assets/gifs/default_text.gif -- 90.40kb -> 75.70kb (16.26%)
/app/client/src/widgets/JSONFormWidget/icon.svg -- 0.47kb -> 0.46kb (1.66%)
/app/client/src/assets/icons/ads/js.svg -- 1.14kb -> 1.12kb (1.2%)
/app/client/src/assets/icons/ads/fork-2.svg -- 1.45kb -> 1.44kb (0.47%)
/app/client/src/assets/images/lock-password-line.svg -- 0.80kb -> 0.80kb (0.36%)
/app/client/src/assets/icons/menu/settings.svg -- 1.00kb -> 1.00kb (0.29%)
/app/client/src/widgets/CurrencyInputWidget/icon.svg -- 1.05kb -> 1.05kb (0.28%)
/app/client/src/widgets/PhoneInputWidget/icon.svg -- 1.47kb -> 1.46kb (0.2%)
/app/client/src/assets/images/saml.svg -- 2.71kb -> 2.70kb (0.18%)
/app/client/src/widgets/CircularProgressWidget/icon.svg -- 2.32kb -> 2.32kb (0.17%)
/app/client/src/assets/images/oidc.svg -- 19.98kb -> 19.97kb (0.05%)
/app/client/src/assets/images/request-template.svg -- 121.44kb -> 121.43kb (0.01%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2022-04-08 22:52:58 +05:30
albinAppsmith
ab7bfc1cd2
chore: Edit app icon color changes to white (#12693) 2022-04-08 22:42:14 +05:30
Sumit Kumar
cffc445824
fix: update check for GSheet where condition (#12729) 2022-04-08 22:33:47 +05:30
Ayangade Adeoluwa
bc8d885813
feat: Response view switcher for all action editors (#9629)
* Response view switcher for all action editors

* fixes prettier issue

* adds correct type to responseDataTypes property

* fix some more conflicts

* Try a new  multi switch component

* Revert multiswitch changes

* Adds finishing touches

* remove warnings

* Fixing bugs, reusing logic
2022-04-08 16:32:34 +00:00
arunvjn
8b10190e1b chore: Added analytics for manual upgrade and adds redirection (#12707) 2022-04-08 17:00:13 +02:00
arunvjn
7f4a190657
chore: Added analytics for manual upgrade and adds redirection (#12707) 2022-04-08 20:27:19 +05:30
Paul Li
9219545879
fix: Form widget should include the following widgets in data property when added in form (#12529)
* fix: Form widget should include the following widgets in data property when added in form

-- Add value props to the widgets, including CheckboxGroupWidget, MultiSelectTreeWidget, MultiSelectWidgetV2, SingleSelectTreeWidget, SwitchGroupWidget
-- Add the corresponding Cypress test case

* fix: Form widget should include the following widgets in data property when added in form

-- Set the value meta propperty for PhoneInputWidget to empty string by default

* fix: Form widget should include the following widgets in data property when added in form

-- Include PhoneInputWidget for test

* fix: Form widget should include the following widgets in data property when added in form

-- Add InputWidgetV2 and CurrencyInputWidget

* fix: Form widget should include the following widgets in data property when added in form

-- Add SelectWidget for assertion

* fix: Form widget should include the following widgets in data property when added in form

-- Wait for @updateLayout

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
2022-04-08 21:07:10 +08:00
Paul Li
115a119003
fix: Auto-suggestion is not working for progress widget while binding (#12675)
* fix: Auto-suggestion is not working for progress widget while binding

-- Add a Cypress test case for demonstrating auto suggestion

* added fix for buttonspec's test

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-04-08 20:11:01 +08:00
Anagh Hegde
737680bb9b
fix: Reset of isPublic flag during git merge operation (#12703)
* do not update the isPublic flag during git operation

* Add tests

* update the comments
2022-04-08 14:35:20 +05:30
Tolulope Adetula
08246e7783
Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-08 09:02:06 +01:00
ashit-rath
99ec9e82e3
fix: JSONForm select/multiselect filterText value synchronous update with onFilterUpdate action (#12578)
* fix: JSONForm select/multiselect filterText synchronous update with onFilterUpdate action

* removed unused dep from useMemo
2022-04-08 11:39:23 +05:30
Favour Ohanekwu
dcddf4cb86
chore: Add data property in entity explorer as part of "show bindings" (#12590)
* include JSAction data in show-bindings
2022-04-07 21:37:03 +01:00
Tolulope Adetula
99a5b8ca69
Merge pull request #12356 from appsmithorg/fix/table-widget-scroll-issue
fix: remove unnecessary horizontal scroll when table columns fit within table widget width and prevent unnecessary re-renders
2022-04-07 19:46:43 +01:00
arunvjn
fabfb65a4f
chore: Parallelise feature flags and user info API (#12263) 2022-04-07 23:27:32 +05:30
Arsalan Yaldram
461f35380b
Merge pull request #12546 from appsmithorg/fix/10319-select-api-response
fix: Disable CTRL+A to select all widgets on Api / Datasource Pane.
2022-04-07 21:51:10 +05:30
Yash Vibhandik
7736daf0a5
fix: 8385 added button variant support in table column type button (#9164) 2022-04-07 16:19:51 +00:00
f0c1s
0ad66f27bd
fix: introduce new regexp for remote url validation (#12004)
* fix: introduce new regexp for remote url validation
* chore: add tests and refactor
* fix: failing cypress test
2022-04-07 16:19:28 +00:00
Bhavin K
d22ae809cb
fix: handle duplicate tab name in tab widget (#12411) 2022-04-07 16:19:12 +00:00
Ayangade Adeoluwa
a210d67e55
feat: Refactor SaasEditor page (#12559)
* Refactor SaasEditor page

* Remove unused variables

* Fixes query form issue with google sheets
2022-04-07 16:18:49 +00:00
rashmi rai
58ac293bda
fix: retained value of where condition (#12592) 2022-04-07 16:18:29 +00:00
f0c1s
ecb6b4457e
feat - remove horizontal rule from git branch list (#12614) 2022-04-07 16:18:14 +00:00
Ankur Singhal
80cebebc0d fixed the first movement on shift 2022-04-07 19:34:55 +05:30
Ankur Singhal
ba24c9736b abstracted out the keyboard navigation behavior in a separate hook 2022-04-07 17:54:17 +05:30
Ankur Singhal
28859aa844 cycling back through controls with shift+tab is also working 2022-04-07 17:45:02 +05:30
Ankur Singhal
6bd7b07747 cycling back through controls with shift+tab is also working 2022-04-07 17:44:45 +05:30
arunvjn
345df76ccc Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 16:33:00 +05:30
Anand Srinivasan
ada1293797
Revert "fix: trigger fields linting issue (#11875)" (#12668)
This reverts commit 186a97c699.
2022-04-07 16:31:31 +05:30
arunvjn
2ac4d917f7 Merge branch 'release' into releasev1.6.17 2022-04-07 16:01:26 +05:30
Aishwarya-U-R
6363e75bda
test: Automation script update to fix JSOnPageLoad pop-up text message (#12673) 2022-04-07 15:55:24 +05:30
arunvjn
c3fdeb884e Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 15:43:29 +05:30
Paul Li
7045416dd8
fix: Progress widget with circular type is showing wrong value (#12667)
-- Output progress value as it is
2022-04-07 15:39:35 +05:30
Aishwarya-U-R
cb14819046
JSOnPageLoad pop-up text msg fix (#12671) 2022-04-07 12:08:26 +02:00
arunvjn
1c5e216e6f Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 14:08:48 +05:30
Parthvi12
d98f590010
test: Revert postgres CRUD element xpath to match CRUD template revertion (#12664)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-04-07 13:42:40 +05:30
Paul Li
481c1297a7
fix: Auto-suggestion is not working for progress widget while binding (#12658) 2022-04-07 13:37:09 +05:30
Ayangade Adeoluwa
d54720fd19
fix: Fix app crash on navigation to API and Datasource Editor (#12640) 2022-04-07 12:45:10 +05:30
Apeksha Bhosale
7b88bfd380
chore: added beta tag to onPageLoad for js actions (#12657) 2022-04-07 12:42:55 +05:30
Nikhil Nandagopal
1d27c951de
Reverted to older template file 2022-04-07 12:14:41 +05:30
Nikhil Nandagopal
73b3a54e08
chore: Update crud template (#12634) 2022-04-07 11:36:55 +05:30
Pawan Kumar
cf425249ca
chore: update theming stylesheet config (#12645) - skipChangeLog
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-04-07 11:28:45 +05:30
arunvjn
03b46483dc
fix: 404 on apps with names that start with api, login or oauth (#12619) 2022-04-07 07:39:15 +02:00
Tolulope Adetula
25c0dabd7b fix: add HTML default for empty space 2022-04-07 05:23:08 +01:00
Nikhil Nandagopal
2539d6ec12 Updated Template 2022-04-06 19:44:23 +05:30
Nikhil Nandagopal
8dd700f663 Updated Template 2022-04-06 19:41:30 +05:30
Nikhil Nandagopal
a9ccfab55b Updated Template 2022-04-06 19:41:28 +05:30
Tolulope Adetula
86ce80abc3 feat: add total records and pageCount to table header 2022-04-06 12:48:55 +01:00
Nikhil Nandagopal
a6fe504768
feat: Updated CRUD Template (#12579)
* Updated Template

* Updated Template

* Updated Template

* updated xpaths for gemeratePage

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-04-06 15:46:36 +05:30
arunvjn
f18d3b8dc4
fix: update url while switching between git branches (#12586) 2022-04-06 11:46:37 +02:00
Ankur Singhal
149c1e29bb increased the height and added vertical padding like other controls 2022-04-06 14:26:18 +05:30
Ankur Singhal
9ea3f5005f we can now cycle through all internal controls of Datepicker on pressing tab 2022-04-06 13:53:25 +05:30
Apeksha Bhosale
e7d4bdba6e
fix: removed promisification of confirmation (#12553)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 12:52:18 +05:30
Nidhi
79a63d535d
fix: Only add missing user set actions to scheduling order (#12601) 2022-04-06 12:04:41 +05:30
Bhavin K
787df868bb
Revert "fix: #6518 Implemented responsive table header controls (#10971)" (#12583)
This reverts commit 88ad2bcbd1.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 11:07:13 +05:30
Nidhi
981c618420
fix: Using form url encoded content type for token requests (#12597)
* fix: Using form url encoded content type for token requests

* fix: Using form url encoded content type for cc as well

* fix: Conversion logic for expires in field
2022-04-05 17:47:44 +00:00
Aswath K
7c647b948c
Fix error with start-https.sh on directory with space in it (#12566) 2022-04-05 20:09:05 +05:30
Tolulope Adetula
f7018314ab
Merge pull request #12541 from appsmithorg/fix/Align-Table-widget-URL-Column-type
fix: align Table widget URL Column type
2022-04-05 13:54:14 +01:00
Ankita Kinger
253b90e595
chore: Add some cypress tests for Admin settings page (#12542)
* added few cypress tests for admin settings page

* uncommented some cypress tests

* updated PR based on suggestions in comments
2022-04-05 18:00:57 +05:30
Arsalan Yaldram
db67e91b63
Merge pull request #12253 from appsmithorg/fix/bindPathList-error
fix: remove bindingPathList properties on jstoggle off.
2022-04-05 17:56:00 +05:30
Arsalan Yaldram
889fd9075c
Merge pull request #12372 from appsmithorg/fix/7554-disabled-button-enable-tooltip
fix: Disabled button widget tooltips stay open
2022-04-05 17:18:19 +05:30
Aman Agarwal
342206e8e4
fix: added a null check for datasourceConfiguration to refer url key (#12575) 2022-04-05 17:00:52 +05:30
Tolulope Adetula
470fd8da21 fix: Align Link icon with text 2022-04-05 12:22:33 +01:00
Arsalan
e88c76d691 fix: Test case for Canvas_scrolling_spec 2022-04-05 14:55:48 +05:30
Arsalan
f5057c544e Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-05 14:47:39 +05:30
Arsalan
aa025143c3 Merge branch 'release' into fix/10319-select-api-response 2022-04-05 14:43:29 +05:30
Arsalan
589bdfc074 fix: Fixed jest test case and added cypress case 2022-04-05 14:42:41 +05:30
Ankita Kinger
8875ace595
chore: Added a check for testing mandatory fields (#12555)
* improved the UX on admin settings page

* added check for value containing only spaces

* implemented suggestions from PR

* implemented suggestion on the PR

* changed logic for checking mandatory fields is not empty

* removed unused import

* updated documentation links for google & github

* using css variables

* added a fix for checking mandatory fields
2022-04-05 13:54:43 +05:30
Tolulope Adetula
6b5a6ff8bf
Merge pull request #12459 from appsmithorg/fix/Multiselect-style-specificity
fix: Multi-select dropdown not closing properly
2022-04-05 09:07:54 +01:00
Apeksha Bhosale
9d9803a3d3
added sanity check to avoid unexpected eval error (#12506) 2022-04-05 13:16:11 +05:30
Tolulope Adetula
e05e75758d
Merge pull request #11383 from appsmithorg/feat/4182-form-detect-changes
feat: Internal property to detect changes in a form
2022-04-05 06:35:20 +01:00
arunvjn
b961f6e2e3
fix: Pages tab navigation in preview mode for git apps (#12567) 2022-04-05 10:02:52 +05:30
Arsalan
b9123b3224 Merge branch 'release' into fix/bindPathList-error 2022-04-04 23:44:15 +05:30
Anagh Hegde
e3c7d2b3f2
fix: While importing the application page sequence does not match with the source application (#12539)
* Add logic to maintain page order while exporting the app

* Add test for the page order during export
2022-04-04 23:24:42 +05:30
arunvjn
b729d842db
fix: page launch error from dashboard (#12557) 2022-04-04 20:55:03 +05:30
Arsalan
b3843e7aa9 fix: Fixed failing test cases 2022-04-04 19:19:51 +05:30
Arsalan
1bf80bd8b8 fix: undo spec test changes. 2022-04-04 19:17:48 +05:30
Arsalan
197554917d fix: undo spec test changes. 2022-04-04 19:17:02 +05:30
Arsalan
b995983adf fix: Test cases fixed for button widget. 2022-04-04 19:07:09 +05:30
Ankur Singhal
26c1c373f9 added input focus color and focus back to input after date selection 2022-04-04 18:51:18 +05:30
Yash Vibhandik
88ad2bcbd1
fix: #6518 Implemented responsive table header controls (#10971) 2022-04-04 18:47:45 +05:30
Arsalan
01539dd52d Merge branch 'release' into fix/10319-select-api-response 2022-04-04 18:06:17 +05:30
f0c1s
057817d393
feat: migration changes hint (#12071)
* Initial changes

* feat: adding new icon and refactoring

* feat: add text and test ids

* chore: add tests
2022-04-04 17:11:49 +05:30
arunvjn
1af6ef2be8
fix: 404 on renaming new pages in apps with legacy URLs (#12547) 2022-04-04 13:11:52 +02:00
Arsalan
c3f2ef1b03 fix: added helpful comments 2022-04-04 16:12:51 +05:30
Arsalan
2e2c0d977e Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-04 16:06:09 +05:30
Arsalan
a64c485f2d fix: remove renderMode prop from widget. 2022-04-04 16:05:08 +05:30
arunvjn
0d7b9df3bd
chore: Changing the clean URLs update description in product updates modal (#12408) 2022-04-04 16:02:51 +05:30
Arsalan
b0869f4d93 fix: Disable CTRL+A to select all widgets on Api Pane. 2022-04-04 13:48:05 +05:30
Parthvi12
6653adc30e
test: add tests for git import flow (#12427)
* adding basic test for git import

* add git import test
2022-04-04 13:27:34 +05:30
Abhijeet
ffd0595330
fix: Fix importing datasource with same name but different plugin issue (#12512)
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
2022-04-04 13:23:00 +05:30
Sumit Kumar
f201ec7bcd
fix: make region a non-mandatory field (#12510)
* Currently S3 plugin datasource requires the region field to be non-empty for it to work (when configured with other as the datasource type from dropdown). However, this field is not required for many S3 offerings. Hence, making it non-mandatory.
2022-04-04 13:06:58 +05:30
Arsalan
f525137f46 fix: Added DragContainer in all modes for tooltip. 2022-04-04 12:43:04 +05:30
Ankita Kinger
a1942ccfee
chore: Improve UX on admin settings page (#12279)
* improved the UX on admin settings page

* added check for value containing only spaces

* implemented suggestions from PR

* implemented suggestion on the PR

* changed logic for checking mandatory fields is not empty

* removed unused import

* updated documentation links for google & github

* using css variables
2022-04-04 12:37:12 +05:30
Tolulope Adetula
c157c5fa72 fix: align Table widget URL Column type 2022-04-04 07:54:25 +01:00
Tolulope Adetula
2bce6d090e fix: failing tests 2022-04-04 07:08:40 +01:00
dependabot[bot]
0689e2d7a0
chore(deps): bump color-string from 1.5.4 to 1.9.0 in /app/client (#12044)
Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.4 to 1.9.0.
- [Release notes](https://github.com/Qix-/color-string/releases)
- [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Qix-/color-string/compare/1.5.4...1.9.0)

---
updated-dependencies:
- dependency-name: color-string
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-04-04 11:24:51 +05:30
dependabot[bot]
b7f09c4e20
chore(deps): bump jszip from 3.6.0 to 3.7.1 in /app/client (#8173)
Bumps [jszip](https://github.com/Stuk/jszip) from 3.6.0 to 3.7.1.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/master/CHANGES.md)
- [Commits](https://github.com/Stuk/jszip/compare/v3.6.0...v3.7.1)

---
updated-dependencies:
- dependency-name: jszip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-04-04 11:23:15 +05:30
Paul Li
dfd3662bd1 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-04 13:27:03 +08:00
Tolulope Adetula
3fb3eff92e
Merge pull request #12324 from appsmithorg/fix/default-value-for-select-widget
fix: default value consistency issues in select widget
2022-04-04 06:20:01 +01:00
Tolulope Adetula
be39074862 revert unnecessary changes 2022-04-04 06:18:03 +01:00
Tolulope Adetula
880cb75b3c fix: select dropdown 2022-04-04 06:12:33 +01:00
f0c1s
50a8e1441c
fix: show errors from git status (#12440)
* fix: show errors from git status
* fix: review comments
2022-04-04 12:55:19 +08:00
f0c1s
26745c6128
feat: update list segment header (#12530)
* fix: update ListSegmentHeader
* chore: add tests for change
2022-04-04 12:55:00 +08:00
Aswath K
ead200859c
feat: Make property title not focusable with keyboard (#12489) 2022-04-03 18:44:30 +02:00
Aishwarya-U-R
7a7169e8c3
test: Cypress tests to include Deploy mode verifications + few flaky fixes (#12444) 2022-04-03 18:43:20 +02:00
rashmi rai
6e26065865
fix: fetchOptionsCondtionally (#12347) 2022-04-03 16:41:59 +00:00
Nayan
797f1c0788
chore: removed feature flag for app template (#12485)
Removed feature flag for templates as we're planning to go live
2022-04-03 10:07:59 +06:00
Paul Li
bbf7f12e4b Merge branch 'release' into feat/4182-form-detect-changes 2022-04-02 23:35:10 +08:00
Paul Li
842e330db3 feat: Internal property to detect changes in a form
-- Change updateCodeInput command to testJsontext
2022-04-02 23:33:14 +08:00
Arsalan
abe304152c Merge branch 'release' into fix/button-group-undo 2022-04-02 18:07:58 +05:30
Paul Li
cc9db789b2 feat: Internal property to detect changes in a form
-- Fix a Cypress test case in Entity_Explorer_DragAndDropWidget_spec.js
2022-04-02 08:13:17 +08:00
ashit-rath
14689c46bf
fix: old list widgets incorrect page size (#12443) (#12490)
(cherry picked from commit 50efc68fd3)

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
2022-04-01 22:23:28 +05:30
Paul Li
9590e0fc7a Merge branch 'release' into feat/4182-form-detect-changes 2022-04-02 00:13:16 +08:00
Paul Li
e25b5da732 feat: Internal property to detect changes in a form
-- Fix on failed test cases in Entity_Explorer_Widgets_Copy_Delete_Undo_spec and Entity_Explorer_Widgets_Copy_Paste_Delete_Undo_Keyboard_Event_spec
2022-04-02 00:11:54 +08:00
Paul Li
78e452634e
feat: Progress bar widget enhancements (#12053)
* feat: Progress bar widget enhancements

-- Scaffold the widget for the first time

* feat: Progress bar widget enhancements

-- Change widget icon

* feat: Progress bar widget enhancements

-- Build property pane

* feat: Progress bar widget enhancements

-- Add a missing property, counterClockwise
-- Rename some properties

* feat: Progress bar widget enhancements

-- Build the first MVP of the widget

* feat: Progress bar widget enhancements

-- Reset rows to 4

* feat: Progress bar widget enhancements

-- Add Cypress test cases

* feat: Progress bar widget enhancements

-- Limit value by ranging from  0 to 100

* feat: Progress bar widget enhancements

-- Make isIndeterminate property not to be JS convertible
-- Hide progress bar and circular progress widget icon from entity explorer

* feat: Progress bar widget enhancements

-- Place indeterminate circular progress to be 100% fit into the container

* feat: Progress bar widget enhancements

-- Show result without rounding for the circular type

* feat: Progress bar widget enhancements

-- Comment out ProgressBar_spec.js

* feat: Progress bar widget enhancements

-- Remove circular progress and progressbar widgets from allowed list for list widget

* feat: Progress bar widget enhancements

-- Move ProgressBar_spec into CommentedScriptFiles directory
2022-04-02 00:02:19 +08:00
rahulramesha
5dd2f444aa
feat: Multi widget reflow (#10813)
feature for group reflow
2022-04-01 20:27:03 +05:30
Bhavin K
e4f1737bca
fix: onclick handler update in ButtonGroup Widget to resolve onClick (#12442) 2022-04-01 19:24:40 +05:30
rashmi rai
b1215c8179
fix: evaluation order on first load (#12022) 2022-04-01 13:16:59 +00:00
Sumit Kumar
c2f39f4eda
feat: [server side change only] convert Mongo's form data to raw / native query (#10058) 2022-04-01 18:44:32 +05:30
Ankita Kinger
947f836a5a
fix: sending query params on redirection from signup to login page (#12501)
* sending query params on redirection from signup to login page

* optimized the code
2022-04-01 16:57:49 +05:30
f0c1s
e69e6e0670
test: Fix failing git sync tests (#12488) 2022-04-01 16:55:56 +05:30
Paul Li
69f5c65518 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 18:40:17 +08:00
Paul Li
2b00f1cdf9 feat: Internal property to detect changes in a form
-- Fix on typo add missing assertion for hasChanges on the spec files
2022-04-01 18:38:35 +08:00
Arsalan
6bbe506d9b Merge branch 'release' into fix/bindPathList-error 2022-04-01 15:30:55 +05:30
Arsalan
97080b2393 fix: small test cases refactor. 2022-04-01 15:30:00 +05:30
Abhinav Jha
68065f8789
feat: activity logging (#12383)
* Add activity logging mechanism in client
2022-04-01 09:55:58 +00:00
Arsalan
9ccdde3b1b Merge branch 'release' into fix/button-group-undo 2022-04-01 14:28:01 +05:30
dependabot[bot]
b39190ad57
chore: bump spring-core from 5.3.15 to 5.3.18 in /app/server/appsmith-plugins/googleSheetsPlugin (#12471)
Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.3.15 to 5.3.18.
- [Release notes](https://github.com/spring-projects/spring-framework/releases)
- [Commits](https://github.com/spring-projects/spring-framework/compare/v5.3.15...v5.3.18)

---
updated-dependencies:
- dependency-name: org.springframework:spring-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 14:18:34 +05:30
dependabot[bot]
088e9f07f0
chore: bump jackson-databind from 2.12.6 to 2.12.6.1 in /app/server/appsmith-plugins/googleSheetsPlugin (#12403)
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.6 to 2.12.6.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 14:17:23 +05:30
dependabot[bot]
1d835dfadb
chore: bump jackson-databind from 2.10.5.1 to 2.12.6.1 in /app/server/appsmith-plugins/restApiPlugin (#12401)
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.5.1 to 2.12.6.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 14:16:59 +05:30
dependabot[bot]
1e50701075
chore: bump jackson-databind from 2.12.6 to 2.12.6.1 in /app/server/appsmith-plugins/snowflakePlugin (#12402)
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.6 to 2.12.6.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 14:16:10 +05:30
dependabot[bot]
d432fb5f32
chore: bump react-dev-utils from 11.0.1 to 11.0.4 in /app/client (#9503)
Bumps [react-dev-utils](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-dev-utils) from 11.0.1 to 11.0.4.
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG-1.x.md)
- [Commits](https://github.com/facebook/create-react-app/commits/HEAD/packages/react-dev-utils)

---
updated-dependencies:
- dependency-name: react-dev-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-04-01 14:05:33 +05:30
Paul Li
afb7b40a44 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 15:44:55 +08:00
Paul Li
0a8b0dfe9a feat: Internal property to detect changes in a form
-- Fix on failed test cases because of newly added hasChanges meta property
2022-04-01 15:42:05 +08:00
dependabot[bot]
de6dbc17ae
chore: bump spring-core from 5.2.3.RELEASE to 5.3.18 in /app/server/appsmith-plugins/restApiPlugin (#12472)
Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.2.3.RELEASE to 5.3.18.
- [Release notes](https://github.com/spring-projects/spring-framework/releases)
- [Commits](https://github.com/spring-projects/spring-framework/compare/v5.2.3.RELEASE...v5.3.18)

---
updated-dependencies:
- dependency-name: org.springframework:spring-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 12:57:47 +05:30
dependabot[bot]
e7f0e5b7b0
chore: bump spring-core from 5.2.3.RELEASE to 5.3.18 in /app/server/appsmith-plugins/jsPlugin (#12473)
Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.2.3.RELEASE to 5.3.18.
- [Release notes](https://github.com/spring-projects/spring-framework/releases)
- [Commits](https://github.com/spring-projects/spring-framework/compare/v5.2.3.RELEASE...v5.3.18)

---
updated-dependencies:
- dependency-name: org.springframework:spring-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 12:57:07 +05:30
dependabot[bot]
ad910fe03e
chore: bump spring-core from 5.2.3.RELEASE to 5.3.18 in /app/server/appsmith-plugins/saasPlugin (#12475)
Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.2.3.RELEASE to 5.3.18.
- [Release notes](https://github.com/spring-projects/spring-framework/releases)
- [Commits](https://github.com/spring-projects/spring-framework/compare/v5.2.3.RELEASE...v5.3.18)

---
updated-dependencies:
- dependency-name: org.springframework:spring-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 12:54:22 +05:30
Tolulope Adetula
ed7369493f fix: use default HTML ellipsis 2022-04-01 08:07:25 +01:00
Ayangade Adeoluwa
4c2b4529c5
fix: Fixes issue with initial values (#12441)
* Fixes issue with initial values

* Allow empty commit
2022-04-01 08:06:46 +01:00
Arsalan
38756753e8 Merge branch 'fix/bindPathList-error' of https://github.com/appsmithorg/appsmith into fix/bindPathList-error 2022-04-01 12:12:53 +05:30
dependabot[bot]
92cf99f025
chore: bump spring-core from 5.2.3.RELEASE to 5.3.18 in /app/server/appsmith-plugins/snowflakePlugin (#12474)
Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.2.3.RELEASE to 5.3.18.
- [Release notes](https://github.com/spring-projects/spring-framework/releases)
- [Commits](https://github.com/spring-projects/spring-framework/compare/v5.2.3.RELEASE...v5.3.18)

---
updated-dependencies:
- dependency-name: org.springframework:spring-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 12:11:20 +05:30
Arsalan
bdbfbd7f9d Merge branch 'release' into fix/bindPathList-error 2022-04-01 12:03:00 +05:30
dependabot[bot]
b440798dcd
chore(deps): bump node-forge from 1.1.0 to 1.3.0 in /app/client (#12191)
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.1.0 to 1.3.0.
- [Release notes](https://github.com/digitalbazaar/forge/releases)
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](https://github.com/digitalbazaar/forge/compare/v1.1.0...v1.3.0)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-01 11:54:59 +05:30
Bhavin K
5124ae0322
fix: onclick handler update in ButtonGroup Widget (#12442) 2022-04-01 11:28:51 +05:30
Ankita Kinger
5b614447b9
fix: Show restricted signup error message on login screen (#11974)
* adding restricted signup message on login screen too

* checking if error value if not true
2022-04-01 10:50:09 +05:30
Tolulope Adetula
4911aa3b65 fix 2022-04-01 06:10:51 +01:00
Tolulope Adetula
d6ee01ca29 Merge branch 'release' into fix/Multiselect-style-specificity 2022-04-01 05:25:20 +01:00
Tolulope Adetula
dabbbb0084 fix: css specitifity in MultiTreeSelect 2022-04-01 05:11:37 +01:00
Tolulope Adetula
b185119a79 revert css fix 2022-04-01 05:00:19 +01:00
Tolulope Adetula
9982593545 improve css specitifity 2022-04-01 04:58:17 +01:00
Ankur Singhal
102a7f3c04 toggle on pressing enter 2022-04-01 04:37:12 +05:30
Paul Li
6d744859c6 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 04:14:05 +08:00
Paul Li
5bb926d6ed feat: Internal property to detect changes in form
-- Fix on the wrong widget name in RichTextEditor_spec.js
-- Replace selectors so that Cypress can interact with UI in Select_spec.js
2022-04-01 04:07:22 +08:00
Tolulope Adetula
b65c0a21b7 fix: replace memoised value with state 2022-03-31 19:19:58 +01:00
Ayangade Adeoluwa
3f2b87b044
Fix issue with oauth2 save and authorize button (#12447) 2022-03-31 18:59:05 +01:00
Ankur Singhal
d7db15cb60 added manual click handlers for bottom bar 2022-03-31 22:28:05 +05:30
Anagh Hegde
f03a163a38
feat: Export application with datasource configuration for sample apps and templates (#12310)
* Expose a way to export crdentials for sample apps and templates

* Export application with creds if marked as exportableWithCred in application object

* Fix and add testcases

* Add comments

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2022-03-31 21:56:18 +05:30
arunvjn
7575756d09
fix: remove encoding of branch name with / in it (#12439) (#12455)
(cherry picked from commit 4b462ae623)
2022-03-31 21:54:11 +05:30
Tolulope Adetula
da397d32f4 fix: css dropdown for multiselect 2022-03-31 17:19:29 +01:00
Paul Li
dc7b9a8b95 Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-01 00:18:16 +08:00
Paul Li
3d5e443eb0 fix: Disabled button widget tooltips stay open
-- Fix on the wrong selector on deploy
2022-04-01 00:16:12 +08:00
arunvjn
4b462ae623
fix: remove encoding of branch name with / in it (#12439) 2022-03-31 17:11:31 +02:00
ashit-rath
50efc68fd3
fix: old list widgets incorrect page size (#12443) 2022-03-31 17:09:21 +02:00
Ankita Kinger
165c911612
chore: Added jest tests for admin settings form fields (#12413)
* added unit test case for tag input field on admin settings page

* added test case for text input component

* added test cases for toggle, accordion and disconnect service components

* added remaining unit test cases related to admin settings

* removed unused imports
2022-03-31 20:05:01 +05:30
Nayan
085b4a3a15
fix: Update admin settings permission from users when they are added or re… (#11770)
Update user permission when email address is added as admin email from settings page.
2022-03-31 20:17:47 +06:00
Trisha Anand
f51da7019d
chore: Adding delete endpoint in ConfigService (#12450) 2022-03-31 19:02:54 +05:30
Abhijeet
28e071b339
fix: Update serialization for map datatype to have predictable order for committing to git (#12373)
* Update serialization for map datatype to have a predictable order

* Refactor
2022-03-31 18:36:40 +05:30
Paul Li
4940d197b5 Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-03-31 20:24:50 +08:00
NandanAnantharamu
015c455603
test: enhancement tests for captcha (#12245)
* Enhancement tests for captcha

* Added few more usecases
2022-03-31 17:49:39 +05:30
Aishwarya-U-R
9bbd671b3f
test: Automated few tests for AForce Migration scenarios + Flaky fixes (#12231) 2022-03-31 17:21:08 +05:30
Anand Srinivasan
186a97c699
fix: trigger fields linting issue (#11875)
* initial fix

* fix warnings

* log evaluation order length

* log time

* logs

* re-order

* rename

* onclick vs release logs

* unit test for loading properties

* clean up

* ends with .tableData

* add comment
2022-03-31 17:07:18 +05:30
Abhinav Jha
2cd7dc9d88
Remove all references to WidgetIcons, as the icons now come from the individual widget folders (#12334)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-31 10:07:37 +00:00
Paul Li
c582ad22da Merge branch 'release' into feat/4182-form-detect-changes 2022-03-31 17:53:50 +08:00
Tolulope Adetula
a44e7b3f24 Merge branch 'release' into fix/default-value-for-select-widget 2022-03-31 09:31:47 +01:00
Tolulope Adetula
c0569b4a76 Fix: table widget scroll issue 2022-03-31 09:23:07 +01:00
arunvjn
27a2cb588d
Incorrect page list in deployed branches (#12416) (#12424)
(cherry picked from commit 7f390d0c00)
2022-03-31 13:45:23 +05:30
Aswath K
dfa788cfab
fix: patches blueprint's popover (#12213)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-31 13:27:06 +05:30
arunvjn
7f390d0c00
fix: Incorrect page list in deployed branches (#12416) 2022-03-31 13:21:20 +05:30
dependabot[bot]
a596d7101f
chore(deps): bump minimist from 1.2.5 to 1.2.6 in /app/client (#12203)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-03-31 11:48:28 +05:30
dependabot[bot]
f310b4b294
chore: bump plist from 3.0.4 to 3.0.5 in /app/client (#12278)
Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/TooTallNate/node-plist/releases)
- [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md)
- [Commits](https://github.com/TooTallNate/node-plist/commits)

---
updated-dependencies:
- dependency-name: plist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-03-31 11:47:35 +05:30
Tolulope Adetula
2267a79899 Merge branch 'release' into fix/table-widget-scroll-issue 2022-03-31 07:13:44 +01:00
ashit-rath
8bdd631ee3
JSON form autogenerate control tooltip content changes (#12208) 2022-03-31 11:36:26 +05:30
akash-codemonk
73c5267d13
chore: Templates UI updates (#11775) 2022-03-31 10:46:04 +05:30
Bhavin K
2b47e00a71
fix: add overflow property in text-widget (#12160) 2022-03-31 10:18:51 +05:30
Bhavin K
e5208b090e
fix: updated word-break for modal only (#12192) 2022-03-31 10:15:58 +05:30
ashit-rath
f8aaa2179f
fix: JSONForm date field tooltip visibility (#12299) 2022-03-31 08:32:57 +05:30
balajisoundar
ffc0f0e72f
fix: Currency input widget rounding off value if there is a trailing zero a… (#12325) 2022-03-31 08:31:04 +05:30
balajisoundar
52646de9bd jest test for setWidgetDynamicPropertySaga function 2022-03-31 08:19:10 +05:30
Shrikant Sharat Kandula
72ee8e7296
Add UsagePulse API, create-only (#12340)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-03-31 06:00:11 +05:30
Paul Li
965876b01f Merge branch 'release' into feat/4182-form-detect-changes 2022-03-30 23:20:29 +08:00
Paul Li
44685835ce feat: Internal property to detect changes in a form
-- Reset isDirty if defaultText is changed in PhoneInputWidget
-- Enable reset if defaultText is not empty in RichTextEditorWidget
2022-03-30 23:15:44 +08:00
akash-codemonk
3f5092307d
chore: update text in admin settings page (#12400) 2022-03-30 20:40:06 +05:30
Arpit Mohan
6dcc00a9f4
ci: Moving the runs-on parameter in some Github workflows to use Buildjet (#12399) 2022-03-30 20:39:34 +05:30
Paul Li
93ae266672 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-30 21:45:40 +08:00
Tolulope Adetula
17a206c3dd
Merge pull request #12138 from appsmithorg/fix/multiselect-prepopulate-value-with-number
fix: Allow Multiselect DefaultValue to accept numbers
2022-03-30 14:33:59 +01:00
Parthvi12
d2ac617850 test: update visual regression tests (#12165)
* updating screenshots as per new entity explorer

* commenting after hook of git_spec

* fix tests

* updating GOOGLE_SIGNUP_SETUP_DOC and GITHUB_SIGNUP_SETUP_DOC urls
2022-03-30 15:29:09 +02:00
Favour Ohanekwu
5b52405210
Support evaluated value in nested property paths (#12341) 2022-03-30 14:28:19 +01:00
Parthvi12
633d8674ee
test: update visual regression tests (#12165)
* updating screenshots as per new entity explorer

* commenting after hook of git_spec

* fix tests

* updating GOOGLE_SIGNUP_SETUP_DOC and GITHUB_SIGNUP_SETUP_DOC urls
2022-03-30 15:27:09 +02:00
Paul Li
a1884e1336
feat: Hide shadows of hiddens objects during page loading in deploy view (#12184)
-- Does not render children of which isVisible is true in view mode
2022-03-30 21:22:01 +08:00
Ankur Singhal
75a3e9262a close picker on pressing enter on time fields 2022-03-30 18:46:48 +05:30
Ayangade Adeoluwa
1cd8dde12c
feat: uses codemirror to display query results (#11312)
* uses codemirror to display query results

* Add finishing touches to codemirror component

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-30 13:12:15 +00:00
Preet Sidhu
c9069bedce
Merge pull request #11673 from appsmithorg/fix-11468_dropdown_performance
fix: 11468 select widget performance on a large data set.
2022-03-30 18:41:59 +05:30
akash-codemonk
9cbabfb028
chore: Remove limit update step in guided tour (#11475) 2022-03-30 18:41:41 +05:30
Ayangade Adeoluwa
5e8a425038
feat: Revamp datasource form buttons (#11924)
* Revamp datasource form buttons

* Fix issues

* Use default values for individual form plugin

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-30 13:11:25 +00:00
Bhavin K
9f246f7d7a
fix: updated internal selectedDate condition (#12268)
* fix: updated internal selectedDate condition

* fix: updated cypress test case
2022-03-30 13:11:10 +00:00
Preet Sidhu
5cf633ba8d
Merge pull request #11812 from appsmithorg/fix-10771_text_widget_warning
fix: 10771 show text widget warning on exceeding line breaks limit
2022-03-30 18:40:51 +05:30
Abhijeet
d9b2a747df
chore: Add git discard and pull documentation url for status API response (#11869)
* Added discard doc url for status API response
2022-03-30 13:10:38 +00:00
Bhavin K
806759d266
fix: added backdrop for menubutton (#12199) 2022-03-30 13:10:22 +00:00
Nidhi
06300a1758
fix: Using blobs for multipart data (#12240) 2022-03-30 13:10:05 +00:00
Ayangade Adeoluwa
7bcab0da15
Fix allignment issues on api response tabs (#12316) 2022-03-30 13:09:44 +00:00
Arpit Mohan
6a3ec51287 Merge branch 'master' into release-300322 2022-03-30 12:33:15 +02:00
Paul Li
076c542f64 fix: Disabled button widget tooltips stay open
-- Change the existing test case so as to be tested on deploy
2022-03-30 18:10:51 +08:00
Paul Li
54e925996a Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-03-30 17:59:06 +08:00
haojin111
44400caa60
Merge pull request #12361 from appsmithorg/fix/12163-gsheet-authentication-failing-when-importing-app
fix: 12163 gsheet authentication failing when importing app with one gsheet datasource
2022-03-30 17:55:53 +08:00
Paul Li
2ac3cff977 fix: Even disabled button tooltip should show
-- Introduce AnchorButton for the disabled button with a tooltip
2022-03-30 17:51:07 +08:00
Anagh Hegde
98c69868f1
fix: Fix binding for APIs during git import (#12357)
* Add org id for the actions during git import

* Updated the test resource
2022-03-30 12:44:09 +05:30
haojin111
8ded371162 fixed issue of redirecting with one oauth authentication 2022-03-30 14:37:34 +08:00
Tolulope Adetula
5a87430e6a fix: table widget scroll when not needed 2022-03-30 01:40:56 +01:00
haojin111
b265ac2fd5
fixed redirection on google authorisation in reconnect modal (#12350)
Co-authored-by: arunvjn <arun@appsmith.com>
2022-03-29 22:24:30 +05:30
arunvjn
f8de567cc8
fix: oauth login flow for new users (#12326) 2022-03-29 17:30:30 +05:30
haojin111
d3265437e6
fix: 12248, 12249, 12252 - issues of reconnect datasource modal (#12287)
* fixed issue of test button function on reconnect modal

* fixed issue of scrolling hiden in authenticated api  on reconnect modal

* fixed issue of scrolling rest api datasource form
2022-03-29 17:26:29 +05:30
Pawan Kumar
e7498f2808
change container height to 100vh (#12317)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-03-29 15:13:02 +05:30
Tolulope Adetula
6aa2c36ea4 fix: test failure 2022-03-29 08:55:19 +01:00
Tolulope Adetula
e89c454ce5 fix: add cypress tests 2022-03-29 08:39:34 +01:00
Tolulope Adetula
a12c183c12 fix: default value consistency issues in select widget 2022-03-29 08:07:01 +01:00
arunvjn
23c12f4afc
fix: URL slugs in duplicate, import and export operations. (#12283)
* Persists modal to show info when update is in progress
2022-03-28 18:30:05 +00:00
Nikhil Nandagopal
b80e536a71
Update crud template (#12298)
* Updated Template

* Updated Template

* Updated Template

* Updated Template

* Updated Template

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2022-03-28 18:59:46 +05:30
Arsalan
d18ee573cb fix: Merge conflicts Resolved. 2022-03-28 18:21:06 +05:30
Preet
8734ae04f3 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-28 15:25:05 +05:30
Preet
738215931b Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-28 15:24:00 +05:30
Pallav Agarwal
b019fbae6f
fix: iframe srcDoc was not able to postMessage that can be received by onMessageReceived event. Match iframe by object not origin (#11809) 2022-03-28 13:12:12 +05:30
Paul Li
35b1546f78
fix: Button group widget's pop-over/drop-down enlarged along the width of the parent (#11804)
* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Implement dynamic width calculation

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add corresponding Cypress test cases

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add min-width CSS property for popover

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add a comment for minPopoverWidth

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Remove the comment for minPopoverWidth

* feat: Button group widget's pop-over/drop-down enlarged along the width

-- update the state variable, itemWidths inside setTimeout to access the updated DOM

* fix: Button gruop widget's pop-over/drop-down enlarged along the width

-- Refine update logic

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Make code DRY by creating createMenuButtonRefs and getMenuButtonWidths methods

* fix: Button group widget's popover/dropdown enlarged along the width

-- Make every popover class name unique

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Rewrite Cypress test

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Eliminate unnecessary test case from ButtonGroup_spec
2022-03-28 12:44:40 +05:30
Preet
d456df8cf6 Merge branch 'release' into fix-11468_dropdown_performance 2022-03-28 12:01:15 +05:30
Preet
28fc96b020 undo common locators lint fix 2022-03-28 12:01:02 +05:30
Preet
0e5602e47e create an object for inline style 2022-03-28 11:33:43 +05:30
Ankita Kinger
62f39c1e8c
fix: Update success message for reset password link sent (#12147)
* updated success message for reset password link sent

* resetting the form if email value gets updated

* minor change in message

* fixed issue when email parameter exists

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-28 11:33:22 +05:30
Aswath K
5330437d1a
feat: Makes jsToggle keyboard accessible (#12048)
* Makes jstoggle keyboard accessible

* fix cypress locator
2022-03-28 11:21:52 +05:30
Parthvi12
794c0f2299
test: add test for git sync bug #10773 (#12267)
* added test for git sync bug and fixed flaky tests

* updating git test
2022-03-28 10:40:07 +05:30
Preet
88e326d878 Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-28 10:22:02 +05:30
Preet
2143346783 Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-28 10:21:13 +05:30
haojin111
a7934f78fa
fix: scrolling issue of git connection tab (#11813)
Creates a margin which allows scrollbar to appear on top of the content and fixes issue.
2022-03-28 09:05:11 +05:30
haojin111
e6466e1758
fix: OAuth authorization issue (#12183) 2022-03-28 09:03:32 +05:30
arunvjn
bf1d9efc2a
chore: Move url builder functions into RouteBuilder.ts (#12265) 2022-03-27 21:55:08 +05:30
rashmi rai
bfd96334af
fix: where clause improvements (#11748) 2022-03-27 19:10:48 +05:30
Tolulope Adetula
bed6834a2f Merge branch 'release' into fix/multiselect-prepopulate-value-with-number 2022-03-27 07:07:07 +01:00
Tolulope Adetula
71284e2fc9 fix: add default error message 2022-03-27 07:06:34 +01:00
Mojtaba
5cac8cb3b9
feat: Add Array type to MultipartFormDataType variants for REST api (#11386)
* feat: Add Array type to MultipartFormDataType variants
 and handle every item in list as a part in multipart request

* fix: add array options

* fix: rename file to  array value

* fix: parse Array from json text

* fix: reformat the code and remove `System.out.println`

* fix: testParseMultipartArrayDataWorks is more accurate now

Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-26 20:08:55 +01:00
haojin111
185fe2d0ed
Merge pull request #12212 from appsmithorg/fix/11499-issue-of-commenting-pos-on-canvas
fix: 11499 - position issue of comment on canvas
2022-03-26 23:55:12 +08:00
haojin111
2db560d772
Merge pull request #11814 from appsmithorg/feat/11780-add-scrolling-repo-limit-modal
feat: added scrollbar to repo limit error modal
2022-03-26 23:48:01 +08:00
haojin111
2b862b9b3f
fix: maximize file import card when git import card is not available 2022-03-26 15:33:10 +00:00
haojin111
a0b6ee5a5b Merge branch 'release' into feat/11780-add-scrolling-repo-limit-modal 2022-03-26 21:54:10 +08:00
Preet
fb48aca05d fix prettier issue 2022-03-26 16:30:31 +05:30
haojin111
b442663131 Merge branch 'release' into fix/11499-issue-of-commenting-pos-on-canvas 2022-03-26 17:08:52 +08:00
haojin111
c43d680736
Merge pull request #12136 from appsmithorg/fix/12084-airtable-auth-issue-in-git-import
fix: 12084 - fixed issue of airtable authorize on reconnect modal
2022-03-26 14:28:53 +08:00
Abhijeet
b13cf320f0
chore: Add manual and auto update fields within application object to distinguish between the migration related changes (#12099) 2022-03-26 10:40:59 +05:30
Ankita Kinger
665be7f214
fix: Added routing for admin settings page in App Header (#12262) 2022-03-26 10:40:35 +05:30
Aishwarya UR
f8b66444e0 Merge branch 'release' into fix/12084-airtable-auth-issue-in-git-import 2022-03-26 09:28:06 +05:30
Preet Sidhu
74def3bb98
Merge branch 'release' into fix-11468_dropdown_performance 2022-03-25 16:45:14 +05:30
Preet
4b14f2bf4f fix merge conflicts 2022-03-25 16:44:12 +05:30
albinAppsmith
5994837f3d
* Generate page - dropdown slected option alignment fix (#12139) 2022-03-25 16:42:04 +05:30
Preet
16bea463e7 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:34:40 +05:30
arunvjn
69c09c03aa
feat: adding slug names in urls (#10957)
* Init commit clean urls

* Changes to builder route

* Refactored URLs

* Remove default params from url builder functions.

* Fixed more urls

* Changed selector name

* Minor url correction

* Type fixes

* Jest fixes

* Fixed routing for old published apps

* Fixed url slug replace

* page-1 -> page1 as default page slug name

* Remove application id from init editor calls

* Use default page slug

* Added comments and placeholder values for slug names

* variable rename

* Removed redirection and added back the old routes

* Prevent page slug name recompute

* Fixed home page load in view mode

* Added null checks

* Fixed jest test

* Fixed jest test

* Update URL slugs when app/page name changes

* Added unit tests and updates types

* Removed unused code

* * Removed duplication fetch page call.
* Fixes #11354
* Fixed sign up flow

* Refactored initializeEditorSaga

* Fixed warnings

* Fixed integrations screen URL bugs

* Cypress fixes

* Fixed slug names in copy/move operations and pages screen

* Minor refactor

* Fixed page highlight bug in published apps

* Added new url factory and middleware to store url params

* Changed store to default export and fix unit tests

* Fixed slugs unit test

* Minor fixes

* Fixes #11379

* Fixed set as home page feature

* Updated types

* app id adjustments for cypress

* Fixed bad merge

* Refactored routes to functional component

* * Fixed EE active entity highlight.
* Remove unused code in editor router.

* jest fix

* Mock history to prevent security errors

* constant rename

* Removed console logs

* Fixed page id regex

* Do not check for /pages in url

* Fixed missing pageId on quick edit/deploy clicks

* Missed files from previous commit

* Fixed warnings

* Fixed jest test

* New api integration

* feat: Add applicationVersion property to Application (#11626)

Added a new property to Application object - applicationVersion. This property can be used to identity when there is a breaking change and can not be solved with migration. FE will use this property to detect such conditions. Another API is added to migrate the applicationVersion to latest version when user migrates the breaking changes.

* Added manual upgrade modal.

* Test fix

* Fixed jest test

* function rename

* Fix deploy error

* Added null check

* Changes to persist URL search params when redirecting

* Added updates tooltip

* More unit test cases

* Fixed git url redirection

* Fix warning

* Fixed evaluation on upgrade

* Fixed warnings

* File rename

* Added cypress for clean urls

* Fixed import/export/fork cypress

* Cypress api server fixes

* Fixed mongo spec

* Fixed replay spec

* Fixed comments spec

* More cypress fixes

* Fixed tooltip in update btn

* Text size changes

* Minor fixes

* Jest test fix

* Fixed type error

* Fixed warnings

* Fixed todo comments

* Moved description to constants file

* Fixed cypress CI run crash

* Fixes git cypress failures

* Import/Export cypress test fixes

* Import export fork cypress fixes

* Explorer test fix

* Switch branch test fix

* Added applicationVersion in export app json

* Calls plugin forms in parallel

* Fixed warnings

* Fixed warning

* Import export CI fixes

* Reverts previous changes

* Fixes import export

* Fixed import export cypress URL verification

* Pass applicationVersion when duplicating application

* Cypress fix

* Dummy commit

Co-authored-by: Nayan <nayan@appsmith.com>
2022-03-25 16:13:26 +05:30
Preet
6902255b72 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:06:37 +05:30
Arsalan
824a89caca fix: remove alert. 2022-03-25 15:42:57 +05:30
Arsalan
f0de3c6457 fix: remove bindingPathList properties on jstoggle off. 2022-03-25 15:25:01 +05:30
Paul Li
d001aa81c5 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-25 17:29:04 +08:00
haojin111
3b7653e3d9 updated position of comment pin along with container property 2022-03-25 17:11:23 +08:00
Ayangade Adeoluwa
4fb492ee60
Fix flickering confirmation modal (#12211)
Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-25 13:52:23 +05:30
dependabot[bot]
9e14682765
chore: bump minimist from 1.2.5 to 1.2.6 in /app/util/plugin-generation (#12242)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-25 12:12:36 +05:30
Arpit Mohan
4328369c68
chore: Adding the package.json file to plugin-generation folder (#12039) 2022-03-25 12:11:14 +05:30
Aishwarya-U-R
f68bdaa453
test: Skip Git flaky test to unblock CI (#12238)
* Commenting git flaky

* BindApiWIthlistWidget validaton fix

* BindApiWIthlistWidget validaton fix

* SwitchGroup spec fix

* command.js change
2022-03-25 12:04:23 +05:30
Ankur Singhal
45bc4b71f2 added escape when picker is focused 2022-03-25 03:35:21 +05:30
Aishwarya-U-R
761e697da8
test: Automated tests improvements for Mongo CRUD cases + few flaky fix (#11985)
* Adding AForceMigration spec

* Merge from release

* Mongo CRUD data load check added

* Added bug id & adding to skip to checkin

* Unskipping MySQL_Spec to test TED

* Api-bugs spec fix

* Adding back MySQL_Spec to ignore

* EE_CopyQuery_RenameDatasource_spec revert to fix

* Skipping Git_sync flaky test

* Removing mySQl from ignore

* Unskipping Mongo cases as Bug12162 fixed

* Empty files moved due to Mocha update
2022-03-25 01:04:28 +05:30
Favour Ohanekwu
6f7b6b2999
fix reload of page on debug-button click (#12002) 2022-03-24 16:48:54 +01:00
Preet
7b8a950b95 Merge branch 'release' into fix-10771_text_widget_warning 2022-03-24 20:46:18 +05:30
Sumit Kumar
40f4e3c755
fix: S3 plugin: provide support for MinIO (#11766)
* update option label

* add minIO as a separate datasource option
add datasource connection changes to support minIO without SSL and when using CA signed certificates

* fix cypress tests
2022-03-24 18:28:00 +05:30
Preet
5b6d7623cc fix filter text 2022-03-24 18:27:39 +05:30
Arpit Mohan
8eea57358c
chore: Upgrading mocha dependencies (#12085) 2022-03-24 18:25:24 +05:30
Arpit Mohan
95e1b545ac
chore: Upgrading the puppeteer dependency in perf folder (#12042) 2022-03-24 18:24:39 +05:30
Daniel
fd42a8ae69
fix: reorder the advanced settings form (#12193) 2022-03-24 12:44:18 +00:00
Preet
19c7786388 fix auto height of virtual list 2022-03-24 18:04:01 +05:30
Sumit Kumar
027161e033
fix smart substitution setting toggle fetch method and path. (#12181)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-24 17:55:32 +05:30
Yash Vibhandik
08f5347b72
fix: #8911 auto complete property updated (#10679)
* fix: #8911 auto complete property updated

* test: updated cypress test

* fix : update cypress

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-03-24 17:42:22 +05:30
Tolulope Adetula
fafc208e97
Merge pull request #12141 from appsmithorg/fix/filterText-in-autocomplete
fix: Select Widget autocomplete
2022-03-24 13:03:59 +01:00
akash-codemonk
7443c16e59
fix: show the error message received from the server when sending test email fails (#11972) 2022-03-24 16:50:43 +05:30
Sumit Kumar
a486474483
rename variable. (#12204) 2022-03-24 16:38:52 +05:30
Nidhi
c3554f79b5 fix: Modified import export flow to use valid names for actions (#11879)
* fix: Modified import export flow to use valid names for actions

* Added test
2022-03-24 11:47:48 +01:00
dependabot[bot]
c3c54b01b0
chore: bump follow-redirects in /app/server/scripts/node (#12038)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.9)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-24 15:47:11 +05:30
dependabot[bot]
c8af22e491
chore: bump follow-redirects from 1.14.7 to 1.14.9 in /app/rts (#12036)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.9)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-24 15:46:44 +05:30
dependabot[bot]
d85e3c6ef7
chore(deps): bump follow-redirects from 1.14.7 to 1.14.9 in /app/client (#12037)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.9)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-03-24 15:42:28 +05:30
Apeksha Bhosale
d0fdabaccd feat: Settings js editor (#9984)
* POC

* Closing channels

* WIP

* v1

* get working with JS editor

* autocomplete

* added comments

* try removing an import

* different way of import

* dependency map added to body

* triggers can be part of js editor functions hence

* removed unwanted lines

* new flow chnages

* Resolve conflicts

* small css changes for empty state

* Fix prettier

* Fixes

* flow changes part 2

* Mock web worker for testing

* Throw errors during evaluation

* Action execution should be non blocking on the main thread to evaluation of further actions

* WIP

* Fix build issue

* Fix warnings

* Rename

* Refactor and add tests for worker util

* Fix response flow post refactor

* added settings icon for js editor

* WIP

* WIP

* WIP

* Tests for promises

* settings for each function of js object added

* Error handling

* Error handing action validation

* Update test

* Passing callback data in the eval trigger flow

* log triggers to be executed

* WIP

* confirm before execution

* Remove debugging

* Fix backwards compatibility

* Avoid passing trigger meta around

* fix button loading

* handle error callbacks

* fix tests

* tests

* fix console error when checking for async

* Fix async function check

* Fix async function check again

* fix bad commit

* Add some comments

* added clientSideExecution flag for js functions

* css changes for settings icon

* unsued code removed

* on page load PART 1

* onPageLoad rest iof changes

* corrected async badge

* removed duplicate test cases

* added confirm modal for js functions

* removed unused code

* small chnage

* dependency was not getting created

* Fix confirmation modal

* unused code removed

* replaced new confirmsaga

* confirmaton box changes

* Fixing JSEditor Run butn locator

* corrected property

* dependency map was failing

* changed key for confirmation box

Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-24 11:04:36 +01:00
Arsalan
543240017d fix: Merge Conflicts Resloved. 2022-03-24 15:32:21 +05:30
NandanAnantharamu
c7f3b86d8a
test: added test for recaptcha (#11805)
* Added test for Recaptcha

* updated test
2022-03-24 14:59:29 +05:30
haojin111
e4148821f6 fixed position issue of comment on canvas 2022-03-24 17:27:01 +08:00
arunvjn
bed11f4eca
fix: Open documentation CTA in omni-bar (#11954)
* Fixes broken "No Results" state in omnibar
* Adds spacing in documentation.
2022-03-24 14:47:17 +05:30
Nayan
468ed8454f
chore: Send test email error message to client (#11968)
Passes error message from server to client when there is error in send test email
2022-03-24 14:52:51 +06:00
arunvjn
6c3116b0aa
fix: unneccessary ellipsis for page names in view mode (#12032) 2022-03-24 13:14:53 +05:30
Tolulope Adetula
c82fa8fadb Merge branch 'release' into fix/multiselect-prepopulate-value-with-number 2022-03-24 08:39:49 +01:00
Tolulope Adetula
8b26bfc0c7
Merge pull request #12089 from appsmithorg/fix/MultiSelect-Default-Label-incorrectly-displayed
fix: multiselect default label issue
2022-03-24 08:37:15 +01:00
Sumit Kumar
47ad7cc9b1
feat: add JSON smart substitution feature to Firestore plugin actions
* This PR adds the JSON smart substitution feature to Firestore plugin actions.
* This smart substitution will work exactly the same way as it works for REST API actions.
* Currently, smart substitution only gets applied to the body section of Create, Set, Add or Update commands as this is the only input field that expects a JSON input type.
* It can be toggled On/Off via the Settings tab.
* It is set to On by default. However, data migration has been added to set it to Off for all existing Firestore actions so that they are not impacted by this PR's changes.
2022-03-24 13:02:54 +05:30
Paul Li
89e10add95
fix: Even disabled button tooltip should show (#12186)
-- Remove disable popover prop
2022-03-24 15:18:05 +08:00
Paul Li
c0a3bd27c8
fix: Switch group widget is crashed when selectedValues is undefined (#12095)
* fix: Switch group widget is crashed when selectedValues is undefined

-- Make selected prop for the component to return empty array if its value is falsy

* fix: Switch group widget is crashed when selectedValues is undefined

-- Add a Cypress test for the fix
2022-03-24 15:16:18 +08:00
ashit-rath
32fee08c5c
feat: JSON Form widget (#8472)
* initial layout

* updated parser to support nested array

* array field rendering

* changes

* ts fix

* minor revert FormWidget

* modified schema structure

* select and switch fields

* added checkbox field

* added RadioGroupField

* partial DateField and defaults, typing refactoring

* added label and field type change

* minor ts changes

* changes

* modified widget/utils for nested panelConfig, modified schema to object approach

* array/object label support

* hide field configuration when children not present

* added tooltip

* field visibility option

* disabled state

* upgraded tslib, form initial values

* custom field configuration - add/hide/edit

* field configuration - label change

* return input when field configuration reaches max depth

* minor changes

* form - scroll, fixedfooter, enitity defn and other minior changes

* form title

* unregister on unmount

* fixes

* zero state

* fix field padding

* patched updating form values, removed linting warnings

* configured action buttons

* minor fix

* minor change

* property pane - sort fields in field configuration

* refactor include all properties

* checkbox properties

* date properties

* refactor typings and radio group properties

* switch, multselect, select, array, object properties

* minor changes

* default value

* ts fixes

* checkbox field properties implementation

* date field prop implementation

* switch field

* select field and fix deep nested meta properties

* multiselect implementation

* minor change

* input field implementation

* fix position jump on field type change

* initial accordian

* field state property and auto-complete of JSONFormComputeControl

* merge fixes

* renamed FormBuilder to JSONForm

* source data validation minor change

* custom field default value fix

* Editable keys for custom field

* minor fixes

* replaced useFieldArray with custom logic, added widget icon

* array and object accordian with border/background styling

* minor change

* disabled states for array and objects

* default value minor fix

* form level styles

* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren

* added isValid for all field types

* fixed reset to default values

* debounce form values update

* minor change

* minor change

* fix crash - source data change multi-select to array, fix crash - change of options

* fix positioning

* detect date type in source data

* fix crash - when object is passed to regex input field

* fixed default sourceData path for fields

* accodion keep children mounted on collapse

* jest test for schemaParser

* widget/helper and useRegisterFieldInvalid test

* tests for property config helper and generatePanelPropertyConfig

* fix input field validation not appearing

* fix date field type detection

* rename data -> formData

* handle null/undefined field value change in sourceData

* added null/undefined as valid values for defaultValue text field

* auto detect email field

* set formData default value on initial load

* switch field inline positioning

* field margin fix for row direction

* select full width

* fiex date field default value - out of range

* fix any field type to array

* array default value logic change

* base cypress test changes

* initial json form render cy test

* key sanitization

* fix fieldState update logic

* required design, object/array background color, accordion changes, fix - add new custom field

* minor change

* cypress tests

* fix date formatted value, field state cypress test

* cypress - field properties test and fixes

* rename test file

* fix accessort change to blank value, cypress tests

* fix array field default value for modified accessor

* minor fix

* added animate loading

* fix empty state, add new custom field

* test data fix

* fix warnings

* fix timePrecision visibility

* button styling

* ported input v2

* fix jest tests

* fix cypress tests

* perf changes

* perf improvement

* added comments

* multiselect changes

* input field perf refactor

* array field, object field refactor performance

* checkbox field refactor

* refectored date, radio, select and switch

* fixes

* test fixes

* fixes

* minor fix

* rename field renderer

* remove tracked fieldRenderer field

* cypress test fixes

* cypress changes

* array default value fixes

* arrayfield passedDefaultValue

* auto enabled JS mode for few properties, reverted swith and date property controls

* cypress changes

* added widget sniping mode and fixed object passedDefaultValue

* multiselect v2

* select v2

* fix jest tests

* test fixes

* field limit

* rename field type dropdown texts

* field type changes fixes

* jest fixes

* loading state submit button

* default source data for new widget

* modify limit message

* multiseelct default value changes and cypress fix

* select default value

* keep default value intact on field type change

* TextTable cypress text fix

* review changes

* fixed footer changes

* collapse styles section by default

* fixed footer changes

* form modes

* custom field key rentention

* fixed footer fix in view mode

* non ascii characters

* fix meta merge in dataTreeWidget

* minor fixes

* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts

* modified dependency injection into evaluated values

* refactored fixedfooter logic

* minor change

* accessor update

* minor change

* fixes

* QA fixes date field, scroll content

* fix phone number field, removed visiblity option from array item

* fix sourceData autocomplete

* reset logic

* fix multiselect reset

* form values hydration on widget drag

* code review changes

* reverted order of merge dataTreeWidget

* fixes

* added button titles, fixed hydration issue

* default value fixes

* upgraded react hook form, modified array-level/field-level default value logic

* fixed select validation

* added icon entity explorer, modified icon align control

* modify accessor validation for mongo db _id

* update email field regex

* review changes

* explicitly handle empty source data validation
2022-03-24 12:43:25 +05:30
ashit-rath
b9ed9e74e8
fix: List widget inconsistent pageSize value with the number of item shown in the list. (#11355)
* fix - List widget inconsistent pageSize value

* consider data list length to calculate average gap

* update listdsl for List_spec

* minor change

* fix this.props.children mutation

* fix gridGap calculation

* minor spec change

* update listwidgetdsl.json

* reverted dsl update

* minor test dsl update

* minor averageGridGap calc fix

* minor change

* updated List_spec

* minor change
2022-03-24 12:41:33 +05:30
arunvjn
2902d6bdb8
fix: Removes static generate page text from integrations page. (#12156) 2022-03-24 12:39:38 +05:30
Ankita Kinger
6df2c5eeb1
fix: Design QA changes & form login removed from signup screen if disabled (#11958)
* design qa changes & form login removed from signup screen if disabled

* updated color to use constants & updated error message on restart banner

* added PR review changes

* reverted restart banner error message change

* updated restart timeout from 1 min to 2 min

* reduced spacing for disconnect button
2022-03-24 12:35:00 +05:30
Anagh Hegde
fae7fc6e7c
fix: App visibility of git connected application is reset after git merge (#11890)
* Fix issue with policies being overridden during hydration from file system to db

* Fix tests

* Update the policies for the branched application

* Add test cases for the visibility changes for git connected applications

* Remove the visibility flag from application object while committing to git repo
2022-03-24 07:01:28 +00:00
ankurrsinghal
6a503b4d57
Merge pull request #12007 from appsmithorg/fix/datepicker-resets-today-11837-2
fix: added bugfix for date parsing in datepicker widget 2
2022-03-24 12:31:03 +05:30
Parthvi12
62bca4fa3f
test: added tests for omnibar (#12150)
* adding tests for omnibar

* putting mySQL tests in ignoreTestFiles
2022-03-24 07:00:38 +00:00
Ankur Singhal
0d84b9753f added keyboard interaction for datepicker 2022-03-24 03:33:27 +05:30
Paul Li
8820e4c7c9 fix: Even disabled button tooltip should show
-- Remove disable popover prop
2022-03-24 03:19:55 +08:00
Arsalan
86125dee5e fix: Merge conflicts resolved. 2022-03-23 20:28:12 +05:30
Arsalan
707a707029 fix: Added Test cases for ButtonGroup and MenuButton. 2022-03-23 20:20:42 +05:30
Daniel
48685a850d
fix: blank screen in datasource view mode (#12145) 2022-03-23 18:00:38 +05:30
Tolulope Adetula
aa806de7ba fix: parsing unnecessary value 2022-03-23 13:08:32 +01:00
Abhijeet
b4dfb6919f
fix: Archived pages are getting copied in forked application (#12050)
* Filter cloning archived pages in application fork action
2022-03-23 17:34:42 +05:30
Preet
bbb4a9f51b Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-23 14:46:15 +05:30
Arsalan
7af65dc899 fix: remove only from test cases. 2022-03-23 13:32:18 +05:30