Commit Graph

5691 Commits

Author SHA1 Message Date
Ashit Rath
90532f123c merged latest release 2022-06-17 11:42:56 +05:30
Aishwarya-U-R
3622bf924e
Automated tests for Postgres Datatype - Datetime (#14607) 2022-06-17 11:42:18 +05:30
Aswath K
bd33b76c1d
feat: widget fuzzy search (#14464)
* widget fuzzy search POC

* fix threshold

* Makes fuse to initialize only once

* add proper dependancy to useEffect

* Adds more search terms

* Adds search term for other widgets

* reduce distance for better search results
2022-06-17 08:42:47 +05:30
Pawan Kumar
a38f484ede
fix: In Table widget for button/icon/menu type when Button Color is selected as Theme color and we toggle JS {{or}}}} is displayed (#14492)
* fix table widget color picker bug

* fix table widget color picker bug

* fix font issue on navigating to edit mode from view mode

* code review feedback
2022-06-16 16:46:05 +05:30
Aswath K
478ae29b34
feat: Disable js toggle button if field is not empty (#12754)
* feat: Disable js toggle button if field is not empty and on non-default value

* allows certain values based on control type

* adds handling for more control types

* Change disabled message

* feat: makes option control delete button keyboard accessible

* adds support for theme values

* Adds support for border radius & box shadow controls

* message change and refactor

* minor correction in the message

* Add proper condition for Datepicker control

* fix one cypress test

* updated tests

* add checks for OptionControl

* Updated table binding test

Co-authored-by: apple <nandan@thinkify.io>
2022-06-16 15:17:35 +05:30
Aswath K
06422d1ce2
fix: Issues with widget name focus (#14504)
* fix: black border on organisation menu name

* fix: not focusing on widget name on reflow
2022-06-16 14:33:06 +05:30
Aishwarya-U-R
d7eb5c58fc
Automated tests for Postgres Datatype - Numeric, Character (#14481) 2022-06-16 12:20:02 +05:30
ChandanBalajiBP
0f1a64d906 Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-16 11:50:34 +05:30
ChandanBalajiBP
24d1ac1018 added test cases with requireed changes 2022-06-16 11:48:44 +05:30
akash-codemonk
1514734b27
fix: hide focus pointer when the associated element is out of view in welcome tour (#14216) 2022-06-16 10:04:42 +05:30
ChandanBalajiBP
20f652b543 Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-15 23:25:26 +05:30
Ankita Kinger
9b7944e7ee
feat: migrate organisation to workspace (#13863)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* migrated a few missed out org to workspace

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* fixed AppsmithRole

* mongodb version update

* fixed compile error

* fixed compile issue

* fixed some tests

* simplified embedded mongodb config

* updated a cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-06-15 21:07:41 +05:30
Anand Srinivasan
ef6a2452b5
List copy - update dynamic trigger path list names (#14334) 2022-06-15 15:54:04 +05:30
akash-codemonk
0ddab71a79
fix: hide explorer toggle icon in preview mode (#14318) 2022-06-15 13:52:53 +05:30
Favour Ohanekwu
6c45270def
fix: order async functions in settings tab alphabetically (#13731)
* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* fix merge conflict

* JSFunctionnExe spec flow fix

* update cypress tests

* update cypress tests

* add test case for cloning page

* Datatypes - Numeric spec addition

* failure fixes

* JSfun failure fix

* Postgres failure fix

* JSFuncExecutions failure fix

* MySQL failure point fix

* COmmunity issues wait time fix

* Fixing toast mesg validation point

* Reverting all fixes

* Revertion

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:46:53 +05:30
Pawan Kumar
89bf40e3d7
fix: Toast shows wrong theme name when changing themes (#14488)
* fix typo in toast when changing theme

* fix cypress test

* Added wait time!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:21:37 +05:30
Anand Srinivasan
8b68af1d85
fix: cyclic dependency on array of objects removal (#13962)
* initial fix

* remove un-necessary diff event

* add array accessor dependencies

* init tests

* updated test case

* create folder

* move file

* nested array test cases

* simplify test cases

* comments

* clean up

* evaluation utils test

* remove test

* add back tests and merge
2022-06-15 06:47:57 +00:00
Ayush Pahwa
d220ed428a
Skipping parse of empty array response (#14502)
- When we get a response from API, the data can be either null, undefined, not an array and an array but with no data
- We had handled for everything else except the case of empty array
- This commit fixes that

- We run a query which will return an empty array as response
- We check if application is crashing because of this
2022-06-15 10:59:57 +05:30
Aishwarya-U-R
ad606ad3e2
Script fixes for flaky tests (#14494) 2022-06-14 11:02:37 +05:30
Rishabh Rathod
35aa6536d9
fix: mutliple onPageLoad api call (#14484)
* fix: mutliple onPageLoad api call
* fix postgres spec
2022-06-13 19:26:06 +05:30
rahulramesha
f6cfe32bc7
chore: remove addChildrenSaga dead code and it's associated redux actions (#14425) 2022-06-13 11:31:25 +05:30
Rishabh Rathod
4e13fc5125
fix: AppViewer init and page fetch logic (#14294)
OnPageSwitch we need not `initializeAppViewPage` but instead, only `fetchPublishedPage` this changes fixes that.
2022-06-10 18:22:59 +00:00
Aishwarya-U-R
43cba21013
test: Automated tests for improved CRUD with JSONFrom - Postgres Ds (#14271)
* Postgres CRUD

* MySQL CI run fix

* Added wait time to DeployApp()

* Helpers Enhancements

* ChangeTheme CRUD

* Postgres CRUD

* Postgres CRUD updated

* Postgres CRUD updates

* Postgres CRUD fix

* Postgres CRUD update

* postgres CRUD update

* Postgress CRUD fix

* setting cypress video false

* ExecuteAction spec fixed

* Postgres case #13 fix

* postgres CRUD fix

* Postgres CRUD fixes

* cypress video - true, reattempt - 1

* failure fixes

* Bug 11529 script added

* Bug 11529 scripted + failure fixes

* JSOnLoad_spec failure fix

* OnLoadActions failure fix

* Failure fixes

* ReadTable increased timeout

* JSFunctionExecution_spec failure fix

* Removed duplicate cases

* Mongo failure fixes + applying theme

* Mongo Spec - Added Deletion of DS also

* Deleting initial page

* Deleting DS Validation added

* tc desc updated

* failure point fixes
2022-06-10 19:00:59 +05:30
f0c1s
3594cb3d24
Slowed down git commit and discard progress bar (#14196) 2022-06-10 08:28:57 +05:30
f0c1s
4e2f6d902a
Fix fallback url for git documentation (#14430) 2022-06-10 08:28:19 +05:30
Ankita Kinger
3b62e3f26a
Refactor code for RBAC feature (#14426) 2022-06-10 07:35:30 +05:30
Aswath K
c096027a54
fix: Editable being autofocused on Application card (#14393) 2022-06-10 00:47:48 +05:30
ChandanBalajiBP
aaa2bc1f2f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-09 23:29:03 +05:30
Tolulope Adetula
ddaf283f00 fix: add code comments 2022-06-09 13:50:17 +01:00
rahulramesha
c1da8a6866
fix: paste widgets on a new page (#14295)
* paste widget on generate Page

* adding cypress tests
2022-06-09 17:17:47 +05:30
rahulramesha
abf5821d32
fix: select Modal Widget on clicking on settings badge (#14195) 2022-06-09 16:30:15 +05:30
Tolulope Adetula
3d7d8911fd fix: more refactoring 2022-06-09 10:31:02 +01:00
Tolulope Adetula
909bbf0585 fix: remove console statements 2022-06-09 10:20:35 +01:00
Tolulope Adetula
2c46d42311 fix: CANVAS_SELECTOR 2022-06-09 09:56:31 +01:00
Tolulope Adetula
1f0c38bbf4 fix: remove template literals 2022-06-09 09:41:16 +01:00
Tolulope Adetula
b77870a6ba Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-09 09:39:49 +01:00
Tolulope Adetula
bd4632abd6 fix: refactor code 2022-06-09 09:38:08 +01:00
Pawan Kumar
e3a8d782cf
fix canvas loading issue (#14400) 2022-06-09 13:45:45 +05:30
Aishwarya-U-R
949b657103
Updating Mongo DB name to match Mongo TED database name (#14389) 2022-06-09 12:21:46 +05:30
Tolulope Adetula
4d5fc3b31f Revert "fix: empty commit"
This reverts commit cef5bed7f6.
2022-06-09 07:11:53 +01:00
Tolulope Adetula
cef5bed7f6 fix: empty commit 2022-06-09 07:11:24 +01:00
Aswath K
a88618d17d
chore: Adds feature flag for Property pane grouping (#14311)
* Adds feature flag for Property pane grouping

* changes assertion logic
2022-06-09 11:16:00 +05:30
akash-codemonk
50b93894d2
fix: Update the widget from drop down to select widget in suggested widget list (#14059) 2022-06-09 11:01:52 +05:30
balajisoundar
265ed0dc25
fix: Improve cell overflow check logic when switching between table page (#14095)
* fix: Improve cell overflow check logic when switching between table page.

* Table locators update

* Migration spec - locators update

* Migration spec locators update

* MongoDBShoppingCart spec locators update

* POstgress Spec locator fix

* Adding wait!

* Mongo DBcart spec fix

* EchoApiCMS_spec locator update

* Table locators update

* updated locators

* Added delay

* Hidden column fix trial

* Adding refresh page

* Adding time

* Fix cypress xpaths

Co-authored-by: bhavin <techbhavin@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
2022-06-08 21:59:31 -07:00
ChandanBalajiBP
c8f733fb08
Handle string datatype in API response (#14274) 2022-06-09 10:28:56 +05:30
Ankita Kinger
442b849d9e
Refactor code for RBAC feature (#14362) 2022-06-08 18:48:15 +05:30
RakshaKShetty
221d9c0a7c
test: git delete branch tests (#14047)
* gitdeletebranchtests
2022-06-08 17:14:15 +05:30
NandanAnantharamu
eff7dd5a4e
test:JsonForm test for multi source data (#14153)
* JsonForm test for multisource data

* Added tests for jsonForm widget

* moved locators to seperate file

* Added some more tests

* Updated tests
2022-06-08 16:21:53 +05:30
Tolulope Adetula
665aec5d61 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-08 11:21:01 +01:00
Tolulope Adetula
3a331558ff fix: remove dead code 2022-06-08 11:17:49 +01:00
Tolulope Adetula
22db2edf42 fix: TreeSelect 2022-06-08 10:57:53 +01:00
Pawan Kumar
065cb0e1ba
chore: code split for hiding branding badge (#14346)
* code split for hiding branding badge

* use selectors in branding badge
2022-06-08 15:11:53 +05:30
ashit-rath
3adbb8736f
feat: Rich Text Editor enable browser spellcheck (#13886)
* feat: Rich Text Editor enable browser spellcheck

* fix: added custom menu

* add function for OS check, updated text based on OS

* fix: text update

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-06-08 14:35:35 +05:30
Favour Ohanekwu
d5da24e51e
fix: cyclic dependency in renaming js objects (#13914)
* keep localunevaltree update in sync with unevaltree

* undo tree check

* identify .data difference for js objects

* empty line

* unit test

* unit test name change

* comment

Co-authored-by: Anand Srinivasan <anand.a.srinivasan@outlook.com>
2022-06-08 08:47:59 +01:00
Parthvi12
38f14bb5ac
test: Add regenerate SSH key tests (#14325)
* Add regenerate SSH key tests

* fix flaky tests

* fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-08 13:07:00 +05:30
Tolulope Adetula
ab998cfe55
fix: Cursor pagination in list widget (#14206) 2022-06-08 13:06:21 +05:30
Bhavin K
144c999d1c
fix: updated css clash with tree select (#14343) 2022-06-08 07:22:53 +00:00
Tolulope Adetula
0d4f8a0b3f Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-06-08 06:33:35 +01:00
Tolulope Adetula
1680df92c7 fix: for MultiSelect 2022-06-08 06:32:28 +01:00
Rishabh Rathod
dbcd69e63e
fix: crash due to evalMetaUpdate (#14320)
* fix: crash due to evalMetaUpdate

* Add default value for workerResponse

* patch fix

* fix root cause of DataCloneError
2022-06-07 12:06:27 +05:30
Ayangade Adeoluwa
2ffd942e06
fix: Add null checks for empty datatypes in api/query responses (#14208)
* Add null checks for empty datatypes in api/query responses

* Add jest cases for failing tests

* Add one more test case
2022-06-06 13:27:19 +05:30
Ankita Kinger
290298b2d8
update document link for SAML (#14285) 2022-06-06 12:55:03 +05:30
Aishwarya-U-R
98c06e2817
Automated tests for improved CRUD with JSONFrom - Mongo Ds (#14191) 2022-06-06 11:29:15 +05:30
rahulramesha
9cbcf180cc
minor correcion in Deprecation message (#14273) 2022-06-06 10:18:43 +05:30
Aman Agarwal
3bcb1daf73
fix: onPageLoad false failure issue (#14141)
1. Fixed on page load actions getting called multiple times.
2. Now Evaluation only happens once we complete the fetching of the page's all entities including js objects and actions, this avoids cases where actions are not defined when ran.

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2022-06-06 09:26:14 +05:30
Bhavin K
8c40098975
fix: added hover css for indeterminate checkbox (#14194) 2022-06-03 19:16:31 +05:30
Pawan Kumar
78e6bcf7ad
fix: Theming UX Changes (#13741)
* update color control ux

* add reset theme option

* remove the console

* update theme card

* update icons + text for reset

* update button size

* fix cypress tests

* fix cypress tests

* fix flaky git tests

* incorporate ashit feedback

* fix cypress tests

* fix color button in theme panel

* fix reset theme logic + jest tests

* fix button styles reset issue in json form

* add cypress test for theming reset

* incorporate ashit feedback

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-03 15:55:38 +05:30
Anagh Hegde
4c6c109edf
fix: Update the widget from drop down to select widget in suggested widget list (#13944)
* Update the widget from drop down to select widget
2022-06-03 07:49:56 +00:00
Aswath K
c29fd2db19
chore: Adds canDisplayValue to property controls (#13309)
* Adds canDisplayValue to property controls

* Adds tests

* add fn for LocationSearch & ActionSelector

* Adds CSV value support in ButtonTabControl
2022-06-03 10:37:02 +05:30
Aswath K
7bb58ff3c2
fix: uses forwardRef instead of using ref prop (#14201) 2022-06-02 22:11:28 +05:30
Bhavin K
543ce339e3
feat: Added Tooltip for icon button widget (#14131) 2022-06-02 15:14:26 +05:30
Tolulope Adetula
6108d6fd1d Fix: Disable scrolling when dropdown opens 2022-06-01 14:42:16 +01:00
Arpit Mohan
48738091e5
chore: Removing jest test coverage because of node version mismatch (#14230) 2022-06-01 17:43:03 +05:30
Bhavin K
1a3eafb182
fix: update error highlight border in RTE widget 2022-06-01 17:41:25 +05:30
Aswath K
b83058b391
Name not getting focused on adding new modal widget (#14205) 2022-06-01 17:01:48 +05:30
akash-codemonk
ec6d998d27
Revert "fix: signing up with a redirect url which has a query param goes to a 400 page (#13548)" (#13991)
This reverts commit c0f7c4534d.
2022-06-01 16:00:15 +05:30
Aman Agarwal
7aeaf75c90
fix: removed default value for API DS, updated conditions for headers and apiformattype (#14107)
* fix: removed default value for API DS, updated conditions for headers and apiformattype

* fix: added test cases for content type changes on changing method types

* fix: imported isEmpty directly with loading full lodash module
2022-06-01 10:29:58 +00:00
Bhavin K
95e6b4fb98
fix: switch group added check for inline width (#14190)
* fix: switch group added check for inline width

* SwitchGroup inline cypress test added

* New snaps to match CI run

* Adding right images for CI run

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-01 00:13:32 +05:30
Tolulope Adetula
b22975f6db fix: PR review 2022-05-31 15:21:46 +01:00
Tolulope Adetula
af17e7b8fd Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-31 11:53:20 +01:00
Tolulope Adetula
e1301dc18b fix: remove autofocus 2022-05-31 11:52:39 +01:00
Aishwarya-U-R
6c1c5581e7
Automated tests for improved CRUD with JSONFrom - MySQL Ds (#14014) 2022-05-31 11:03:59 +05:30
Tolulope Adetula
88a1daacc3 Revert "remove unused code"
This reverts commit 2d694ca446.
2022-05-30 23:17:35 +01:00
Tolulope Adetula
17ec737977 Revert "fix: popup issues"
This reverts commit 9a8bb35809.
2022-05-30 23:12:04 +01:00
Arsalan Yaldram
9018481415
fix: update jest env and testtimeout (#14178) 2022-05-30 17:52:54 +05:30
Parthvi12
da195a6ca0
remove third party api in cypress test (#14154) 2022-05-30 12:38:16 +05:30
arunvjn
b2158131a6
chore: auto focus search input box when widgets library is open(#14148) 2022-05-30 09:26:51 +05:30
arunvjn
fd68dd5bc2
chore: changed edit/launch button to links in applications dashboard. (#14111) 2022-05-30 09:25:18 +05:30
Sumesh Pradhan
31c98a8fda
Added healthcheck for editor with https (#13947)
Added a fix for the docker health check on editor with ssl enabled for appsmith-ce fat container and the slim client appsmith-editor
2022-05-27 17:05:21 +05:30
Arsalan Yaldram
8d55d6f51d
chore: update node version to 16.14.0 (#14127) 2022-05-26 23:39:59 +05:30
Arsalan Yaldram
b28eb3fed8
chore: Update node version to 16.15.0 LTS (#14094) 2022-05-26 16:05:02 +05:30
haojin111
3c1b1a3628
Merge pull request #13864 from appsmithorg/feat/13412-improve-import-app-flow-ui
feat: 13412 - improve import app with progress bar
2022-05-26 16:49:47 +08:00
NandanAnantharamu
6359bfcfbe
test: List testcases (#14009) 2022-05-26 13:25:08 +05:30
rahulramesha
9cb8524acd
fix: stop showing errored widget labels permanently and show them only on hover or when selected (#14064) 2022-05-26 12:55:29 +05:30
Chandan Balaji
4d76db5fe7 updated harcoded values 2022-05-26 12:45:48 +05:30
Pawan Kumar
7c9135f945
fix: Canvas jitters on page refresh on an application where widgets don't occupy the entire width of the canvas (#13917)
* fixes the flicker of widgets

* fix jest test

* fix use dynamic app layout jitter issue

* fix use dynamic app layout jitter issue

* remove unecessary dispatch

* remove unecessary dispatch
2022-05-26 10:22:55 +05:30
Ankita Kinger
fa45282b0a
fix: alignment of the image seen on no search results on application page (#13950)
* fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)

* add debounce to search and remove state var

* increase debounce time

* fix: updated the condition to show expiry key (#13092)

* Add index for git (#13133)

* fix: Fixed compile time errors

* fix: Unable to see apps in home page after git connect fails (#13387)

* Fix Redis installation in Dockerfile (#13428) (#13430)

Conflicts:
	Dockerfile

* fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)

* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections

(cherry picked from commit 7261834fe5)

* fix: NPE check when datasource createdAt is null

(cherry picked from commit beafb371b24180dce2e351f1dea6d9d34db2a204)

* fixed image alignment for no search results on applications page

* deleted duplicate file

* reload to Refresh script update

* Adding sleep - script fix

Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Rimil Dey <rimildeyjsr@gmail.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-26 10:05:35 +05:30
Abhijeet
845d5b2ad4
chore: Update CRUD page template to include JSONFormWidget (#12662)
* Updated Template

* Fix testcases

* Try removing autogenerated field entry from insert modal

* Update mongo testcase
2022-05-26 09:19:33 +05:30
arunvjn
f75440f29a
fix: removes animation in tooltips (#14032) 2022-05-25 23:12:01 +05:30
Favour Ohanekwu
7bbd109f62
fix: improve jseditor linting performance (#14001) 2022-05-25 18:08:35 +02:00
arunvjn
5947b07c70
fix: Removes animation in deploy button (#14029) 2022-05-25 19:39:12 +05:30
arunvjn
82328f4753
fix: delay comment threads API call till the application details are retrieved (#14011) 2022-05-25 18:19:01 +05:30
Tolulope Adetula
d07d8f8a5d fix: PR review 2022-05-25 13:11:43 +01:00
Bhavin K
1760e8150c
fix: checkbox, switch property fields update, migration added (#13997) 2022-05-25 17:03:33 +05:30
Chandan Balaji
b24428be59 fix: UI Inconsistencies in Datasource Card and Page 2022-05-25 16:58:30 +05:30
Arsalan Yaldram
b266dd47d3
Merge pull request #13585 from appsmithorg/fix/table-bindingPathList
fix: table derived bindingList error.
2022-05-25 15:42:05 +05:30
Aswath K
c8e79eca95
feat: Focus widget name or first property when opening property pane (#13513)
* feat: intial investigation.

* Completed focusing of Property title

* removes unused import

* fix issue with inability to focus Dropdown

* checks if PP opened not because of focusing on input elements in widget

* Adds two level of focus for LocationSearch

* adds multi state to KeyValue component

* Adds multi state to Draggable List as well

* Adds multi state to DatePickerControl

* fix: style issue with draggableList & KeyValue comp

* avoids auto focusing on Panel

* remove commentedout code

* fix: cypress tests

* change ActionConstant name

Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-05-25 15:35:53 +05:30
ashit-rath
6d591c49b9
fix: JSONForm Select field validate empty string as an invalid value (#13993) 2022-05-25 15:34:50 +05:30
Rishabh Rathod
cbce8f8b8e
fix: trigger consuming previous evaluated values (#13084)
We are changing how we maintain meta values in our architecture,

Earlier metaHOC component state was used to store meta values that were debounced and pushed in batch to metaReducer and trigger evaluation.
We remove the metaHOC state and directly update values to metaReducer and trigger evaluation separately via a debouched function.
2022-05-25 15:16:14 +05:30
akash-codemonk
77cee950b1
fix: inconsistency in naming actions from omnibar (#13898) 2022-05-25 15:10:06 +05:30
rahulramesha
a2688bb4da
feat: Add deprecation warning badge to deprecated widgets (#13381)
This Change also introduces, isDeprecated flag to widget config, when true will add the warning to the widget's propertyPane.
2022-05-25 09:38:32 +00:00
Tolulope Adetula
2d694ca446 remove unused code 2022-05-24 23:36:56 +01:00
Tolulope Adetula
9a8bb35809 fix: popup issues 2022-05-24 23:35:42 +01:00
Tolulope Adetula
806b212380 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-24 22:46:15 +01:00
Pawan Kumar
297421b332
fix: Redirect to website home instead of appsmith home on watermark (#14018)
* update url

* open url in new tab;
2022-05-23 17:39:12 +05:30
haojin111
7e5332ceb7 Merge branch 'release' into feat/13412-improve-import-app-flow-ui 2022-05-23 13:31:28 +08:00
Aishwarya-U-R
d0fed6bfe7
Automation script update to fix Community issues failure (#13968) 2022-05-23 10:50:27 +05:30
Arsalan
6bc68c0327 Merge branch 'release' into fix/table-bindingPathList 2022-05-23 10:41:03 +05:30
rahulramesha
f2c02ab931
fix: Grouped widgets moving to the bottom most row, even when widgets are not overlapping with the multi select box (#13658) 2022-05-20 15:57:12 +02:00
arunvjn
da1a57de72
Fixes the error message shown in reset password flow from user profile (#13974) 2022-05-20 14:37:02 +05:30
ashit-rath
76536124f8
fix: JSONForm modify source data object to null causes crash (#13966) 2022-05-20 13:46:45 +05:30
Maulik
7ccc541fbf
fix: update placeholder for phone input widget (#13635) 2022-05-20 10:41:58 +05:30
arunvjn
9753df54f4
fix: remove transition delay in the switch between explorer and widgets. (#13942) 2022-05-20 10:32:13 +05:30
haojin111
82dcfeff21
Merge branch 'release' into feat/13412-improve-import-app-flow-ui 2022-05-20 04:17:18 +08:00
haojin111
9561fe0dd8 updated comments of commit 2022-05-19 23:02:35 +08:00
Favour Ohanekwu
cad1620683
fix:prevent execution of js function when jscollection is saving (#13592) 2022-05-19 14:13:51 +01:00
Favour Ohanekwu
244095a888
fix: Js editor inconsistency (#13708) 2022-05-19 13:21:51 +01:00
Favour Ohanekwu
2748ed0e64
fix: prioritize parse errors in debugger callout (#13765)
Prioritize parse errors over lint errors in debugger callout
2022-05-19 11:57:49 +01:00
ashit-rath
f6d726b2a1
task: JSONForm footer should always stick to bottom when fixed footer enabled (#13904) 2022-05-19 13:07:59 +05:30
Bhavin K
33d8347193
fix: handle selectedValues value (#13887) 2022-05-19 12:41:54 +05:30
f0c1s
f4c1049027
Add analytics for git import application (#13925)
Analytics tracking is missing for git import application. This commit adds event tracking as follows:

- When git-import-application card is clicked
2022-05-19 12:16:38 +05:30
Ayangade Adeoluwa
f7107a4a0a
Fix response tab overflow issue (#13839)
This commit fixes three things

- It prevents the tab headers from being scrolled up when on the RAW/JSON tabs.
- It prevents the Table component from pushing the API right pane away when its contents are too wide.
- It also prevents the table and JSON component from clipping the data displayed within them by adding margins/paddings between them and the parent container.
2022-05-19 08:32:43 +05:30
Ayangade Adeoluwa
1ee494b9ca
fix: Fix validation check that is blocking input from changing (#13943)
* Fix validation check that is blocking input from changing

* Add testcases for Elastic search datasource

* Adds header value to test case

* Fix validation logic
2022-05-18 17:35:03 +00:00
Ayangade Adeoluwa
dd46351e38
Increase width for various form controls (#13895) 2022-05-18 15:37:47 +01:00
Aishwarya-U-R
04a8c3b037
Tests for JSObjects-onPageLoad (#13712)
Automated tests to improve coverage for JSObjects-onPageLoad
2022-05-18 16:09:42 +05:30
arunvjn
0bcabdb11f
fix: Text overlap in slash commands (#13871) 2022-05-18 15:37:24 +05:30
Anand Srinivasan
4e5cf6c156
add unit test (#13776) 2022-05-18 13:16:16 +05:30
arunvjn
f3dec5ca0f
fix: bind api/query to list widget in sniping mode (#13859) 2022-05-18 13:03:52 +05:30
arunvjn
1296fe7f57
Added selected state for query/js add button (#13897)
Adds selected state to Query/JS add button in explorer when submenu is open.
2022-05-18 12:03:09 +05:30
Satish Gandham
8dc9c0b017
feat: Optimize create uneval tree via memoization (#13476)
* - Memoize the expeinsive parts of createUnevalTree

* - Split the generateDataTreeWidget and memoize the expensize part
- Remove stary console statement in MultiSelectWidget

* - Some debugging code, needs to be removed.

* Debugging in progress

* Still debugging

* Still debugging

* Working??

* Jest tests passing, and fast enough

* remove unused imports

* One failing jest test, testing luck with cypress

* Remcoe console statment from jest test

* - Sync with release.
- Comment failing jest test

* Disable a test

* - Clean up

* Final cleanup and documentation

* - Make function and variable names accurate and easy to understand

* Update code comments

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-05-18 10:51:53 +05:30
Nayan
33c78e93ef
feat: Update organization slug (#13791)
When organization name is updated, the slug is not updated. This generates a outdated URL when user clicks on a organization name from the left panel. This PR changes the following behaviors

    The Organization slug will be no more unique
    Link to organization applications will be based on organization id instead of slug
    Organization slug will be updated whenever there is a change in organization name
    All the existing organization slugs will be updated
2022-05-18 11:08:13 +06:00
Ankita Kinger
1396141af4
chore: optimize naming conventions for variables and functions (#13858)
* optimize naming conventions for variables and functions

* update import statement

* minor css change
2022-05-18 10:23:08 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows (#13257) 2022-05-18 04:46:25 +00:00
Parthvi12
32bcd94e54
Add tests for git discard changes (#13866) 2022-05-18 04:45:32 +00:00
haojin111
27ebbfabe3 update full changes 2022-05-17 14:56:34 +08:00
ashit-rath
25d24688a6
fix: Property pane - Hidden sections icon select popover not opening properly (#13881) 2022-05-17 12:25:25 +05:30
haojin111
89990c2114 unstaging coverage-summary.json 2022-05-17 14:28:00 +08:00
Ankita Kinger
11d03370a4
Add field for reply-to email address on email config page (#13857) 2022-05-16 16:23:36 +05:30
haojin111
a3be2498e3 added import application progress bar when importing from json 2022-05-16 18:09:23 +08:00
Keyur Paralkar
22605a341a
fix: added empty stack in sppThemingReducer (#13837) 2022-05-16 13:16:35 +05:30
albinAppsmith
7f241cb98e
feat: Entity explorer pages section resize (#13576)
* * Page container resize changes

* * changed inline style to styled component

* * Added preserve height functionality
2022-05-16 12:09:32 +05:30
Tolulope Adetula
a956ff6d71
Merge pull request #13793 from appsmithorg/fix/select-widget-filtering
fix: Select widget filtering
2022-05-16 05:17:43 +01:00
rahulramesha
6738c969bf
chore: changes to render complete property pane post dragging or resizing (#13141)
* changes to render complete property pane post dragging or resizing

* rework to compensate for expensive render of theming properties
2022-05-15 18:42:07 +05:30
ashit-rath
e44aecfe85
fix: JSONForm missing theming accent color property and few JS enabled controls not access sourceData/formData properties (#13817)
* fix: JSONForm missing theming accent color property and few JS enabled inaccessible sourceData/formData properties

* reverted adding of customJSControl JSON_FORM_COMPUTE_VALUE for exisiting properties

* minor revert

* minor fix
2022-05-13 19:53:23 +05:30
akash-codemonk
e1045b1bc3
chore: add autofocus prop to TagInputComponent (#13578) 2022-05-13 17:34:08 +05:30
Keyur Paralkar
a5f426d02b
fix: theme property pane reset on hover over the widget (#13716) 2022-05-13 16:10:09 +05:30
Bhavin K
dabca5aac5
fix : prevent dragging when resizing (#13600) 2022-05-13 11:26:09 +05:30
arunvjn
9381eeaea7
Trigger submenu instead of omni-bar when "Add Query/JS" button in the explorer is clicked. (#13774) 2022-05-13 10:31:08 +05:30
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Tolulope Adetula
83a2237a3a Merge branch 'release' into fix/select-widget-filtering 2022-05-12 12:41:32 +01:00
Tolulope Adetula
379ce6cf5c fix: Select widget filtering 2022-05-12 12:31:45 +01:00
Arsalan
b0e4f099bc fix: return undefiend when propertiesToUpdate is empty array. 2022-05-12 14:15:50 +05:30
f0c1s
84be23c490
chore: refactor git code (#13724) 2022-05-12 14:02:56 +05:30
Arsalan
8fa294ae49 Merge branch 'release' into fix/table-bindingPathList 2022-05-12 11:40:52 +05:30
Parthvi12
72e24b9a2a
test: update cypress tests as per added test data in TED (#13761)
* update data table
2022-05-11 17:50:12 +00:00
Maulik
7856d8234e
chore: update error message for no schema available for a datasource (#13467) 2022-05-11 19:15:06 +02:00
arunvjn
ae22baaa36
fix: persists query param in redirect urls (#13738) 2022-05-11 20:42:07 +05:30
arunvjn
8084744e98
chore: safe crash application on theme APIs failure (#13743) 2022-05-11 16:01:04 +05:30
Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects (#13700) 2022-05-11 11:20:33 +01:00
ChandanBalajiBP
43758f6e7e
Merge pull request #13725 from appsmithorg/Fix/Hover-state-of-renaming-titles
fix: Hover state of renaming titles
2022-05-11 14:59:26 +05:30
rahulramesha
27d5ae8b77
fix: Avoid pasting list widget inside another list widget (#13719)
* fix for stopping list widget from copying onto itself

* remove duplicate comment

* verify selected widgets are not inside list widget if list widget is to be pasted
2022-05-11 14:46:22 +05:30
Rishabh Rathod
89c4bbeeec
chore: remove only for jest test (#13668) 2022-05-11 09:12:59 +00:00
rahulramesha
3923204dcc
The page order doesn't work as expected in page setting page (#13448) 2022-05-11 13:28:07 +05:30
arunvjn
0571f9c36b
Delay on page load actions till all actions are retrieved (#13657)
As a quick fix to prevent the on-page load actions from firing before the actions are even fetched, we had reverted the changes to make fetch page DSL call parallel in 13587. Unfortunately, theming PR brought back parallelisation and the issue along with it.

This PR ensures that the on-page-load actions are only made after actions are fetched while preserving parallelisation.
2022-05-11 12:36:25 +05:30
NandanAnantharamu
7199a329a9
test: Theme related tests (#12740)
* Removed unwanted waits

* Updated test for fonts

* Updated tests with Font and Theme usecases

* updated tests

* Added new tests and common locators

* Added default/update theme tests

* grouped tests

* Updated Theme tests

* updated multiwidget test

* updated theme tests

* Updated tests

* Reordered tests
2022-05-11 11:43:28 +05:30
Pawan Kumar
2dacdec880
fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas (#13608)
* fix tab widget scrolling + text widget font control overflowing issue

* revert text widget changes

* tab widget scroll issue

* remove border radius and box shadow from v1 widgets
2022-05-11 10:23:13 +05:30
Tolulope Adetula
10aca0297f
Merge pull request #13275 from appsmithorg/fix/disable-cancel-button-on-a-disabled-select-widget
fix: disable cancel button on a disabled select widget
2022-05-11 03:55:52 +01:00
Tolulope Adetula
2f8c178dda fix: Failing Tests 2022-05-11 02:36:54 +01:00
Ayangade Adeoluwa
49a4e47b95
Add functionality to close modal when back overlay is clicked. (#13669) 2022-05-10 12:39:03 +00:00
Chandan Balaji
01604bb25a hover state of renaming titles 2022-05-10 17:38:08 +05:30
akash-codemonk
c0f7c4534d
fix: signing up with a redirect url which has a query param goes to a 400 page (#13548) 2022-05-10 13:32:25 +05:30
Aishwarya-U-R
f5cc98644f
Automated tests to TableFilterSpec for Bug #13334 + failure fixes (#13662) 2022-05-10 10:40:46 +05:30
Arpit Mohan
cf27bbdfec
Merge pull request #13653 from appsmithorg/fix-13652 2022-05-10 05:25:44 +02:00
akash-codemonk
2b5d5dd89f
fix: triggering omnibar shortcuts toggles visibility when visible (#11601) 2022-05-09 19:43:57 +05:30
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled (#13520) 2022-05-09 17:34:49 +05:30
Sangeeth Sivan
897d3818b9
fix: Handle login form password error message on blur (#13568)
* gitignore

* don't show password field errorMessage onBlur

* remove unused import of usestore
2022-05-09 15:53:41 +05:30
Sangeeth Sivan
d5845e972a
fix: Use unique id instead of indices as keys for DraggableList (#13553)
* gitignore

* fix: Use unique id instead of indices as keys for DraggableList(#9991).

* removed duplicate 'stacks' from gitignore

* revert change to cypress selector for draggable list

* use 'id' ad key name for consistency and that it doesn't break in other places
2022-05-09 15:52:37 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget (#13605)
* refactor: removed the duplicate style properties for the list widget

* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
ashit-rath
a715c0eefa
fix: JSONForm Phone number field required validation (#13525)
* fix: JSONForm Phone number field required validation

* PR review suggestion change
2022-05-09 14:59:53 +05:30
Aishwarya UR
fdc3143c21 Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-05-09 13:58:37 +05:30
Arsalan
f6f5125018 Merge branch 'release' into fix/table-bindingPathList 2022-05-09 11:11:04 +05:30
Sangeeth Sivan
ab557b1443
fix: Lowercase 'first' on the welcome page. (#13559)
* gitignore

* fix: Lowercase 'first' on the welcome page.(#8876)

* removed duplicate 'stacks' from gitignore
2022-05-09 10:54:48 +05:30
Tolulope Adetula
de8aebfe00 Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-05-09 03:15:51 +01:00
Favour Ohanekwu
3ab904d83d
fix:only show js successful execution toast message in edit mode (#13590)
* only show js successful execution toast message in edit mode
2022-05-07 17:03:03 +01:00
Anubhav
e35f8dc897 fix: use modified instead of updated 2022-05-07 08:10:34 +05:30
rashmi rai
c0f98ad4d7
fix:change default value in rest api json and placeholder (#13261) 2022-05-06 19:13:10 +01:00
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page (#13178)
* added cypress test of form login on admin setting page

* resotre setting after checked

* added a check if signup form is enabled for all users

* minor fix

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Arpit Mohan
4934fc9066
Merge pull request #13644 from appsmithorg/fix-12164 2022-05-06 16:17:37 +02:00
rahulramesha
7a501ecd9c
fix: stopping list widget from copying onto another list widget (#13621)
* fix for stopping list widget from copying onto itself

* remove duplicate comment
2022-05-06 19:41:09 +05:30
arunvjn
c7305d4114
Makes bindings popover consistent with the other popovers (#13579) 2022-05-06 11:40:51 +00:00