Commit Graph

120 Commits

Author SHA1 Message Date
Aswath K
24b9da6741
fix: change Button variant types constant (#7817)
* change Button variant types constant

* Add migration

* Adds cypress test to validate default button variant

* update the ButtonVariant for MenuButton inside table widget

* Remove only from Button_spec

* fix: Binding issue with Variant in table

* fix: cypress test for default variant validation

* Add validation to IconButton inside table
2021-10-12 08:04:51 +00:00
Vicky Bansal
1d9f1831ba
Reset table page on filters reset (#8257)
Date column to not show invalid date when column value is empty
2021-10-11 17:51:35 +05:30
albinAppsmith
71886c3b9e
feat: Property pane dropdown overflow issues (#8236)
* * hide subtext for date picker fix
* EE clicking on entity, unfolding/folding added

* * bug fixes in action dropdown

* bug fix for cursor

* fix: 8190 background api request and welcome helper button (#8281)

* chore: Move action/js debugger tabs related logic to a common component (#8199)

* removed background of api request textbox and added hover text on "no thanks" button

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>

* fix: added scrolling in invited users more popup (#8226)

* added scrolling in invited users more popup

* always scrollbar displaying on invited users pan

* fixed issue related with 8190

* updated cursor of invited users more

* replace edit data source icon with remix icon (#8192)

* * active text color

* fix: dropdownlist props issue (#8322)

* Commented failing JS tests (#8276)

Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>

* docs: Update ServerSetup.md (#8255)

* Make port customizable from env variable (#8288)

* fix: issue with string templates (#7848)

* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests

* fixed props pass issue

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>

* * bug fixes

* * bug fix

* * test cases fix

* - test case fix

* * test fixes

* * bug fix in test case

Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-11 11:31:05 +05:30
Sheetal Patel
addca3fdb4
fix: if-else-statements-converted to ternary operator (#8219) 2021-10-09 02:05:24 +05:30
Vicky Bansal
fdac6428b4
fix: Icon button click should not de-select row in table widget (#8197) 2021-10-08 18:00:12 +05:30
Tolulope Adetula
0b1f6da7fa
fix: column reorder on data load (#8167)
* fix: column reorder

* fix: table reorder with derived column
2021-10-08 07:43:33 +01:00
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30
Tolulope Adetula
8b30fdd758
fix: wrong doc link (#7983) 2021-09-30 03:39:21 -07:00
Aswath K
b4bab33d1e
fix: make the row click event trigger when table button is clicked (#7878) 2021-09-28 16:27:44 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
Vicky Bansal
609cdc05e4
feat: Table selected row and action trigger UX improvement (#7310) 2021-09-23 17:16:47 +05:30
Vicky Bansal
8679141c76
Fix button click issue in table widget when action configured in onClick is no action (#7523) 2021-09-22 12:58:35 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
Nikhil Nandagopal
87b13eca2d
fix: Widget Property Pane Updates (#7467)
* reverted previous revert

* standardised widget sizes

* Text changes

* changed default input label style to match default text style

* more messaging tweaks

* minor fix

* Removed dot from the text

* minor fix for form widget

* fixed tests

* minor fixes
2021-09-20 16:13:44 +05:30
ashit-rath
1c24afb356
fix: table row cell actions to get proper currentRow data (#7244)
* fix: table row cell actions to get proper currentRow data

* minor change
2021-09-16 12:26:52 +05:30
Abhinav Jha
b49f5097c6
refactor: Widget Development API (#6405) 2021-09-09 20:40:22 +05:30
somangshu
f18d58bb12 Revert "fix: property pane (#7157)"
This reverts commit 72f667bec4.
2021-09-09 13:48:16 +05:30
Nikhil Nandagopal
72f667bec4
fix: property pane (#7157)
* updated widget properties

* updated placeholders

* updated default for date

* lint fix

* Fixed more styles and reverted changes to input widget

* adjusted default sizes of different widgets

* resized image in list widget

* reduced chart default data

* fixed tests

* PR comment fixes

* fixed tests failing

* fix: Fixed failing jest tests because of an error in chart widget propertyConfig object

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-09-08 20:03:06 +05:30
Vicky Bansal
b7385ebd91
fix: Filter columns which has a column accessor (#7101)
* Filter columns which has does not have a column accessor property
2021-09-08 14:41:48 +05:30
Yash Vibhandik
387ba66f00
FIX #4952 : checked array before spread (#7027) 2021-09-08 14:30:07 +05:30
Tolulope Adetula
db88ef86f4
fix: underline style for text (#6865)
* fix: underline style for text

* fix: add expected structure example

* Revert "fix: add expected structure example"

This reverts commit efd56886a26f87bb18cf6edc53bd246bfeb8e0f1.

* fix: test failing

* fix: widget crashing (#6980)

* fix: update omnibar search string for documentation for actions (#6722)

* [Mongo] Added default values for query for Find, Count and Distinct commands (#6960)

* Added smart defaults for query in Count, Distinct & Find commands

* Added test cases for smart inputs for query and limit for find, and query for count and distinct

* Distinct command output now results a JSON object instead of an array of strings (#6964)

* Fix: Break word when text widget content is long (#6211)

fixes #5319

* fix: widget crashing

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>
2021-09-06 00:06:15 -07:00
Tolulope Adetula
742f0cf1ec
feat: compact mode in property pane (#6637)
* fix: compact mode

* fix: test

* fix: remove row height visibility

* fix: options label for compactMode

* feat: Add test

* Fix: failing test

* fix: test

* fix: test case.

* fix failing test

* fix: move position of rowHeight prop in property pane
2021-09-06 00:05:51 -07:00
Tolulope Adetula
45fad5e094
Feat: Table Widget: icon button as a new column type (#6598)
* feat: add icon button properties to property pane
* feat: add icon button styles to property pane
2021-09-01 15:20:23 +05:30
Vicky Bansal
dbc3ca6bdf
feat: Table widget - Configure table data rows count (#5552)
Introduced a new field called as total record count which can be used to disable the pagination controls while having server side pagination. If this value is undefined the conditions will be ignored. The total record count is `total count / page size`, all the parameters need to be bound to the query/API for the functionality to work properly
2021-08-30 14:54:59 +05:30
Bhavin K
b892712685
Table widget: default selected row, 0th (#5930) 2021-08-30 12:28:45 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
Yash Vibhandik
a5fe7c391e
fixed the filter issue in table widget (#6739)
The filters did not get reset where the data in the table widget changes in the edit mode. This is now fixed
2021-08-23 12:59:14 +05:30
Yash Vibhandik
158a71acab
FIX #3123 : added custom csvSeparator property in table widget for csv download (#6291) 2021-08-18 16:03:26 +05:30
Tolulope Adetula
b6f9aef70a
feat: Add isDisabled to Button column and isVisible to all Table widget Column settings (#4819) 2021-08-17 18:24:43 +05:30
Vicky Bansal
82722e5a38
Fix table date type column sorting (#6134) 2021-08-16 19:07:30 +05:30
Tolulope Adetula
38e1d660ef
fix: table column order and isVisible (#6521)
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh
2021-08-11 19:32:14 +05:30
Hetu Nandu
eba88cdc85
Hotfix Table Widget crashes when there is a cyclical dependency (#6505) 2021-08-10 15:51:27 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)
This reverts commit 3ae1bd6d95.
2021-08-10 13:27:29 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering (#5941)
* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
10ff97b3dc
fix for tabelwidget filter bug (#6001)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-27 10:48:52 +05:30
Vicky Bansal
0e6ff2bebe
Fix-Keep date picker open when selecting time, month, year in Table widget filters (#5991)
Keep date-picker open when selecting time or changing month, year in Table filters, The user before this could not select or change time. We have fixed this by closing the date-picker popover onClick of outside overlay/canvas.
2021-07-26 12:29:53 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30
Hetu Nandu
52311e8944
Only add appsmith functions in global scope during trigger evaluation (#5760) 2021-07-13 18:27:59 +05:30
Yash Vibhandik
c7577a23f0
FIX #4676 : added onclick handler and update property pane config to table widget for column type image
added onclick handler and update property pane config to table widget for column type image

* added default value for onclick and remove extra check

* updated TableUtilities test case

* updated cypress test Table_spec
2021-07-09 17:51:51 +05:30
Bhavin K
16e7297021
Feature/table multi select (#5074)
We have added checkboxes against table rows when multi selection is enabled. The end user can also select all rows now in click of a button. The related design has also been refreshed.
2021-07-07 11:22:10 +05:30
Hetu Nandu
c2a1c1feb4
Don't log debug level logs in prod (#5527) 2021-07-05 11:19:43 +05:30
Vicky Bansal
b6e205e5b2
Fix-Rename compact mode property in Table Widget to Row Height (#5496)
* Change compact mode title to Row height in property pane configurations
2021-07-02 16:57:20 +05:30
Bhavin K
96c6b3b80f
moved table property pane config (#5478)
In the table widget, The header options are not re-ordered below the Actions
2021-07-01 12:23:21 +05:30
Somangshu Goswami
9b1dbeb9dc
Revert "Enable total number of rows and page size for server side pagination in table widget (#4863)" (#5469)
This reverts commit related to #2230 & #1578. We will revisit this problem again and implement the solution based on the discussion in the thread.
2021-06-29 15:01:41 +05:30
Vicky Bansal
fe700a8049
Fixed empty area issue when columns are hidden in published mode (#5162) 2021-06-23 19:09:04 +05:30