Commit Graph

1582 Commits

Author SHA1 Message Date
Shrikant Sharat Kandula
89620d3cbf
Fix unused reactive publisher (#16732) 2022-09-13 18:08:35 +05:30
Shrikant Sharat Kandula
83fc89f1a1
fix: No-op Asserts (#16690) 2022-09-13 13:55:33 +05:30
Trisha Anand
becd778fe1
chore: Added username to error logs when signup is disabled (#16720) 2022-09-13 13:07:12 +05:30
Trisha Anand
aa45f851eb
chore: Minor code refactor + Deleting PermissionGroupServiceTest from CE (#16680)
Minor code refactor + Deleting PermissionGroupServiceTest from CE
2022-09-11 20:53:12 +05:30
Parthvi
e3ba513e2a
fix: Update AppsmithError.java (#16676)
Update AppsmithError.java
2022-09-11 00:06:26 +05:30
Sumit Kumar
0cbe81dfde
feat: merge GraphQL plugin to release (#16554)
* merge GraphQL plugin to release
2022-09-09 21:29:47 +05:30
Vishnu Gp
43ee8b2089
chore: Changes in user invited analytics event (#16611) 2022-09-09 10:31:18 +05:30
Anagh Hegde
4d609a5b4d
feat: Add non-configured datasource to merge template to an existing app API response (#15918)
Add unconfigured datasource to merge template to app API
2022-09-08 22:55:47 +05:30
Dhruvik Neharia
c87fd20b02
feat: Update QR Scanner Themes to Code Scanner Themes (#16595)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-08 15:04:12 +05:30
Trisha Anand
96435ac235
chore: Using single permission group for all public viewable objects (#16620) 2022-09-08 11:37:12 +05:30
Trisha Anand
245a09ae21
fix: Duplicate default workspaces for first login using SSO (#16606) 2022-09-07 14:11:04 +05:30
Anagh Hegde
274205196f
test: refactor git test (#16550)
* Refactor tests

* Use Mock.Spy to mock the method of the testing class

* Add the mock for new workspaceId in the test class

Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-09-07 10:21:09 +05:30
Shrikant Sharat Kandula
06c8210a3a
fix: Fix LinkageError with macOS DNSResolver class (#16581)
On macOS, when running a MySQL query, we see the following error:

```
java.lang.ClassCastException: class io.netty.channel.kqueue.KQueueEventLoopGroup cannot be cast to class io.netty.channel.EventLoopGroup
```

This is because of a `LinkageError`, caused because these classes exist both in the parent `server` module classpath, as well as in this plugin's classpath separately. To fix this, we removed this dependency from the server module.

But then, this caused a problem with how the `DNSResolver` class was being, well, resolved by the application class loader, vs the plugin class loader. This is a macOS specific problem, and doesn't affect other operating systems.

For this, we add just this package as a dependency to the MySQL plugin.
2022-09-06 22:00:53 +05:30
Trisha Anand
70bb40d5c5
fix: Creating default workspace for SSO signed up users before creating first application (#16579) 2022-09-06 12:55:07 +00:00
Trisha Anand
9cf3714d36
chore: Code Split for Policy Generator (#16538) 2022-09-05 20:40:52 +05:30
Vishnu Gp
75a9858397
chore: Added some changes in authentication analytics events (#16432)
* chore: Added some changes in authentication analytics events

* Review Changes
2022-09-05 10:46:59 +05:30
Trisha Anand
97a651c6a5
chore: update-bad-theme migration should only run once. (#16507)
Update bad theme migration should only run once.
2022-09-04 21:04:20 +05:30
Trisha Anand
918c018049
fix: Performance improvement of /new API by updating the api used for fetching apps. Eliminating public applications from the result (#16497) 2022-09-03 22:33:29 +05:30
Trisha Anand
8c4451a2fe
fix: Duplicating themes where 1:many applications mapping exists (#16496) 2022-09-02 22:39:21 +05:30
Dhruvik Neharia
f97cd4c38a
feat: Add QR Scanner to System Themes (#16474) 2022-09-02 17:06:34 +05:30
Nidhi
29fe999dc7
chore: Converted server log timestamps to UTC (#16475) 2022-09-02 13:09:12 +05:30
Shrikant Sharat Kandula
8a0838505a
All outgoing requests should go through the configured proxy (#14427)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-01 11:16:45 +05:30
Anagh Hegde
b53dc1d47f
chore: Refactor repo limit check function (#16356)
* Refactor repo limit check function

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitServiceCEImpl.java

* Fix the repo limit check

Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-01 08:53:27 +05:30
Trisha Anand
0163c22003
fix: For a public app, do not export the default permission group (#16409)
* For a public app, do not export the default permission group

* Adding test to assert that exported application JSON is not public.
2022-08-31 10:44:32 +05:30
Vishnu Gp
fa31166eaa
fix: Added analytics event for workspace creation (#16383)
## Description
This adds the missing analytics event for workspace creation

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Locally

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-30 10:41:36 +05:30
Trisha Anand
8d9e071648
feat: Adding cache eviction for users whose permissions change due to super user changes (#16362)
Adding cache eviction for users whose permissions change due to super user changes
2022-08-29 13:21:24 +05:30
Trisha Anand
a5e6d09ae8
fix: Super user updated from docker.env on every restart (#16351) 2022-08-27 23:04:39 +05:30
Trisha Anand
649fe2ec7c
chore: refactor code split for UserUtils for super user creation (#16348) 2022-08-27 21:39:17 +05:30
Anagh Hegde
043705f343
chore: refactor git constants (#16287) 2022-08-25 20:52:25 +05:30
Trisha Anand
8f3591615a
feat: RBAC framework (#14823)
Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
2022-08-22 23:27:07 +05:30
subratadeypappu
0e2637b1b2
chore: Modified action execution payload to support data types (#16106)
* POC: Datatype handling autogenerated naming params client

* added array and file datatype

* handles all primitive types

* paramproperties convetred to map instead of array

* parametermap inversion

* handled no bindings bug

* feat: Consume action execution payload changes w.r.t. data type mapping (#15555)

This commit does the following things
1. It consumes data type metadata from payload
2. It consumes the mapping between the pseudo binding name and original binding name
3. It doesn't apply any logic w.r.t. data type identification after consumption

* added comments and cleaned code with proper datatypes

* removed URLencoding for binding params names

* feat: Remove URL decoding on param keys from server-side codebase (#15555)

* Remove unused import (#15555)

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
2022-08-19 01:01:47 +05:30
Nidhi
cdb70066b6
fix: Logging execute events again (#16125)
Execute action triggered events were not getting logged because of a lack of subscription. Fixed in place.

## Type of change
- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Locally connected to segment

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-18 13:40:29 +05:30
Trisha Anand
48ab154cf1
chore: Removing debug feature flag logs from the server (#15931) 2022-08-11 12:50:37 +02:00
Nayan
8e38079a31
chore: Return custom slug in other api (#14854)
* -return custom slug in response to the get list of pages API

* -return custom slug for default page in home page API

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-10 21:52:24 +06:00
Vishnu Gp
2c03cecbb1
feat: Added more data to existing analytics events (#15684)
* feat: added more data to existing analytics events

* Added extra audit data points for page and action events

* Corrected minor comment issue

* Review changes

* Removed audit references in variable names

* Review changes related to sending analytics events and DB optimization
2022-08-09 13:05:00 +00:00
Anagh Hegde
82a9d720ae
feat: Added unconfigured datasources to the template API response (#15606)
Co-authored-by: Akash N <akash@codemonk.in>
2022-08-04 09:50:54 +05:30
Keyur Paralkar
bfd341510e
feat: added accentColor and fontFamily to the theme config chartwidget (#15622) 2022-08-03 11:47:01 +05:30
Nidhi
02aa9b29bf
fix: Reset sync function fields on each update (#15442)
* Reset sync function fields on update

* Partial cypress test

* Completed cypress test

* Uncommented every other test :P
2022-08-03 10:11:02 +05:30
Nidhi
7693c759aa
fix: Do not cache updatable connections (#15593)
* fix: Do not cache updatable connections

* Delete cache entries for stale connections

* Test fixes
2022-08-02 23:13:18 +05:30
Hetu Nandu
69490bbcbf
chore: Extend commenting deprecation deadline to 1.7.12 (#15616) 2022-08-02 10:02:34 +00:00
Shrikant Sharat Kandula
928a93d02e Fix OIDC session tokens support in Redis sessions
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-08-02 15:28:29 +05:30
Shrikant Sharat Kandula
de23ea9d61
feat: JSON Session serialization on Redis (#15368) 2022-07-30 00:42:56 +05:30
Vishnu Gp
7d8fca9545
chore: Fixed flaky ApplicationForkingServiceTests (#15550) 2022-07-30 00:34:23 +05:30
Shrikant Sharat Kandula
8619a311ad
Fix compile error 2022-07-29 15:16:43 +05:30
Shrikant Sharat Kandula
04f8d2799d
Fix potential delay in sending setup completion (#15534)
The Installation setup complete event is not getting sent sometimes, and it's behavior looks very much like there's some race condition somewhere. I'm proposing this change towards two goals.

One, currently, we send the event after the user-entered data is saved to the DB. But, there's no actual dependency, no point to waiting on that for sending the event. The actual user itself, is already created and signed up. So, one change is that we don't wait for the DB update to be applied. I'm also changing .onSuccess to .map, hoping that might make a difference.

Two, make a debug log entry to see if it is our callback function that's not getting invoked, or if Segment's API isn't doing it's job, when the event is not sent.

This PR also fixes formatting of Segment error messages.
2022-07-29 14:35:26 +05:30
Anagh Hegde
4821a5c141
fix: ssh url validation in git to include a few cases where - is present in the url (#15499)
Fix the ssh URL validation to include a few cases with `-` in the url
2022-07-29 10:44:19 +05:30
Nidhi
12e626d5b0
chore: Added isMock and isTemplate to action execution analytics (#15505)
Added isMock and isTemplate to action execution
2022-07-29 01:18:09 +05:30
Nidhi
daea0a8545
chore: Added analytics for C, U, D operations on actions (#15069)
* chore: Added analytics for C, U, D operations on actions

* chore: Added isTemplateOrMock field in datasource

* fix: Set mock datasource field as true on creation

* Split template and mock identifiers into two. Added them to analytics as well

* Added tests as well as felt like a noob.

* Add isMock and isTemplate fields to datasources of created Actions

* Removed execute action triggered props

* Revert "Removed execute action triggered props"

This reverts commit cad1b8af504218813daa5f563f7b417fa263101b.

* Stringified response body before recording event

* Adding ds fields

* Reverting client side changes

* Fixed failing tests

Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com>
2022-07-28 09:40:47 +05:30
Nidhi
6df4dafead
chore: Better server logging infra (#15440)
* Fixed a bunch of server side logging issues

* Tests

* Added ISO8601 timestamp to log format
2022-07-28 09:40:03 +05:30
Vishnu Gp
828f734b18
Added missing analytics events and extra data (#15408)
This adds a few missing analytics events and some more extra data for audit purposes. The missing event added are,

    User login (login_USER)
    User logout (logout_USER)
    Import Application (import_APPLICATION)
    Export Application (export_APPLICATION)
    Clone Application (clone_APPLICATION)
    Create Workspace (create_WORKSPACE)
    Delete Workspace (delete_WORKSPACE)
    View Page (view_NEWPAGE)
2022-07-27 21:01:34 +05:30