Commit Graph

1392 Commits

Author SHA1 Message Date
Satish Gandham
12f9a005ae
chore: Refactor getSelectedWidget selector (#16647)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Rename getSelectedWidget to getLastSelectedWidget in selectors/ui

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-15 05:44:11 +00:00
albinAppsmith
3beea62e44
feat: Updates modal new design changes (#16553)
* feat: Updates modal new design changes

* Title and Subtitle font changes

* test cases fixed for product updates modal
2022-09-14 10:40:48 +05:30
NandanAnantharamu
642cdb886b
test: updated locator with wait for flaky test (#16734)
updated locator with wait
2022-09-14 08:39:09 +05:30
Parthvi
ca64ceb4fb
test: update cypress test fork_template_spec (#16719)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-09-13 12:50:09 +05:30
NandanAnantharamu
6f45430395
test: updated test and dsl (#16656)
updated test and dsl
2022-09-13 11:56:37 +05:30
balajisoundar
afb9aa93c1
feat: Table widget V2 Inline editing validation for plain text & number column (#15954) 2022-09-13 11:11:59 +05:30
Ayangade Adeoluwa
342c5cc673
fix: Fix Api url path issue (#16628)
* Fix Api url path issue

* Modify test cases
2022-09-13 05:02:59 +00:00
Ayangade Adeoluwa
b3c4f7c392
feat: AST apis for parsing script and returning identifiers (#16252)
* rts configurations for ast

* update shared dependencies.json for shared ast module

* feat: api for script to identifiers

* fix: typo for identifiers

* feat: api for multiple scripts to get identifiers

* fix: rts config, apis for ast

* fix: removed unnecessary changes for ast modules

* fix: docker image for rts including ast shared module, rts file alias ref

* fix: added comments in build.sh file

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-09-12 14:45:47 +05:30
Aishwarya-U-R
bdadb827e3
test: Script updates for flaky tests (#16631)
* CreateNewApp spec flaky fix

* fix

* Moved RepoLimit to commented files

* Inline spec failure fix - case 19

* Table FIlter specs V1/V2 split

* Binding/Table_Property_ToggleJs spec - V1/V2 fix

* Spec name update

* Wait increase

* DS - duplicate error capture fix

* revert

* Recaptcha spec fix

* Jsfun exe flaky fix - unskipped case

* jsfunc exec spec fix

* jsfunex spec fix

* Api bugs spec fix

* Api bugs spec fix

* Chartdata point spec flaky fix

* Theme_multiselect brown type fix

* Jsfunc exe spec fix

* Inline spec fix

* Inline spec fix

* Inline spec fix

* Theme multiselect spec fix

* Promises spec fix

* JSFun Exe spec fix

* Api_all verb methods update

* List1 spec 4th case fix

* Jsfun exe skipping 10th case

* jsunf exe 10th case trial fix

* firestore stub error capture

* jsonload failng spec skip

* JSonload spec fix

* json load spec fix

* Git repo moved back
2022-09-12 09:48:44 +05:30
Parthvi
ee8259d311
test: Fix flaky git tests (#16675)
* fix flaky git tests

* undo skip for git import tests
2022-09-12 08:59:06 +05:30
arunvjn
7d0dae89d8
fix: Better autocomplete for fast-xml-parser (#16452) 2022-09-09 22:07:33 +05:30
Sumit Kumar
0cbe81dfde
feat: merge GraphQL plugin to release (#16554)
* merge GraphQL plugin to release
2022-09-09 21:29:47 +05:30
Tolulope Adetula
b4b4284a56
fix:allow clear button in tree select widget (#16542)
* Fix: tree select allowClear button

* fix: import duplication

* Fix: add tests for bug

* fix: Add Placeholder fix

* fix: test case

* fix: remove comments
2022-09-09 04:55:31 -07:00
NandanAnantharamu
14140c10b7
test: fix for flaky test (#16534)
* updated test

* updated test

* uncommented the working tests

* updated test to avoid flakiness
2022-09-08 18:41:20 +05:30
Keyur Paralkar
e7209f06fd
feat: Table widget checkbox column type (#15933)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix: type casting issue for sectionName

* fix: addressed review comments

* chore: removed unused imports

* fix: added prop.hidden comparision in the memoized PropertySection component

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-08 16:35:59 +05:30
Arpit Mohan
8590308945 ci: Commenting out the test for git repo limit check
This test needs to be improved to hit TED instead of the Github API
2022-09-08 02:35:06 +05:30
Arpit Mohan
15ddca66c8
ci: Removing the git repo limit test as this test will fail in EE. (#16622)
We need to organize the Cypress test suite in a way that we have different checks running in CE vs EE.
2022-09-08 00:41:48 +05:30
Aishwarya-U-R
bf232dbb7e
test: Script updates for flaky tests (#16558) 2022-09-07 23:55:55 +05:30
Ayush Pahwa
e53045de5a
fix: updating trigger meta to get the source of console logs (#16520)
For nested functions, the trigger meta is not available for subsequent functions. So in cases where the dynamic trigger has the relevant info, we can use that to update the trigger meta and then use that meta to display the source of the logs.

Fixes #16515
Fixes #16483
Fixes #16514

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-07 11:53:47 +05:30
Aishwarya-U-R
353e007e78
test: Script updates for flaky tests (#16533)
* Autosave trial fix

* json form field flaky fix

* js fun exe spec flaky fix
2022-09-06 08:59:39 +05:30
Aishwarya-U-R
06cd7542f5
test: Script updates for flaky tests (#16455)
* UUID table load time increase

* Autocomplete js api failiure fix

* mysql crud fix

* MySQL, Postgres CRUD updates

* flaky fix

* flaky fix

* Upgrade Appsmith spec - moved

* MySQL CRUD spec split

* fix

* fix

* fix

* fix

* Postgres CRUD spec split

* Postgres CRUD spec split

* fix

* EE names update

* fix

* fix
2022-09-05 15:24:56 +05:30
Tanvi Bhakta
a308d564f7
chore: bump ds version (#16488)
* update to v1.0.12

* bump ds version

* bump ds version (again)
2022-09-05 15:24:00 +05:30
Aswath K
8b297e4da1
chore: Property pane design changes (#16112) 2022-09-05 10:22:39 +05:30
Ayush Pahwa
7d621de978
feat: console log implementation in appsmith (#16286)
* feat: capture console from across the app (#15676)

* create: console override file

- Adds methods to override the given console functionality to capture the console statements written by the user

* update: evaluate function to extract console op

- Added logs extraction for both sync and async functions
- Adding them to the return object of the evaluations

* update: timestamp field to log addition method

- Added optional argument to function definition for inputting the timestamp of the log
- This is done to maintain timings of the execution of the log

* update: interface for log objects

* update: post function execution logic

- Added logic to push the logs generated by the evaluation to the logs store

* update: added handling for sending nested fns

- While console logging functions or objects that had functions was causing an error
- Added a check for removing functions and replacing them with name of the functions instead

* chore: added types and comments

* fix: updated evaluation tests

* fix: added check for log in returned obj

* update: added the source data in the trigger logs

- Removed on js execute logs from showing up here since they are already handled. If they are not removed, they will show up on the first page load twice

* add: ellipsis function for log title string

- This is to keep big object contained in the first line only

* update: made logs reset function public

* update: resetting logs before new eval

- Logs object has to be cleared before next eval can happen to make sure there are no roll overs from last evals

* chore: added comments

* add: extracting logs after eval of functions

* add: storing logs to redux after eval

* refactor: updated types

* add: func to store logs w/ severity as arg

* refactor: updating func call for user logs

* chore: fixed elipsis logic

* chore: removed unused type

* chore: updated preview text logic

* add: type for transfer object post eval

* update: aded new userLogs obj to dataTreeEvaluator

* update: passing logs from object to saga

* update: parsing received userlogs

* refactor: used predefined fns

* refactor: moved resetlogs to common func

* chore: updated comments

* feat: update redux store and UI for system + user logs (#15936)

* update: updated types for the redux store

- Added category and data fields in the log object

* update: types of log redux store

* update: calls for the console log store function

* update: icon fetch func for log item UI

* update: syncing UI with the new designs (WIP)

* chore: fixed lint error

* update: filters for logs

* update: icon for clearing log filters

* update: filtering function

- Added checks against category and severity

* update: logitem UI

- updated type of the UI object
- added css based ellipsis
- added toggle for console logs
- added array of json views for objects/arrays
- css tweaks

* update: debugger cta

- Removed copy option
- Updated UI

* update: logic for expanding user logs

- Removed debugger CTA
- Fixed position for the expand/collapse icon
- Added joining char for when the log is expanded

* update: assets for new UI

- updated colors
- Added new icon

* hotfix: ternserver code

* add: search across the text of log

* update: icons for the app

* update: click to expand/collapse of logs

* fix: search keyword update on change within JSObjects

* fix: alignment of log items in both states

* update: jest tests for debugger errors and filter

* fix: drop down options color issue

- the icon used was not the standard one
- We have a lot of duplicates of the same icon

* fix: synced with ADS changes on release

* fix: remove dependency from old icon

* add: cypress selectors for automation testing

* fix: replaced static messages with variables

* fix: updated the dependency map for filter

* fix: height of the filter drop down

* fix: chaining logic for search filter

* fix: syncing the padding values to ADS

* fix: help icon visibility issue

* fix: width of filter dropdown

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>

* add: e2e tests for console statements using IIFE

* test: added test for console logs in jsobjects

* fix: functionality of expanding context menu on msg click

* fix: added try catch and handling for numbers

* hotfix: handling unwanted toasts

* fix: alignment and clickable cursor

* fix: alignment of expanded span in console logs

* add: analytics event on new console log created

* fix: added handling for boolean and undefined

* fix: removed log reset from common func

- Whenever we are creating global DTO, the logs were being reset. This caused logs to reset whenever a promise was encountered in the logs.

* fix: combined JS log saving to widget process

* add: new analytics event on filter changed

* update: added handling for empty value

* update: removed comma between multiple logs

* update: synced test changes with release

* update: removed unused wait timings

* Logs spec script update

* update: ts methods in log spec e2e test

* logs spec update

* update: removed body clicks from test script

* Logs spec update

* update: removed ask from google option

* refactor: ui fixes

* fix: text selection of logs

* fix: updated dropdown width management

* update: made the flushlogs function async

* update: added handling for promises

* update: added test with promises fail and pass

* fix: added sync variant to work for sync objects

* refactor: commented out unused tests

* update: exceptions in the name of log entity

* fix: pagination of logs to handle dynamic data stream

* fix: removed unused async function

* fix: moved logs handling to separate saga

* fix: color for context menu text

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-04 17:28:05 +05:30
Arpit Mohan
763261716b
chore: Fixing lint errors in the Cypress code base (#16504) 2022-09-03 23:57:41 +05:30
Aswath K
db08b16d4e
feat: Grouping & reorganisation of Property Pane (#15768)
* Removes feature flag from Client code

* Updates Cypress tests
2022-09-03 18:20:39 +05:30
Ankita Kinger
e28e89807c
feat: Refactor invite modal for handling RBAC updates (#16405)
* refactored code for invite modal changes for rbac

* code splitted some more files for refactoring invite modal component

* removed unused imports

* created new variable for handlers

* updated an import

* reverted a change

* refactored a section of code

* fixed a cypress test

* fixed a cypress test

* updated imports

* exported some entities
2022-09-02 22:45:08 +05:30
akash-codemonk
9bb1ad64ee
fix: welcome tour ending on page refresh (#16079) 2022-09-02 18:45:48 +05:30
sneha122
990692cc81
fix: gsheets insert command placeholder issue fixed (#16441)
gsheets insert command placeholder issue fixed

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-09-02 12:32:51 +05:30
Aishwarya-U-R
4bf0827763
test: Script updates for flaky tests (#16355) 2022-09-02 06:35:45 +05:30
Ayangade Adeoluwa
80fa2c2713
fix: Blocks shortcut action execution when git modal is open (#16248) 2022-09-01 22:55:22 +02:00
Souma Ghosh
ca11be276f
feat: Add new pageOffset binding to Table Widget (#16083)
* feature: Add new pageOffset binding to Table Widget

* Add jest tests
Modify getPageOffset to account for failed tests

* Review changes

* take page size as tableData.length when Serverside pagination is on

* Update bindings count in cypress test for table widget v2

* Changes default value of pageOffset to 0
Use pageSize instead of tableData.length when tableData is not available

* Update jest tests according to changes in the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-01 15:31:02 +05:30
NandanAnantharamu
655dbbdf8d
test: added some more assertions (#16418)
added some more assertions
2022-09-01 14:03:52 +05:30
Souma Ghosh
3d40780d94
fix: Table reverts column positions on sorting if columns returned differ (#16237)
* fix: Table reverts column positions on sorting if columns returned differ

* Adds Cypress tests

* Update cypress tests to reorder column and validate

* Adds another assertion to table column order cypress test
2022-09-01 11:40:19 +05:30
Tolulope Adetula
6bed5a3b7a
fix: TreeWidgets issues (#16401)
* fix: TreeWidgets issues

* fix: make FlattenedOptions derived props

* feat: add more test cases

* fix: test issues
2022-09-01 06:40:04 +01:00
arunvjn
fce2352599
fix: fast render form elements in UQI query editors (#16199) 2022-09-01 10:41:57 +05:30
akash-codemonk
c9ac2e9568
chore: show template fork modal based on query param (#16193) 2022-09-01 09:28:04 +05:30
Ayangade Adeoluwa
0e49c6efa9
fix: replace action execution cancellation toast errors with a better one (#16277)
* Remove error messages when user cancel action executions

* Add toast message after user cancels action execution

* Change error message

* Cypress validation for Bug #1609 added

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-31 18:08:42 +00:00
Rishabh Rathod
55082812b2
revert: "fix: dataTree mutation (#15952)" (#16406)
## Description

This reverts commit dbcc643ccf.

Fixes #16378

## Type of change

- Revert changes which impacted performance

## How Has This Been Tested?

Manual performance verification 

@ramsaptami 

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
2022-08-31 13:38:17 +00:00
Arsalan Yaldram
4c9484935b
fix: Property pane dropdown for currency and phone input widgets. (#16379)
* fix: Property pane dropdown for currency and phone input widgets.

* fix: added focus on open, added test cases
2022-08-30 11:33:31 +05:30
Aishwarya-U-R
f627b1ea8b
test: Script updates for flaky fixes (#16350)
* Table adding more wait time

* theme multiselect trial fix

* Ds form spec flaky fix

* TableV2 filter spec - app crash fix

* theme multiselect flaky fix

* ds form spec + community issues flaky fix

* spinner validatio added

* Theme_multiselect fix

* Json query run flaky fix

* DS add click flaky fix

* ds + locator update

* Skipping upgrade tests until fix

* Arango flaky fix

* Mongo.js flaky fix

* MySql CRud spec time increase

* ReadTableRowColumnData timeout increase
2022-08-29 04:36:17 +05:30
arslanhaiderbuttar
e60375cd02
test: Upgrade appsmith (#16203)
* Added test cases for appsmith upgrade

Added test cases for appsmith upgrade

* deleted extra commands

* add new workflow for upgrade scenarios

* updated the s3 details

* update command.js

* updated the work flows

* Removed the conflicting part with TED

* Update commands.js

* TED run command updated

* removed async calls

* added commands to start the v160

* updated few steps

* added debugging updtream step

* changed the paths

* dynamic port numbers

* dynamic port numbers

* removed the port numbers

* removed debug from the workflows

* increased timeout

* changed the path

* fixed the after all hook

* fixed the stop container
2022-08-28 11:28:01 +05:00
Aishwarya-U-R
3b90baf1d8
test: Script updates for flaky fixes (#16289)
* Auto completre fix

* Toast fixes

* Autocomplete js fix

* datatree mutation spec update

* Datatree -added  running api

* rmeoved unused ref

* Deletion time added

* Community issues spec fix

* AssertImportToast() update

* QueryAbort case fix

* Signature fix

* update

* UUID flaky fix

* Pomises spec + toasts updates

* Toasts updates

* ErrorReporting spec fix

* Scrolling mockdb fix

* Bug tests name change for easy identification

* bug spec file name update

* JSfunc fix

* Community issues table load time increase

* AssertContains() reduced wiat time

* AssertContains() update

* timeout added to mysql crud

* AssertContains revert

* AllInputWidget trial fix

* wait until table load ReadTableRowColumnData()

* fix

* testTimeout added

* ReadTableRowColumnData() revert

* path fix

* WaitUntilTableLoad() revert

* COmmunity issues row select fix

* Faker added

* wait time add for multiselect

* Mulipart fix

* Community issues spec fix

* AllInput spec update

* timeout 1 to 3

* update

* update

* EnterJSContext from JSEditor to PropPane ts

* update

* Removed unwanted comments

* fix

* UUID fix
2022-08-27 18:10:11 +05:30
Rishabh Rathod
dbcc643ccf
fix: dataTree mutation (#15952) 2022-08-24 22:06:54 +05:30
Aishwarya-U-R
f2c6e1ed61
test: Script updates for flaky fixes (#16143)
* Remove mongo coll dataset

* JSEXe spec flaky trial fix

* AbortActions to ts

* js func exe fix

* Abort spec fix

* Appsmith down flaky fix

* SelectWidget bug 12531 comment

* JSfun exec spec flaky fix

* Scrolling spec fix

* mysql crud fix

* mySql crud fix

* CRUD generate page fix

* jsonload flaky fix

* Automcomplete spec update

* jsOnload-1 spec flaky fix

* http patch

* patch install

* patch path correction

* cypress instal force

* removed

* yarn

* adding dev

* applypatch path corrected

* patch fix

* patch update

* patches

* patch file name update

* Adding blureprint patch back

* Cypress install removed

* Removed .only

* Autocomplete + Abort spec fix

* CI run key press fix

* https proxy update path fix

* JS editor parsing delay handle

* Autocmplete js fix

* Abort Query added

* Removed  "dev": "cypress open"

* js func exec spec fix

* js editor type flaky fix

* GetNClick revert

* Saving JS editor aft removal

* JS specs flaky fixes

* JSfun flaky fix

* Auto complete spec fi

* jSonkoad1 spec fix

* JSOnload spec

* Auto complete JS spec fix

* Removing waiting for toasts

* jsfun fix

* EditJSObj Preetify update

* contains index or colection

* SetQueryTimeout update

* DS toasts handle

* POstgresCRUD toast change

* POstgres CRUD toasts fix

* Bug 15372 spec toast fix + Api timeout update

* Added DeleteDSDirectly()

* Arango spec fix

* JSEditor indent spec - 6 fix

* JSeditor indent spec update 7, 1,2

* removed only

* JSEDitor Indent spec fixes

* removed only

* MySQK CRUD fixes

* BUg 14006 spec fix

* Mongo spec toast fix

* Mongo update

* text wrapping spec flaky fix
2022-08-24 19:53:41 +05:30
Dhruvik Neharia
11d33b79cd
feat: Add USA to the Map Chart Widget (#16130)
* feat: Add USA to the Map Chart Widget

* test: Add USA test to Map Chart Cy Spec
2022-08-24 13:49:24 +05:30
balajisoundar
38f9661e45
fix: Table widget pagesize in short row height mode (#16045) 2022-08-23 17:19:59 +05:30
Rimil Dey
b502332076
fix: catch block not working in firefox and safari for async functions (#15376)
* Add error.message only to data.reason, since the call stack being sent to responsePayload is different for different browsers. This fix ensures a consistent behaviour across all browsers

* Add integration tests

* Update test to typescript

* Fix error message

* Use new error instead of message object

* Code review fix

* Add else block to catch unknown errors

* Update tests

* Get back to original solution - error solution not working in safari
2022-08-23 11:32:31 +05:30
Trisha Anand
8f3591615a
feat: RBAC framework (#14823)
Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
2022-08-22 23:27:07 +05:30
Rishabh Rathod
83d30b8d05
fix: autocomplete fixes & enhancement (#15857) 2022-08-22 11:17:24 +05:30