Commit Graph

8706 Commits

Author SHA1 Message Date
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Satish Gandham
abf7277d20
Merge pull request #4240 from appsmithorg/perf/optimize_react-json-viewer
Memoize CurrentValueViewer to prevent expensive rerenders of react JSON viewer
2021-05-05 18:18:05 +05:30
Trisha Anand
218ac82e7f
During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path. (#4315)
* During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path.

* To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist.

* Revert "To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist."

This reverts commit c494932289e33287074c56844fbf76c8418875af.

* Disabling cypress test which asserts cyclical errors when depending on yourself
2021-05-05 17:55:39 +05:30
Rishabh Saxena
95f3cb8a9a
Log an analytics event for cyclical dependency errors (#4323) 2021-05-05 16:51:15 +05:30
Trisha Anand
6cf3b8a901
In case the chart series data id starts with a number, it was incorrectly identified as a number instead of a string which led to incorrect path computed to check in binding paths (#4322) 2021-05-05 16:50:59 +05:30
Paul Li
ee47510fac Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-05 05:29:46 -04:00
Paul Li
4be80b665a FEATURE-4135 : Table URL columns pretty link
-- Remove the anchor tag wrapping display text
-- Make display text case-sensitive
2021-05-05 05:26:57 -04:00
Kaushik Varanasi
984119e9cb
Feature: auto create organisation Fixes #2720 (#3922)
* added basic function structure for creating organization

* added functionality for automatically creating an organization with 'Untitled organization 1' like applications. Need to add tests.

* added test for creating organizations with default names

* added tests for creating org with default name

* updated jest tests to not fill in the organization form

* remove unused imports

* deleted unnused files

* added more test to check invite users to application and check that the create application is visible

* updated share application tests according to the new workflow

* fix failing tests. TODO: fix tests with renameRandomOrg to rename specific org

* remove rename random org and rename specific orgs

* remove blocking code so the element can be scrolled into view

* fix tests

* try to fix flaky tests

* remove unused

* remove create organization tests as we are testing these components elsewhere

* fix failing tests by stubbing create org response

* update tests according to new workflow
2021-05-05 12:40:35 +05:30
vicky-primathon.in
e96fa63f6d Disable client side search when server side search is enabled in table widget 2021-05-05 12:39:15 +05:30
Somangshu Goswami
fd6709b29a
Merge pull request #4119 from appsmithorg/fix/date-input-edit
Fix date string parsing for date from input field
2021-05-05 12:08:16 +05:30
Somangshu Goswami
0a0d9794dd
Merge pull request #4099 from appsmithorg/fix/#3860-input-widget-validation
[Bug] : Input widget validation issues#3860
2021-05-05 12:06:59 +05:30
Somangshu Goswami
6d41a4eb27
Merge pull request #4211 from appsmithorg/fix/4134-table-filter-case-insensitive
Fix/4134 table filter case insensitive
2021-05-05 12:02:27 +05:30
Nidhi
6894d66102
Merge pull request #4312 from appsmithorg/fix/reset-tests
Resetting cypress in CI
2021-05-05 11:54:35 +05:30
bhavin
a29b20eca5 fix: set date picker calendar popover position to bottom 2021-05-05 11:53:59 +05:30
Nidhi
756bdcc573 Resetting cypress in CI 2021-05-05 11:43:47 +05:30
Satish Gandham
4543bcc39e Add eslint rule to warn against inline functions in jsx 2021-05-05 11:37:12 +05:30
vicky-primathon.in
ba2d9e1ed2 Added cypress test to validate email parsing 2021-05-05 11:30:33 +05:30
vicky-primathon.in
53b99c1a34 Fix email parsing issue in text widget 2021-05-05 10:59:49 +05:30
abhishek nayak
10b8cdc32a
Update WidgetConfigResponse.tsx
Edited default table column size to remove scrollbar
2021-05-05 03:36:21 +05:30
Paul Li
e1be6ad940 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-04 15:53:24 -04:00
Paul Li
a5a0e0d85d FEATURE-4135 : Table URL columns pretty link
-- Add displayText field into property pane
-- Display urls based on displayText
-- Fix url alignment issue
2021-05-04 15:48:40 -04:00
Nidhi
96123890cd
Merge pull request #4296 from appsmithorg/release
Fixes for broken evaluation
2021-05-04 22:49:00 +05:30
Abhinav Jha
b508e37387
Fix DEFAULT_OPTION_VALUE validations which were breaking evaluations (#4295) 2021-05-04 22:42:15 +05:30
akash-codemonk
6ad40de1e5
Fix undefined error in debugger sagas (#4291)
Use correct types and check if validationMessages exists as it could be undefined
2021-05-04 20:12:42 +05:30
Satish Gandham
611a07af75 Add eslint rule to sort destructure keys 2021-05-04 19:45:29 +05:30
Sumit Kumar
1286af4285
fix for NPE (#4288) 2021-05-04 18:39:45 +05:30
Apeksha Bhosale
8473226382
app crashes when moving from google to rest api (#4282)
* app crashes when moving from google to rest api

* wrong url for test
2021-05-04 18:38:20 +05:30
bhavin
5f9497a627 date format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss' 2021-05-04 16:39:05 +05:30
Satish Gandham
adb5f7bc7a - Memoize ReactTableComponent 2021-05-04 16:30:57 +05:30
Nidhi
bba2591aba
No tests (#4284) 2021-05-04 15:49:47 +05:30
Rishabh Saxena
99c302e018
Fix update application test (#4281) 2021-05-04 14:31:19 +05:30
Shrikant Sharat Kandula
568c0f92ac Merge branch 'release'
# Conflicts:
#	app/client/public/privacy-policy.html
#	app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java
2021-05-04 13:16:26 +05:30
Satish Gandham
30b33331a2
Fix cyclic dependency making the table widhget crash the app. #4209 (#4214)
- Check if sanitizedTableData is array

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-05-04 13:04:35 +05:30
Kaushik Varanasi
7af0faa32e
Feature: Fork apps across orgs : fixes #3089 (#4121)
* create basic button for forking

* added menu item for fork, opens a basic modal. TODO: Add functionality to fork

* clicking fork app enables organization select and forks across applications

* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible

* removed unused code

* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing

* tests fixed, but needs unexpected login from cy

* Resolved bug with login by using correct cypress selectors

* Added tests to check that dsls match, added documentation and removed unused code

* remove unused fork function and directly dispatch from modal

* refactor code

* revert

* removed unused code and refactored tests

* feature/fork-apps-across-orgs-refactor

* make code prettier

* renamed components correctly

* refactored modal code into single file. TODO: fix warnings, test and remove unused code

* pass setModalClose to dialog component to maintain global modal state

* Added types for fork modal props

* update tests and remove unused code

* Removed isDeployedApp and instead passed trigger as a prop

* remove console logs and revert imports to small case

* rename files as components

* minor changes

* cleanup

* mock dispatch for jest

* move jest mocks to component tests
2021-05-04 11:34:23 +05:30
arunvjn
da0abfb2bf
CSS fix to wrap long urls/text in json viewer (#4269) 2021-05-04 11:17:09 +05:30
Satish Gandham
2a3d0fd28e - Destructure TableComponent props 2021-05-04 00:12:21 +05:30
Nidhi
e855123542
DB change for SAAS editor UI component (#4268) 2021-05-04 00:05:48 +05:30
Nidhi
8596f51921
New privacy policy (#4267)
* New policy

* Minor styling
2021-05-03 22:54:03 +05:30
abhishek nayak
edfe965cf7
Merge pull request #4248 from appsmithorg/areyabhishek-patch-2
Update WidgetConfigResponse.tsx
2021-05-03 20:28:44 +05:30
arunvjn
2956953955
Feature/gsheet warning modal (#4258)
Added modal to inform the users about google sheet warnings and events to monitors sheets usage.
2021-05-03 17:43:37 +05:30
Nidhi
446220515f
Added limited use disclosure (#4261)
* Added limited use disclosure
2021-05-03 16:28:51 +05:30
Shrikant Sharat Kandula
d950aeca22
Check for error class type before casting (#4256) 2021-05-03 16:13:26 +05:30
Satish Gandham
e3b361a8d4 Change inline functions in jsx to class properties 2021-05-03 14:33:03 +05:30
akash-codemonk
c36b1ffa04
Update debugger analytics events (#4186)
- Send analytic event for tab change in api and query pane

- Also update debugger text

- Send open debugger analytic event while opening from shortcut
2021-05-03 13:38:49 +05:30
Ashok Kumar M
4350da7da3
Fix: Updating help text for tabs widget after refactor. 2021-05-03 13:12:57 +05:30
Rishabh Saxena
81a2bfa067
Fix storybook build (#4087) 2021-05-03 11:19:12 +05:30
Pawan Kumar
923cbcd595
Fix: Validation on grid gap + handle delete child on list widget (#4247)
* handle delete case for list widget

* add check for grid grap validation

* update test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-03 10:31:47 +05:30
abhishek nayak
782afcc6b0
Create WidgetConfigResponse.tsx 2021-05-01 04:57:16 +05:30
abhishek nayak
7623b99830
Update WidgetConfigResponse.tsx
1. Changed default text of dropdown widget, and radio button
2. Changed the font size of title of form widget to heading1 from paragraph
3. Changed default location of Google maps widget
2021-05-01 04:25:37 +05:30
Confidence Okoghenun
924dd58312
chore: Adds office hours update for Apr 29 2021-04-30 22:56:43 +01:00