Commit Graph

6439 Commits

Author SHA1 Message Date
Apeksha Bhosale
ac97e51294
fetch js collections after page clone (#10147) 2022-01-07 08:58:40 +00:00
Pranav Kanade
82cbf718d0
refactor: code splitting to support third party sso/oidc in EE (#10201)
* added config to support code split

* splitting config

* moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* updated jest config

* updated third party login registry class
2022-01-07 11:38:17 +05:30
Arpit Mohan
07ad5aadee
chore: Fixing client build because of unused variable (#10221) 2022-01-06 23:02:05 +05:30
haojin111
f4bcb69589
fix: issue with merge button not visible after switching branches post merge, handle merge error (#10141) 2022-01-06 22:07:51 +05:30
balajisoundar
1b654fc943
chore: Skip bad table migration version 47 2022-01-06 21:45:45 +05:30
Aishwarya-U-R
ac705a49f3
test: Automated tests for RestApi Bug in Typescript (#10137)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix

* Bugs # 8595 & 10049 - Implemented

* Updating AGHelper methods to explicit public

* Reverting tsconfig.json

* tsconfig.json reverted

* Adding local tsconfig.json for Cypress tests

* fixture read updating for ts tests

* Updating .yml files to pick up ts files execution

* Including ts files for cypress run

* Running only ts test files

* Inclusion of TS files for cypress run

* Revert cypress.json to run all tests

* Added validation for Bug #10055 & commented

* Flaky fix
2022-01-06 20:36:17 +05:30
Suji Kim
c15445a92d
fix: Add white-space CSS to span tag (#9708)
Co-authored-by: goorm <goorm@RayKim.local>
2022-01-06 20:26:16 +05:30
Ayush Pahwa
3ab11fa942
feat: Add enable/disable functionality to form components (#10215)
* Added new condition type

* Added new variables to cater to enable/disable conditionals

* Adding functionality to disable the drop down control

* Added ability to enable/disable to dynamic input text fields

* Updated input text control to have enabled/disabled feature

* Added enable/disable functionality to FixedKeyInputControl

* Added enable/disable func to switch control and stanrdasied var name

* Added disable functionality for file picker

* Added enable/disable functionality to QUER_DYNAMIC_TEXT
2022-01-06 20:09:21 +05:30
Abhijeet
92a5cbf7f2
chore: Don't take client cancellation for git flows into account to keep the repo and DB in sane state even when client cancels subscription (#10036)
* Added Mono sink calls for git and import application APIs

* TC for import-export

* Update TCs for gitService

* Added git commit and create branch test

* Test added for midway cancellation flow
2022-01-06 20:04:35 +05:30
Hetu Nandu
656c9a5fa5
Fix action.run signature check (#10214) 2022-01-06 13:51:53 +00:00
Parthvi12
86a61edebb
test: added tests for import, export and fork application (#10202)
* added tests for import, export and fork application

* updating the forkedApp dsl
2022-01-06 19:12:13 +05:30
Ayush Pahwa
a0252da451
feat: Moving form evaluations to separate thread (8051) (#9437)
* Registering new eval types

* Moving code from saga to thread execution

* Added a loading state while thread is working

* Added types and comments

* Code refactor for final render

* Added custom spinner

* Instead of spawning a new thread, working on the same one

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-06 10:49:01 +00:00
Keyur Paralkar
cd68d70d2e
fix: added min width to wrap long page names (#10121)
* fix: added min width to wrap long page names

* fix: adjusted the width on editing for contextMenu

* style: moved the editing style in the contextMenu

* refactor: added custom classes
2022-01-06 16:04:36 +05:30
Ayush Pahwa
eec4527af4
feat: Connect drop down to redux state to fetch options dynamically (#10192)
* Connect drop down control to redux state to fetch options dynamically when needed

* Moved whole selection logic to mapStateToProps

* Removing unused imports
2022-01-06 10:03:20 +00:00
Anagh Hegde
ed490304d9
feat: Git import - generate and save SSH Keys (#9129)
* Added API to generate deploy keys and store them in a collection for import flow

* Add tests for the key generation flow

* Move the key generation to helper class

* changes per review

* changes per review
2022-01-06 15:16:33 +05:30
Paul Li
7992efae4d
fix: The date data in ISO 8601 format is throwing Invalid date on table widget (#10190)
-- Fix on wrong ISO8601 format token
2022-01-06 17:11:40 +08:00
Aman Agarwal
ac14726750
fix: run button loading infinitely due to query update when final and initial value remains same (#10189) 2022-01-06 13:04:28 +05:30
NandanAnantharamu
ddd852c5dd
Added test for file types (#10156) 2022-01-06 11:31:53 +05:30
Nayan
758d6d6725
fix: Fixed error due to string to instant serialization (#10074)
Fixes the serialization exception when exported application has deleted JSObject.

Fixes #9807
2022-01-06 11:13:25 +06:00
Ayangade Adeoluwa
9f836721f4
feat: Feat/uqi sorting component (#9775)
* Sorting component implementation with testing templates to be removed.

* add dsls implementation

* fixes delete item function, removes test cases

* removes test and unwanted files, adds enum to sorting control

* updated the form control from dropdown to dynamic text

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-01-06 00:29:24 +05:30
Pawan Kumar
028fe42dd2
fix: Select widget if set to required on initial state has red border (#9378)
* fix select widget error bug

* fix jest test

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-01-05 13:43:25 +00:00
Aman Agarwal
231e58adef
fix: run button loading infinitely due to entity update start action (#10149) 2022-01-05 17:03:38 +05:30
Paul Li
1f7be1877b
feat: support iframe.srcdoc in iframe widget (#8693)
* feat: support iframe.srcdoc in iframe widget

-- Add a new property srcDoc and its change handler
-- Rename handlers

* feat: Support iframe.srcdoc in iframe widget

-- Show error messages only if there are no both of URL and inline HTML

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-05 13:01:58 +08:00
Pranav Kanade
7861ce6915
feat: Add config to disable the form login (#10153)
* updated login/signup pages to use form login disabled config

* added env var config
2022-01-05 10:26:42 +05:30
Paul Li
c7e2d5a2bb
fix: When image url is not passed in both image and default field the rotate icons are still displayed in the widget (#8549)
-- Update showImageControl to true only if either of image or default image url exists

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-05 05:08:42 +08:00
ankurrsinghal
4281d3b5bc
fix: Added focus styling for switches in property pane (#10045) 2022-01-04 18:00:07 +05:30
Favour Ohanekwu
36629df853
fix: improve slash command conditional (#10102) 2022-01-04 10:29:23 +01:00
Favour Ohanekwu
b703ceb69f
fix: remove duplicate query params in evaluated value (#10101)
Remove duplicate query parameters in evaluated value
2022-01-04 10:27:38 +01:00
Satish Gandham
92cdeac090
feat: Add app import utility and perform the initial setup on CI (#10050)
- Run all files in the tests folder in sequence
- Better error handling and saving of screenshots
- Organise and refactor code. WIP
- Improve the summary generator
- Add utility method to import an app
- Add a basic performance test on imported app

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-01-04 13:58:47 +05:30
Daniel
84d6dae173
Merge pull request #10075 from appsmithorg/fix/active-datasources-page-scroll
fix: remove unnecessary spaces from the active datasource page for consistent page scroll
2022-01-04 09:26:44 +01:00
Anagh Hegde
48af7ea0df
fix: Merge and pull branch analytics NPE (#10117)
* Fix merge and pull branch issue

* fix detach remote API

* changes per review

* changes per review
2022-01-04 13:25:58 +05:30
Favour Ohanekwu
5036229b52
clear action data on page switch (#10104) 2022-01-04 07:42:06 +01:00
Yash Vibhandik
a6a462cf68
feat: #4141 added truncate support into text widget (#9820)
* feat: #4141 added truncate support into text widget

* fix: updated truncate show logic, cypress added

* fix: updated ellipsis position

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-01-04 11:51:02 +05:30
Anagh Hegde
4718f519a3
fix: sync branch issues (#9918)
* Error handling for git limit

* clear cahe of git limit on connect api

* update per review

* check the repo is public before checking for the limit

* changes per review

* check if the repo is public or private during connect flow

* fix issues with sync branches

* Add sucess error handler

* changes per review

* add missing return statement

* remove unused import statements
2022-01-03 11:42:58 +05:30
Nayan
50fd155d2f
fix: Unable to add comment to public apps (#10103)
Commenting on a public app fails if the user is not not part of the corresponding organization. This PR fixes that issue.
2022-01-03 11:59:35 +06:00
Vicky Bansal
c9ec218b79
fix: change recaptcha key and type and add suggestion for recaptchaToken (#9464)
* Change recaptcha key and type and add suggestion for recaptchatoken

* Add recaptchaToken property as target for auto completion cypress tests

* Added cypress test to validate recaptcha v2 can be selected in button widget property pane

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-02 08:27:39 -08:00
Leo Thomas
9cd89884bf
fix: 9648 The Update query fails to update for all matching Document in mongo (#9975)
* fix:9648 Mongo update All issue-In Progress

* fix: Mongo Multi update query fail fixes

* Added updated testcases that got affected by the code change

* Changes reverted as per review comments
2021-12-31 19:12:19 +05:30
Danieldare
605fb1962a Merge remote-tracking branch 'origin/release' into fix/active-datasources-page-scroll 2021-12-31 11:07:25 +01:00
Danieldare
d845394a3c fix: add condition and styles to check for active tab 2021-12-31 10:59:45 +01:00
Aishwarya-U-R
d71a873e16
test: Automated tests for Flakiness fixes (#10040)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix
2021-12-31 11:58:47 +05:30
Vaishnavi Joshi
946efd816c
Update OrgInviteUsersForm.tsx (#8910)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-31 11:12:26 +05:30
Keyur Paralkar
40ba88ce57
fix: added selectedOptionValue for index change in changeSelectedOption func Dropdown widget (#10047)
* fix: added selectedOptionValue for index change in changeSelectedOption func Dropdown widget

* test: added cypress test for select reset issue
2021-12-31 11:00:17 +05:30
arunvjn
6858a4f8d4
chore: Added snippet source analytics (#8546)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-31 04:49:17 +00:00
Danieldare
dc3da1b02d fix: remove unnecessary space from the active datasource page for consistent page scroll 2021-12-30 12:06:48 +01:00
balajisoundar
467f9ee1c2
fix: Allow empty value in multiple widgets options property (#10012)
- Checkbox group widget
- MultiSelecttree widget
- Multiselect widget
- dropdown widget
- radio group widget
- single select tree
- switch group widget
2021-12-30 14:57:44 +05:30
Vicky Bansal
f05c92603e
fix: Improper formatting for Input Widget for DataType currency (#9050)
* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Add comments for utilities formatCurrencyNumber and limitDecimalValue

* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Fix Input currency type cypress test

* Add comments for utilities formatCurrencyNumber and limitDecimalValue

* Fix upstep and downstep button action for formated currency input

* remove crendentials from cypress.json

* Fix input currency test flakiness

* Fix cypress test for currency input type

Fix formatCurrencyNumber function and added more unit tests

* Fix cypress test for currency input

Handle group separator and decimal separator when formatting and deformatting input for currency type

* remove console.log

* Handle formatting changes for default text

* Format input widget value for currency to handle default text

* remove unused import

* Add unit tests for getGroupSeparator and getDecimalSeparator functions

* add function to get user locale

* use preventDefault in input increment/decrement button click

* Use getLocale function, use String function

* use Number function for type conversion

* fix number to string type

* Handle 0 value for numbers

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-30 00:40:01 -08:00
Vicky Bansal
2d645b7e8d
fix: disable submit button when date is out of bounds (#9552)
* disable submit button when date is out of bounds

* Remove comment from derived.js function as comments are not allowed for parsing

* Fix table client side search cypress test

* validate date again min/max irrespective of isRequired property
2021-12-30 00:38:40 -08:00
Tolulope Adetula
54bb8bffe0
fix: rich text editor cursor fix (#9889)
* fix: rich text editor cursur fix

* fix: failing tests

* fix: debounce callback

* fix: Throw away any pending invokation

* fix: use SetTimeout for deboucing

* fix: markdown issues

* fix: onTextChange on page load

* fix: failing test
2021-12-30 00:01:45 -08:00
Keyur Paralkar
22e9da52ce
fix: changed the download icon in the table widget (#10065) 2021-12-30 12:12:02 +05:30
Nayan
abd4de1cd9
fix: Application is not publishable when imported without theme (#10009)
When we import an application from a JSON file where themes are not present, publishing the application fails. This PR fixes this issue.
2021-12-30 12:32:54 +06:00
Abhijeet
9cba2986f3
fix: Fix npe while importing application when JSObject contains only variables and no action (#10044) 2021-12-29 15:48:04 +00:00
Vicky Bansal
891f6aa22e
Revert "fix: Users unable to drag a column outside of viewport of a property pane to rearrange column order (#9944)" (#10056)
This reverts commit bbd2b41d7c. Skipping CI for this
2021-12-29 18:51:30 +05:30
Bhavin K
563984fc67
fix: added placement default value (#10025) 2021-12-29 17:32:37 +05:30
Bhavin K
323fa52455
feat: add progressbar widget (#9574) 2021-12-29 17:31:19 +05:30
Bhavin K
e995865b28
fix: updated columns names (#9715) 2021-12-29 17:12:07 +05:30
Abhijeet
d24703cdea
feat: Introduce version field for git JSON files structure (#9800)
* Introduce version field for applicationJson

* Update TC to check the version
2021-12-29 15:29:53 +05:30
Ashok Kumar M
96015deda3
fix: disallow drag to select for drop disabled canvas. (#9914)
* fix: disallow drag to select for drop disabled canvas.

* adding test case.

* fixing checkboxes dimensions.
2021-12-29 13:04:31 +05:30
Anagh Hegde
f921305e95
feat: Add analytics for BE git events (#9899)
* Add analytics for connect flow

* Add analytics for commit flow

* Add analytics events for git flows

* changes per review

* add reference to constructor

* Add error events to git analytics

* changes per review

* resolve conflicts
2021-12-29 07:23:03 +00:00
Yash Vibhandik
29687f9f12
feat: 8761 added optionAlignment property (#9696) 2021-12-29 07:22:10 +00:00
Aishwarya-U-R
3a4db6bdfd
test: Automated tests for S3 uploads & Mongo Bugs + Flakiness fixes (#9931)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()
2021-12-29 11:11:30 +05:30
Yash Vibhandik
cfd86cf5ba
fix: 6842 added property firstDayOfWeek (#9497) 2021-12-29 11:00:02 +05:30
Abhijeet
3bf43dc73a
fix: Filter the action and collection with no pageIds to fix server error while importing the application (#10024)
* Filter the action and collection with no pageIds to fix npe

* Added TC
2021-12-29 04:59:47 +00:00
Favour Ohanekwu
c96c0d4f3b
feat: Show evaluated value in embeddedDatasource url (#9198)
Show evaluated value in embeddedDatasource url
2021-12-28 13:14:32 +01:00
Abhijeet
4c5241bc93
fix: JS objects not getting copied over when app is duplicated while retaining the JS objects in original app (#10011)
* Create new action collection instead of updating the original collection 

* Update TC
2021-12-28 12:00:41 +00:00
Aswath K
56590ef253
feat: Add keyboard navigation for dropdown (#9561)
* Add keydown handler for DropdownContainer

* Add keyboard focus state

* fix: esc resets changed selection

* Add tests

* fix: Merge induced type issue with multi-select option

* fix: broken locator from #8777
2021-12-28 16:43:56 +05:30
Satish Gandham
c5abd3dd6f
feat: UI Performance Infra setup v1 (#9835)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-12-28 16:09:15 +05:30
balajisoundar
8c6bae6f71
fix: allow updating computed values of table widget in view mode (#9817)
* fix: allow updating computed values of table widget in view mode
* cypress tests
2021-12-28 12:45:28 +05:30
Snyk bot
703d47f7b1
chore: [Snyk] Security upgrade com.fasterxml.jackson.core:jackson-databind from 2.10.5.1 to 2.12.6 (#10014)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-2326698
2021-12-28 12:09:34 +05:30
Snyk bot
7e6a48c7b8
chore: [Snyk] Security upgrade com.fasterxml.jackson.core:jackson-databind from 2.10.5.1 to 2.12.6 (#10015)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-2326698
2021-12-28 12:08:53 +05:30
Abhijeet
b72ac43bd7
fix: Update defaultResourceIds with resource ids after the disconnect event (#9990)
* Update defaultResourceIds with resource ids after the disconnect event

* Update TC to check the applicationPage updates correctly

* Added TC
2021-12-28 10:57:50 +05:30
Vicky Bansal
bbd2b41d7c
fix: Users unable to drag a column outside of viewport of a property pane to rearrange column order (#9944) 2021-12-28 01:23:49 +05:30
imgbot[bot]
15ace470a5
chore: [ImgBot] Optimize images (#10019)
*Total -- 226.72kb -> 167.93kb (25.93%)

/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/EmptyApp.snap.png -- 20.32kb -> 13.87kb (31.78%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/apppage.snap.png -- 57.58kb -> 41.70kb (27.59%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/quickPageWizard.snap.png -- 59.08kb -> 42.85kb (27.47%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/loginpage.snap.png -- 35.57kb -> 26.33kb (25.96%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/emptyAppBuilder.snap.png -- 44.30kb -> 33.38kb (24.67%)
/app/client/src/assets/icons/widget/camera.svg -- 0.28kb -> 0.27kb (1.41%)
/app/client/src/widgets/CameraWidget/icon.svg -- 0.31kb -> 0.30kb (1.27%)
/app/client/src/assets/icons/widget/camera/exit-fullscreen.svg -- 0.51kb -> 0.50kb (1.15%)
/app/client/src/assets/icons/widget/camera/fullscreen.svg -- 0.36kb -> 0.36kb (1.08%)
/app/client/src/assets/icons/widget/camera/camera-muted.svg -- 0.69kb -> 0.69kb (0.84%)
/app/client/src/widgets/SwitchGroupWidget/icon.svg -- 1.60kb -> 1.59kb (0.61%)
/app/client/src/assets/icons/widget/camera/camera.svg -- 0.69kb -> 0.69kb (0.56%)
/app/client/src/assets/icons/widget/camera/microphone-muted.svg -- 1.63kb -> 1.63kb (0.42%)
/app/client/src/assets/icons/form/help-outline.svg -- 0.89kb -> 0.89kb (0.33%)
/app/client/src/assets/icons/widget/camera/microphone.svg -- 1.46kb -> 1.45kb (0.27%)
/app/client/src/assets/icons/widget/camera/camera-offline.svg -- 1.44kb -> 1.44kb (0.2%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-27 18:02:30 +05:30
rashmi rai
f6b9abdacf
feat: adding ads component for UQI (#8777) 2021-12-27 17:34:45 +05:30
Rishabh Saxena
7a0715af7c
chore: update error handling for git sync flows (#9998) 2021-12-27 12:25:54 +05:30
haojin111
8ed33db539
fix: minor fixes for the git sync flows (#9964) 2021-12-26 20:22:42 +05:30
Rishabh Saxena
89ae6a02d3
fix: connect git via global config (#9982) 2021-12-26 18:40:20 +05:30
Nidhi
3426d70b28
chore: Fixed dot replacement policy for mongo (#9961) 2021-12-25 21:29:05 +05:30
Abhijeet
904b05abaa
chore: Update git error codes to log only useful errors in sentry (#9994) 2021-12-25 09:55:01 +00:00
arunvjn
5af8112fbe
fix: Fixed undo redo cyclic dependency bug (#9884) 2021-12-25 04:55:22 +00:00
Jen Dunlap
fa4ff18f43
chore: removed string type declaration per JS-0331 (#8428)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-12-25 01:35:43 +05:30
Shrikant Sharat Kandula
3f727cdfbb Remove echo MongoDB URI
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-24 22:01:39 +05:30
Shrikant Sharat Kandula
531280c42e Fix MongoDB URI missing authSource
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-24 21:48:52 +05:30
Nayan
e3f8040265
fix: Set auth db name in MongoDB properties (#9997) 2021-12-24 20:45:18 +05:30
Anagh Hegde
74f0d7400f
add tests and fix tests failures (#9981) 2021-12-24 14:54:47 +00:00
Nidhi
e6f4513b48
fix: Appends authSource param to mongo URI if absent, also fixes inability to connect to mongo without user info (#9995) 2021-12-24 19:42:04 +05:30
Paul Li
6c8c7b2da8
feat: camera widget (#8069)
* feat: Camera Widget

-- Scaffold the basic structure of the widget

* feat: Camera Widget

-- Prototype a feature, taking picture

* feat: Camera Widget

-- Add types for MediaRecorder
-- Define media capture status and action types
-- Prototype basic video recording, playing features

* feat: Camera Widget

-- Implement video player
-- Add timer for recording and playing video
-- Add permission and error handling logic
-- Add device selectors

* feat: Camera Widget

-- Place control buttons above device inputs layer
-- Make the widget fully responsive

* feat: Camera Widget

-- Change the color of caret-down icon to white
-- Remove overlaying of web cam and video player
-- Add some padding for device inputs

* feat: Camera Widget

-- Add black background to the container of the widget

* feat: Camera Widget

-- Change the widget icon

* feat: Camera Widget

-- Implement the mute feature of a mic or a camera

* feat: Camera Widget

-- Check media device permissions before getting started

* feat: Camera Widget

-- Add a fullscreen control

* feat: Camera Widget

-- Set error text color to white
-- Change the layout of control panel

* feat: Camera Widget

-- Apply layout change for control panel according to app layout change

* feat: Camera Widget

-- Add a new derived property, videoURL

* feat: Switch Group Widget

-- Adopt theme changes

* feat: Camera Widget

-- Make background grey in case of both error and disabled status

* feat: Camera Widget

-- Update npm dependencies

* feat: Camera Widget

-- Fix on #8788, using muted property

* feat: Camera Widget

-- Show off the microphone setting icon only if the current mode is video
-- Set isMirrored property to true by default

* feat: Camera Widget

-- Add photo viewer

* feat: Camera Widget

-- Add onImageCapture, onRecordingStart, onRecordingStop actions instead of onMediaCapture

* feat: Camera Widget

-- Expose meta properties for the widget

* feat: Camera Widget

-- Fix on responsiveness issue

* feat: Camera Widget

-- Add type definitions for MediaStream recording

* feat: Camera Widget

-- Hide isMirroed property for video mode

* feat: Camera Widget

-- Wrap all the controls with TooltipComponent

* feat:  Camera Widget

-- Implement enter, exit full screen feature

* feat: Camera Widget

-- Add a widget icon for entity explorer

* feat: Camera Widget

-- Fix on the typo for the label of onRecordingStop property

* feat: Camera Widget

-- Enable/disable media tracks

* feat: Camera Widget

-- Set the video's height to 100% in fullscreen mode

* feat: Camera Widget

-- Add overlayers on Webcam

* feat: Camera Widget

-- Set position to relative on fullscreen wrapper div
-- Set the photo viewer's height to 100%

* feat: Camera Widget

-- Add image, mediaCaptureStatus, timer meta properties to keep UI states when the widget is dragged

* feat: Camera Widget

-- Refactor code base, eliminating commented code blocks

* feat: Camera Widget

-- Revert all the changes needed for keeping status when the widget is dragged
-- Set mirroed property to false for video mode
2021-12-24 22:06:59 +08:00
Aman Agarwal
4d73536ea8
fix: Correcting the execution of query with the latest values when run shortcut is pressed (#9363)
* fix(run-hot-key): added update init action with debounced on change function

* fix(run-hot-key): Adding new action for updating store for isSaving query true

* fix(run-hot-key): updating the action name to preparing_update_action

* fix(run-hot-key): added descriptive comments

* fix(run-hot-key): updated the action name and moved condition to action file

* fix(run-hot-key): updated the action to entity started at global app

* fix(run-hot-key): added entity saving status to show loader

* fix(run-hot-key): fixed cypress test to type in the query rather using set method of code editor
2021-12-24 19:29:02 +05:30
Parthvi12
b82ea06aa3
test: Adding visual tests for layout validation (#9857)
* Adding visual tests for layout validation

* updating screenshot to match CI's screenshot resolution

* updating screenshot as per CI

* setting failure threshold for the image comparision

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-24 17:47:22 +05:30
Paul Li
3d0be06ea1
fix: table filter popup is overlaid on modal (#8540)
* fix: Table widget's filter pop-up does not collapse on opening a modal

-- Dispatch an action for closing the table filter pane when a modal is opened

* fix: Table widget's filter pop-up does not collapse on opening a modal

-- Add the Cypress test case

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-24 18:02:40 +08:00
Paul Li
6436082a9a
fix: Icon Widget button variant does not have JS option (#8669)
-- Make buttonVariant prop JS convertible
-- Add the corresponding validation, as well

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-24 18:01:09 +08:00
Nayan
cd3a2ac1c4
Set a default color to application when application has no color set from FE (#9919) 2021-12-24 15:51:42 +06:00
Keyur Paralkar
792b1e6bd6
fix: changed the editing to false on onFocus in PrimaryColumnsControl (#9825) 2021-12-24 15:01:26 +05:30
Keyur Paralkar
c39f7f968b
fix: changed the default row size to 4 for the divider widget (#9917) 2021-12-24 13:49:34 +05:30
albinAppsmith
352f843821
fix: Input border color fix for hover state (#9894)
* * added appsmith platform theme basic
* changed input hover border

* * generate application text change

* * changed colors to new css file
2021-12-24 12:55:25 +05:30
Ayangade Adeoluwa
45a5c38320
feat: Added tests for renaming entities through the entity explorer (#9867)
* Added tests for renaming entities through the entity explorer

* changes made to deletePageFromSideBar function

* adds custom made test cases config

* test cases should be within smoke test suite

* return configuration to run full test suite
2021-12-24 08:16:08 +01:00
balajisoundar
1fad719dbe
Add API for application themes (#9449) 2021-12-24 12:14:59 +05:30
balajisoundar
2138229a59
fix: Reset on submit for Number type in Input widget (#9958)
- Handle NaN value in defaultValue validations in Input widget
2021-12-24 11:20:07 +05:30
Parthvi12
6cb4590f4f
Added testcases for statbox (#9684) 2021-12-24 09:17:43 +05:30
Ayangade Adeoluwa
8e97e79791
remove unneccessary styles from field array control (#9880) 2021-12-23 18:10:08 +01:00
Ayangade Adeoluwa
7f04f32ac2
fixes undefined error coming from datasource rest api form values (#9952) 2021-12-23 18:09:11 +01:00
Leo Thomas
69c76c299f
fix: Incorrect error handling when incorrect sheet name is used in Google Sheets query (#9771)
* fix/9463-Incorrect error handling when incorrect sheet name is used in Google Sheets query

* Code review changes v1
2021-12-23 21:25:02 +05:30
Vicky Bansal
d40226e937
fix: Default date to remain empty value when binding value is empty (#9823) 2021-12-23 21:21:28 +05:30
Paul Li
e789b1293b
fix: Audio recorder widget - group styling properties (#7643)
* Fix: Audio recorder widget styling property needs to be categorized under Styles not General

-- Group style related properties

* Fix: Audio recorder widget styling property needs to be categorized under Styles not General

-- Move styles section to the bottom of the layout
2021-12-23 14:17:47 +00:00
Hetu Nandu
39b0a4e5a6
feat: Native promises support in Appsmith (#8988)
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-12-23 14:17:20 +00:00
Bhavin K
244b089771
fix: added support for timePrecision (#9423) 2021-12-23 14:17:08 +00:00
Sumit Kumar
4b75f77caa
feat: add support for projection, sort and pagination. (#9712)
* Add API server support for UQI's Projection, Sorting and Pagination feature.
2021-12-23 14:16:49 +00:00
Nidhi
9af1f4c9f4
fix: Switched reference from package name to plugin name (#9916) 2021-12-23 14:16:30 +00:00
Nidhi
b2855ccf77
fix: Do not return JS actions when fetching page actions (#9960) 2021-12-23 14:16:16 +00:00
Shrikant Sharat Kandula
20cfc44b02
Fix toast message on reset password (#9957) 2021-12-23 14:16:09 +00:00
Sumit Kumar
cdcb657229
add query params from datasource to URI (#9963)
Add query params from datasource to final URI used for REST API query.
2021-12-23 14:15:54 +00:00
balajisoundar
8d3e3fd88b
fix: remove allowed filetype restriction in filepickerwidget (#9921) 2021-12-23 18:46:57 +05:30
Sumit Kumar
4a075628d7
fix: add work around to handle bad data in Firestore UQI migration (#9966)
* add another migration for those Firestore actions that could not be migrated.
* handle ClassCastException via try catch and assigning default empty value.
2021-12-23 15:59:53 +05:30
Abhijeet
0e0b4d0d1e
Check for layoutOnLoadAction during clone application (#9947) 2021-12-22 21:40:19 +05:30
haojin111
8567d67ef9
fix: disconnect git and repo connect error UI modal (#9833) 2021-12-22 01:26:32 +05:30
Rishabh Saxena
f91e457db9
chore: show only ssh key in the deploy key UI section and remove the label (#9882) 2021-12-21 21:27:26 +05:30
Anand Srinivasan
3a4658c8f5
fix: unexpected return error (#9432)
* assign undefined for empty scripts during evaluation

* add unit tests

* handle anonymous_function when undefined

* update unit tests

* remove unwanted assignments in evaluation scripts

* update unit tests

* Update app/client/src/workers/evaluate.test.ts

* fix lint cypress tests

* remove semicolon

* fix API_bugs_spec

* undo anonymous function change

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* add comment

* return back when JS is empty

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-21 20:00:19 +05:30
Anagh Hegde
4f4d0fd7df
fix: Clear the cache - git limit number of repos (#9874)
* Error handling for git limit

* clear cahe of git limit on connect api

* update per review

* check the repo is public before checking for the limit

* changes per review

* check if the repo is public or private during connect flow
2021-12-21 14:17:26 +00:00
Nikhil Nandagopal
0b0b978245
chore: Updated Template for CRUD DB template (#9913) 2021-12-21 19:34:37 +05:30
Rishabh Saxena
5ec308ce90
fix: git config updates (#9818) 2021-12-21 19:16:37 +05:30
Sumit Kumar
c858edf726
fix Mongo smart substitution for quotes around ObjectId (#9856)
- fix Mongo plugin's smart substitution feature to handle quotes around ObjectId in array. e.g. Initial replacement value: ["ObjectId(xyz)"] , final replacement value: [ObjectId(xyz)]
- unrelated: added version number to lombok dependency to stop build failures in IntelliJ.
2021-12-21 18:47:19 +05:30
Shrikant Sharat Kandula
2dec964e21
Add migration for new MongoDB mock endpoint (#9909)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-21 18:04:12 +05:30
Abhijeet
20649ccb0a
fix: Fixes issues related to git profile and use appsmith user profile as a fallback value (#9891)
* Fixes related to git profile

* Added a TC for connect application with empty git profile and null default git profile
2021-12-21 16:45:56 +05:30
Arpit Mohan
bbe7267b6e
ci: Adding Vercel integration because of issues with Netlify (#9903)
Netlify builds are failing because of seemingly memory constraints. Also they are taking twice as long as Vercel. 

This is an experiment to see if we can switch to Vercel for our deploy preview needs.
2021-12-21 15:33:12 +05:30
Keyur Paralkar
848bc13bc3
fix: corrected Index cond. for conditional formatting in table widget (#9735)
* fix: corrected Index cond. for conditional formatting in table widget

* test: added integration test for checking condtional formating post sorting

* refactor: enhanced the originalIndex condition with nullish coalescing op
2021-12-21 15:25:12 +05:30
Aishwarya-U-R
13f24cbce8
test: Automated tests for Rest Api, S3 Bugs and flakiness fixes (#9695) 2021-12-21 15:07:30 +05:30
NandanAnantharamu
d8e41b4b5c
test: updated org test (#9868) 2021-12-21 13:38:10 +05:30
Sumit Kumar
b8cfc18f7f
fix: fix firestore pagination cyclic dependency error (#9892)
* fix firestore pagination cyclic dependency error
fix firestore UQI migration error

* fix TC
2021-12-21 11:27:05 +05:30
Abhijeet
95869517f6
fix: Replace default IDs for forked application with destination resource IDs (#9886) 2021-12-21 11:19:00 +05:30
akash-codemonk
48267bf239
Fix mock Postgres database endpoint (#9593) 2021-12-21 11:13:19 +05:30
Parthvi12
293ddc3ea1
adding test cases for undo/redo (#9742) 2021-12-21 10:44:58 +05:30
Leo Thomas
77433cf62b
feat: Add support to send arbitrary form values to oAuth server during Datasource authentication (#9660)
* feat:9389  Add support to send arbitrary form values to oAuth server during Datasource authentication

* Changes related to Code Review Comments of PR 9650

* Changes implemented to set custom Key Value pairs

* Resolved Code Review comments

* Resolved Code Review comments
2021-12-21 10:12:26 +05:30
Nayan
a447c6ee5d
Hide updated date when application was not updated manually (#9493)
We should last updated date of an application in the home page. If an application was updated internally e.g. a new user was added to the application, the updated date was set and it was displayed in the home page. This PR fixes that problem.
2021-12-20 22:54:02 +00:00
Arpit Mohan
96677ef673
fix: Updating log4j to 2.17.0 to prevent JNDI lookups (#9863)
Also making minor edit to not show "Application name updated" toast message. This is a counter-productive toast that is distracting the user
2021-12-20 16:01:08 +05:30
balajisoundar
2796bf0baf
fix: handle undefined filterdata props in table widget (#9832) 2021-12-20 15:41:33 +05:30
Anagh Hegde
8a75928c2f
fix: Fix the wrong CS url for private repo limit check (#9865) 2021-12-20 15:16:57 +05:30
arunvjn
99a12be018
feat: add option to delete org (#9287)
Co-authored-by: Nayan <nayan@appsmith.com>
2021-12-20 05:58:01 +00:00
Rishabh Saxena
29d90166af
chore: update font for the user settings title (#9854) 2021-12-20 11:19:17 +05:30
Ankita Kinger
aa190fb434
fix: Excluded hyphen substitution in branch name validation (#9842)
* added exception for hyphen in branch name validation

* created jest test case for branchlist removeSpecialChars function
2021-12-20 10:22:28 +05:30
Anagh Hegde
1b30c58617
feat: Limit private git repos which can be connected within organization (#9803)
* Added check for private repos

* WIP limit repos

* Get the git connected apps from git

* Call CS to get the limit for the git connected apps

* Update comment

* Changes per review

* Add check for limiting the repo

* Cache the results from cloud service

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2021-12-18 17:40:46 +00:00
Leo Thomas
03afb6df22
fix: Handled a possible null key from headers - NullPointerException in sentry (#9810) 2021-12-18 22:42:00 +05:30
imgbot[bot]
387aed75e1
chore: [ImgBot] Optimize images (#9855)
*Total -- 311.31kb -> 173.82kb (44.16%)

/deploy/digital_ocean/images/edit-app.png -- 309.70kb -> 172.23kb (44.39%)
/app/client/src/assets/icons/widget/switch-group.svg -- 1.60kb -> 1.59kb (0.61%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-18 22:40:28 +05:30
Abhijeet
5e6e6caedb
fix: Use Appsmith user profile as a fallback git profile (#9821)
* Added appsmith profile as a fallback value

* Modified TC for userData to include git profile TCs

* Added check for null value when user want to use repo level profile and provide empty author name or email

* Refactor method names
2021-12-18 21:36:25 +05:30
Nayan
68a9584fd9
fix: removed sentry reposrting when application not found (#9839) 2021-12-17 20:16:49 +05:30
Abhijeet
4bc86a906f
chore: Update default local git repo path as per docker-volume requirements (#9804)
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 14:30:54 +00:00
Ayangade Adeoluwa
b763fa03d3
fix: fixes inability to rename other widgets, jsactions, pages (#9848)
* fixes inability to rename other widgets, jsactions, pages

* adds edge case to handle renaming non action based entities

* fix if check
2021-12-17 19:21:06 +05:30
Nidhi
ab4add4b83
fix: Install plugin to existing organizations after approval (#9840) 2021-12-17 12:35:19 +05:30
Tolulope Adetula
831c0cb685
fix: chart validation (#9718) 2021-12-16 22:19:44 -08:00
Shrikant Sharat Kandula
9202c0bf67 Fix Docker buildx images
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 10:27:56 +05:30
Shrikant Sharat Kandula
31da3ea9ef Load Docker buildx images for testing
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 10:26:30 +05:30
Leo Thomas
ec755d261c
fix: Google sheets Bulk insert of empty array returns an error (#9725)
* fix/8924-Bulk Insert throwing error on empty data in google sheets new1

* fix/8924 Error in bulk insert empty data

* fix/8924 Code review fix for Google Sheet Bulk insert error

* fix/8924 Code review fix for Google Sheet Bulk insert error

* Fixed code review comments

* Methodconfig data changes since only empty Mono is being tested
2021-12-17 10:13:08 +05:30
Shrikant Sharat Kandula
8a336d3caa Fix OOM in insertDefaultResources migration
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-16 22:39:48 +05:30
Shrikant Sharat Kandula
1247864893
Fix migration OOM in firestore action migration (#9830)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-16 21:03:35 +05:30
Ayangade Adeoluwa
bdad41f323
Fix merge problems (#9829) 2021-12-16 20:43:00 +05:30
Paul Li
f62c8a62a4
fix: checkbox group feedback (#6959)
* FIX-6783 : Checkbox group widget - Feedback

-- Add default border for a checkbox icon and color for a label
-- Align the option to the center if its options count is one or inline
-- Set isInline to true by default in widget config

* FIX-6783 : Checkbox Group Widget Feedback

-- Add a migration for isInline property

* Feat: Checkbox Groupd Widget Feedback

-- Add vertical margin between options

* Fix: Checkbox Group Widget

-- Increase default rows value to 1.5 in widget configuration

* Fix: Checkbox Group Widget

-- Change the migration version number

* Fix: Checkbox Group Widget

-- Change migration version number

* Fix: Checkbox Groupd Widget Feedback

-- Delete redundant WidgetConfigResponse file

* Fix: Checkbox Group Widget Feedback

-- Change the config values of rows, columns
-- Refactor migration file

* Fix: Checkbox Group Widget

-- Refactor migration file

* fix: Checkbox Group Widget Feedback

-- Fix on the wrong dsl version

* fix: Checkbox Group Widget Feedback

-- Remove a unnecessary comment
-- Update the version of the widget in its config and migration

* fix: checkbox group feedback

-- Rewrite a migration for isInline property

* fix: checkbox group feedback

-- Follow the figma design on disabled state

* fix: Checkbox Group Widget feedback

-- Apply appropriate migration

* fix: Checkbox group widget - Feedback

-- Apply theme changes

* fix: Checkbox Group Widget - Feedback

-- Change the border color of an unchecked checkbox to DARK_GRAY

* fix: Checkbox Group Widget - Feedback

-- Remove inset box shadow from the checkbox indicators

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 22:24:23 +08:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
Ayangade Adeoluwa
e6bc975889
fix: Fixes inability to use duplicate names across multiple actions in different pages (#9360)
* Fixes inability to use duplicate names across multiple actions in different pages

* adds comments for better understanding and readability

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:53 +05:30
Ayangade Adeoluwa
7af727651d
fix: Assigns query Params in Datasource and Api query editor (#9184)
* adds option to assign query params in datasource and see those params in apieditor

* fix flaky cypress tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:38 +05:30
Ayangade Adeoluwa
a6796daaa9
fix: deleted actions display error messages when navigated to (#9507)
* deleted actions display error messages when navigated to

* adding custom type for goBackFn

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:14 +05:30
Ayangade Adeoluwa
c36d8f1b49
fixes query editor duplication (#9761) 2021-12-16 18:10:02 +05:30
Nidhi
508865f1dc
fix: Added handling for refactor of default list elements (#9774) 2021-12-16 11:33:40 +00:00
Nidhi
e48a51c166
fix: Ignore form data elements with null keys (#9769)
* fix: Ignore form data elements with null keys

* Added reference to constant instead of using a String
2021-12-16 09:54:38 +00:00
NandanAnantharamu
4fa39d924d
test: TableWidget bugs (#9795)
* Added tests for Table widget bugs

* typo in test corrected

* Updated a flaky test
2021-12-16 14:52:14 +05:30
Abhijeet
52782c6088
fix: Resolve issues related to disconnect git repo flow (#9760)
* Fixed issues related to git disconnect

* Update TC
2021-12-16 08:50:11 +00:00
Abhijeet
c51c0036af
fix: Fix action collection not being deleted when the deleted collection in edit mode is published (#9785) 2021-12-16 13:48:14 +05:30
Sumit Kumar
7909ae8680
feat: port Firestore plugin to UQI (#9393)
* Port Firestore plugin to UQI schema
* This PR implements a non-functional requirement i.e. from an end user perspective there is no change in the features that the plugin provides. However, the underlying DSL to render and interpret the query interface has been updated.
* It also involves a migration change to port existing Firestore plugin actions to the new UQI schema.
2021-12-16 13:31:09 +05:30
Nidhi
8d53c16e25
fix: Added check for self references in layout (#9756) 2021-12-16 13:30:19 +05:30
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Aswath K
66b9f69426
fix: Issue with deleting page (#9784)
Old page id was getting cached caused failure in deleting pages

Fixes #9717
2021-12-16 12:28:30 +05:30
Trisha Anand
11603e0d24
chore: Backend code split (#9610)
* Server comes up

* Instead of extracting ee, we extract the ce to get the mongo repo to work

* ActionRepo migrated

* ApiTemplateRepo migrated

* Application repo migrated

* Asset Repo migrated

* Collection repo migrated

* Comment repo migrated

* Comment thread repo migrated

* Config repo migrated

* datasource repo migrated

* group repo migrated

* Invite user repo migrated

* layout repo migrated

* New action repo migratd

* .

* Migrated rest of the repos.

* Migrated the repo impl as well between ce and common

* acl package partially migrated

* Authentication migration done!

* Controllers migrated

* AppsmithPermission enum migrated to class and split

* Unnecessary change removed

* Appsmith role enum converted to class

* Revert

* Reverting enum to class conversion after failing at implementing

* All services migrated

* server.solutions package completed

* Fixed solutions failing test cases

* Code compiling! Woohoo!
2021-12-15 22:59:46 +05:30
Ayangade Adeoluwa
763bb8f287
restricts datasource name character length (#9471) 2021-12-15 18:02:11 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Aman Agarwal
0c74e7273e
fix(handle-enter-confirm-popup): added key action to confirm popup wi… (#8980)
* fix(handle-enter-confirm-popup): added key action to confirm popup with class functions

* fix(handle-enter-confirm-popup): removed isModalOpen in keyUp not required check
2021-12-15 17:21:57 +05:30
Ayush Pahwa
d52a28dd2e
Added handling for non JSON response on executeAction (#8907)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-15 17:10:03 +05:30
Favour Ohanekwu
79b45c60df
fix: Update replaceAll function for browser support (#9776)
Update replaceAll function for browser support
2021-12-15 11:42:25 +01:00
Nayan
f0a2cbd73f
chore: Added DB migration to flush redis (#9772) 2021-12-15 13:54:27 +05:30
rahulramesha
ddedf985b5
entity name rerender fix (#9703) 2021-12-15 08:23:24 +00:00
Favour Ohanekwu
84a627aaeb
fix: properly lint triggerfields (#9773)
Properly lint trigger fields
2021-12-15 06:18:45 +01:00
Rishabh Saxena
2821ac2d75
fix: git sync updates (#9623)
Co-authored-by: haojin111 <haojin828@outlook.com>
2021-12-15 00:30:59 +08:00
Anagh Hegde
e216dad15b
feat: Refactor APIs to include branch name in the request header (#9679)
* refactor api's to include branchName for git

* Check for updating Ids for move action

* Added check for global profile

* Fix bad merge

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2021-12-14 15:09:30 +00:00
Aman Agarwal
2c61de6525
fix: Correcting the duplication of headers from datasource to newer APIs (#9157) 2021-12-14 12:39:05 +00:00
Aman Agarwal
d05b2d5b56
fix: Correcting the run button loading state on cancel in API pane (#9094)
* fix(run-button-loading): the run button loading state changed on cancel

* fix(run-button-loading): added test case for run button loading status
2021-12-14 12:37:42 +00:00
Nidhi
b0900d1c22
fix: Added collection id and clientsideexecution to layout on page load DTO (#9683) 2021-12-14 16:34:45 +05:30
Ayangade Adeoluwa
cac0df71aa
fixes duplication of where clause AND-condition fields (#9745) 2021-12-14 11:42:21 +01:00
Nayan
28c181b59c
feat: [Feature] Upgrade spring boot version to 2.5.5 (#8932)
Upgrades spring boot version to 2.5.5
2021-12-14 16:22:37 +06:00
Nayan
c126786e98
fix: application is added to recent list if duplicated (#9549)
When user duplicates an application, the source application is also being marked as recently accessed application. As a result both the duplicated application and the source application are shown in the beginning of the list of applications.
2021-12-14 16:21:50 +06:00
Hetu Nandu
4c54ea21fb
feat: Add support for custom 'this' and 'global' variables during evaluation (#9651) 2021-12-14 14:00:43 +05:30
Nidhi
861ee2c46e
fix: Added handling for action collections during duplicate app flow (#9637) 2021-12-14 13:40:25 +05:30
Ayangade Adeoluwa
e9cd435c96
feat: UQI Pagination Component implementation (#9446)
* pagination component implementation with files for testing(to be removed)

* UQI Pagination component created.

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-14 09:02:06 +01:00
Aswath K
c9e1a73db7
fix: Regex to detect function args (#9634)
* fix: Regex to detect function args

* Add Tests for argString to Array

* fix: failed condition

* fix: bug with arrow function regex
2021-12-14 13:28:09 +05:30
Bhavin K
f7e2e079a9
fix: 8336 updated isLoading property in all widgets (#9409) 2021-12-14 07:55:58 +00:00
Bhavin K
406255fcf6
fix : updated alignments (#9602) 2021-12-14 07:55:30 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Apeksha Bhosale
9a7a5e06af
fix: changed conditions for variables as variables were undefined (#9748) 2021-12-14 13:01:40 +05:30
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
Rishabh Saxena
d9bdde0904
chore: remove plausible to improve page performance (#9713) 2021-12-13 12:13:39 +05:30
NandanAnantharamu
990ec76c4b
test: Added test for select Widget (#9600)
* Added test for select Widget

* updated common locators
2021-12-13 11:14:01 +05:30
Parthiv Makwana
c2d549cb37
chore: Duplicate case labels found in switch case in Icon.tsx (#8640) 2021-12-12 19:20:14 +05:30
Shrikant Sharat Kandula
a26c14e2cd
fix: Load pages from GitBook sequentially (#8519)
Loading them in parallel is causing us to breach some rate limiting restrictions sporadically and the whole process fails. So this reverts to loading pages sequentially instead.
2021-12-12 19:11:07 +05:30
Abhijeet
e6c323a2ec
fix: Update crud template for failing S3 list file action (#9691)
* Updated Template

* Update TC

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-12-12 18:23:59 +05:30
dependabot[bot]
199927b32e
chore: bump algoliasearch-helper from 3.2.2 to 3.6.2 in /app/client (#9307)
Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.6.2.
- [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases)
- [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG)
- [Commits](https://github.com/algolia/algoliasearch-helper-js/compare/3.2.2...3.6.2)

---
updated-dependencies:
- dependency-name: algoliasearch-helper
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 07:52:56 +00:00
dependabot[bot]
1a2db9dc09
chore: bump ua-parser-js from 0.7.22 to 0.7.31 in /app/client (#9504)
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.22 to 0.7.31.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.22...0.7.31)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 07:50:09 +00:00
Paul Li
08b0e86967
feat: Change Map Pin Color on Map Widget (#8337)
* feat: Change Map Pin Color on Map Widget

-- Add a color property for a marker

* feat: Change Map Pin Color on Map Widget

-- Set #E0DEDE as default color

* feat: Change Map Pin Color on Map Widget

-- Revert to the original logic

* feat: Change Map Pin Color on Map Widget

-- Add a new base icon for a marker

* feat: Change Map Pin Color on Map Widget

-- Add anchor property for custom marker icon

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 13:43:29 +08:00
dependabot[bot]
f8f230f531
chore: bump prismjs from 1.24.0 to 1.25.0 in /app/client (#7649)
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-11 12:31:48 +05:30
dependabot[bot]
abe50f3c6e
chore: bump url-parse from 1.4.7 to 1.5.3 in /app/client (#9502)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.3.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.3)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-11 06:50:39 +00:00
Shrikant Sharat Kandula
3c259386ff
fix: Add fix for log4j2 RCE (#9706)
Ref: https://spring.io/blog/2021/12/10/log4j2-vulnerability-and-spring-boot.

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-11 09:54:38 +05:30
Snyk bot
b31d390054
chore: app/client/package.json & app/client/yarn.lock to reduce vulnerabilities (#9447)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-JSONSCHEMA-1920922

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-10 18:11:35 +00:00
Nidhi
d3a100e02f
feat: Added action to upload multiple files in S3 (#9337)
* feat: Added action to upload multiple files in S3

* Added test case for multiple file uploads

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-10 10:43:12 +00:00
Vicky Bansal
39db055211
fix: use defaultTab as selectedTab when selectedTab property is not available on page load (#9487) 2021-12-10 14:15:03 +05:30
Aishwarya-U-R
fd0f258699
test: Automated tests for RestApi, S3 Bugs (#9539)
* Supressing console.log

* Bugs 5550, 8684 scripted

* Bugs # 9425, # 4775 + S3 failure fix

* S3 failure fixes

* Postgress Delete Ds correted

* Bug # 9334 - Implemented

* onlyQueryRun reverted

* testSaveDatasource reverted

* Mongo Aggregate case fix

* testSaveDatasource updated to test true & false
2021-12-10 12:53:12 +05:30
albinAppsmith
2721b5b784
fix: Context menu auto close issue in page settings (#9675)
* * Bug fix for context menu auto  closing

* * Added comments
2021-12-10 09:58:52 +05:30
Abhijeet
f12b97b9d8
fix: When the SQL table provided by user have less number of columns than template columns for generate CRUD page (#8810) 2021-12-10 09:11:57 +05:30
Trisha Anand
3a21d91a57
fix: PageLoad - action.data implicitly depends on action.actionConfiguration. Added this relationship to dag (#9178)
* fix: PageLoad - action.data implicitly depends on action.actionConfiguration. Added this relationship to dag

* Random walkthrough comments

* Logic does not work!

* Ignore pagination configuration from dynamic binding path list to avoid creating cyclic dependency

* The most complicated test case ever passed! Woohoo!

* Code cleanup

* Incorporated review comments
2021-12-09 20:04:55 +05:30
Tolulope Adetula
7f3c849876
fix: button variant table binding (#8712)
* fix: Table widget binding

* fix: binding property

* fix: Add binding and new validation

* fix: Control for Table Binding

* fix: revert new Validation type change

* fix: failing test

* fix: validation

* fix: validation issue

* fix: binging issue

* revert: control changes

* revert: control changes

* fix: binding issues

* revert: validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 04:12:42 -08:00
balajisoundar
ae21b7ef51
chore:[Admin settings] Send email config details as payload when making send test email call (#9631) 2021-12-09 17:41:45 +05:30
Paul Li
54579a4e6c
feat: Switch Group widget (#7590)
* Feat: Switch Group Widget

-- The first MVP of the widget

* feat: Switch Group Widget

-- Follow the same config and implementation as the other group widgets

* feat: Switch Group Widget

-- Elaborate the help text for defaultSelectedValues

* feat: Switch Group Widget

-- Add a widget icon

* feat: Switch Group Widget

-- Remove unnecessary property control at ItemsControl.tsx
-- Refactor some code snippets for higher code quality
-- Add basic cypress test cases

* fix: icon for the widget optimised & replaced

* feat: Switch Group Widget

-- Add a unit test for defaultSelectedValuesValidation

* feat: Switch Group Widget

-- Make the validation type for defaultSelectedValues property to ValidationTypes.ARRAY
-- Remove original validation function and its unit test

* feat: Switch Group Widget

-- Fix on typo
-- Fix on formatting issue
-- Change the help text for isRequired property

* feat: Switch Group Widget

-- Revert help text for isRequired property to the original one

* feat: Switch Group Widget

-- Set strict property to true on defaultSelectedValues

* feat: Switch group widget

-- Refactor utility function, getCamelCaseString
-- Add the corresponding test case

* feat: Switch group widget

-- Implement options property as a plain JS field
-- Reimplement update logic for selectedValues when options changes
-- Add a new utility function for checking equality of object arrays
-- Add a unit test for the above function
-- Rewrite the corresponding Cypress test cases

* feat: Switch Group Widget

-- Remove isArrayEqual utility function and directly use functions from lodash

* feat: Swtich Group Widget

-- Make selectedValues as a derived property

* feat: Switch Group Widget

-- Replace the widget icon

* feat: Switch Group Widget

-- Rewrite a test case for onSelectionChange property

* feat: Switch Group Widget

-- Remove redundant calls for openPropertyPane

* feat: Switch Group Widget

-- Remove closePropertyPane call from afterEach hook

* feat: Switch Group Widget

-- Change the selector for every switch element in onSelectionChange test case

* feat: Switch Group Widget

-- Fix on failed Cypress test case, adding closePropertyPane command to onSelectionChange

* feat: Switch Group Widget

-- Remove template literal from a selector

* feat: Switch Group Widget

-- Make click on onSelectionChange test case forced

* feat: Switch Group Widget

-- Fix on crash issue when editing on Options property

* feat: Switch Group Widget

-- Add the widget icon to show in entity explorer

* feat: Switch Group Widget

-- Fix on blue color on mouse down
-- Add a new property for alignment

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-12-09 20:02:47 +08:00
Tolulope Adetula
3e51c1173c
fix: negative spacing in list widget (#9571)
* fix: add validation for negative numbers and allow negative spacing

* fix: add validation test for negative numbers

* fix: validation tests

* fix: validation test

* fix: errors

* fix: grid gap

* fix: validation test
2021-12-09 02:01:11 -08:00
Nishi Agrawal
3e7123d11a
fix: Cursor turning to pointer upon onclick in deployed app (#8111)
* [fix]:cursor turning to pointer upon onclick in deployed app

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: cursor changing to pointer only if onclick event associated to image widget

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: build error, no used var

Signed-off-by: nishihere19 <nishihere19@gmail.com>

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 14:49:24 +05:30
Nayan
15ca54e43f
Custom domain should be configured from admin UI (#9633) 2021-12-09 14:40:08 +05:30
Tolulope Adetula
4829820e86
fix: add enableClientSideSearch (#9505)
* fix: add enableClientSideSearch

* fix: add test

* fix: refactor function

* fix: filter issue

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 22:35:27 -08:00
Aswath K
177df5cc68
fix: table icon selector js mode toggle issue (#9396)
* fix: ARRAY validation with allowedValues

* Adds TABLE_PROPERTY validation

* Add test

* fix: Table icon JS mode toggle issue

* remove unused variable

* Make use of constant for icon

* Adds comment

* better validation

* fix: failed cypress test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 11:45:59 +05:30
Tolulope Adetula
af08547529
fix: Select widget Value (#9444)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 11:14:53 -08:00
Vicky Bansal
3ac913a12c
feat: Row selection in Table widget using Primary Column (#8156) 2021-12-08 19:36:14 +05:30
Bhavin K
4889098888
fix: added placement support in button, button group, and menu widget (#9354) 2021-12-08 13:11:13 +00:00
Snyk bot
ddf1490866
chore: app/client/package.json & app/client/yarn.lock to reduce vulnerabilities (#9630)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NODESASS-1059081
2021-12-08 13:10:08 +00:00
Arpit Mohan
7dfd8ac6f5
chore: Making smtp default install true for new all organizations (#9654) 2021-12-08 16:33:31 +05:30
Shrikant Sharat Kandula
4b7b9b698b
Migration to update mockdb endpoint (#9562)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-08 11:35:16 +05:30
balajisoundar
ef488f1f7a
fix: Empty column name check before computing dynamicBindingPathList in Table widget (#9466) 2021-12-08 11:24:31 +05:30
Nidhi
e402a76564
fix: Added timestamp in where clause types, modified logic for calculating date time types (#9608)
* fix: Added timestamp in where clause types, modified logic for calculating date times

* fix: Added another field for timestamp, shouldn't fail

* Added test case for older filter method as well

* Added test case for older filter method as well

* Modified types for date and time
2021-12-08 05:25:07 +00:00
Nayan
092b78bbc4
Send test mail by config (#9478)
Sending the test email was using existing email configuration, this commit fixes this to use the configuration provided by the user on the admin settings UI.
2021-12-08 09:56:49 +05:30
albinAppsmith
c433464de8
* Bug fix in the api url bar (#9579) 2021-12-07 21:13:09 +05:30
Pawan Kumar
f33758d871
remove reset on text widget (#9594)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-12-07 15:59:04 +05:30
Hetu Nandu
7143bba134
feat: Geolocation APIs on appsmith (#9295)
Co-authored-by: Anand Srinivasan <66776129+eco-monk@users.noreply.github.com>
2021-12-07 15:49:33 +05:30
arunvjn
f62247b468
feat: Action undo redo (#9045) 2021-12-07 09:45:18 +00:00
haojin111
d701f8dfb1
fix: misc git sync fixes / ui polish (#9229)
Co-authored-by: Rishabh Saxena <rishabh@appsmith.com>
Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2021-12-07 07:59:32 +00:00
Rishabh Saxena
0ccfac7978
fix: check if smartlook, sentry and analytics are inited before the init call (#9576) 2021-12-07 07:32:51 +00:00
NandanAnantharamu
f1c4f03438
Updated test (#9616) 2021-12-07 12:58:27 +05:30
Keyur Paralkar
6e986f9e50
fix: undefined evaluted value text widget (#9521)
* fix: evaluted value undefined for text widget

* test: added cypress spec for cell background and text size change validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-07 10:24:19 +05:30
Arpit Mohan
b5e27aaa57
feat: Adding a SMTP plugin (#8927) 2021-12-07 09:15:15 +05:30
Yash Vibhandik
9b3b1f5196
fix: 7487 added allowSelectAll option in property pane (#9536)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-06 11:26:44 +05:30
Bhavin K
62a0f0c952
fix: ButtonGroupWidget button variant validation updated (#9454) 2021-12-06 11:07:29 +05:30
balajisoundar
99eb298de7
chore: disable and assert disablility of teletry on CI (#9560) 2021-12-03 23:59:17 +05:30
Tolulope Adetula
5ec470e3c6
fix: selected row issue (#9445)
* fix: selected row issue

* fix: add tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-03 06:15:23 -08:00
imgbot[bot]
81ccdbaede
chore: [ImgBot] Optimize images (#9544)
*Total -- 1,062.82kb -> 832.92kb (21.63%)

/contributions/assets/widgetConfig.png -- 422.37kb -> 324.12kb (23.26%)
/contributions/assets/propertyConfig.png -- 449.61kb -> 350.59kb (22.02%)
/contributions/assets/widgetFolder.png -- 180.78kb -> 148.29kb (17.97%)
/app/client/src/assets/icons/comments/pin_3.svg -- 0.41kb -> 0.39kb (5.21%)
/app/client/src/assets/icons/comments/unpin.svg -- 0.53kb -> 0.51kb (4.02%)
/app/client/src/assets/icons/form/trash.svg -- 2.81kb -> 2.76kb (1.88%)
/app/client/src/assets/icons/control/copy.svg -- 0.88kb -> 0.87kb (1.55%)
/app/client/src/assets/icons/header/hamburger.svg -- 0.22kb -> 0.21kb (1.35%)
/app/client/src/assets/icons/ads/double-arrow-right.svg -- 1.07kb -> 1.06kb (1.28%)
/app/client/src/assets/icons/widget/text.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/widgets/DocumentViewerWidget/icon.svg -- 0.96kb -> 0.96kb (0.61%)
/app/client/src/assets/icons/ads/double-arrow-left.svg -- 1.05kb -> 1.04kb (0.28%)
/app/client/src/assets/icons/comments/eye.svg -- 1.39kb -> 1.38kb (0.21%)
/app/client/src/assets/icons/control/help.svg -- 0.48kb -> 0.48kb (0.2%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-03 12:47:23 +05:30
Anand Srinivasan
7647d076fb
fix: sentry issues (#9491)
* add polyfill for string.replaceAll

* null check for logs
2021-12-03 12:18:37 +05:30
albinAppsmith
12e277ad1f
fix: Fold/Unfold fix on click of entity (#8961)
* * fold/unfold fix

* * cypress fix

* * Button style fixes

* * test case fix

* * cypress fixes
2021-12-03 11:54:08 +05:30
balajisoundar
fa65e38cf4
fix: fix segment calls not getting fired issue on CE instances (#9543) 2021-12-03 11:08:18 +05:30
Shrikant Sharat Kandula
77caf4c536
chore: Send telemetry option in user profile to client (#9535)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Co-authored-by: sbalaji1192 <balaji@appsmith.com>
2021-12-03 01:56:16 +05:30
Parthvi12
0b8181c229
test: testcases for autocomplete using slash and mustache (#9489)
* Testcases for autocomplete using slash and mustache

* fixed failing tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-02 19:39:50 +05:30
Shrikant Sharat Kandula
cd624982b8
Handle telemetry disabled (#9517)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-02 16:58:26 +05:30
Aswath K
eed6ad9166
fix: empty string validation if required is set (#9476) 2021-12-02 16:45:18 +05:30
Anand Srinivasan
4ced0954db
feat: Syntax parsing through AST (#9115)
* ast changes

* ast fix for cyclic dependency

* jest test updates for ast

* feat: Extract references in code with AST (#8617)

Co-authored-by: Nidhi <nidhi@appsmith.com>

* undo debugger changes

* code clean up and comments

* update type checks for literal nodes

* include tests for IIFE and direct object access

* fix - dependency map not updated on IIFE/direct object access

* update tslib

* unescape on AST parsing

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
2021-12-02 15:33:43 +05:30
Nidhi
2653c7828f
feat: authentication for SaaS (#9352)
* initial commit

* fix: Added migration gor google sheets plugin name
2021-12-02 14:46:51 +05:30
Bhavin K
2ade131ebf
fix: button group cursor in case of disable (#9481) 2021-12-02 14:15:46 +05:30
Aswath K
cc0ed3b89e
fix: long dropdown popup truncates items (#9187)
* set max-height for Dropdown

* Better height calculation

* address review comment

* removed unecessary assertion

Co-authored-by: Apple <nandan@thinkify.io>
2021-12-02 08:28:51 +01:00
Keyur Paralkar
ba5262df2c
fix: fixed the default value of zero not present in parent form data on pageload (#9324)
* fix: fixed the default value of zero not present in parent form data on pageload

* test: added cypress test for Checking default value 0

* refactor: changed the DSL and added reset condition at the end of test

* refactor: removed the proxy variable

* refactor: corrected the typo
2021-12-02 11:36:24 +05:30
Uchechukwu Nwafor
74a9e7c892
fix: refresh profile image on the header when a new image is uploaded (#8550) 2021-12-02 11:26:41 +05:30
Aishwarya-U-R
37339c0cb1
test: RestAPI parallel run & Debug btn crash [Bugs 5550, 6863, 8686] - Script implementation (#9435)
* Bugs 5550, 6863 - Script implemented

* Added wait time in cy.updateCodeInput

* S3 DeleteSource failure fix

* S3 Delete Ds case fix

* Mongo Failure fixes

* Failure fixes

* Bug 8686 - Implemented

* cypress.json updated

* Added wait for proper validation pass

* Updated

* Updated EvaluateCurrentValue

* Update commands.js

* Added AfterEach

* Updated EvaluateCurrentValue()
2021-12-02 10:50:44 +05:30
Nidhi
5434d25735
fix: Added client side execution logic and on page load logic for js (#9392)
* fix: Added client side execution logic and on page load logic for js

* Revert dev env

* Revert dev env

* Updated tests expectation partly to break PR

* fix: Reverted test breakage for this PR
2021-12-01 22:02:43 +05:30
Aman Agarwal
df715297ec
fix: Adding empty array check for mapping keys (#9459) 2021-12-01 18:36:41 +05:30
Favour Ohanekwu
a9527f3e49
update ternserver when no custom def is available (#9472) 2021-12-01 04:50:15 +01:00
Nidhi
0a4e1a3e6d
fix: Send unsupported message when trying to test SaaS integrations (#9335) 2021-11-30 17:37:22 +00:00
Abhinav Jha
5173ef418b
chore: Update Validations (#9177)
* Update Validations
===
- If number value is out of bounds, return minmax || parsed || 0
- If text has regex, match RegExp - earlier we were matching with
  string, which was always failing
- Prioritise  expected  value in TEXT validation RegExp case.

* Add tests for regex and update tests for other changes

* Add test for using expected type instead of regex in messages

* Update regex, as it was reported to be buggy
2021-11-30 22:21:41 +05:30
NandanAnantharamu
425a46f34d
test: updated filter tests (#9448)
* Filter Tests

* Test spec added

* updated import

* added some wait

* updated the dependencies

* Added the dependancy files
2021-11-30 20:56:37 +05:30
Tolulope Adetula
809a288bdc
fix: popups same width as parent (#7499)
* fix: select widget popup

* fix: select widget

* fix: Menu button

* fix: make Clear Var names

* fix: consistent dropdown width

* fix: define variable better

* fix: prettier error

* fix: variable name

* fix: select popup issue

* fix: PR issues add comments

* fix: remove unused css

* fix: add tests

* fix: more pop overs

* fix: menu button popup

* fix: Multiselect dropdown

* fix: failing test

* fix: add more tests

* fix: Failing Test
2021-11-30 02:38:46 -08:00
rashmi rai
b65258876f
fix: missing number of queries in active datasource (#7694) 2021-11-30 10:11:40 +00:00
Nayan
06656eca5d
feat: [Feature] Show recently accessed apps first (#9017)
Most recently apps will be displayed under each organization in user homepage. Earlier, the applications were sorted based on application names.
2021-11-30 15:43:30 +06:00
Favour Ohanekwu
ec6c0c592e
fix: Properly save JSON to clipboard (#9416)
Properly copy JSON to clipboard
2021-11-30 06:49:22 +01:00
Favour Ohanekwu
b8ca5cb816
fix: remove moment interface objects from completions (#9379)
Remove interface objects from completions
2021-11-30 06:48:13 +01:00
Favour Ohanekwu
4675b4bb10
fix: Show correct toast type options in debugger (#9415)
Show correct toast type options
2021-11-30 06:46:40 +01:00
Parthvi12
af430d7049
test: testcases for content management system app using echo api (#9420)
* testcases for content management system app using echo api

* added response check method for API calls
2021-11-30 09:28:57 +05:30
Parthvi12
720806574f
test: PgAdminFix (#9313)
* commenting failing tcs for now

* resolving conflict and  fixing testcases

* Update PgAdmin_spec.js

* fixing testcases

Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-11-30 04:54:42 +05:30
Bhavin K
6ea90e7c7b
feat: add document viewer widget (#7666)
* created new widget

* new lib for document viewer

* added cypress tests

* updated icon

* handling different url types with viewer

* add to ignore react-documents in jest transformIgnorePatterns

* added jest test, updated comments

* required changes

* updated cypress test

* updated icon svg

* doc viewer new renderers added

* comment as required

* updated test case

* added url / base64 validations

* updated url checking condition for space and updated test case

* cypress selector update

* updated url validations

* Merge branch 'release' into feature/new-document-viewer

* lazy load external lib
2021-11-29 15:37:49 +00:00
Yash Vibhandik
f6acbf1407
fix: #8530 Added Config for Menu JS Convertible (#8775)
* fix: #8530 updated config for menu color jsconvertible

* test case updated

* yarn lock update
2021-11-29 15:37:05 +00:00
Rishabh Rathod
bddafdcb7e
fix: Add default props dependency in dependency map (#9418)
* Add cloneDeep
* Add comments
2021-11-29 09:04:40 +00:00
Aswath K
669d901176
fix: MenuItem overflow (#9195) 2021-11-29 11:51:01 +05:30
Leo Thomas
4c29436974
fix: Google Sheet Plugin Numeric inputs Whitespace issue. (#9364)
* fix:Google Sheet Plugin Numeric inputs Whitespace issue.

* fix:Google Sheet Plugin Numeric inputs Whitespace issue - Review 1
2021-11-29 05:51:33 +00:00
NandanAnantharamu
2a3089383a
updated test flow (#9388) 2021-11-26 12:18:31 +00:00
Tolulope Adetula
f30e389167
fix: Evaluation issue with Button in table Widget (#9356)
* fix: Evaluation issue

* fix: add validation

* revert jest tests changes

* revert cypress test

Co-authored-by: root <pawan@appsmith.com>
2021-11-26 17:03:50 +05:30
Aishwarya-U-R
e5a28b3d9b
test: S3 QueryPane scripting along with possible CRUD flow coverage (#9278)
* S3 QueryPane scritping

* Postgress, S3 - failure fixes

* Postgres, S3 failure fixes

* S3 failure fixes

* Added scrollIntoView for Postgres CRUD failures

* S3 - Suggested&Snipeable widgets implemented

* S3 CRUD - failure fix

* Postgres, S3 CRUD failure fixes

* S3 field inputs corrected

* JQuery empty used to clear fields

* Commenting cases to unblock CI runs

* PgAdmin Spec - commenting failures to unblock CI

* S3, Postgres CRUD failure fixes

* Added Wait for Onboarding spec case failure

* typeValueNValidate - updated

* typeValueNValidate updated

* Reverted typeValueNValidate method trigger change

* Adding wait to typeValueNValidate

* Updated typeValueNValidate with updateCodeInput
2021-11-26 16:17:53 +05:30
Aman Agarwal
2ca413c152
fix: Correcting the throwing error to logging error for promisified triggers (#9385) 2021-11-26 15:30:24 +05:30
Confidence Okoghenun
0b18ea64f3
chore: Renames actions to event on property pane (#8579) 2021-11-26 15:02:04 +05:30
Hetu Nandu
8f2935f023
fix: Don't remove bindings when transfering action out of page (#9296) 2021-11-26 14:34:16 +05:30
Pawan Kumar
f738c5e087
fix: Alignment of point numbers in welcome pages (#9353)
* fix scroll in panel in property pane

* fix table widget button height issue

* fix alignment issues

* hide canvas selection in preview mode

* filter alignment issue fix

* fix app mode issue with iframe widget

* fix 404 alignment issues

* fix generate page alignemnt issues

* fix jsobjects empty container alignment issues

* fix comments width issue

* fix alignment issues
2021-11-26 11:46:08 +05:30
Keyur Paralkar
9fc0a038ec
fix: update tooltip record count prop table (#9297)
* docs: changed the tooltip text for total record count for table widget

* test: added unit test for testing tooltip text table widget

* refactor: added Tooltip message in the message constants
2021-11-26 10:44:00 +05:30
Bhavin K
a961c66ec3
fix: updated button group widget properties and GROUP_BUTTONS controls style (#9304) 2021-11-26 10:29:56 +05:30
NandanAnantharamu
301c2b0c92
Ignoring Flaky test (#9387) 2021-11-26 02:58:43 +00:00
rashmi rai
96d4c0b774
fix: fixing missing where key (#9215) 2021-11-25 18:48:40 +05:30
Rishabh Rathod
d7cdf6f84b
fix: Add escaping special characters before JSON.parse (#9293)
* Add escaping special characters before JSON.parse
2021-11-25 16:22:40 +05:30
Hetu Nandu
5d7f68a031
fix: Mute action execution errors when error callback is present (#9366) 2021-11-25 15:28:04 +05:30
Aswath K
41c7c344b4
fix: radio group widget crash when one of options becomes null (#9303) 2021-11-25 14:59:16 +05:30
Trisha Anand
4512c86d87
feat: Trigger framework with default implementation for entity selector for UQI (#9142)
* Untested trigger framework added

* Entity selector is working!

* Moved to query params instead of request body for the trigger api (since the trigger api is of type GET)

* Adding minor comments

* Added test case for trigger functionality
2021-11-25 12:35:43 +05:30
NandanAnantharamu
3d495fc548
test: updated locators (#9271)
* updated locators

* updated dsl

* Skipping failing tests

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
2021-11-25 08:55:41 +05:30
Pawan Kumar
d96c4981ca
fix: Button size inside the Table widget has increased + Property pane's panel not scrollable + Alignment issues (#9318) 2021-11-24 17:55:07 +05:30
Vicky Bansal
bf513f5c60
fix: Hide scrollbar in header and show when user hovers over header in Table Widget (#9323)
Co-authored-by: root <pawan@appsmith.com>
2021-11-24 15:27:26 +05:30
Favour Ohanekwu
c98bbbe6ae
fix: properly update dependency map (#9169)
Properly update dependency map
2021-11-24 05:43:50 +01:00
Paul Li
3f87f4959e
fix: Table Widget Icon Button should be having a default variant (#8664)
* fix: Table Widget Icon Button should be having a default variant

-- Add update logic for button variant property

* fix: Table Widget Icon Button should have default variant

-- Revert old solution
-- Set default button variant to PRIMARY both in getTableColumns and in propertyConfig

* fix: Table Widget Icon Button should have default variant

-- Change comments for updateIconAlignment utility function
-- Create a migration for button variant

* fix: Table Widget Icon Button should have default variant

-- Remove unused index parameter from forEach statement

* fix: Table Widget Icon Button should have default button variant

-- Fix on misuse of forEach on primaryColumns object

* fix: Table Widget Icon Button should have default variant

-- Change buttonVariant to TERTIARY instead of PRIMARY
2021-11-23 22:10:13 +08:00
Bhavin K
ffefdcccd8
fix: added muted flag and updated helper text (#9259) 2021-11-23 15:10:43 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking (#7361)
* add tailwindcss

* docked property pane

* uncomment a line

* make entity explorer as drawer on unpin

* remove unused imports

* add pin state in  reducer

* add menu icon in header

* fix widget sidebar

* fix widgets sidebar

* style property pane

* update property pane css

* update icons in property pane

* update property pane header styles

* update spacing

* fix few ui issues

* wip: preview mode

* wip:preview mode

* remove unused import

* comments sidebar in app and edit mode

* fix order of import

* use selected state for property pane

* update scrollbar style

* add classes to sidebar and property pane

* make widgets editor fluid

* make widgets editor fluid and refactor logic

* resize the widgets editor if explorer is pinned

* add shortcut for preview mode

* fix link for tabs in edit mode

* zoom in/zoom out for 0.75

* fix chart widget + table widget crashing

* allow zooming of canvas

* fix weird canvas draw issue + update container for handling zoom

* add actions for is panning

* allow panning with grab cursor

* reset panning + zooming when entering preview mode

* add grabbing cursor when grabbing

* only prevent default when space key is pressed

* dont allow zoom in preview mode

* remove unused imports

* fix dont allow zoom in preview mode

* fix ux of panning on space hit

* make fluid as the default app layout

* chart spec

* fix dropdown_on change spec

* fix add widget table and bind spec

* remove draggable property pane spec

* fix container spec

* fix form widget spec

* fix jest test

* fix the function typo

* remove clicking of close button for property pane in cypress tests

* remove property pane actions test

* fix drag and drop test failing

* add cypress selector id to back button in property pane

* fix toggle js spec

* fix merge conflicts from new design system

* editor header

* fix product updates styles + widget card

* remove all unused imports

* fix dynamic layout spec

* fix entity explorer tab rename test failing

* fix table spec

* fix bind tabletextpagination spec

* fix js object spec

* fix entity explorer rename issue

* fix cypress test

* fix cypress command wrong commit

* fix tab spec

* fix property pane copy tests

* add zoom header

* zoom levels

* make property pane sidebar resizable

* add multi select property pane

* fix widget search bug

* update property pane width in state on drag end

* fix viewer header

* fix editor header

* update editor header + remove zooming

* update small style

* dont allow closing of explorer when resizing

* fix jest test

* fix dropdown widget jest test

* preview test case wip

* add entity explorer pinning tests + preview mode tests

* add tooltip in layout control + add padding bottom in property pane view

* incorporate aakash feedbacks

* fix preview mode margin issue

* remove panning code

* fix cypress failing test

* uncomment jest test

* remove redundant code

* fix maincontainer test

* incorporate review feedbacks

* incorporate aakash feedbacks

* review feedbacks

* incorporate review feedbacks

* incorporate qa feedbacks

* fix dynamic layout spec

* updated test based on latest change

* dsl updated

* Updated dsl

* Updated dsl

* resize deselects widget issue.

* fix canvas height issue

* fix typo

* incorporate qa feedbacks

* incorporate qa feedbacks

* incorporate qa feedbacks

* update color for setting control for widget name

* fix onboarding styles conflicts

* Updated tests

* fix application overflow issue

* updated test method

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
Yash Vibhandik
75a25925b8
fix: #5980 added clear all filters button and close filter pane button (#8734)
* fix: #5980 added clear all filters button and close filter pane button

* height updated

* updated class names for test case
2021-11-23 11:53:26 +05:30
Yash Vibhandik
399eabd987
fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name (#8770)
* fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name

* highlighted duplicate column labels, show error message only when duplicate column label focused

* updated test case

* updated duplicate label indicator logic for test case
2021-11-23 11:35:01 +05:30