Commit Graph

6439 Commits

Author SHA1 Message Date
balajisoundar
c9f65d080a
fix: skip bad table migration thats breaking computed columns we di… (#10897) 2022-02-04 23:07:22 +05:30
Anand Srinivasan
c2a6e089db
fix: passing params from JS to API/SQL query (#10826)
* Revert "fix: revert this.params solution (#10322)"

This reverts commit 2bcd73e41d.

* replace 'this.params' with 'executionParams'

* replace 'this?.params' also with 'executionParams'

* fix unit test lint errors

* added unit tests for params handling

* evaluateActionBindings unit test - add default value case

* comments update

* remove un-necessary `executionparams` assigment to `evalTree`
2022-02-04 17:58:46 +05:30
Rishabh Rathod
1bcf344154
fix: Race condition issue of meta reducer update (#10837)
* Fix race condition issue of meta reducer update

* refactor comment

* Fix logic to update meta state
2022-02-04 17:52:25 +05:30
Ayangade Adeoluwa
aa129fc26b
feat: adds Headers tab to the Api response view (#10807)
* adds Headers field to the Api response view

* show empty object if headers not present
2022-02-04 12:32:38 +01:00
Vicky Bansal
b7ebc7501e
fix: Column tile reposition on focus state of Input element inside property pane configuration for Table and Tabs widget (#10046) 2022-02-04 16:29:54 +05:30
Rishabh Saxena
ebb257bac2
chore: update cta text and doc url on the disconnect modal (#10872) 2022-02-04 12:40:36 +05:30
Tolulope Adetula
c82fab975d
fix: table column visibility (#10808) 2022-02-04 08:09:37 +01:00
Anagh Hegde
fa06473d63
fix: Delete the pages post merge operation from application when they are removed from file system (#10810)
* Delete the pages post merge operation from application if they are removed from file system

* Changes per review

* Add tests

* changes per review

* Use string utils for null check

* Change per review

* Fix tests

* Fix tcs
2022-02-04 12:07:07 +05:30
Paul Li
6b45805f21
fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.) (#10724)
-- Set trimValue prop to false with property controls such as TabControl, MenuItemsControl, ButtonListControl, PrimaryColumnsControl
2022-02-04 13:46:21 +08:00
Apeksha Bhosale
a66b8be886
fix: enable response tab in js editor even if it has warnings (#10866) 2022-02-03 21:29:46 +05:30
Shrikant Sharat Kandula
6967c35531
fix: Disallowed IPs can be bypassed by using a CNAME/A record (#10868)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-03 21:23:04 +05:30
Abhijeet
2e5c1ea4ec
chore: Update doc urls for errors related to git (#10852)
* Update doc urls for errors and SSH key response
2022-02-03 21:13:40 +05:30
Abhijeet
7329d7ff23
fix: Fix NPE during import application when page ids are missing for published action and actionCollection (#10858)
* Provide a fallback pageIds for missing ones in action and JSObjects published version

* Add TC
2022-02-03 20:08:58 +05:30
Abhijeet
e356fd039f
chore: Commit only unpublished resources to git repo which includes queries, JSObjects, pages to avoid data duplication (#10776)
* Commit only unpublished resources to avoid resolving merge conflicts twice

* Added TCs

* Update directory names, fix pull issue in JSObjects
2022-02-03 11:47:57 +00:00
rashmi rai
e73ccc7f25
fix: props is now required in type Validator (#10854) 2022-02-03 15:27:08 +05:30
Keyur Paralkar
da638d7f2b
Updated Template (#10853)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2022-02-03 15:23:56 +05:30
Tolulope Adetula
94dbd612c3
fix: onOptionChange on TreeSelects and fix Switch Toggle (#10632)
* fix: treeSelect onoptionChange

* fix: revert cypress

* fix:switch widget toggle

* fix: remove Important from styling
2022-02-02 23:57:49 -08:00
Sumit Kumar
6f83df976d
feat: add sorting and pagination features to S3 plugin (#10736)
* add sorting and pagination features to S3 plugin
2022-02-03 06:15:01 +00:00
Keyur Paralkar
45152272a6
fix: added sentry exception for invalid DynamicBindingListPath (#10790)
* fix: added sentry exception for invalid DynamicBindingListPath

* refactor: updated the error message

* test: update unit test case for dynamic binding path error

* fix: addressed review comments

* fix: removed widgetFactory and propertyPane code for invalidDynamicBindingPath function
2022-02-03 11:22:14 +05:30
Abhijeet
0b1a8ad20b
fix: Update ApplicationPageId with defaultPageId while fetching applications for homepage (#10812) 2022-02-03 10:56:35 +05:30
Bharat Patodi
743d6cb00d
chore: Replace equality and inequality operators with their strict versions (#7585)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-03 09:42:38 +05:30
Satish Gandham
fa32411383
chore: Perform perf tests on a large app (#10831)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-02-03 00:25:10 +05:30
Daniel
d29016590b
Merge pull request #10437 from appsmithorg/fix/name-of-undefined-datasource
fix: Name of undefined error in datasource catch Block
2022-02-02 19:53:11 +01:00
albinAppsmith
1c7a4f4a48
fix: Execute query overflow scroll issue (#10836) 2022-02-02 23:50:45 +05:30
Nidhi
f450ea5be3
fix: Fixed issue with H2 where PS parameters were getting merged if the keys were the same (#10805) 2022-02-02 17:43:53 +00:00
Vicky Bansal
a39176dc38
fix: add keywords to the validation list (#10690) 2022-02-02 21:05:42 +05:30
Mojtaba
170c263f9c
Merge pull request #10711 from appsmithorg/fix/9221-mysqlPlugin_user_with_empty_password
fix(mysqlPlugin): MySQL allow empty password if user is not empty
2022-02-02 18:39:51 +03:30
Segun Daniel Oluwadare
a91b7c2a2b fix: add default value 2022-02-02 16:03:34 +01:00
Danieldare
cf577f8751 fix undefined error 2022-02-02 16:03:33 +01:00
Daniel
ec1c3c9fb8
Merge pull request #10664 from appsmithorg/fix/db-section-overlap
fix: Datasources section overlap
2022-02-02 15:49:03 +01:00
Tolulope Adetula
bb2f7da823
feat: Select and Multiselect V2 (#10359)
* fix: Select V2

* Fix: CI Fail

* fix: failing test

* fix: failing test

* Fix: MultiSelect

* Fix: loading issue

* Fix: loadin state

* Fix: loading

* fix: failing test

* fix: evaluation tests

* Fix: failing tests

* Fix: failing test

* fix: failing tests

* Fix: Failing tests

* fix: select All

* fix: filtering

* Fix: filtering

* fix: refactor Select widget

* fix: hide MultiSelect

* fix: select options

* Fix: failing tests

* fix: failing tests

* Fix: issues

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* Update system-themes.json

* fix: PR reviews

* Update EntityDefinitions.ts

* Fix: issues

* fix: console

* fix: QA issues

* fix: options issues

* fix: add widget icons

* fix: update Selectv2

* empty commit to fix CI

* fix: failing test
2022-02-02 06:15:07 -08:00
Daniel
45816c51f1
Merge pull request #10652 from appsmithorg/fix/delete-icon-s3-amazon-page
fix: Change delete icon in s3 amazon where clause component
2022-02-02 04:59:45 -08:00
Vicky Bansal
b99a42acdf
fix: add pre-filled option on adding an option to a checkbox or radio button (#10544) 2022-02-02 17:40:40 +05:30
Danieldare
54e2f2e9b1 fix: revert delete icon name 2022-02-02 12:00:01 +01:00
Danieldare
cfc89819a8 fix: remove unused icon 2022-02-02 12:00:01 +01:00
Danieldare
43b77d08af fix: change delete icon 2022-02-02 12:00:01 +01:00
Danieldare
532ec5768c fix: datasources section overlap 2022-02-02 11:54:56 +01:00
Ankita Kinger
da68425a57
Merge pull request #10801 from appsmithorg/hotfix/team-settings-page
fix: Multiple API calls on Team settings page for same user role selection
2022-02-02 15:16:39 +05:30
rahulramesha
d1de691790
change reflow BETA Card (#10789) 2022-02-02 15:16:06 +05:30
Abhinav Jha
e08c7e66d4
fix: Purge orphaned paths from dynamic path lists in widgets (#10803)
- Paths in dynamicBindingPathList and dynamicTriggerPathList which don't exist in the widget, may cause issues later in the lifecycle of an application. Purging these orphaned paths during property updates.
2022-02-02 14:55:16 +05:30
Nidhi
bc93a1d413
fix: Removed filter of JS actions from get method (#10726) 2022-02-02 08:28:41 +00:00
Nidhi
b02a7f53f6
fix: Disabled generate CRUD page feature for MsSQL (#10811) 2022-02-02 08:27:59 +00:00
Rishabh Saxena
812da166e0
chore: beta tags for git sync (#10774) 2022-02-02 13:22:37 +05:30
Tolulope Adetula
ea1ba54603
fix: test case (#10804)
* fix: test case

* fix: dsl

* fix: DSL

* fix: test
2022-02-01 23:52:05 -08:00
Keyur Paralkar
2ec0d2b02a
fix: Updated Template (#10694)
* Updated Template

* Updated Template

* Updated Template

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2022-02-02 12:50:21 +05:30
Parthvi12
283ef050d4
test: Fixed flaky tests Replay_editor and Table_navigateTo_validation_spec (#10772)
* Fixed flaky tests Replay_editor_spec and TableWidget_NaviagateTo_Validation_spec

* adding fix for ActiveDatasource.spec
2022-02-02 10:52:10 +05:30
ankurrsinghal
c349f2f9f5
Merge pull request #10688 from appsmithorg/enhancement/focus-widget-title-on-f2
feat: added a keydown listener to focus property pane title on pressing f2
2022-02-02 10:51:46 +05:30
arunvjn
52f979cbf6
Fixes inconsistent rename behaviour for datasources (#10767) 2022-02-02 05:21:25 +00:00
Ankita Kinger
28e9f90f8b Merge branch 'release' of https://github.com/appsmithorg/appsmith into hotfix/team-settings-page 2022-02-01 18:19:16 +05:30
Ankita Kinger
98dea5e64a updated conditional check 2022-02-01 18:19:07 +05:30
Shrikant Sharat Kandula
b1997b8b08
fix: Disallow access to instance metadata hosts (#10797)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-02-01 18:07:08 +05:30
Ankita Kinger
6ef90973c5 Merge branch 'release' of https://github.com/appsmithorg/appsmith into hotfix/team-settings-page 2022-02-01 18:06:27 +05:30
Ankita Kinger
34da849cbd avoiding multiple API calls on selecting same role for a user under manage users 2022-02-01 18:06:10 +05:30
Bhavin K
4e28b4887c
Revert "fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770)" (#10786)
This reverts commit df1ee35992.
2022-02-01 15:43:20 +05:30
Tolulope Adetula
8729c2b435
fix: select treeselect value validation (#10760)
* fix: Select adn treeSelect validation

* fix: remove cy.wait()
2022-02-01 10:54:16 +01:00
Mojtaba Zarezadeh
d1ddebd3d8 merge all tests in one file 2022-02-01 13:02:53 +03:30
Bhavin K
df1ee35992
fix: Added iFrame to load Base64 PDF data in document viewer widget (#10770) 2022-02-01 13:37:52 +05:30
Mojtaba Zarezadeh
8197ebf297 fix: add single imports 2022-02-01 10:32:55 +03:30
Favour Ohanekwu
caca4131e7
fix: Evaluate PrivateWidgets to fix list widget children evaluation issue (#10737) 2022-02-01 10:48:57 +05:30
Vicky Bansal
8e174f7316
chore: Fix recaptcha script not loading issue (#10764) 2022-01-31 21:25:58 +05:30
Abhijeet
6b1e3fe7c0
fix: Add branch param for redirect url while authorising Google Sheet when application is connected to git (#10715)
* Add branch param in the redirect url
2022-01-31 10:11:12 +05:30
Rishabh Saxena
2e92b3a05e
chore: increase axios timeout for git specific APIs (#10732) 2022-01-31 09:48:58 +05:30
Abhijeet
8c4d711f5b
chore: Make sure to keep forked application in valid state even if client exits the flow before server responds (#10704) 2022-01-30 17:43:35 +05:30
Rishabh Saxena
c0285eb168
chore: use documentation link from the error response for git errors (#10662) 2022-01-29 13:56:27 +05:30
albinAppsmith
5cfe12bcea
feat: Entity explorer UI redesign (#9811)
Co-authored-by: arunvjn <arun@appsmith.com>
2022-01-29 12:56:19 +05:30
Daniel
20f5a7f7d3
Merge pull request #10681 from appsmithorg/fix/authenticated-api-query-parameters
fix: Add query parameters to Options/Form
2022-01-28 05:03:33 -08:00
Shrikant Sharat Kandula
d3d1f8bbf9
Clear sessions on password reset (#9955)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Nayan <nayan@appsmith.com>
2022-01-28 16:49:00 +05:30
Shrikant Sharat Kandula
cc3ab115b5
Remove CORS config as it's unused now (#10312)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-01-28 16:48:04 +05:30
Rishabh Rathod
b61ceab94b
fix: Add meta to eval cycle and update it when default changes (#10401)
* Rearrange data tree widget factory

* Remove existing handling of default value override

* Altternate way of meta property override

* Fix tests

Co-authored-by: hetunandu <hetu@appsmith.com>
2022-01-28 16:40:05 +05:30
Mojtaba Zarezadeh
e400ea0e80 cleanup: improve comments 2022-01-28 13:03:07 +03:30
Favour Ohanekwu
d5a459be30
fix: show lint warning when unused variable is present in code (#10599) 2022-01-28 09:18:19 +01:00
Mojtaba Zarezadeh
6d3be8c283 fix(mysqlPlugin): allow empty password if user is not empty 2022-01-28 11:43:21 +03:30
Abhijeet
07082f6bde
fix: Copy evaluation version for cloned application from the source application to fix dynamic binding evaluation to support escaped characters without double escapes (#10702) 2022-01-28 08:07:59 +00:00
Bhavin K
45d3704dda
fix: icon button remove default green (#10573) 2022-01-27 19:07:13 +05:30
Ankur Singhal
842828b187 added a keydown listener to focus property pane title on pressing f2 2022-01-27 16:40:57 +05:30
Yash Vibhandik
35d46b42d4
fix: #10428 styling support in popup (#10487) 2022-01-27 15:37:05 +05:30
Favour Ohanekwu
db3e29e15d
fix: Fix crash on broken list widget (#10670) 2022-01-27 15:31:24 +05:30
rashmi rai
10b3fe3800
feat: Validations for Action Forms (#10457) 2022-01-27 15:20:05 +05:30
Rishabh Rathod
d3c2833c8c
chore: remove defaultSelectedFiles (#10586)
- It is not being used anywhere
2022-01-27 09:40:51 +00:00
Danieldare
5cfc81a9d3 fix: add query parameters to options 2022-01-27 10:04:27 +01:00
Aman Agarwal
aab77b8ebb
fix: Memoized the Form Control Component reducing unwanted re-rendering (#10553)
* fix: reduced unnecessary re-rendering of form components

* fix: memoized form control and moved config errors to selector logic
2022-01-27 14:09:21 +05:30
Tolulope Adetula
b89c3100e4
fix: RTE required field (#10629) 2022-01-27 00:37:50 -08:00
Abhijeet
8d93d06317
feat: Add reference doc url for error responses for git APIs (#10620)
* Added reference doc urls for pull conflicts

* Update TCs
2022-01-27 13:08:21 +05:30
Bhavin K
dfaddfbce4
fix: Datepicker closeOnSelection will now remain true by default for new widget drops(#10479) 2022-01-27 11:42:39 +05:30
Anagh Hegde
e0e4a73650
fix: Logic to delete stale git branch which are not in db (#10647) 2022-01-26 21:29:00 +05:30
Anagh Hegde
c83f7fb3c1
feat: Git import api (#10282)
* Added API to generate deploy keys and store them in a collection for import flow

* Add tests for the key generation flow

* Move the key generation to helper class

* changes per review

* Fix bad merge

* add api to import application

* handle timeout for git import

* Update the comments

* Add API for git import

* handle duplicate application name error & add profiles while importing

* Add tests for import api

* Hydrate from file system after cloning the repo

* Fix test failures

* Test cases

* changes per review

* throw error when the datasource with same name of different type exists

* Fix test failures

* Fis error messages

* Fix test failures

* Fix issue with checking the datasource types

* Add datasource name check while importing the application

* Refactor SSH key gen code for import

* Resolve issues around defaultResourceIds, don't commit app name

* Resolve the issue related to duplicate name for app during import

* Minor fixes

* WIP

* Add logic to get unconfigured datasources for the application

* Fix tests

* WIP

* revert datasource related changes

* Add a boolean flag to Datasource entity

* Add a boolean flag to Datasource entity

* Add flag to identify import status

* Set application name before importing from json files in git-import

* update the variable name

* changes per review

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2022-01-26 21:26:22 +05:30
Abhijeet
0183897d5a
chore: Update mongo indexes to improve the query performance (#10658)
* Add index for JScollection, action and userData

* Refactor
2022-01-26 21:24:56 +05:30
Nidhi
c7d1e87c0a
fix: Removed tracking on Sentry for unsupported plugin operation (#10636) 2022-01-26 19:02:48 +05:30
Abhijeet
231c3aaeb7
fix: Bugfix for curl import when the request is made from the child branch for git-connected application (#10638)
* Fix for curl import in sub-branch

* Added comment
2022-01-26 18:20:49 +05:30
Daniel
d553495d23
Merge pull request #10321 from appsmithorg/fix/active-datasoure-flash-page
fix: Active datasource page flashes to user upon clicking the Save DataSource Button.
2022-01-26 11:42:36 +01:00
Sumit Kumar
610d665aae
add query params to form.json (#10574) 2022-01-26 12:59:07 +05:30
Anagh Hegde
341bc61e8c
feat: Add logic to sync the repo if the path is not updated in env file (#10478)
* Add logic to sync the repo if the path is not updated in env file

* changes per review

* checkout branch locally when the branch is not present in remote

* Add the local checked out branch to list
2022-01-26 12:55:07 +05:30
Keyur Paralkar
5afff85e8d
fix: changed validation to FUNCTION for the default selected value RadioGroupWidget (#10020)
* fix: changed validation to FUNCTION for the default selected value RadioGroupWidget

* refactor: changed evalued struct msg for radio group default value

* test: added cypress test for checking radiogroup widget with integer value

* test: added jest test to validate the defaultValidation function for radio widget

* refactor: changed the test case title

* chore: updated yarn.lock file

* refactor: addressed the review comments

* refactor: added comment for defaultOptionValidation

* refactor: changed the expected example [QA comment]

* fix: added validationOperationType prop

* Revert "fix: added validationOperationType prop"

This reverts commit 896226fe940621c2c71aa8a9e87831039a9655de.

* fix: added custom validation for the options property

* fix: modififed the custom validation logic

* refactor: modified the cypress test

* refactor: addressed review comments

* refactor: addressed review comments

* refactor: addressed review comments; Updated custom validation for DSV; Update cypress

* refactor: added boolean check for the default selected value

* refactor: addressed review comments

* test: fixed jest test case
2022-01-26 12:48:13 +05:30
Shrikant Sharat Kandula
6accb9e364
fix: Use CDN for all assets (#10417)
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-26 02:19:43 +05:30
Ashok Kumar M
2a8e37bf3b
feat: Sliding Canvas for Dragging and Selection (#9983)
* Move existing canvas's to CanvasArenas folder

* moving hooks to canvas arenas folder.

* Sticky canvas implementation.

* fixing specs(WIP)

* dip

* fixing test cases.

* removing comments.

* fixing build

* renaming for readability.

* adding folder for canvas based sagas.

* Resolve conflicts.

* fixing failed cases.

* fixing cypress cases.

* fixing bugs introduced coz of drag and drop.

* fixing bugs.

* few more bug fixes in draw to select.

* mouse pointer default when drag to select.

* bug fix.

* dip

* integrating intersection api.

* dip need to adjust offset

* fixing offset issues.

* readability fix

* rebase bug fixes.

* bug fix.

* adjust canvas slider on mouse over.

* unwanted changes.

* left offset fix + removing dead code.

* fixing bugs.

* fixing broken test cases.

* addressing code review comments.
2022-01-25 20:58:31 +05:30
NandanAnantharamu
91986714f6
test: commenting out Typescript tests (#10619) 2022-01-25 20:21:54 +05:30
dependabot[bot]
113c96dc54
chore: bump h2 from 2.0.206 to 2.1.210 in /app/server/appsmith-interfaces (#10554)
Bumps [h2](https://github.com/h2database/h2database) from 2.0.206 to 2.1.210.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/compare/version-2.0.206...version-2.1.210)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-25 19:38:36 +05:30
NandanAnantharamu
5245984ff8
test: Table Download test (#10571)
* Table Download test

* updated test
2022-01-25 19:37:51 +05:30
Confidence Okoghenun
98a8aab728
feat: Adds code hint for JS promises in JS Object editor (#10570) 2022-01-25 19:34:10 +05:30
akash-codemonk
94d37f55dd
feat: improved guided tour (#9125) 2022-01-25 19:26:52 +05:30