Commit Graph

722 Commits

Author SHA1 Message Date
Aswath K
eed6ad9166
fix: empty string validation if required is set (#9476) 2021-12-02 16:45:18 +05:30
Keyur Paralkar
ba5262df2c
fix: fixed the default value of zero not present in parent form data on pageload (#9324)
* fix: fixed the default value of zero not present in parent form data on pageload

* test: added cypress test for Checking default value 0

* refactor: changed the DSL and added reset condition at the end of test

* refactor: removed the proxy variable

* refactor: corrected the typo
2021-12-02 11:36:24 +05:30
Aishwarya-U-R
37339c0cb1
test: RestAPI parallel run & Debug btn crash [Bugs 5550, 6863, 8686] - Script implementation (#9435)
* Bugs 5550, 6863 - Script implemented

* Added wait time in cy.updateCodeInput

* S3 DeleteSource failure fix

* S3 Delete Ds case fix

* Mongo Failure fixes

* Failure fixes

* Bug 8686 - Implemented

* cypress.json updated

* Added wait for proper validation pass

* Updated

* Updated EvaluateCurrentValue

* Update commands.js

* Added AfterEach

* Updated EvaluateCurrentValue()
2021-12-02 10:50:44 +05:30
NandanAnantharamu
425a46f34d
test: updated filter tests (#9448)
* Filter Tests

* Test spec added

* updated import

* added some wait

* updated the dependencies

* Added the dependancy files
2021-11-30 20:56:37 +05:30
Tolulope Adetula
809a288bdc
fix: popups same width as parent (#7499)
* fix: select widget popup

* fix: select widget

* fix: Menu button

* fix: make Clear Var names

* fix: consistent dropdown width

* fix: define variable better

* fix: prettier error

* fix: variable name

* fix: select popup issue

* fix: PR issues add comments

* fix: remove unused css

* fix: add tests

* fix: more pop overs

* fix: menu button popup

* fix: Multiselect dropdown

* fix: failing test

* fix: add more tests

* fix: Failing Test
2021-11-30 02:38:46 -08:00
rashmi rai
b65258876f
fix: missing number of queries in active datasource (#7694) 2021-11-30 10:11:40 +00:00
Parthvi12
af430d7049
test: testcases for content management system app using echo api (#9420)
* testcases for content management system app using echo api

* added response check method for API calls
2021-11-30 09:28:57 +05:30
Parthvi12
720806574f
test: PgAdminFix (#9313)
* commenting failing tcs for now

* resolving conflict and  fixing testcases

* Update PgAdmin_spec.js

* fixing testcases

Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-11-30 04:54:42 +05:30
Bhavin K
6ea90e7c7b
feat: add document viewer widget (#7666)
* created new widget

* new lib for document viewer

* added cypress tests

* updated icon

* handling different url types with viewer

* add to ignore react-documents in jest transformIgnorePatterns

* added jest test, updated comments

* required changes

* updated cypress test

* updated icon svg

* doc viewer new renderers added

* comment as required

* updated test case

* added url / base64 validations

* updated url checking condition for space and updated test case

* cypress selector update

* updated url validations

* Merge branch 'release' into feature/new-document-viewer

* lazy load external lib
2021-11-29 15:37:49 +00:00
Yash Vibhandik
f6acbf1407
fix: #8530 Added Config for Menu JS Convertible (#8775)
* fix: #8530 updated config for menu color jsconvertible

* test case updated

* yarn lock update
2021-11-29 15:37:05 +00:00
NandanAnantharamu
2a3089383a
updated test flow (#9388) 2021-11-26 12:18:31 +00:00
Tolulope Adetula
f30e389167
fix: Evaluation issue with Button in table Widget (#9356)
* fix: Evaluation issue

* fix: add validation

* revert jest tests changes

* revert cypress test

Co-authored-by: root <pawan@appsmith.com>
2021-11-26 17:03:50 +05:30
Aishwarya-U-R
e5a28b3d9b
test: S3 QueryPane scripting along with possible CRUD flow coverage (#9278)
* S3 QueryPane scritping

* Postgress, S3 - failure fixes

* Postgres, S3 failure fixes

* S3 failure fixes

* Added scrollIntoView for Postgres CRUD failures

* S3 - Suggested&Snipeable widgets implemented

* S3 CRUD - failure fix

* Postgres, S3 CRUD failure fixes

* S3 field inputs corrected

* JQuery empty used to clear fields

* Commenting cases to unblock CI runs

* PgAdmin Spec - commenting failures to unblock CI

* S3, Postgres CRUD failure fixes

* Added Wait for Onboarding spec case failure

* typeValueNValidate - updated

* typeValueNValidate updated

* Reverted typeValueNValidate method trigger change

* Adding wait to typeValueNValidate

* Updated typeValueNValidate with updateCodeInput
2021-11-26 16:17:53 +05:30
Hetu Nandu
8f2935f023
fix: Don't remove bindings when transfering action out of page (#9296) 2021-11-26 14:34:16 +05:30
Hetu Nandu
5d7f68a031
fix: Mute action execution errors when error callback is present (#9366) 2021-11-25 15:28:04 +05:30
NandanAnantharamu
3d495fc548
test: updated locators (#9271)
* updated locators

* updated dsl

* Skipping failing tests

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
2021-11-25 08:55:41 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking (#7361)
* add tailwindcss

* docked property pane

* uncomment a line

* make entity explorer as drawer on unpin

* remove unused imports

* add pin state in  reducer

* add menu icon in header

* fix widget sidebar

* fix widgets sidebar

* style property pane

* update property pane css

* update icons in property pane

* update property pane header styles

* update spacing

* fix few ui issues

* wip: preview mode

* wip:preview mode

* remove unused import

* comments sidebar in app and edit mode

* fix order of import

* use selected state for property pane

* update scrollbar style

* add classes to sidebar and property pane

* make widgets editor fluid

* make widgets editor fluid and refactor logic

* resize the widgets editor if explorer is pinned

* add shortcut for preview mode

* fix link for tabs in edit mode

* zoom in/zoom out for 0.75

* fix chart widget + table widget crashing

* allow zooming of canvas

* fix weird canvas draw issue + update container for handling zoom

* add actions for is panning

* allow panning with grab cursor

* reset panning + zooming when entering preview mode

* add grabbing cursor when grabbing

* only prevent default when space key is pressed

* dont allow zoom in preview mode

* remove unused imports

* fix dont allow zoom in preview mode

* fix ux of panning on space hit

* make fluid as the default app layout

* chart spec

* fix dropdown_on change spec

* fix add widget table and bind spec

* remove draggable property pane spec

* fix container spec

* fix form widget spec

* fix jest test

* fix the function typo

* remove clicking of close button for property pane in cypress tests

* remove property pane actions test

* fix drag and drop test failing

* add cypress selector id to back button in property pane

* fix toggle js spec

* fix merge conflicts from new design system

* editor header

* fix product updates styles + widget card

* remove all unused imports

* fix dynamic layout spec

* fix entity explorer tab rename test failing

* fix table spec

* fix bind tabletextpagination spec

* fix js object spec

* fix entity explorer rename issue

* fix cypress test

* fix cypress command wrong commit

* fix tab spec

* fix property pane copy tests

* add zoom header

* zoom levels

* make property pane sidebar resizable

* add multi select property pane

* fix widget search bug

* update property pane width in state on drag end

* fix viewer header

* fix editor header

* update editor header + remove zooming

* update small style

* dont allow closing of explorer when resizing

* fix jest test

* fix dropdown widget jest test

* preview test case wip

* add entity explorer pinning tests + preview mode tests

* add tooltip in layout control + add padding bottom in property pane view

* incorporate aakash feedbacks

* fix preview mode margin issue

* remove panning code

* fix cypress failing test

* uncomment jest test

* remove redundant code

* fix maincontainer test

* incorporate review feedbacks

* incorporate aakash feedbacks

* review feedbacks

* incorporate review feedbacks

* incorporate qa feedbacks

* fix dynamic layout spec

* updated test based on latest change

* dsl updated

* Updated dsl

* Updated dsl

* resize deselects widget issue.

* fix canvas height issue

* fix typo

* incorporate qa feedbacks

* incorporate qa feedbacks

* incorporate qa feedbacks

* update color for setting control for widget name

* fix onboarding styles conflicts

* Updated tests

* fix application overflow issue

* updated test method

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
Yash Vibhandik
399eabd987
fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name (#8770)
* fix: #4758 added EvaluatedValuePopup over PrimaryColumnsControl to show errors and handled duplicate column name

* highlighted duplicate column labels, show error message only when duplicate column label focused

* updated test case

* updated duplicate label indicator logic for test case
2021-11-23 11:35:01 +05:30
Pranav Kanade
bffe28361a
fix: Show invite option for substring user emails of other shared users (#8962)
* show invitation option for overlapping email addr string if no exact match is found.

* added test case

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-11-22 10:33:43 +05:30
Parthvi12
ff0222e270
test: PgAdminApp Intial (#9139)
* PgAdminApp Intial

* refactored spec file and adding PgAdminlocators.json file

* updated json file path

* updated locator file

* added comments to the spec file
2021-11-21 14:00:20 +00:00
Aishwarya-U-R
c52e1d9072
test: Intercept/Real DB for Mongo, MySQL & QueryPane with CRUD flow for Postgres (#9081)
* Intercept/Real DB-Mongo,Postgres-Querypane

* Intercept-Mongo, SQL, Query-Postgres

* Added back welcomePage reference
2021-11-18 14:27:51 +00:00
Aswath K
701207718b
fix: Unable to drag disabled button (#8206) 2021-11-18 15:52:04 +05:30
balajisoundar
7978833011
test: first time user onboarding cypress tests (#9171) 2021-11-17 20:58:23 +05:30
Hetu Nandu
91253e8791
Fix issue where widget property evaluation substitution type was overriden (#9191) 2021-11-17 13:57:58 +00:00
NandanAnantharamu
72cce79a36
test: updated createModal util (#9120)
* updated common method

* Updated login route wait

* updated method
2021-11-17 15:40:57 +05:30
albinAppsmith
06ca32cd96
fix: Edit icon in API editor and toggle transition issue (#9013) 2021-11-17 12:06:18 +05:30
Yash Vibhandik
9c751ae58e
fix: #8528 Added default Icon column (#8733)
* fix: #8528 added defaultIconName for controlType ICON_SELECT and updated default value for column type icon button

* test case update
2021-11-16 16:12:20 +05:30
Yash Vibhandik
27d12754c6
fix: 8537 submenu color when disabled (#8948)
* fix: 8537 submenu color when disabled

* updated test case
2021-11-16 16:00:46 +05:30
Bhavin K
7032ee6b89
fix: Update designs for select widgets according to Figma (#8594)
* updated design as per figma

* updated design, fix cypress test

* item width fix as required

* label functionality in select, tree-select wids

* changes as required

* label, placeholder and default focused item logic changes for select

* updated border color for invalid selected value

* fix for colors file
2021-11-16 09:27:38 +00:00
Hetu Nandu
429337b5b1
fix: clearInterval action creator adds argument in the wrong slot (#9029) 2021-11-16 09:26:47 +00:00
Pranav Kanade
dcf184b05b
added a fix and test case (#9167) 2021-11-16 12:36:18 +05:30
Paul Li
d700b62ac5
feat: Spellcheck property for the input widget (#8496)
* feat: Spellcheck property for the input widget

-- Add a new widget boolean property, isSpellCheck
-- Add the corresponding Cypress test cases

* feat: Spellcheck property for the input widget

-- Place isSpellCheck property just after autoFocus property
2021-11-12 15:34:10 +08:00
Yash Vibhandik
4b2c1fc316
fix: 8543 added disabled flag support in icon button table widget (#8950)
* fix: 8543 added disabled flag support in icon button table widget

* updated test case
2021-11-11 16:09:21 +05:30
NandanAnantharamu
8bc0b0a90d
test: Disable status check for deleteApp step after each test (#9001)
* DeleteApp Status check disabled

* Updated deleteApp status code check to false

* Moved Layout widgets spec to clientside
2021-11-09 17:48:21 +05:30
Aswath K
7570734f23
fix: Unable to group widgets (#9043)
* fix: Unable to group when indexeddb is empty

* Add test for widget grouping
2021-11-09 15:12:07 +05:30
Tolulope Adetula
dbbb7b84b2
fix: disable sorting in view mode (#7387)
* fix: disable sorting in view mode

* fix: add sortable to property pane

* fix: fix failing tests

* fix: Add cypress test

* fix: remove unneccesary useMemo

* fix: sortable columns

* fix: default switch value

* fix: revert switch control and add migrations

* fix: migration
2021-11-08 21:08:39 -08:00
Bhavin K
2956162d7f
feat: new tooltip, updated cypress tests (#8759) 2021-11-03 09:24:19 +05:30
rashmi rai
f56e5dce1a
fix: added try catch in where key handling (#8618) 2021-11-02 15:06:42 +00:00
albinAppsmith
55df317211
fix: API Editor bug fixes (#8803)
* * Confirmation modal fixes

* * header overflow fixed, API editor

* * Delete truncate issue fix
* Tabs count UI fix

* * Removed hardcoded text from component and added in messages

* * removed hardcoded size

* * fixed scroll issue in appviewer

* * eval field fixes

* * design fix for key in API pane

* * fixed test cases
2021-11-01 10:24:06 +05:30
Bhavin Ag
da5baba982
fix: rename no item to no results in select components (#8666)
* style: update no results found style for multi select

* style: update empty data text for multi select widget

* style(SingleSelectTree): update style for no items found

* style: remove minimum width from empty containers

* test: add integration test for tree select

* test: add integration test for empty data for multi select

* test: add integration test for empty states
2021-10-30 23:25:23 -07:00
Aishwarya-U-R
d3f2f8c04f
test: Generate CRUD implementation - Mongo, MySQL, S3 (#8879)
* Generate CRUD implementation - Mongo, MySQL, S3

* Revertion from intercept to route
2021-10-29 07:02:45 +00:00
rahulramesha
ce453fd259
fix: Copied modal close and mobile modal bug fix (#8497)
* fix for copied widget

* copied modal paste on maincontainer fix

* mobile modal fix

* added logic to paste modal widget on the main container only

* added check only for modal Widget close since the saga seems to be shared for other scenarios
2021-10-28 07:41:19 +05:30
NandanAnantharamu
294032376f
test: lint error/warning tests (#7211)
* Test for lint

* Basic tests for Linting Warning/Error

* Updated tests

* Updated tests

* Updated tests with another lint scenario

* updated test

* Added tests for list and text Widget

* Updated tests

* Updated tests
2021-10-27 12:54:02 +05:30
NandanAnantharamu
b27e3567c6
Updated test (#8811) 2021-10-27 11:38:39 +05:30
NandanAnantharamu
ce26b5bb5f
Commented Delete Test (#8589) 2021-10-26 22:26:26 +05:30
Apeksha Bhosale
4487fee83e
fix: changed dummy actions object (#8510)
* changed dummy actions object

* Snippets for js objects

* added js objects tag

* fixed tests for new changes

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-10-26 18:23:58 +05:30
Anand Srinivasan
9e55ca9ff0
fix: table widget design (#8426)
* Table - multi-select checkbox and selected row color update

* table: change hoverstyle on multi-select checkbox

* re-order conditions

* table widget: use px for positioning checkbox

* change hover style for unselected row

* check box remains white on hover

* fix cypress test

* table search box - highlight on active

* search cancel icon updated

* move svg to assets folder
2021-10-26 14:01:27 +05:30
Tolulope Adetula
3a40b76790
fix: page number reset (#8681)
* fix: page number reset

* fix: add cypress test
2021-10-26 01:12:03 -07:00
Rafael Baldasso Audibert
0e22f26621
fix: Change "Allow Horizontal Scroll" text to "Allow scroll" (#8085)
* chore: Change "Allow Horizontal Scroll" to "Allow Scroll"

* chore: Hide option to choose scroll for pie chart

* fix: Fix prettier errors

* feat: Add migration to allowScroll for `CHART_WIDGET`s

Closes #4227

* fix: Fix chart widget prop recursively

Per https://github.com/appsmithorg/appsmith/pull/8085#discussion_r733442011
Closes #4227
2021-10-25 17:09:39 +05:30
Rishabh Saxena
8dc3fb4951
fix: don't fetch comment threads for anonymous users (#8717)
* fix: don't fetch comment threads for anonymous users

* fix: add wait to public apps test

* proper fix

* var updated

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-10-22 17:10:12 +05:30
akash-codemonk
6347bd9c38
fix: show tooltips for entity names in explorer (#8501) 2021-10-21 10:07:34 +05:30
Rishabh Saxena
31476092cc
chore: refactors for supporting git branches (#7695) 2021-10-18 19:33:44 +05:30
Aswath K
ce4b984e27
fix: unable to change button color on table widget (#8521)
* fix: unable to change button color on table widget

* Adds test for Table button color validation

* removes commented out code
2021-10-14 16:25:03 +05:30
Paul Li
c9c529646f
feat: RTE - option to hide the toolbar (#8271)
-- Add a new widget property, isToolbarHidden
-- Add new Cypress test cases for the newly added property
2021-10-13 18:10:52 +05:30
Aswath K
24b9da6741
fix: change Button variant types constant (#7817)
* change Button variant types constant

* Add migration

* Adds cypress test to validate default button variant

* update the ButtonVariant for MenuButton inside table widget

* Remove only from Button_spec

* fix: Binding issue with Variant in table

* fix: cypress test for default variant validation

* Add validation to IconButton inside table
2021-10-12 08:04:51 +00:00
albinAppsmith
71886c3b9e
feat: Property pane dropdown overflow issues (#8236)
* * hide subtext for date picker fix
* EE clicking on entity, unfolding/folding added

* * bug fixes in action dropdown

* bug fix for cursor

* fix: 8190 background api request and welcome helper button (#8281)

* chore: Move action/js debugger tabs related logic to a common component (#8199)

* removed background of api request textbox and added hover text on "no thanks" button

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>

* fix: added scrolling in invited users more popup (#8226)

* added scrolling in invited users more popup

* always scrollbar displaying on invited users pan

* fixed issue related with 8190

* updated cursor of invited users more

* replace edit data source icon with remix icon (#8192)

* * active text color

* fix: dropdownlist props issue (#8322)

* Commented failing JS tests (#8276)

Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>

* docs: Update ServerSetup.md (#8255)

* Make port customizable from env variable (#8288)

* fix: issue with string templates (#7848)

* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests

* fixed props pass issue

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>

* * bug fixes

* * bug fix

* * test cases fix

* - test case fix

* * test fixes

* * bug fix in test case

Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-11 11:31:05 +05:30
Arpit Mohan
57bdbdc0f9
test: Fixing some cypress tests that were asserting if the message texts are correct (#8369) 2021-10-11 10:38:08 +05:30
Bhavin K
59af26dd8e
fix: tooltip should hide for a disabled on button widget (#8209) 2021-10-08 19:58:59 +05:30
Vicky Bansal
fdac6428b4
fix: Icon button click should not de-select row in table widget (#8197) 2021-10-08 18:00:12 +05:30
akash-codemonk
9f2c32b9de
fix: onboarding table widget is blank after adding binding (#8285) 2021-10-08 13:22:08 +05:30
Aswath K
b02240cc34
fix: Focus lost when typing on property pane (#8318)
* fix: Focus lost when typing on property pane

* resurrect tests for Radio & CheckboxGroup
2021-10-08 13:09:31 +05:30
balajisoundar
d1efe8405e
feat: Add tooltips for icons in editor (#7711)
fixes: #6759
2021-10-08 12:35:34 +05:30
NandanAnantharamu
470fab30f7
test: S3Crud test fix (#8323)
* added route for a validation

* removed calls which are not happening
2021-10-08 08:32:34 +05:30
yatinappsmith
9ff6c804dc
Commented failing JS tests (#8276)
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
2021-10-07 16:13:01 +05:30
akash-codemonk
30c859180e
chore: Move action/js debugger tabs related logic to a common component (#8199) 2021-10-07 12:23:58 +05:30
yatinappsmith
f900cf9765
test: JSEditor Tests (#8068)
* Added basic support for JSEditor

* Added copy and delete test cases

* Basic changes for js editor

* Basic tests

* JSEditor Binding tests
2021-10-07 07:59:16 +05:30
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
NandanAnantharamu
77d1c7ccfc
test: Updated flaky test (#8198)
* Updated flaky test

* updated test

* updated test

* commenting test
2021-10-05 18:39:07 +05:30
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30
Favour Ohanekwu
30d0fb7a6d
fix: Add window object methods and properties as invalid entity name (#7928)
Added window object property and method names to list of invalid entity names
2021-10-04 13:49:58 +01:00
Rishabh Saxena
a69c8b7484
feat: callouts for wip features (#8080) 2021-10-04 13:31:46 +05:30
Pranav Kanade
ca4541a415
updated existing test cases to validate the import export flow with different user permissions (#8099) 2021-10-04 13:04:48 +05:30
Pranav Kanade
b261efc511
fix: skip bot comment when user skips comments tour (#7693)
* setup for skipping the bot comments if user skips the comments tour

* Using the onboarding status api

* removed comments

* fixed typos

* added test cases

* small fixes

* updated the tests

* minor update to a test case
2021-10-01 21:55:55 +05:30
akash-codemonk
48f2c584ab
fix: Fix mismatch between errors in debugger and evaluated value popup (#7752) 2021-09-29 17:33:11 +05:30
Tolulope Adetula
60131403b2
feat: disable parsing link (#7075)
* feat: add disableLink for text widget

* feat: add test for disable link

* fix: email parsing

* fix: test issues

* fix: failing test

* fix: failing test
2021-09-26 23:00:40 -07:00
arunvjn
90fda1ccae
fix: Remove snippet and doc icon from property pane (#7806) 2021-09-27 04:56:39 +00:00
rahulramesha
46f525d365
fix: modal widget issues (#7821)
* fixing modal issues

* adding cypress tests

* patch for modal Issues
2021-09-25 16:45:39 +05:30
Aswath K
8a45e1507e
feat: Add AudioWidget (#7179)
* Create initial version of AudioWidget by copying VideoWidget

* Add EventType for AUDIO

* Change default Audio URL to a podcast related to Appsmith

* Add AudioWidget icon

* Change Entity definition for AudioWidget

* Add cypress test

* Add jest test

* fix: typo
2021-09-24 21:35:53 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
Vicky Bansal
609cdc05e4
feat: Table selected row and action trigger UX improvement (#7310) 2021-09-23 17:16:47 +05:30
NandanAnantharamu
8e6ba37d00
test: fix/Updated common method (#7734)
* Updated common method

* updated dsl
2021-09-23 16:44:01 +05:30
Pawan Kumar
c48cdcdeb4
chore: comment out the moving widget cypress test (#7733)
* comment out the moving of widgets test

* update tests for replay spec

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-22 20:38:03 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
Apeksha Bhosale
ffe00cd1a2
fix: widget refactor actions fetch change (#7574)
* widget refactor actions fetch change

* Added test for binding Button with API

Co-authored-by: Apple <nandan@thinkify.io>
2021-09-21 11:32:30 +05:30
rahulramesha
0b37812b56
feat: resizable modal (#7312)
* dip

* resizable modal full working commit

* resizable modal minor fixes

* code restructuring

* fix canvas small size bugs and add migration to remove modal type

* moving resize modal to modal sagas

* layoutResize and last column width

* fix warning

* setResizible if resizing

* fix incorrect import

* fixing cypress tests

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-09-20 22:36:13 +05:30
Nikhil Nandagopal
b9b5d54745
fix: Property pane updates (#7631)
* Renamed TreeSelect Widget
2021-09-20 20:48:10 +05:30
akash-codemonk
9877fe4b05
fix: Switch to the debugger error tab when clicked on the debug button in toast (#7455) 2021-09-20 16:50:22 +05:30
Tolulope Adetula
15b26f823e
feat: Tree Select widget (#6271)
* feat: Tree Select

* feat: styling multiselect

* fix: selected values

* fix: remove console statement

* fix: popup position

* fix: selection types

* fix: Form validation using TreeSelect

* feat: Add Label to TreeSelect

* fix: styling

* fix: Dropdown search

* fix: Add Entity Definitions

* fix: Entity Definition

* Feat: Add clear icon

* fix: validation

* fix: options validation

* fix: Styling issues

* fix: build error

* Fix: Separate Tree Select widget

* fix: issues and add validation

* fix: Options Validation

* fix: issues with build

* fix: yarn

* fix: changes

* fix

* Fix: select component

* fix: PR issues

* fix: merge conflicts

* fix: issues

* fix: all issues

* test: added test

* fix: failing test
2021-09-17 02:08:35 -07:00
NandanAnantharamu
1d101300a5
test: fixing the Cypress test for input spec (#7551) 2021-09-16 16:05:02 +00:00
NandanAnantharamu
30d337c9dc
test: Added test for public apps access check (#7525) 2021-09-16 13:44:30 +00:00
NandanAnantharamu
738f5940f2
Updated test (#7535) 2021-09-16 18:19:46 +05:30
Bhavin K
9116c6483f
fix: add check for max char in input widget only applicable for text type (#7250) 2021-09-16 16:32:34 +05:30
ashit-rath
0354fdaa16
fix: Input widget as number type 0 as default value (#7251)
* fix: Input widget as number type 0 as default value

* added cypress test case

* cypress test fix, force click default text input

* updated input widget validation of number/currency/phone number type

* minor change
2021-09-16 11:22:01 +05:30
Yash Vibhandik
aea55014ec
fix: added container wrapper component to handle styles (#6476)
* FIX #2587 : added container wrapper component to handle styles, updated test cases

* FIX #2587 : abstract widget style component for common use and wraped on text widget

* updated style boundary and css

* updated cypress test

* fix: accommodate prop pane height change for the test

* removed properties from text widget

* updated container wrapper style to handle border corners, updated migrations for container and form widget

* fixed container overflow

* added testcases for container and text widget

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-09-16 09:51:31 +05:30
rahulramesha
c4de8fc720
fix: copy paste new widget key generation (#7464)
fixes widgets from having exact same react keys
2021-09-15 19:34:27 +05:30
NandanAnantharamu
1db152bd5c
updated test and common method (#7446) 2021-09-15 14:07:58 +05:30
akash-codemonk
e9fe54fefe
fix: Show trigger errors in the debugger with widget and property name (#6970) 2021-09-15 10:41:13 +05:30
akash-codemonk
d34827da78
fix: Show recent errors first in the debugger error tab (#7420) 2021-09-14 20:21:07 +05:30
ashit-rath
289c490217
fix: allow multiple draggable popper to co-exist (#7323)
* fix: allow multiple draggable popper to co-exist

* added custom data-cy for popper drag handler to fix failing cypress tests
2021-09-13 18:05:05 +05:30
NandanAnantharamu
0cfdd35df1
Test : Added assertion for query data (#7061) 2021-09-13 14:27:00 +05:30
yatinappsmith
6f4d91865b
commenting dropdown_spec (#7271) 2021-09-09 10:31:16 +05:30
Apeksha Bhosale
09eea59330
feat: JS Editor (#6003)
* Changes to add js plugin

* routes+reducer+create template

* added debugger to js editor page

* entity explorer changes

* create js function

* added copy, move and delete action

* added js plugin

* added existing js functions to data tree

* removed actionconfig for js collection

* new js function added to data tree and entity as well

* parsing flow added

* changes to data tree

* parse and update js functions

* small changes for def creator for js action

* create delete modified

* small changes for update

* update flow change

* entity properties added

* removed linting errors

* small changes in entity explorer

* changes for update

* move, copy implementation

* conflict resolved

* changes for dependecy map creation

* Only make the variables the binding paths

* Basic eval sync working

* Minor fixes

* removed unwanted code

* entity props and autocomplete

* saving in progress show

* redirection fix after delete js action

* removed unnecessary line

* Fixing merge conflict

* added sample body

* removed dummy data and added plugin Type

* few PR comments fixed

* automplete fix

* few more PR comments fix

* PR commnets fix

* move and copy api change

* js colleciton name refactor & 'move to page' changes & search

* view changes

* autocomplete added for js collections

* removing till async is implemented

* small changes

* separate js pane response view

* Executing functions

* js collection to js objects

* entity explorer issue and resolve action on page switch

* removed unused line

* small color fix

* js file icon added

* added js action to property pane

* Property pane changes for actions

* property pane changes for js functions

* showing syntax error for now

* actions sorted in response tab

* added js objects to slash and recent entitties

* enabling this to be used inside of function

* eval fix

* feature flag changes for entity explorer and property pane

* debugger changes

* copy bug fix

* small changes for eval

* debugger bug fix

* chnaged any to specific types

* error in console fix

* icons update

* fixed test case

* test case fix

* non empty check for functions

* evaluate test case fix

* added new icons

* text change

* updated time for debounce for trial

* after release mereg

* changed icon

* after merge

* PR comments simple

* fixed PR comments - redux form, settings remove

* js object interface changes

* name refactor

* export default change

* delete resolve actions chnage

* after merge

* adding execute fn as 3rd option and removed create new js function

* issue 7054 fixed - app crash

* execute function on response tab changes

* refactor function name part 1

* refactor of js function name

* try catch added refactor

* test fix

* not used line removed

* test cases locator fixed

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-09-08 23:02:22 +05:30
akash-codemonk
30899cbb4a
fix: Undoing delete widget does not restore the errors in the debugger (#7232) 2021-09-08 16:13:44 +05:30
arslanhaiderbuttar
603e282529
test: Select UI test cases (#6328)
* Select/MultiSelect widget UI test cases

* Select/MultiSelect Test Cases

Dropdown-AlertModal
Dropdown-FromModal
Dropdown-Call-Api
Dropdown-Call-Query
Toggle JS - Dropdown-Call-Query
Toggle JS - Dropdown-CallAnApi Validation
Verify Search box for selecting drop-down options
Verify Dropdown default value
Dropdown Icon Visibility
Explore Widget related documents
Dropdown Close
On Option Change Action
Copy paste dropdown
Dropdown-Delete
Toggle JS - Dropdown-Unckeck Visible field
Toggle JS - Dropdown-ckeck Visible field

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* Added go to edit page from published page

* Removed the multiselect test cases from dropdown

* Select ui test cases fixes

* Select UI test fixes
2021-09-07 13:41:36 +00:00
arslanhaiderbuttar
c5503ee9e8
List widget UI test cases (#5535)
* List Widget UI Test Cases

List Widget UI Test Cases:

Change the List Widget Name
Add or Modify items
Change the Background Color
Change the Item Background Color
Enable Disable Visible
Enable Disable Visible - JS
Adding Query/API
Copy Widget
Delete Widget
Change the list and item background color using JS Button

* Update List_spec.js
2021-09-07 12:48:38 +00:00
akash-codemonk
f4adea8371
feat: Show contextual search menu for debugger errors (#7078) 2021-09-07 14:45:11 +05:30
albinAppsmith
3d85575979
style: Removed dark/light. theme switcher and made light theme default (#6979)
* Removed Theme switcher

* Changed default theme to light

* Auth screen dark theme changes

* auth screen ui ix

* Theme change Ui test removed

* bug fix
2021-09-06 14:37:52 +05:30
Tolulope Adetula
db88ef86f4
fix: underline style for text (#6865)
* fix: underline style for text

* fix: add expected structure example

* Revert "fix: add expected structure example"

This reverts commit efd56886a26f87bb18cf6edc53bd246bfeb8e0f1.

* fix: test failing

* fix: widget crashing (#6980)

* fix: update omnibar search string for documentation for actions (#6722)

* [Mongo] Added default values for query for Find, Count and Distinct commands (#6960)

* Added smart defaults for query in Count, Distinct & Find commands

* Added test cases for smart inputs for query and limit for find, and query for count and distinct

* Distinct command output now results a JSON object instead of an array of strings (#6964)

* Fix: Break word when text widget content is long (#6211)

fixes #5319

* fix: widget crashing

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>
2021-09-06 00:06:15 -07:00
Tolulope Adetula
742f0cf1ec
feat: compact mode in property pane (#6637)
* fix: compact mode

* fix: test

* fix: remove row height visibility

* fix: options label for compactMode

* feat: Add test

* Fix: failing test

* fix: test

* fix: test case.

* fix failing test

* fix: move position of rowHeight prop in property pane
2021-09-06 00:05:51 -07:00
Bhavin K
3d967e2df3
feat: statbox widget (#6556)
Introducing a new widget: Statbox / Statistic box Widget; This is a composite widget which has text and icon in a certain layout that can be easily changed.
2021-09-03 15:45:04 +05:30
Rishabh Saxena
3859cb8438
fix: listen to page id url param at the parent editor component (#7009) 2021-09-03 13:39:39 +05:30
Tolulope Adetula
45fad5e094
Feat: Table Widget: icon button as a new column type (#6598)
* feat: add icon button properties to property pane
* feat: add icon button styles to property pane
2021-09-01 15:20:23 +05:30
arunvjn
277cb7fcca
fix: Ghseets scroll bug(#6634) 2021-09-01 14:41:51 +05:30
NandanAnantharamu
49b3a78a0a
test: Custom chart spec (#6939)
* test : Custom chart spec

* updated title
2021-08-31 11:21:09 +05:30
Vicky Bansal
dbc3ca6bdf
feat: Table widget - Configure table data rows count (#5552)
Introduced a new field called as total record count which can be used to disable the pagination controls while having server side pagination. If this value is undefined the conditions will be ignored. The total record count is `total count / page size`, all the parameters need to be bound to the query/API for the functionality to work properly
2021-08-30 14:54:59 +05:30
yatinappsmith
b8d9e68106
test: Added stub tests for MySQL, MsSQL, ArangoDB and Redshift (#6868)
* Added stub testcases for MySQL, MsSQL, ArangoDB and Redshift

* Removed intercept for saveDatasource
2021-08-27 17:24:03 +05:30
Hetu Nandu
3380227cbb
feat: Enable Promises in Appsmith (#6253) 2021-08-27 14:55:28 +05:30
arslanhaiderbuttar
c90d844b63
test: Form widget UI test (#6884)
* Form widget test cases

* Form widget Test Cases

- Form widget fixes

* Form widget Test Cases

Defult Form text,  Reset and Close button Validation
Add Multiple widgets in Form
Form_Widget Minimize and maximize General Validation
Rename Form widget from Entity Explorer
Toggle JS - Form-Unckeck Visible field Validationpassed
Toggle JS - Form-Check Visible field Validationpassed
Copy Paste Validation
Form Delete Validation

* Form_test_cases_Fix

* Form test cases fix
2021-08-26 20:24:37 +05:00
Vicky Bansal
2f45db2008
Input widget: New data type supported - Phone number with ISD codes (#5256) 2021-08-26 16:22:45 +05:30
NandanAnantharamu
530735e13f
test: CypressNewVersion (#6116)
* Upgrade Cypress Version

* Upgrade to 7.6

* update moment library with Dayjs

* updated a test

* Added tests for copy to clipboard

* Added a missing dsl
2021-08-25 19:31:04 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
arslanhaiderbuttar
8380299958
fix: chart widget fix (#6867)
Custom fusion chart was loading with some delay and cypress test cases were getting previous element to verify the x axis data. Added one more check to wait till the chart data is loaded before verifying.
2021-08-25 15:42:41 +05:00
akash-codemonk
95c60bafeb
fix: Hide debugger errors until onPageLoadActions are run (#6786) 2021-08-25 10:04:42 +05:30
Paul Li
cb4242e7e5
Feat: Style customisation in the button widget (#6052)
Added multiple style props to the button widget:
- Button styles
- The background colour can change with a hex code
- elevation (box-shadow & colour)
- There are button variant contained (solid button), outlined (only borders), text (text buttons)
- Button can have an end icon or start icon
2021-08-24 19:23:15 +05:30
yatinappsmith
aa869f21ab
test: Added Support for MySQL (#6795)
* Added Support for MySQL

* Update setup-test.sh

fixed sql file

* Update setup-test.sh

Fixed path
2021-08-24 14:16:52 +05:30
Ashok Kumar M
971cc35e7f
[Feature] Click on widget will no longer open property pane (#6219)
* [Feature] Click on widget will no longer open property pane

* fixing test cases

* coverage fixes

* fixing imports.

* fixing build failure.

* fixing new specs

* clear property pane state for any new selection.
2021-08-23 19:42:17 +05:30
Pranav Kanade
6782bf6b85
fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) 2021-08-23 14:46:25 +05:30
NandanAnantharamu
0e5816d413
Fix/chart spec (#6774)
* updated Chart spec with a wait for route

* updated Chart spec with a wait for route
2021-08-23 14:02:53 +05:30
akash-codemonk
a42938c139
Expand all debugger errors by default (#6676) 2021-08-23 11:57:23 +05:30
arslanhaiderbuttar
01e5d8d839
Table UI test cases (#5910)
* TableUITestCases

Commit

* Table-widget-testcases

On Search Text Change Action
Default array data
On Row Selected Action
Explore Widget related documents Verification
On Page Change Action
Default search text
Default selected row
Delete Table Widget
Changing Column data type to "Image"
Changing Column data type to "URL"
Table Widget Functionality To Verify Row Height Functionality
Drage and Drop Table widget and verify default data
Table Widget Functionality To Filter The Data using 'Empty
Table Widget Functionality To Filter The Data using 'Not Empty'

* Discarded changes in cypress.json

Discarded changes in cypress.json

* Updated the test cases

* Undo changes to Cypress.json

Undo changes to Cypress.json

* Added new dsl json file

* Merge branch 'release' into SelectUITestCases

* table test cases fix

Co-authored-by: arslan <>
2021-08-21 12:34:23 +05:00
Rishabh Rathod
12e7ee0c94
Add s3 support for generate CRUD (#6264)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Add useS3BucketList hook WIP

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Add Query to get all S3 buckets

* Fix dropdown open issue

* Remove defaultIsOpen prop from dropdown

* Resolve comments
- Remove debugger
- mockSheetUrl -> getSheetUrl

* Add S3 cypress test

* Fix cypress test yml config

* Fix generate page cypress test
2021-08-20 12:27:01 +05:30
Anagh Hegde
e76d8c2c15
Change the name of the mock datasource (#6498)
* Change the name of the mock datasource

* Remove the hardcoded value for Cloud services

* Handle index out of exception

* Add check if the response contains necessary credentials for mockdb

* Change as per review comments

* Fix cypress test failures

* minor changes to fix cypress test for mock data according to new changes

* updated mock data locator

* Update the mockdata source name

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-19 17:53:30 +05:30
Bhavin K
3741bc160e
Added series title (internal property) to the chart widget selectedDataPoint (#6104) 2021-08-18 12:41:07 +05:30
Bhavin K
3270d6c7ba
Input widget enhancements (#5670)
Many new input widget enhancement added. The widget now has the capability to have its own label and tooltip as helper. The user can now add Icons inside the input widget and align them as well, The user can allow choose the max allowed length of the input. We have also added the isValid property in tandem to the regex property for additional validations using JS expressions
2021-08-17 16:38:04 +05:30
Paul Li
532e8f2a74
Feature : Checkbox Group widget (#6199)
Introducing a new widget: `Checkbox Group`, Users can now create a group of checkboxes and have an action trigger and also be able to refer the selected values from the internal API.
2021-08-17 14:41:38 +05:30
Favour Ohanekwu
f0c7ce0e89
Feature/option to upload file or text in multipart form (#6534)
* added option to multipart form data for file or text upload

* updated styles for the dynamic-text-field-with-dropdown styled component

* added cypress tests for multipart body type

* code refactor: moved constants to ApiEditorConstants.ts

* updated multipart dropdown styles

* minor bug fix
2021-08-16 13:00:11 +01:00
Favour Ohanekwu
30c11e4a74
fix cypress mockdatasource flaky test (#6624) 2021-08-16 12:24:17 +01:00
Favour Ohanekwu
11385092ca
Hotfix/trailing white spaces in mysql datasource configuration (#6227)
* trimmed white spaces in datasource configuration

* Added cypress tests for MySQLdatasource

* fixed trailing whitespaces bug in mysql datasource configuration

* Fix overflowing text in toasts on safari (#6200)

* [Feature] Generate template page from datasource  (#5513)

- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Fix xss redirectURL (#6229)

* Update msg

* Revert "Update msg"

This reverts commit 0ac70ea7e9.

* Fix JS error message showing callstack in firefox (#6234)

* Adding expiry of 30 days to session cookies (#6224)

Fixes #5872

Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed.

* Removing release-drafter github action (#6248)

* Add Skip tour button in welcome onboarding (#6158)

This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.

* Fix - #6221 new nav analytics improvements (#6223)

* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards

* Add missed new nav analytics for connections (#6233)

* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks

* [Fix] Small UI improvements to suggested widgets section (#6190)

* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment

* Fix NPE when Segment key not available correctly (#6244)

* Using local Postgres database instead of remote (#6241)

* Using local Postgres database instead of remote

* Added createdb and usedb at the top

* FEATURE-5852 : make the iframe widget message property accessible (#5897)

-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.

* Disable tern in view mode (#6203)

* Fixed ExecutionParams (#6284)

* Fix test by mocking the response (#6273)

* added cypress tests for users mock datasource

* Fix: Mark comment threads as viewed when they are resolved (#6251)

* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type

* Add analytics event for mock-data creation (#6136)

* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Missing validations (#6281)

* Fix validations for certain scenarios which were missed earlier

* Minor comments feature fixes (#6245)

* Fix comment card click: set visible thread (#6166)

* Fixing bug where the comment feature flag was disabled for all users

* [Fix] Refresh sidebar comments list when a thread is unresolved (#6326)

* fix stop Rich text Editor from crashing on Modal (#6077)

* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Sentry typeError fix, with checks (#6256)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Supporting all ASCII characters in table widget (#6041)

* Updated labels Mock data to Sample data (#6330)

* [perf] propertyControl re-rendering (#5941)

* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Snowflake get structure error resolved for columns query (#6316)

* Table name reference copied from templates body to avoid misconfiguration in action body

* more conditions for run check (#6255)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Fix comment card click at the view mode (#6332)

* Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)

* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>

* Multiselect Widget (#5228)

We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.

* Added instance Id in analytics datapoint (#6252)

* Enable Autocomplete for Static Objects (#6302)

* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action

* updated cypress tests to account for testing trailing spaces in db name and host address

* removed unparsed token

* Commenting test (#6354)

* Add list buckets API to S3 (#6334)

* Add list buckets action method to S3

* Added TC for list bucket method

* FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)

 reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished

* Added null check to verify empty layout in generate CRUD page flow (#6359)

* Fix authentication issue while creating mockdata (#6294)

* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password

* updated cypress tests for mock datasource

* fixed cypress failing datasources tests

* Fix: Update debugger placeholder text for non-mac (#6142)

* Added logic to show form data requests in debugger (#6350)

* Added logic to show form data requests in debugger

* Tests and comments

* Tests

* Tern server performance fix and Best match fix (#6338)

* Uncomment Gen CRUD page Test (#6371)

* Reorganised test steps to utilise retry action (#6208)

* updated spec with assertion values (#6323)

* updated spec with assert

* updated test

* updated test

* updated dsl

* Improvement: Add limit on password length in user signup (#6312)

* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login

* Fix binding query for the nested data responses (#6372)

* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications

* Fix: Keep inspect entity in sync with the widget selection in the entity explorer

* docs: Updates event archive

* Navigation Dropdown feedback Changes (#6119)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Feature: Add API to set and get concurrent app editors (#6292)

* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts

* close modal on cancel btn click (#6383)

The cancel button in the modal will now by default have the close action configured.

* Button and chart fixes (#6373)

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* changed border radius of multiselect widget to 0px (#6349)

* open link inside text component in a new tab (#6205)

* Fix loading test data for Cypress tests in CodeBuild

* Change dropdown widget to select widget in Github labels for automation to work properly (#6386)

* Updating k8s README to point to docs.appsmith.com

* iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)

* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component

* BUG : Iframe widget: wrong placeholder `Title` (#6053)

Rectified the wrong placeholder in the iframe widget title property.

* Use feature flag api to enable/disable comments (#6322)

* Check if comments are enabled for comment intro modal (#6395)

* Fix ts error release (#6396)

* updated common method (#6397)

* Fix #5740 - Api actions are treated as queries (#6381)

* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages

* fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403)

* Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360)

* Icon Button Widget (#5723)

Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.

* [Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407)

* fix: Font size fixed for consistency between select and multi-select widget (#6400)

* Skip btn comment onboarding (#6331)

* [Fix] Reset comment mode hotkey (#6401)

* Welcome tour GIF and Close button fixes (#6309)

* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants

* Fix: Set a default option in select widget while adding from suggested widgets (#6236)

* Fix jest test for comments by overriding isCommentMode selector (#6027)

* Fix download with URL issue  (#6179)

* Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)

Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update CRUD template For S3 page (#6426)

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>

* Cypress tests for commenting feature (#5505)

* Minor fixes for comments on the modal widget (#6368)

* Update permission check for determining a user with dev access for comments intro (#6431)

* Prevent Entire Editor Header from re rendering (#6415)

* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* [Fix] Focus the comment thread when opened after dismissing (#6437)

* Dont fetch feature flags if not logged in (#6444)

* Update README.md

Fixed a spelling mistake

* Fix: Parse api body to be shown as an object in debugger if possible (#6249)

* Fix: List Widget issues (#6226)

* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>

* [Bugfix] Empty object creation in published pages for application object fixed

* Omnibar redesign (#6288)

Omni bar would now have the categories navigation and documentation.

* [skip_changelog] Form login disabled after user uses OAuth login method (#6425)

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* changed default image to old value loading from cloudinary (#6467)

* Feature: Show a list of realtime app editors (#6286)

* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list

* Enable auto-start after VM restart (#6428)

* BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)

-- Add a overlaid div for iframe

* Added fix for cmd + enter not running google sheets actions (#6446)

* Fix-Catch invalid google recaptcha v3 key error (#6034)

* Handle invalid google recaptcha v3 key

* changed default divider color to light grey (#6335)

* fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380)

* Add null check for the nested data structure (#6479)

* Add null check for the nested data structure

* Add unit test for the null nested data

* Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)

* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup

* [Fix] Minor comments feature fixes (#6490)

* Fix skip btn

* update sorting for mentions list

* Show server logs when create cypress user fails

* [Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477)

* Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)

This reverts commit 3ae1bd6d95.

* Updated flaky test (#6486)

* Updated flaky test

* updated another test

* Store MongoDB creds in separate file from install.sh (#6499)

* Store MongoDB creds in separate file from install.sh

* Move MongoDB credentials to docker.env

* Add Analytics to Generate CRUD template feat (#6503)

* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics

* Fix: Adding checks before we check for disallowCopy (#6214)

* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.

* Hotfix Table Widget crashes when there is a cyclical dependency (#6505)

* FIX #5254 : dropdown height fixed and made scrollable (#6170)

* will widget pane if user moves away from canvas (#6516)

* Fix: intercom triggers are not working properly (#6512)

* initializing the intercom as soon as the help components are mounted.

* removed log

* Fix: Undo-Delete of Containers fix (#6510)

* Encrypt attributes (#6508)

* encrypt attributes

* updated references to DOM targets for accessing the Mock User datasource

* Fix/omnibar landing bug (#6513)

* hide certificate string using dots on UI (#6533)

* replace actual certificate string with '*' like it is done for hiding password on the UI.

* Updated Template

* fixed failing cypress tests

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Confidence Okoghenun <cokoghenun@gmail.com>
Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com>
Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: abhishek nayak <nayak.abhishek@gmail.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Nipun Agarwal <31271538+nipun1999@users.noreply.github.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2021-08-13 09:42:29 +01:00
arslanhaiderbuttar
273b2d902f
Update Button_spec.js (#6474)
* Update Button_spec.js

Button widget issue has been fixed.

* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. (#5389)
* dip

* dip

* scroll

* fixes

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* solve for canvas glitches

* dip

* dip

* dip

* adjust scroll speed

* dip

* dip(code clean up)

* dip

* dip

* ---dip

* dip

* dip

* dip

* middle ware for dropping multiple widgets.

* adding scroll to drag for canvas selection.

* fixing drag disabled and modal widget(detach from layout) drops

* firefox and safari fixes

* rebase conflicts.

* fixing broken specs.

* fixing specs and adding jest tests.

* show border and disable resize when multiple widgets are selected.

* selection box grab cursor

* merge conflicts.

* code clean up

* fixing specs.

* fixed a bug and failed specs.

* fixing rerenders.

* code clean up

* code review comments

* always have the drag point inside the widget.

* fetching snap spaces instead of calculating.

* remove widget_move action

* fixing bugs with add widget parent height updation.

* fixing specs.

* List widget conflict fixes.

* fixing canvas drop persistence.

* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
3a41ab1f17
Added test for Navigate To feature (#6531)
* Added test for Navigate To feature

* updated test title
2021-08-12 11:01:20 +05:30
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) 2021-08-10 12:21:46 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
NandanAnantharamu
f5dd307357
updated spec with assertion values (#6323)
* updated spec with assert

* updated test

* updated test

* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action (#6208) 2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test (#6371) 2021-08-04 11:05:16 +05:30
NandanAnantharamu
cd72098b0d
Commenting test (#6354) 2021-08-03 16:19:45 +05:30