769 Commits

Author	SHA1	Message	Date
Sagar Khalasi	c0f7fa7baf	chore: Updated another set of third party urls (#36571) ... ## Description Updated third party URLs. Fixes `[Issue URL](https://github.com/appsmithorg/appsmith/issues/36437)` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11174864458> > Commit: c6432d4363f80513aae2d55310e5905dc83d0acc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11174864458&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 04 Oct 2024 07:58:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Enhanced fetch tests to ensure proper handling of requests and responses. - Corrected expected outputs for URL and date formats in the Table Widget tests. - Simplified validation logic for unsupported file types in the Document Viewer tests. - **Chores** - Modified test cases to utilize local mock APIs for enhanced testing reliability. - Updated image URLs in fixture data to reflect new local sources. - Adjusted default images for widgets to ensure consistent visual representation. - Improved interactivity in modal widget tests with updated actions and dynamic data binding. - Updated limited tests to focus on server-side JavaScript function execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-04 15:06:56 +05:30
Sagar Khalasi	cf0bfa510a	fix: Fix shareapp case due to load issue (#36627) ... ## Description Fixes #`36626` Issue: Script was clicking on share button without full page load. Solution: Waited for page load with api. EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5285 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11174778224> > Commit: 80be7e10eac4227b33702435f679e21173f12ef8 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11174778224&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 04 Oct 2024 07:01:59 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced test coverage for workspace sharing and public access functionalities. - Added assertions to validate visibility of the Git sync bottom bar during application editing. - **Bug Fixes** - Updated specification for limited tests to point to the correct test file, ensuring accurate execution of tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-04 13:19:16 +05:30
Sagar Khalasi	177636d43a	chore: Updated doc urls (#36634) ... ## Description Updated third party URLs. Fixes #`36437` ## Automation /ok-to-test tags="@tag.DocumentViewer" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11125143689> > Commit: 7d19fcce57eb2183d6e261feaa772d20d6fafa10 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11125143689&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.DocumentViewer` > Spec: > <hr>Tue, 01 Oct 2024 12:45:03 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated document link URLs for testing to ensure accurate functionality in the DocumentViewer widget. - **Tests** - Maintained and validated tests for various document types, ensuring correct rendering and handling of different file formats. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-03 11:51:25 +05:30
albinAppsmith	4f501419cd	fix: Revert "feat: allow multiple lines in alert component" (#36643) ... Reverts appsmithorg/appsmith#36629 Reverts appsmithorg/appsmith#36126 Reverting this PR since it is causing multiple issues in toast and we are reverting the original PR caused this issue. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11138591480> > Commit: 598a1d3c6e94fc817c1bc75293b60936a422f77c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11138591480&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 02 Oct 2024 07:27:39 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new styled button component for enhanced toast notifications. - Updated toast styling with customizable properties for better visual presentation. - **Bug Fixes** - Simplified toast body structure by removing unnecessary components, ensuring content displays correctly. - **Chores** - Removed outdated end-to-end test file for button widget alert functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-02 12:58:16 +05:30
NandanAnantharamu	241dfa8f33	test: replaced 3rd party apit in treeSelect (#36598) ... Replaced 3rd Party API with TED /ok-to-test tags="@tag.Select" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11102740010> > Commit: 692dd2810fb4520bac6fe8aec3658a0cb70525ba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11102740010&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Select` > Spec: > <hr>Mon, 30 Sep 2024 09:21:05 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-10-01 16:05:40 +05:30
Rudraprasad Das	dc2ab49963	fix: updating migration repo for DSCrudAndBindings spec (#36452) ... ## Description Updates name of the migration repo in the following specs to the new name in TED ``` cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts ``` ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11100011900> > Commit: 7eedfb48b9182ffe226eea2da00c5af55d32b861 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11100011900&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 30 Sep 2024 06:03:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Updated repository names in test specifications to ensure accurate references during application validation and Git Autocommit tests. - Added a new migration tag to categorize tests under the migration context. - Modified the list of limited tests to include new test files for Git-related functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-30 18:36:51 +08:00
saiprabhu-dandanayak	a6c109b3ba	feat: allow multiple lines in alert component (#36126) ... ### Description ### Fixes : [#30851](https://github.com/appsmithorg/appsmith/issues/30851) I have raised this pr in-order to allow multiple lines in alert message ### Screenshots ### passing `\n` in the message  ### unable to parse `\n`  ### After issue is resolved  ### Cypress Testing video https://github.com/user-attachments/assets/ec826cef-664f-4392-b81e-9974178e65ec <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new styled component `StyledPre` for enhanced formatting in toast notifications. - Enhanced the Toast component to better render content, improving readability by preserving whitespace and formatting. - Added automated tests for the button widget's alert functionality, ensuring correct display of messages with newline characters. - **Bug Fixes** - Improved the display of alert messages in toast notifications, ensuring they respect original formatting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-30 11:15:51 +01:00
Jacques Ikot	6f27959bce	fix: Invalid Date Display in Table Widget's Date Column When Using Unix Timestamp (ms) (#36455) ... ## Description **Problem** When populating a table widget with data that includes dates in Unix timestamp (milliseconds) format, setting the column type to "Date," the input format to "Unix timestamp (ms)," and selecting a display format leads to an issue during inline editing. While the date picker behaves correctly, selecting a new date results in the table cell showing an "Invalid Date" error. **Root Cause** The platform currently uses DateInputFormat.MILLISECONDS for Unix timestamp (ms) formatting. However, this value is not a valid option for the moment.format() function, which expects the input format to be 'x' for Unix timestamps in milliseconds. This mismatch leads to the "Invalid Date" error. **Solution** Modify the logic to map DateInputFormat.MILLISECONDS to the correct moment format string 'x'. Adjust the table's transformDataPureFn to correctly process and display dates in Unix timestamp (ms) format after inline edits, ensuring the moment library can handle the input properly. **Outcome** This fix ensures that when a user selects a date via the date picker in inline editing mode, the selected date is displayed correctly in the table without any errors. Fixes #35631, #25081 ## Automation /ok-to-test tags="@tag.Sanity, @tag.Binding, @tag.Table, @tag.Datepicker" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11101758400> > Commit: 6a3cae774f3824bd2ee126b501bfa4b6d71ae0c8 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11101758400&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Binding, @tag.Table, @tag.Datepicker` > Spec: > <hr>Mon, 30 Sep 2024 08:54:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced date column editing in table widgets to accept Unix timestamps in milliseconds without errors. - Introduced a new enumeration for improved date formatting options. - Added mock data structures for testing various date formats and transformations in the table widget. - New method for generating formatted date strings for tomorrow in both verbose and ISO formats. - **Bug Fixes** - Improved validation logic for date inputs in the table, ensuring proper handling of different date formats. - **Tests** - Added new test cases to validate date handling and input formats in the table widget. - Introduced a new test suite for transforming table data based on specified column metadata. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-30 10:02:42 +01:00
Rudraprasad Das	b1ed82dbcf	fix: fixed autocommit spec for airgap (#36579) ... ## Description Changes autocommit test repo to a new airgap compatiable repo ## Automation ``` /test cypress/e2e/Regression/ClientSide/Git/GitAutocommit_spec.ts ``` ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11065723641> > Commit: ed27652b4fe386f943a937e0e7efdc059700d779 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11065723641&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` > Spec: cypress/e2e/Regression/ClientSide/Git/GitAutocommit_spec.ts > <hr>Fri, 27 Sep 2024 06:55:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Updated the repository name in the autocommit tests to better reflect current context. - Revised test suite tags for improved organization and focus. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-27 18:07:57 +08:00
NandanAnantharamu	cc9673757b	test: udpated 3rd party api for Commandclick nav spec (#36545) ... replace 3rd API with TED /ok-to-test tags="@tag.IDE" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the test suite to focus on command click navigation within the IDE. - **Bug Fixes** - Adjusted the base URL for the data source in the navigation test to reflect local development settings. - **Chores** - Modified the limited tests execution list to prioritize IDE command click navigation tests over template-related tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11046090068> > Commit: fd95c8bc6a69ad009ddc8377a1a3c2b20c7be033 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11046090068&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Thu, 26 Sep 2024 05:55:50 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-09-26 12:09:17 +05:30
Sagar Khalasi	73169d13b0	chore: Replacing ted api call for resources (#36472) ... ## Description Remove third party url. Fixes `https://github.com/appsmithorg/appsmith/issues/36535` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11031926377> > Commit: bf5f2950598b16f4eadda81c1076d0c504e90be1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11031926377&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 25 Sep 2024 12:37:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Updated various image and URL references in test configurations to point to local resources instead of external links, improving consistency and performance during testing. - **Bug Fixes** - Corrected image source URLs in multiple test files to ensure proper loading of images in the application. - **Chores** - Replaced outdated URLs with local Docker host URLs across numerous test files and configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-25 19:41:00 +05:30
Manish Kumar	842443c267	chore: making autocommit GA (#36347) ... ## Description - Removal of release_git_autocommit_feature_enabled flag - Removal of fallback implementation to classes which was autocommit flag annotated - Removal of irrelevant test cases post removal of fallback implementation. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10994151881> > Commit: 42b43f19e4b47d70f8c9784ae1c4c67601d79412 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10994151881&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 23 Sep 2024 12:53:01 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced file operations for resource management in Git, including methods for saving, deleting, and reading resources. - Streamlined handling of auto-commit functionalities, making certain features universally accessible. - **Bug Fixes** - Removed outdated fallback implementations for auto-commit eligibility and Git auto-commit helpers. - **Refactor** - Simplified constructors and dependencies in file operation classes, improving maintainability. - Eliminated feature flag dependencies from various components, including tests, focusing on core functionality. - **Tests** - Removed tests related to feature flags, streamlining the testing process for auto-commit and migration functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: brayn003 <rudra@appsmith.com>	2024-09-25 14:32:01 +05:30
NandanAnantharamu	20fa8de803	test: fix test in airgap for canvas context prop (#36519) ... This test spec was working fine on EE/CE this fix will handle scenario in airgap environment /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11026655789> > Commit: f120b71d43a06123060ccfc3fcc0b3feb7b72d71 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11026655789&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 25 Sep 2024 05:41:09 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-09-25 12:26:59 +05:30
Jacques Ikot	8fe96c9c20	fix: isRequired validation property for table select column (#36375) ... ## Description **Problem** The select column of the table widget does not have a validation property within its property pane to allow users add an isRequired validation to the table select column. **Solution** Added a Validation section to the table select column's property pane, which includes an isRequired toggle. When enabled, this feature will trigger a visual indication (error border colour) around the select widget if a required field is left unselected during "Add new row" or inline editing. Fixes #30091 ## Automation /ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity, @tag.Select" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10957896180> > Commit: d2597e6a26938f2b99f2f997fca7bc110e5c2091 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10957896180&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity, @tag.Select` > Spec: > <hr>Fri, 20 Sep 2024 12:23:29 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced end-to-end tests for Select column validation in Table widgets. - Enhanced validation logic to support Select column types in the Table widget. - Added visual feedback for required Select fields during row addition and inline editing. - Improved locator for single-select widget button control to enhance UI interaction. - **Bug Fixes** - Improved error handling and visual representation for invalid editable Select cells. - **Documentation** - Updated validation configuration to include Select column types for better usability. - **Refactor** - Enhanced code clarity for styled components related to Select fields. - Modified method to improve versatility in handling table interactions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Sai Charan <saicharan.chetpelly@zemosolabs.com> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-23 08:44:46 +01:00
Sagar Khalasi	1cf043c40a	fix: Inline editing flaky test fix (#36366) ... ## Description EE PR: [Appsmith EE Pull Request #5158](https://github.com/appsmithorg/appsmith-ee/pull/5158) Root Cause Analysis (RCA): The `updateCodeInput` function was identified as a source of flakiness due to improper execution. Additionally, the `SaveLocalStorageCache` caused issues by retaining the reset button after the 6th test case, resulting in a duplicate button in the 7th test case, which led to test failures. Solution: Replaced `updateCodeInput` with `EnterJSContext` from `agHelper` for more reliable execution. For the second flaky step, a new page was created, and a table with relevant data was added. This resolved the issue without requiring significant changes to the test case or workflow. Fixes #`36365` ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10940196158> > Commit: 32d1be4c3dfe54bf8a0f8e9f54b20d2845c86407 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10940196158&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Thu, 19 Sep 2024 12:01:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the inline editing test suite for the table widget to improve state management between tests. - **New Features** - Updated the limited tests to focus on inline editing functionality, enhancing testing priorities for the Table V2 widget. - Introduced new properties in the widget locators to enhance UI interactions, including selectors for various controls and elements within the property pane and cell editing functionalities. - Added a new JavaScript toggle selector to facilitate interactions in tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-20 12:44:14 +05:30
Rahul Barwal	6507f90e05	fix: Incorrect updation of selctedRowIndex when primary column is set. (#36393) ... ## Description <ins> Problem statement </ins> 1. Table should have a primary column set. 2. The table should be filtered(via search or client side filters) 3. there should be a selectedRow in table a. One way to ensure is add a text widget and bind it to table's `selectedRowIndex` property. If you now run a query that updates the data behind the table: the `selectedRow` is updated to (seemingly) random row and selectedRowIndex is updated as well <ins> Rootcause </ins> We have a mechanism of preserving `selectedRow` when data updates happen. Underlying logic gets the previous selected row and tries to find it in the new data using the primary key. * If it finds it, it updates the selectedRowIndex to the `__original_index__` of the found row i.e. its position in the original data before any filters were applied. <ins> Solution </ins> We update the selectedRowIndex to the index in the new filtered data. <ins> How to test </ins> 1. Create a table with a primary key 2. Add a text widget and bind it to table's `selectedRowIndex` property 3. Filter the table 4. Click on a row to select it 5. Run a query that updates the data behind the table 6. Assert that the selected row is the same and that the selectedRowIndex is updated to the new index Fixes #36080 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10953679202> > Commit: 1a2d64467e453229940b67b29da1ce9d0e9ac24d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10953679202&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Fri, 20 Sep 2024 06:30:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Improvements** - Enhanced the efficiency of the TableWidgetV2 by streamlining the method for retrieving the index of selected rows. - Improved code readability and maintainability without altering the overall functionality. - **New Features** - Introduced new test cases to validate filtering and searching functionalities within the Table Widget V2. - Added a JSON configuration for a data-driven table interface, supporting sorting, filtering, and dynamic data binding. - Introduced fixture data for testing, allowing for comprehensive validation of table behavior under various conditions. - Added a JavaScript object containing employee data to facilitate filtering and display in the table. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-20 12:25:23 +05:30
Sagar Khalasi	9e7fa1d725	chore: Added sanity and tags for blank tag specs (#36421) ... ## Description Added relevant tags with sanity tags. Fixes `https://github.com/appsmithorg/appsmith/issues/36415` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10938122144> > Commit: 8383cf735da821760853af77f232b5c992904a19 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938122144&attempt=4" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 19 Sep 2024 11:41:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced test suites with additional `@tag.Sanity` tags for improved categorization and organization. - **Bug Fixes** - Updated various test suite tags to include `@tag.Sanity`, ensuring comprehensive coverage of functionalities. - **Documentation** - Improved tagging structure across multiple test suites for better clarity and maintainability. - **Chores** - General modifications to existing test suite descriptors to include new tags without altering core functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-19 18:21:58 +05:30
Valera Melnikov	bb0ec5ce9d	fix: disable anvil snapshots tests (#36422) ... ## Description Disable all Anvil snapshot tests. The tests will be enabled after solving the #36419. Related thread https://theappsmith.slack.com/archives/C025SE88KNE/p1726721979435589 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10938186194> > Commit: ee5c8f40eb3873bd9db8d9b7ca4c3519d989a038 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938186194&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 19 Sep 2024 11:14:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Temporarily skipped multiple test suites for various Anvil widgets due to unresolved issues, preventing potential false negatives in testing. - Specific tests affected include those for Modal sizes, App Theming, Button, Checkbox, Currency Input, Heading, Icon Button, Inline Button, Input, Paragraph, Phone Input, Radio Group, Stats, Switch Group, Switch, Table, Toolbar Button, and Zone Section Widgets. These adjustments ensure the integrity of the testing process while issues are being addressed. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-19 14:22:21 +03:00
NandanAnantharamu	006dbfd46a	test:Fix canvas context prop01 (#36391) ... EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159 RCA: The property section related validations were not working Solution: Enhanced verification of property pane section visibility using accessibility attributes. Introduced new UI interaction properties for managing collapsible sections. /ok-to-test tags="@tag.IDE" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10923368993> > Commit: c996a38fba4d94cf80baf574d6ad3db75b2bb8cf > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10923368993&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 18 Sep 2024 14:10:07 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved test logic for verifying the state of property pane sections, enhancing accessibility compliance. - Updated limited tests to include new test specifications for the property pane. - **Bug Fixes** - Enhanced robustness of tests by refining visibility state checks using ARIA attributes. - **Chores** - Expanded locator capabilities in the testing framework to support new UI components related to collapsible sections. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-09-19 11:39:44 +05:30
NandanAnantharamu	9f7e624b70	test: fix canvas context property pane (#36356) ... EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5161 RCA: The property section related validations were not working Solution: - Enhanced verification of property pane section visibility using accessibility attributes. - Introduced new UI interaction properties for managing collapsible sections. /ok-to-test tags="@tag.IDE" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10919160204> > Commit: 3d5c864891f027d03e5d50ddb15a185f980d83aa > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10919160204&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 18 Sep 2024 09:42:19 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-09-18 17:31:40 +05:30
Pawan Kumar	27aeb4dc18	chore: fix map chart spec (#36370) ... /ok-to-test tags="@tag.Maps" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10916335124> > Commit: 6e88177f19e0b2deff3eed2d2531a8f88ec06a68 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10916335124&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Maps` > Spec: > <hr>Wed, 18 Sep 2024 06:11:15 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-18 11:53:42 +05:30
albinAppsmith	66c815f1cb	feat: Migrate DBform to UQI config (#36168) ... ## Description This PR migrates the plugins which were old DBForm config to UQI config. Plugins that got affected, 1. Snowflake 2. ArangoDB 3. Oracle 4. PostgreSQL 5. MySQL 6. Elasticsearch 7. DynamoDB 8. Redis 9. MSSQL 10. Redshift Fixes #35496 Fixes #35497 Fixes #35500 Fixes #35487 Fixes #35490 Fixes #35491 Fixes #35499 Fixes #35501 Fixes #35502 Fixes #35506 Fixes #35890 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10897087023> > Commit: e8fe475a48aac1e2e1f3184181ae0bed154313ba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10897087023&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Tue, 17 Sep 2024 06:07:27 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced rendering logic in the Query Editor to support additional UI component types. - Improved handling of form evaluations and query configurations across various plugins, including ArangoDB, DynamoDB, Elasticsearch, and others. - Introduced structured layouts for editor configurations, enhancing clarity and usability in multiple database plugins. - **Bug Fixes** - Adjusted control flow in sagas to ensure proper handling of UI component types, improving user interactions. - **Chores** - Refined JSON configurations across multiple plugins for better organization and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-17 14:22:32 +05:30
NandanAnantharamu	5dfbe8cac7	test: fix DataSourceScheme (#36339) ... test: Fixing DataSourceScheme test EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5155 Improved reliability of data source schema tests by ensuring correct UI interactions and logical flow. Enhanced verification process by checking for the absence of loading spinners before data verification. **Bugs Raised as part of fixing the spec:** https://github.com/appsmithorg/appsmith/issues/36349 Test Skipped: https://github.com/appsmithorg/appsmith/issues/36348 /ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10885399399> > Commit: 12ca3b6b75d5bb135dd4859c45a90d6a9ead81eb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10885399399&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 16 Sep 2024 15:08:37 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Bug Fixes** - Skipped a test case for schema fetching due to a known bug, improving test reliability. - **New Features** - Enhanced search functionality within the datasource structure, ensuring previous inputs do not interfere with new searches. - Improved interaction with the schema tab in the user interface for better testing. - **Documentation** - Updated the path for limited tests to focus on the "Datasource Schema" functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-09-16 22:53:09 +05:30
Sagar Khalasi	996e26b537	fix: Fix datepicker issue with aghelper (#36325) ... ## Description **Root Cause Analysis (RCA):** In the local environment, the minDate field was consistently cleared as expected, but this behavior was not replicated in the CI pipeline. Updating the existing flow to address this issue could introduce other problems. The minDate text area having js date function in the CI pipeline, leading to repeated test failures. Multiple function attempts to resolve this issue were unsuccessful. **Solution**: I tried using the `agHelper` utility and updated the test flow with adding a new test case. EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5139 Fixes #`36329` ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10878662752> > Commit: 0985fc573bbbc678850985babcbc027897c9d59f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10878662752&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Mon, 16 Sep 2024 06:53:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced Datepicker widget functionality with new locators for improved user interaction. - **Bug Fixes** - Improved test cases for the Datepicker widget, ensuring accurate validation of display data and date formats. - **Documentation** - Updated test specifications to reflect a shift in focus towards the Datepicker widget. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-16 13:33:53 +05:30
Pawan Kumar	7e98542495	chore: remove filled icon style setting (#36300) ... Fixes #35175 /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10845022776> > Commit: 9224955b35c1083a6135afd956ba9026c91683c1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10845022776&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 13 Sep 2024 08:02:36 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Simplified theme management by removing icon style options from the user interface. - **Bug Fixes** - Enhanced clarity in theme handling by refining type usage in various components. - **Chores** - Removed deprecated icon style properties and constants to streamline code and improve maintainability. - Deleted a test case related to icon styles to focus testing efforts elsewhere. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-13 15:02:14 +05:30
Sagar Khalasi	6d64812d83	chore: exclude test for gitautocommit (#36307) ... ## Description Excluding test case Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10846188820> > Commit: 169260dd225113124f40f17898c59c5c0a770bba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10846188820&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Fri, 13 Sep 2024 09:22:22 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the "Git Autocommit" test suite to include a new tag for exclusion in airgap environments, enhancing test execution strategy for isolated systems. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-13 14:53:53 +05:30
Rahul Barwal	5996f74b73	test: fix failing table filter spec by rearranging steps. (#36303) ... ## Description In the spec, feature flag intercept is interfering with navigating back to editor flow. Since we need FF in the editor, this PR rearranges these steps. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/10845920958> > Commit: c7de064cd6c262f969270be226a135371985646e > Workflow: `PR Automation test suite` > Tags: `@tag.Table` > Spec: `` > <hr>Fri, 13 Sep 2024 08:40:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved test flow for the Table V2 component by repositioning navigation actions, enhancing clarity and context. - **Chores** - Updated the configuration for limited tests to focus on the Table V2 widget's filtering functionality instead of template-related tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-13 14:43:23 +05:30
Pawan Kumar	049a8a9c67	chore: remove typography selection in app theming (#36110) ... /ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced new hooks for icon management: `useIconDensity` and `useIconSizing`. - **Improvements** - Refactored hooks to enhance performance by using `useMemo` instead of state management, leading to more efficient calculations for icon size, density, spacing, and typography. - Streamlined theme management by consolidating logic and removing unnecessary properties, improving clarity and maintainability. - Optimized CSS class name management within the `useCssTokens` hook for better performance. - **Bug Fixes** - Removed `fontFamily` property from various components, which may affect text rendering but simplifies font management. - **Documentation** - Updated comments and documentation to reflect changes in typography and theme handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10786030048> > Commit: a0d12586c130252d4164305c5293c1b6fb67b5eb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10786030048&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 10 Sep 2024 06:00:30 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-13 11:19:26 +05:30
Valera Melnikov	7ba06c829d	chore: change snapshot package (#35867) ... /ok-to-test tags="@tag.All" ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10815637874> > Commit: 54937a7a64e755959e3420a0a20abcc30ee10d78 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10815637874&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Sep 2024 17:30:00 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added support for visual regression testing through new tagging in various test suites. - Integrated a new image snapshot plugin to enhance testing capabilities. - **Bug Fixes** - Removed outdated image snapshot assertions to streamline testing processes. - **Documentation** - Updated tags in multiple test suites to improve organization and clarity regarding visual testing. - **Chores** - Upgraded Node.js version in the Cypress Dockerfile for improved performance and compatibility. - Simplified Cypress plugin configuration by removing unnecessary functions and enhancing browser compatibility. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-12 11:09:42 +03:00
Jacques Ikot	8a9af791e4	feat: Allow table search to include label and value for tables with select column type (#36061)	2024-09-12 08:28:46 +01:00
Sagar Khalasi	1ccb023cf7	fix: Fixed Bug29566 spec with list widget (#36260) ... ## Description **Root Cause Analysis (RCA):** The test case in `BugTests/Bug29566_Spec.ts` has become flaky due to its dependency on a third-party API call `(https://api.jsonbin.io/v3/b/)`. As experienced automation engineers, we understand that relying on third-party services can introduce instability and lead to frequent test failures. In this particular case, the dependency was tightly coupled with the test logic, and updating the data was not a viable solution. **Solution:** Upon assessing the situation, I determined that refactoring the existing test would take significantly longer than rewriting it from scratch. Therefore, I chose the rewriting approach to prioritize time efficiency. The test flow has been updated while maintaining the same assertions for data validation. Additionally, I have incorporated an extra assertion to verify the data after a page reload to further enhance the robustness of the test. Fixes #`36259` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10816309843> > Commit: 2be906c50572425b31d84db8387e8e07b92314fb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10816309843&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 11 Sep 2024 17:34:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced testing for the list widget to ensure it populates correctly on page load, addressing Bug 29566. - Introduced dynamic data sourcing for more accurate test scenarios. - **Bug Fixes** - Updated test cases to reflect changes in functionality and validate correct data display. - **Documentation** - Renamed test case for clarity regarding the specific bug being addressed. - **Chores** - Updated the limited tests configuration to focus on the new bug test instead of a template test. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-12 09:38:46 +05:30
Pawan Kumar	b5f4c65719	chore: fix select1 spec (#36228) ... <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced test functionality by adding a check for page save errors in the "Select1" test, improving error handling before executing further actions. - **Chores** - Updated testing priorities by commenting out the "Fork Template" test and activating the "Select1" test in the limited tests configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD d248530e0b95d34947fef3ffc2ba08e71e81dad7 yet > <hr>Tue, 10 Sep 2024 11:37:57 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-11 11:28:44 +05:30
Sagar Khalasi	c44c35609c	fix: Fixed flaky fork template test case (#36200) ... ## Description Root Cause Analysis (RCA): The issue stemmed from the use of hardcoded templates in our tests, which introduced inherent flakiness. This approach caused intermittent failures, particularly when the hardcoded template was not available or had changed. Solution: I have resolved this by implementing dynamic locators that select the first available template during the test execution. This ensures greater stability and reduces flakiness. The only scenario where this approach could fail is if no templates are available, which would be a product-level blocker rather than a test issue. Fixes #`36199` ## Automation /ok-to-test tags="@tag.Templates" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10775279036> > Commit: be8fc879c21fa90b7083e52d4cde52439f8f5546 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10775279036&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Templates` > Spec: > <hr>Mon, 09 Sep 2024 14:51:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved reliability of the template forking test by updating element selectors and streamlining navigation steps. - Enhanced test coverage by adding a step for generating a page with data. - **Chores** - Renamed test specification file to better reflect its focus on application-level testing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-10 15:29:02 +05:30
Hetu Nandu	60dbda49e7	chore: Transitions for IDE (#35714) ... ## Description Uses `AnimatedGridLayout` component to introduce transitions for the IDE. This is behind a feature flag Fixes #34538 Fixes #30863 Fixes #34544 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10737363879> > Commit: a912f5c52366abe48768727a1c605cd72b48752c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10737363879&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ServerSide/OnLoadTests/ExecuteAction_Spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Fri, 06 Sep 2024 16:32:30 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced two new layout components: `AnimatedLayout` and `UnanimatedLayout` for improved editor interface structuring. - Added TypeScript type definitions for the DOM View Transitions API to enhance type safety and developer experience. - Implemented custom hooks, `useGridLayoutTemplate` and `useEditorStateLeftPaneWidth`, for dynamic grid management and left pane width calculation in the IDE layout. - **Improvements** - Enhanced layout responsiveness with the addition of dynamic grid management. - Updated the `Editor` component to use a centralized constant for height calculations, improving maintainability and consistency. - Enhanced test accuracy by refining assertions in the Git Branch Protection test suite. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Sagar Khalasi <sagar@appsmith.com>	2024-09-09 16:25:50 +05:30
Sagar Khalasi	188e9f0643	fix: Video2 spec flaky fix (#36166) ... ## Description RCA: We are using youtube url for `Verify Basic Functionality of Video Widget - muted`. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case. Solution: Deleted this test as it can be part of manual testing. Fixes #`36164` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10766784105> > Commit: 11d8d952f5e24cc49056532b15da190eefe8ba41 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10766784105&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 09 Sep 2024 05:41:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Removed a test case for the muted functionality of the Video Widget, streamlining the test suite. - **Chores** - Updated the test path in the limited-tests file to prioritize video widget testing over template testing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-09 11:55:00 +05:30
Anagh Hegde	08ec688396	test: remove redundant select workspace in cypres test (#36138) ... ## Description The spec MemberRoles started failing on PG branch(both ce and ee) recently. In this spec the last step, which asserts the user with view permission leaving workspace was failing. `the _.homePage.LeaveWorkspace(workspaceId);` internally calls for `_.homePage.SelectWorkspace(workspaceId);` ## Automation /ok-to-test tags="@tag.Workspace" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10736154328> > Commit: c9203b7da718cd2b718cf0fc990c4e4375cf5435 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10736154328&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Workspace` > Spec: > <hr>Fri, 06 Sep 2024 10:04:45 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated the test flow for workspace member roles to ensure accurate simulation of user behavior when leaving a workspace. - **Chores** - Modified the limited tests configuration to focus on member roles, removing the previous test for template for improved testing relevance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-06 16:07:32 +05:30
Pawan Kumar	f06a82b7bb	fix: Theming Selected new Font is reverted whenever Color is removed (#36119) ... Fixes #15007 /ok-to-test tags="@tag.Theme" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10733545727> > Commit: dec21477152095d034f63a7e08d2719cb0687b12 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10733545727&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Theme` > Spec: > <hr>Fri, 06 Sep 2024 06:48:00 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced theme validation for the multi-select widget, improving the robustness of theme-related tests. - Added new locators for featured themes to enhance testing capabilities. - **Bug Fixes** - Reactivated a previously skipped test case to validate font consistency across the application. - **Refactor** - Optimized color change handling in the ColorPicker component for better performance and reliability. - Refactored theme color control logic for improved maintainability and clarity. - **Improvements** - Enhanced type safety in theme properties to prevent misconfigurations. - Improved testability of the ThemeCard and ThemeSelector components with new attributes for automated testing. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-06 12:46:51 +05:30
Rudraprasad Das	45a3d814cb	fix: adding new test cases for git auto-commit (#34913) ... ## Description Adds cypress test for checking auto-commit functionality Fixes #33964 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10715693875> > Commit: 3dda8362544b4bc7b977e780f7d1140b1343c93f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10715693875&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Thu, 05 Sep 2024 07:45:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an end-to-end test suite for the Git autocommit feature, validating UI and backend interactions. - Added a new property to track the autocommit status bar in the GitSync class. - Enhanced the AutocommitStatusbar component for better testability with a new identifier. - **Improvements** - Made auto-commit eligibility checks always available by removing feature flag gating. - Improved logging visibility for auto-commit operations by adjusting log levels. - **Bug Fixes** - Streamlined tests by removing unnecessary checks related to the auto-commit eligibility feature flag. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: sondermanish <sonder.manish@gmail.com>	2024-09-05 23:42:10 +08:00
Hetu Nandu	65eb8546f4	fix: Fall of the error toasts wall (#35839)	2024-09-05 11:06:43 +05:30
NandanAnantharamu	bdeeea5c77	test: fix inline editing spec (#35986) ... RCA: Toggle state of the property was going to wrong state, hence with retry test was passing as it would bring back the application to required statee. Solution: Updated toggle state in the flaky test to avoid this issue EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4997 /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10633979760> > Commit: b63e5716203e0865ad493b1bc0ab8e952aaa7301 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10633979760&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 30 Aug 2024 14:27:24 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced inline editing functionality for table widgets, improving interaction and validation in tests. - **Bug Fixes** - Updated limited tests configuration to prioritize inline editing tests over previous specifications. - **Tests** - Improved test coverage for inline editing by adding interactions with dropdowns and property state toggling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-30 20:05:41 +05:30
Jacques Ikot	826a33aa9c	fix: Prevent Errors in Debugger When Deleting List Widget (#35820) ... ## Description **Problem** When deleting a List widget in the EE environment, the widget is successfully removed, but errors are displayed in the in-app debugger. These errors disappear upon refreshing the page, leaving users confused as to why the errors appeared in the first place, despite the widget being deleted correctly. **Root Cause** - The issue arises from the sequence in which widgets and their associated meta widgets are deleted. - When deleting a widget with meta widgets (e.g., a List widget): - The main widget is removed first via the deleteWidget saga. - Meta widgets are then deleted later during the componentWillUnmount lifecycle method. - The lint evaluation runs between these two processes, detecting meta widgets still present in the state without a parent widget. - This mismatch triggers errors in the in-app debugger, which disappear once the page is refreshed, as the meta widgets have already been deleted by then. **Solution** - We have modified the deletion process to ensure that both the main widget and its associated meta widgets are removed within the same action. - Instead of handling meta widget deletion in the general deleteSaga: - We now check for widgets with the hasMetaWidgets flag within the deleteWidget saga. - If such widgets are found, their meta widgets are deleted before the main widget is removed from the layout. - This adjustment ensures that the lint evaluation occurs after both the main widget and its meta widgets have been removed, preventing errors in the debugger. Fixes #35628 ## Automation /ok-to-test tags="@tag.Widget, @tag.List, @tag.IDE, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10629216245> > Commit: 56a4c85076d574cc2ebfef12d3b9f998ee1a4ece > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10629216245&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.List, @tag.IDE, @tag.Sanity` > Spec: > <hr>Fri, 30 Aug 2024 09:25:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced testing for the list widget to include verification of the drag, drop, and delete functionalities. - Improved widget deletion process by ensuring related meta widgets are also addressed during deletion. - Updated test descriptions for better clarity and scope, specifically focusing on deletion functionality. - Introduced a factory for creating instances of version 2 list widgets, streamlining widget generation. - **Bug Fixes** - Expanded test coverage for potential issues in widget behavior, particularly concerning deletion. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-30 10:38:19 +01:00
NandanAnantharamu	67de8c1a19	test: updated tests for checkboxgroup (#35945) ... RCA: Test was failing after removing retry, the issue was it was clicking on a checkbox which was not required. the retry actually was bringing back the system to right state by clicking again. Solution: We removed the step that was unnecessary in this case which resolved the issue EE: https://github.com/appsmithorg/appsmith-ee/pull/4992 /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10616697878> > Commit: e599c6d0149814c38049aaba7828465361d8f43b > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10616697878&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 29 Aug 2024 14:33:59 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: karthik <thinkify@karthiks-MacBook-Pro.local>	2024-08-29 22:55:33 +05:30
Anna Hariprasad	5ddf6e6977	feat: remove-clear-option-for-required-select-widget (#35060) ... Hi @rohan-arthur, @somangshu , @contributor-support **Fixes** #34262 **What's in this pr :** - Added isRequired prop for select widget components to control the logic for the remove button. - Added two test cases to verify clear button rendering when isRequired is set to true and false. **Screenshots :**    Please let me know if any changes are required. Thank you. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced an `isRequired` property to the `SelectButton`, `SelectComponent`, and `SelectWidget`, allowing users to indicate whether a selection is mandatory. - Enhanced rendering logic in the `SelectButton` to conditionally display the cancel button based on the `isRequired` state. - Improved styling and behavior options in `SelectComponent` for better integration into forms. - **Tests** - Added new test cases for the `SelectButton` to ensure correct rendering behavior of the cancel button based on the `isRequired` prop. - Streamlined Cypress tests to focus on the non-existence of the clear button, reflecting updated component behavior. - Updated locator configurations to improve test coverage for user interactions involving clearing selections. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-28 16:03:16 +05:30
Jacques Ikot	9f387d5763	fix: Correct Select Widget Mapping for Dynamic Label and Value Keys (#35862) ... ## Description **Problem** When the Select widget's labelKey or valueKey properties are switched to JS mode, passing a function that returns a string as the key causes the dropdown options to break. Instead of correctly mapping the labels and values, the options are incorrectly returned as an array of the key itself. **Root Cause** The issue lies in the `getOptions` function in derived.js. The logic that computes the select options based on the labelKey and valueKey was not handling cases where these properties are functions that return arrays. Instead of mapping through the source data and returning the corresponding values for each key, the function was mistakenly returning the entire array. **Solution** The `getOptions` function in derived.js has been updated to correctly handle cases where labelKey or valueKey are arrays. The function now maps through the sourceData and computes the correct labels and values based on the provided properties, ensuring that the dropdown options are displayed as expected. Fixes #35269 ## Automation /ok-to-test tags="@tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10560970428> > Commit: 118badee07c47fe72f727f8ab248c29685f6f7a1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10560970428&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding` > Spec: > <hr>Mon, 26 Aug 2024 15:24:26 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced test coverage for the Select widget by adding new test cases to validate the correct functioning of JavaScript functions in the label and value keys. - Improved processing of `optionLabel` and `optionValue` properties for the Select widget, ensuring accurate mapping to `sourceData`. - Introduced a new helper function to streamline the validation of label and value keys in the Select widget tests. - **Bug Fixes** - Corrected the handling of multiple options in the Select widget to enhance data mapping accuracy and functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-27 07:54:44 +01:00
Jacques Ikot	28ac53bf6e	fix: Ensure Select Column Displays Data When Options Are Not Set (#35817) ... ## Description **Problem** When using a table widget, changing a column to the "Select" type causes the data in that column to disappear unless the options property is explicitly set. This creates a poor user experience, as it appears that the data has been lost or the widget is malfunctioning. **Solution** We have implemented a fallback mechanism to ensure a smoother user experience. If no options are set in the property pane, the label inside the select cell will now default to displaying the existing value. This ensures that the data remains visible, even in the absence of predefined options. Fixes #35807 ## Automation /ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding, @tag.Table, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10513374411> > Commit: 1e89468e8345f2fc351c100428dca76a7a455dbc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10513374411&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Select, @tag.Binding, @tag.Table, @tag.Sanity` > Spec: > <hr>Thu, 22 Aug 2024 19:43:53 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced the select column in the table widget to return a default value when no options are available. - **Bug Fixes** - Improved robustness of the select cell component to prevent errors when the options array is empty. - **Tests** - Updated and reorganized test cases for the select column to improve clarity and specificity. - Introduced a new test case to validate default value behavior when no options are provided. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-23 10:10:27 +01:00
Pawan Kumar	f91073eae1	chore: fix zone dotted highlight is not showing up on new anvil apps (#35787) ... Fixes #35231 /ok-to-test tags="@tag.Anvil" Before:  After:  <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Improved widget border style handling by simplifying parameters and logic. - Enhanced visual consistency by removing the `elevatedBackground` consideration from various components. - Refined test logic to focus on section properties during space distribution. - **Bug Fixes** - Addressed potential inconsistencies in widget appearance related to background elevation settings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10503394684> > Commit: 574aab588e35fc90e59720010e2b8a249bf824ed > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10503394684&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.Anvil > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilHeadingWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Thu, 22 Aug 2024 07:30:08 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-08-22 12:46:48 +03:00
Rahul Barwal	6c8d4a9a66	fix: Fixes currentRow calculation logic in table(property pane) (#35390) ... ## Description <ins>Problem</ins> `currentRow` variable which is availabe in property pane of col settings - is not getting correct value during runtime if the table is sorted or filtered. <ins>Root cause</ins> * We are considering `processedTableData` to get the `currentRow`. * This property is not updated during filtering and sorting, another property `filteredTableData` is updated instead. * We CANNOT use `filteredTableData` as it depends on `primaryColumns` property which we intend to update as well - this is leading to cyclic dependency during evaluations. <ins>Solution</ins> Since the problem is related to edit cases and given the constraints around using `filteredTableData` directly, we fixed the problem by adding a new property to `editableCellValue` object called `__originalIndex__`. * This property stores the index of the row being edited in `processedTableData` * On top of this change, the PR adds a migration for updating the current row binding in TableWidgetV2, ensuring accurate current row calculation and improving the functionality of the widget. * We also added unit test for migration changes. * Additionally, This pull request refactors the DSLs for TableWidgetV2 migration test cases to update the DSLs to separate folder, drastically reducing the file size to its core logic, improving the readability of the code. * We also updated relevant test cases to account for this change. [Testing plan](https://www.notion.so/appsmith/Issue-34346-currentRow-doesn-t-work-correctly-when-the-table-is-filtered-449225ae822c485493036599c2b19487) [Counter part EE pr](https://github.com/appsmithorg/appsmith-ee/pull/4879) Fixes #34346 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10451549845> > Commit: d1d65c6898c223bf3f6dfbfe93b8e8de214fcc7d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10451549845&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 19 Aug 2024 11:15:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [x] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Updated DSL migration process to support version 90, enhancing compatibility and robustness. - Introduced new migration logic for table widget data bindings, improving inline editing capabilities. - Enhanced validation logic for editable cells in table widgets, allowing for more dynamic data handling. - Added a method to discard edits in specific table cells, improving user interaction. - Introduced a new message constant for required fields, enhancing user feedback. - **Bug Fixes** - Improved validation checks for table cells based on updated indices and values. - **Tests** - Added comprehensive tests to validate migration functions related to Table Widget, ensuring all aspects function correctly post-update. - Enhanced test specifications for improved validation logic and coverage in table widget functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: sneha122 <sneha@appsmith.com>	2024-08-20 13:31:45 +05:30
Jacques Ikot	6628635cf4	fix: mandatory date column enforcement (#35613) ... ## Description **Problem:** When the `isRequired` property is set for date columns in the table widget, the validation doesn't work as expected. Users can add new rows without filling in the date field, even though it is marked as required. This results in rows being added with missing date values, which can lead to incomplete or invalid data entries. **Root Cause:** The validation logic for the date column is currently handled within the DateCell component. However, the isRequired validation functionality was not implemented within this component. Additionally, the general validation logic in the `getEditableCellValidity` function, located in the derived.js file, does not account date cells in its isRequired validation. **Solution:** To fix this issue: **Enhance the `getEditableCellValidity` function:** Extend the existing validation logic in getEditableCellValidity to include the date cell in its validation, specifically checking for the isRequired property. **Integrate with DateCell validation:** Ensure that the isRequired validation is properly executed in conjunction with the existing date validations inside the DateCell component. This will enforce the requirement and prevent new rows from being added if the date field is left empty. **Test Plan** https://www.notion.so/appsmith/Test-Plan-Date-Column-Marked-as-Required-Doesn-t-Enforce-Mandatory-Entry-When-Adding-New-Table-Row-c73b764af60842a188cba056bdda6d79?pvs=4 Fixes #34258 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10453174231> > Commit: 40fe2eaf7d45024bef00f8031e971a5bac2a4e3e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10453174231&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 19 Aug 2024 13:17:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced validation for "Date" column types, ensuring that required fields are correctly enforced. - **Enhancements** - Improved validation logic for more accurate user feedback in date cells. - Expanded support for validating "date" columns in the table widget. - **Bug Fixes** - Enhanced error handling to ensure proper indication of cell validity based on new validation criteria. - Updated visual feedback for cell editor state in the UI. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-20 07:09:51 +01:00
Sagar Khalasi	25349c1c66	test: Update case base duplicate file name (#35672) ... ## Description Remove the duplicate file name with different cases as well. Fixes #`34939` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10370869517> > Commit: 242ca07a87991f5786bd8a33aeefaf046e2a29e0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10370869517&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 13 Aug 2024 14:36:34 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No	2024-08-20 10:48:52 +05:30
Rahul Barwal	32f2986662	chore: fix flaky datepicker spec. (#35726) ... ## Description In the past we attempted to remove the `DatePickerV2_spec` from flaky list after successful `/ci-limit-test` runs ([EE PR with runs](https://github.com/appsmithorg/appsmith-ee/pull/4736)). But the very next day it had to be added back to the flaky list. There was certainly a problem which was not getting caught on local and `ci-limit-test` runs. Upon observing the [last known failure run of this spec](https://internal.appsmith.com/app/cypress-dashboard/run-details-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10096251875&attempt=5&selectiontype=test&testsstatus=failed&specsstatus=fail), this error got highlighted: > CypressError: Timed out retrying after 100000ms: `cy.wait()` timed out waiting `100000ms` for the 5th response to the route: `updateLayout`. No response ever occurred. Upon further debugging and a loooot of local runs I noticed that even though we were changing the `Max date` at the end of this spec does not do anything(on the product UI) and more importantly had no impact on the test run. So we removed it. The good thing is that in current [EE PR](https://github.com/appsmithorg/appsmith-ee/pull/4907) as well there are no failures. > PS: I would still be on alert after merging to notice any more failures and add it back to flaky, if it troubles other team members. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datepicker, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10446454718> > Commit: b0348f4f13c6b36cb35b0a5fd596513d42ab7837 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10446454718&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datepicker, @tag.Sanity` > Spec: > <hr>Mon, 19 Aug 2024 03:36:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the DatePicker component's test to remove the maximum date constraint, allowing for a broader range of valid dates during testing. - Revised conditions for tooltip assertions related to date range validation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-19 09:16:48 +05:30