PromucFlow_constructor

Author	SHA1	Message	Date
Alex	68264f1e2e	chore: extract search and add to ads (#38192 ) ## Description Extract search and add to ADS. Fixes [#37888](https://github.com/appsmithorg/appsmith/issues/37888) ## Automation /ok-to-test tags="@tag.IDE, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12407865393> > Commit: dce12fbeebae3ef23d9bd251a8096b09306a06d5 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12407865393&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE, @tag.Sanity` > Spec: > <hr>Thu, 19 Dec 2024 07:44:13 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit ## Release Notes - New Features - Introduced the `SearchAndAdd` component for enhanced search and add functionality. - Added a new Storybook story for the `SearchAndAdd` component, providing visual documentation and interaction examples. - Bug Fixes - Replaced the deprecated `AddAndSearchbar` component with `SearchAndAdd` in relevant areas of the application. - Documentation - Enhanced documentation for the `SearchAndAdd` component through Storybook. - Chores - Updated import statements to reflect the new component structure and removed obsolete components. - Modified locators to use data attributes for improved element identification in tests. - Added specific identifiers for testing frameworks to enhance testability of components. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-12-19 13:43:13 +05:30
Sagar Khalasi	a5fa2aa7a1	test: new test cases framework functions and Action selector (#37566 ) ## Description E2E Test cases for framework function & Action selector. Fixes [Issue URL](https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/37370) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12343756587> > Commit: 56f7a2eb2acee62237f9dcd395b6a618956e38a2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12343756587&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 16 Dec 2024 03:08:25 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced property pane with new button widget identification. - New selectors for action cards and toast notifications. - Improved modal interaction with new properties for buttons. - Added functionality for toggling JavaScript execution on page load. - New methods for character manipulation and console log management. - Comprehensive application configurations for interval management. - New applications and widgets for managing intervals and clipboard functionality. - New functionality for resetting widgets and handling navigation actions. - Introduction of new JSON configurations for various applications. - Bug Fixes - Improved error handling for various actions and functions. - Tests - Extensive test coverage for new and existing functionalities, including action selectors, interval functions, alert handling, and geolocation features. - New tests for clipboard functionality, download actions, and local storage operations. - Enhanced tests for Radio and CategorySlider widgets to improve validation of JavaScript context and error handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: yatinappsmith <yatin@appsmith.com>	2024-12-16 16:41:54 +05:30
Sagar Khalasi	ab0628839b	fix: Fix iframe and widget test case for clicking (#38039 ) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Iframe" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12236274208> > Commit: 7bd2b6a3d6cb68b9e0eeeccdb0c52b60113a4515 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12236274208&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Iframe` > Spec: > <hr>Mon, 09 Dec 2024 13:30:29 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Improved the Iframe widget test by ensuring button clicks can proceed under all conditions. - Enhanced entity context management during URL property updates in tests. - Tests - Updated test specification to include the Iframe widget test, replacing the previous fork template entry. - Adjusted visibility assertion to use conditional waits in the Iframe widget tests. - Style - Modified CSS selector spacing in the CommonLocators to improve element targeting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-12-09 19:00:43 +05:30
Sagar Khalasi	39877bdb66	fix: Fix flaky test case for the iframe spec (#38018 ) ## Description Re-wrote new test case. Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38017 ## Automation /ok-to-test tags="@tag.Iframe" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12197419550> > Commit: 5b0d7ad0a92123b412cb18c7b1814548f51e6ac4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12197419550&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Iframe` > Spec: > <hr>Fri, 06 Dec 2024 11:07:20 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - New Features - Enhanced testing suite for the Iframe widget, allowing for more specific interactions with multiple iframe instances. - Added a new test case to verify iframe behavior during property updates. - Bug Fixes - Updated iframe URL configurations to ensure correct redirection to the new documentation site. - Documentation - Introduced a new JSON structure for the Iframe widget, detailing properties and settings for improved user interaction. - Chores - Updated test specification paths to focus on the Iframe widget tests. - Modified common locators for improved navigation element targeting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-12-06 17:11:17 +05:30
albinAppsmith	46786ae003	feat: Enable new toolbar for cypress (#37148 ) ## Description This PR enabled IDE toolbar for cypress. Fixes #37217 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12115693818> > Commit: f2af8705e91af400b3a80f6684cce7fb487f1ca3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12115693818&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 02 Dec 2024 12:19:38 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new feature flag `release_actions_redesign_enabled` to enhance user experience. - Bug Fixes - Updated method calls in various test cases to improve consistency and reliability in interactions, specifically renaming methods related to data sources and queries. - Improved error handling and validation in tests for MongoDB query functionalities. - Documentation - Enhanced test coverage and assertions for various functionalities, including API actions, Google Sheets queries, and JavaScript function execution. - Style - Updated CSS selectors for improved consistency and maintainability across components and test cases. - Tests - Refactored multiple test cases to utilize new helper methods, improving code clarity and reducing direct DOM manipulation. - Enhanced visual tests for JSEditor and improved interaction with the run button. - Added new assertions and enhanced the structure of tests for various components, including API response handling and widget interactions. - Streamlined interaction with the settings toolbar in various test cases by encapsulating functionality within the `PluginActionForm` class. - Introduced new `data-testid` attributes across various components to enhance testability. - Chores - Removed unused imports and streamlined method calls for better performance and readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-12-03 09:21:43 +05:30
NandanAnantharamu	ff3909a50d	test: partial import export areas covered (#37661 ) Adding tests for partial import/export To be done into a new app To be done into a new page GitConnected App and importApp testing https://docs.google.com/spreadsheets/d/1Vq5vRUyAMv2npPv4j41omzZrYcRUb8LEOhNVu_O4OE8/edit?gid=428365096#gid=428365096 /ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - New Features - Introduced a comprehensive suite of end-to-end tests for validating partial import and export functionality. - Added new JSON configurations for API actions and application components to enhance import/export capabilities, including structured representations for widgets and actions. - Improvements - Updated test specification paths to reflect the new focus on partial import/export tests. - Expanded the set of locators for Cypress tests to improve interaction with entity items and specific row data in tables. These updates aim to improve the reliability and functionality of the import/export processes within the application. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12035486686> > Commit: 5c3d72b8d9ab5cb9948f3cb8935c1db63fccb050 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12035486686&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 27 Nov 2024 06:19:10 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-11-28 23:48:53 +05:30
NandanAnantharamu	602fe2b8a1	test: fix tabs skipped test CE (#37023 ) [NandanAnantharamu](https://github.com/NandanAnantharamu) NandanAnantharamu commented [1 hour ago](https://github.com/appsmithorg/appsmith-ee/pull/5425#issue-2607459836) • Skipped test in Tab spec is fixed. There was change in one of the validation step /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11504174102> > Commit: 6b0e6077236862ebd92ee9d121622a4b4af46063 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11504174102&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 24 Oct 2024 17:52:38 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Re-enabled test case for verifying colors, borders, and shadows of the Tabs widget. - Updated border color assertion to dynamically check the widget's border color. - Improvements - Enhanced verification of property visibility and functionality for the Tabs widget, including tab renaming, deletion, and binding with text widgets. - Validated behavior when toggling the "Show Tabs" property and ensured appropriate error handling for invalid default tabs. - Chores - Updated the test file reference in the limited-tests configuration to focus on the Tabs widget. - Introduced new selectors for improved interaction with widget properties. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-10-25 21:21:57 +05:30
Rahul Barwal	9719e9238c	chore: Update tinymce version to 6.8.3 in package.json and yarn.lock (#36909 ) ## Description TinyMCE initially switched from LGPL to MIT in 2022, aiming for a more permissive license. However, it reverted to GPL v2+ for version 7, which is a concern for us. TinyMCE 6.8.3 under the MIT license until October 31, 2024, it will stop receiving any security updates post that. Fixes #36859 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.TextEditor" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11379278624> > Commit: 8aa96b6100642663f39e275b370582397e11a6a4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11379278624&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.TextEditor` > Spec: > <hr>Thu, 17 Oct 2024 06:29:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No	2024-10-17 12:18:14 +05:30
Hetu Nandu	8463d02740	chore: [Plugin Action Editor] Combine Plugin Editor UI state (#36651 ) ## Description Removes the parallel apiPaneReducer and queryPaneReducer and combines it into pluginActionEditor Fixes #36153 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11231694032> > Commit: 3a204e2902f9733be05e3b7087869d2e91ad52eb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11231694032&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 08 Oct 2024 10:15:30 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - New Features - Introduced a new constant `POST_BODY_FORM_DATA_KEY` for improved data handling. - Added several action creators and selectors for enhanced management of the plugin action editor's state. - Implemented state management for the plugin action editor's debugger. - Added the ability to execute commands related to plugins in the `CodeEditor` component. - Introduced a new enumeration `DEBUGGER_TAB_KEYS` for better organization of debugger tabs. - Improvements - Refactored import statements for better organization and reduced complexity. - Enhanced the `PluginActionResponse` component to focus on plugin action state management. - Updated the tab management logic in various components to reflect the new plugin action state. - Improved state management in the `QueryEditor` and `APIEditor` components to accurately represent action processing states. - Added error handling in the `ActionSettings` component for missing configuration. - Bug Fixes - Updated logic in hooks to ensure proper state management for plugin actions. - Adjusted navigation and tab selection methods to align with the new plugin action state management. - Corrected test selectors for error tabs in Cypress tests to ensure accurate UI interactions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-08 16:12:27 +05:30
NandanAnantharamu	8e9b843644	test: udpated files by removing un-used APIs (#36705 ) Removed APIs that are not in use /ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11179855393> > Commit: ce672b5ff1f3976034fd91b1c1ffe7eb9efbf925 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11179855393&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 04 Oct 2024 13:50:12 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Updated the authenticated API URL for improved connectivity. - Bug Fixes - Removed outdated properties (`restapi_url` and `connection_type`) from environment configurations to streamline the data model. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-10-07 16:00:43 +05:30
Aman Agarwal	56e7f89402	chore: removed old flags for airgap instances (#36609 ) ## Description Removed all the occurrences of listed flags in the codebase: 1. ab_ds_binding_enabled 2. ab_ds_schema_enabled 3. ab_gsheet_schema_enabled 4. ab_learnability_discoverability_collapse_all_except_data_enabled 5. ab_learnability_ease_of_initial_use_enabled 6. ab_mock_mongo_schema_enabled 7. ab_start_with_data_default_enabled 8. rollout_js_enabled_one_click_binding_enabled Fixes #36256 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11177173738> > Commit: bfbf6bbe77b963c5d257c29cf5bac35139417a07 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11177173738&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 04 Oct 2024 10:31:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced test coverage for the Community Issues page, focusing on pagination, search, filtering, and issue management. - Improved functionality for adding new rows to table widgets, including visibility controls and state validations. - Bug Fixes - Resolved issues related to the visibility of UI elements when adding new rows and ensured accurate data reflection in the table. - Tests - Expanded tests for pagination, row selection, search functionality, and filtering logic in table widgets. - Added comprehensive assertions for client-side search and filtering scenarios, including checks for modal visibility during issue management. - Chores - Removed obsolete feature flags and streamlined logic for managing feature flags across components. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-07 15:26:25 +05:30
NandanAnantharamu	9f7e624b70	test: fix canvas context property pane (#36356 ) EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5161 RCA: The property section related validations were not working Solution: - Enhanced verification of property pane section visibility using accessibility attributes. - Introduced new UI interaction properties for managing collapsible sections. /ok-to-test tags="@tag.IDE" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10919160204> > Commit: 3d5c864891f027d03e5d50ddb15a185f980d83aa > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10919160204&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` > Spec: > <hr>Wed, 18 Sep 2024 09:42:19 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-09-18 17:31:40 +05:30
albinAppsmith	91fd967311	feat: Action redesign - changes in save and edit datasource (#36222 ) ## Description This PR updates the save datasource text to "Save" and edit datasource text to "Edit". Also, updated the save datasource icon to better represent datasource. Fixes #35503 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10807660093> > Commit: fda9c7479d4626aa7178e74f310586264724471c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10807660093&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Sep 2024 09:43:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Simplified user interface messages for editing and saving data sources to "Edit" and "Save." - Updated the icon for the save button to better represent the action when saving a datasource. - Introduced a new locator for the save datasource button to enhance testing capabilities. - Bug Fixes - Improved adherence to coding standards by modifying ESLint rules related to function props. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-11 16:32:53 +05:30
Hetu Nandu	65eb8546f4	fix: Fall of the error toasts wall (#35839 )	2024-09-05 11:06:43 +05:30
Aman Agarwal	d79bad4e27	fix: API multipart spec flakiness (#35927 )	2024-08-28 17:47:44 +05:30
Anna Hariprasad	5ddf6e6977	feat: remove-clear-option-for-required-select-widget (#35060 ) Hi @rohan-arthur, @somangshu , @contributor-support Fixes #34262 What's in this pr : - Added isRequired prop for select widget components to control the logic for the remove button. - Added two test cases to verify clear button rendering when isRequired is set to true and false. Screenshots : ![image](https://github.com/user-attachments/assets/4c276add-f28e-4060-8f44-a957dc48f673) ![image](https://github.com/user-attachments/assets/02138d93-e4c1-4e67-97df-0703398c440b) ![image](https://github.com/user-attachments/assets/8eb8ec6f-9124-4a61-9df4-448338086714) Please let me know if any changes are required. Thank you. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced an `isRequired` property to the `SelectButton`, `SelectComponent`, and `SelectWidget`, allowing users to indicate whether a selection is mandatory. - Enhanced rendering logic in the `SelectButton` to conditionally display the cancel button based on the `isRequired` state. - Improved styling and behavior options in `SelectComponent` for better integration into forms. - Tests - Added new test cases for the `SelectButton` to ensure correct rendering behavior of the cancel button based on the `isRequired` prop. - Streamlined Cypress tests to focus on the non-existence of the clear button, reflecting updated component behavior. - Updated locator configurations to improve test coverage for user interactions involving clearing selections. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-28 16:03:16 +05:30
Aman Agarwal	a0f2ee10ce	fix: collapse params & query params in action selector if value is not changed (#35323 )	2024-08-02 15:01:18 +05:30
Abhijeet	992bbdb7c8	chore: Update Postgres port for TED in CI (#34430 ) ## Description PR to update the Postgres posrt for TED container in CI. /test all ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9646981763> > Commit: d998c6fe77ac2acdb71888fe6b3d7603ddda508c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9646981763&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Chores - Updated Docker port mapping from `5432` to `5433` across multiple CI workflow files to ensure consistency and avoid port conflicts. - Bug Fixes - Adjusted PostgreSQL connection port from `5432` to `5433` in test fixtures and scripts to align with environment changes and prevent connection issues. - Tests - Modified test scripts to handle new PostgreSQL port settings for improved reliability in testing scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-06-25 10:35:15 +05:30
Pawan Kumar	e01b34ec5d	chore: tests for wds button widget (#34242 ) /ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced test cases for Anvil Button Widgets, including Canvas, Preview, and Deploy modes. - Bug Fixes - Updated CSS and HTML selectors for better element targeting and testing reliability. - Style - Improved styling logic for buttons in the InlineButtons component. - Chores - Added `data-testid` attributes for better test targeting. - Refactored code for string concatenations and URL constructions in DeployModeHelper. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9597157402> > Commit: c551705fe01aace94962fcc7fa91dff253136721 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9597157402&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-06-20 18:30:16 +05:30
Ashok Kumar M	699222c5ee	feat: Preliminary set of test cases and test utils for Anvil DnD and Space distribution. (#33827 ) [![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX1u2Bid9BINpjXo7tV9v2Rzv3B7llrExE%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=NPM_l3J) ## Description In this PR we are - adding more testcases for Anvil DnD and space redistribution - create a structure for adding more utils for Anvil - adding utilities to perform operations in anvil - cleaning up anvil based locators Fixes #33738 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9297777615> > Commit: 21572b8a99cb22fb622729c807737ac133cfd073 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9297777615&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No	2024-05-30 12:46:56 +05:30
sneha122	f9d00eb595	fix: turned on learnability flags on by default (#33283 ) Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-05-13 15:48:11 +05:30
Valera Melnikov	07854ca1fd	fix: e2e autoLayout test (#33295 ) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.MobileResponsive" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9003479936> > Commit: 80aceb5b469801ef97dae454b382342e0ae88cb8 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9003479936&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No	2024-05-08 17:51:26 +03:00
Valera Melnikov	ed9c55d4c4	fix: asymmetric padding for sections and zones (#33204 ) ## Description Added asymmetric paddings for sections and zones. https://github.com/appsmithorg/appsmith/assets/11555074/1959c6f2-5e26-4fdd-98e3-ea1bb5e09dae Fixes #32209 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8999510824> > Commit: b714426d3185c9a75523fe98ae4ca75e26f0b249 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8999510824&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No --------- Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>	2024-05-08 13:16:51 +03:00
sneha122	ee7a6bed2d	fix: slash menu command show all available queries and datasources fixed (#33076 ) ## Description The slash menu command popup that gets shown today for property pane only shows 5 queries and not all the queries that exist in my page. This PR solves that problem by adding `Load more` option in the popup which users can click to get full list of queries. This behaviour of load more is similar to load more of one click binding. Note: Cypress test case have been added for this PR. ### Before: Even though I have 6 queries, it's only showing 5 and hiding `Api1` <img width="266" alt="Screenshot 2024-05-03 at 12 05 47 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/31b2512e-74a0-46c0-bdc5-37030154b651"> <img width="280" alt="Screenshot 2024-05-03 at 12 05 41 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/6943c769-cdba-4a67-b1d7-237e80831314"> After: https://github.com/appsmithorg/appsmith/assets/30018882/e748534f-a842-4f9e-b54a-d86cbd1ae54e Fixes #32896 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.JS" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8996774021> > Commit: aadce199e6fc024a6ac3eebdcf3e5160a9697c1f > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8996774021&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-05-08 11:43:09 +05:30
Ashok Kumar M	4b1ef98014	feat: Anvil DnD Polish(Refactor) (#32839 ) [![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX18VSEOqElAtQ747ag1P1M0EAgrsJtMy4pQ%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=MdeCkAG) ## Description In this PR, - we are refactoring Anvil DnD to use dom elements to render highlights instead of canvas. Why? - Doesn't have the ability to overflow a widget and still allow dnd events(section widget use case) - limitations with respect to being testable - we are adding compensators to dnd layers, so that DnD is not just for layout but for the entire widget. Widget is the appsmith entity. layout is something present in container like widgets like Section and Zone which allow you to contain children widgets based on a the layout structure. What are compensators? - additional padding for DnD layers in a widget - additional position offsets for highlights in a widget so that they don't stick to the layout. Why compensators? - Section widget can be activated to show highlights in areas overlapping with main canvas - DnD should be possible even at spacings created by parent widget like in Zone widget - we are also removing canvas activation logic and moving to using mouse move event to activate a canvas for DnD. Fixes #32016 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8872919856> > Commit: 3f6603bf8480a99437552ac73764c9de1d6f7f95 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8872919856&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced a new layout property for widgets, enhancing customization options. - Added a custom error boundary component to handle and display errors elegantly. - New drag-and-drop components and utilities to improve interaction within the editor canvas. - Adjusted component hierarchies in Anvil editor and viewer for better performance and structure. - Refactor - Simplified rendering logic in `AnvilWidgetComponent` by removing conditional boundaries. - Updated the hierarchy within the Anvil editor, enhancing component nesting and interaction. - Bug Fixes - Adjusted padding values and added new constants for better UI alignment and interaction feedback. - Chores - Renamed and reorganized Cypress locators and methods for clearer and more efficient testing automation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-29 11:32:08 +05:30
NandanAnantharamu	a96f9cced5	test: fix JsObjectMutation flaky test (#32936 ) RCA: <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated the test specification file and focused test execution on a specific test case. - Added a new assertion to verify the presence of a specific element in the DOM. - Added a new declaration to the `CommonLocators` class for improved test reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-26 18:19:22 +05:30
Shrikant Sharat Kandula	cd22fc1087	test: Some cleanup for Git Cypress tests (#32836 ) 1. Change usage of ports bound to 3000, 5000 and 8000 to 4200, which will be the canonical port for TED in the future. 2. Switch to using TED's native git repo management APIs, instead of the Gitea compatibility layer. 3. Remove code from GitHub ages. /ok-to-test tags="@tag.Sanity, @tag.Git"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8785291879> > Commit: b38f4eb388716f7fcfc2a032d788c2ebb951568b > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8785291879&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced Git integration by shifting from GitHub to Gitea for repository operations in test environments. - Updated URLs and endpoints across various test scripts and data fixtures to align with new configurations. - Tests - Modified test scenarios to reflect changes in Git operations and URL configurations. - Chores - Updated CI workflows by replacing old secrets with new ones for better configuration management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-23 10:01:14 +05:30
Hetu Nandu	065ced345b	chore: Make Editor Pane Segments GA (#32712 )	2024-04-18 10:05:34 +05:30
Hetu Nandu	48685e633a	fix: Feature flags not intercepted correctly (#32341 ) ## Description Fix for correctly intercepting Feature Flags in the testing env Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8533833714> > Commit: `e7a1bebf9feda3c92015907b73f9cdcd8bc806a7` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8533833714&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Optimized feature flag management for improved performance and reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-03 12:54:52 +05:30
Shrikant Sharat Kandula	fc4100b747	test: Use server on 5000 port for test pictures (#32304 ) We've introduced a new Node express server on TED at port 5000, which runs Postgraphile, as well as serves the test static assets. This PR switches to use that endpoint for test static assets.	2024-04-02 10:26:45 +05:30
Vemparala Surya Vamsi	4b27a59b1c	chore: remove feature flag code of consolidated api (#32248 ) Removed feature flag related code to consolidated api, also corrections in feature flags are made here. Fixes #31100 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/8490467344> > Commit: `fce48b210983689994152b7ae77c773cfdca854a` > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced new feature flags to enhance user interface and default settings. - Refactor - Simplified page loading logic for better performance. - Enhanced error handling and reporting for a smoother user experience. - Chores - Cleaned up unused imports and code for better maintainability. - Bug Fixes - Removed redundant checks and updated functionality to include new feature flags. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-01 17:45:09 +05:30
balajisoundar	18882e7559	chore: Update @tinymce/tinymce-react (#32120 ) ## Automation /ok-to-test tags="@tag.TextEditor" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8477514930> > Commit: `b69e1d01c55200b58eea0704e36b940bbb8f1992` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8477514930&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Rich Text Editor with improved styling, additional toolbar options, and updated functionality. - Style - Updated styles for the Rich Text Editor, including toolbar, editor header, and various elements within the editor. - Chores - Removed unused plugins from the Rich Text Editor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-29 12:07:35 +05:30
Aman Agarwal	af184f3cb0	feat: add edit option in suggested queries in hint commands (#32076 ) ## Description This PR introduces a new way to edit the queries directly from slash hint commands that edit button appears on hover of the hint. This also introduces an event `EDIT_ACTION_CLICK` as emitted from different other places of our application with all the similar properties except the `from` : `SlashCommandHint` <img width="566" alt="Screenshot 2024-03-27 at 12 45 09 AM" src="https://github.com/appsmithorg/appsmith/assets/7565635/34f0e226-d45a-482b-8484-7e1fdc672a04"> Fixes #32075 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8465758601> > Commit: `cff14b0006441274e182d17ff66603219971ddbd` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8465758601&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the code editor with improved command suggestions and quick command generation, including URL and event parameter handling. - Introduced new styling for command suggestions in the code editor. - Refactor - Updated functions and components for better handling and mapping of plugins within the code editor. - Chores - Added necessary imports and updated the usage of various components and utilities to support new features and improvements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-28 19:24:33 +05:30
Hetu Nandu	d9b20e8c2b	feat: Rollout Side by Side (#31686 )	2024-03-13 13:12:08 +05:30
Ashok Kumar M	c209b47671	chore: clean up space distribution feature in Anvil (#31468 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description This PR addresses two particular things with space distribution - Issue: Space distribution distributing more than max column limit space - Enhancement: Replace flew grow css for zones to flex basis to make sure column widths are even irresepective of number of zones in a section. Additional Fixes: - replaced test id of widgets editor to abide by repo standards. - disable crud app generation feature for Anvil. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enabled new feature flags to enhance application capabilities. - Introduced dynamic space redistribution for improved layout management. - Added "Generate App" functionality for users with specific feature access. - Enhancements - Updated UI selectors for better consistency and reliability. - Refined layout system logic to always utilize the Anvil layout system. - Refactor - Optimized feature flag selection logic for efficiency. - Improved flex property handling in layout components for more accurate space distribution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-06 12:59:44 +05:30
Aishwarya-U-R	30300bb6a4	test: Cypress \| Replacing some external api's with TED + Flaky fix (#31118 ) ## Description - This PR does some clean up of comments - in DeployHelper.ts - This PR replaced external image api with TED mock api in ServerSide/OnLoadTests/OnLoadActions_Spec.ts - Extrenal example api to TED in Widgets/Image/Image_spec.js - Extrenal api links in app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js to TED api's - Flaky fixes /ServerSide/LoginTests/LoginFailure_spec.js - for EE CI run failure (Added multiple Dynamic checks) - support command.js method LoginUser() - added Dynamic check - Encapsulated Datasources/Arango_Basic_Spec.ts into conditional check to run in CE alone, instead of entirely skipping, since its failing in EE due to chrome crash #### Media #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated Cypress regression tests to use flower images instead of cat images for API calls. - Modified limited test configurations to run with different spec files. - Adjusted GitHub Actions workflow to change `matrix_count` values based on the event type and retrieve PR number for manual triggers. - Updated Docker image tag in CI tests to `nightly`. - Refactor - Enhanced `DataManager` class with new properties for flower image URLs. - Improved `EntityExplorer` class method to ensure more reliable triggering of events. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-23 13:18:01 +05:30
Pawan Kumar	55fb2ce467	fix: Widget Sidebar Spec (#31196 ) In my last PR, I broke the widget_sidebar_spec, this PR fixes that. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated CSS selectors in test support files for improved consistency and reliability. - Tests - Added the `@tag.Widget` tag to improve organization in Entity explorer tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-02-19 15:49:57 +05:30
Ashok Kumar M	f7d41891b8	fix: Anvil toggleable widgets not working when native callbacks are used for AnvilFlexComponent (#31125 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In last weeks effort of cleaning up Editor and Viewer parts of AnvilFlexComponent I had changed synthetic React callbacks to native ones #30780 . This has resulted in regression of widget toggling of widgets like Checkbox, Switch, etc. so changing them back to synthetic events by passing callbacks and props to the viewer part of AnvilFlexComponent. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new testing suite for validating widget interactions in Anvil Layout Mode, focusing on switch and checkbox widgets. - Added new functionalities for switch and checkbox widgets, including selection toggling and state verification. - Enhanced Anvil editor components to support custom click behaviors, improving widget interaction in edit mode. - Bug Fixes - Addressed issues with native click callbacks interfering with widget events. - Tests - Added comprehensive test cases for new widget functionalities and interactions. - Refactor - Updated internal logic for widget selection and style adjustments based on interaction states. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-15 11:00:57 +05:30
Aishwarya-U-R	a6b8a3440e	test: Cypress \| Text_With_Different_Size_spec.ts re-write + Flaky fixes (#30445 ) ## Description - This PR re-writes the entire Text_With_Different_Size_spec.ts spec to fix the master run flakyness and and improves the overall complexity of the test case format - cypress/e2e/Regression/ClientSide/Onboarding/StartFromScratch_spec.ts (agHelper.VisitNAssert improved) - Master runs pass at [Run1](https://github.com/appsmithorg/appsmith-ee/pull/3337#issuecomment-1899183181), [Run2](https://github.com/appsmithorg/appsmith-ee/pull/3337#issuecomment-1899197871) - cypress/e2e/Regression/ClientSide/BugTests/AbortAction_Spec.ts (1st test - replace with TED url) - getConsolidatedDataApi() separated, created new agHelper.CypressReload() - Removed cy.log statements from few places - homePage.LogOutviaAPI() removed static wait - Replaced homePage.LogOutviaAPI(); with homePage.Signout(); in places where its flaky - Split /Onboarding/StartFromScratch_spec.ts to 3 specs to reduce flakyness - Split /ClientSide/PartialImportExport/PartialExport_Widgets_spec.ts with failing test to run the other tests in CI - /Templates/Fork_Template_To_App_spec.ts - Added dynamic check to fix CI flakiness - agHelper.AssertURL(), assertHelper.AssertDocumentReady() improved - jsEditor.NavigateToNewJSEditor() improved - cypress/e2e/Regression/ClientSide/ExplorerTests/JSEditorContextMenu_Spec.ts - jsEditor.ValidateDefaultJSObjProperties improved - cypress/e2e/Regression/ServerSide/OnLoadTests/OnLoadActions_Spec.ts - (3rd case - flaky fix) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after changes were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Tests - Enhanced test flexibility by dynamically constructing API URLs. - Improved test setup and flow in onboarding and regression suites. - Added new test spec files for dynamic height, onboarding, bug tests, login failure, and starting from scratch scenarios. - Refactor - Updated function calls and parameters across various test files for consistency and efficiency. - Removed redundant code and streamlined test actions. - Chores - Updated intercepted HTTP methods and added new utility functions to support test operations. - Bug Fixes - Fixed issues related to element visibility assertions in test scripts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-08 16:55:58 +05:30
Ashok Kumar M	c37d0c283f	fix: Anvil Widgets not accessible when widget has no content. (#30780 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In this PR, we are fixing a few issues and also destructuring AnvilFlexComponent for edit and view. Issues Fixed - Widgets without any content like a text widget without text are not hoverable - Modal once opened does not close when other widgets on the canvas are selected via the enitty explorer. Anvil Flex Component was common component inspired from PositionedContainer of Fixed layout. It had all features of Edit and View together in one place. This mean viewer was unnecessarily interpreting more code. Now AnvilFlexComponent has been broken into AnvilFlexComponent and AnvilEditorFlexComponent. AnvilEditorFlexComponent is a wrapper around AnvilFlexComponent with abilities needed for Edit Mode. Another issue addressed in the PR is removal of DraggableComponennt, which was just making dragging possible and providing a few styles like fading the widget when it is being dragged. With this PR all the above mentioned functions will be taken care of by AnvilEditorFlexComponent. #### PR fixes following issue(s) Fixes #30734 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced feature flag management with additional flags for better control over application features. - Introduced a new editor component for Anvil layout system, improving layout and behavior management in edit mode. - Added a custom hook for managing hover states on Anvil widgets, enhancing user interaction. - Refactor - Updated AnvilFlexComponent to use `forwardRef` for better ref management and optimized widget configuration and rendering logic. - Modified selector logic to simplify the retrieval of layout system type, enhancing code maintainability. - Adjusted test methodologies to improve reliability and accuracy. - Bug Fixes - Corrected assertions in Cypress end-to-end tests to accurately locate and interact with widgets in the Anvil canvas, ensuring test reliability. - Chores - Updated common locators and assertion methods in Cypress support files for consistency and clarity in test scripts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-05 18:00:50 +05:30
Aishwarya-U-R	67d20d9858	test: Cypress \| Helpers improved + Flaky fixes (#30735 ) ## Description - This PR fixes the RenameApplication flakyness in CI with added dynamic check - Also replacing js cy.renameApp to TS helper - Flaky fixes - cypress/e2e/Regression/ClientSide/Workspace/MemberRoles_Spec.ts (entire spec updates for EnableGAC, removed signout from 'it' blocks) - cypress/e2e/Regression/ClientSide/Workspace/ShareAppTests_Spec.ts (7th flaky fixed) - cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts (5th test) - cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js (2nd - added validation to match the test description, 1st & 3rd - removed static waits, Added multiple dynamic checks) - cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js (3rd & 4th flaky tests) - homePage.AssertViewPageLoad() created - homePage.LaunchAppFromAppHover() improved - homePage.Signout() - added dynamic checks - Added more validation to homePage.Signup() method with Dynamic checks - homePage.LeaveWorkspace() removed redundant SelectWorkspace call - admingSettings.EnableGAC() - added dynamic checks - featureFlagIntercept - removed static sleep, reload check improved - agHelper.VisitNAssert() - removed static sleep - homePage.OpenMembersPageForWorkspace() - removed sleep, added dynamic checks #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Refactor - Enhanced Cypress test commands across multiple test suites for improved efficiency and readability. - Refactored conditional checks and method invocations for better test scenario handling. - Tests - Updated testing approaches for application deployment, workspace management, and error handling. - Introduced new assertions for UI visibility and functional behavior in automated tests. - Chores - Optimized GitHub Actions workflow by adjusting the matrix count for build processes. - Added new test specs for limited tests in the client-side regression suite. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-01 16:42:53 +05:30
Ashok Kumar M	6765888eb0	chore: Anvil cypress tests (#30580 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In this pr we are writing tests to validate a few preliminary cases of the Anvil Editor. the purpose of the task is to be able to run anvil tests along side the present suite of test cases. Things to note for Anvil based test cases - ANVIL_EDITOR_TEST tag is used for Anvil based tests to make sure relevant feature flags are set(using featureFlagIntercept) before creating pages so that Anvil pages are created. - each test case in a Anvil spec file also use featureFlagIntercept to set the relevant flags since pages are reloded before running tests. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Anvil editor with the ability to test app navigation, drag and drop functionality, and suggested widgets feature. - Improved accessibility and interaction capabilities within the Anvil canvas. - Tests - Added comprehensive end-to-end tests for new Anvil editor features, including app navigation settings, widget drag and drop, and suggested widgets integration. - Refactor - Introduced new constants and locators for better test structure and readability. - Style - Updated components with new attributes for improved accessibility and testing. - Chores - Added new tags for organizing tests related to the Anvil editor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-31 11:02:38 +05:30
Vemparala Surya Vamsi	ad68825818	feat: Frontend changes for consolidated-api with EE test case support (#30506 )	2024-01-24 12:14:16 +05:30
Rahul Barwal	cfb6c99196	chore: Add cypress specs for partial import and export functionality (#30166 ) ## Description This pull request adds partial import and export tests to the application. It includes the following changes: - Adds exported file to be used in partial import export tests - Add export and import options to EntityExplorer - Adds spec to test export functionality. - Add PartialImportExportLocators.ts, EntityCheckboxSelector.tsx, JSExportedOnly.json, and index.tsx - Add test for partial export functionality for selected datasources - Adds test to check all exported sections one by one - Refactor partial export functionality tests - Refactor export and import locators - Add test for partial import functionality #### PR fixes following issue(s) Fixes #30029 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced partial export and import functionality for components such as JavaScript objects, queries, widgets, and data sources. - Enhanced Entity Explorer with new "Export" and "Import" actions. - Tests - Added test cases for validating partial export and import features. - Updated test suite to include direct app level import with data sources. - Refactor - Modified access level for the `uploadFile` property in the HomePage class to facilitate testing. - Style - Updated UI components with test identifiers to improve testability. - Chores - Updated the list of tests for running limited test scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2024-01-17 11:20:01 +05:30
Vemparala Surya Vamsi	8bb61d996a	chore: reverted consolidated api (#30314 ) ## Description Reverted consolidated api changes and also some CE related changes to make it compatible with EE. #### PR fixes following issue(s) Reverts #29650 & #29939 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [x ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced the reliability and efficiency of Cypress e2e tests by adjusting wait conditions and assertions. - Simplified network request handling across various test cases. - Updated test logic to align with changes in application data structure and network requests. - Tests - Improved test stability for application import/export, Git sync, page load behavior, and widget interactions. - Refined mobile responsiveness tests to accurately validate layout conversions and autofill behaviors. - Chores - Removed deprecated feature flags and code related to consolidated page load functionality. - Cleaned up unused parameters and simplified action payloads in Redux actions. - Documentation - Updated comments for clarity in test specifications. - Style - Adjusted code styling for consistency across test suites. - Bug Fixes - Fixed data retrieval logic in tests to ensure correct data extraction from API responses. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-16 10:16:48 +05:30
Vemparala Surya Vamsi	96701c343d	feat: Frontend changes for consolidated-api (#29933 ) ## Description Our objective in this pr is to improve the page load time of our application by calling a consolidated-api which contains all the resources to load our pages. This PR contains all the client side changes to call the consolidated-api as well as feature flag related changes. Fixes #29650 & #29939 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated network request aliases and response handling in end-to-end tests. - New Features - Introduced a new API class `ConsolidatedPageLoadApi` for fetching consolidated page load data. - Tests - Enhanced testing for application URL navigation and data retrieval. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-15 10:00:29 +05:30
albinAppsmith	9bbf13debe	feat: enabled editor pane sidebar (#29882 ) ## Description This PR fixes the cypress failures introduced after editor pane #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29881 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Hetu Nandu <hetunandu@gmail.com>	2024-01-12 20:13:58 +05:30
Aishwarya-U-R	39ebef39a5	test: Cypress \| Replace static with Dynamic checks (#29664 ) ## Description - This PR removed static wait from spec - API_with_List_Widget_spec - Git/GitSync/GitSyncedApps_spec.js (fixes for EE flakyness - WIP - still failing in chrome, pass in electron) - Remove wait from OpenPaneAndChangeThemeColors() & added n/w check - Upgrading Cypress from 13.3 to 13.6 - Flaky fix: - ClientSide/Widgets/Text/Text2_Spec.ts - ClientSide/Widgets/Select/Select2_Spec.ts - cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts - /ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced Git synchronization capabilities with improved user interface interactions. - Streamlined navigation back to the editor from deployment mode. - Implemented more robust table loading checks to ensure data is properly displayed. - Bug Fixes - Fixed issues with element presence assertions to improve test reliability. - Addressed the visibility of certain UI elements to ensure they appear as expected. - Tests - Updated end-to-end test scripts to reflect new interactions and assertions. - Added a new test file `GitSyncedApps_spec.js` to cover Git-synced applications. - Removed outdated test file `Fork_Template_spec.js`. - Refactor - Improved method calls for querying and interacting with elements to enhance test stability. - Optimized wait conditions for element visibility to reduce flakiness in tests. - Chores - Adjusted the GitHub Actions workflow for client-server build to refine output for matrix counts. - Updated CI test workflow to incorporate Electron setup and remove Chrome setup steps. - Documentation - Included comments to explain the rationale behind certain timeout values and method changes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-22 17:20:05 +05:30
Aishwarya-U-R	fe3863eb65	test: Cypress \| Replace static with Dynamic waits - Part 1 (#29405 ) ## Description - Removed hard waits from below specs: - Apps/CurrencyInputIssue_Spec.js - ClientSide/Widgets/Modal/Modal_spec.ts (Fix & unskip) - /Binding/TableV2_Widget_API_Pagination_spec.js - Unskip - ApiTests/API_Unique_name_spec.js - Flaky fix - TableV2_Widget_API_Pagination_spec.js - Flaky fix - /ServerSide/QueryPane/S3_1_spec.js - Removed empty ReusableHelper.ts - Improved agHelper.GetElement() to include the assertion for element presence/absence - Modified helpers/function calls to fit the above syntax of GetElement() - Improved WaitUntilEleAppear(), WaitUntilEleDisappear() to use timeout from cypress config #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Tests - Enhanced end-to-end test stability by replacing static waits with dynamic element-based synchronization. - Skipped certain test suites to streamline the testing process. - Improved test assertions and control flow for more reliable verification of UI components. - Chores - Updated test helper methods to support new verification strategies. - Cleaned up unnecessary imports and inheritance in test support classes. - Documentation - Adjusted test case descriptions to reflect the new synchronization methods used. - Bug Fixes - Fixed issues with test synchronization that could lead to flaky test results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-11 14:39:36 +05:30
Hetu Nandu	a99bd1a1a1	chore: Remove back button (#29312 ) ## Description Removes the back button from Editor screen other than the canvas. With the new IA, this would not be needed #### PR fixes following issue(s) Fixes #29306 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced end-to-end test suites for Autocomplete, Git Sync, and IDE functionalities with improved UI interaction logic. - Introduced wait times in tests to better handle asynchronous UI updates. - Refactor - Streamlined navigation in the editor by replacing direct UI interactions with dedicated navigation methods. - Removed redundant code and improved the clarity of test scenarios. - Chores - Updated common locators by removing unused selectors to simplify test codebase. - New Features - Implemented feature flags to conditionally enable new UI components, providing a more tailored user experience. - Documentation - Updated internal documentation to reflect changes in test suites and feature flag usage. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-09 07:17:23 +05:30

1 2 3 4 5

217 Commits