Commit Graph

383 Commits

Author SHA1 Message Date
devrk96
f6bb16a4e6
Fix: Invalid email error in invite modal (#1368)
* Invalid email error showing on entering incorrect email before submission

* error state name corrected

* colon removed from error message
2020-10-29 16:47:52 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356)
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
2020-10-29 16:44:39 +05:30
Trisha Anand
fc9ea45e3b
[API breaking change : Automated Tests Will Fail] Page And Action Refactor (#549)
* Introduced new page which stores the published and unpublished pages as separate.

* Mid level commit to save the state.

* Parity of new page repository with old page repository (custom functions)

* WIP : Delete a page. This requires changes across application structure as well.

* Added publishedPages construct inside application to store the pages in the deployed view as well as isDefault so that the same changes (delete or isDefault) in unpublished view doesn't alter these fields for the published application

* Parity reached with PageService.

* Minor ActionService refactor to remove unnecessary code.
ApplicationPageService, LayoutActionService, LayoutService use the new page service to fetch the pages
Minor corrections in fetching the page from new page service in tests

* New save function which sets the PageDTO for unpublished page and then saves the new page into repository.

* Migration of page service functions to new page service functions across other services/tests/controller

* Finished migrating all the page service functions to the new page service functions

* Application Service Tests have been fixed.

* All the existing test cases are working now.

* Publish application implemented to store published pages as well. Added a basic test case to check that published pages is being set and that page's publishedPageDTO is being set accordingly.

* Minor TODOs added to add test cases for published application.

* A few tests to ascertain that published application page fields (deleted, isDefault) does not get changed when these statuses are changed for a page in edit mode.

* Added a new controller end point to fetch application in view mode.

* Added new endpoint for fetching an application in view mode on the client.

* Bug fix where get application in view mode API was not getting called.

* Fixed the get page names by application & archive pages which have been deleted in edit mode during publishing of application.

* During delete page, if a page was never published and it was deleted during edit, delete the entire page instead of just deleting the unpublished PageDTO

* Minor formatting.

* Non working client side code to fetch page list using view mode.

* revert unnecassary changes and streamlined view and edit actions

* Fix missed import

* Fixed a bug where if a page is not published, it should not be returned in view mode in list of page names api.

* Fixed update for a page which was not working in integration test.

* ActionDTO added.

* Solidified the new action structure.

* Migration added for NewAction index creation and NewAction per Action insertion in the database.

* Basic file structure added the new repository, custom repository, service, etc.

* Delete OldPage.java

* Repo functions added - TODO : Haven;t handled the published/edited views

* Helper functions added to convert Action to NewAction and vice-versa. Removed unused currentUserMono usage.

* Create & update action functionality added.

* Execute Action refactored. Removed dry run specific code.

* Repository migrated to handle new data structure. Execute action refactored to no longer support dry runs of actions.

* TODO added for special handling of change view of application to handle edge cases of pages/actions which either exist in published mode but don't exist in unpublished mode or vice versa.

* Migrated finding on load actions from spring repository to custom repository.

* In view mode, now actions are being fetched by application id directly instead of first fetching application and then using the page ids, fetching the actions. This reduces the db calls from 2 to 1 per fetch actions in view mode api call.

* Delete action and get all actions (used in edit mode on the client side) implemented.

* Updated CollectionService and ActionCollectionService to use the new action service instead of the old one.

* LayoutActionService refactored to now use the new service functions.

* ActionController now no longer used ActionService. The remaining service functions have been migrated to the new action service.

* Refactor across ACL code for addition/removal of policies during addition/removal of users to organization, making app public, refactor for services like policy utils, item service, etc.

* Removed the last of action repository and action service and replaced with new action repo and new action service.

* Compile and run time issues fixed. The server is coming up without any spring dependency errors.

* WIP in fixing fetching actions by page id.

* Finally!!! Fixed the fetch actions (both published and unpublished actions) by page id repository function.

* Fixed create action bug where null datasource in published actiondto (inside newly created action) leads to error.

* Fixed the execute action issues :
1. Removed the dry runs from the tests
2. Fixed the null pointer error in variable substituted action and datasource configurations.

* 1. Fixed the custom action repository field names.
2. Fixed the data structures used in ExamplesOrganizationClonerTests

* Fixed countByDatasourceId repository function which was querying the actions incorrectly.

* Fixed the clone example organization error where the id of the action was not getting updated in the page correctly. Yay!

* Fixed post merge compilation failure.

* Fixed more compilation time failures in ActionServiceTest

* Fixed failing test case for fetching actions in view mode.

* Minor changes to resolve merge changes and incorporate in the new refactored code.

* 1. Fixed compile time errors on Client code.
2. Fixed fetching of actions in view mode by application id. The repository function did not need name parameter. Removed the same.

* [Integration Testing Error Fix] : Added a new test case for refactor action name.

* Instead of fetching actions in the page, mistakenly used the base service which was fetching all the actions in the repository, barring none which led to the name refactor being blocked even though no action in the current page exists with the new proposed name,

* Added delete functionality to action service.

* Minor code cleanup

* Adding viewMode to action execution

* Replacing action with actionId.

* 1. Bug fix for deletion of unpublished action. In case of never published action, the entire action should be deleted. In case an action was published, only the unpublished action should be deleted.
2. In case of DB actions (external datasources), only the bare minimum fields should be stored inside the action (datasource id and datasource plugin id). The other fields should not be duplicated across code.

* Fixed yarn build compilation issues.

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ActionController.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Changed the API path for GET applications in view mode. Some minor code formatting.

* Incorporated review comments.

* Some more unnecessary code removed.

* Instead of returning Page, now the interface object between client and server for Pages is PageDTO

* Migrated Page and Action to PageDTO and ActionDTO
Fixed the compilation issues.
TODO : Fix the test compilation issues.

* Fixed compilation time issues with all the tests by migrating Page and Action to PageDTO and ActionDTO respectively

* Action Controller and Page Controller no longer extend Base Controller. All the required functions have now been implemented and no base line API end points are being re-used from the base.

* Test case fixes.

* Bug Fix : Updating an action was not updating execute on load. Fixed the data flow leading to the error.

* Deprecating Page and Action domain objects. This is to ensure no new code is written with these till we remove this old code.

* Cloned example applications are now published before returning. This is to ensure that the applications are in ready to view mode when the new user signs up.

* Added a function comment to expand on the usage of new param introduced.

* When cloning a page, new actions were not being stored. Added that. Also updated the clonePage test to assert that the actions are also cloned when the pages are cloned.

* Updated a Api call

* removed extra slash

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
2020-10-26 18:04:23 +05:30
Hetu Nandu
f4d9277950
Fix this (#1379) 2020-10-23 23:32:59 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
Nikhil Nandagopal
5b35d93374 Merge branch 'master' into release 2020-10-20 15:34:01 +05:30
Nikhil Nandagopal
8a97f25b1d
Fix/example apps (#1315)
* added signup for public apps that are not example apps

* minor fix
2020-10-20 15:33:21 +05:30
akash-codemonk
6a2a36aadb
Update application card colors (#1288) 2020-10-20 14:31:54 +05:30
akash-codemonk
380da11ef0
Query home page with datasource information (#1237) 2020-10-20 14:30:02 +05:30
Lois Harris
2e6ba8d8fd
[#1136] Fix the Appsmith logo click href (#1255)
Fixes: #1136
2020-10-19 19:04:55 +05:30
akash-codemonk
47847cbc7c
Add widget cta in query pane (#1157) 2020-10-15 12:51:00 +05:30
devrk96
539253f17e
Feature: Create new-app flow (#926)
* create new app flow

* uncontrolled component error fixed

* loader added when user is deleting or user role is updating

* home page loader and create-new-app loader added

* user role changing and use deleting state fixed

* PR feeback changes added

* orgname loader added

* warnings removed

* fixed create-new-app flow and delete app test cases

* beforeAll test case condition fixed

* Initial navigation condition fixed in createOrg test cases

* app card loading state fixed
2020-10-14 16:05:19 +05:30
Nikhil Nandagopal
c550e9202f Merge branch 'master' into release 2020-10-12 19:08:23 +05:30
akash-codemonk
25285033d6
Feat/add query flow (#1146)
* Add datasource connected page

* Default to show connected screen in datasource editor

* Update UI

* Fixes

- Change text from connected to saved
- Show key with empty values if there are no values
- After creating a new datasource go to edit mode

* Stop calling test on save

* Fix tests

* Fix test

* Dummy commit

* Always be in view mode unless clicked on edit mode

* Fixes

- Update datasource connected page for rest api datasource
- Fix empty array values not resetting

* Fix create new api crashing

- While creating new datasource show form in edit mode

* Fix tests
2020-10-12 19:07:18 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
satbir121
8bf80fe507
Google Recaptcha integration for button and form button widgets. (#1118)
* Adding base code for google re-captcha.

* Removing recaptcha as well

* Adding recaptchaToken on Button.

* Fixing updateMetaProperty errors.

* Handling recaptcha generation failed case.

* Adding a message for recaptcha token gen fail

* Rename setRecaptchaToken

* Adding loading state for recaptcha button

* Adding googleRecaptchaKey as a Btn prop

* Adding the bound functions in widgets

* Removing unused vars.

* Handling google recaptcha key error.

* Adding proper messages for
2020-10-12 18:31:19 +05:30
satbir121
1cafe307d5
Feature/invitation modal (#938)
* light and dark mode added in Invite modal

* warnings removed

* create org and invite user test cases fixed

* Application invite design implemented

* manage user icon added

* button width fixed

* PR feedback implemented

* test cases fixed

* used blueprint classes

* used calc for width distribution

* copy button width fixed

* prop passing fixed

* copy button size reduced

* readonly input field background color fixed

* input background theme name ordering changed

* TagInputComponent moved to ads

* created DropdownWrapper for select field in orgInviteForm

* Warnings created due to unique key and depdencies is fixed

* Warning fixed in dropdown component

* correct prop name used

Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
2020-10-12 12:45:35 +05:30
akash-codemonk
a229f68654
Show datasource structure fixes (#1078) 2020-10-09 18:54:50 +05:30
Yash Joshi
3bd342a848
Fix active styles for checkbox & radio (#1061)
Fixes: #994
2020-10-07 13:11:08 +05:30
satbir121
93a1dc7f87
Revert "Feature: Invite modal (#927)" (#1017)
This reverts commit 63daf74a44.
2020-10-06 11:32:43 +05:30
devrk96
63daf74a44
Feature: Invite modal (#927)
* light and dark mode added in Invite modal

* warnings removed

* create org and invite user test cases fixed

* Application invite design implemented

* manage user icon added

* button width fixed

* PR feedback implemented
2020-10-05 14:05:05 +05:30
akash-codemonk
90438b117b
Add option to refresh datasource structure (#686) 2020-09-29 09:47:25 +05:30
satbir121
0991595b25
Fixix merge issue with ShadeColor (#757) 2020-09-28 11:08:44 +05:30
Nikhil Nandagopal
3fdd0a246a
Feature/instrumentation (#744)
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods

* added use effect to stop tracking on mount of entity properties

* removed open api tracking

* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount

* added tracking for entity explorer

* moved from app route to sentry app route because passing JSX to app route causes re-renders

* Fixing theme and route change issues.

* added performance tracking for API / Query execution and Page Load actions

* added isntrumentation to open / close actions

* added instrumentation for apis & actions

* reduced sample rate
added async tracking

* added tracking for property pane

* Remove tracking from reducer

* added option to attach async operations to parent transactions

* Fix typo

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-28 10:42:23 +05:30
devrk96
dc1e2e124f
Fix: Light mode bugs (#724)
* light mode bugs resolved

* dark and light color type name is renamed

* useCallback added in editableText
2020-09-28 10:36:06 +05:30
devrk96
03e658d3b6
user name added in profile dropdown (#736) 2020-09-26 18:52:15 +05:30
satbir121
15f84203c7
Video widget (#684)
* Working version of video player.

* Adding default video url

* Reducing the default widget of video widget

* Fixed tests

* Adding video icon.

* Removing commented code.

* Adding playState, onPause, onStart, onEnd.

* Adding onPlay event.

* Fixing onPlay

* Adding isVisible field.

* Changing video icon.

* Fixing Popover table video.

* Adding an error message for no url.
2020-09-26 18:29:33 +05:30
devrk96
028070eeb2
Feature: Variable addition in light and dark theme (#677)
* variables defined in light and dark constants in theme.

* warning message removed

* Fixing create app btn click opening form

* blackShades removed and icon color in application card fixed

* state change fixed

* type of light and dark constants added

Co-authored-by: Satbir Singh <satbir121@gmail.com>
2020-09-23 19:36:50 +05:30
Satbir Singh
aab56496c9 Adding type and app background 2020-09-21 18:55:58 +05:30
akash-codemonk
8b668484ad
Feat/database structure (#525)
Datasource structure ui
2020-09-21 14:41:42 +05:30
Abhinav Jha
0b87c7431b
Fix issue where tabs are lost when the user enters an invalid tabs value (#569) 2020-09-18 10:52:54 +05:30
satbir121
b9154f6ea9
Homepage redesign with themes (#482)
* Updating homepage body color

* WIP: Fixing scrolls and adding anchors

* Removing divider from bottom of the page.

* Adding hover background color to app card

* Changing edit and launch icons.

* Fixing app name paddding in card.

* Fixing workspaces overflow

* Adding right padding to applications view

* Adding share icon to share btn

* Fixing Application card styles.

* Fixing text decoration in button.

* Adding new workspace button

* Fixing new workspace and new app styles.

* Adding icon sizes.

* Fixing Org Name and Org settings menu.

* Application menu working

* Fixing overlay visibility on app card

* Fixing settings page content width.

* Fixing workspace icon

* Changing app card colors.

* Removing debugger

* Adding app icon.

* Fixing the spaces in application card

* Adding storybook-static folder to gitignore.

* Adding other storybook files.

* Adding menu items for app

* Removing cypress selector from text.

* Menu width issue fixed

* Default app icon color added

* Removing hardcoded colors

* Removing hardcoded colors.

* Light Mode on!

* Showing correct icon and color in menu

* Update color working properly.

* Updating appIcon

* Editable text working.

* Adding validator

* Adding edit permissions to menu

* Removing box shadow on app card.

* Fixing context menu fill color

* Fixing Menu hover issues.

* Fixing menu open close hover issues.

* Fixing settings pages

* Changed Workspace to org.

* Fix: State management in EditableText Component (#540)

* Error state height is fixed as per design

* savingState prop condition fixed

* Fixing createnew.

* Fixing saving state for application card.

* Fixed application card editable text error.

* Fixing issue caused during merge.

* Fixing tests in create org.

* Removing commented code.

* Removing unwanted vars.

* Fixing delete duplicate tests.

* Latest color palette.

* Fixing form and table widget.

* Removing switcher from header

* Removing unused files

* Fixing app card context dropdown

* Show overlay fix

* Adding localStorage support to theme.

* Making dark mode the default.

Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
2020-09-16 17:20:47 +05:30
Abhinav Jha
436f190555
Feature: Widgets: Cut-Copy-Paste-Delete shortcuts, undo-delete facility (#500) 2020-09-16 15:58:01 +05:30
devrk96
3f9d2e8d8d
Feature: Callout component (#535)
* callout component with story implemented

* text className import fixed

* callout color and background color fixed

* storywrapper import fixed

* fill property fixed

* background prop added
2020-09-15 12:40:53 +05:30
akash-codemonk
1701df82c3
Add remaining moment defs (#537) 2020-09-12 11:54:20 +05:30
Nikhil Nandagopal
c421ab12b1
removed duplicate user object (#513)
removed id field which is never populated
added help modal in applications page and intercom to load in help modal
shutdown intercom on signout to clear existing chats

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-09 10:48:36 +05:30
devrk96
34ff72b505
Feature: Radio group component (#481)
* Radio group component with story implemented

* radio group implemented using native input and label.

* radio component height fixed in story

* disabled name in theme corrected for radio

* align prop removed
2020-09-09 08:48:54 +05:30
akash-codemonk
7271cd0a7a
Add few ternjs defs for moment (#508) 2020-09-08 14:13:46 +05:30
Abhinav Jha
70fea0e560
Feature: Add widgets from explorer (#464)
* Deprecate Navbar. Sidebar becomes a panelStack. It now has two panels, WidgetSidebar and Explorer

Co-authored-by: Nandan <nandan@thinkify.io>
2020-09-02 12:14:01 +05:30
akash-codemonk
aa068e3596
Add duplicate application option (#465) 2020-09-01 12:46:54 +05:30
devrk96
f562ecf159
Feature-Icon enum added and size updated. (#463)
* appIcon color, icon enums and size fixed

* icon import updated
2020-08-31 10:29:18 +05:30
satbir121
e2b939416a
Members and org settings page (#424)
* Members and org settings page.

* Adding link back to applications

* Making UI look better.

* Fixing some more css

* Table dropdown onBlur, UI transparency, Popover issue fixed. Added sort arrow (#413)

* table dropdown ui issue and onblur click fixed

* position props value fixed

* tabs tripple click fixed

* Position props in table dropdown made optional

* tabs background color bug removed

* General settings page is bug free.

* Getting the manage users page to work.

* Moving general settings into its own file.

* Removing some unwanted URLs

* User cant change their role or remove themselves

* Changing onClick prop for Icon.

* Fixing tests

* Added loading states to text inputs.

* Added validators for text input

* Fixed border of skeleton for text input

* Adding a loader for Members screen

* Adding Noop to icon button

* Removing console.log

* Fixing imports.

* Moving org reducer to immer.

* Using utils email validator.

* Removing placeholder from text input props.

Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
2020-08-29 00:21:16 +05:30
devrk96
241eff7d55
Menu component (#358)
* menu component implemented and tabs selected ui bug fixed

* PR comments resolved

* icon import updated

* Menu item component (#437)

* Adding blank components.

* Adding Todo note for tree

* Adding todo note for LighteningMenu

* ads button component

* Adding storybook support.

* storybook integrated with button component

* ads button component props completed

* button component icon and loading logic implemented

* button component completed

* Added a text knob.

* Adding default text for button.

* Merging theme and other fixes.

* Fixed info button.

* Better types.

* Adding background param to components.

* Re-using vsariant for callount.

* Added props for Text input.

* Adding text component.

* feedback changes added in button and icon component

* type any removed in button component

* function naming corrected

* menu component implemented

* menu-item implemented with text, icon and label

* menu story updated with menu-items

* menu story updated

* storyWrapper added in all stories

* ads text removed

* spinner import updated

* relative import added

Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: satbir121 <39981226+satbir121@users.noreply.github.com>

Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: satbir121 <39981226+satbir121@users.noreply.github.com>
2020-08-28 16:21:41 +05:30
vicky-primathon
8a0805d77f
Fix: Table widget actions header scrollbar padding (#353)
* Table header scrollbar padding removed. 
* Table row font size changed based on compact mode.
2020-08-28 15:25:20 +05:30
akash-codemonk
dbfd986d0e
Add action settings tab to api and query pane (#434)
* Add action settings tab to api and query pane

- Ask for confirmation before running an action

* Update  property of actions basedon the updateLayout response

Prevent confirmation dialog for Action run, until  property of action is true

Send an API Request when the user toggles the  property of an Action

* update http method to toggle executeOnLoad for an action to PUT

* Fix save layout response type

* Remove console.log

* If updating executeOnLoad, avoid calling update action API

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2020-08-27 21:09:16 +05:30
akash-codemonk
4f8a3b5968
Save datasource name on change (#373) 2020-08-26 10:54:44 +05:30
Hetu Nandu
4873ac3421
Local store via Datatree (#367) 2020-08-24 17:39:17 +05:30
akash-codemonk
3deb9ace43
Add clone page option (#365)
Adding the option to clone a page in the overflow menu of the entity explorer
2020-08-22 08:40:22 +05:30
Hetu Nandu
c658769b1b
Style polish (#371)
* Rotate Fork app icon
* Change Explorer divider color
* Fix favicon not accessible
* Rename `appsmith.url` to `appsmith.URL`
* AppView page tab overflow ellipsis
* Rename `Back to editor` button to `Edit App`
* Update App card colors
2020-08-20 20:47:20 +05:30
vicky-primathon
17af152148
Table Widget: Filter updates (#355)
- Show symbol signifying selected filters in table widget
- Show callout to prompt users to change column data types for accurate filter operations
2020-08-20 15:00:19 +05:30