Commit Graph

1808 Commits

Author SHA1 Message Date
Abhijeet
efc303e760
chore: Update the build process to refer the Appsmith version from the info.json in all build artifacts (#29903)
Fixes #29623

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2024-01-12 19:44:58 +05:30
Goutham Pratapa
d77c1ab110
fix: missing psql client error in ci (#30279) 2024-01-12 17:28:35 +05:30
Aishwarya-U-R
7a18d4ac4c
test: Cypress | Flaky fixes + Replacing static waits (#30067)
## Description
- This PR includes the flaky fixes of the below specs:
- jsEditor.NavigateToNewJSEditor() using TS helpers (Addressing
flakyness in specs /BugTests/JS_Bug29131_spec.ts,
BugTests/invalidLintError_Spec.ts,
ClientSide/BugTests/JS_Bug28764_Spec.ts,
/ClientSide/BugTests/Bug29566_Spec.ts,
ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts)
- /Widgets/ListV2/Listv2_onItemClick_spec.js (toast validation updated
to ts helper)
           - /Apps/MongoDBShoppingCart_spec.ts (Flaky fix 2nd case)
           - /Regression/Apps/PromisesApp_spec.js (1st test)
- /ClientSide/OtherUIFeatures/ApplicationURL_spec.js (whole spec for
static wait removal + flaky fixes)
- /ClientSide/Templates/Fork_Template_spec.js (complete spec fixes,
cypress exception fix)
           - /Sanity/Datasources/Arango_Basic_Spec.ts (3rd test)
- /ServerSide/OnLoadTests/JSOnLoad2_Spec.ts (8th case flaky fix)
- /ClientSide/MobileResponsiveTests/AutoFillWidgets_Reflow_spec.ts (2nd
testcase, flow update)
           - /ClientSide/OtherUIFeatures/Resize_spec.js (import update)
- /ClientSide/Templates/Fork_Template_spec.js (1st & 3rd for flaky fix,
removed 2nd - redundant check)
- /Git/GitSync/RepoLimitExceededErrorModal_spec.js flaky fix for EE repo
failure
- /ServerSide/ApiTests/API_Bugs_Spec.js (3rd case, removed waits, moved
to TED Api)
           - /Apps/EchoApiCMS_spec.js (removed redundant action)
- /AppNavigation/Sidebar_spec.ts, /AppNavigation/TopInline_spec.ts,
/AppNavigation/TopStacked_spec.ts - added refresh calls for CI flakyness
- homePage.RenameWorkspace() & homePage.NavigateToHome() &
homePage.Signout() - removed static wait, added dynamic check
- homePage.CreateNewApplication() - removed static wait
- homePage.CreateAppInWorkspace() - removed commented code
- homePage.CreateNewWorkspace() - logic improved
- agHelper.AssertURL() - added timeout, removed static wait, calling
assertHelper.AssertDocumentReady()
- Few of agHelper methods timeout & error mesg text update
- cy.Signup() - updated validations
- agHelper.CheckForErrorToast() to agHelper.FailIfErrorToast() - method
name
- /ClientSide/BugTests/DSDiscardBugs_spec.ts - removed unnecessary
method call

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after all changes were reviewed

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Enhanced timeout handling across various helper methods for improved
stability.
- Streamlined interactions with UI elements using updated helper
methods.
- Adjusted test suites to utilize configuration values for consistency.

- **Tests**
  - Temporarily disabled specific test suites to address current issues.
- Updated test assertions and interaction patterns for clarity and
reliability.
- Added new test cases and assertions to cover additional
functionalities.

- **Chores**
  - Updated workflow variables for more efficient CI processes.
- Curated the list of limited tests to focus on critical test scenarios.

- **Documentation**
  - Clarified test descriptions and intentions for better understanding.

- **Bug Fixes**
- Fixed UI element interactions to prevent test flakiness and improve
user experience.
- Implemented page refresh before application imports to ensure clean
state for tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-12 12:00:12 +05:30
Goutham Pratapa
5d8b1b6e1b
fix: failing ci with psql not found (#30207)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated GitHub workflow to include PostgreSQL client installation
steps.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-10 18:29:14 +05:30
Saroj
88eaa666cd
ci: Schedule TBP workflow to run 4 times a day with 3hrs interval (#30081)
## Description
- Scheduled TBP workflow to run 4 times a day with 3hrs interval
- Made changes in TBP workflow to run all the steps only while running
with schedule or manual workflow trigger
- Added condition to run ci-test and ci-test-result only during schedule
or manual workflow run.

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- [x] CI Run
>
>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated the workflow schedule for Docker image build tests to run at
new times: 7:00 AM, 10:00 AM, 1:00 PM, and 4:00 PM IST on weekdays.
- Modified conditional triggers in the CI pipeline to exclude jobs from
running on push events.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-09 16:22:38 +05:30
sharanya-appsmith
168a7de7e1
ci: added suggestion message on using @tag.All (#30092)
## Description
> Added: **step** - Add suggestion in the PR on using @tag.All in
workflow `.github/workflows/integration-tests-command.yml`
> This will post a comment in the PR to use specific tags.


#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> tested with tbp 

#### How Has This Been Tested?
- [ ] Manual

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Integration tests now suggest using specific tags for more efficient
testing.
- Docker image build tests prompt for using `@tag.All` when appropriate,
with a link to documentation for guidance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-08 15:47:31 +05:30
yatinappsmith
ea62d75811
CI: fix server test rerun (#30089)
fix server test rerun

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated workflow to ensure test extraction step runs when certain
tests fail.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-08 15:40:50 +05:30
Nikhil Nandagopal
f11ba0b9c1 Updated Label Config 2024-01-08 11:42:43 +05:30
Nikhil Nandagopal
1927a32a88 Updated Label Config 2024-01-08 11:34:13 +05:30
sharanya-appsmith
f5578c1e50
ci: Added step to check if @tag.All is given as expected. (#29926)
## Description
> Added step to check if @tag.All mentioned is as expected, if not throw
a message to use `/ok-to-test tags="@tag.All"` and exit the run


#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> TBP with tags 

#### How Has This Been Tested?
- [x] Manual
- [x] TBP
>

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

The existing bullet-point list is still valid and does not need to be
updated.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-05 18:11:01 +05:30
Nikhil Nandagopal
05bcedf205 Updated Label Config 2024-01-05 12:18:17 +05:30
Nikhil Nandagopal
80bed14799 Updated Label Config 2024-01-05 12:14:55 +05:30
Nikhil Nandagopal
b7f76baf71 Updated Label Config 2024-01-05 12:12:01 +05:30
yatinappsmith
b1e8c1a6e5
CI: fix empty commit failures for server build (#29997)
fix empty commit failures for server build

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the server build workflow to allow commits with empty
messages.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-03 13:27:35 +05:30
Hetu Nandu
4d9fccf267
Update --task.yaml (#29920)
Updates the "Task" issue template

- Removes the required input of "Have you searched for similar issues?"
- Makes the tasks body a required input


Removing the "Have you searched for similar issues?" because this
template is used mostly internally for incremental issues towards a
project / epic and not used by the community

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated the issue template by removing the checkbox for checking
existing issues.
- Modified the 'SubTasks' field from a text area to a mandatory checkbox
list in the issue template.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-01-02 16:53:34 +05:30
yatinappsmith
7caf93d526
CI: Added restore cache from git for client build (#29938)
## Description
Added restore cache from git for client build
#### Type of change
- New feature (non-breaking change which adds functionality)
## Testing
Tested in local fork
#### How Has This Been Tested?

- [X] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
## Checklist:
#### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my
feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Optimized the client build workflow to trigger only on relevant
changes or specific events, ensuring resource-efficient operations.
- **Chores**
- Updated workflow conditions to improve the CI/CD process, enhancing
overall development efficiency.
- **Documentation**
- Provided triage instructions to streamline the handling of workflow
changes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-29 15:26:25 +05:30
yatinappsmith
c1491c6db7
CI: fix client cache sequence (#29911)
fix client cache sequence
2023-12-28 09:15:50 +05:30
yatinappsmith
1c5afeecc7
CI: Add Caching support for Client Build (#29884)
## Description
Add Caching support for Client Build
#### PR fixes following issue(s)

#### Type of change
- New feature (non-breaking change which adds functionality)
## Testing

#### How Has This Been Tested?
Tested in a fork
## Checklist:
#### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my
feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
  - Implemented caching for release builds to enhance performance.

- **Chores**
- Updated workflow to ensure successful status updates during build
processes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-28 09:03:14 +05:30
sharanya-appsmith
0ce1780595
test: Cypress - added @tag.excludeForAirgap, @tag.Templates tags (#29790)
## Description
> Added excludeForAirgap tgs 

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> running tbp
> /ok-to-test tags="@tag.excludeForAirgap" 

#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress
>
>

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Test Enhancements**
- Improved test descriptions and added relevant tags for better
categorization and filtering across various test suites.
- Consolidated test logic and descriptions for clarity and coherence in
test suites.

- **Bug Fixes**
- Updated test cases to reflect accurate scenarios for bugs and feature
testing.
- Adjusted test sequences and assertions for enhanced reliability and
coverage.

- **Refactor**
- Restructured test suites for a more logical flow and clearer
objectives.
- Enhanced test setup steps and assertions for comprehensive validation.

- **Chores**
- Implemented a new tagging functionality for organizing test suites and
cases.
  - Added new tags to the tagging system for improved test management.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-27 16:50:36 +05:30
yatinappsmith
eea43ffba5
CI : Added checks for scheduled changes (#29880)
Added checks for scheduled changes

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the workflow to trigger certain actions on a scheduled basis
as well as other specified events.

- **Documentation**
  - No changes in public API documentation required.

- **Chores**
  - Triage process remains unchanged.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-27 08:19:27 +05:30
Goutham Pratapa
e621376305
fix: failing client-build (#29878) 2023-12-26 22:34:04 +05:30
Goutham Pratapa
34f9267cbd
mv: client-build to self-hosted runners (#29877)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the build process to use a new self-hosted deployment runner
with enhanced resources.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-26 22:29:34 +05:30
yatinappsmith
df3f7da567
CI: Fix server cache (#29874)
Fix server cache
2023-12-26 18:53:06 +05:30
yatinappsmith
0b977c975e
ci: Improved the efficiency of the build process by only running server-related jobs when there are changes in the server folder (#29859)
## Description
added changes to skip server incase of no changes
#### PR fixes following issue(s)

#### Type of change

- New feature (non-breaking change which adds functionality)


## Checklist:
#### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my
feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Improved the efficiency of the build process by only running
server-related jobs when there are changes in the server folder.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-26 15:48:24 +05:30
sharanya-appsmith
1a40dee4cb
ci: changed cypress dashboard url (#29864)
## Description
> Changed the url from from 
>
`https://internal.appsmith.com/app/cypress-dashboard/rundetails-64ec3df0c632e24c00764938
`to`
https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5`

>
`https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-6541e22b0c243558fe2288ca?branch=master`
to
`https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master`

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated URLs for the Cypress dashboard in CI/CD workflows to ensure
accurate linking to test results and run details.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-26 15:41:42 +05:30
sharanya-appsmith
003dd7c2aa
ci: added client-unit-tests, server-unit-tests in package-master needs (#29844)
## Description
> Added client-unit-tests, server-unit-tests in package-master step


#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> running tbp on the branch 

#### How Has This Been Tested?
- [ ] TBP run

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the build process to require both client and server unit tests
to pass before packaging.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-26 10:12:21 +05:30
Shrikant Sharat Kandula
ae565a4d13
ci: Remove base image schedule trigger 2023-12-25 10:40:53 +05:30
Arpit Mohan
60e6ceed51
ci: Adding logging to debug ci-test-result (#29828)
Adding logs to debug ci-test-result

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
  - Improved error handling and logging in integration test workflows.

- **Documentation**
  - Fixed typographical error in the name of the test workflow.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-23 14:26:24 +05:30
Shrikant Sharat Kandula
3635677a5f
ci: Add workflow for Caddy routes test 2023-12-23 06:54:10 +05:30
Aishwarya-U-R
39ebef39a5
test: Cypress | Replace static with Dynamic checks (#29664)
## Description
- This PR removed static wait from spec - API_with_List_Widget_spec
- Git/GitSync/GitSyncedApps_spec.js (fixes for EE flakyness - WIP -
still failing in chrome, pass in electron)
- Remove wait from OpenPaneAndChangeThemeColors() & added n/w check
- Upgrading Cypress from 13.3 to 13.6
- Flaky fix:
      - ClientSide/Widgets/Text/Text2_Spec.ts
      - ClientSide/Widgets/Select/Select2_Spec.ts
      - cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts
      - /ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced Git synchronization capabilities with improved user interface
interactions.
  - Streamlined navigation back to the editor from deployment mode.
- Implemented more robust table loading checks to ensure data is
properly displayed.

- **Bug Fixes**
- Fixed issues with element presence assertions to improve test
reliability.
- Addressed the visibility of certain UI elements to ensure they appear
as expected.

- **Tests**
- Updated end-to-end test scripts to reflect new interactions and
assertions.
- Added a new test file `GitSyncedApps_spec.js` to cover Git-synced
applications.
  - Removed outdated test file `Fork_Template_spec.js`.

- **Refactor**
- Improved method calls for querying and interacting with elements to
enhance test stability.
- Optimized wait conditions for element visibility to reduce flakiness
in tests.

- **Chores**
- Adjusted the GitHub Actions workflow for client-server build to refine
output for matrix counts.
- Updated CI test workflow to incorporate Electron setup and remove
Chrome setup steps.

- **Documentation**
- Included comments to explain the rationale behind certain timeout
values and method changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-22 17:20:05 +05:30
Nikhil Nandagopal
6015999060 Updated Label Config 2023-12-22 17:06:09 +05:30
Nikhil Nandagopal
50bb4b8f32 Updated Label Config 2023-12-22 17:05:44 +05:30
Saroj
a24ec21a74
ci: Setup ci-test runner count based on tags defined (#29791)
## Description
- Added logic to handle the runner count based on the tags

#### Type of change
- Workflow files
## Testing
- Workflow run


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a `tag-check` job to validate the presence of tags in
workflow commands.
- Workflows now comment on PRs with documentation links for tags when
tags are missing.

- **Enhancements**
- Enhanced CI workflows to conditionally run jobs based on tag presence.
  - Added matrix inputs to improve job configuration flexibility.

- **Documentation**
- Added comments to PRs with links to workflow runs when tags are
specified.

- **Refactor**
- Centralized tag and matrix setup across multiple workflows for
consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-22 16:41:34 +05:30
Nikhil Nandagopal
66de8d7b00 Updated Label Config 2023-12-22 15:43:42 +05:30
Nikhil Nandagopal
b04240aced Updated Label Config 2023-12-22 15:43:10 +05:30
Nikhil Nandagopal
1eba03843c Updated Label Config 2023-12-22 15:43:02 +05:30
sharanya-appsmith
6911ae6f44
ci: added schedule event name in package-release and master steps (#29773)
## Description
> Added schedule event name in package-release and master steps to run
those on scheduled cron

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>  running tbp manually in the branch 

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
	- Updated workflow to trigger certain job steps on a scheduled basis.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-22 14:33:11 +05:30
yatinappsmith
b57fa957c2
CI: Server build cache (#29803)
Server build cache

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Improved the caching process for release builds to enhance the
efficiency of our deployment workflows.


<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-22 14:07:10 +05:30
yatinappsmith
52a5375455
CI: commented caching changes (#29787)
commented caching changes
2023-12-21 15:57:03 +05:30
yatinappsmith
4b6f826a9b
CI: fixed clone dir (#29783)
fixed clone dir
2023-12-21 15:41:41 +05:30
yatinappsmith
2e783f1f62
CI: fixed token (#29782)
fixed token
2023-12-21 15:35:00 +05:30
yatinappsmith
c902d1977a
CI: fix server build added missing quotes (#29780)
fix server build added missing quotes

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Improved the handling of user information in the automated server
build process to ensure compatibility with values containing spaces.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-21 15:23:44 +05:30
yatinappsmith
33b073dd30
CI: Added Cache for Server Build (#29775)
## Description
Added cache for server
#### PR fixes following issue(s)

#### Media

#### Type of change

- New feature (non-breaking change which adds functionality)

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Implemented caching for release builds to enhance efficiency and speed
up the deployment process.

- **Chores**
  - Updated build workflow with additional steps for caching operations.

- **Documentation**
- Confirmed no changes to public API documentation are needed as this
update does not alter exported entities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-21 14:57:05 +05:30
Shrikant Sharat Kandula
fa4388da81
ci: Remove unused APPSMITH_IS_SELF_HOSTED 2023-12-21 07:13:42 +05:30
Saroj
e2ec25bc7c
ci: Skip TBD for every push on release branch (#29732)
## Description
- Skipping TBD for every push on release branch
- TBD will run once a day on the scheduled cron
- People can still run TBD on-demand

#### Type of change
- Workflow Change

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated the CI/CD workflow to trigger Docker image builds on pushes to
the "master" branch instead of the "release" branch.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-19 18:49:39 +05:30
sharanya-appsmith
8d5b389f38
ci: added event_name schedule in client-build, rts-build, ci-test-custom-script to run them in scheduled run as well (#29724)
## Description
> added event_name schedule in client-build and rts-build to run them in
scheduled run as well

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
>
## Testing
> running TBP workflow to ensure nothing is impacted. 

#### How Has This Been Tested?
- [x] TBP Run


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Updated build workflows to trigger on scheduled events.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-19 16:10:06 +05:30
Saroj
cf53dbfb23
ci: Allow static split of cypress specs (#29653)
## Description
- Allowing static split of cypress specs in CI runs.
- Optimised the spec allocation by considering the duration history for
each spec.
- Updated the affecting workflows to utilise the static split

#### Type of change
- Workflows
- Cypress-split pugin
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new environment variable to optimize test resource
allocation during CI/CD processes.
- Enhanced Cypress testing with dynamic and static test splitting
strategies.

- **Refactor**
- Refactored Cypress plugin configuration to support conditional test
splitting based on the environment variable.

- **Chores**
- Updated GitHub Actions workflows to include new environment variables
for test runs.

- **Documentation**
- Updated internal documentation to reflect changes in test setup and
execution strategies.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-18 17:10:11 +05:30
sharanya-appsmith
3495346965
ci: Added cron at 6 am ist on tbp ce workflow (#29643)
## Description
> Added a cron job for the TBP workflow to run at 6 am on weekdays-
Daily Promotion analysis purpose

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
- To check if the workflow is triggered as expected 

#### How Has This Been Tested?
- [x] Manual


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-12-15 19:04:15 +05:30
Goutham Pratapa
e21583e8fa
skip running TBD for release (#29244) 2023-12-15 15:25:43 +05:30
Saroj
25508563fb
ci: Fix for the junit run-result cache saving issue (#29529)
## Description
Currently, when we run the server build without tests, we still try to
check the cache for run-result, but as the cache is not present during
the first run, where we just build the server, and on the success of the
workflow, actions/cache create the cache with the specified key,

Which is creating an issue while we try to save the actual run-result
cache when we run the tests in server-unit-tests.

Solution : 
- Added a condition to check the cache present only while running tests

#### Type of change
- Workflow changes (server-build.yml)
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the server build process to conditionally skip certain steps
based on user input.

- **Chores**
  - Improved automation in the build workflow to enhance efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-12 14:05:34 +05:30