ba4e29fb82
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Ankita Kinger
|
ba4e29fb82
|
fix: Updating admin settings logic to fix issues on EE (#40135)
## Description Updating admin settings logic to fix issues on EE Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14315577260> > Commit: 1b0c2823290e6af5849b096d640ac856964a0d4c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14315577260&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Mon, 07 Apr 2025 17:54:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Admin Settings now displays Profile and Organisation sections whenever available, independent of user privileges. - Updated category filtering ensures non-superusers see only the most relevant options. - Introduced a new locator for the sub-text link in Admin Settings to improve test coverage. - **Style** - Enhanced link presentation in the Admin Settings page for clearer navigation. - **Bug Fixes** - Simplified test logic for Admin settings, improving the reliability of test cases. - Ensured consistent boolean handling for user superuser status across various components. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ankita Kinger
|
e9cca6a56f
|
feat: Updating admin settings page as per new designs (#40101)
## Description Updating admin settings page as per new designs: https://www.figma.com/design/XouAwUQJKF2lf57bQvNM1e/Cloud-Billing-(-Phase-1-)?node-id=15907-10916&m=dev Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14302998753> > Commit: 259bdc292d08fd3f6cc4ffb2fce833b71c123d2e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14302998753&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Mon, 07 Apr 2025 07:33:30 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced an updated profile page for managing account details and profile images. - Expanded and restructured the Admin Settings with clear sections like Instance Settings, Configuration, User Management, Branding, and Profile. - Added new icons that enhance the visual experience. - Implemented a new styled component for conditional rendering of links in settings. - Added user settings for session management and Git configuration. - Enhanced test cases for Admin Settings to ensure proper navigation and functionality. - Introduced a new configuration for instance settings, allowing for detailed management options. - Added a new configuration for profile settings, enhancing user management capabilities. - Introduced a new configuration for email settings, reflecting organizational needs. - **Bug Fixes** - Revised the save button text to “Save Changes” and refined success notifications. - **Refactor** - Streamlined routing and configuration for a more intuitive and consistent Admin Settings experience. - Updated category management logic in the LeftPane component to focus on user management and organizational categories. - Modified the filtering logic in admin settings helpers for improved clarity and functionality. - Enhanced the overall structure of test cases for better organization and clarity. - **Style** - Updated header and layout styling for improved visual consistency. - Enhanced the visual presentation of the SettingsSubHeader component. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |