Pranay
b7b024a98c
docs: Updating contribution guidelines ( #18190 )
...
The contribution guidelines for documentation are outdated due to the recent migration. Here are the fixes/updates -
- Removed the following files from `contribution/docs/` -
- [CONTRIBUTING.md](https://github.com/appsmithorg/appsmith/blob/release/contributions/docs/CONTRIBUTING.md )
- [DB Integrations.md](https://github.com/appsmithorg/appsmith/blob/release/contributions/docs/DB%20Integrations.md )
- [UploadingAssets.md](https://github.com/appsmithorg/appsmith/blob/release/contributions/docs/UploadingAssets.md )
- [Widgets.md](https://github.com/appsmithorg/appsmith/blob/release/contributions/docs/Widgets.md )
- [adding_guides.md](https://github.com/appsmithorg/appsmith/blob/release/contributions/docs/adding_guides.md )
- Removed [Documentation Improvement](https://github.com/appsmithorg/appsmith/blob/release/.github/ISSUE_TEMPLATE/--documentation-improvement.yaml ) template as we have created [new templates](https://github.com/appsmithorg/appsmith-docs/issues/new/choose ) in the [appsmith-docs](https://github.com/appsmithorg/appsmith-docs ) repository.
- Updated the relevant links in the [Documentation Improvement](https://github.com/appsmithorg/appsmith/blob/release/CONTRIBUTING.md#-improve-the-documentation ) section ( template links and contribution guidelines for docs) of [CONTRIBUTING.md](https://github.com/appsmithorg/appsmith/blob/release/CONTRIBUTING.md ) file.
Co-authored-by: Pranay105 <pranaybhardwaj@Pranays-MacBook-Pro.local>
2022-11-23 11:41:40 +05:30
Appsmith Bot
224353743d
Update top contributors
2022-11-23 06:58:48 +05:30
Nikhil Nandagopal
3172d03186
Updated Label Config
2022-11-22 19:33:32 +05:30
Shrikant Sharat Kandula
4a43fcfdc3
Change path to load Segment
2022-11-22 16:02:55 +05:30
Appsmith Bot
22550d638a
Update top contributors
2022-11-22 06:59:34 +05:30
Nilesh Sarupriya
287311ee98
feat: set user permissions for js object ( #18077 )
2022-11-21 17:22:04 +05:30
Nilansh Bansal
a5ec8600b9
fix: Fixed error message mentioning the wrong resource type ( #18308 )
2022-11-21 15:55:30 +05:30
Shrikant Sharat Kandula
d96019cbb1
fix: Fix NPE if email in admin emails doesn't have a user ( #18222 )
...
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-11-21 14:14:42 +05:30
akash-codemonk
f669954873
chore: update omnibar to work with docusaurus site ( #18146 )
...
Fixes #17501
New index will be used once the algolia keys are updated https://github.com/appsmithorg/keys/pull/10
## Description
- Update algolia index name and keys.
- Removed [app/client/gitbook-algolia-lambda.js](https://github.com/appsmithorg/appsmith/pull/18146/files#diff-cd4ea8ae515ff25aaad99dc86059b65cc9b67edcde4eb261e1e456497b6957d3 ). It is being replaced by [website/omnibar-algolia-index.js](https://github.com/appsmithorg/appsmith-docs/pull/564/files#diff-a3f32686fd88fe5556e1dec268d0fa72ddd30a7ca05af48e2d55f1a811acd2c0 ).
- Fixes video and list styles of content shown in the omnibar.
- Videos on docs.appsmith.com are wrapped in a `videoembed` tag so have updated the regex for the same.
- Image urls also sometimes include algolia highlight tags which makes the url invalid have removed the same
https://github.com/appsmithorg/appsmith/pull/18146/files#diff-0e7cdbf77157af62f50ece962a8d4e381b2c070c2453123e8a713298f9640e25R126 .
- Docusaurus https://docusaurus.io/docs/markdown-features/admonitions have a different syntax have updated the regex to parse the same. https://github.com/appsmithorg/appsmith/pull/18146/files#diff-0e7cdbf77157af62f50ece962a8d4e381b2c070c2453123e8a713298f9640e25R154
TLDR
Make omnibar work with the new docs site.
## How Has This Been Tested?
- Manual
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
https://github.com/appsmithorg/appsmith/issues/17501#issuecomment-1307043824
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-11-21 08:25:33 +00:00
Ravi Kumar Prasad
57583c0764
feat: Insturment JS Objects settings #16970 ( #18046 )
2022-11-21 13:10:35 +05:30
Abhinav Jha
67f7d217a1
feat: (Internal Change) Add auto height computation functions ( #17962 )
...
* Add auto height reflow functions libary
* Add comments in hard to understand parts
* feat: auto height reflow lib (#17978 )
added 2 tests for boxHelper and 1 simple test for reflow computeChangeInPositionBasedOnDelta
Co-authored-by: Ankur Singhal <ankurrsinghal@gmail.com>
* Reduce one loop. Fix typo
* Add helper functions and use them in lib
* Use helper function
* Add types
* Fix issue where widgets don't get close to the bottom most above widget if that widget hasn't changed
* fix: auto height reflow lib merge release (#18193 )
* feat: show number of tabs on the header (#18071 )
* number of tabs displayed alongside label
* styling for span removed
* feature added and cypress test cases written
* code refactoring after review
* Update top contributors
* feat: Auto-height add reducers and actions (#17953 )
* Add reducers for auto height feature (Internal Change, No changes reflected to users)
Co-authored-by: ankurrsinghal <ankur@appsmith.com>
* [Bug] Incorrect count of users in workspace when adding multiple users (#17728 )
fix: filtering unique users by userId
Co-authored-by: Anubhav <anubhav@appsmith.com>
* fix: Instrumentation for execution errors (#18093 )
* fix: Instrumentation for execution errors
* added widget editor error event
* fix: Sidebar heading fontSize & checkbox alignment (#18104 )
sidebar heading & checkbox alignment to heading
* chore: added type for feature flag (#18152 )
add: new type for env variable
* Update top contributors
* feat: [Context Switching]: Change focus target and fix cursor position (#17794 )
Co-authored-by:
rahulramesha <rahul@appsmith.com>
* fix: JS Objects save failures due to AST changes (#18018 )
* fix: update local_testing.sh to build image for external contributor PRs (#18024 )
* chore: use `typography` and `getTypographyFromKey` from the design-system (#18050 )
Change typography imports, change function call
* dummy
Co-authored-by: Rishabh Kashyap <rishabh.kashyap@appsmith.com>
Co-authored-by: Appsmith Bot <74705725+appsmith-bot@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Ankit Srivastava <67647761+ankitsrivas14@users.noreply.github.com>
Co-authored-by: Anubhav <anubhav@appsmith.com>
Co-authored-by: ChandanBalajiBP <104058110+ChandanBalajiBP@users.noreply.github.com>
Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: subratadeypappu <subrata@appsmith.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
Co-authored-by: Ankur Singhal <ankurrsinghal@gmail.com>
Co-authored-by: ankurrsinghal <ankur@appsmith.com>
Co-authored-by: Ankur Singhal <ankurrsinghal@gmail.com>
Co-authored-by: Rishabh Kashyap <rishabh.kashyap@appsmith.com>
Co-authored-by: Appsmith Bot <74705725+appsmith-bot@users.noreply.github.com>
Co-authored-by: Ankit Srivastava <67647761+ankitsrivas14@users.noreply.github.com>
Co-authored-by: Anubhav <anubhav@appsmith.com>
Co-authored-by: ChandanBalajiBP <104058110+ChandanBalajiBP@users.noreply.github.com>
Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: subratadeypappu <subrata@appsmith.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
2022-11-20 11:42:32 +05:30
Appsmith Bot
904fa89833
Update top contributors
2022-11-20 06:59:17 +05:30
Ayangade Adeoluwa
300950b147
fix: Fix response header issues ( #17717 )
...
Fix response header issues
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-11-19 19:29:15 +05:30
subratadeypappu
4e20b4c496
Fix JS object duplicate name issue ( #18198 )
2022-11-19 09:19:36 +05:30
Appsmith Bot
847c3ec11c
Update top contributors
2022-11-19 06:59:09 +05:30
balajisoundar
9079d36600
fix: Cyclic deps in Table widget shouldn't crash the app ( #18217 )
2022-11-18 16:24:35 +05:30
arunvjn
5acc08c57c
chore: linting performance improvement ( #18101 )
...
* Fixes bad selectors that resulted in unnecessary re-renders.
* Added deep equality check before updating redux store with lint errors
2022-11-18 15:53:24 +05:30
Hetu Nandu
c2103cd16e
fix: Log ChunkLoadError on Sentry only after 3rd failure ( #18196 )
2022-11-18 09:33:23 +00:00
Vishnu Gp
9c1f9e4af8
fix: Corrected usage of old soft deleted filter in BaseAppsmithRepository ( #18238 )
2022-11-18 09:33:00 +00:00
Nikhil Nandagopal
487e556dda
Updated Label Config
2022-11-18 12:26:50 +05:30
Shrikant Sharat Kandula
4fed4ec52a
Fix Stale PID file breaking start-https.sh script ( #17957 )
2022-11-18 11:51:38 +05:30
Appsmith Bot
6ef08f9b50
Update top contributors
2022-11-18 06:59:22 +05:30
Vaibhav Tanwar
bc516a5583
fix: Google sheet datasource fix ( #18199 )
...
null check added for object value
2022-11-17 18:54:21 +05:30
Aswath K
2cb7474e1c
fix: Allow country code change text gets wrapped and makes the UI looks ugly ( #18218 )
...
* fix: Change country code text gets wrapped and makes the UI looks ugly
* fix: Cypress failures
2022-11-17 17:45:06 +05:30
Appsmith Bot
e8a74dbb1a
Update top contributors
2022-11-17 06:59:16 +05:30
Vishnu Gp
4402b35247
fix: Error deleting application when soft-deleted entities are present in the application ( #18185 )
...
* fix: Error deleting application when soft-deleted entities are present in the application
* Review changes
2022-11-16 20:15:38 +05:30
Tanvi Bhakta
8bc40c91d9
chore: use typography and getTypographyFromKey from the design-system ( #18050 )
...
Change typography imports, change function call
2022-11-16 11:32:00 +07:00
Sumit Kumar
f6fe0ad8cb
fix: update local_testing.sh to build image for external contributor PRs ( #18024 )
2022-11-16 05:41:05 +05:30
subratadeypappu
993eae833e
fix: JS Objects save failures due to AST changes ( #18018 )
2022-11-16 05:40:29 +05:30
Hetu Nandu
b4adfcf8e2
feat: [Context Switching]: Change focus target and fix cursor position ( #17794 )
...
Co-authored-by:
rahulramesha <rahul@appsmith.com>
2022-11-15 11:50:18 +05:30
Appsmith Bot
328ca49532
Update top contributors
2022-11-15 06:59:28 +05:30
Ayush Pahwa
77dffdb3b3
chore: added type for feature flag ( #18152 )
...
add: new type for env variable
2022-11-14 19:04:51 +07:00
Rohit Agarwal
7a79347ce2
fix: Sidebar heading fontSize & checkbox alignment ( #18104 )
...
sidebar heading & checkbox alignment to heading
2022-11-14 13:51:07 +05:30
ChandanBalajiBP
2184eb8acd
fix: Instrumentation for execution errors ( #18093 )
...
* fix: Instrumentation for execution errors
* added widget editor error event
2022-11-14 14:01:55 +07:00
Ankit Srivastava
e64f87e033
[Bug] Incorrect count of users in workspace when adding multiple users ( #17728 )
...
fix: filtering unique users by userId
Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-11-14 11:58:20 +05:30
Abhinav Jha
3f71fa68a1
feat: Auto-height add reducers and actions ( #17953 )
...
* Add reducers for auto height feature (Internal Change, No changes reflected to users)
Co-authored-by: ankurrsinghal <ankur@appsmith.com>
2022-11-14 09:49:25 +05:30
Appsmith Bot
14159c5593
Update top contributors
2022-11-09 06:59:51 +05:30
Rishabh Kashyap
1e7c97c1f7
feat: show number of tabs on the header ( #18071 )
...
* number of tabs displayed alongside label
* styling for span removed
* feature added and cypress test cases written
* code refactoring after review
2022-11-08 20:50:58 +05:30
Trisha Anand
5f8f8f9b70
chore: Re-adding the read permission group AclPermission ( #18132 )
2022-11-08 08:03:08 +05:30
balajisoundar
2df27a6fb2
feat: Option to add new row in Table widget ( #17515 )
2022-11-05 15:24:20 +05:30
Appsmith Bot
a9731276c2
Update top contributors
2022-11-05 06:59:35 +05:30
Nikhil Nandagopal
7faa348b6b
Updated Label Config
2022-11-04 15:34:23 +05:30
Nikhil Nandagopal
2db16f8bb2
Updated Label Config
2022-11-04 12:44:41 +05:30
Dhruvik Neharia
2ec1ccc6a5
feat: Code Scanner Enhancements ( #17929 )
...
* feat: Add Scanner Variant - Click to scan and always on to code scanenr
* feat: Enhancements for code scanner's property pane - update help text, hide properties on always on
* feat: Add Image Mirror button to code scanner
* feat: Update code scanner video fit to contain
* feat: Add DSL migrations for Code Scanner
* feat: Make always on the default scanner layout, rename scannerVarient to scannerLayout
* feat: Stop scanning and detecting codes in background for code scanner widget
* test: Add Cypress tests for different scanner layouts for code scanner
* refactor: fix minor code callouts here and there
* refactor: Restructure cypress test suite
* feat: Increase code scanner delay to avoid unintended detections
* refactor: combine two different conditions into one ternary
* feat: Remove one cy test case
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-11-04 11:45:45 +05:30
Aman Agarwal
9c4cfe16f1
fix: delete individual ds without blocking other ds ( #17949 )
...
* fix: delete individual ds without blocking other ds
* fix: removed delay for deletion, isDeleting ui state
2022-11-04 11:25:25 +05:30
Rohit Agarwal
be68317b0a
chore: template list sidebar consistent with application page sidebar ( #17882 )
...
made template list sidebar consistent with application page sidebar
2022-11-04 10:08:29 +05:30
Appsmith Bot
f9ba58a82e
Update top contributors
2022-11-04 06:59:44 +05:30
Favour Ohanekwu
37b69ef6b5
chore: Delete redundant nvm folder ( #18087 )
...
Delete redundant nvm folder
2022-11-03 19:39:40 +01:00
Ankita Kinger
38d321242f
chore: Splitting files to support groups on members page in EE ( #18085 )
...
* splitted files to support groups on members page in EE
* updated an import
* minor change
2022-11-03 22:09:51 +05:30
albinAppsmith
d7fc478491
fix: Radio button triggering on change twice ( #18056 )
...
* fix: Radio button triggering on change twice
* stable version update
2022-11-03 16:00:34 +05:30