Commit Graph

19001 Commits

Author SHA1 Message Date
Nilansh Bansal
fe7ca6b98e
chore: added prettier spotless plugin for json files (#35447)
## Description
This PR adds the spotless formatter and validator for the JSON files
present in the project. If there is any invalid JSON file, the formatter
fails and logs the file and the error LOC to be fixed.
It uses the `prettier JSON` formatted in spotless for the same.
Since Spotless is already added to the pre-commit hook it also makes it
necessary to fix the JSON and then commit the changes.

- The prettier JSON formattor preserves the order of the keys.
- Indendation of 2 spaces has been added in the config

Screenshot of the errors displayed for Invalid JSONs
<img width="1427" alt="image"
src="https://github.com/user-attachments/assets/00bbd61c-7414-4787-b9ac-2f0d392f6f33">

### Last attempt to resolve this issue
The formatted used was `simple JSON` which led to change in order of
JSON keys.
PR: https://github.com/appsmithorg/appsmith/pull/35395
Ref:
https://theappsmith.slack.com/archives/CGBPVEJ5C/p1722929754593669?thread_ts=1722916121.682699&cid=CGBPVEJ5C


Fixes #34969 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10264348935>
> Commit: 4957b647f3d5e0f9853e7f391411b62ee189547b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10264348935&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 06 Aug 2024 12:40:47 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-08-08 09:16:03 +05:30
Nidhi
1e473694b5
Merge pull request #35515 from appsmithorg/test/theme-tests 2024-08-07 21:23:31 +05:30
Nikhil Nandagopal
5acc392031 Updated Label Config 2024-08-07 17:54:19 +05:30
Nikhil Nandagopal
b346cbe2c9
Update config.json 2024-08-07 17:33:18 +05:30
Nikhil Nandagopal
8c950dbeb7
Update config.json 2024-08-07 17:03:50 +05:30
Nikhil Nandagopal
d693af7160
Update config.json 2024-08-07 17:00:46 +05:30
Nikhil Nandagopal
aab81dbb95 Updated Label Config 2024-08-07 17:00:22 +05:30
Anagh Hegde
58ae4f7ba9 test: add ordering for theme import test to fix flakiness (#35473) 2024-08-07 16:58:04 +05:30
Anagh Hegde
c8efe56a34
test: add ordering for theme import test to fix flakiness (#35473) 2024-08-07 16:50:35 +05:30
Nikhil Nandagopal
a4d2562ba6
Update config.json 2024-08-07 16:49:53 +05:30
Sagar Khalasi
6d1b9bdc2c
test: fix flaky case for forkapp (#35376)
## Description
Fix case with adding one more assertion with wait.
RCA: 
The issue was not with the function itself but rather with the flaky
behavior of the Cypress code. The modal was opening, and our code was
attempting to click the “Skip to Application” button too quickly. The
actual validation was only for SkipToAppBtn, but in the application, the
modal was still loading, causing Cypress to perform the action
prematurely, which led to failures. To address this, I added an
additional wait for another element, and this resolved the issue.


Fixes #`35375`  


## Automation

/ok-to-test tags="@tag.Fork"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10279433214>
> Commit: 748f4f7cf960355a957e59f3956a47880494da93
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10279433214&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Fork`
> Spec:
> <hr>Wed, 07 Aug 2024 07:08:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **New Features**
- Enhanced test robustness for the ForkApplication component by
implementing a prerequisite check for the presence of a critical UI
element linked to data sources.

- **Bug Fixes**
- Improved control flow in tests to ensure that necessary elements are
available before proceeding with actions, reducing the likelihood of
test failures.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-07 13:55:22 +05:30
Hetu Nandu
0b1bcf2bef Revert "Add a generic label check step"
This reverts commit 6d5dacdd96.
2024-08-07 12:06:43 +05:30
Hetu Nandu
f1190d2f79 Merge branch 'refs/heads/release' into chore/ok-to-test-push 2024-08-07 11:53:17 +05:30
Hetu Nandu
6d5dacdd96 Add a generic label check step 2024-08-07 11:52:42 +05:30
Rudraprasad Das
9b59d4da17
fix: issue with opening custom widget source editor (#35463) 2024-08-07 11:49:23 +05:30
Nidhi
62c46f06fc
Merge pull request #35466 from appsmithorg/cherry-pick/ci-clientbuild-fix 2024-08-07 09:38:14 +05:30
Diljit
43518e6d58
chore: Remove google fonts imported from googleapis (#35392)
## Description
Google fonts are served by the appsmith instance and change that was
introduced in t[his
PR](https://github.com/appsmithorg/appsmith/pull/22129). This PR removes
redundant the import of google fonts from googleapis.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10270353461>
> Commit: 142bcc8507af247ced35a92473cc6fdab9868025
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10270353461&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 06 Aug 2024 17:21:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Transitioned to a fully local/custom font strategy, enhancing branding
consistency and potentially improving load times.

- **Usability Improvements**
- Enhanced output readability in the GitHub Actions workflow, making it
easier for users to identify changed files.
- Updated the file change detection mechanism in the GitHub Actions
workflow for better performance and clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-07 08:49:04 +05:30
yatinappsmith
0f98d06090 CI: commented files changed step. It is a notification step (#35460)
commented files changed step. It is a notification step

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Modified the GitHub Actions workflow to simplify job flow by
commenting out the command execution for changes in the client folder,
effectively disabling that functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit b3c35e9e68)
2024-08-07 03:26:01 +05:30
Nikhil Nandagopal
57a8e83b4a Updated Label Config 2024-08-06 22:44:02 +05:30
Valera Melnikov
c42e0317de
fix: change appsmith alias (#35349)
In order to unify package names, we decided to use `@appsmith` prefix as
a marker to indicate that packages belong to our codebase and that these
packages are developed internally. So that we can use this prefix, we
need to rename the alias of the same name. But since `@appsmith` is
currently being used as an alias for `ee` folder, we have to rename the
alias as the first step.

Related discussion
https://theappsmith.slack.com/archives/CPG2ZTXEY/p1722516279126329

EE PR — https://github.com/appsmithorg/appsmith-ee/pull/4801

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10267368821>
> Commit: 2b00af2d257e4d4304db0a80072afef7513de6be
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10267368821&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 06 Aug 2024 14:24:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-08-06 17:52:22 +03:00
Hetu Nandu
1ca6ab83f7
chore: Override fast-xml-parser for security concern (#35435) 2024-08-06 20:06:11 +05:30
yatinappsmith
b3c35e9e68
CI: commented files changed step. It is a notification step (#35460)
commented files changed step. It is a notification step

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Modified the GitHub Actions workflow to simplify job flow by
commenting out the command execution for changes in the client folder,
effectively disabling that functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-06 19:35:30 +05:30
Goutham Pratapa
f19ec6a183
fix: failing backup and restore appsmithctl (#35162)
Fixes: #34996
2024-08-06 19:34:59 +05:30
Nikhil Nandagopal
c042f94bed Updated Label Config 2024-08-06 19:28:18 +05:30
Nikhil Nandagopal
2ed8aa82d5 Updated Label Config 2024-08-06 19:25:13 +05:30
Nikhil Nandagopal
cacdf90016 Updated Label Config 2024-08-06 19:19:26 +05:30
Nikhil Nandagopal
c9ecddcc47 Updated Label Config 2024-08-06 19:16:33 +05:30
Nikhil Nandagopal
2234b33181 Updated Label Config 2024-08-06 19:16:20 +05:30
yatinappsmith
5eb9e0b904
Merge pull request #35448 from appsmithorg/release
06/08 - Daily promotion
2024-08-06 18:14:03 +05:30
VigneswarV
380022c0de
fix: commit icon of github on airgapped, the app crashes. #33812 (#34673) 2024-08-06 17:43:29 +05:30
Nikhil Nandagopal
73c68f4736 Updated Label Config 2024-08-06 17:23:52 +05:30
Vemparala Surya Vamsi
95e32687af
chore: Memoising some computations within WDS_TOOLBAR_BUTTONS_WIDGET (#35436)
## Description
Memoising some computations related to WDS_TOOLBAR_BUTTONS_WIDGET

Fixes #`Issue Number`  

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10264040446>
> Commit: c15e274b718fc36f17b8f7edda4f23790b72f16d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10264040446&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 06 Aug 2024 10:43:05 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Performance Enhancements**
- Optimized the `ToolbarButtons` component for improved efficiency by
utilizing the `useMemo` hook, reducing unnecessary calculations and
re-renders.
- Consolidated the computation of `sortedButtons` and `disabledKeys` in
`ToolbarButtonsComponent` for better performance and clarity.
  
- **Telemetry Integration**
- Added performance tracking capabilities to the `withWidgetProps`
higher-order component, enhancing observability of widget performance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-06 14:49:22 +03:00
Valera Melnikov
2661c92883
Merge pull request #35452 from appsmithorg/fix/resolve-conflicts
fix:resolve conflicts
2024-08-06 14:26:02 +03:00
Nikhil Nandagopal
82d9095961 Updated Label Config 2024-08-06 16:44:07 +05:30
Nikhil Nandagopal
e7379710ee Updated Label Config 2024-08-06 16:43:51 +05:30
Valera Melnikov
5add64cc1d Merge branch 'master' into fix/resolve-conflicts 2024-08-06 14:04:19 +03:00
Nikhil Nandagopal
cbb45686be Updated Label Config 2024-08-06 15:41:04 +05:30
Nikhil Nandagopal
8543ab9992 Updated Label Config 2024-08-06 15:36:24 +05:30
Nikhil Nandagopal
fe894bb0e3 Updated Label Config 2024-08-06 15:19:52 +05:30
Nikhil Nandagopal
3527930c8d Updated Label Config 2024-08-06 15:18:52 +05:30
Nikhil Nandagopal
4346076326 Updated Label Config 2024-08-06 15:15:57 +05:30
Nikhil Nandagopal
f8444011b2 Updated Label Config 2024-08-06 14:55:59 +05:30
Nikhil Nandagopal
162592056e Updated Label Config 2024-08-06 14:37:11 +05:30
Nikhil Nandagopal
b01dc9deff Updated Label Config 2024-08-06 14:36:14 +05:30
Nikhil Nandagopal
eea603c423 Updated Label Config 2024-08-06 14:35:46 +05:30
Nikhil Nandagopal
26fa7324a6 Updated Label Config 2024-08-06 14:34:03 +05:30
Nikhil Nandagopal
697189cff3 Updated Label Config 2024-08-06 14:33:44 +05:30
Nikhil Nandagopal
670842907e Updated Label Config 2024-08-06 14:31:04 +05:30
Nikhil Nandagopal
309fe3f17f Updated Label Config 2024-08-06 14:30:52 +05:30
Nikhil Nandagopal
f46aac33fc Updated Label Config 2024-08-06 14:21:56 +05:30