Commit Graph

60 Commits

Author SHA1 Message Date
Anagh Hegde
7099113beb
chore: add postgres db during the startup conditionally (#37605)
## Description
This pull request proposes a change to conditionally add a PostgreSQL
database during startup.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12064918747>
> Commit: fbded313eb0f1416f4bdd453c6d42db437f4eecc
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12064918747&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 28 Nov 2024 08:44:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced conditional PostgreSQL service for CI tests, enhancing
database service management.
- **Improvements**
- Refined job conditions for CI tests execution, improving workflow
clarity and control.
- Enhanced error handling and logging for better debugging during test
failures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-02 15:07:04 +05:30
Shrikant Sharat Kandula
c9ddd9c765
chore: Remove CS URL in client (#37665)
The server should be the source of truth and owner for the current CS
URL, and the client having direct access to the CS URL is (almost) an
abstraction leak. We're using it on client for one purpose only, to
redirect to CS for Google sheets authorization. That's just as well
achieved with another redirect via the server.

This PR does that redirection and removes access to the CS URL to the
client code. Not used anywhere else, and shouldn't be needed.


## Automation

/test sanity datasource

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12029489682>
> Commit: 0a1937e7d5d492c7c6a98bde124a157663126ac1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12029489682&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource`
> Spec:
> <hr>Tue, 26 Nov 2024 12:21:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
	- Enhanced CI workflow with improved error handling and logging.
- Added a new authorization redirection endpoint in the SaaS controller.

- **Improvements**
	- Database URL validation step added to CI tests.
	- Artifact management for test results has been clarified and improved.
- Removal of `cloudServicesBaseUrl` from various configurations to
streamline cloud service integration.

- **Bug Fixes**
	- Refined logic for rerunning tests based on previous results.

These updates contribute to a more robust and efficient testing and
configuration environment.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-11-27 10:32:35 +05:30
Sagar Khalasi
e0fb8f91cf
Fix: Fix for GHSL-2024-277 (#36836)
## Description
Fix :
https://github.com/appsmithorg/appsmith/security/advisories/GHSA-5f24-4j99-h3gc#event-330907

Use bash syntax to access the environment variable: $EVENT_COMMITS

Fixes #`36835`

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
18af8361443cfcdd98239fbc4af52c96aaadf501 yet
> <hr>Mon, 14 Oct 2024 04:55:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a `run_count` input parameter for specifying the number of
test repetitions.
	- Added input parameters for manual triggering in the CI workflow.
- New environment variable `COMMIT_INFO_AUTHOR` captures the author name
for better context in commit messages.

- **Improvements**
	- Enhanced logic for handling commit messages and test run conditions.
- Improved caching mechanism for better tracking of test outcomes across
runs.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-10-14 21:05:58 +05:30
Abhijeet
992bbdb7c8
chore: Update Postgres port for TED in CI (#34430)
## Description
PR to update the Postgres posrt for TED container in CI.

/test all

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9646981763>
> Commit: d998c6fe77ac2acdb71888fe6b3d7603ddda508c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9646981763&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->








## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated Docker port mapping from `5432` to `5433` across multiple CI
workflow files to ensure consistency and avoid port conflicts.

- **Bug Fixes**
- Adjusted PostgreSQL connection port from `5432` to `5433` in test
fixtures and scripts to align with environment changes and prevent
connection issues.

- **Tests**
- Modified test scripts to handle new PostgreSQL port settings for
improved reliability in testing scenarios.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-25 10:35:15 +05:30
Apeksha Bhosale
22dade8d37
chore: Removed two extra machines for ci-test-limit (#34357)
## Description
ci-test-limit runs 3 machines by default and this is wastage of our
resource, in most of our use cases we end up using only one machine
soremoving extra unnecessary two.

run -
https://github.com/appsmithorg/appsmith/actions/runs/9593828953/job/26455099156

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9594698568>
> Commit: 18d2ab3a9f292c6e3ca8ed7c803bbabde75cb1ab
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9594698568&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Updated test workflow configuration for more efficient CI runs.
  
- **Tests**
- Switched limited test spec file to improve test coverage and
relevance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 11:42:59 +02:00
Abhijeet
cd2f1cb5dd
chore: Cleanup Flagsmith envs from CI (#33704)
## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9210729164>
> Commit: ffb04c3dd1eb214aa4d3cdd3d97a28ca0ada7de1
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9210729164&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-24 10:19:48 +05:30
Arpit Mohan
9faab949cc
ci: Making minor improvements to the CI workflow files (#33636)
This is trivial housekeeping task to keep the workflow files consistent
and remove warnings.
2024-05-23 19:47:34 +05:30
Shrikant Sharat Kandula
8480704398
ci: Don't mount volume for TED's git repos (#33666)
The upcoming TED version is about come with a Git repo, baked into the
image. We're going to use this to test import of git repos.

But since we mount a blank folder onto this, the baked-in contents of
`/git-server/repos` is effectively cleared and overwritten. This PR
fixes that. We don't really need this volume mount, should be okay to
remove.

/test sanity
2024-05-23 18:39:53 +05:30
Arpit Mohan
f81cb9f970
ci: Removing outdated Github action actions-cache (#33568)
Using actions/cache/save which is the supported version now.
2024-05-20 19:26:31 +05:30
Arpit Mohan
ddefab7306
ci: Adding the overwrite: true parameter to actions/upload-artifact@v4 command (#33593)
## Description
By default the value of overwrite is false. In previous versions of
upload-artifact, this setting was implicit and true. Making this change
to fix the error `Failed to CreateArtifact: Received non-retryable
error: Failed request: (409) Conflict: an artifact with this name
already exists on the workflow run` in Github actions.

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-20 17:22:22 +05:30
Arpit Mohan
6aeb456c62
ci: Upgrade GitHub Action steps to github-script@v7 and pload-artifact@v4 (#33554)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No

---------

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
2024-05-20 10:49:27 +05:30
Shrikant Sharat Kandula
cd22fc1087
test: Some cleanup for Git Cypress tests (#32836)
1. Change usage of ports bound to 3000, 5000 and 8000 to 4200, which
will be the canonical port for TED in the future.
2. Switch to using TED's native git repo management APIs, instead of the
Gitea compatibility layer.
3. Remove code from GitHub ages.


/ok-to-test tags="@tag.Sanity, @tag.Git"<!-- This is an auto-generated
comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8785291879>
> Commit: b38f4eb388716f7fcfc2a032d788c2ebb951568b
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8785291879&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Enhanced Git integration by shifting from GitHub to Gitea for
repository operations in test environments.
- Updated URLs and endpoints across various test scripts and data
fixtures to align with new configurations.
- **Tests**
- Modified test scenarios to reflect changes in Git operations and URL
configurations.
- **Chores**
- Updated CI workflows by replacing old secrets with new ones for better
configuration management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 10:01:14 +05:30
Shrikant Sharat Kandula
85bed5bfc7
ci: Publish port 4200 for TED (#32835)
This changes to publish TED's canonical app port, `4200`.

What's wrong with the currently used ports?


57f63003ef/app/app.ts (L18-L20)

Quoting here:

> 8000, // Past static webserver port, to be removed, after switching to
4200, clashes with CloudServices on CI.
> 5000, // Past Postgraphile port, to be removed, after switching to
4200, clashes with macOS AirDrop.
> 3000, // Past Gitea port, to be removed, after removing Gitea, because
it clashes with `yarn start` in Appsmith.

/ok-to-test tags="@tag.Sanity"
2024-04-22 10:33:07 +05:30
Arpit Mohan
86cd40982b
ci: Upgrading the github action steps from Node 16 to Node 20. (#32004)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._

This is a maintenance fix that removes the warnings in our CI runs to
make it more readable.
Refer:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8386795331>
> Commit: `2b1bfe7ed505ad9ba67bfe9211d50ebabb8ea0ce`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8386795331&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated DockerHub login action across multiple workflows to version 3
for enhanced security and performance.
- Updated various GitHub Actions to newer versions in different
workflows for improved compatibility and performance.
- Modified file path pattern in a workflow step for consistency and
clarity.
- Updated setup actions for Java to version 4 for better Java
environment setup.
- Updated setup-node version in a workflow and adjusted comments for
Cypress test results.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-01 15:41:43 +05:30
Valera Melnikov
92c72ee20e
chore: update node version and appropriate git workflows (#31486)
## Description
- update node version and appropriate git workflow
- added the path to webpack cache folder, this should speed up bundle
creation about a minute

[Test, build and push Docker
Image](https://github.com/appsmithorg/appsmith/actions/runs/8421752151)
[Build Client, Server & Run only
Cypress](https://github.com/appsmithorg/appsmith/actions/runs/8421752151)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Chores**
- Updated actions/cache and actions/setup-node to v4 across various
workflows for improved caching and Node.js setup.
- Modified the `yarn install` command to use `--immutable` flag,
enhancing dependency management.
- **Documentation**
- Updated comments within workflows to include cautionary and important
notes, ensuring better clarity.
- **Refactor**
	- Adjusted caching paths and keys for more efficient caching behavior.
- Changed Node.js installation to version 20.11.1 in Dockerfile,
aligning with the latest version for better performance and security.
- **Tests**
- Modified assertion in `getCurrentLocationSaga` test to check for the
presence of a property, improving test accuracy.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2024-03-26 14:12:11 +03:00
Aishwarya-U-R
30300bb6a4
test: Cypress | Replacing some external api's with TED + Flaky fix (#31118)
## Description
- This PR does some clean up of comments - in DeployHelper.ts
- This PR replaced external image api with TED mock api in
ServerSide/OnLoadTests/OnLoadActions_Spec.ts
- Extrenal example api to TED in Widgets/Image/Image_spec.js
- Extrenal api links in
app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js
to TED api's
- Flaky fixes /ServerSide/LoginTests/LoginFailure_spec.js - for EE CI
run failure (Added multiple Dynamic checks)
- support command.js method LoginUser() - added Dynamic check
- Encapsulated Datasources/Arango_Basic_Spec.ts into conditional check
to run in CE alone, instead of entirely skipping, since its failing in
EE due to chrome crash

#### Media
#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Updated Cypress regression tests to use flower images instead of cat
images for API calls.
- Modified limited test configurations to run with different spec files.
- Adjusted GitHub Actions workflow to change `matrix_count` values based
on the event type and retrieve PR number for manual triggers.
	- Updated Docker image tag in CI tests to `nightly`.

- **Refactor**
- Enhanced `DataManager` class with new properties for flower image
URLs.
- Improved `EntityExplorer` class method to ensure more reliable
triggering of events.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-02-23 13:18:01 +05:30
Shrikant Sharat Kandula
d25b94fe50
chore: Remove unneeded exposing of 9001 port (#30499)
We're already using `/supervisor` for this, and don't expect anyone to
hit the port directly.
2024-01-22 15:06:08 +05:30
Saroj
cf53dbfb23
ci: Allow static split of cypress specs (#29653)
## Description
- Allowing static split of cypress specs in CI runs.
- Optimised the spec allocation by considering the duration history for
each spec.
- Updated the affecting workflows to utilise the static split

#### Type of change
- Workflows
- Cypress-split pugin
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new environment variable to optimize test resource
allocation during CI/CD processes.
- Enhanced Cypress testing with dynamic and static test splitting
strategies.

- **Refactor**
- Refactored Cypress plugin configuration to support conditional test
splitting based on the environment variable.

- **Chores**
- Updated GitHub Actions workflows to include new environment variables
for test runs.

- **Documentation**
- Updated internal documentation to reflect changes in test setup and
execution strategies.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-18 17:10:11 +05:30
sharanya-appsmith
a1fb4ba197
test: Cypress - Added cypress grep library (#29259)
Leveraging the library

[cypress-grep](https://github.com/cypress-io/cypress/tree/develop/npm/grep).
Using this we can tag testcases with relevant tags and use it to run
specific testcases.

**Command to run in local:** 
`CYPRESS_grepTags=@tag.Binding,@tag.Git npx cypress run
`
Pass the tags to CYPRESS_grepTags argument and only the test cases which
has the
tags passed will be picked to run. ex `@tag.Binding and @tag.Git` are
the tag names here.

**Tags can be added in the description on the test case like** 
`{ tags: ["@tag.Datasource"] }` for a single tag
`{ tags: ["@tag.Datasource", "@tag.Git"] }` for multiple tags 

**How to run In CI**
Single Tag - `/ok-to-test tags=@tag.Binding`
Multiple tag - `/ok-to-test tags=@tag.Binding,@tag.Git`


**TODOs in the next release:** 
- [ ] Add tags.ts file with all needed tags
- [ ] Add tags to remaining spec files. 
- [ ] Fail the PR run if tags added are not from tag.ts and post the
message on the same

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update

#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [x] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Added a search functionality to the app.

- **Enhancements**
- Integrated search bar at the top of the `Hero` component and a
`Search` component to the `App` component.
  - Added styles for the search bar.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2023-12-07 18:23:27 +05:30
Saroj
f2261b36f3
ci: Cache the docker image (#29369)
## Description
- Now saving the docker image in cache instead of uploading it as an
artefact to save time

#### Type of change
- Workflow changes
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated CI workflows to use GitHub Actions cache for Docker images
instead of uploading to artifacts.
- Removed `restore-keys` from Yarn dependency caching for a more
streamlined caching process.
- Improved conditions for Docker image caching to enhance CI efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-07 16:59:32 +05:30
Arpit Mohan
2650ea161d
ci: Updating actions/checkout to v4 and defaulting to fetch-depth 1 instead of 0 (#29281)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to use `actions/checkout@v4` for
improved performance and reliability.
- Removed `fetch-depth` parameter to simplify checkout steps across
various workflows.
  - Standardized quote usage for consistency in workflow files.

- **Documentation**
- Adjusted formatting and descriptions in workflow files for better
clarity and readability.

- **Refactor**
- Aligned multiple workflow files to follow a consistent structure and
naming convention.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

fetch-depth 0 causes the Github workflow to checkout the entire Git
history. This is not required. We only need to check out the head of the
commit. By default, actions/checkout has fetch-depth=1, hence removing
it from the workflow completely for simplicity.
2023-12-05 13:44:43 +05:30
Arpit Mohan
58c62e0bbc
ci: Removing set-output in CI workflows as it's a deprecated command. (#29279)
Using GITHUB_OUTPUT to save environment variables instead. This is to
remove lots of warnings in the CI run and make it easier to read the
summary.
2023-12-03 12:46:56 +05:30
Saroj
8dab2c84e6
test: Cypress - Map chart automation (#28512)
## Description
- Map Chart Automation
#### PR fixes following issue(s)
- Added tests for Map Chart Widget
#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>

## Checklist:
#### QA activity:
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-11-03 16:59:22 +05:30
Aishwarya-U-R
f0f8a58140
ci: Removal of env's from Setting Cypress step (#28192)
## Description
- This PR removes the env's from Setting up Cypress step

#### Type of change
- Yml update (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI limited runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-10-18 18:31:35 +05:30
Saroj
48a3f15ab1
test: Bump cypress version to 13.3.1 (#27987)
## Description
 - Bumped cypress version
 - Updated workflow files to use latest cypress GitHub-action 

#### Type of change
- Workflow files
- Package.json
- yarn.lock
## Testing
>
#### How Has This Been Tested?
- [x] Cypress

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-10-13 10:49:56 +05:30
akash-codemonk
3dc1241468
chore: get browser logs from failed cypress tests (#27724)
Fixes https://github.com/appsmithorg/appsmith/issues/26006

Get browser console logs for failed tests. This will help with easier
debugging of flaky tests.

Sample artifact for a test
https://github.com/appsmithorg/appsmith/suites/16856147292/artifacts/962768313
Latest test run of the change:
https://github.com/appsmithorg/appsmith/actions/runs/6405413689

Trimming down the files to a max of 10 files, since the artifact size
can go upto a GB when there are a 1000 or more tests failing.

---------

Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-10-05 14:42:30 +05:30
Saroj
20c5290c57
ci: Fix ci-test workflows (#27583)
## Description
- Fix ci-test workflows

#### Type of change
- Workflow files
## Testing
- CI run
2023-10-05 10:38:48 +05:30
Aishwarya-U-R
a8c50cfb37
test: Cypess | Oracle DS validations added (Part 5) + CI Stabilize (#27440)
## Description
- This PR adds below:
- Oracle - Delete table data validation
- Deploy App & verify the deleted data
- Bind query to already existing table widget, deploy, Filter table &
verify
- Improved AssertPopoverTooltip - to handle both tooltip elements
- Oracle - Copy, Move query validated [Tc #
2363](https://github.com/appsmithorg/TestSmith/issues/2363)
- Oracle - Query settings page validation covered [Tc #
2365](https://github.com/appsmithorg/TestSmith/issues/2365)
- Oracle - Widgets (Select, DatePicker) to Insert query binding [Tc #
2366](https://github.com/appsmithorg/TestSmith/issues/2366)
- Updated ToggleConfirmBeforeRunning() to run for Api & Queries
- Enabling limited-workflow re-run

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-20 00:56:11 +05:30
Aishwarya-U-R
6fcf9b48c4
test: Cypess | Oracle DS validations added (Part 2) + CI Stabilize (#27282)
## Description
- This PR adds Oracle validations
- 'Add more' validated from Oracle Ds page
- Tc's automated Tc
[#2204](https://github.com/appsmithorg/TestSmith/issues/2204)
- Added a bit of sleep for keyboard actions (Enter, Escape, Delete)
- Added default param for datasources._host
- Oracle documentation verification added
- get cypress url dashboard url - step commented in ymls, as its no more
used
- Updating Slack message to also display the failing specs in notif
- ElasticSearch spec - update to check hosted run
- ServerSide/GenerateCRUD/MySQL2_Spec.ts - EntityExplore ds name miss
fix
- Update waitForServerRestart() timeout

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-14 16:53:42 +05:30
Aishwarya-U-R
7985a551f6
test: Cypess | Oracle DS validations added (Part 1) + CI Stabilize (#27161)
## Description
- Adds validations for Oracle Ds to run in Hosted instance
- Trial fix for EmbedSettings/EmbedSettings_spec.js (checking the
Appsmith is starting page goes away on its own)
- Block_Execution.ts - updated to use Oracle mock data
- Oracle tests [TC
#2354](https://github.com/appsmithorg/TestSmith/issues/2354), [TC
#2355](https://github.com/appsmithorg/TestSmith/issues/2355), [TC
#2356](https://github.com/appsmithorg/TestSmith/issues/2356), [TC
#2357](https://github.com/appsmithorg/TestSmith/issues/2357) Automated
- Set Commit Message update for Hosted runs since now Airtable,
ElasticSearch are also part along with GSheet cases
- SMTP added verification on mail details (from, to, status, msg body
etc)
- Widgets/WidgetPropertySetters_spec.ts - Lint error case flaky fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-13 22:33:14 +05:30
Saroj
5312ee11f3
test: Fix gsheet tests (#27146)
## Description
- Fix gsheet tests
- Fix workflows to not upload the result file in case of success

#### Type of change
- spec file changes
- Workflow file changes

## Testing
>
#### How Has This Been Tested?
- [x] Cypress


## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-11 18:37:02 +05:30
Aishwarya-U-R
5e2a4b6afa
test: Cypress | Update ci-test-limit to use Mock Flagsmith (#27120)
## Description
- This PR updates the name of datasource method from 'AssertDSActive' to
'AssertDSInActiveList'
- Updated ci-test-limit.yml to include the flagsmith params
- Updates Postgress staging db name/creds
2023-09-09 00:37:23 +05:30
Saroj
1a81caf568
ci: Fix for ci-test-limited rerun (#27094)
## Description
- Fix for ci-test-limited rerun

#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-09-08 12:45:12 +05:30
Saroj
d1fea6ba47
ci: Cypress rerun improvements (#27072)
## Description
- Cypress parallel run improvements
#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-09-07 17:00:39 +05:30
Saroj
ba9ebf1d6e
ci: Migrate pending workflows to dime defenders (#26968)
## Description
- Updated the logic to use DimeDefenders spec split
- Updated ci-test-hosted, ci-test-limited and ci-test-custom-script
- Changes to handle when there is no spec to run in CI

#### Type of change
- DimeDefender script
- Workflows
## Testing
- Workflow run
2023-09-06 14:40:13 +05:30
Saroj
d3f68b223f
ci: Fix internal db connection issue (#26731)
## Description
 - Fix internal db connection issue

#### Type of change
- cypress_hooks.js 
- Workflow changes
## Testing
- CI run
2023-08-29 16:45:49 +05:30
Aishwarya UR
968eb9950b ci-test-limit fix 2023-08-28 17:50:10 +05:30
Saroj
193f4849a7
ci: Add env variables to ci test limit and hosted workflow to use internal cypress db (#26656)
## Description
- Add env variables to ci test limit and hosted workflow to use internal
cypress db
#### PR fixes following issue(s)

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
 - CI Run
2023-08-25 15:06:19 +05:30
Valera Melnikov
826d58f813
chore:update node version to v18 (#26358)
## Description
Update node version

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-15 18:56:04 +05:30
Saroj
cf7883e398
ci: Fix comment issue in PR for failed specs (#25584)
## Description
- Fix comment issue in PR for failed specs

#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-21 16:37:14 +05:30
Aishwarya-U-R
7846907416
test: Cypress | Flaky fix (#25179)
## Description
- This PR fixes the below flaky tests
     - BugTests/AllWidgets_Reset_Spec.ts
     - BugTests/InputTruncateCheck_Spec.ts
- BugTests/CatchBlock_Spec.ts (external api replace with TED
v1/mock-http-codes/404 api)
     - Datasources/Airtable_Basic_Spec.ts
     - Onboarding/FirstTimeUserOnboarding_spec.js
     - Autocomplete/JS_AC_spec.ts - split!
     - GenerateCRUD specs - added assertion
     - ci-test-limit - comit message update for workflow & comment run

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-07 23:28:16 +05:30
Saroj
188976376a
ci: Fix to skip the commented lines from limited-tests.txt (#25197)
## Description
- Fix to skip the commented lines from limited-tests.txt

#### Type of change
- Workflow file chnage
## Testing
>
#### How Has This Been Tested?
- Manual workflow run
2023-07-07 14:57:29 +05:30
Saroj
c8fb7e685d
ci: Fix the result job name fir limited test workflow (#25192)
## Description
- Fix the result job name fir limited test workflow
-  It has below improvements

  -- it will skip lines starting with # or // in limited-test.txt
-- Dynamically assign the matrix count, run through command it will take
5 runners and manual workflw run will take 60 runners
  -- Cypress dashboard heading
  -- Some other small improvements

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-07 14:13:40 +05:30
Saroj
50240fc74b
ci: Add command to run ci-test-limited (#25180)
## Description
- Add command to run ci-test-limited
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-07 12:26:55 +05:30
Aishwarya-U-R
91325d258e
test: Cypress | Moving Non-TED containers within Tests (#24709)
## Description
- This PR improves the container start for 
- Arango DB - Container started moved to test case level
- MsSql - Delete container added
- Elastic - Container started moved to test case level
- Starts container, runs tests, stops containers & deletes it too 🤞🏻
- Removed containers start from yml file
- Flaky fixes below:
         - Apps/ReconnectDatasource_spec.js
         - Improved FillPostgresDSForm()

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after all changes are reviewed
2023-06-21 23:07:21 +05:30
Saroj
11a18d1d08
ci: Remove un-necessary artifact uploads from ci-test.yml (#24717)
## Description
- Remove un-necessary artifact uploads from ci-test.yml
- Updated steps to use new format for $GITHUB_OUTPUT
#### Type of change
- Workflow file
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-06-21 19:33:58 +05:30
Aishwarya-U-R
2d8bc2bc2d
test: Cypress | Flaky fixes (#24673)
## Description
- This pR fixes few of flaky tests as part of CI Stabilization work:
    - ApiTests/API_Unique_name_spec.js - Loginviaapi() - added timeout
- Datasources/MsSQL_Basic_Spec.ts - Starting container at test level
since lot of CI recent failures in reg this until this is moved to TED

#### Type of change
- Script fixes (non-breaking change which fixes an issue)

## Testing
>#### How Has This Been Tested?
- [x] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-06-21 00:54:18 +05:30
Aishwarya-U-R
80dadf71dd
test: Cypress | Flaky fix (#24587)
## Description
- This PR fixes the below flaky points in Stabilizing CI:
- MobileResponsiveTests/AutoDimension_1_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)
 
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
>
>

## Checklist:
#### QA activity:
- [x] Added `Test Plan Approved` label after changes were reviewed
2023-06-18 22:21:30 +05:30
Aishwarya-U-R
084e28ab21
test: Cypress | Flaky fixes (#24581)
## Description
- This PR fixes the below flaky:
- ReconnectDatasource_spec.js
- ConversionAlgorithm_AutoLayout_Validation_BasicSpec.js
- Improves CreateApplication with intercept assert
- Changes all agHelper.AssertN.wStatus to assertHelper() method

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-06-18 10:25:16 +05:30
Aishwarya-U-R
959fdce6ac
test: Cypress | Flaky fixes (#24508)
## Description
- This PR improves the sign up method to work even if telemetry related
details are not asked at start
- Also alters the Commit message based on the repository/workflow or
push runs
 - Improves DragDropWidgetNVerify()
 - Fixes flaky TableV2/Inline_editing_spec.js spec with TS methods
 - Improved EditTableCell()
 - Skipping deleting apps during local runs for debugging purpose
 - Fixes PropertyPane_Search_spec.ts
- Fixed ever flaky AppNavigationWithMultiplePages_spec,
AppNavigationWithAutoLayout_spec

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?

- [X] Cypress CI runs
>
>

## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after changes were reviewed
2023-06-17 00:10:10 +05:30