Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
15,981 Commits 1 Branch 0 Tags 507 MiB
b6e7e8e62f
Commit Graph

8392 Commits

Author SHA1 Message Date
Shrikant Sharat Kandula
b6e7e8e62f
chore: Remove deprecated unused fields (#29831) 
These fields were used in migrations, that re now deleted. So these
fields became unused now.
 2023-12-27 14:34:41 +05:30
Hetu Nandu
fc34360b2a
fix: Context Switching fixes for Copy and Delete (#29841) 
## Description
Fixes issues related to Segmented Lists around Copy / Delete
interactions

- It introduces a method to remove any focus history for a url. This is
added whenever we delete or move an item to another page
- It manages redirects after deleting a JS / Query / Datasource


#### PR fixes following issue(s)
Fixes #29697
Fixes #29694
Fixes #29700
Fixes #29699

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Implemented new redirect logic after deleting JavaScript collections,
actions, and datasources to enhance user experience.
- Added custom routing for JavaScript collection creation and
management.

- **Enhancements**
- Updated focus history handling to improve navigation and entity
tracking within the app.

- **Bug Fixes**
- Fixed entity identification logic in test paths to ensure accurate
testing scenarios.

- **Refactor**
- Centralized datasource grouping logic for better maintainability and
performance.
- Optimized widget deletion process to handle multiple widgets
efficiently.

- **Documentation**
	- No user-facing documentation updates in this release.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-27 14:17:35 +05:30
Hetu Nandu
168053b2f2
chore: Move Add button to top (#29863) 
Moves the add pane to the top

Fixes #29861

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the layout and conditional rendering logic in the editor pane
for enhanced user experience and interface clarity.
- Streamlined button visibility and interaction across various sections
of the IDE, ensuring a more intuitive workflow when adding new elements.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-27 12:37:33 +05:30
albinAppsmith
f266db27a5
feat: added analytics for segmented control navigation (#29852) 
## Description

Added analytics for page pane segments.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/29376


#### Type of change

- New feature (non-breaking change which adds functionality)

## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced navigation within the editor pane by introducing specific
navigation methods for different segments such as JS, Queries, and UI.

- **Refactor**
- Improved internal navigation handling to provide a more consistent
user experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-27 12:34:31 +05:30
Rahul Barwal
2fef626dcc
feat: adds see more to canvas starter templates (#29777) 
## Description
* This PR increases discovery of building blocks, allowing more building
blocks to be shown in canvas.
* We also refactored the way `add a page from template` functions: now
we have updated store structure to reflect from where the modal open was
triggered.
* This pull request refactors the template styling and adds support for
an optional modal layout. It also includes various updates and fixes to
the styled components used in the templates feature.

#### PR fixes following issue(s)
Fixes #29723
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- New feature (non-breaking change which adds functionality)
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Implemented a modal for template selection with the ability to hide
it.
	- Added a "See More" text option for template page layouts.
	- Introduced layout switching capability within the templates modal.

- **Enhancements**
	- Updated template list and content components to support modal layout.
	- Added initial filter state management for template filtering.

- **Refactor**
	- Renamed selectors and actions for clarity and consistency.
- Improved logic for determining template forking and filter component
behavior.

- **Bug Fixes**
	- Adjusted styles to correctly apply margins in various layouts.

- **Documentation**
	- Updated messages and constants with more accurate terminology.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-27 10:29:33 +05:30
Preet Sidhu
fa7bd6a543
feat: add layouts and widgets for sections and zones. (#29713) 
## Description

1. Create Section Widget.
2. Create Zone Widget.
3. Create layouts and presets for Sections and zones.
4. Upate layout for Anvil Main Canvas.
5. Refactor BaseLayoutComponent. Separate renderer for edit and view
modes.
6. Add childrenMap context to avoid prop drilling through all layouts.
7. Add Anvil Config for WDS widgets.

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress

#### Test Plan

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new `Zone Stepper Control` component for UI interaction.
- Added `AnvilCanvas` and `AnvilMainCanvas` components with improved
performance and interaction features.
- Implemented `LayoutProvider` and `useClickToClearSelections` for
better layout management.
- Launched `AnvilCanvasDraggingArena` and `AnvilHighlightingCanvas`
components with enhanced drag-and-drop capabilities.
- New `useZoneMinWidth` hook to calculate minimum zone width based on
child widgets.
- Added `SectionRow`, `Section`, `ZoneColumn`, and `Zone` components for
advanced layout structuring.
  - New `WidgetRenderer` component for dynamic child widget rendering.

- **Enhancements**
- Improved canvas activation and deactivation logic with
`useCanvasActivation` and `useCanvasActivationStates`.
- Enhanced drag-and-drop experience with updated `useCanvasDragging`
logic.
- Streamlined `AnvilMainCanvas` integration with conditional rendering
based on `renderMode`.
- Optimized `FlexLayout` component to handle new `isContainer` and
`layoutType` properties.

- **Bug Fixes**
- Fixed issues with widget positioning and event handling in
`WidgetNamesCanvas` components.
- Corrected `PageView` width property type for consistent page
rendering.

- **Refactor**
- Consolidated Anvil layout update management with `anvilSagas` and
`anvilChecksSagas`.
- Refined `SectionWidget` and `ZoneWidget` configuration for improved
stability and performance.
- Streamlined `LayoutElementPositionsObserver` with `layoutType`
enhancements.

- **Documentation**
- Updated comments and added clarifications for better developer
understanding of canvas-related hooks and components.

- **Style**
- Modified `.anvil-canvas` class styles for full-width and height
presentation.

- **Chores**
- Cleaned up import statements and removed unused code across various
components and utilities.

- **Tests**
- Enhanced Cypress tests with additional selectors and interaction
commands for `AutoDimension` feature verification.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
 2023-12-26 09:16:58 -05:00
Vaibhav Chobisa
6a6405227d
fix: clearInterval only clears the 'id' passed as the argument, instead of all the intervals (#29805) 
## Description
clearInterval() method is removing all the intervals defined using
setInterval(). This fix will make clearInterval() work as expected, that
is, remove only the intervals whose respective 'id' has been passed as
an argument to it.

#### PR fixes following issue(s)
Fixes #29725 

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
Relevant Jest tests added to the file: interval.test.ts
#### How Has This Been Tested?
- [x] Manual
- [x] Jest

#### Test Plan
Tests added to the file: interval.test.ts

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved interval management by ensuring that `clearInterval` now
correctly removes only the targeted interval, preserving others.
  
- **Tests**
- Expanded test coverage for interval-clearing functionality to validate
the precise removal of intervals.
  
- **Refactor**
- Updated function imports to correctly reference interval clearing
methods, enhancing the accuracy of interval manipulations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-26 15:15:53 +05:30
Rahul Barwal
12ac67a373
fix: Icons not coming up in start with template flow. (#29857) 
## Description
This PR registers the editor widgets in the TemplateView component by
calling the `registeEditorWidgets` function from `EditorUtils`. This
ensures that the necessary widgets(&icons) are available for use in the
start with template flow.

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the initialization process of the editor for enhanced
performance and reliability.

- **New Features**
- Integrated new widgets into the editor to expand functionality for
users.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-26 14:49:08 +05:30
albinAppsmith
7cef42d656
fix: Blank states sidebar (#29768) 
## Description

This PR fixes all the blank states in the left pane of the editor.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/29696

#### Type of change

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)


## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Streamlined the user interface by simplifying components and removing
unnecessary permission checks.
- Consolidated empty state messaging across different sections for a
more unified user experience.

- **Style**
- Updated iconography in the IDE sidebar for better visual
representation.

- **Documentation**
  - Improved in-app messaging and descriptions to enhance user guidance.

- **Bug Fixes**
- Fixed conditional rendering issues to ensure consistent display of
empty states when no items are present.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-26 14:39:14 +05:30
Ankita Kinger
410a55cf3c
fix: Refactoring code to fix a couple of issues related to modules on EE (#29843) 
## Description

Refactoring code to fix a couple of issues related to modules on EE

#### PR fixes following issue(s)
Fixes [#29842](https://github.com/appsmithorg/appsmith/issues/29842)
[#29445](https://github.com/appsmithorg/appsmith/issues/29445)

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
  - Introduced a new interface for improved action context handling.
  - Added functionality to create API actions based on the editor type.
- Implemented a new hook for retrieving parent entity information in the
datasource editor.

- **Refactor**
- Updated various components to utilize the new
`ActionParentEntityTypeInterface`.
  - Enhanced reducer logic for better handling of action configurations.
  - Streamlined entity exports and imports for consistency.

- **Bug Fixes**
- Fixed redirection logic in the Datasource Blank State component for a
smoother user experience.

- **Chores**
  - Removed unused event listeners from sagas to optimize performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-26 11:38:00 +05:30
Aman Agarwal
5daaf98452
fix: updated the design for the admin users (#29712) 
## Description
This PR updates the design of the admin users UI for profiling questions
to newer version. Below are the list of changes introduced in this PR :
- Deprecated `role` property for the user
- Updated components to reuse the similar UI
- Updated the background image for the admin setup screen
- before <img width="1325" alt="Screenshot 2023-12-21 at 10 29 52 PM"
src="https://github.com/appsmithorg/appsmith/assets/7565635/31cc44b6-4534-4a6a-a5e4-1e84b2d5705c">


- after <img width="1295" alt="Screenshot 2023-12-21 at 10 51 58 PM"
src="https://github.com/appsmithorg/appsmith/assets/7565635/c4181ded-ec7d-4b68-8b3c-3d0699d00c9c">


- Changed the profiling questions for the admin second page while
setting up the instance
- before <img width="1273" alt="Screenshot 2023-12-21 at 10 30 16 PM"
src="https://github.com/appsmithorg/appsmith/assets/7565635/6f7c5c8c-7f9f-470b-bb2e-3e94b1a741fc">

- after <img width="1311" alt="Screenshot 2023-12-21 at 10 51 48 PM"
src="https://github.com/appsmithorg/appsmith/assets/7565635/355c4123-a686-4423-a312-5e67c1c39c13">


#### PR fixes following issue(s)
Fixes #29692
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new `UserWelcomeScreen` component to enhance the user
onboarding experience.
  - Added a proficiency level selection to the user setup process.
  - Updated the use case selection options for a more tailored setup.

- **Bug Fixes**
- Fixed issues with form input handling for proficiency and use case
selections.

- **Refactor**
- Streamlined the setup process by removing role selection and custom
use case input.
  - Refined the user interface elements related to the setup forms.

- **Documentation**
  - Updated constant messages to align with the new setup flow.

- **Style**
- Implemented new styles for the `WelcomeBackground` and its components
to improve visual appeal.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-25 17:54:46 +05:30
ashit-rath
f507acf544
chore: submenu refactor for modules IA changes (#29837) 
## Description
PR refactors the submenu for query creation to pull out the content Ui
to a separate component for reuse

#### PR fixes following issue(s)
EE PR https://github.com/appsmithorg/appsmith-ee/pull/3188

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved the Editor's file explorer by separating the menu content
into a new component for better code organization.

- **New Features**
- Introduced a search feature within the file explorer to filter file
operations quickly.

- **Documentation**
- Added type definitions and comments for the new `ExplorerMenuContent`
component and its props for clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-25 13:17:18 +05:30
Hetu Nandu
8f322a7504
fix: Moves property pane width context state to Editor level (#29806) 2023-12-22 21:56:58 +05:30
Pawan Kumar
72ace3e6ef
chore: Split Text widget (#29789) 
Fixes #29446 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Introduced `WDSHeadingWidget` for enhanced heading elements.
  - Launched `WDSParagraphWidget` for improved paragraph formatting.

- **Refactor**
- Transitioned from `WDSTextWidget` to more specific text-related
widgets: `WDSHeadingWidget` and `WDSParagraphWidget`.
  
- **Style**
- Updated widget styles to reflect new static color assignments and
semantic changes.
  
- **Documentation**
- Updated widget names in configuration files to align with new naming
conventions.
  
- **Chores**
  - Removed unused color configuration code from `styleConfig.ts`.
  
- **Tests**
  - Adjusted tests to accommodate new widget structure and naming.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-22 15:08:00 +03:00
Aishwarya-U-R
39ebef39a5
test: Cypress | Replace static with Dynamic checks (#29664) 
## Description
- This PR removed static wait from spec - API_with_List_Widget_spec
- Git/GitSync/GitSyncedApps_spec.js (fixes for EE flakyness - WIP -
still failing in chrome, pass in electron)
- Remove wait from OpenPaneAndChangeThemeColors() & added n/w check
- Upgrading Cypress from 13.3 to 13.6
- Flaky fix:
      - ClientSide/Widgets/Text/Text2_Spec.ts
      - ClientSide/Widgets/Select/Select2_Spec.ts
      - cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts
      - /ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced Git synchronization capabilities with improved user interface
interactions.
  - Streamlined navigation back to the editor from deployment mode.
- Implemented more robust table loading checks to ensure data is
properly displayed.

- **Bug Fixes**
- Fixed issues with element presence assertions to improve test
reliability.
- Addressed the visibility of certain UI elements to ensure they appear
as expected.

- **Tests**
- Updated end-to-end test scripts to reflect new interactions and
assertions.
- Added a new test file `GitSyncedApps_spec.js` to cover Git-synced
applications.
  - Removed outdated test file `Fork_Template_spec.js`.

- **Refactor**
- Improved method calls for querying and interacting with elements to
enhance test stability.
- Optimized wait conditions for element visibility to reduce flakiness
in tests.

- **Chores**
- Adjusted the GitHub Actions workflow for client-server build to refine
output for matrix counts.
- Updated CI test workflow to incorporate Electron setup and remove
Chrome setup steps.

- **Documentation**
- Included comments to explain the rationale behind certain timeout
values and method changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-22 17:20:05 +05:30
Rudraprasad Das
8ce2521919
feat: autocommit UI integration (#29755) 
## Description
- Integrates auto-commit UI with server
- Adds analytics

#### PR fixes following issue(s)
Fixes #29753

#### Media
<img width="1728" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/8724051/a463794b-254d-4090-92b2-0a45a5645a3d">

#### Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Implemented auto-commit toggling for Git synchronization.
  - Introduced progress polling for auto-commit operations.
  - Added retrieval of Git metadata to enhance user experience.

- **Enhancements**
- Improved user feedback with success toasts for enabling/disabling
auto-commit.
- Streamlined Git-related analytics with new event tracking for
auto-commit actions.

- **User Interface**
- Updated Git settings UI to reflect the new auto-commit feature and its
status.

- **Bug Fixes**
  - Resolved issues with incorrect Git metadata display.
  - Fixed inconsistencies in auto-commit state management.

- **Refactor**
  - Refactored Git Sync state management for clarity and efficiency.
- Optimized Git-related selectors for better performance and
reliability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-22 16:36:54 +05:30
sneha122
7ee713bf6c
fix: plugins not loaded during onboarding issue fixed (#29786) 
## Description

This PR fixes issue of plugins not being seen on datasources page during
onboarding:
https://theappsmith.slack.com/archives/C05P3ME9MBR/p1703035861780029

**Root cause:**
The issue occurs because workspaceId is not present when we make an API
call to fetch all plugins. WorkspaceId comes from an API
`applications/new` and this API is called once we answer following
onboarding questions
![Screenshot 2023-12-21 at 3 49 24
PM](https://github.com/appsmithorg/appsmith/assets/30018882/aa1a00a4-cff4-4715-810a-88bd13c6facc)

Now If the API call gets completed before we select start with data
options, we get workspaceId and we are able to proceed ahead to fetch
plugins, but if this API call is not completed by the time we select
start with data, workspace id not available hence we dont see any
plugins.

**Solution:**
To make sure that we do not face such issue and we always workspace Id
available before we show 3 onboarding options, I have added a condition
of workspace Id for loading the component which shows 3 options, this
way 3 options will be shown only if workspace id is available, meaning
only if above API call is complete.


#### PR fixes following issue(s)
Fixes #29784 
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Conditional display of the 'Create New Apps' option based on workspace
selection.

- **Refactor**
- Enhanced `ApplicationProps` interface to include `currentWorkspaceId`.

- **Style**
- Visual updates to the 'Applications' page when creating new
applications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
 2023-12-22 14:32:24 +05:30
Hetu Nandu
1eb07585ca
chore: Editor Embedded Add Pane (#29764) 
## Description

Embeds the Add Pane experience inside Editor state itself. We will no
longer show the Add Pane in a new state which can only be accessed via
the Sidebar.

#### PR fixes following issue(s)
Fixes #29513

#### Media


https://github.com/appsmithorg/appsmith/assets/12022471/64f959f7-9dce-42cc-8645-3fc9dc77c153



#### Type of change
- New feature (non-breaking change which adds functionality)
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Introduced a new function to build global addition URLs.
  - Added new path configurations for enhanced routing capabilities.
- Implemented a new `GlobalAdd` component for creating queries, APIs,
and JS objects.
- Updated the `EditorPane` to include new segments and functionalities.

- **Enhancements**
  - Improved the IDE's main pane with additional routing options.
  - Enhanced the editor pane with a new UI for adding global elements.
- Streamlined the left pane in the IDE to integrate with the updated
editor pane.

- **Bug Fixes**
  - Corrected layout and scrolling behavior in various IDE components.

- **Documentation**
- Updated event tracking with the addition of "ADD_PANE" to the
analytics enum.

- **Refactor**
- Refined the `EditorPaneSegments` component for better clarity and
performance.
- Optimized the rendering logic in several components for better user
experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-22 13:51:47 +05:30
Rishabh Rathod
2f15b55131
fix: type error on ee (#29807) 2023-12-22 13:46:58 +05:30
Jacques Ikot
c8217e63a5
feat: improve templates listing page in start with templates flow (#29524) 
## Description
Enhancements to Templates Gallery:

1. Fixed Template Heights:
Adjusted the template card display to feature a fixed height for each
template, providing a consistent and visually appealing layout.

2. Title Update to "Operations":
Revised the section title from "Templates" to "Operations" to better
reflect the purpose and content of the gallery.

3. New Card for Building Blocks:
Created a new card to accommodate building blocks seamlessly. This
enhancement ensures a more comprehensive representation of the available
elements within each template.

4. Transition to Grid Layout:
Replaced the Masonry layout with a grid structure for improved alignment
and visual harmony between templates and building blocks. This change
enhances the overall organization and presentation of content within the
gallery.

Figma -
https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=4293-41441&mode=design&t=nPvqyNdtbtsKmvm2-0

#### PR fixes following issue(s)
Fixes #29456 

#### Media

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced styled components for improved layout and design of
building block templates.
- Added a new "Fork" button with tooltip functionality to Building Block
components.
- Implemented a grid layout for template presentation using the new
`TemplateGrid` styled component.
- Created a `FixedHeightTemplate` component to enforce consistent sizing
and text truncation for template elements.

- **Enhancements**
- Updated the `BuildingBlock` component to support a new
`onForkTemplateClick` event.
- Refined the visual presentation and layout of templates with updated
CSS styles.
- Improved the template filtering interface with new selectors and
loading indicators.
- Enhanced the `TemplatesContent` component to include search
functionality and display the count of templates and filters.

- **Bug Fixes**
- Fixed issues with template rendering by replacing the use of `Masonry`
with `TemplateGrid`.
- Adjusted the `RequestTemplate` component to correctly display the
request text based on the `isBuildingBlock` prop.

- **Refactor**
- Refactored the `TemplatesContent` component into
`StartWithTemplateContent` and `StartWithTemplateFilters` for better
modularity.
- Removed redundant code and imports across various template-related
components and files.
- Streamlined test scripts by introducing custom helper functions for
template interactions.

- **Documentation**
- Added a new message constant `REQUEST_BUILDING_BLOCK` for requesting
building blocks.

- **Style**
- Applied updated styles to the `SearchWrapper` and
`ModalContentWrapper` components for better visual consistency.

- **Chores**
- Updated the `TEMPLATE_BUILDING_BLOCKS_FILTER_FUNCTION_VALUE` constant
to reflect the correct terminology.

- **Tests**
- Modified test cases related to filtering templates and forking
templates to reflect changes in the UI and functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>
 2023-12-22 13:41:35 +05:30
Rishabh Rathod
feea8bec11
chore: JSModule Action selector CE changes (#29799) 2023-12-22 12:39:05 +05:30
Valera Melnikov
ad256ed64a
feat: add readonly mode to input (#29778) 
## Description
Add readonly mode for input component and widgets

#### PR fixes following issue(s)
Fixes #29145 

#### Media


https://github.com/appsmithorg/appsmith/assets/11555074/2d42a2bf-603b-4b30-a74c-6c1edd408216

![Снимок экрана 2023-12-20 в 20 13
43](https://github.com/appsmithorg/appsmith/assets/11555074/bbb45fee-65ae-4f0b-8681-33713bee079f)

#### Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a "Read-only" mode for input fields, enabling users to view
data without the ability to modify it.

- **Enhancements**
- Improved input components to respect both disabled and read-only
states.
  - Updated widget properties to include read-only configurations.

- **Style Updates**
- Standardized padding across various components to use spacing
variables for consistency.

- **Documentation**
- Added "Read-only" property documentation to relevant component
interfaces and configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 15:03:28 +03:00
vadim
d98dd29b4c
chore: WDS shadows quick fix (#29788) 
Fixes #29744 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the Dark Mode theme with enhanced shadow elevations for better
visual depth.
- Refined the Light Mode theme by adjusting transparency levels for a
cleaner appearance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 14:48:42 +03:00
Pawan Kumar
d74f0fe9f3
chore: move orientation and label position to content tab" (#29737) 
Fixes #29428 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new configuration options for widget orientation and label
position, allowing users to customize their widgets to be either
horizontal or vertical and to position labels on the left or right.

- **Refactor**
- Simplified the property pane configurations by removing unused style
configurations, streamlining the setup for users.

- **Chores**
- Cleaned up widget configuration code for Checkbox Group, Radio Group,
and Switch Group widgets to enhance maintainability and user experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 12:03:30 +03:00
Aishwarya-U-R
c03e04aedb
test: Cypress | Flaky fix SetOptions_Spec.ts for EE failure (#29767) 
## Description
- This PR fixes SetOptions_Spec.ts which is flaky in EE

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Improved wait conditions and element retrieval methods for enhanced
end-to-end test reliability.
  - Updated assertions to improve test accuracy and stability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 14:32:38 +05:30
Ankita Kinger
1c6f026970
chore: Refactor JS action entity button checks (#29774) 
## Description

Refactoring JS action entity button checks

#### PR fixes following issue(s)
Fixes [#29762](https://github.com/appsmithorg/appsmith/issues/29762)

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Simplified display logic for JavaScript collections by removing unused
properties.
  
- **Bug Fixes**
- Corrected the conditional display of context menus and edit icons in
the JavaScript editor.

- **Style**
- Updated user interface elements to reflect changes in display
properties.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 14:26:49 +05:30
Ankita Kinger
235122e7e3
chore: Refactoring API wiring for actions and JS actions to support private entity renaming on EE (#29763) 
## Description

Refactoring API wiring for actions and JS actions to support private
entity renaming on EE. Also handles a couple of other issues (refer the
issue attached below)

#### PR fixes following issue(s)
Fixes [#29762](https://github.com/appsmithorg/appsmith/issues/29762)

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced action and JS object naming capabilities with new
context-aware options.
  - Added support for organizing actions and JS objects within modules.

- **Improvements**
- Streamlined the process of renaming actions and JS objects to be more
intuitive and context-sensitive.

- **Refactor**
- Updated internal type declarations for consistency and future
extensibility.

- **User Interface**
- Improved UI elements to reflect the new naming and organizational
features for actions and JS objects.

- **Bug Fixes**
- Corrected logic to ensure proper handling of the `isPublic` flag
within JS collections.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 10:22:54 +05:30
Rahul Barwal
2b1e450559
fix: Show connect your data prompt correctly (#29705) 
## Description

**Problem** 
We noticed that some users go through "start with data" option and then
"forks a starter building block from canvas", this condition prevents
showing the popup if datasource is already connected.

With this PR we add a check, to ensure that if user already has some
datasources then it prevents showing the popup if datasource is already
connected.

#### PR fixes following issue(s)
Fixes #29680

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the logic for displaying the datasource prompt in the editor
to enhance user experience.
  - Optimized data retrieval for app-wide datasources.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-21 10:05:48 +05:30
vadim
23c911d5be
chore: Adjust inner spacing (#29765) 
Closes #29423 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the visual styling of the TagGroup component, including
adjustments to tag height, padding, and margin for a cleaner and more
streamlined appearance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-20 15:55:24 +03:00
ashit-rath
3924fd61b7
chore: action editor right pane refactor (#29757) 
## Description
Add flags to enable/disable viewing certain sections of Actions right
side pane.

Applies to showing the bindings, schema sections
Condition to hide the complete right pane when none of the sections are
allowed to show.

#### PR fixes following issue(s)
Fixes for PR https://github.com/appsmithorg/appsmith-ee/pull/3164

#### Type of change
> Please delete options that are not relevant.
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a toggle to show or hide schema information in the Action
Sidebar.
- Added a feature to suggest widgets based on the current context in the
Query Editor.

- **Enhancements**
- Improved conditional rendering logic for displaying the right pane in
the API and Query Editors.
- Streamlined the import of DatasourceStructureContainer for better
maintainability.

- **Refactor**
  - Renamed `SomeWrapper` to `ActionRightPaneWrapper` for clarity.
- Created a custom hook `useShowSchema` to handle the visibility of
schema information.

- **Documentation**
- Updated interface `QueryEditorContextContextProps` to include the
`showSuggestedWidgets` property.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-20 18:02:09 +05:30
Pawan Kumar
369b9021bb
fix: WDS PhoneInput input area displays “+” & country code in different lines (#29756) 
Fixes #29362 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated the `TextInput` component documentation to reflect the new
`startIcon` property change.

- **Style**
- Adjusted CSS selectors for improved targeting of start and end icons
within text input fields.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-20 13:39:26 +03:00
Hetu Nandu
8e88676243
fix: Widget Context Switching (#29735) 
## Description
Fixes context switching issues related to Widget List ensuring it also
works for current prod


#### PR fixes following issue(s)
Fixes #29695


#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Added a search functionality to the app.
- Integrated a search bar at the top of the `Hero` component and a
`Search` component to the `App` component.
  - Included styles for the search bar in the application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-20 12:26:16 +05:30
albinAppsmith
a185256f6a
fix: Added height to new query button menu (#29729) 
## Description

This PR adds a fixed height to the new query button in datasource config
page.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/29609


#### Type of change

- Bug fix (non-breaking change which fixes an issue)


## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated the action button to have a conditional height based on the
number of pages for improved layout consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-20 12:19:28 +05:30
Shrikant Sharat Kandula
078ef8a538
chore: Cleanup of some deprecated objects (#29577) 2023-12-20 11:34:46 +05:30
Apeksha Bhosale
93f284a50b
fix: make js updates only for application js objects (#29745) 
## Description
update should happen only for js objects which are created on a page not
for js modules and it's js objects. Adding sanity check which uses
selector to fetch only js objects created on page



#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
 2023-12-20 11:22:50 +05:30
Apeksha Bhosale
b39a0cba6f
fix: on click bug fix (#29743) 
## Description
filtering query modules from all modules to show it on action selector


#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the handling of module instances in the user interface to
enhance performance and stability.

- **Bug Fixes**
- Fixed an issue where certain data types were incorrectly handled,
ensuring consistency and reliability in the app's data management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-19 19:50:31 +05:30
Pawan Kumar
1f38d7333a
chore: add action group component (#29645) 
Fixes #29425 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Introduced an icon alongside menu items, with positioning options.
- Implemented a new `ActionGroup` component to manage a group of actions
with overflow behavior and keyboard navigation.
- Added new `ActionGroupItem` and `MoreIcon` components for action
groups.

- **Enhancements**
- Improved resize handling in the `ThemeProvider` for conditional
rendering based on measurements.
- Updated button styles to adjust minimum inline sizing for better
layout.

- **Documentation**
- Created Storybook stories to showcase `ActionGroup` configurations and
usage.

- **Style**
- Modified list item styling in the `Menu` component to incorporate
icons.

- **Tests**
  - Added mock for `useDebounce` hook in `AppsmithIDE` tests.
- Updated Cypress test assertions to accommodate changes in layout
behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Valera Melnikov <valera@appsmith.com>
 2023-12-19 16:04:27 +03:00
Ankit Srivastava
92d5554118
chore: added intercom consent analytics event (#29722) 2023-12-19 18:08:33 +05:30
Rohan Arthur
dcad2189ff
chore: changes the copy of the profiling questions (#29707) 2023-12-19 17:51:05 +05:30
Apeksha Bhosale
ad8c0d8f82
fix: added analytics function to execute js function on js editor (#29733) 
## Description
separated analytics function to get correct data for action execution.
This was creating problem inside package editor as application data was
not present.

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Integrated analytics tracking for action execution to enhance insights
into user interactions with plugins.

- **Refactor**
- Streamlined event logging in action execution by consolidating
analytics data into a single object.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-19 16:28:02 +05:30
ashit-rath
1fbfb28abf
chore: reset entities reducers on editor unmount (#29565) 
## Description

Reset widgets, actions and jsCollection on application unmount.
This is to make sure no entities get into workflows or modules editor

#### PR fixes following issue(s)
PR for https://github.com/appsmithorg/appsmith-ee/pull/3138

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Implemented a feature to reset the editor to its initial state across
various components.

- **Refactor**
  - Enhanced state management to ensure a consistent reset behavior.

- **Chores**
- Updated internal state handling to improve performance and
reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-19 16:01:44 +05:30
Nilansh Bansal
10005794dd
feat: http2 support for REST API and GraphQL (#29304) 
## Description
> This PR adds a selection dropdown for the HTTP Version in the REST API
and GraphQL plugins.

#### PR fixes following issue(s)
Fixes #28226 


#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced support for selecting different HTTP protocol versions when
configuring APIs.

- **Enhancements**
- Improved user interface for API configuration with a new dropdown to
select HTTP protocol versions.

- **Bug Fixes**
- Fixed an issue to ensure that the API configuration now correctly
displays protocol labels in dropdown menus.

- **Documentation**
- Added user-friendly placeholders and titles for secure and fast API
connection settings.

- **Refactor**
- Enhanced internal methods to support the selection of HTTP protocol
versions for API actions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Aman Agarwal <aman@appsmith.com>
 2023-12-19 15:56:20 +05:30
Valera Melnikov
862cdded5a
chore: add shadow elevation color tokens (#29708) 
Fixes: #29702
 2023-12-19 10:43:06 +03:00
Ankita Kinger
cc61ca4c47
chore: Refactoring queries/JS section on entity explorer to support private entities on packages (#29703) 
## Description

Refactoring queries/JS section on entity explorer to support private
entities on packages

#### PR fixes following issue(s)
Fixes [#28495](https://github.com/appsmithorg/appsmith/issues/28495)

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
  - Introduced new search filtering capabilities in the global search.
- Enhanced the `EntityExplorer` component to selectively display files
based on new criteria.

- **Enhancements**
- Expanded `JSCollection` interface to support workflow associations and
contextual actions.

- **Refactor**
- Streamlined naming functions with the introduction of
`CreateNewActionKey` enum to ensure consistency in action creation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 22:37:32 +05:30
Jacques Ikot
9a38452fe5
fix: move canvas starter datasource prompt from entity explorer to sidebar button (#29559) 
## Description
In this fix, we've moved the canvas starter datasource prompt into the
newly introduced left side bar for data. This enhancement not only
ensures a more intuitive user experience but also establishes a clear
and cohesive relationship with the data button, streamlining the
workflow for a more efficient and user-friendly interface.

Notion -
https://www.notion.so/appsmith/Bring-in-data-modal-pops-up-in-the-wrong-place-after-the-new-sidebar-update-ecfe985e89944caeb618ea1a19398342?pvs=4

#### PR fixes following issue(s)
Fixes #29484 

#### Type of change
- Bug fix (non-breaking change which fixes an issue)
- 
## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Improved the visual layout of popover components for better user
interface alignment.

- **Refactor**
- Streamlined the user interface by removing the
`DatasourceStarterLayoutPrompt` from the `EntityExplorer` component.
- Enhanced the `SidebarButton` component to conditionally render the
`DatasourceStarterLayoutPrompt` based on context, ensuring a more
dynamic and responsive user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 21:23:49 +05:30
sharanya-appsmith
97d5e60842
test: Cypress - tags added - @tag.Workspace, @tag.Datasource, @tag.JS, @tag.PropertyPane (#29704) 
## Description
> Added tags to cases 
    -   cypress/e2e/Regression/ClientSide/Workspace - @tag.Workspace
    -  cypress/e2e/Regression/ServerSide/ApiTests - @tag.Datasource
    -  cypress/e2e/Regression/ServerSide/Datasources - @tag.Datasource
    -  cypress/e2e/Regression/ServerSide/GenerateCRUD - @tag.Datasource
    - cypress/e2e/Regression/ServerSide/JsFunctionExecution - @tag.JS
    - cypress/e2e/Regression/ServerSide/OnLoadTests - @tag.PropertyPane
    - cypress/e2e/Sanity/Datasources - @tag.Datasource
    - cypress/e2e/Regression/ServerSide/QueryPane -  @tag.Datasource

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
## Testing
> /ok-to-test tags="@tag.Workspace,  @tag.PropertyPane,  @tag.JS"

#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Enhanced test suites for Radio, Rating, and Select widgets with
metadata tags for improved categorization and filtering.
- Updated test descriptions and restructured test cases for better
clarity and organization.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 17:41:37 +05:30
sharanya-appsmith
58a8d4334e
test: Cypress - added tags - @tag.Radio, @tag.Rating, @tag.TextEditor, @tag.PhoneInput, @tag.IconButton, @tag.Maps, @tag.MenuButton, @tag.Progress, @tag.Statbox (#29693) 
## Description
> Added tags to cases 
- cypress/e2e/Regression/ClientSide/Widgets/Modal - @tag.Modal,
@tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/Multiselect -
@tag.Multiselect, @tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/PhoneInput -
@tag.PhoneInput, @tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/RTE - @tag.TextEditor,
@tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/Radio - @tag.Radio,
@tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/Select - @tag.Select,
@tag.Widget
-
cypress/e2e/Regression/ClientSide/Widgets/Others/StatBox_DragAndDrop_spec.js
- @tag.Statbox, @tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/Rating - @tag.Rating,
@tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/Others/Progress_spec.js -
@tag.Progress, @tag.Widget
- cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts -
@tag.Maps, @tag.Widget

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
## Testing
> /ok-to-test tags="@tag.Radio, @tag.TextEditor, @tag.PhoneInput,
@tag.Maps"

#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Enhanced test suites for Radio, Rating, and Select widgets with
metadata tags for improved categorization and filtering.
- Updated test descriptions and restructured test cases for better
clarity and organization.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 17:25:28 +05:30
sharanya-appsmith
31a091efdb
test: Cypress - added tags - @tag.Filepicker, @tag.Form, @tag.Iframe, @tag.Image, @tag.Input (#29689) 
## Description
> Added tags to 
- cypress/e2e/Regression/ClientSide/Widgets/Filepicker - @tag.Filepicker
    - cypress/e2e/Regression/ClientSide/Widgets/Form - @tag.Form
    - cypress/e2e/Regression/ClientSide/Widgets/Iframe - @tag.Iframe
    - cypress/e2e/Regression/ClientSide/Widgets/Image - @tag.Image
    - cypress/e2e/Regression/ClientSide/Widgets/Input - @tag.Input


#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> /ok-to-test tags="@tag.Widget" 
> /ok-to-test tags="@tag.Filepicker ,@tag.Image" 

#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Enhanced test suites with tags for better categorization and
searchability.
	- Improved test descriptions and reordered test steps for clarity.
	- Updated test suites to use arrow functions for consistency.

- **Tests**
- Expanded test coverage for file picker widgets, including additional
file formats.
	- Added new test cases for form widget functionalities and validations.
	- Refined iframe widget tests to verify different aspects separately.
- Adjusted image widget tests and input widget tests for improved
validation and functionality checks.

- **Chores**
- Updated tags.js file to reflect the latest tagging conventions for
tests.

- **Style**
- Standardized formatting across various test suites to maintain code
cleanliness and readability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 17:24:59 +05:30
sharanya-appsmith
59f4d9d422
test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682) 
## Description
> Added tags to cases in 
- cypress/e2e/Regression/ClientSide/PropertyPane
- cypress/e2e/Regression/ClientSide/ThemingTests
- cypress/e2e/Regression/ClientSide/Refactoring
- cypress/e2e/Regression/ClientSide/ProductRamps
- cypress/e2e/Regression/ClientSide/Performance
- cypress/e2e/Regression/ClientSide/PeekOverlay


#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> /ok-to-test tags="@tag.JS, @tag.Perf, @tag.Settings,
@tag.PropertyPane, @tag.Theme"

#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Enhanced test categorization with the addition of tags for better
filtering and identification across various test suites.
- Improved readability and maintenance of test cases through
reformatting and restructuring.
- Updated test suite options for improved test coverage and
identification.

- **Refactor**
- Optimized test setup and execution logic for several feature-related
test suites.

- **Bug Fixes**
- Adjusted test cases to accurately reflect application behavior,
particularly in toast message validation and property setting scenarios.

- **Documentation**
- Added comments for clarity in test code to aid in understanding test
case intent and functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 17:18:23 +05:30
sharanya-appsmith
78514dcbac
test: Cypress - tag - @tag.MobileResponsive (#29678) 
## Description
> Added tags to cases in 
- cypress/e2e/Regression/ClientSide/MobileResponsiveTests/

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
> /ok-to-test tags="@tag.MobileResponsive"

#### How Has This Been Tested?
- [ ] Manual
- [ ] Cypress


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Enhanced mobile responsiveness test suites with additional tags and
assertions to ensure consistent behavior across various devices.
- Improved test structure for clarity and better simulation of user
interactions on mobile viewports.
- Increased coverage for widget dimension validations after viewport
changes.

- **Refactor**
- Reorganized test cases and logic for a more streamlined testing
process.

- **Documentation**
- Updated test descriptions and added comments for better understanding
of test purpose and functionality.

- **Chores**
- Adjusted test suite setups and teardowns for optimized test execution.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
 2023-12-18 17:15:29 +05:30