b4ec1d9d5b
2611 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Sumit Kumar
|
0e54c57ead
|
feat: Oracle integration: Add support for DB schema and update error infra (#22634)
## Description - Update the Oracle plugin code to use newer error framework infra. - Add support to fetch DB schema and show dynamic query templates. - The following info is shown to the users as part of the DB schema: table names, column names for each table, column types, primary key, foreign key - Update static query templates. - Update datasource form to show mandatory fields with asterik mark - Update datasource validity check to return error on empty password field - Improve data read for the following types: `timestamp with local time zone` , `clob`, `nclob` - Minor refactor into modular re-usable functions Fixes #20794 #20795 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - JUnit TC to be added via separate PR. Another issue it open to track it. ### Test Plan [Test plan links](https://github.com/appsmithorg/TestSmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22Oracle+SQL+DB%22) ### Issues raised during DP testing https://github.com/appsmithorg/appsmith/issues/21487 ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [x] Test plan has been peer-reviewed by QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Added Test Plan Approved label after reviewing all Cypress tests - [ ] Added Test Plan Approved label after developers review JUnit tests |
||
|
Abhijeet
|
32e8224120
|
feat: Update existing app via JSON import (#22684)
## Description When a user wants to develop in an instance and deploy in another, the only way to update an app is via Git. In scenarios where this is not possible (either in Airgapped scenarios or due to the user's choice), the user cannot update the deployed app. This PR allows a user to update an existing app via JSON import. The original references will be maintained where applicable > TL;DR: Provide a way to update the existing application via JSON import in situations where Git sync is not an option. Fixes #22075 ### How to test? 1. Create a new workspace `WS1` 2. Create new app 3. Generate CRUD page 4. Export the application 5. Create new workspace lets's call this as `WS2` and import the exported app from step 4 6. Create another page `pageCreatedInWS2` in imported application in `WS2` 7. Export the updated application from `WS2` 8. Update existing application created in step 2 in `WS1` by importing the application which is exported from `WS2` in step 7 9. Updated application should have `pageCreatedInWS2` page ``` Curl for ref: curl --location '{{base_url}}/api/v1/applications/import/{{workspaceId}}?applicationId={{applicationId}}' \ --header 'Cookie: SESSION={{cookieSessionId}}' \ --header 'X-Requested-By: Appsmith' \ --form 'file=@{{JSON_FILE_TO_IMPORT}}' ``` ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## How Has This Been Tested? - Manual - JUnit ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Ayangade Adeoluwa
|
f87ba6a671
|
feat: Feat/add google sheets metdata (#22577)
This PR does three things: 1. Cleans up the Datasource Form page and makes the code more readable and discoverable 2. Adds the Account information for google sheets 3. Adds a way to render form configs specifically in view or edit modes. |
||
|
PiyushPushkar02
|
6843efcb0b
|
fix: Google Sheets Scope Label Change (#22548)
## Description - The following PR changes the label values seen by the user in the scope selection drop-down menu while creating a Google Sheet data source. - The changes accommodate for one specific scope that was present in the previous implementation and is not present now i.e read/write without delete permission for which a new scope has been added. - Also with these changes the migration for old data sources is not required since we have added all the previously used scopes here. - Figma Link: https://www.figma.com/file/TcFhqEbAc8ymHTRF5wR1qv/Limited-GSheet-Access?node-id=506-32761 - Notion link for migration: https://www.notion.so/appsmith/Google-Sheet-Migration-ab7bbfbdae1f40189a957b6ae5374145 Fixes #22327 ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Harsh Mange
|
25d8d3ed03
|
fix: [#21180] Firestore plugin -> "Timestamp Path" fix (#22646)
## Description > Firestore plugin -> "Timestamp Path" field must not be required field (isRequired: false) Closes #21180 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist: ### Dev activity - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Ayush Pahwa
|
ddfc329abe
|
feat: remove bloat from large files during upload (WIP) (#21757)
## Description Currently, we try to upload large files by converting their binaries into strings which leads to bloat in size. This is because converting to bytes in a multi-byte encoding usually takes a larger space and white characters are also included. We were also doing multiple modifications which were just adding to the bloat. Hence, we are now converting the binary data into an array buffer to prevent this. This buffer is added to the multi-part form data request as a new part and we add a pointer in the pace of the data which used to be present earlier. This allows us to have minimal bloat on the payload while sending the request. TLDR: fix for uploading large files by changing the data type used for upload. *TODO:* - [x] Client side payload changes - [x] Server side double escape logic fixes - [x] Server side tests - [x] Server side refactor - [ ] Cypress tests Fixes #20642 Media ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Nidhi Nair <nidhi@appsmith.com> |
||
|
subratadeypappu
|
f9d2849487
|
Fix stringified JSON response (#22450) (#22498)
## Description TL;DR This commit fixes unexpected stringified JSON in the following plugins - REST API Plugin - GraphQL plugin The detailed analysis can be found in the comment section of the issue itself (#22450) Slack Conversations - [1](https://theappsmith.slack.com/archives/C0341RERY4R/p1681123872154409) - [2](https://theappsmith.slack.com/archives/CGBPVEJ5C/p1681726446635249) > Add a TL;DR when description is extra long (helps content team) Fixes #22450 Media ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nidhi
|
7d1c4d87b6
|
ci: Fixed external dependencies in tests partially (#22639) | ||
|
Ankita Kinger
|
ae05e93ec9
|
chore: Removing feature flag for app level invites (#22650)
## Description Removing feature flag for app-level invites. Also, updating import statements to use `@appsmith/..` instead of `ce/..` Fixes [#22657](https://github.com/appsmithorg/appsmith/issues/22657) ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual - Jest - Cypress ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nilesh Sarupriya
|
a1bf46a850
|
chore: create a new index on permission groups for defaultDomainId & defaultDomainType (#22673)
## Description > Create a new index on permission group with `defaultDomainId` + `defaultDomainType` + `deleted` +`deletedAt` in order to improve the performance of the queries which are used to find the permission groups using `defaultDomainId` and `defaultDomainType`. > Also, we are going to remove an already existing index: `permission_group_workspace_deleted_compound_index` which was used earlier, when we were still dependent on `defaultWorkspaceId` Fixes #22674 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? > Tested locally by running the server. > Indices post the server start: ``` db.permissionGroup.getIndexes() [ { v: 2, key: { _id: 1 }, name: '_id_' }, { v: 2, key: { assignedToUserIds: 1, deleted: 1 }, name: 'permission_group_assignedUserIds_deleted_compound_index' }, { v: 2, key: { defaultDomainId: 1, defaultDomainType: 1, deleted: 1, deletedAt: 1 }, name: 'permission_group_domainId_domainType_deleted_deleted_compound_index' } ] ``` ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|
Vishnu Gp
|
e651f6242e
|
feat: To store user's Intercom email share consent on backend (#22648)
## Description Currently, there is no way for us to know any details about a user when they reach out to support via Intercom. Thus, we are not able to offer the right level of support to them basis their current plan. The idea is to ask for consent to share user details with Appsmith before Intercom is enabled for a user, the basis which support can determine the right level of support. This PR helps to store and retrieve the flag variable for a particular user which says whether the consent was given or not. Fixes #22611 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - JUnit ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nidhi
|
b3f1d53492
|
fix: Modified plugin documentation links (#22637)
## Description New links will lead users directly to the most relevant sections in the docs. ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
sneha122
|
a5c1c7a102
|
feat: disable spreadsheet entity in case of insert/delete one (#22490)
## Description This PR fixes: - When google sheet datasource is created with selected sheets scope, in this case we need to disable spreadsheet option in the entity dropdown of the query, so that user cannot delete/insert from selected sheets > Add a TL;DR when description is extra long (helps content team) Fixes #22152 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Manish Kumar
|
25513d169c
|
chore: update multiple-environments feature flag criteria (#22627)
## Description As part of ongoing efforts to improve our feature flagging process, this Pull Request updates the "multiple-environments" feature flag criteria to limit access to a specific list of email addresses, rather than the entire Appsmith domain. This will help to reduce the impact of the latest merges and ensure that only authorised users have access to the feature. Specifically, this Pull Request modifies the existing criteria for the "multiple-environments" feature flag and changes the access control from email domains to individual email addresses. This ensures that only users with approved email addresses can access the feature, and reduces the risk of unauthorised access or unintended consequences resulting from recent code merges. description generated by chatGPT The email addresses are as follows: 1. [me-eng1@appsmith.com](mailto:me-eng1@appsmith.com) 2. [me-eng2@appsmith.com](mailto:me-eng2@appsmith.com) 3. [me-qa1@appsmith.com](mailto:me-qa1@appsmith.com) 4. [me-qa2@appsmith.com](mailto:me-qa2@appsmith.com) 5. [me-demo@appsmith.com](mailto:me-demo@appsmith.com) > changed the feature flag strategy from emailDomain to email and assigned five emails Fixes #22626 ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag |
||
|
Rohan Arthur
|
8e0d683c9b
|
fix: tooltip in gsheets query pagination field (#22622)
## Description In the google sheets query for operation `Fetch Many`-->`Sheet Rows`, the tooltip is as follows:  this example is incorrect, it should be `...Table1.pageSize`, and not just `pageSize` Fixes #21384 ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual ### Test Plan ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Rohan Arthur <rohanarthur@Rohans-MacBook-Pro.local> |
||
|
Manish Kumar
|
77aeca27a0
|
feat: adding email property in google sheets (#22321)
## Description As a part of google sheet scope limitation, the email address is being added in datasource configuration. The email address is being stored in a property, an element in properties (`List<Property>`) with key: 'emailAddress' and value: (<emailId>) . In order to retrieve this property a GET call to endpoint `https://www.googleapis.com/drive/v3/about?fields=user` is being made. This property is being saved while google sheet datasource gets authorised, after access toke retrieval from cloud services. in the endpoint `/saas/{datasourceId}/token`. Since the flow is specific to google sheets, the main code is implemented in googlesheetPluginExecutor. The flow has three steps - Getting access token from datasourceConfiguration - making the call to googleApis and obtaining the email address - saving it back into datasource configuration The authorisation flow itself saves the datasource later on. > TL;DR Adding emailAddress in properties of datasource configuration when google sheets is authorised. Fixes #21902 - New feature (non-breaking change which adds functionality) ## This has been tested - Manual - JUnit ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag |
||
|
Nilesh Sarupriya
|
b9cb7a7c86
|
chore: add helper method to be used in ee (#22303)
## Description > Add a helper send analytics method for role assigned to users Fixes https://github.com/appsmithorg/appsmith/issues/21314 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? > This is a utility which will be used in EE code and will be tested there. ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|
Abhijeet
|
971eb06c08
|
feat: Update the Installation Setup Complete event to better track the analytics (#22572)
## Description This PR adds/updates the fields which are getting reported as a part of `Setup Complete Event` as a part of onboarding revamp project. Fixes https://github.com/appsmithorg/cloud-services/issues/675 ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nilesh Sarupriya
|
b90a14ce00
|
chore: change workspace update from save to update object (#22549)
## Description > Change the update workspace flow to update using the MongoTemplate `updateFirst` rather than Repository `save` Fixes # (issue) > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? > `testWorkspaceUpdate_checkAdditionalFieldsArePresentAfterUpdate` ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> |
||
|
Abhijeet
|
e310b0a97d
|
feat: Add support for datasource which can't be self-hosted for air-gapped version (#22393)
## Description In earlier PR we opted out for plugins that can't be self-hosted for airgap thinking that as public internet is not available there might not be any usecase for these plugins. But we are seeing multiple levels of air gapping needed where customers still want the support for a few plugins like S3, Redshift, Firestore etc. which are offered by hosting providers. https://theappsmith.slack.com/archives/C02K2MZERSL/p1681285395230519?thread_ts=1680632400.272319&cid=C02K2MZERSL Fixes https://github.com/appsmithorg/appsmith/issues/22230 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
dependabot[bot]
|
75f4e04b40
|
chore: bump json from 20220924 to 20230227 in /app/server/appsmith-interfaces (#22443)
Bumps [json](https://github.com/douglascrockford/JSON-java) from 20220924 to 20230227. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/douglascrockford/JSON-java/releases">json's releases</a>.</em></p> <blockquote> <h2>20230227</h2> <table> <thead> <tr> <th>Pull Request</th> <th>Description</th> </tr> </thead> <tbody> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/723">#723</a></td> <td>Protect JSONML from stack overflow exceptions caused by recursion</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/720">#720</a></td> <td>Limit the XML nesting depth for CVE-2022-45688</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/711">#711</a></td> <td>Revert pull 707 - interviewbit spam</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/704">#704</a></td> <td>Move javadoc comments above the interface definition to make it visible</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/703">#703</a></td> <td>Update Releases.md for JSONObject(Map): Throws NPE if key is null</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/696">#696</a></td> <td>Update JSONPointerTest for NonDex compatibility</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/694">#694</a></td> <td>Pretty print XML</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/692">#692</a></td> <td>Example.md syntax highlight and indentation</td> </tr> <tr> <td><a href="https://redirect.github.com/douglascrockford/JSON-java/issues/691">#691</a></td> <td>Create unit tests for various number formats</td> </tr> </tbody> </table> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md">json's changelog</a>.</em></p> <blockquote> <p>20230227 Fix for CVE-2022-45688 and recent commits</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/douglascrockford/JSON-java/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/appsmithorg/appsmith/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
dependabot[bot]
|
b6dbce0bf7
|
chore: bump snowflake-jdbc from 3.13.26 to 3.13.29 in /app/server/appsmith-plugins/snowflakePlugin (#22444)
Bumps [snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.13.26 to 3.13.29. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/snowflakedb/snowflake-jdbc/releases">snowflake-jdbc's releases</a>.</em></p> <blockquote> <h2>Release</h2> <ul> <li>Please Refer to Release Notes at <a href="https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes">https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes</a></li> </ul> <h2>Release</h2> <ul> <li>Please Refer to Release Notes at <a href="https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes">https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes</a></li> </ul> <h2>Release</h2> <ul> <li>Please Refer to Release Notes at <a href="https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes">https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst">snowflake-jdbc's changelog</a>.</em></p> <blockquote> <p><strong>JDBC Driver 3.13.29</strong></p> <ul> <li>|| Please Refer to Release Notes at <a href="https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes">https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes</a></li> </ul> <p><strong>JDBC Driver 3.13.28</strong></p> <ul> <li>|| Please Refer to Release Notes at <a href="https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes">https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes</a></li> </ul> <p><strong>JDBC Driver 3.13.27</strong></p> <ul> <li>|| Please Refer to Release Notes at <a href="https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes">https://community.snowflake.com/s/article/JDBC-Driver-Release-Notes</a></li> </ul> <p><strong>JDBC Driver 3.13.26</strong></p> <ul> <li>|| Upgraded the arrow library from version 9.0.0 to 10.0.1.</li> <li>|| Relocated files in META-INF/versions to META-INF/versions/<!-- raw HTML omitted -->/net/snowflake/client/jdbc/internal.</li> <li>|| Added the getNano() and getOffset() methods to the SnowflakeTimeWithTimezone object to return the number of nanoseconds and the time zone offset, respectively.</li> </ul> <p><strong>JDBC Driver 3.13.25</strong></p> <ul> <li>||<strong>BCR (Behavior Change Release) Change</strong></li> <li>||Caution: Version 3.13.25 of the Snowflake JDBC driver changes the default value of the allowUnderscoresInHost parameter to false. This change might impact PrivateLink customers with account names containing underscores. In this situation, you must override the default value by setting allowUnderscoresInHost true.</li> <li>||<strong>New Features</strong></li> <li>||Set the allowUnderscoresInHost parameter to false by default which converts underscores in account names to hyphens to avoid Apache httpclient connection error with underscores. This behavior can be turned off by setting allowUnderscoresInHost to true.</li> <li>||Updated the aws-java-sdk-bom library version from 1.11.394 to 1.12.327.</li> <li>||Added the enableReturnTimestampWithTimeZone parameter to set whether to include the timezone in a timestamp.</li> <li>||Added log warnings for each of the error return paths while parsing a SnowflakeConnectString.</li> <li>||Added commas to the SnowflakeDatabaseMetaData.getColumn() arguments to improve readability.</li> <li>||Added support for stored procedures.</li> <li>||<strong>Bug Fixes</strong></li> <li>||Fixed an issue related to using the GET command when GCS_USE_DOWNSCOPED_CREDENTIAL is true.</li> <li>||Fixed an issue related to returning result types when the session handle is NULL.</li> </ul> <p><strong>JDBC Driver 3.13.24</strong></p> <ul> <li>|| Upgraded the following libraries:</li> <li>|| arrow from version 8.0.0 to 9.0.0</li> <li>|| jacksondatabind from version 2.13.2.2 to 2.13.4.2</li> <li>|| google-cloud-storage from version 2.5.0 to 2.6.2</li> <li>|| Remove DML check on getUpdateCount()</li> </ul> <p><strong>JDBC Driver 3.13.23</strong></p> <ul> <li>|| Relocate Google Guava classes from com/google/common/util/concurrent/** in FIPS driver</li> <li>|| Return an empty resultset for getProcedures() when connected with a reader account</li> <li>|| Use parallelism parameter for PUT/GET with Azure</li> <li>|| Set default logger level for arrow project to SEVERE to avoid unwanted INFO messages</li> <li>|| login test params updated and test case added</li> </ul> <p><strong>JDBC Driver 3.13.22</strong></p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Sumit Kumar
|
ce81f3856d
|
fix: fix oracle plugin info (#22432)
## Description - Update plugin name to `Oracle` from `Oracle plugin` - Update plugin icon Related to #20796 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
sneha122
|
685bd13fb9
|
fix: gsheet ui issues fixed (#22384)
## Description This PR fixes for google sheet datasource create: - Remove asterics of scope - Copy of the permissions drop down should be "Read" instead of "Read Files" > Add a TL;DR when description is extra long (helps content team) Fixes #22383 > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|
Arpit Mohan
|
82607d0628
|
chore: Upgrading graphql dependency (#21809)
This PR upgrades the Graphql dependency to the latest stable release. Co-authored-by: Sumit Kumar <sumit@appsmith.com> |
||
|
Nilansh Bansal
|
40bd7733b2
|
fix: App nav upload logo thumbnail false (#22342)
## Description > This PR fixes the logo upload which was by default getting set to a thumbnail type size. Fixes #22293 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
subratadeypappu
|
094d0a917f
|
fix: Allow empty password in PostgreSQL trust authentication login (#22186)
This PR reclaims the changes introduced in this [PR](https://github.com/appsmithorg/appsmith/pull/19265) later which got reverted by this [PR](https://github.com/appsmithorg/appsmith/pull/20629) ## Description - The PR removes the empty password validation check for PostgreSQL while creating a new data source. - The JUnit test case is added for the same. Implemented using a separate PostgreSQL container with Trust Authentication enabled for the Same. - Please note for testing from UI perspective we have to create a user with Trust auth enabled to validate the above changes. Fixes #14003 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - JUnit ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
PiyushPushkar02
|
ac63cadf24
|
fix: Firestore Invalid DS Test Success (#21954)
## Description - The following PR fixes the issue where the firestore test data source was returning success even after providing an invalid project id. - The PR address the invalid project id only not the db URL as it is fetched from the auth json If the URL is invalid in user provided entry. Also, the value is mutable at runtime from the firestore side. - For more detailed description of the following can be found in the notion doc here: https://www.notion.so/Firestore-c3f5c816a68a45b18395da74be97d666 Fixes #21373 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual - JUnit ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Ankita Kinger
|
49fbaea769
|
fix: Improving UX on the members page and the invite modal (#22268)
## Description > Improving UX on the members page and the invite modal. Fixes [#22306](https://github.com/appsmithorg/appsmith/issues/22306) ## Type of change - Bug fix (non-breaking change which fixes an issue) - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nilansh Bansal
|
c552cb898f
|
fix: mixpanel publish event individual query counts added (#22341)
## Description > This PR adds individual Action counts for DB, API, JS, SAAS and REMOTE actions in mixpanel PUBLISH_APPLICATION event. Fixes #21536 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nayan
|
67a8d3b7fd
|
fix: Moved gitSyncId from BranchAwareDomain to BaseDomain (#22335)
## Description Moved `gitSyncId` from `BranchAwareDomain` to `BaseDomain` because it's changing property order in the git files. Fixes #22282 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Abhijeet
|
2b83f265fd
|
chore: Add helper methods for instance configuration class (#22296)
## Description For air gap instances, public internet will be restricted and as a result, API calls which will be made during the instance registration should be gracefully handled for air-gap isnatnce. As a part of this, the current PR creates a helper class from Instance config class to have a custom implementation on the EE repo. Corresponding EE PR: https://github.com/appsmithorg/appsmith-ee/pull/1263 Related issue: https://github.com/appsmithorg/appsmith/issues/21500 ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nilansh Bansal
|
54dfd18de6
|
fix: Revert PR 22157 (#22280)
## Description > This PR reverts the changes done in #22157 > Another PR will be raised post the blockers are fixed to create the `forkWithConfiguration` field as this can impact the users forking their apps directly. Fixes #21691 ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
SatVeer Singh
|
9dd1ef6ff0
|
fix: Hint text in create query (sql based datasources) (#22190)
## Description Improve hint text in SQL type queries. Fixes #22011 Fixes #22117 |
||
|
Abhijeet
|
bf3cb2e804
|
refactor: Seperate out service level methods to helper classes to have custom implementation in business edition (#21884)
## Description For air gap instances, public internet will be restricted and as a result, cron jobs that depend on cloud-services won't be supported. As a part of this, the current PR creates a helper class to have a custom implementation on the EE repo. Corresponding EE PR: https://github.com/appsmithorg/appsmith-ee/pull/1252 Fixes #21522 #21521 #21882 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nayan
|
a859f76343
|
chore: Move Git related meta data to new base domain class (#22065)
## Description This PR creates a new base class `BranchAwareDomain` from the `BaseDomain` class. This new base class will contain the Git related metadata. Any domain class that needs to be tracked by git should extend `BranchAwareDomain` class instead of `BaseDomain` class. Fixes #22063 |
||
|
Nayan
|
12686a2855
|
chore: Moved common methods of permission classes to base class (#22120)
## Description This refactoring PR moved common methods of permission classes to a new base class. Fixes #22127 ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual - JUnit tests - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
sneha122
|
67f7571f1e
|
fix: specific sheets to whole drive issue fixed (#21968)
This PR fixes the issue: - Spreadsheet dropdown does not show all sheets, when google sheet datasource is edited from specific sheets to all sheets. - If files are picked in the file picker, no error message is shown on datasource review page, but if files are not picked, error message is shown on review page. Fixes #21916 |
||
|
Nilansh Bansal
|
5645310887
|
feat: forkWithConfiguration flag added for forking app to a workspace (#22157) | ||
|
Sumit Kumar
|
d9442d2a7b
|
feat: Oracle Integration: Add support for Prepared Statements (#21744)
## Description
- This PR introduces support for prepared statements to the Oracle
integration that is currently behind a feature flag.
- Fixed a bug with PL/SQL cmd due to semicolon.
- Fixed a bug with reading Array type.
- The following tasks will be taken up separately and will not be part
of this PR. They will be resolved before lifting the feature flag:
- DB structure and query templates
- Error messages infra
- JUnit TC
- The following data types were tested: `char, varchar, array, int,
float, double, raw, timestamp, timestamp_tz, interval` . The following
cmd was used to test the feature:
```
select * from TYPESTEST4 where c_varchar2={{'varchar2'}}
and c_nvarchar2={{'nvarchar2'}}
and c_number={{1}}
and c_float={{11.22}}
and c_date={{'2002-10-03'}}
and c_binary_float={{11.22}}
and c_binary_double={{11.22}}
and c_timestamp=TO_TIMESTAMP({{'01-01-1997 09:26:50.124'}})
and c_timestamp_tz=TO_UTC_TIMESTAMP_TZ({{"1997-01-01T09:26:56.66+02:00"}})
and c_interval_day=NUMTODSINTERVAL({{1}}, {{'HOUR'}})
and c_char={{'char '}}
and c_raw=utl_raw.cast_to_raw({{'raw'}})
```
- `JSON` type could not be tested because it was only recently
introduced in version 21c. However, the Oracle test instance credentials
available on Notion are for 19c. Tracking it
[here](https://github.com/appsmithorg/appsmith/issues/20796).
Fixes #20533
## Type of change
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
- Manual
## How to Test
```
(1) Create a Table with various data types like:
create table typestest4 (
c_varchar2 varchar2(20),
c_nvarchar2 nvarchar2(20),
c_number number,
c_float float,
c_date date,
c_binary_float binary_float,
c_binary_double binary_double,
c_timestamp timestamp,
c_timestamp_tz timestamp with time zone,
c_timestamp_ltz timestamp with local time zone,
c_interval_year interval year to month,
c_interval_day interval day to second,
c_raw raw(256),
c_rowid rowid,
c_urowid urowid,
c_char char(256),
c_nchar nchar(256),
c_clob clob,
c_nclob nclob,
c_blob blob
)
(2) Insert data into the table:
insert into TYPESTEST4 values (
'varchar2',
'nvarchar2',
1,
11.22,
'03-OCT-02',
11.22,
11.22,
TIMESTAMP'1997-01-01 09:26:50.124',
TIMESTAMP'1997-01-01 09:26:56.66 +02:00',
TIMESTAMP'1999-04-05 8:00:00 US/Pacific',
INTERVAL '1' YEAR(3),
INTERVAL '1' HOUR,
utl_raw.cast_to_raw('raw'),
'000001F8.0001.0006',
'000001F8.0001.0006',
'char',
'nchar',
'clob',
'nclob',
utl_raw.cast_to_raw('raw')
)
(3) Run the following select cmd with prepared statement toggle on:
select * from TYPESTEST4 where c_varchar2={{'varchar2'}}
and c_nvarchar2={{'nvarchar2'}}
and c_number={{1}}
and c_float={{11.22}}
and c_date={{'2002-10-03'}}
and c_binary_float={{11.22}}
and c_binary_double={{11.22}}
and c_timestamp=TO_TIMESTAMP({{'01-01-1997 09:26:50.124'}})
and c_timestamp_tz=TO_UTC_TIMESTAMP_TZ({{"1997-01-01T09:26:56.66+02:00"}})
and c_interval_day=NUMTODSINTERVAL({{1}}, {{'HOUR'}})
and c_char={{'char '}}
and c_raw=utl_raw.cast_to_raw({{'raw'}})
```
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
|
||
|
Anagh Hegde
|
735d62d663
|
feat: exclude view mode only present resources during the export (#22133)
## Description > When the file is exported we include view mode resources which are not present in edit mode. This does not make sense and bloats the file. A user does not have a way to recover these resources. Hence removing these resources from the app export. Fixes #21997 ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Manual - JUnit ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Abhijeet
|
f66410ebcb
|
feat: Add functionality to opt out plugin from airgap instance (#22098)
## Description As a part of supporting airgap instances we want to restrict the plugins which have any public dependency. This PR introduces a config setting for plugins to opt out of airgap. Also as a part of this exercise we are also adding a setting for CS dependency which can be utilised in future if our customers wants to opt out of CS dependent plugins. Corresponding EE PR: https://github.com/appsmithorg/appsmith-ee/pull/1258 > TL;DR: Provide a way for plugins supported in Appsmith to opt-out of airgap instances Fixes https://github.com/appsmithorg/appsmith/issues/21499 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nilansh Bansal
|
f2b5931873
|
fix: Git Repo Not Found Error Message (#22116)
## Description > This PR fixes the git repo not found error message. Fixes #21338 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
Nilesh Sarupriya
|
72b820139e
|
chore: update workspace member comparator (#22009)
## Description > Comparator for sorting the workspace members. > The existing comparator in CE missed a few NULL conditions, for which we had to introduce a new comparator in EE. But we will now be using the updated comparator for both CE and EE. Fixes # (issue) > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? > Existing test cases pass. ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|
Sanveer Singh Osahan
|
c7f8b5b800
|
chore: Added test for various data types (#20069) (#21932)
## Description Added tests for querying various data types in MySQL plugin Fixes #20069 ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - JUnit ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|
sneha122
|
c8cd459f39
|
feat: Added file id mapping in datasource config (#21699)
## Description
This PR adds:
- File Id mapping of the google sheets selected by user, in datasource
configuration, so that when creating queries on top of such gsheet
datasource, only the selected spreadsheets can be seen in the
spreadsheet dropdown.
Changes done on client side:
- As soon as user selects file in file picker popup, the callback will
get the file ids and update the datasource to contain file ids as a part
of datasource configuration properties.
- If user cancels the file selection, file ids is sent as empty array
and datasource is updated.
Changes done on server side:
- In `GoogleSheetPlugin.java` where we have defined execute and trigger
methods for gsheet query, here I have added a new variable
allowedFileIds, which gets the list of authorised file ids from
datasource configuration object and the same list is passed to functions
like `transformTriggerResponse` and `transformExecutionResponse`, which
returns file list data based on the allowedFileIds. In FileListMethod
class, these methods contain the logic to send only authorised file
data.
- Since these two methods are a part of triggerMethod and
executionMethod interfaces, all gsheet query operation classes that
extend this method, their function definition needed to be updated with
this third allowedFileIds parameter.
- Similarly all gsheet query operations test classes were using these
two methods, and hence this third parameter needed to be added there as
well.
How to test:
- With this improvement, when we select `file1` and `file2` for one
datasource and `file3` and `file4` for another datasource, In the query
dropdown for first ds, we should only see `file1` and `file2`, for
second datasource, we should only see `file3` and `file4`.
- Please check following gsheet operations:
- Fetch Many
- Fetch Details
- Update One
- Update Many
- Insert Many
> Add a TL;DR when description is extra long (helps content team)
Fixes #21074
Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
## Type of change
> Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
- Manual
- JUnit
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
|
||
|
Anagh Hegde
|
641ca391f5
|
fix: Git connected apps are showing a status error (#22046) | ||
|
Nilesh Sarupriya
|
89bb0826af
|
fix: send additional data to analytics for cloud hosted instance (#21855)
## Description > Send additional data required for cloud hosted instance. Fixes #21857 Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - Bug fix (non-breaking change which fixes an issue) - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? > Tested manually. ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|
Abhijeet
|
bc156a0766
|
fix: Build failure because of access token signature difference in EE repo (#22044)
This PR fixes the build failure which got introduced because of the recent PR merged as a part of enabling default JsonView https://github.com/appsmithorg/appsmith/pull/21766 |
||
|
Shrikant Sharat Kandula
|
4280ded88e
|
chore: Fix unnecessary re-shading of jars (#21994)
Solves a single thing in the build configurations, resulting in a few
wins.
1. Reduced number of warnings in the output.
1. In release branch:
```
mvn clean package -DskipTests | grep --fixed-strings --count '[WARNING]'
3233
```
1. In this PR's branch:
```
mvn clean package -DskipTests | grep --fixed-strings --count '[WARNING]'
172
```
2. All uber-jar files are shaded twice, currently. Once with the default
execution of `maven-shade-plugin`, and again with the `shade-plugin-jar`
execution in these `pom.xml` files. This is double-work, and is the
cause of most of the warnings we see.
1. This `shade-plugin-jar` was added to have the plugin information
included in the `/META-INF/MANIFEST.MF` file, since we can't configure
the default execution of the shade plugin (it comes to us from Spring
Boot).
2. Instead, we switch to configuring plugin information in a
`/plugin.properties` file.
3. Previously, we used `/plugin.properities` for plugin information in
dev time, and `/META-INF/MANIFEST.MF` in production. This PR will change
it so that we use `/plugin.properties` all the time. We configure PF4J
with a custom plugin manager to achieve this.
3. Moved all `plugin.properties` into `src/main/resources`, so that they
land up in the root of the final jar files. But this means, during
development, loading the plugin fails since it looks for a
`plugin.properties` at the root of the plugin module, i.e., next to the
`src` folder.
1. For this, in the custom plugin manager class, we change where we look
for the `plugin.properties` file during development mode. In this mode,
we look at the `target/classes/plugin.properties` file, which is where
maven saves this file, taken from
`src/main/resources/plugin.properties`.
2. This also solves the duplication of the plugin properties that's
currently present, between `plugin.properties` and the `<properties>`
section of `pom.xml` files.
Here's the shade plugin's default execution and configuration, from
Spring Boot:
https://github.com/spring-projects/spring-boot/blob/v3.0.1/spring-boot-project/spring-boot-starters/spring-boot-starter-parent/build.gradle#L174.
|
