Commit Graph

27 Commits

Author SHA1 Message Date
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Apeksha Bhosale
4825ce2a2a
Show JS eval errors in evaluated value pane and debugger (#4463)
Co-authored-by: jsartisan <pawankumar2901@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-05-26 18:02:43 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Pawan Kumar
d814e780ed
Fix: Update chart from array to object (#3907)
* update structure of chart data

* update chart data

* update chart data structure

* remove array like validator

* remove log

* remove log

* widget utils + update tests for chart data validations

* update utils test

* add migrations

* remove unnecessary helper function

* remove unnecessary helper function

* update validation test cases

* WIP

* WIP 2

* Remove validationConfigMap from widget and add to properties

* Update data tree validator to get validation from the correct place

* Minor reference fixes

* Fix test mocks

* fix for bad setting of nested property path

* add test for migration for chart widget function

* fix test for widget utils

* remove unused import;

* remove unsued import

* update migration version

* remove console and add check if data is array

* fix custom fusion chart + validation not working issue

* move custom fusion chart config to chart data section

* remove console and unused import

* fix test

* fix property config test

* fix dynamicbinding path list in migration

* remove old chart validation

* remove old validation test

* fix widget prop utils test

* remove array codepath for widget utils

* fix utils test

* fix utils test

* fix prettier issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 16:05:59 +05:30
Nidhi
084faf8d54
Typo ¯\_(ツ)_/¯ (#3595) 2021-03-17 17:04:53 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057)
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Hetu Nandu
a885fc8d3b
Fix chart data migration issues (#3458) 2021-03-09 20:05:42 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-04 10:54:47 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
abhishek nayak
4048b81b2e
Update ChartDataControl.tsx 2021-01-18 18:47:50 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Hetu Nandu
b1c8008c3d Add null check for evaluated value in Chart Data Control (#1675)
Fixes: #1672, #1666
2020-11-11 17:28:26 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
Hetu Nandu
bf2b4efbfd
Fix for action execution (#1023) 2020-10-06 22:17:16 +05:30
Nikhil Nandagopal
ce628768bb
Fix/bindings (#554)
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval

* added a migration for older charts that have their data as strings

* flagged column actions as an action trigger to avoid evaluating it

* minor fix

* fixed chart fields disappearing

* added migration on update

* added migration to constructor

* added a fallback for first time renders

* removed migration from did update

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-16 13:41:24 +05:30
Nikhil Nandagopal
4995706679
Fix chart data evaluation (#548)
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval

* added a migration for older charts that have their data as strings

* flagged column actions as an action trigger to avoid evaluating it

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-15 22:24:15 +05:30
Hetu Nandu
38aafb5027
Fix embedded datasource path (#2)
* Refactor CodeMirror component to be more configurable and testable (hints, markings)
* Update the existing datasource path component
* Better text highlighting for JSON fields
* Case insensitive hinting in autocomplete
2020-07-01 15:31:07 +05:30
Hetu Nandu
c2213bd696 Evaluated value bug fixes 2020-06-11 11:03:16 +00:00
Hetu Nandu
cb2867069f Action creator evaluated value fixes 2020-06-10 12:16:50 +00:00
Hetu Nandu
e401844014 Fix Chart series data 2020-06-05 16:20:23 +00:00
Hetu Nandu
d9540f8927 Evaluated value popup 2020-06-04 13:49:22 +00:00
Vicky Bansal
747c3d5d8b Chart validations, Tabs add new tab issue fix 2020-05-29 06:07:56 +00:00
Vicky Bansal
fc5f417923 Fix/map issues 2020-05-07 10:51:37 +00:00
Vicky Bansal
1f9294b608 Fix/map tab issues 2020-04-29 10:29:02 +00:00
Nikhil Nandagopal
739ba35dc1 Feature/widgets 2020-04-15 11:42:11 +00:00